[8u] RFR+RFA 8200109: NMT: diff_malloc_site assert(early->flags() == current->flags(), "Must be the same memory type")

zgu at redhat.com zgu at redhat.com
Mon Feb 11 17:27:48 UTC 2019


On Mon, 2019-02-11 at 17:11 +0100, Aleksey Shipilev wrote:
> On 2/8/19 10:50 PM, zgu at redhat.com wrote:
> > JDK8u Webrev: http://cr.openjdk.java.net/~zgu/JDK-8200109-8u/webrev
> > .00/
> 
> The code change looks good. (...and I cannot give approvals to push).
> However, we should probably
> wait a few weeks before considering it for 8u, looking more testing
> in jdk/jdk. Also, jdk11u
> backport should happen first?
I have no problem with delaying backport. This patch is mainly to avoid
false-positive scenario of NMT/JcmdDetailDiff.java. 

JDK13 and JDK11  all have the test enabled, I did not find additional
bug report related it, so I guess it should not be a problem for JDK8u
neither.

-Zhengyu


> 
> Thanks,
> -Aleksey
> 


More information about the jdk8u-dev mailing list