8u/11u repo access and Jira changes

Langer, Christoph christoph.langer at sap.com
Tue Feb 26 19:41:39 UTC 2019


I'd rather second Andrew in this discussion.

Initially I also thought it might be more sensible to restrict the subset of people with commit permissions to jdk8u/jdk11u. But if I think more about it I rather think we should keep it open. At least try to get some experiences.

Here are my reasons:
- Look at how it works with the jdk/jdk12 repositories for upstream development. There, jdk12 got more and more restrictions applied and in fact it's virtually closed now at release candidate phase. But the repository is not closed, theoretically everybody could push
- If somebody pushes by mistake to the non dev repository, this can always be backouted
- I think some changes can/will still need to go to jdk11u first (e.g. certain test fixes, changes that Oracle promotes to 11.0.3-oracle, P1 issues that we approve). For these scenarios it would be beneficial if no restrictions apply to the set of allowed committers.
- process wise it's easier to handle

Best regards

> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
> Behalf Of Andrew Haley
> Sent: Dienstag, 26. Februar 2019 20:07
> To: Aleksey Shipilev <shade at redhat.com>; jdk-updates-
> dev at openjdk.java.net; jdk8u-dev at openjdk.java.net
> Subject: Re: 8u/11u repo access and Jira changes
> On 2/26/19 6:54 PM, Aleksey Shipilev wrote:
> > On 2/26/19 7:46 PM, Andrew Haley wrote:
> >> We have a group responsible for managing the release branch, and these
> >> could be the people with commit access to that tree. But I
> >> don't want to restrict that group necessarily to be the maintainers.
> >
> > I do want it, though.
> I am aware of that. However, I disgree, and I explained why, but this
> response does not address my reasons.
> > We would have lots of committers that come and push changesets to
> > update projects.
> I don't quite understand this sentence.
> > I would very much prefer that machines prohibit us from committing
> > (pun intended) mistakes that can be mechanically checked. Regular
> > Reviewers and Committers have no business pushing into stable tree,
> > and this should be mechanically forbidden. There is no need to
> > restrict the push privileges to stable tree to maintainers only, but
> > it should be restricted to some subset of users who have the need to
> > modify it.
> I don't object to that, as long as it's flexible enough to allow us
> quickly to authorize people to work on the release tree.
> > In other needs, trust people, but also set up processes so that they
> > cannot make simple mistakes.
> This seems to contradict your earlier statement. blocking access
> to only allow maintainers doesn't only prevent mistakes.
> --
> Andrew Haley
> Java Platform Lead Engineer
> Red Hat UK Ltd. <https://www.redhat.com>
> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

More information about the jdk8u-dev mailing list