Proposal for back-porting JFR to OpenJDK8u

[Andrey Petushkov]

In another thread Andrew is talking and asking questions regarding JFR integration. IMHO the status looks like:
- both Alibaba and Azul has reached understanding that current Azul's patch should be pushed as a basis for further work
- no one else has volunteered to formally review the patch
- apparently both Alibaba and Azul will review and further improve the code while working on missing features
with all above in mind, do we still need a formal review? (Andrew, what's your opinion?)

And yes, I've got a colleague with committer permission for jdk8u, so if jdk8u-incubator repos have inherited access list from jdk8u (Andrew, could you please suggest?) he can do that

Thanks,
Andrey

> On 27 Feb 2019, at 09:46, guangyu.zhu <guangyu.zhu at aliyun.com> wrote:
> 
> Hi Andrey,
> 
> I am not sure if Andrew H can assign us permission to submit patches to jdk8u-jfr-incubator repo. Maybe Mario can help clarify. I am not a submitter either. Usually my colleague will help me submit a patch. I think you can do the same.
> 
> Thanks,
> Guangyu
> 
> ------------------------------------------------------------------
> Sender:Andrey Petushkov <andrey at azul.com>
> Sent At:2019 Feb. 27 (Wed.) 16:26
> Recipient:guangyu.zhu <guangyu.zhu at aliyun.com>
> Cc:Mario Torre <neugens at redhat.com>; yumin qi <yumin.qi at gmail.com>; jdk8u-dev <jdk8u-dev at openjdk.java.net>; kingsum.chow <kingsum.chow at gmail.com>; denghui.ddh <denghui.ddh at antfin.com>
> Subject:Re: Proposal for back-porting JFR to OpenJDK8u
> 
> Hi Guangyu,
> 
> Yes, that would be of course easier to collaborate if the basis is in the common repo. However I assume some governing entity (Andrew H?) should approve the commit, 
> as well as somebody should execute that. I'm not a committer, cannot do that
> 
> Regards,
> Andrey
> 
> > On 27 Feb 2019, at 03:33, guangyu.zhu <guangyu.zhu at aliyun.com> wrote:
> > 
> > Hi Andrey,
> > 
> > Now that Mario has created the repo, I suggest that you commit the basline patch as soon as possible, and then Alibaba will merge the missing features including thread sampling, G1 heap summary and region types, biased locking events and so on...this will speed up the backport process. What do you think?
> > 
> > Thanks,
> > Guangyu
> > 
> > 
> > ------------------------------------------------------------------
> > Sender:Mario Torre <neugens at redhat.com>
> > Sent At:2019 Feb. 26 (Tue.) 22:00
> > Recipient:Andrey Petushkov <andrey at azul.com>
> > Cc:guangyu.zhu <guangyu.zhu at aliyun.com>; yumin qi <yumin.qi at gmail.com>; jdk8u-dev <jdk8u-dev at openjdk.java.net>; kingsum.chow <kingsum.chow at gmail.com>; denghui.ddh <denghui.ddh at antfin.com>
> > Subject:Re: Proposal for back-porting JFR to OpenJDK8u
> > 
> > On Tue, Feb 26, 2019 at 2:42 PM Andrey Petushkov <andrey at azul.com> wrote:
> > >
> > >
> > >
> > > On 26 Feb 2019, at 12:13, Mario Torre <neugens at redhat.com> wrote:
> > >
> > > > We are carrying analysis of what following JFR-related code changes to bring from jdk12+
> > >
> > > I don't think we should do that for every new baseline, I think integrating the platform changes from 11 to 8 is already a really big step, without endlessly backporting features from every other release down the line.
> > >
> > > We thought that it is a good idea to at watch them, at least to don't miss anything important. And given the number of such fixes happened in last 10 months it looks like having the JFR implementation open-sourced brought significant interest which possibly indicates there were number of bugs which deserve to be fixed
> > 
> > 
> > Yes, watching the changes is certainly good in the optic of searching
> > for bug (and security) fixes, I didn't mean to stop this effort, I'm
> > worried about backport features (like new events and perhaps APIs) to
> > 8 however.
> > >
> > >
> > > I also would like to proceed with the current patches before adding more to the table as this is already a quite difficult patch to properly review and test without thinking about changes in further releases.
> > >
> > > No problem, we can submit additional changes as a separate review requests so community can decide whether and what to take
> > 
> > Yes, exactly!
> > 
> > I would suggest to wait for your patch with the integrated
> > functionality and then we can proceed with a proper review cycle and
> > push into the incubator repository [1].
> > 
> > Cheers,
> > Mario
> > 
> > [1] https://hg.openjdk.java.net/jdk8u/jdk8u-jfr-incubator/
> > 
> > -- 
> > Mario Torre
> > Associate Manager, Software Engineering
> > Red Hat GmbH <https://www.redhat.com>
> > 9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898
> > 
>