RFR: [8u] JDK-8193255: Root Certificates should be stored in text format and assembled at build time

[Severin Gehwolf]

On Thu, 2020-01-30 at 04:37 +0000, Andrew John Hughes wrote:
> Updated in
> https://cr.openjdk.java.net/~andrew/openjdk8/8193255/jdk/webrev.02/

[...]
> >   50                 if (!fName.equals("README")) {
> >   51                     String alias = fName + " [jdk]";
> >   52                     try (InputStream fis = Files.newInputStream(p)) {
> >   53                         ks.setCertificateEntry(alias, cf.generateCertificate(fis));
> >   54                     }
> >   55                 }
> > 
> >   So judging by your explanation below this is intentional. Strictly speaking,
> >   doing a backport of JDK-8225392 would need to be aware of that. This should be
> >   OK as we need to account for JDK 7 bootstrap too and you said you are going to
> >   do JDK-8225392 backport as well.
> > 
> 
> What's intentional? Sorry, you've lost me here.

Removal of the try/catch block surrounding this code in the original
code.

[...]
> > Yes, we don't need JDK-8235142 in jdk8u in this case.
> 
> 8193255 is included in this webrev and I intend to list it in the
> commit. My point was that it's impossible to build anything without
> that, as neither bootstrap JDK has Path.of.

Works for me too.

> Let me know if this is now ok with these minor changes,

Looks good. Reviewed!

Thanks,
Severin