[8u] RFR: 8146215: (fs) java/nio/file/Files/probeContentType/Basic.java failed frequently on Solaris-sparc with Unexpected type: text/plain

Andrew Hughes gnu.andrew at redhat.com
Mon Jun 29 12:47:37 UTC 2020

On 26/06/2020 23:30, Alex Kashchenko wrote:
> Hi,
> Please review the backport of JDK-8146215 to 8u:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8146215
> 9 commit: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/44bb7c7997ca
> 8u webrev: https://cr.openjdk.java.net/~akasko/jdk8u/8146215/webrev.00/
> 8u code change is almost identical to 9, only copyright year is changed
> in AbstractFileTypeDetector.java. Test part doesn't apply cleanly,
> because probeContentType/Basic.java in 9 contains changes that are not
> in 8u (JDK-8129632 and others), it is adjusted for 8u. Testing: included
> test, jck:api/java_net;api/java_nio.

Hi Alex,

The class library code changes look fine.

For the testing, I think JDK-8150204 should at least be backported
first. It's a test-only change, and you're effectively doing that in
this patch, but uncredited. I can understand the reluctance to backport
the Mac OS X fix, JDK-8129632, so I'm happy for the 8150204 backport to
just take the testing changes from 8129632 as part of it, or work around
them as you have here.

Once 8150204 is in place, this backport should be close to the 11u version.

Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

More information about the jdk8u-dev mailing list