[8u] RFR: 8261952: Avoid converting path to vcruntime140.dll to short-style path

[Dmitry Cherepanov]

Hi Paul,

8201267 is about disabling warnings and I don't see a good justification for full backport of 8201267 (even if some of these warnings apply to 8u). The proposed patch fixes build failure (when 8u built with pre-installed VS 2017) and it's probably worth backporting it to 8u.

Thanks,

Dmitry

On 27.04.2021 23:17, Hohensee, Paul wrote:
> Why not backport 8201267?
>
> Thanks,
> Paul
>
> -----Original Message-----
> From: jdk8u-dev <jdk8u-dev-retn at openjdk.java.net> on behalf of Dmitry Cherepanov <dcherepanov at azul.com>
> Date: Thursday, February 18, 2021 at 4:59 AM
> To: "jdk8u-dev at openjdk.java.net" <jdk8u-dev at openjdk.java.net>
> Subject: [8u] RFR: 8261952: Avoid converting path to vcruntime140.dll to short-style path
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8261952
> Webrev: http://cr.openjdk.java.net/~dcherepanov/openjdk8u/8261952/webrev.v0/
>
> Please review the partial backport for Windows build with VS 2017.
> This is to avoid converting path to vcruntime140.dll  to short-style path (with vcrunt~1.dll)
>
> In JDK 11, it was fixed as a part of https://bugs.openjdk.java.net/browse/JDK-8201267
>   From original RFR: https://mail.openjdk.java.net/pipermail/build-dev/2018-April/021563.html
>
> * In toolchain_windows.m4, the BASIC_FIXUP_PATH was redundant as all
>     directories sent in here are already fixed. Calling it here messes up
>     the filename of the dll, which in VS2017 is more than 8 chars.
>
> Thanks,
>
> Dmitry
>
>