[8u] RFR: 8185934: keytool shows "Signature algorithm: SHA1withECDSA, -1-bit key"

Andrew Hughes gnu.andrew at redhat.com
Wed Jan 20 17:01:31 UTC 2021


On 11:57 Mon 11 Jan     , Severin Gehwolf wrote:
> Hi,
> 
> I'd like to backport this simple fix to OpenJDK 8u as it simplifies the
> backport of JDK-8172404 to 8u and the patch at hand is low risk. The
> JDK 8u patch is the same as the one for JDK 10, except for one context
> difference in keytool/Resources.java. The reason for this is that JDK-
> 8191137 got fixed in JDK 10 *after* JDK-8185934 and in JDK 8u it's the
> other way around. Other than that, the patch is identical. Please
> review.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8185934
> webrev: https://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8185934/jdk8/01/webrev/
> 
> Thoughts?
> 
> Thanks,
> Severin
> 

Looks fine (after moving the jarsigner parts of the patch to the end to compare
with the 11u version).

Not sure why the webrev is showing three bug IDs.

Anyway, please flag for approval.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222


More information about the jdk8u-dev mailing list