[8u] RFR: 8258373: Update the text handling in the JPasswordField

Alex Kashchenko akashche at redhat.com
Wed Oct 13 09:21:57 UTC 2021


Hi,

Please review a backport of JDK-8258373 to 8u:

Bug: https://bugs.openjdk.java.net/browse/JDK-8258373

Mainline commit:
https://github.com/openjdk/jdk/commit/7afb01dce966e4c00880711ef232af12af755b3a

8u webrev: https://cr.openjdk.java.net/~akasko/jdk8u/8258373/webrev.00/

Patch does not apply cleanly, changes besides paths reshuffling:

In JPasswordField::setText @BeanProperty is changed to @beaninfo;
description is preserved, but bound=false flag is excluded because the
same method in parent class does not have this flag (added in
JDK-4763438). It is not clear whether it may be better to add this
flag to the parent class or alternatively exclude all @beaninfo
changes.

In tests String::repeat usage is  replaced with Collections::nCopies.

TextBeanProperty test is excluded, it won't pass in 8u without
additional @beaninfo changes.

Testing: checked that added tests pass.

-- 
-Alex



More information about the jdk8u-dev mailing list