[jdk8u-dev] RFR: 8221988: add possibility to build with Visual Studio 2019 [v2]

Severin Gehwolf sgehwolf at openjdk.java.net
Fri Apr 8 17:04:42 UTC 2022


On Fri, 8 Apr 2022 16:26:22 GMT, Alexey Pavlyutkin <duke at openjdk.java.net> wrote:

>> Hi!
>> 
>> Please review backport of 8221988. This one opens a bunch of backports enabling support of VS2019. The 11u patch applied with the following changes:
>> 
>> - changes to absent documentation files skipped
>> - resolved baseline conflicts toolchain_windows.m4
>> 
>> Verification: `bash configure` under VS2019 prompt
>> Regression: `bash configure` under VS2017 prompt
>> 
>> @RealCLanger @mdoerr if you take a look at this I will be very grateful
>
> Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   rearrange valid VS versions

With which versions of Visual Studio has this been tested?

common/autoconf/toolchain_windows.m4 line 28:

> 26: ################################################################################
> 27: # The order of these defines the priority by which we try to find them.
> 28: VALID_VS_VERSIONS="2013 2015 2012 2010 2017 2019"

Order should be: `2010 2012 2013 2015 2017 2019`

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/33


More information about the jdk8u-dev mailing list