OpenJDK 8u332 Released
Andrew Hughes
gnu.andrew at redhat.com
Sun Apr 24 17:16:49 UTC 2022
On 20:40 Fri 22 Apr , Peter Tribble wrote:
> Hi,
>
> On Fri, Apr 22, 2022 at 6:20 PM Andrew Hughes <gnu.andrew at redhat.com> wrote:
>
> > We are pleased to announce the release of OpenJDK 8u332.
> >
> > The source tarball is available from:
> >
> > * https://openjdk-sources.osci.io/openjdk8/openjdk8u332-ga.tar.xz
> >
>
> Building from the tarball fails for me. (I'm on illumos, but I'm not sure
> it should
> make any difference given what I see.) The make just hangs silently. The
> problem
> appears to be that without any scm information the various SCM_ variables
> end
> up empty, and if they aren't quoted mess up the shell constructs. A patch
> that
> fixes the problem and allows the build to proceed (thanks to the OmniOS
> folks)
> follows, but I wonder if the release tarballs need to contain the scm tip
> file(s).
>
> diff -wpruN '--exclude=*.orig' a~/make/common/MakeBase.gmk
> a/make/common/MakeBase.gmk
> --- a~/make/common/MakeBase.gmk 1970-01-01 00:00:00
> +++ a/make/common/MakeBase.gmk 1970-01-01 00:00:00
> @@ -318,9 +318,9 @@ SCM_TIP_FILECMD := $(PRINTF) "$(SCM):%s"
> # Emit the scm:id pair to $@
> define GetSourceTips
> $(CD) $(SRC_ROOT) ; \
> - if [ -d $(SCM_DIR) -a "$(SCM_VERSION)" != "" ] ; then \
> + if [ -d "$(SCM_DIR)" -a "$(SCM_VERSION)" != "" ] ; then \
> $(ID_COMMAND) >> $@ ; \
> - elif [ -f $(SCM_TIP_FILENAME) ] ; then \
> + elif [ -f "$(SCM_TIP_FILENAME)" ] ; then \
> $(SCM_TIP_FILECMD) >> $@ ; \
> fi;
> $(PRINTF) "\n" >> $@
>
> Thanks,
>
I build the tarballs on several architectures before posting them,
though admittedly these are all Linux systems. I'm guessing Illumos is
an OpenSolaris variant? Each commit is tested on Linux, MacOS and
Windows as provided by GitHub now, but sadly we don't have any regular
testing on Solaris.
The line in question seems to be unique to the recent backport
of JDK-8210283 [0]. Did previous release tarballs work for you
(i.e. 8u322 and before)? Does a current Git checkout of
https://github.com/openjdk/jdk8u work?
The fix above suggests a problem with spaces in the filenames.
It'd be interesting to see build logs for the failure if you
have them.
[0] https://github.com/openjdk/jdk8u/commit/054b85b1f65254b2d3d2a1d343e14d8eabd1af40
Thanks,
--
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
More information about the jdk8u-dev
mailing list