[jdk8u-dev] Withdrawn: 8197859: VS2017 Complains about UINTPTR_MAX definition in globalDefinitions_VisCPP.hpp

[Alexey Pavlyutkin]

On Fri, 13 May 2022 08:31:52 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

> Hi! Please review another backport from MSVS2019 seria. This one fixes type declarations made by globalDefinitions_VisCPP.hpp. The patch from 11u applied with the following changes:
> 
> - inttypes.h is included conditionally under `_MSC_VER >= 1800` because the header was introduced only in MSVS 2013 but we have to keep support of the earlier MSVS versions 
> - the duplicates of declarations made in inttypes.h are not just removed but quoted with `_MSC_VER < 1800`
> - common\autoconf\generated-configure.sh is regenerated to add MSVS2019 recognition (I forgot to do that in https://urldefense.com/v3/__https://github.com/openjdk/jdk8u-dev/pull/33__;!!ACWV5N9M2RV99hQ!M4NnegcaHTEzTfkYdO7tglXK_4sQL7AV28eKEAQ-masKtB1LoqriuE8jTzUB-u1YmsfNIucxoKTEDNjdgQc$ )
> 
> Verification: 2019 build (both 32/64) now fails with 
> 
> ad_x86_64_pipeline.obj : error LNK2011: precompiled object not linked in; image may not run
> jvm.dll : fatal error LNK1120: 1 unresolved externals
> 
> error (to be fixed by backport of 8043492)
> 
> Regression: 2017/2013/2012/2010 full build - ok
> 
> @kimbarrett @dholmes-ora if you took a look at that it would be very much appreciated

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/58