[jdk8u-dev] RFR: 8251551: Use .md filename extension for README

George Adams duke at openjdk.org
Fri Jun 24 15:10:51 UTC 2022


On Fri, 24 Jun 2022 15:02:50 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> I think we need to bring in the changes to convert to markdown first (notably [JDK-8139668](https://bugs.openjdk.org/browse/JDK-8139668) and [JDK-8176509](https://bugs.openjdk.org/browse/JDK-8176509)) before doing this.

I hadn't seen those patches before, are they not focussed on the [README-builds.html](http://hg.openjdk.java.net/jdk8/jdk8/raw-file/tip/README-builds.html) file rather than the top-level `README` file? I'm not sure why one would block the other.

> Also, this patch looks to be removing the old file and adding a new one, when it should be a rename. That makes it hard to see what has actually changed.

That's the way the patch was applied from the top (see the original [commit](https://urldefense.com/v3/__https://github.com/openjdk/jdk/commit/6ed221cb9ad2e81d92dda0ef32095dda5d52cb85__;!!ACWV5N9M2RV99hQ!MmYNUhzflNfUpQVY2b6OJEEoTg2nbR6f4kN4TElpLorFx2Zl2yF-06MhoTZPLO0PQNKdHWUyViLpZiGzUvY$ )). I wouldn't like to change that now as it would be inconsistent with the other repos?

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/75


More information about the jdk8u-dev mailing list