RFR: JDK-8011180 : (xs) Remove obsolete scripts from make/scripts

[Paul Sandoz]

Hi Mike,

I think this is in general good move.

IMHO a separate repo for simple tools like webrev and jcheck seems a bit much. Do you think it would be worthwhile consolidating some code-tools repos?

Paul.

On Jan 10, 2014, at 1:12 AM, Mike Duigou <mike.duigou at oracle.com> wrote:

> Hello all;
> 
> This is a change which will no doubt come as a surprise to some. This change consists of removing two scripts:
> 
> make/scripts/hgforest.sh
> make/scripts/webrev.ksh
> 
> They are being removed for different reasons. hgforest.sh is being removed because it has been superseded by common/bin/hgforest.sh and bugs are only being fixed on the common/bin/hgforest.sh script. common/bin/hgforest.sh will soon sprout new features which prompts the timing of this change.
> 
> webrev.ksh is being removed because the script has been moved to another repository in the code tools project [1]. This is a consequence of exactly the same script being needed by quite a few repos. Essentially each set of OpenJDK repos would need to have the same changes applied and this is too much work, and a procedural hassle. So, even though you probably (finally) discarded your local webrev.ksh installation during jdk8 you'll once again need to maintain your own copy. I'm personally not terribly happy about this situation as it virtually ensures that most people will be using an out-of-date version of webrev but so far a better alternative has yet to be proposed. (I would like to suggest perhaps an openjdk tools tarball containing webrev, defpath, jcheck, jtreg but that's a separate discussion).
> 
> The current version of webrev is always available at [2].
> 
> The relatively straightforward webrev for this change:
> 
> http://cr.openjdk.java.net/~mduigou/JDK-8011180/0/webrev/
> 
> These removals will be backported to JDK8 at some point in the future and the webrev.ksh removal will be backported to JDK7.
> 
> Cheers,
> 
> Mike
> 
> [1] http://hg.openjdk.java.net/code-tools/webrev
> [2] http://hg.openjdk.java.net/code-tools/webrev/raw-file/tip/webrev.ksh