From shurailine at openjdk.java.net  Thu Dec  3 01:00:11 2020
From: shurailine at openjdk.java.net (Alexandre Iline)
Date: Thu, 3 Dec 2020 01:00:11 GMT
Subject: RFR: CODETOOLS-7902793: Fix IllegalMonitorStateException in
 JInternalFrameOperatorCloseTest
Message-ID: <onvuv72JqcBfvQxQYHcCAHGqZ_9zJ90Kxy4-8NXNr5k=.3dfde2ec-171e-48d7-b5db-1ac53ca21133@github.com>

What worked was to override setClosed(boolean) in JInternalFrame to not close the frame.

Also while inspecting the stack trace, I have discovered that the description is not passed down from JInternalFrameOperator.waitClosed()

-------------

Commit messages:
 - CODETOOLS-7902793: Fix IllegalMonitorStateException in JInternalFrameOperatorCloseTest

Changes: https://git.openjdk.java.net/jemmy-v2/pull/4/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jemmy-v2&pr=4&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-7902793
  Stats: 95 lines in 3 files changed: 36 ins; 44 del; 15 mod
  Patch: https://git.openjdk.java.net/jemmy-v2/pull/4.diff
  Fetch: git fetch https://git.openjdk.java.net/jemmy-v2 pull/4/head:pull/4

PR: https://git.openjdk.java.net/jemmy-v2/pull/4

From shurailine at openjdk.java.net  Thu Dec  3 01:00:12 2020
From: shurailine at openjdk.java.net (Alexandre Iline)
Date: Thu, 3 Dec 2020 01:00:12 GMT
Subject: RFR: CODETOOLS-7902793: Fix IllegalMonitorStateException in
 JInternalFrameOperatorCloseTest
In-Reply-To: <onvuv72JqcBfvQxQYHcCAHGqZ_9zJ90Kxy4-8NXNr5k=.3dfde2ec-171e-48d7-b5db-1ac53ca21133@github.com>
References: <onvuv72JqcBfvQxQYHcCAHGqZ_9zJ90Kxy4-8NXNr5k=.3dfde2ec-171e-48d7-b5db-1ac53ca21133@github.com>
Message-ID: <Q-FHoujAx9tKOtlCDMUdF18tKVj_Fot5AgLQLUMLFZk=.2fc3d83b-8d36-4138-9d89-7296f11a7e48@github.com>

On Thu, 3 Dec 2020 00:55:51 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

> What worked was to override setClosed(boolean) in JInternalFrame to not close the frame.
> 
> Also while inspecting the stack trace, I have discovered that the description is not passed down from JInternalFrameOperator.waitClosed()

@akolarkunnu @amresh_sahu, can you take a look?

-------------

PR: https://git.openjdk.java.net/jemmy-v2/pull/4

From github.com+72060147+amresh-sahu at openjdk.java.net  Mon Dec  7 05:08:31 2020
From: github.com+72060147+amresh-sahu at openjdk.java.net (Amresh Sahu)
Date: Mon, 7 Dec 2020 05:08:31 GMT
Subject: RFR: CODETOOLS-7902793: Fix IllegalMonitorStateException in
 JInternalFrameOperatorCloseTest [v4]
In-Reply-To: <4IJir6UHnfLQSEWRVREN9JVRNCXYJjpNxsRTgU5En1s=.65d618b8-1aec-4c38-86b5-36f48256ff2b@github.com>
References: <4IJir6UHnfLQSEWRVREN9JVRNCXYJjpNxsRTgU5En1s=.65d618b8-1aec-4c38-86b5-36f48256ff2b@github.com>
Message-ID: <z0oV4eA2UiRdc0WQfLIvCDz7Ge0Zt9z6a_Vd_8lOzbw=.87962aa3-6057-4a0b-b85f-98fb6f784105@github.com>

> IllegalMonitorStateException has been fixed.

Amresh Sahu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:

 - Merge pull request #1 from openjdk/master
   
   Update forked branch
 - Update JInternalFrameOperatorCloseTest.java
   
   Removed whitespace and tabs.
 - Update JInternalFrameOperatorCloseTest.java
   
   There were two scenarios one is happy path scenario where only closing internal frame was being tested and another was negative scenario where TimeoutExpiredException was expected so removed the negative test scenario.
 - Update JInternalFrameOperatorCloseTest.java
   
   Removed whitespace.
 - Update JInternalFrameOperatorCloseTest.java
   
   removed whitespaces.
 - Fixed issue CODETOOLS-7902793.

-------------

Changes:
  - all: https://git.openjdk.java.net/jemmy-v2/pull/3/files
  - new: https://git.openjdk.java.net/jemmy-v2/pull/3/files/13590425..7c671ac3

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jemmy-v2&pr=3&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jemmy-v2&pr=3&range=02-03

  Stats: 106 lines in 5 files changed: 100 ins; 2 del; 4 mod
  Patch: https://git.openjdk.java.net/jemmy-v2/pull/3.diff
  Fetch: git fetch https://git.openjdk.java.net/jemmy-v2 pull/3/head:pull/3

PR: https://git.openjdk.java.net/jemmy-v2/pull/3

From akolarkunnu at openjdk.java.net  Mon Dec  7 14:07:21 2020
From: akolarkunnu at openjdk.java.net (Abdul Kolarkunnu)
Date: Mon, 7 Dec 2020 14:07:21 GMT
Subject: RFR: CODETOOLS-7902793: Fix IllegalMonitorStateException in
 JInternalFrameOperatorCloseTest
In-Reply-To: <onvuv72JqcBfvQxQYHcCAHGqZ_9zJ90Kxy4-8NXNr5k=.3dfde2ec-171e-48d7-b5db-1ac53ca21133@github.com>
References: <onvuv72JqcBfvQxQYHcCAHGqZ_9zJ90Kxy4-8NXNr5k=.3dfde2ec-171e-48d7-b5db-1ac53ca21133@github.com>
Message-ID: <WtCrgt4Qe19A63S8gOlrKT20sHUGqvljuoGyt5a21x0=.42f288e2-455b-4d38-87f2-4b7de11cd89d@github.com>

On Thu, 3 Dec 2020 00:55:51 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

> What worked was to override setClosed(boolean) in JInternalFrame to not close the frame.
> 
> Also while inspecting the stack trace, I have discovered that the description is not passed down from JInternalFrameOperator.waitClosed()

test/org/netbeans/jemmy/operators/JInternalFrameOperatorCloseTest.java line 60:

> 58:         JemmyProperties.setCurrentDispatchingModel(
> 59:                 JemmyProperties.getCurrentDispatchingModel());
> 60:         internalFrame = new UncloseableInternalFrame("JInternalFrameOperatorTest", true, true, true, true);

Is it possible to make use of internalFrame.setClosable(false) API instead of overriding and having  a new class UncloseableInternalFrame.

-------------

PR: https://git.openjdk.java.net/jemmy-v2/pull/4

From github.com+72060147+amresh-sahu at openjdk.java.net  Mon Dec  7 14:33:21 2020
From: github.com+72060147+amresh-sahu at openjdk.java.net (Amresh Sahu)
Date: Mon, 7 Dec 2020 14:33:21 GMT
Subject: RFR: CODETOOLS-7902793: Fix IllegalMonitorStateException in
 JInternalFrameOperatorCloseTest
In-Reply-To: <onvuv72JqcBfvQxQYHcCAHGqZ_9zJ90Kxy4-8NXNr5k=.3dfde2ec-171e-48d7-b5db-1ac53ca21133@github.com>
References: <onvuv72JqcBfvQxQYHcCAHGqZ_9zJ90Kxy4-8NXNr5k=.3dfde2ec-171e-48d7-b5db-1ac53ca21133@github.com>
Message-ID: <Z5Fgcb1PRFH6LTrO_fr1s3ltFQGMi2Jdzu8SAiZro6E=.bd45e2a5-28aa-41f5-9540-ba667c02b968@github.com>

On Thu, 3 Dec 2020 00:55:51 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

> What worked was to override setClosed(boolean) in JInternalFrame to not close the frame.
> 
> Also while inspecting the stack trace, I have discovered that the description is not passed down from JInternalFrameOperator.waitClosed()

Not able to run the test due to NPE.

When close event is triggered by calling internalFrameOper.close(); JInternalFrame.doDefaultCloseAction() is called(). This method fires close property change event. Because we are closing the internal frame so this frame is removed from the desktop pane and when it is removed then its parent also set to null in Container.remove() method call.

I tested JInternalFrame add/remove workflow with Oracle's InternalFrameDemo class and It seems me valid. NPE is not a part of Product Bug.


java.lang.NullPointerException
	at org.netbeans.jemmy.ClassReference.<init>(ClassReference.java:51)
	at org.netbeans.jemmy.EventDispatcher.<init>(EventDispatcher.java:87)
	at org.netbeans.jemmy.operators.ComponentOperator.<init>(ComponentOperator.java:195)
	at org.netbeans.jemmy.operators.ContainerOperator.<init>(ContainerOperator.java:71)
	at org.netbeans.jemmy.operators.WindowOperator.<init>(WindowOperator.java:70)
	at org.netbeans.jemmy.util.DefaultVisualizer.makeVisible(DefaultVisualizer.java:211)
	at org.netbeans.jemmy.operators.ComponentOperator.makeComponentVisible(ComponentOperator.java:887)
	at org.netbeans.jemmy.operators.AbstractButtonOperator.push(AbstractButtonOperator.java:350)
	at org.netbeans.jemmy.drivers.windows.DefaultInternalFrameDriver.requestClose(DefaultInternalFrameDriver.java:59)
	at org.netbeans.jemmy.operators.JInternalFrameOperator.close(JInternalFrameOperator.java:581)
	at org.netbeans.jemmy.operators.JInternalFrameOperatorCloseTest.testClose(JInternalFrameOperatorCloseTest.java:99)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
	at org.testng.internal.TestInvoker.invokeMethod(TestInvoker.java:599)
	at org.testng.internal.TestInvoker.invokeTestMethod(TestInvoker.java:174)
	at org.testng.internal.MethodRunner.runInSequence(MethodRunner.java:46)
	at org.testng.internal.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:822)
	at org.testng.internal.TestInvoker.invokeTestMethods(TestInvoker.java:147)
	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:146)
	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:128)

-------------

PR: https://git.openjdk.java.net/jemmy-v2/pull/4

From shurailine at openjdk.java.net  Mon Dec  7 15:43:23 2020
From: shurailine at openjdk.java.net (Alexandre Iline)
Date: Mon, 7 Dec 2020 15:43:23 GMT
Subject: RFR: CODETOOLS-7902793: Fix IllegalMonitorStateException in
 JInternalFrameOperatorCloseTest
In-Reply-To: <WtCrgt4Qe19A63S8gOlrKT20sHUGqvljuoGyt5a21x0=.42f288e2-455b-4d38-87f2-4b7de11cd89d@github.com>
References: <onvuv72JqcBfvQxQYHcCAHGqZ_9zJ90Kxy4-8NXNr5k=.3dfde2ec-171e-48d7-b5db-1ac53ca21133@github.com>
 <WtCrgt4Qe19A63S8gOlrKT20sHUGqvljuoGyt5a21x0=.42f288e2-455b-4d38-87f2-4b7de11cd89d@github.com>
Message-ID: <gOrZRWkBhupc1H0tC9Ojjt2cgLWe9iZ-rkg-RMuvCKQ=.3ef9018c-8813-4320-89a6-5566bcf25d2f@github.com>

On Mon, 7 Dec 2020 14:04:06 GMT, Abdul Kolarkunnu <akolarkunnu at openjdk.org> wrote:

>> What worked was to override setClosed(boolean) in JInternalFrame to not close the frame.
>> 
>> Also while inspecting the stack trace, I have discovered that the description is not passed down from JInternalFrameOperator.waitClosed()
>
> test/org/netbeans/jemmy/operators/JInternalFrameOperatorCloseTest.java line 60:
> 
>> 58:         JemmyProperties.setCurrentDispatchingModel(
>> 59:                 JemmyProperties.getCurrentDispatchingModel());
>> 60:         internalFrame = new UncloseableInternalFrame("JInternalFrameOperatorTest", true, true, true, true);
> 
> Is it possible to make use of internalFrame.setClosable(false) API instead of overriding and having  a new class UncloseableInternalFrame.

setClosable(boolean) only removes the close button on the window header. It does not stop window to be closed when done through the API. So, no.

-------------

PR: https://git.openjdk.java.net/jemmy-v2/pull/4

From shurailine at openjdk.java.net  Tue Dec  8 01:10:17 2020
From: shurailine at openjdk.java.net (Alexandre Iline)
Date: Tue, 8 Dec 2020 01:10:17 GMT
Subject: RFR: CODETOOLS-7902793: Fix IllegalMonitorStateException in
 JInternalFrameOperatorCloseTest
In-Reply-To: <Z5Fgcb1PRFH6LTrO_fr1s3ltFQGMi2Jdzu8SAiZro6E=.bd45e2a5-28aa-41f5-9540-ba667c02b968@github.com>
References: <onvuv72JqcBfvQxQYHcCAHGqZ_9zJ90Kxy4-8NXNr5k=.3dfde2ec-171e-48d7-b5db-1ac53ca21133@github.com>
 <Z5Fgcb1PRFH6LTrO_fr1s3ltFQGMi2Jdzu8SAiZro6E=.bd45e2a5-28aa-41f5-9540-ba667c02b968@github.com>
Message-ID: <BKAmOISgvnm57XBx2l64x45YwKFJq9_gLsnHxImFYhY=.c09624df-64f0-48a6-99f5-eb2d03998955@github.com>

On Mon, 7 Dec 2020 14:30:30 GMT, Amresh Sahu <github.com+72060147+amresh-sahu at openjdk.org> wrote:

>> What worked was to override setClosed(boolean) in JInternalFrame to not close the frame.
>> 
>> Also while inspecting the stack trace, I have discovered that the description is not passed down from JInternalFrameOperator.waitClosed()
>
> Not able to run the test due to NPE.
> 
> When close event is triggered by calling internalFrameOper.close(); JInternalFrame.doDefaultCloseAction() is called(). This method fires close property change event. Because we are closing the internal frame so this frame is removed from the desktop pane and when it is removed then its parent also set to null in Container.remove() method call.
> 
> I tested JInternalFrame add/remove workflow with Oracle's InternalFrameDemo class and It seems me valid. NPE is not a part of Product Bug.
> 
> 
> java.lang.NullPointerException
> 	at org.netbeans.jemmy.ClassReference.<init>(ClassReference.java:51)
> 	at org.netbeans.jemmy.EventDispatcher.<init>(EventDispatcher.java:87)
> 	at org.netbeans.jemmy.operators.ComponentOperator.<init>(ComponentOperator.java:195)
> 	at org.netbeans.jemmy.operators.ContainerOperator.<init>(ContainerOperator.java:71)
> 	at org.netbeans.jemmy.operators.WindowOperator.<init>(WindowOperator.java:70)
> 	at org.netbeans.jemmy.util.DefaultVisualizer.makeVisible(DefaultVisualizer.java:211)
> 	at org.netbeans.jemmy.operators.ComponentOperator.makeComponentVisible(ComponentOperator.java:887)
> 	at org.netbeans.jemmy.operators.AbstractButtonOperator.push(AbstractButtonOperator.java:350)
> 	at org.netbeans.jemmy.drivers.windows.DefaultInternalFrameDriver.requestClose(DefaultInternalFrameDriver.java:59)
> 	at org.netbeans.jemmy.operators.JInternalFrameOperator.close(JInternalFrameOperator.java:581)
> 	at org.netbeans.jemmy.operators.JInternalFrameOperatorCloseTest.testClose(JInternalFrameOperatorCloseTest.java:99)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
> 	at org.testng.internal.TestInvoker.invokeMethod(TestInvoker.java:599)
> 	at org.testng.internal.TestInvoker.invokeTestMethod(TestInvoker.java:174)
> 	at org.testng.internal.MethodRunner.runInSequence(MethodRunner.java:46)
> 	at org.testng.internal.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:822)
> 	at org.testng.internal.TestInvoker.invokeTestMethods(TestInvoker.java:147)
> 	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:146)
> 	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:128)

Thank you, @amresh-sahu, for the analysis. Like we discussed, I can not reproduce this problem locally. But I think I have enough to work on this.

-------------

PR: https://git.openjdk.java.net/jemmy-v2/pull/4

From shurailine at openjdk.java.net  Tue Dec  8 02:04:29 2020
From: shurailine at openjdk.java.net (Alexandre Iline)
Date: Tue, 8 Dec 2020 02:04:29 GMT
Subject: RFR: CODETOOLS-7902793: Fix IllegalMonitorStateException in
 JInternalFrameOperatorCloseTest [v2]
In-Reply-To: <onvuv72JqcBfvQxQYHcCAHGqZ_9zJ90Kxy4-8NXNr5k=.3dfde2ec-171e-48d7-b5db-1ac53ca21133@github.com>
References: <onvuv72JqcBfvQxQYHcCAHGqZ_9zJ90Kxy4-8NXNr5k=.3dfde2ec-171e-48d7-b5db-1ac53ca21133@github.com>
Message-ID: <ZqDZTn3GMwcrxT_M9eFDs3GWBIakXxgZJLgnVNXz_NY=.54705c40-bf3c-4ef1-b71b-e29f27c0676e@github.com>

> What worked was to override setClosed(boolean) in JInternalFrame to not close the frame.
> 
> Also while inspecting the stack trace, I have discovered that the description is not passed down from JInternalFrameOperator.waitClosed()

Alexandre Iline has updated the pull request incrementally with one additional commit since the last revision:

  closing of the internal frame is actually unnecessary, as the windoe is closed in the teardown anyway

-------------

Changes:
  - all: https://git.openjdk.java.net/jemmy-v2/pull/4/files
  - new: https://git.openjdk.java.net/jemmy-v2/pull/4/files/9d2c1199..bc4a2b55

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jemmy-v2&pr=4&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jemmy-v2&pr=4&range=00-01

  Stats: 4 lines in 1 file changed: 0 ins; 4 del; 0 mod
  Patch: https://git.openjdk.java.net/jemmy-v2/pull/4.diff
  Fetch: git fetch https://git.openjdk.java.net/jemmy-v2 pull/4/head:pull/4

PR: https://git.openjdk.java.net/jemmy-v2/pull/4

From shurailine at openjdk.java.net  Tue Dec  8 02:12:20 2020
From: shurailine at openjdk.java.net (Alexandre Iline)
Date: Tue, 8 Dec 2020 02:12:20 GMT
Subject: RFR: CODETOOLS-7902793: Fix IllegalMonitorStateException in
 JInternalFrameOperatorCloseTest [v2]
In-Reply-To: <BKAmOISgvnm57XBx2l64x45YwKFJq9_gLsnHxImFYhY=.c09624df-64f0-48a6-99f5-eb2d03998955@github.com>
References: <onvuv72JqcBfvQxQYHcCAHGqZ_9zJ90Kxy4-8NXNr5k=.3dfde2ec-171e-48d7-b5db-1ac53ca21133@github.com>
 <Z5Fgcb1PRFH6LTrO_fr1s3ltFQGMi2Jdzu8SAiZro6E=.bd45e2a5-28aa-41f5-9540-ba667c02b968@github.com>
 <BKAmOISgvnm57XBx2l64x45YwKFJq9_gLsnHxImFYhY=.c09624df-64f0-48a6-99f5-eb2d03998955@github.com>
Message-ID: <AUEJpppG7hSk6mn7KGjTS40HsF0nFDeHa5BhcQptCog=.b252ad07-70d5-4481-a804-96b0c3f0484b@github.com>

On Tue, 8 Dec 2020 01:07:59 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

>> Not able to run the test due to NPE.
>> 
>> When close event is triggered by calling internalFrameOper.close(); JInternalFrame.doDefaultCloseAction() is called(). This method fires close property change event. Because we are closing the internal frame so this frame is removed from the desktop pane and when it is removed then its parent also set to null in Container.remove() method call.
>> 
>> I tested JInternalFrame add/remove workflow with Oracle's InternalFrameDemo class and It seems me valid. NPE is not a part of Product Bug.
>> 
>> 
>> java.lang.NullPointerException
>> 	at org.netbeans.jemmy.ClassReference.<init>(ClassReference.java:51)
>> 	at org.netbeans.jemmy.EventDispatcher.<init>(EventDispatcher.java:87)
>> 	at org.netbeans.jemmy.operators.ComponentOperator.<init>(ComponentOperator.java:195)
>> 	at org.netbeans.jemmy.operators.ContainerOperator.<init>(ContainerOperator.java:71)
>> 	at org.netbeans.jemmy.operators.WindowOperator.<init>(WindowOperator.java:70)
>> 	at org.netbeans.jemmy.util.DefaultVisualizer.makeVisible(DefaultVisualizer.java:211)
>> 	at org.netbeans.jemmy.operators.ComponentOperator.makeComponentVisible(ComponentOperator.java:887)
>> 	at org.netbeans.jemmy.operators.AbstractButtonOperator.push(AbstractButtonOperator.java:350)
>> 	at org.netbeans.jemmy.drivers.windows.DefaultInternalFrameDriver.requestClose(DefaultInternalFrameDriver.java:59)
>> 	at org.netbeans.jemmy.operators.JInternalFrameOperator.close(JInternalFrameOperator.java:581)
>> 	at org.netbeans.jemmy.operators.JInternalFrameOperatorCloseTest.testClose(JInternalFrameOperatorCloseTest.java:99)
>> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>> 	at java.lang.reflect.Method.invoke(Method.java:498)
>> 	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
>> 	at org.testng.internal.TestInvoker.invokeMethod(TestInvoker.java:599)
>> 	at org.testng.internal.TestInvoker.invokeTestMethod(TestInvoker.java:174)
>> 	at org.testng.internal.MethodRunner.runInSequence(MethodRunner.java:46)
>> 	at org.testng.internal.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:822)
>> 	at org.testng.internal.TestInvoker.invokeTestMethods(TestInvoker.java:147)
>> 	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:146)
>> 	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:128)
>
> Thank you, @amresh-sahu, for the analysis. Like we discussed, I can not reproduce this problem locally. But I think I have enough to work on this.

The exception was actually coming from the finally block where the test attempts to close an internal frame which  acts absolutely normally (with field done been set to true). That, probably, means that there is something wrong in InternalFrameOperator.close(). Which is not related to this test, as this test is only supposed to test that waiting happens if the internal windows is not closing.
I have therefore removed internal frame closing at the end. It was unnecessary in the first place, as the test disposes the container window anyway.
The problem of the NPE coming from internal frame closing happening because the internal frame does not have a parent, should still be resolved. @amresh-sahu, can you be so kind file a separate bug on that with all the details you can provide? If you can create a standalone scenario for that, it would be great.

-------------

PR: https://git.openjdk.java.net/jemmy-v2/pull/4

From shurailine at openjdk.java.net  Tue Dec  8 02:12:20 2020
From: shurailine at openjdk.java.net (Alexandre Iline)
Date: Tue, 8 Dec 2020 02:12:20 GMT
Subject: RFR: CODETOOLS-7902793: Fix IllegalMonitorStateException in
 JInternalFrameOperatorCloseTest [v2]
In-Reply-To: <Z5Fgcb1PRFH6LTrO_fr1s3ltFQGMi2Jdzu8SAiZro6E=.bd45e2a5-28aa-41f5-9540-ba667c02b968@github.com>
References: <onvuv72JqcBfvQxQYHcCAHGqZ_9zJ90Kxy4-8NXNr5k=.3dfde2ec-171e-48d7-b5db-1ac53ca21133@github.com>
 <Z5Fgcb1PRFH6LTrO_fr1s3ltFQGMi2Jdzu8SAiZro6E=.bd45e2a5-28aa-41f5-9540-ba667c02b968@github.com>
Message-ID: <MGdwEIYf6U13NfPAnfB-JiFbZV8MDXQ1jwTTNzJf5Gc=.59e90c26-b160-4229-b810-2bdc38922e8c@github.com>

On Mon, 7 Dec 2020 14:30:30 GMT, Amresh Sahu <github.com+72060147+amresh-sahu at openjdk.org> wrote:

>> Alexandre Iline has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   closing of the internal frame is actually unnecessary, as the windoe is closed in the teardown anyway
>
> Not able to run the test due to NPE.
> 
> When close event is triggered by calling internalFrameOper.close(); JInternalFrame.doDefaultCloseAction() is called(). This method fires close property change event. Because we are closing the internal frame so this frame is removed from the desktop pane and when it is removed then its parent also set to null in Container.remove() method call.
> 
> I tested JInternalFrame add/remove workflow with Oracle's InternalFrameDemo class and It seems me valid. NPE is not a part of Product Bug.
> 
> 
> java.lang.NullPointerException
> 	at org.netbeans.jemmy.ClassReference.<init>(ClassReference.java:51)
> 	at org.netbeans.jemmy.EventDispatcher.<init>(EventDispatcher.java:87)
> 	at org.netbeans.jemmy.operators.ComponentOperator.<init>(ComponentOperator.java:195)
> 	at org.netbeans.jemmy.operators.ContainerOperator.<init>(ContainerOperator.java:71)
> 	at org.netbeans.jemmy.operators.WindowOperator.<init>(WindowOperator.java:70)
> 	at org.netbeans.jemmy.util.DefaultVisualizer.makeVisible(DefaultVisualizer.java:211)
> 	at org.netbeans.jemmy.operators.ComponentOperator.makeComponentVisible(ComponentOperator.java:887)
> 	at org.netbeans.jemmy.operators.AbstractButtonOperator.push(AbstractButtonOperator.java:350)
> 	at org.netbeans.jemmy.drivers.windows.DefaultInternalFrameDriver.requestClose(DefaultInternalFrameDriver.java:59)
> 	at org.netbeans.jemmy.operators.JInternalFrameOperator.close(JInternalFrameOperator.java:581)
> 	at org.netbeans.jemmy.operators.JInternalFrameOperatorCloseTest.testClose(JInternalFrameOperatorCloseTest.java:99)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
> 	at org.testng.internal.TestInvoker.invokeMethod(TestInvoker.java:599)
> 	at org.testng.internal.TestInvoker.invokeTestMethod(TestInvoker.java:174)
> 	at org.testng.internal.MethodRunner.runInSequence(MethodRunner.java:46)
> 	at org.testng.internal.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:822)
> 	at org.testng.internal.TestInvoker.invokeTestMethods(TestInvoker.java:147)
> 	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:146)
> 	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:128)

@amresh-sahu , to make sure, can you run the test with the latest changes?

-------------

PR: https://git.openjdk.java.net/jemmy-v2/pull/4

From shurailine at openjdk.java.net  Tue Dec  8 03:28:18 2020
From: shurailine at openjdk.java.net (Alexandre Iline)
Date: Tue, 8 Dec 2020 03:28:18 GMT
Subject: RFR: WIP: CODETOOLS-7902793: Fix IllegalMonitorStateException in
 JInternalFrameOperatorCloseTest [v2]
In-Reply-To: <Z5Fgcb1PRFH6LTrO_fr1s3ltFQGMi2Jdzu8SAiZro6E=.bd45e2a5-28aa-41f5-9540-ba667c02b968@github.com>
References: <onvuv72JqcBfvQxQYHcCAHGqZ_9zJ90Kxy4-8NXNr5k=.3dfde2ec-171e-48d7-b5db-1ac53ca21133@github.com>
 <Z5Fgcb1PRFH6LTrO_fr1s3ltFQGMi2Jdzu8SAiZro6E=.bd45e2a5-28aa-41f5-9540-ba667c02b968@github.com>
Message-ID: <VaCtraFx2HOEYk_4VBsDOHZ43gqBI0SUxqjZnRbZQ2w=.432b34e2-8c77-46b5-95ca-88294e086b80@github.com>

On Mon, 7 Dec 2020 14:30:30 GMT, Amresh Sahu <github.com+72060147+amresh-sahu at openjdk.org> wrote:

>> Alexandre Iline has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   closing of the internal frame is actually unnecessary, as the windoe is closed in the teardown anyway
>
> Not able to run the test due to NPE.
> 
> When close event is triggered by calling internalFrameOper.close(); JInternalFrame.doDefaultCloseAction() is called(). This method fires close property change event. Because we are closing the internal frame so this frame is removed from the desktop pane and when it is removed then its parent also set to null in Container.remove() method call.
> 
> I tested JInternalFrame add/remove workflow with Oracle's InternalFrameDemo class and It seems me valid. NPE is not a part of Product Bug.
> 
> 
> java.lang.NullPointerException
> 	at org.netbeans.jemmy.ClassReference.<init>(ClassReference.java:51)
> 	at org.netbeans.jemmy.EventDispatcher.<init>(EventDispatcher.java:87)
> 	at org.netbeans.jemmy.operators.ComponentOperator.<init>(ComponentOperator.java:195)
> 	at org.netbeans.jemmy.operators.ContainerOperator.<init>(ContainerOperator.java:71)
> 	at org.netbeans.jemmy.operators.WindowOperator.<init>(WindowOperator.java:70)
> 	at org.netbeans.jemmy.util.DefaultVisualizer.makeVisible(DefaultVisualizer.java:211)
> 	at org.netbeans.jemmy.operators.ComponentOperator.makeComponentVisible(ComponentOperator.java:887)
> 	at org.netbeans.jemmy.operators.AbstractButtonOperator.push(AbstractButtonOperator.java:350)
> 	at org.netbeans.jemmy.drivers.windows.DefaultInternalFrameDriver.requestClose(DefaultInternalFrameDriver.java:59)
> 	at org.netbeans.jemmy.operators.JInternalFrameOperator.close(JInternalFrameOperator.java:581)
> 	at org.netbeans.jemmy.operators.JInternalFrameOperatorCloseTest.testClose(JInternalFrameOperatorCloseTest.java:99)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
> 	at org.testng.internal.TestInvoker.invokeMethod(TestInvoker.java:599)
> 	at org.testng.internal.TestInvoker.invokeTestMethod(TestInvoker.java:174)
> 	at org.testng.internal.MethodRunner.runInSequence(MethodRunner.java:46)
> 	at org.testng.internal.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:822)
> 	at org.testng.internal.TestInvoker.invokeTestMethods(TestInvoker.java:147)
> 	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:146)
> 	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:128)

As we have discovered with @amresh-sahu , it does not work in his environment.

-------------

PR: https://git.openjdk.java.net/jemmy-v2/pull/4

From shurailine at openjdk.java.net  Tue Dec  8 03:51:31 2020
From: shurailine at openjdk.java.net (Alexandre Iline)
Date: Tue, 8 Dec 2020 03:51:31 GMT
Subject: RFR: CODETOOLS-7902793: Fix IllegalMonitorStateException in
 JInternalFrameOperatorCloseTest [v3]
In-Reply-To: <onvuv72JqcBfvQxQYHcCAHGqZ_9zJ90Kxy4-8NXNr5k=.3dfde2ec-171e-48d7-b5db-1ac53ca21133@github.com>
References: <onvuv72JqcBfvQxQYHcCAHGqZ_9zJ90Kxy4-8NXNr5k=.3dfde2ec-171e-48d7-b5db-1ac53ca21133@github.com>
Message-ID: <CtulWnW2sTYIGH31WCJ-N3ZXbXskjloOR-V2wvrZHGU=.10a0f7e7-cdbf-47b1-a7ce-5425c7f02859@github.com>

> What worked was to override setClosed(boolean) in JInternalFrame to not close the frame.
> 
> Also while inspecting the stack trace, I have discovered that the description is not passed down from JInternalFrameOperator.waitClosed()

Alexandre Iline has updated the pull request incrementally with one additional commit since the last revision:

  much easier to override the driver!

-------------

Changes:
  - all: https://git.openjdk.java.net/jemmy-v2/pull/4/files
  - new: https://git.openjdk.java.net/jemmy-v2/pull/4/files/bc4a2b55..e7263355

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jemmy-v2&pr=4&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jemmy-v2&pr=4&range=01-02

  Stats: 55 lines in 1 file changed: 40 ins; 14 del; 1 mod
  Patch: https://git.openjdk.java.net/jemmy-v2/pull/4.diff
  Fetch: git fetch https://git.openjdk.java.net/jemmy-v2 pull/4/head:pull/4

PR: https://git.openjdk.java.net/jemmy-v2/pull/4

From github.com+72060147+amresh-sahu at openjdk.java.net  Tue Dec  8 04:06:18 2020
From: github.com+72060147+amresh-sahu at openjdk.java.net (Amresh Sahu)
Date: Tue, 8 Dec 2020 04:06:18 GMT
Subject: RFR: CODETOOLS-7902793: Fix IllegalMonitorStateException in
 JInternalFrameOperatorCloseTest [v3]
In-Reply-To: <CtulWnW2sTYIGH31WCJ-N3ZXbXskjloOR-V2wvrZHGU=.10a0f7e7-cdbf-47b1-a7ce-5425c7f02859@github.com>
References: <onvuv72JqcBfvQxQYHcCAHGqZ_9zJ90Kxy4-8NXNr5k=.3dfde2ec-171e-48d7-b5db-1ac53ca21133@github.com>
 <CtulWnW2sTYIGH31WCJ-N3ZXbXskjloOR-V2wvrZHGU=.10a0f7e7-cdbf-47b1-a7ce-5425c7f02859@github.com>
Message-ID: <K-ylDpHFJZNwWUdhBTyvkUJ4n_c8iy7xK8BF2aARikM=.db78ee89-0972-4a29-8dea-99866dba31b1@github.com>

On Tue, 8 Dec 2020 03:51:31 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

>> What worked was to override setClosed(boolean) in JInternalFrame to not close the frame.
>> 
>> Also while inspecting the stack trace, I have discovered that the description is not passed down from JInternalFrameOperator.waitClosed()
>
> Alexandre Iline has updated the pull request incrementally with one additional commit since the last revision:
> 
>   much easier to override the driver!

Changes look fine and these are working as expected.

-------------

PR: https://git.openjdk.java.net/jemmy-v2/pull/4

From akolarkunnu at openjdk.java.net  Tue Dec  8 07:23:18 2020
From: akolarkunnu at openjdk.java.net (Abdul Kolarkunnu)
Date: Tue, 8 Dec 2020 07:23:18 GMT
Subject: RFR: CODETOOLS-7902793: Fix IllegalMonitorStateException in
 JInternalFrameOperatorCloseTest [v3]
In-Reply-To: <CtulWnW2sTYIGH31WCJ-N3ZXbXskjloOR-V2wvrZHGU=.10a0f7e7-cdbf-47b1-a7ce-5425c7f02859@github.com>
References: <onvuv72JqcBfvQxQYHcCAHGqZ_9zJ90Kxy4-8NXNr5k=.3dfde2ec-171e-48d7-b5db-1ac53ca21133@github.com>
 <CtulWnW2sTYIGH31WCJ-N3ZXbXskjloOR-V2wvrZHGU=.10a0f7e7-cdbf-47b1-a7ce-5425c7f02859@github.com>
Message-ID: <Rb9gCLvte6WR5_dmUi27mnwswhxbMcep9ryZAXtbfZg=.aa384d99-2608-4908-a6b5-48433f1706ce@github.com>

On Tue, 8 Dec 2020 03:51:31 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

>> What worked was to override setClosed(boolean) in JInternalFrame to not close the frame.
>> 
>> Also while inspecting the stack trace, I have discovered that the description is not passed down from JInternalFrameOperator.waitClosed()
>
> Alexandre Iline has updated the pull request incrementally with one additional commit since the last revision:
> 
>   much easier to override the driver!

Looks good

Looks good

-------------

PR: https://git.openjdk.java.net/jemmy-v2/pull/4Marked as reviewed by akolarkunnu (Committer).

From shurailine at openjdk.java.net  Tue Dec 15 01:26:03 2020
From: shurailine at openjdk.java.net (Alexandre Iline)
Date: Tue, 15 Dec 2020 01:26:03 GMT
Subject: Integrated: CODETOOLS-7902793: Fix IllegalMonitorStateException in
 JInternalFrameOperatorCloseTest
In-Reply-To: <onvuv72JqcBfvQxQYHcCAHGqZ_9zJ90Kxy4-8NXNr5k=.3dfde2ec-171e-48d7-b5db-1ac53ca21133@github.com>
References: <onvuv72JqcBfvQxQYHcCAHGqZ_9zJ90Kxy4-8NXNr5k=.3dfde2ec-171e-48d7-b5db-1ac53ca21133@github.com>
Message-ID: <m-KG334rUY_bZ9mG1ir1qc6nOohWT73WMS6My_2WwzI=.500b7436-c513-474b-8c87-4cf3a4178745@github.com>

On Thu, 3 Dec 2020 00:55:51 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

> What worked was to override setClosed(boolean) in JInternalFrame to not close the frame.
> 
> Also while inspecting the stack trace, I have discovered that the description is not passed down from JInternalFrameOperator.waitClosed()

This pull request has now been integrated.

Changeset: 94612e2e
Author:    Alexandre Iline <shurailine at openjdk.org>
URL:       https://git.openjdk.java.net/jemmy-v2/commit/94612e2e
Stats:     89 lines in 3 files changed: 36 ins; 22 del; 31 mod

7902793: Fix IllegalMonitorStateException in JInternalFrameOperatorCloseTest

Reviewed-by: akolarkunnu

-------------

PR: https://git.openjdk.java.net/jemmy-v2/pull/4

From shurailine at openjdk.java.net  Wed Dec 16 01:51:10 2020
From: shurailine at openjdk.java.net (Alexandre Iline)
Date: Wed, 16 Dec 2020 01:51:10 GMT
Subject: RFR: CODETOOLS-7902811: Add accessible name and description to the
 dump
Message-ID: <xHiyu_VJ_-PuypqCeUHcT2ceMUODuvK1fwH0sRvMSp4=.1dff9ff9-2f43-411d-b82f-e7bbf8c2bed1@github.com>

Accessible name and description are useful to identify components in the hierarchy.

-------------

Commit messages:
 - Updating copyright years to sync with JDK repo.
 - CODETOOLS-7902811: Add accessible name and description to the dump

Changes: https://git.openjdk.java.net/jemmy-v2/pull/5/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jemmy-v2&pr=5&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-7902811
  Stats: 92 lines in 8 files changed: 84 ins; 0 del; 8 mod
  Patch: https://git.openjdk.java.net/jemmy-v2/pull/5.diff
  Fetch: git fetch https://git.openjdk.java.net/jemmy-v2 pull/5/head:pull/5

PR: https://git.openjdk.java.net/jemmy-v2/pull/5

From shurailine at openjdk.java.net  Wed Dec 16 01:51:10 2020
From: shurailine at openjdk.java.net (Alexandre Iline)
Date: Wed, 16 Dec 2020 01:51:10 GMT
Subject: RFR: CODETOOLS-7902811: Add accessible name and description to
 the dump
In-Reply-To: <xHiyu_VJ_-PuypqCeUHcT2ceMUODuvK1fwH0sRvMSp4=.1dff9ff9-2f43-411d-b82f-e7bbf8c2bed1@github.com>
References: <xHiyu_VJ_-PuypqCeUHcT2ceMUODuvK1fwH0sRvMSp4=.1dff9ff9-2f43-411d-b82f-e7bbf8c2bed1@github.com>
Message-ID: <5DnaRUg4IuPg1HJUnVtcmB4Pbc3i3-7IfN4YJmJLtXo=.fb9f1628-22ee-4c6e-b154-ca3f08e282fa@github.com>

On Wed, 16 Dec 2020 01:43:12 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

> Accessible name and description are useful to identify components in the hierarchy.

@amresh-sahu?

-------------

PR: https://git.openjdk.java.net/jemmy-v2/pull/5

From github.com+72060147+amresh-sahu at openjdk.java.net  Wed Dec 16 04:38:03 2020
From: github.com+72060147+amresh-sahu at openjdk.java.net (Amresh Sahu)
Date: Wed, 16 Dec 2020 04:38:03 GMT
Subject: RFR: CODETOOLS-7902811: Add accessible name and description to
 the dump
In-Reply-To: <5DnaRUg4IuPg1HJUnVtcmB4Pbc3i3-7IfN4YJmJLtXo=.fb9f1628-22ee-4c6e-b154-ca3f08e282fa@github.com>
References: <xHiyu_VJ_-PuypqCeUHcT2ceMUODuvK1fwH0sRvMSp4=.1dff9ff9-2f43-411d-b82f-e7bbf8c2bed1@github.com>
 <5DnaRUg4IuPg1HJUnVtcmB4Pbc3i3-7IfN4YJmJLtXo=.fb9f1628-22ee-4c6e-b154-ca3f08e282fa@github.com>
Message-ID: <dihLkLS2u25LncEJ2lC312eAqJg4VyBRbbUFYmeAPvA=.a201936d-fccf-4354-a517-049fbd90ce2c@github.com>

On Wed, 16 Dec 2020 01:46:00 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

>> Accessible name and description are useful to identify components in the hierarchy.
>
> @amresh-sahu?

LGTM.

-------------

PR: https://git.openjdk.java.net/jemmy-v2/pull/5

From duke at openjdk.java.net  Wed Dec 16 16:27:41 2020
From: duke at openjdk.java.net (duke)
Date: Wed, 16 Dec 2020 16:27:41 GMT
Subject: git: openjdk/jemmy-v2: CODETOOLS-7902811: Add accessible name and
 description to the dump (#5)
Message-ID: <ce861462-f58f-4031-90cb-bbef659414b3@openjdk.java.net>

Changeset: bc246f7a
Author:    Alexander Ilin <alexandre.iline at oracle.com>
Committer: GitHub <noreply at github.com>
Date:      2020-12-16 08:26:45 +0000
URL:       https://git.openjdk.java.net/jemmy-v2/commit/bc246f7a

CODETOOLS-7902811: Add accessible name and description to the dump (#5)

* CODETOOLS-7902811: Add accessible name and description to the dump

* Updating copyright years to sync with JDK repo.
Updating version info.

! src/org/netbeans/jemmy/drivers/DefaultDriverInstaller.java
! src/org/netbeans/jemmy/operators/ComponentOperator.java
! src/org/netbeans/jemmy/operators/JFileChooserOperator.java
! src/org/netbeans/jemmy/operators/JInternalFrameOperator.java
! src/org/netbeans/jemmy/util/LookAndFeel.java
! src/org/netbeans/jemmy/util/Platform.java
! src/org/netbeans/jemmy/version_info
+ test/org/netbeans/jemmy/operators/AcessibleDumpPropertiesTest.java


From shurailine at openjdk.java.net  Wed Dec 16 16:34:15 2020
From: shurailine at openjdk.java.net (Alexandre Iline)
Date: Wed, 16 Dec 2020 16:34:15 GMT
Subject: Withdrawn: CODETOOLS-7902811: Add accessible name and description to
 the dump
In-Reply-To: <xHiyu_VJ_-PuypqCeUHcT2ceMUODuvK1fwH0sRvMSp4=.1dff9ff9-2f43-411d-b82f-e7bbf8c2bed1@github.com>
References: <xHiyu_VJ_-PuypqCeUHcT2ceMUODuvK1fwH0sRvMSp4=.1dff9ff9-2f43-411d-b82f-e7bbf8c2bed1@github.com>
Message-ID: <MfYIwSv_RYoYag3KJuZcUhr_jqTN0b50MtngY3rziLU=.6387d18d-a97c-43ff-9d7c-929dbec55a48@github.com>

On Wed, 16 Dec 2020 01:43:12 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

> Accessible name and description are useful to identify components in the hierarchy.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.java.net/jemmy-v2/pull/5