RFR: Codetools 7902736

Abdul Kolarkunnu akolarkunnu at openjdk.java.net
Wed Nov 11 07:01:01 UTC 2020


On Wed, 11 Nov 2020 02:17:02 GMT, Amresh Sahu <github.com+72060147+amresh-sahu at openjdk.org> wrote:

>> Add selected text to the dump, whether or not the test is empty. Add empty string for null return value.
>
> Looks fine.

Just a thought - Is it a good idea to differentiate 'null' and empty string - May be by replacing "" with "null" when selectedText is null.
Also what about renaming 'selected' with 'selectedText' .

-------------

PR: https://git.openjdk.java.net/jemmy-v2/pull/2


More information about the jemmy-dev mailing list