RFR: CODETOOLS-7902793: Fix IllegalMonitorStateException in JInternalFrameOperatorCloseTest

Alexandre Iline shurailine at openjdk.java.net
Wed Nov 18 15:14:11 UTC 2020

On Wed, 18 Nov 2020 10:20:13 GMT, Amresh Sahu <github.com+72060147+amresh-sahu at openjdk.org> wrote:

> IllegalMonitorStateException has been fixed.

Changes requested by shurailine (Committer).

test/org/netbeans/jemmy/operators/JInternalFrameOperatorCloseTest.java line 100:

> 98:             @Override
> 99:             public void internalFrameClosing(InternalFrameEvent e) {
> 100:                     new QueueTool().waitEmpty();

There is a comment below, which explains what should be here:
// Making not to close the fame for 1 minute and expecting TimeoutExpiredException
// from waitClosed()

Which would mean that the lines in internalFrameClosing(InternalFrameEvent e) should just delay the execution for  minute. The reason for doing that, it looks like, is that there is no other way to detect window closing but by the timeout.

Your fix is doing something completely different.


PR: https://git.openjdk.java.net/jemmy-v2/pull/3

More information about the jemmy-dev mailing list