RFR: CODETOOLS-7902793: Fix IllegalMonitorStateException in JInternalFrameOperatorCloseTest [v2]

Amresh Sahu github.com+72060147+amresh-sahu at openjdk.java.net
Tue Nov 24 11:07:14 UTC 2020

On Wed, 18 Nov 2020 15:11:07 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

>> Amresh Sahu has updated the pull request incrementally with one additional commit since the last revision:
>>   Update JInternalFrameOperatorCloseTest.java
>>   There were two scenarios one is happy path scenario where only closing internal frame was being tested and another was negative scenario where TimeoutExpiredException was expected so removed the negative test scenario.
> test/org/netbeans/jemmy/operators/JInternalFrameOperatorCloseTest.java line 100:
>> 98:             @Override
>> 99:             public void internalFrameClosing(InternalFrameEvent e) {
>> 100:                     new QueueTool().waitEmpty();
> There is a comment below, which explains what should be here:
> // Making not to close the fame for 1 minute and expecting TimeoutExpiredException
> // from waitClosed()
> Which would mean that the lines in internalFrameClosing(InternalFrameEvent e) should just delay the execution for  minute. The reason for doing that, it looks like, is that there is no other way to detect window closing but by the timeout.
> Your fix is doing something completely different.

Removed negative test scenario. 
Currently, Testing that Internal frame is closing or not.


PR: https://git.openjdk.java.net/jemmy-v2/pull/3

More information about the jemmy-dev mailing list