From mandy.chung at oracle.com Thu Aug 4 12:35:11 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Thu, 04 Aug 2011 12:35:11 -0700 Subject: Review request on the optional modules support Message-ID: <4E3AF46F.1050801@oracle.com> An update on the optional module support [1]. Webrev: http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/optional-modules.00/ The note has been updated to include the open questions raised in the discussion. http://openjdk.java.net/projects/jigsaw/doc/topics/optional.html There is an open question whether the isModulePresent method should take a version-range argument or other alternative for an application to support different versions of modules with incompatible change (see [2]). I propose to get this prototype in the jigsaw repository first and address the open question next as we would need to get the use cases to determine what the right API for it. Summary of Changes: 1. A new @RequireOptionalModule annotation is defined to indicate that the annotated type requires the optional module to be present when it's referenced; otherwise, ModuleNotPresentException would be thrown. See java.util.Properties.loadFromXML and other examples in the JDK. 2. Two new methods are added in the java.lang.reflect.Module class to test if a module has been resolved and linked with this module's context. The requireModulePresent(String mn) method checks if the given module is present; if not, it throws ModuleNotPresentException. isModulePresent(String mn) simply returns true/false and it can be used for the fall-back cases if an optioanl module is not present. 3. Class.getModule() is modified to lazily set the Module for a system class loaded by the VM bootstrap null loader. The VM loads the primordial classes directly in the VM and also other system classes when the caller is loaded by null class loader without calling the library. The Class's module field is null in that case. The Loader class is refactored to support the lazily initialization of the Class's module. 4. An optional module that doesn't any local class but just reexports another module is not currently stored in the configuration. Thus the loader can't find it even if it's present. jdk.jaxp is an example that reexports sun.jaxp as sun.jaxp exports its internal APIs and permits only specific module to use (jaxws) while jdk.jaxp only reexports the public APIs. I simply added the remote contexts list in the configuration as the fast configuration work will further change the layout. With another change I made in the SimpleLibrary.StoredConfiguration class to add indirection for the context name that reduces the config file size [3], the remote contexts list should have minimal impact to the config size. Please also note that I added a "Guideline of Using Optional module" section in [2] which is intended to illustrate the class loading issue with optional module but not as a recommendation for the coding practice. This would be another topic to discuss. Thanks Mandy [1] http://mail.openjdk.java.net/pipermail/jigsaw-dev/2011-May/001298.html [2] http://openjdk.java.net/projects/jigsaw/doc/topics/optional.html [3] http://mail.openjdk.java.net/pipermail/jigsaw-dev/2011-June/001349.html From jesse.glick at oracle.com Thu Aug 4 13:18:10 2011 From: jesse.glick at oracle.com (Jesse Glick) Date: Thu, 04 Aug 2011 16:18:10 -0400 Subject: Review request on the optional modules support In-Reply-To: <4E3AF46F.1050801@oracle.com> References: <4E3AF46F.1050801@oracle.com> Message-ID: <4E3AFE82.7040809@oracle.com> On 08/04/2011 03:35 PM, Mandy Chung wrote: > http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/optional-modules.00/ Parenthetical note: "jdk.jaxp" as a module name seems wrong since JAXP is not specific to the JDK (i.e. JRE + tools); would expect "jre.jaxp". Same for AWT, etc. > A new @RequireOptionalModule annotation is defined to indicate that the annotated type "Annotated element" I guess (includes methods); Javadoc needs to be edited. > http://openjdk.java.net/projects/jigsaw/doc/topics/optional.html Open question #1 - does it not suffice that @ROM is @Documented? Open question #3 - a Maven plugin for checking JRE compatibility does something like this: http://mojo.codehaus.org/animal-sniffer/animal-sniffer-annotations/ From Alan.Bateman at oracle.com Thu Aug 4 13:25:19 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 04 Aug 2011 21:25:19 +0100 Subject: Review request on the optional modules support In-Reply-To: <4E3AFE82.7040809@oracle.com> References: <4E3AF46F.1050801@oracle.com> <4E3AFE82.7040809@oracle.com> Message-ID: <4E3B002F.1020407@oracle.com> Jesse Glick wrote: > On 08/04/2011 03:35 PM, Mandy Chung wrote: >> http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/optional-modules.00/ > > Parenthetical note: "jdk.jaxp" as a module name seems wrong since JAXP > is not specific to the JDK (i.e. JRE + tools); would expect > "jre.jaxp". Same for AWT, etc. > I wouldn't be concerned about the module names at this point as it's way too early in the JDK modularization effort and the module graph, names, etc. are all likely to change. -Alan. From mandy.chung at oracle.com Thu Aug 4 14:01:24 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Thu, 04 Aug 2011 14:01:24 -0700 Subject: Review request on the optional modules support In-Reply-To: <4E3B002F.1020407@oracle.com> References: <4E3AF46F.1050801@oracle.com> <4E3AFE82.7040809@oracle.com> <4E3B002F.1020407@oracle.com> Message-ID: <4E3B08A4.6050301@oracle.com> On 8/4/11 1:25 PM, Alan Bateman wrote: > Jesse Glick wrote: >> On 08/04/2011 03:35 PM, Mandy Chung wrote: >>> http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/optional-modules.00/ >> >> Parenthetical note: "jdk.jaxp" as a module name seems wrong since >> JAXP is not specific to the JDK (i.e. JRE + tools); would expect >> "jre.jaxp". Same for AWT, etc. >> > I wouldn't be concerned about the module names at this point as it's > way too early in the JDK modularization effort and the module graph, > names, etc. are all likely to change. Exactly. The module names will be changed for example how the substitution is supported [1]. TBD. Mandy [1] http://openjdk.java.net/projects/jigsaw/doc/draft-java-module-system-requirements-12#substitution From mandy.chung at oracle.com Thu Aug 4 16:33:34 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Thu, 04 Aug 2011 16:33:34 -0700 Subject: Review request on the optional modules support In-Reply-To: <4E3AFE82.7040809@oracle.com> References: <4E3AF46F.1050801@oracle.com> <4E3AFE82.7040809@oracle.com> Message-ID: <4E3B2C4E.1050506@oracle.com> On 08/04/11 13:18, Jesse Glick wrote: >> A new @RequireOptionalModule annotation is defined to indicate that >> the annotated type > > "Annotated element" I guess (includes methods); Javadoc needs to be > edited. > Fixed. >> http://openjdk.java.net/projects/jigsaw/doc/topics/optional.html > > Open question #1 - does it not suffice that @ROM is @Documented? I think @Document + @throws ModuleNotPresentException will suffice. @ROM implies "@throws ModuleNotPresentException" and it's a good practice to specify @throws in the javadoc. I don't see a need to add a new javadoc tag. I included the question there to see if anyone thinks differently. Mandy From Alan.Bateman at oracle.com Mon Aug 8 08:01:16 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 08 Aug 2011 16:01:16 +0100 Subject: Review request on the optional modules support In-Reply-To: <4E3AF46F.1050801@oracle.com> References: <4E3AF46F.1050801@oracle.com> Message-ID: <4E3FFA3C.4030009@oracle.com> Mandy Chung wrote: > An update on the optional module support [1]. > > Webrev: > http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/optional-modules.00/ > > The note has been updated to include the open questions raised in > the discussion. > http://openjdk.java.net/projects/jigsaw/doc/topics/optional.html I went through the webrev. It mostly looks okay to me but I suspect that developers might initially grapple with isModulePresent and requireModulePresent as instance methods (in time I guess the javadoc will be fleshed out and concepts such as context can be referenced). I see you've changed a few of the SecurityManager methods to throw ModuleNotPresentException but I'm not sure that is really needed. The alternative is to just have the permission checks fail, as they do now, when the desktop module is not present. The updates to java.lang.reflect.Module remind me to ask whether this is the right package for this class (java.lang, java.lang.reflect or java.lang.module). I realize there is history here (should Class and Package be in java.lang.reflect, etc.) but it does seem inconsistent now. One of the questions posed is whether the compiler can use the RequireOptionalModule annotations but I would have thought that if there are any references to types in optional modules then it will require that they be present at compile time. Maybe this question is only for the case that reflection is used? Another question is about handling different versions but that strikes me as a bit fragile and could potentially get out of sync with the version constraints in the module-info too. Otherwise I think the changes are okay and I note that RequireOptionalModule will need to have to classes element removed once we don't require the class analyzer in the build. -Alan From mandy.chung at oracle.com Mon Aug 8 17:33:28 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Mon, 08 Aug 2011 17:33:28 -0700 Subject: Review request on the optional modules support In-Reply-To: <4E3FFA3C.4030009@oracle.com> References: <4E3AF46F.1050801@oracle.com> <4E3FFA3C.4030009@oracle.com> Message-ID: <4E408058.9060501@oracle.com> On 8/8/11 8:01 AM, Alan Bateman wrote: > Mandy Chung wrote: >> An update on the optional module support [1]. >> >> Webrev: >> >> http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/optional-modules.00/ >> >> The note has been updated to include the open questions raised in >> the discussion. >> http://openjdk.java.net/projects/jigsaw/doc/topics/optional.html > I went through the webrev. > > It mostly looks okay to me but I suspect that developers might > initially grapple with isModulePresent and requireModulePresent as > instance methods (in time I guess the javadoc will be fleshed out and > concepts such as context can be referenced). > I think ModuleClassLoader might actually be a more appropriate class defining these methods. The downside of it is that it requires to cast the class loader returned from Class.getClassLoader() to ModuleClassLoader. > I see you've changed a few of the SecurityManager methods to throw > ModuleNotPresentException but I'm not sure that is really needed. The > alternative is to just have the permission checks fail, as they do > now, when the desktop module is not present. > There doesn't seem to have any reason for an application that doesn't require desktop module to call these methods. So the question is whether we want to disallow the use of these methods if desktop module is not present: checkAwtEventQueueAccess() checkTopLevelWindow() checkSystemClipboardAccess() It's more of a cleanup on the API. > The updates to java.lang.reflect.Module remind me to ask whether this > is the right package for this class (java.lang, java.lang.reflect or > java.lang.module). I realize there is history here (should Class and > Package be in java.lang.reflect, etc.) but it does seem inconsistent now. > I too wonder about the inconsistency. I'm making a note of it. > One of the questions posed is whether the compiler can use the > RequireOptionalModule annotations but I would have thought that if > there are any references to types in optional modules then it will > require that they be present at compile time. Maybe this question is > only for the case that reflection is used? > Roger posted this question in our previous discussion. At compile time, the optional module must be present if there is any reference to types in the optional module. If the optional method is not carefully written, at class loading time, the verifier might load types in optional modules for verification regardless of whether the optional module is called or not. The question really comes to whether the compiler can detect such potential verification error during compilation. I talked with Jon Gibbons another day. The compiler can't detect that. Jon and Alex can chime in and explain further. > Another question is about handling different versions but that strikes > me as a bit fragile and could potentially get out of sync with the > version constraints in the module-info too. > > Otherwise I think the changes are okay and I note that > RequireOptionalModule will need to have to classes element removed > once we don't require the class analyzer in the build. I may just take it out now since the class analyzer is using the depconfig file. Thanks Mandy From jesse.glick at oracle.com Tue Aug 9 05:57:13 2011 From: jesse.glick at oracle.com (Jesse Glick) Date: Tue, 09 Aug 2011 08:57:13 -0400 Subject: Review request on the optional modules support In-Reply-To: <4E408058.9060501@oracle.com> References: <4E3AF46F.1050801@oracle.com> <4E3FFA3C.4030009@oracle.com> <4E408058.9060501@oracle.com> Message-ID: <4E412EA9.8000902@oracle.com> On 08/08/2011 08:33 PM, Mandy Chung wrote: >> ...should Class and Package be in java.lang.reflect... > > I too wonder about the inconsistency. Do you have any ambition to make java.lang.reflect be an optional module? (This would require Object.getClass() to throw ModuleNotPresentException.) There are two reasons this might be useful: 1. Secure containers (sandboxes) may prefer that hosted code not even run those limited reflective calls that the security manager would permit. 2. Compilers or analyzers could make more aggressive optimizations or error checks knowing that reflection is unavailable in a given codebase. A third use case would be for a runtime subset that would permit pure functions to be written - i.e. those guaranteed by form to return consistent results - but this would require isolating other parts of java.lang as well: Thread/ThreadGroup, System, Runtime, most Object methods, etc. It may be impossible to do this without vetting bytecode manually. On a related note - I have an RFE open about @SupportedAnnotationTypes in which one suggested fix is for X.class.getCanonicalName() and similar constructs to be treated as compile-time constants. It would be odd but I suppose harmless for the definition of CTCs to refer to modules other than java.lang. > The compiler can't detect [such potential verification errors] Seems like this is more the domain of FindBugs. From Alan.Bateman at oracle.com Tue Aug 9 06:29:01 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 09 Aug 2011 14:29:01 +0100 Subject: Review request on the optional modules support In-Reply-To: <4E412EA9.8000902@oracle.com> References: <4E3AF46F.1050801@oracle.com> <4E3FFA3C.4030009@oracle.com> <4E408058.9060501@oracle.com> <4E412EA9.8000902@oracle.com> Message-ID: <4E41361D.1050201@oracle.com> Jesse Glick wrote: > On 08/08/2011 08:33 PM, Mandy Chung wrote: >>> ...should Class and Package be in java.lang.reflect... >> >> I too wonder about the inconsistency. > > Do you have any ambition to make java.lang.reflect be an optional > module? (This would require Object.getClass() to throw > ModuleNotPresentException.) No, there isn't anything in the current requirements for this. It's not clear to me that putting reflection into its own module would even be feasible or rather I'm not sure that anything useful could run without java.lang.Class being present (java.lang.Class needs to loaded early in the VM startup and it implements several types defined in java.lang.reflect, etc.). -Alan From jesse.glick at oracle.com Tue Aug 9 07:56:47 2011 From: jesse.glick at oracle.com (Jesse Glick) Date: Tue, 09 Aug 2011 10:56:47 -0400 Subject: Review request on the optional modules support In-Reply-To: <4E41361D.1050201@oracle.com> References: <4E3AF46F.1050801@oracle.com> <4E3FFA3C.4030009@oracle.com> <4E408058.9060501@oracle.com> <4E412EA9.8000902@oracle.com> <4E41361D.1050201@oracle.com> Message-ID: <4E414AAF.4000300@oracle.com> On 08/09/2011 09:29 AM, Alan Bateman wrote: > I'm not sure that anything useful could run without java.lang.Class being present Certainly not. The point would merely be to forbid reflection-related APIs from being referenced from another module unless the java.lang.reflect module was explicitly imported. But perhaps this is a deeper property of the calling code than can be captured by API signatures - the Java language and bytecode definition includes inherently reflective operations like instanceof. From sean.mullan at oracle.com Tue Aug 9 10:27:44 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Tue, 09 Aug 2011 13:27:44 -0400 Subject: Review request on the optional modules support In-Reply-To: <4E3AF46F.1050801@oracle.com> References: <4E3AF46F.1050801@oracle.com> Message-ID: <4E416E10.10201@oracle.com> Hi Mandy, I was just reviewing the design note (not the webrev) and I had a couple of minor comments - Optional Module first sentence, suggest: s/referred as optional module/referred to as the optional module 2. ModuleNotPresentException "if it's absent, a ModuleNotPresentException as in the "foo" module example given above." I could not find the "foo" module example above. Do you mean the one at the end of the document? JDK Optional Dependenceies 1. APIs that throw ModuleNotPresentException Are those really the only APIs that require optional modules? Aren't there also internal APIs that have optional dependencies? Don't they need to be updated as well? General Question I'm not sure if this question makes sense, but what happens in the future if JAXP is required by the base module? Would it still make sense to annotate APIs in the module that require it as an optional module? --Sean On 8/4/11 3:35 PM, Mandy Chung wrote: > An update on the optional module support [1]. > > Webrev: > http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/optional-modules.00/ > > The note has been updated to include the open questions raised in the > discussion. http://openjdk.java.net/projects/jigsaw/doc/topics/optional.html > > There is an open question whether the isModulePresent method should take a > version-range argument or other alternative for an application to support > different versions of modules with incompatible change (see [2]). > > I propose to get this prototype in the jigsaw repository first and address > the open question next as we would need to get the use cases to determine > what the right API for it. > > Summary of Changes: 1. A new @RequireOptionalModule annotation is defined to > indicate that the annotated type requires the optional module to be present > when it's referenced; otherwise, ModuleNotPresentException would be thrown. > > See java.util.Properties.loadFromXML and other examples in the JDK. > > 2. Two new methods are added in the java.lang.reflect.Module class to test if > a module has been resolved and linked with this module's context. > > The requireModulePresent(String mn) method checks if the given module is > present; if not, it throws ModuleNotPresentException. > > isModulePresent(String mn) simply returns true/false and it can be used for > the fall-back cases if an optioanl module is not present. > > 3. Class.getModule() is modified to lazily set the Module for a system class > loaded by the VM bootstrap null loader. > > The VM loads the primordial classes directly in the VM and also other system > classes when the caller is loaded by null class loader without calling the > library. The Class's module field is null in that case. The Loader class is > refactored to support the lazily initialization of the Class's module. > > 4. An optional module that doesn't any local class but just reexports another > module is not currently stored in the configuration. Thus the loader can't > find it even if it's present. jdk.jaxp is an example that reexports sun.jaxp > as sun.jaxp exports its internal APIs and permits only specific module to use > (jaxws) while jdk.jaxp only reexports the public APIs. > > I simply added the remote contexts list in the configuration as the fast > configuration work will further change the layout. With another change I made > in the SimpleLibrary.StoredConfiguration class to add indirection for the > context name that reduces the config file size [3], the remote contexts list > should have minimal impact to the config size. > > Please also note that I added a "Guideline of Using Optional module" section > in [2] which is intended to illustrate the class loading issue with optional > module but not as a recommendation for the coding practice. This would be > another topic to discuss. > > Thanks Mandy > > [1] http://mail.openjdk.java.net/pipermail/jigsaw-dev/2011-May/001298.html > [2] http://openjdk.java.net/projects/jigsaw/doc/topics/optional.html [3] > http://mail.openjdk.java.net/pipermail/jigsaw-dev/2011-June/001349.html From Alan.Bateman at oracle.com Tue Aug 9 10:47:10 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 09 Aug 2011 18:47:10 +0100 Subject: sync'ing up jigsaw/jigsaw? Message-ID: <4E41729E.5050502@oracle.com> Mandy, I'm cleaning up my environment and wondering about moving jigsaw/jigsaw to jdk8 (which would mean changing everything to 8-ea form 7-ea in addition to sync'ing up the forest). Is this something you are doing? Just checking (I don't mind doing it, seems like you've done more than your fair share of sync'ing up over the last year). -Alan From mandy.chung at oracle.com Tue Aug 9 10:58:45 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Tue, 09 Aug 2011 10:58:45 -0700 Subject: sync'ing up jigsaw/jigsaw? In-Reply-To: <4E41729E.5050502@oracle.com> References: <4E41729E.5050502@oracle.com> Message-ID: <4E417555.7000906@oracle.com> On 08/09/11 10:47, Alan Bateman wrote: > p my environment and wondering about moving jigsaw/jigsaw to jdk8 > (which would mean changing everything to 8-ea form 7-ea in addition to > sync'ing up the forest). Is this something you are doing? Just > checking (I don't mind doing it, seems like you've done more than your > fair share of sync'ing up over the last year). Yes, I'm working on it. I ran into several small issues, one after another, that I had to fix. My modules build now fails when using the jdk-module-image to build langtools. [javac] warning: [options] bootstrap class path not set in conjunction with -source 1.7 [javac] error: warnings found and -Werror specified [javac] 1 error Hope this is the last one. Mandy From mandy.chung at oracle.com Tue Aug 9 12:45:45 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Tue, 09 Aug 2011 12:45:45 -0700 Subject: Correct webrev for the exports support Message-ID: <4E418E69.5090201@oracle.com> I post a wrong URL for the updated webrev of the exports support [1], sorry. Here is the correct one: Webrev at: http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/exports-full-webrev.01/ The module-info.java for all jdk modules is at: http://cr.openjdk.java.net/~mchung/jigsaw/moduleinfo-exports/jdk-modules-module-info.txt The summary of the changes are described in [2] plus a fix in SimpleLibrary.StoredConfiguration class that adds indirection for the context name that reduces the config file size bloat from 90M to 16M. Alan, There is no other change since you reviewed last time. Mandy [1] http://mail.openjdk.java.net/pipermail/jigsaw-dev/2011-June/001349.html [2] http://mail.openjdk.java.net/pipermail/jigsaw-dev/2011-June/001333.html From mandy.chung at oracle.com Tue Aug 9 16:57:03 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Tue, 09 Aug 2011 16:57:03 -0700 Subject: Review request on the optional modules support In-Reply-To: <4E416E10.10201@oracle.com> References: <4E3AF46F.1050801@oracle.com> <4E416E10.10201@oracle.com> Message-ID: <4E41C94F.5050200@oracle.com> On 08/09/11 10:27, Sean Mullan wrote: > Hi Mandy, > > I was just reviewing the design note (not the webrev) and I had a couple of > minor comments - > > Optional Module > > first sentence, suggest: > > s/referred as optional module/referred to as the optional module > Fixed. > 2. ModuleNotPresentException > > "if it's absent, a ModuleNotPresentException as in the "foo" module example > given above." > > I could not find the "foo" module example above. Do you mean the one at the end > of the document? > I moved the section and the example to the end but forgot to update the statement. Sorry about that. Will fix that. > JDK Optional Dependenceies > 1. APIs that throw ModuleNotPresentException > > Are those really the only APIs that require optional modules? No. They are the ones I identified that should throw ModuleNotPresentException when they are called but the optional module is missing. I also suggest that javax.management.remote.JMXConnector.connect() and/or RMIConnector.connect should be updated to throw ModuleNotPresentException as described in the optional.html note. > Aren't there also > internal APIs that have optional dependencies? Don't they need to be updated as > well? > There are APIs that have optional dependencies but they are designed to work in the absence of the optional module as well. There are different kinds of optional dependencies. 1. APIs that throw ModuleNotPresentException It's the caller's responsibility to make sure that the optional module is installed. The APIs have to detect if the optional module exists before referencing any type in it. 2. Optional dependencies satisfied by its input arguments These APIs do not require the optional module to be present unless its input arguments specify it and are constructed in in the presence of the optional module. For example, java.text.Bidi references java.awt.TextAttribute. So the base module should have an optional dependency on "desktop" module (it's one clean up task to fix module-info.java on my todo list). The desktop module is guaranteed to be present when it hits the code path to reference the java.awt.TextAttribute class. In this case, the application should be configured properly. 3. APIs that fall back to the default implementation when the optional module is absent ResourceBundle is a good example that falls back to use the default locale. Security provider is another example where the default provider and the interface are in one module whereas other provider implementation is in another module (note that this doesn't use the java.util.ServiceLoader mechanism). In any case, one module has an optional dependency on another but it will work both ways - the optional module is present or absent. I see this possibly be adjusted to use the module-aware service loader mechanism [1]. In any case, this doesn't throw MNPE. > General Question > > I'm not sure if this question makes sense, but what happens in the future if > JAXP is required by the base module? Good question. @RequireOptionalModule is intended to mark certain functionality that requires an optional module but not the rest of the module. If the optional dependency becomes a hard dependency, it makes sense to me to update the spec and implementation to remove @ROM annotation and @throw MNPE which doesn't have compatibility issue. > Would it still make sense to annotate APIs > in the module that require it as an optional module? > @RequireOptionalModule is intended for documentation purpose and any developer tools to help the developers be aware that the APIs in (1) above requires a specific module to be present. APIs in (2) and (3) above are of a different category that these APIs supports both cases when the optional module is present or absent but @ROM is defined for those who throws MNPE. On the other hand, should we have a different annotation? I raised a similar question in my first post of the optional modules support [2] what can help the implementor of these APIs to detect if all optional dependencies are properly declared in the module-info.java. One potential problem I see for APIs in (2) and (3) above is that the optional dependency is not declared in the module-info.java and I asked if we should annotate all these APIs so that a tool can detect any incorrect module-info.java during development. I convinced myself that it's not justified to annotate them for this purpose. During development, tests should be developed to exercise the path when the optional module is present or absent and catch the case if the optional module is not declared in the module-info.java. That's my view and it should be caught during the development and testing process. Mandy [1] http://openjdk.java.net/projects/jigsaw/doc/topics/services.html [2] http://mail.openjdk.java.net/pipermail/jigsaw-dev/2011-May/001298.html From mandy.chung at oracle.com Tue Aug 9 21:03:50 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Tue, 09 Aug 2011 21:03:50 -0700 Subject: ClassAnalyzer patch Message-ID: <4E420326.7080904@oracle.com> Alan, I have updated the class analyzer to use the modules from the jigsaw module library for generating its module-info.java. Below is one example of module-info.java ClassAnalyzer output for SwingSet3 demo and jdesktop libraries [1]. module swingset3 @ 1.0 { requires jdesktop.animation @ 1.0; requires jdesktop.appframework @ 1.0; requires jdesktop.swingx @ 1.0; requires jdk.base @ 7-ea; requires jdk.desktop @ 7-ea; requires jdk.logging @ 7-ea; class com.sun.swingset3.SwingSet3; } Webrev at: http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/classanalyzer-update-full/ I also added make/tools/classanalyer/classanalyzer.html to include some information about this tool. The above webrev includes the class analyzer change I included in [2] so that it can be pushed separately. The delta from [2] might be useful if you have already reviewed the previous version: http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/classanalyzer-update.00/ Can you please review it? Thanks Mandy [1] http://java.net/projects/swingset3 [2] http://mail.openjdk.java.net/pipermail/jigsaw-dev/2011-June/001333.html From Alan.Bateman at oracle.com Thu Aug 11 06:40:13 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 11 Aug 2011 14:40:13 +0100 Subject: ClassAnalyzer patch In-Reply-To: <4E420326.7080904@oracle.com> References: <4E420326.7080904@oracle.com> Message-ID: <4E43DBBD.1090903@oracle.com> Mandy Chung wrote: > Alan, > > I have updated the class analyzer to use the modules from the jigsaw > module library for generating its module-info.java. Below is one > example of module-info.java ClassAnalyzer output for SwingSet3 demo > and jdesktop libraries [1]. > > module swingset3 @ 1.0 { > requires jdesktop.animation @ 1.0; > requires jdesktop.appframework @ 1.0; > requires jdesktop.swingx @ 1.0; > requires jdk.base @ 7-ea; > requires jdk.desktop @ 7-ea; > requires jdk.logging @ 7-ea; > class com.sun.swingset3.SwingSet3; > } > > > Webrev at: > > http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/classanalyzer-update-full/ > > > I also added make/tools/classanalyer/classanalyzer.html to include > some information about this tool. > > The above webrev includes the class analyzer change I included in [2] > so that it can be pushed separately. The delta from [2] might be > useful if you have already reviewed the previous version: > > http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/classanalyzer-update.00/ > I skimmed through the changes in the delta webrev and it all seems reasonable and straight-forward (I didn't to review every line, which I think it okay at this point). Just on the full webrev, I see updates to the module config. One odd one is that zipfs shouldn't be in net-ext as it's a file system provider rather than anything network related. Otherwise looks fine to me. -Alan. From Roger.Riggs at oracle.com Thu Aug 11 13:24:04 2011 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Thu, 11 Aug 2011 16:24:04 -0400 Subject: Review request on the optional modules support In-Reply-To: <4E408058.9060501@oracle.com> References: <4E3AF46F.1050801@oracle.com> <4E3FFA3C.4030009@oracle.com> <4E408058.9060501@oracle.com> Message-ID: <4E443A64.7020404@oracle.com> ok, I'll bite... about the compiler being able (or not) to flag potentially faulty references to classes in optional modules. When the compiler is using the module info to compile a module, it will know that another module is optional respect to the module being compiled. For those references, it would seem to be knowable how the reference is being used and be able to flag the same kinds of conditions that the verifier would. What am I missing? Thanks, Roger > >> One of the questions posed is whether the compiler can use the >> RequireOptionalModule annotations but I would have thought that if >> there are any references to types in optional modules then it will >> require that they be present at compile time. Maybe this question is >> only for the case that reflection is used? >> > > Roger posted this question in our previous discussion. At compile > time, the optional module must be present if there is any reference to > types in the optional module. If the optional method is not > carefully written, at class loading time, the verifier might load > types in optional modules for verification regardless of whether the > optional module is called or not. The question really comes to > whether the compiler can detect such potential verification error > during compilation. I talked with Jon Gibbons another day. The > compiler can't detect that. Jon and Alex can chime in and explain > further. From mark.reinhold at oracle.com Fri Aug 12 09:43:50 2011 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Fri, 12 Aug 2011 09:43:50 -0700 Subject: PersistentTreeMap class Message-ID: <20110812164350.B2512767@eggemoggin.niobe.net> From mark.reinhold at oracle.com Fri Aug 12 10:05:15 2011 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Fri, 12 Aug 2011 10:05:15 -0700 Subject: PersistentTreeMap class In-Reply-To: mark.reinhold@oracle.com; Fri, 12 Aug 2011 09:43:50 PDT; <20110812164350.B2512767@eggemoggin.niobe.net> Message-ID: <20110812170515.936CB767@eggemoggin.niobe.net> An embedded and charset-unspecified text was scrubbed... Name: PersistentTreeMap.java Url: http://mail.openjdk.java.net/pipermail/jigsaw-dev/attachments/20110812/db25cb00/PersistentTreeMap.java -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: PersistentTreeMap.c Url: http://mail.openjdk.java.net/pipermail/jigsaw-dev/attachments/20110812/db25cb00/PersistentTreeMap.c From mandy.chung at oracle.com Fri Aug 12 13:44:29 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Fri, 12 Aug 2011 13:44:29 -0700 Subject: sync'ing up jigsaw/jigsaw? In-Reply-To: <4E41729E.5050502@oracle.com> References: <4E41729E.5050502@oracle.com> Message-ID: <4E4590AD.5030802@oracle.com> I have the merge ready. Besides changing everything to 8-ea from 7-ea, I also have to change the langtools to build with JDK 7: (1) to use the jigsaw class to determine if the stubs need to be generated (2) to add "-options" to the -Xlint option (the "javac.lint.opts" property). This is needed for the boot cycle build when it bootstraps to build langtools with the module image. jdk-module-image no longer has rt.jar and thus -Xbootclasspath is not set but the boot.javac.source = 1.6. The langtools build failed with this: [javac] warning: [options] bootstrap class path not set in conjunction with -source 1.6 [javac] error: warnings found and -Werror specified It seems to me that the langtools build needs further cleanup for building with jdk-module-image. So ignoring javac options warning in -Xlint is just a workaround for now. Jon, Does this workaround look okay to you (see langtools/make/build.properties and build.xml)? I'll leave it to you to do a better fix :) Webrev: http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/jigsaw-jdk8-merge/ Mandy On 08/09/11 10:47, Alan Bateman wrote: > Mandy, > > I'm cleaning up my environment and wondering about moving > jigsaw/jigsaw to jdk8 (which would mean changing everything to 8-ea > form 7-ea in addition to sync'ing up the forest). Is this something > you are doing? Just checking (I don't mind doing it, seems like you've > done more than your fair share of sync'ing up over the last year). > > -Alan From jonathan.gibbons at oracle.com Fri Aug 12 15:07:47 2011 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Fri, 12 Aug 2011 15:07:47 -0700 Subject: sync'ing up jigsaw/jigsaw? In-Reply-To: <4E4590AD.5030802@oracle.com> References: <4E41729E.5050502@oracle.com> <4E4590AD.5030802@oracle.com> Message-ID: <4E45A433.1020308@oracle.com> Yeah, the workaround is fine. -- Jon On 08/12/2011 01:44 PM, Mandy Chung wrote: > I have the merge ready. Besides changing everything to 8-ea from > 7-ea, I also have to change the langtools to build with JDK 7: > (1) to use the jigsaw class to determine if the stubs need to be > generated > (2) to add "-options" to the -Xlint option (the "javac.lint.opts" > property). > This is needed for the boot cycle build when it bootstraps to build > langtools with the module image. jdk-module-image no longer has > rt.jar and thus -Xbootclasspath is not set but the boot.javac.source = > 1.6. The langtools build failed with this: > > [javac] warning: [options] bootstrap class path not set in > conjunction with -source 1.6 > [javac] error: warnings found and -Werror specified > > It seems to me that the langtools build needs further cleanup for > building with jdk-module-image. So ignoring javac options warning in > -Xlint is just a workaround for now. > > Jon, > Does this workaround look okay to you (see > langtools/make/build.properties and build.xml)? I'll leave it to you > to do a better fix :) > > Webrev: > http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/jigsaw-jdk8-merge/ > > Mandy > > On 08/09/11 10:47, Alan Bateman wrote: >> Mandy, >> >> I'm cleaning up my environment and wondering about moving >> jigsaw/jigsaw to jdk8 (which would mean changing everything to 8-ea >> form 7-ea in addition to sync'ing up the forest). Is this something >> you are doing? Just checking (I don't mind doing it, seems like >> you've done more than your fair share of sync'ing up over the last >> year). >> >> -Alan > From mandy.chung at oracle.com Fri Aug 12 22:56:23 2011 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Sat, 13 Aug 2011 05:56:23 +0000 Subject: hg: jigsaw/jigsaw: 12 new changesets Message-ID: <20110813055623.A2E7147B41@hg.openjdk.java.net> Changeset: 3408a19567a6 Author: mr Date: 2011-05-24 15:28 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/rev/3408a19567a6 7048009: Update .jcheck/conf files for JDK 8 Reviewed-by: jjh ! .jcheck/conf Changeset: 93d2590fd849 Author: jeff Date: 2011-05-27 14:57 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/rev/93d2590fd849 7045697: JDK7 THIRD PARTY README update Reviewed-by: lana ! THIRD_PARTY_README Changeset: 55e9ebf03218 Author: lana Date: 2011-06-02 13:37 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/rev/55e9ebf03218 Merge Changeset: 2d38c2a79c14 Author: schien Date: 2011-06-07 14:00 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/rev/2d38c2a79c14 Added tag jdk7-b145 for changeset 55e9ebf03218 ! .hgtags Changeset: 404bd0b9385f Author: schien Date: 2011-06-08 10:20 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/rev/404bd0b9385f Merge Changeset: 3e0b96f8f6a0 Author: schien Date: 2011-06-20 16:24 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/rev/3e0b96f8f6a0 Added tag jdk7-b146 for changeset 2d38c2a79c14 ! .hgtags Changeset: 29e7e1474b5e Author: schien Date: 2011-06-20 17:28 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/rev/29e7e1474b5e Merge Changeset: 8da980eedab6 Author: jeff Date: 2011-06-22 10:09 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/rev/8da980eedab6 7057046: Add embedded license to THIRD PARTY README Reviewed-by: lana ! THIRD_PARTY_README Changeset: d91364304d7c Author: lana Date: 2011-06-22 12:40 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/rev/d91364304d7c Merge Changeset: ee67ee3bd597 Author: schien Date: 2011-06-27 13:21 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/rev/ee67ee3bd597 Added tag jdk7-b147 for changeset d91364304d7c ! .hgtags Changeset: 04734fe746f0 Author: schien Date: 2011-06-27 14:10 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/rev/04734fe746f0 Merge Changeset: 1d8f11f6d50c Author: mchung Date: 2011-08-12 14:12 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/rev/1d8f11f6d50c Merge ! .hgtags From mandy.chung at oracle.com Fri Aug 12 22:57:02 2011 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Sat, 13 Aug 2011 05:57:02 +0000 Subject: hg: jigsaw/jigsaw/langtools: 38 new changesets Message-ID: <20110813055824.A6A6B47B42@hg.openjdk.java.net> Changeset: fdc22d73b6f3 Author: mr Date: 2011-05-24 15:28 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/fdc22d73b6f3 7048009: Update .jcheck/conf files for JDK 8 Reviewed-by: jjh ! .jcheck/conf Changeset: 6bb526ccf5ff Author: mcimadamore Date: 2011-05-23 11:55 +0100 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/6bb526ccf5ff 7046348: Regression: javac complains of missing classfile for a seemingly unrelated interface Summary: Types.implementation forces unnecessary symbol completion on superinterfaces of a given type Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/scope/7046348/EagerInterfaceCompletionTest.java Changeset: 6211df69f7e0 Author: jeff Date: 2011-05-27 15:02 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/6211df69f7e0 7045697: JDK7 THIRD PARTY README update Reviewed-by: lana ! THIRD_PARTY_README Changeset: 6762754eb7c0 Author: jjg Date: 2011-06-01 11:25 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/6762754eb7c0 7042623: Regression: javac silently crash when attributing non-existent annotation Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/T7042623.java + test/tools/javac/T7042623.out Changeset: c455e2ae5c93 Author: lana Date: 2011-06-02 13:38 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/c455e2ae5c93 Merge Changeset: 9ff91d0e7154 Author: schien Date: 2011-06-07 14:01 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/9ff91d0e7154 Added tag jdk7-b145 for changeset c455e2ae5c93 ! .hgtags Changeset: f27b6f45a449 Author: schien Date: 2011-06-08 10:25 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/f27b6f45a449 Merge Changeset: 347349c981f2 Author: jjh Date: 2011-06-09 09:13 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/347349c981f2 7052782: Two langtools regression tests fail due to fix for 7034977 which removed the invokeGeneric method Summary: Change the tests to call invoke instead of invokeGeneric Reviewed-by: jrose, mcimadamore ! test/tools/javac/meth/InvokeMH.java ! test/tools/javac/meth/XlintWarn.java Changeset: b8a2c9c87018 Author: lana Date: 2011-06-10 11:44 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/b8a2c9c87018 Merge Changeset: 588d366d96df Author: asaha Date: 2011-04-21 16:16 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/588d366d96df Merge Changeset: 219b522d09e4 Author: asaha Date: 2011-05-04 12:00 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/219b522d09e4 Merge Changeset: 145d832616d3 Author: asaha Date: 2011-05-05 22:30 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/145d832616d3 Merge Changeset: 8b6e015ae7d0 Author: asaha Date: 2011-05-24 11:12 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/8b6e015ae7d0 Merge - test/tools/javac/generics/diamond/7030150/Neg01.java - test/tools/javac/generics/diamond/7030150/Neg01.out - test/tools/javac/generics/diamond/7030150/Neg02.java - test/tools/javac/generics/diamond/7030150/Neg02.out - test/tools/javac/generics/diamond/7030150/Neg03.java - test/tools/javac/generics/diamond/7030150/Neg03.out - test/tools/javac/generics/diamond/7030150/Pos01.java - test/tools/javac/generics/diamond/7030150/Pos02.java Changeset: 35cc19ae29b5 Author: asaha Date: 2011-05-26 17:26 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/35cc19ae29b5 Merge Changeset: 8b65930602c3 Author: asaha Date: 2011-05-26 21:42 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/8b65930602c3 Merge Changeset: 0adb806caf9d Author: asaha Date: 2011-06-06 10:22 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/0adb806caf9d Merge Changeset: bb1fdcebde01 Author: asaha Date: 2011-06-03 07:54 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/bb1fdcebde01 Merge Changeset: 8ed03b0e3c9c Author: asaha Date: 2011-06-06 11:08 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/8ed03b0e3c9c Merge Changeset: f494ca4bca0d Author: lana Date: 2011-06-15 16:11 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/f494ca4bca0d Merge Changeset: 7eba9df190ae Author: bpatel Date: 2011-06-17 20:12 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/7eba9df190ae 7052425: Change the look and feel of the javadoc generate HTML pages using stylesheet Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/background.gif - src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/inherit.gif ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css + src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/tab.gif + src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/titlebar.gif + src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/titlebar_end.gif ! test/com/sun/javadoc/AccessH1/AccessH1.java ! test/com/sun/javadoc/testStylesheet/TestStylesheet.java Changeset: c3a3440fe6e8 Author: bpatel Date: 2011-06-17 20:14 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/c3a3440fe6e8 Merge Changeset: 9425dd4f53d5 Author: schien Date: 2011-06-18 09:04 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/9425dd4f53d5 Merge Changeset: 436fb6aeda5a Author: schien Date: 2011-06-20 16:25 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/436fb6aeda5a Added tag jdk7-b146 for changeset 9425dd4f53d5 ! .hgtags Changeset: 06b6bbbe2787 Author: schien Date: 2011-06-20 17:39 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/06b6bbbe2787 Merge - src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/inherit.gif Changeset: a72412b148d7 Author: jeff Date: 2011-06-22 10:11 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/a72412b148d7 7057046: Add embedded license to THIRD PARTY README Reviewed-by: lana ! THIRD_PARTY_README Changeset: 58bc532d6341 Author: lana Date: 2011-06-22 12:41 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/58bc532d6341 Merge Changeset: ce654f4ecfd8 Author: schien Date: 2011-06-27 13:21 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/ce654f4ecfd8 Added tag jdk7-b147 for changeset 58bc532d6341 ! .hgtags Changeset: e0dec1645823 Author: schien Date: 2011-06-27 14:11 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/e0dec1645823 Merge Changeset: defdd98cb7ce Author: darcy Date: 2011-06-01 23:56 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/defdd98cb7ce 7025784: Add SourceVersion.RELEASE_8 7025786: Add -source 8 and -target 8 to javac 7025789: Change javac source and target default to 8 Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/jvm/Target.java ! src/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java ! src/share/classes/javax/lang/model/SourceVersion.java ! test/tools/javac/6330997/T6330997.java ! test/tools/javac/api/T6395981.java ! test/tools/javac/processing/warnings/TestSourceVersionWarnings.java ! test/tools/javac/quid/T6999438.java ! test/tools/javac/versions/check.sh Changeset: 3b1fd4ac2e71 Author: darcy Date: 2011-06-13 12:17 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/3b1fd4ac2e71 7052122: Update JDK_MINOR_VERSION for JDK 8 Reviewed-by: mr, katleman + test/tools/javac/processing/model/TestSourceVersion.java Changeset: 4844a9fd3a62 Author: darcy Date: 2011-06-22 17:07 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/4844a9fd3a62 6449184: Provide JavacProcessingEnvironment.getWriter Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! test/tools/javac/util/T6597678.java Changeset: 18002d039806 Author: jjg Date: 2011-06-23 11:49 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/18002d039806 7058174: Reduce langtools build warnings Reviewed-by: jjg Contributed-by: alexandre.boulgakov at oracle.com ! make/build.xml ! make/tools/CompileProperties/CompileProperties.java Changeset: d59414955614 Author: lana Date: 2011-06-22 23:26 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/d59414955614 Merge - src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/inherit.gif Changeset: 9eb36cac6b64 Author: lana Date: 2011-06-23 17:30 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/9eb36cac6b64 Merge Changeset: f74e4269a50a Author: darcy Date: 2011-06-24 13:52 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/f74e4269a50a 6575445: Update annotation processor to only use java.util.ServiceLoader Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/diags/examples.not-yet.txt Changeset: 858ae8fec72f Author: jjg Date: 2011-06-30 12:00 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/858ae8fec72f 7060926: Attr.PostAttrAnalyzer misses a case Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/failover/FailOver15.java + test/tools/javac/failover/FailOver15.out Changeset: 469e3bec9b27 Author: lana Date: 2011-06-30 14:19 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/469e3bec9b27 Merge Changeset: 66bca27502f1 Author: mchung Date: 2011-08-12 14:10 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/66bca27502f1 Merge ! .hgtags ! make/build.properties ! make/build.xml - src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/inherit.gif ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Modules.java ! src/share/classes/com/sun/tools/javac/jvm/Target.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties From mandy.chung at oracle.com Fri Aug 12 22:58:59 2011 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Sat, 13 Aug 2011 05:58:59 +0000 Subject: hg: jigsaw/jigsaw/corba: 14 new changesets Message-ID: <20110813055909.11A5E47B43@hg.openjdk.java.net> Changeset: c908ae06bd6b Author: mr Date: 2011-05-24 15:28 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/corba/rev/c908ae06bd6b 7048009: Update .jcheck/conf files for JDK 8 Reviewed-by: jjh ! .jcheck/conf Changeset: 93e77c49b3bb Author: miroslawzn Date: 2011-05-26 13:05 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/corba/rev/93e77c49b3bb 7046882: Regression : JDK 7b123 : Enum exchanged as parameters using CORBA call results in Exception Reviewed-by: raginip ! src/share/classes/com/sun/corba/se/impl/io/ObjectStreamClass.java Changeset: 643f267ca234 Author: jeff Date: 2011-05-27 14:58 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/corba/rev/643f267ca234 7045697: JDK7 THIRD PARTY README update Reviewed-by: lana ! THIRD_PARTY_README Changeset: 7839048ec99e Author: jeff Date: 2011-05-27 15:27 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/corba/rev/7839048ec99e Merge Changeset: 77ec0541aa2a Author: lana Date: 2011-06-02 13:37 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/corba/rev/77ec0541aa2a Merge Changeset: 770227a4087e Author: schien Date: 2011-06-07 14:00 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/corba/rev/770227a4087e Added tag jdk7-b145 for changeset 77ec0541aa2a ! .hgtags Changeset: e85ff90212ad Author: schien Date: 2011-06-08 10:20 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/corba/rev/e85ff90212ad Merge Changeset: 36f0efbc66ef Author: schien Date: 2011-06-20 16:25 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/corba/rev/36f0efbc66ef Added tag jdk7-b146 for changeset 770227a4087e ! .hgtags Changeset: abe4723b9b7f Author: schien Date: 2011-06-20 17:28 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/corba/rev/abe4723b9b7f Merge Changeset: bba0e37d7006 Author: jeff Date: 2011-06-22 10:10 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/corba/rev/bba0e37d7006 7057046: Add embedded license to THIRD PARTY README Reviewed-by: lana ! THIRD_PARTY_README Changeset: 73323cb33962 Author: lana Date: 2011-06-22 12:40 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/corba/rev/73323cb33962 Merge Changeset: 960011ba4bf2 Author: schien Date: 2011-06-27 13:21 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/corba/rev/960011ba4bf2 Added tag jdk7-b147 for changeset 73323cb33962 ! .hgtags Changeset: 97014e43181f Author: schien Date: 2011-06-27 14:10 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/corba/rev/97014e43181f Merge Changeset: cffbf4b1a66a Author: mchung Date: 2011-08-12 14:10 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/corba/rev/cffbf4b1a66a Merge ! .hgtags From mandy.chung at oracle.com Fri Aug 12 23:04:46 2011 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Sat, 13 Aug 2011 06:04:46 +0000 Subject: hg: jigsaw/jigsaw/jaxp: 14 new changesets Message-ID: <20110813060446.49F7C47B46@hg.openjdk.java.net> Changeset: f816d9ea0b34 Author: mr Date: 2011-05-24 15:28 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxp/rev/f816d9ea0b34 7048009: Update .jcheck/conf files for JDK 8 Reviewed-by: jjh ! .jcheck/conf Changeset: bdf77cbd9958 Author: ohair Date: 2011-05-19 08:38 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxp/rev/bdf77cbd9958 7044493: Incorrectly formated GPL headers in JDK7 JAXP source drop Reviewed-by: joehw ! jaxp.properties Changeset: 775dd77e4730 Author: lana Date: 2011-05-20 21:00 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxp/rev/775dd77e4730 Merge Changeset: a70a042c8600 Author: jeff Date: 2011-05-27 15:01 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxp/rev/a70a042c8600 7045697: JDK7 THIRD PARTY README update Reviewed-by: lana ! THIRD_PARTY_README Changeset: 10ca7570f47f Author: lana Date: 2011-06-02 13:37 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxp/rev/10ca7570f47f Merge Changeset: bcd31fa1e3c6 Author: schien Date: 2011-06-07 14:01 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxp/rev/bcd31fa1e3c6 Added tag jdk7-b145 for changeset 10ca7570f47f ! .hgtags Changeset: bae5f389d17b Author: schien Date: 2011-06-08 10:21 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxp/rev/bae5f389d17b Merge Changeset: 9a4d09f33f01 Author: schien Date: 2011-06-20 16:25 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxp/rev/9a4d09f33f01 Added tag jdk7-b146 for changeset bcd31fa1e3c6 ! .hgtags Changeset: 03692de33ca8 Author: schien Date: 2011-06-20 17:28 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxp/rev/03692de33ca8 Merge Changeset: eed2486cb10b Author: jeff Date: 2011-06-22 10:10 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxp/rev/eed2486cb10b 7057046: Add embedded license to THIRD PARTY README Reviewed-by: lana ! THIRD_PARTY_README Changeset: fc268cd1dd5d Author: lana Date: 2011-06-22 12:40 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxp/rev/fc268cd1dd5d Merge Changeset: 6c9ac74190a0 Author: schien Date: 2011-06-27 13:21 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxp/rev/6c9ac74190a0 Added tag jdk7-b147 for changeset fc268cd1dd5d ! .hgtags Changeset: 58dfc6f729e8 Author: schien Date: 2011-06-27 14:10 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxp/rev/58dfc6f729e8 Merge Changeset: cf83abcfb2d5 Author: mchung Date: 2011-08-12 14:10 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxp/rev/cf83abcfb2d5 Merge ! .hgtags From mandy.chung at oracle.com Fri Aug 12 23:04:56 2011 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Sat, 13 Aug 2011 06:04:56 +0000 Subject: hg: jigsaw/jigsaw/jaxws: 23 new changesets Message-ID: <20110813060457.42AF047B47@hg.openjdk.java.net> Changeset: b52d1b2f4a52 Author: mr Date: 2011-05-24 15:28 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxws/rev/b52d1b2f4a52 7048009: Update .jcheck/conf files for JDK 8 Reviewed-by: jjh ! .jcheck/conf Changeset: c902e39c384e Author: jeff Date: 2011-05-27 15:01 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxws/rev/c902e39c384e 7045697: JDK7 THIRD PARTY README update Reviewed-by: lana ! THIRD_PARTY_README Changeset: bcca8afc019f Author: ohair Date: 2011-06-01 10:36 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxws/rev/bcca8afc019f 7049699: Problem with xml/jax-ws Reviewed-by: ramap ! jaxws.properties Changeset: 42bfba80beb7 Author: lana Date: 2011-06-02 13:37 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxws/rev/42bfba80beb7 Merge Changeset: 6ec12c60ad13 Author: schien Date: 2011-06-07 14:01 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxws/rev/6ec12c60ad13 Added tag jdk7-b145 for changeset 42bfba80beb7 ! .hgtags Changeset: 1b7851b9e113 Author: schien Date: 2011-06-08 10:21 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxws/rev/1b7851b9e113 Merge Changeset: 581dab3f0773 Author: asaha Date: 2011-04-21 16:15 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxws/rev/581dab3f0773 Merge Changeset: 26610bb80151 Author: asaha Date: 2011-05-04 12:00 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxws/rev/26610bb80151 Merge Changeset: c6ff860428c7 Author: asaha Date: 2011-05-05 22:28 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxws/rev/c6ff860428c7 Merge Changeset: f4e1caef46d0 Author: asaha Date: 2011-05-24 11:11 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxws/rev/f4e1caef46d0 Merge Changeset: 9896cee00786 Author: asaha Date: 2011-05-26 17:25 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxws/rev/9896cee00786 Merge Changeset: d1febdcb0351 Author: asaha Date: 2011-05-26 21:36 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxws/rev/d1febdcb0351 Merge Changeset: 239c80c331da Author: asaha Date: 2011-06-06 10:19 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxws/rev/239c80c331da Merge Changeset: 09412171ca4b Author: asaha Date: 2011-06-03 07:54 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxws/rev/09412171ca4b Merge Changeset: 9d8fd0982fb8 Author: asaha Date: 2011-06-06 10:54 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxws/rev/9d8fd0982fb8 Merge Changeset: 05469dd4c366 Author: lana Date: 2011-06-15 16:04 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxws/rev/05469dd4c366 Merge Changeset: faa394edbfe3 Author: schien Date: 2011-06-20 16:25 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxws/rev/faa394edbfe3 Added tag jdk7-b146 for changeset 05469dd4c366 ! .hgtags Changeset: 9244c440c0df Author: schien Date: 2011-06-20 17:28 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxws/rev/9244c440c0df Merge Changeset: 632e38191caa Author: jeff Date: 2011-06-22 10:10 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxws/rev/632e38191caa 7057046: Add embedded license to THIRD PARTY README Reviewed-by: lana ! THIRD_PARTY_README Changeset: d13b1f877bb5 Author: lana Date: 2011-06-22 12:41 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxws/rev/d13b1f877bb5 Merge Changeset: 2605f832dfbf Author: schien Date: 2011-06-27 13:21 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxws/rev/2605f832dfbf Added tag jdk7-b147 for changeset d13b1f877bb5 ! .hgtags Changeset: 47022a1b59be Author: schien Date: 2011-06-27 14:10 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxws/rev/47022a1b59be Merge Changeset: d04925491f72 Author: mchung Date: 2011-08-12 14:10 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxws/rev/d04925491f72 Merge ! .hgtags From mandy.chung at oracle.com Fri Aug 12 22:56:54 2011 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Sat, 13 Aug 2011 05:56:54 +0000 Subject: hg: jigsaw/jigsaw/jdk: 136 new changesets Message-ID: <20110813061941.6352B47B48@hg.openjdk.java.net> Changeset: 3f760b347d3b Author: mr Date: 2011-05-24 15:28 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/3f760b347d3b 7048009: Update .jcheck/conf files for JDK 8 Reviewed-by: jjh ! .jcheck/conf Changeset: f09930d526ba Author: jrose Date: 2011-05-26 17:37 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/f09930d526ba 7032323: code changes for JSR 292 EG adjustments to API, through Public Review Summary: API code changes and javadoc changes following JSR 292 Public Review comments, through PFD Reviewed-by: never ! src/share/classes/java/lang/BootstrapMethodError.java ! src/share/classes/java/lang/ClassValue.java ! src/share/classes/java/lang/invoke/AdapterMethodHandle.java ! src/share/classes/java/lang/invoke/BoundMethodHandle.java ! src/share/classes/java/lang/invoke/CallSite.java ! src/share/classes/java/lang/invoke/ConstantCallSite.java ! src/share/classes/java/lang/invoke/Invokers.java ! src/share/classes/java/lang/invoke/MemberName.java ! src/share/classes/java/lang/invoke/MethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleNatives.java + src/share/classes/java/lang/invoke/MethodHandleProxies.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/java/lang/invoke/MethodType.java ! src/share/classes/java/lang/invoke/MutableCallSite.java ! src/share/classes/java/lang/invoke/SwitchPoint.java ! src/share/classes/java/lang/invoke/package-info.java ! src/share/classes/sun/invoke/util/ValueConversions.java ! src/share/classes/sun/invoke/util/VerifyAccess.java ! src/share/classes/sun/invoke/util/Wrapper.java ! test/java/lang/invoke/6998541/Test6998541.java ! test/java/lang/invoke/InvokeDynamicPrintArgs.java ! test/java/lang/invoke/InvokeGenericTest.java ! test/java/lang/invoke/JavaDocExamplesTest.java ! test/java/lang/invoke/MethodHandlesTest.java ! test/java/lang/invoke/indify/Indify.java Changeset: 81f957f86ba5 Author: jcoomes Date: 2011-05-27 19:03 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/81f957f86ba5 Merge Changeset: bc97b962330e Author: mfang Date: 2011-05-26 20:32 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/bc97b962330e 7045184: GTK L&F doesn't have hotkeys in jdk7 b141, while b139 has. Reviewed-by: yhuang, ogino ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk.properties Changeset: 6943c4d9caa3 Author: mfang Date: 2011-05-31 13:58 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/6943c4d9caa3 Merge Changeset: 7c5bc5a807ee Author: dholmes Date: 2011-05-27 19:04 -0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/7c5bc5a807ee 7024120: Verify reduced JRE contents for java 7 Summary: stripped all symbols from libs and executables to reduce JRE size. Restored missing classes needed to pass JCK in headless mode Reviewed-by: bobv, ohair ! make/common/Defs-embedded.gmk ! make/common/Release-embedded.gmk Changeset: f4895b3fe1be Author: dholmes Date: 2011-05-31 17:28 -0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/f4895b3fe1be Merge Changeset: eab27338b3d9 Author: schien Date: 2011-06-01 11:16 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/eab27338b3d9 Merge Changeset: 8d91855a1f4e Author: prr Date: 2011-05-27 13:25 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/8d91855a1f4e 7046587: Outlines in OTF/CFF fonts are misclassified as quadratic curves Reviewed-by: igor ! src/share/classes/sun/font/FileFontStrike.java ! src/share/classes/sun/font/FontScaler.java ! src/share/classes/sun/font/FreetypeFontScaler.java ! src/share/classes/sun/font/NullFontScaler.java Changeset: 0b0b92707cf5 Author: bae Date: 2011-05-30 12:05 +0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/0b0b92707cf5 7032904: XRender: Java2Demo : Infinite loop in Java_sun_java2d_loops_MaskBlit_MaskBlit on OEL 5.6 x64 Reviewed-by: prr ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java ! src/solaris/native/sun/java2d/x11/XRBackendNative.c Changeset: 290daca0a693 Author: prr Date: 2011-05-30 22:00 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/290daca0a693 7049874: OpenJDK Build breakage fix: freetypescaler.c needs to match updated signature Reviewed-by: lana, igor ! src/share/native/sun/font/freetypeScaler.c Changeset: b351af09bfa3 Author: lana Date: 2011-06-02 13:35 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/b351af09bfa3 Merge Changeset: d2081a1f417f Author: bagiras Date: 2011-05-27 11:45 +0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/d2081a1f417f 7045174: Most of the tests in awt area fails with jdk 7b142 on windows with -Xcheck:jni Reviewed-by: art, denis ! src/windows/native/sun/windows/awt_Object.cpp ! src/windows/native/sun/windows/awt_Toolkit.cpp Changeset: 000a845b1e38 Author: denis Date: 2011-05-28 12:56 +0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/000a845b1e38 7046325: Broken links in java.awt.Toolkit's javadoc Reviewed-by: dav, yan ! src/share/classes/java/awt/Toolkit.java Changeset: eab94f59b6dc Author: dcherepanov Date: 2011-05-30 13:25 +0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/eab94f59b6dc 7045354: Korean IME's Hanja candidate window is not displayed on IMFDemo Reviewed-by: art, ant ! src/windows/native/sun/windows/awt_Component.cpp Changeset: f05164caa490 Author: serb Date: 2011-05-30 17:16 +0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/f05164caa490 7045193: interactive JCK tests java_awt/interactive/FileDialogTests fail Reviewed-by: dcherepanov, dav, art, denis ! src/solaris/classes/sun/awt/X11/GtkFileDialogPeer.java Changeset: b955226868af Author: lana Date: 2011-06-02 13:36 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/b955226868af Merge Changeset: 1fbaf2b688a6 Author: rupashka Date: 2011-05-24 11:37 +0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/1fbaf2b688a6 7045593: Possible Regression : JTextfield cursor placement behavior algorithm has changed. Reviewed-by: peterz ! src/share/classes/javax/swing/text/Utilities.java + test/javax/swing/text/Utilities/bug7045593.java Changeset: 442237d3ec2c Author: rupashka Date: 2011-05-28 11:55 +0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/442237d3ec2c 7048204: NPE from NimbusLookAndFeel.addDefault Reviewed-by: peterz ! src/share/classes/javax/swing/plaf/nimbus/NimbusLookAndFeel.java + test/javax/swing/plaf/nimbus/Test7048204.java Changeset: 386516fdf40b Author: lana Date: 2011-06-02 13:37 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/386516fdf40b Merge Changeset: 0a80650409e1 Author: mullan Date: 2011-05-24 14:15 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/0a80650409e1 7044443: Permissions resolved incorrectly for jar protocol (Patch from bugs.openjdk.java.net) Reviewed-by: alanb, chegar Contributed-by: dbhole at redhat.com ! src/share/classes/sun/security/provider/PolicyFile.java + test/java/security/Policy/GetPermissions/JarURL.java Changeset: ace2dfdecda1 Author: mullan Date: 2011-05-24 14:32 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/ace2dfdecda1 Merge Changeset: 70942be348af Author: jeff Date: 2011-05-27 15:02 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/70942be348af 7045697: JDK7 THIRD PARTY README update Reviewed-by: lana ! THIRD_PARTY_README Changeset: b49a0af85821 Author: vinnie Date: 2011-05-30 16:37 +0100 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/b49a0af85821 7049173: Replace the software license for ECC native code Reviewed-by: alanb ! src/share/native/sun/security/ec/impl/ec.c ! src/share/native/sun/security/ec/impl/ec.h ! src/share/native/sun/security/ec/impl/ec2.h ! src/share/native/sun/security/ec/impl/ec2_163.c ! src/share/native/sun/security/ec/impl/ec2_193.c ! src/share/native/sun/security/ec/impl/ec2_233.c ! src/share/native/sun/security/ec/impl/ec2_aff.c ! src/share/native/sun/security/ec/impl/ec2_mont.c ! src/share/native/sun/security/ec/impl/ec_naf.c ! src/share/native/sun/security/ec/impl/ecc_impl.h ! src/share/native/sun/security/ec/impl/ecdecode.c ! src/share/native/sun/security/ec/impl/ecl-curve.h ! src/share/native/sun/security/ec/impl/ecl-exp.h ! src/share/native/sun/security/ec/impl/ecl-priv.h ! src/share/native/sun/security/ec/impl/ecl.c ! src/share/native/sun/security/ec/impl/ecl.h ! src/share/native/sun/security/ec/impl/ecl_curve.c ! src/share/native/sun/security/ec/impl/ecl_gf.c ! src/share/native/sun/security/ec/impl/ecl_mult.c ! src/share/native/sun/security/ec/impl/ecp.h ! src/share/native/sun/security/ec/impl/ecp_192.c ! src/share/native/sun/security/ec/impl/ecp_224.c ! src/share/native/sun/security/ec/impl/ecp_256.c ! src/share/native/sun/security/ec/impl/ecp_384.c ! src/share/native/sun/security/ec/impl/ecp_521.c ! src/share/native/sun/security/ec/impl/ecp_aff.c ! src/share/native/sun/security/ec/impl/ecp_jac.c ! src/share/native/sun/security/ec/impl/ecp_jm.c ! src/share/native/sun/security/ec/impl/ecp_mont.c ! src/share/native/sun/security/ec/impl/logtab.h ! src/share/native/sun/security/ec/impl/mp_gf2m-priv.h ! src/share/native/sun/security/ec/impl/mp_gf2m.c ! src/share/native/sun/security/ec/impl/mp_gf2m.h ! src/share/native/sun/security/ec/impl/mpi-config.h ! src/share/native/sun/security/ec/impl/mpi-priv.h ! src/share/native/sun/security/ec/impl/mpi.c ! src/share/native/sun/security/ec/impl/mpi.h ! src/share/native/sun/security/ec/impl/mplogic.c ! src/share/native/sun/security/ec/impl/mplogic.h ! src/share/native/sun/security/ec/impl/mpmontg.c ! src/share/native/sun/security/ec/impl/mpprime.h ! src/share/native/sun/security/ec/impl/oid.c ! src/share/native/sun/security/ec/impl/secitem.c ! src/share/native/sun/security/ec/impl/secoidt.h Changeset: 4ed7c877a463 Author: michaelm Date: 2011-05-30 23:36 +0100 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/4ed7c877a463 7042550: Reintegrate 6569621 Reviewed-by: chegar, alanb ! src/share/classes/java/net/InetAddress.java ! src/share/classes/java/net/Socket.java ! src/share/classes/java/net/SocketPermission.java + src/share/classes/sun/net/RegisteredDomain.java ! src/share/classes/sun/net/www/URLConnection.java ! src/share/classes/sun/net/www/http/HttpClient.java Changeset: c79a089ae13b Author: wetmore Date: 2011-05-31 12:45 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/c79a089ae13b 7042097: JDK 7's Unlimited Cryptographic Policy bundle text files must be updated. Reviewed-by: valeriep ! make/javax/crypto/Makefile Changeset: a00f48c96345 Author: lancea Date: 2011-06-02 12:02 -0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/a00f48c96345 7049107: Cannot call initCause() on BatchUpdateException Reviewed-by: darcy ! src/share/classes/java/sql/BatchUpdateException.java Changeset: 39de8937c1d8 Author: lana Date: 2011-06-02 13:38 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/39de8937c1d8 Merge Changeset: 8318d03e1766 Author: jrose Date: 2011-06-01 23:56 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/8318d03e1766 7049415: Failure of resolution of sym.reference to the c.s.s. should be wrapped in BootstrapMethodError Summary: Wrap invokedynamic linkage errors in BootstrapMethodError, as needed. Reviewed-by: never ! src/share/classes/java/lang/invoke/MethodHandleNatives.java Changeset: 0b8b6eace473 Author: jrose Date: 2011-06-01 23:56 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/0b8b6eace473 7050328: (jsr-292) findConstructor throws ExceptionInInitializerError if run under SecurityManager Summary: Wrap system property and reflection accesses under doPrivileged. Ensure constant pool linkage bypasses the SM as specified. Reviewed-by: kvn, never ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleNatives.java ! src/share/classes/java/lang/invoke/MethodHandleStatics.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/sun/invoke/util/ValueConversions.java ! test/java/lang/invoke/InvokeDynamicPrintArgs.java Changeset: 34481a4012c3 Author: jrose Date: 2011-06-01 23:56 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/34481a4012c3 7049122: java/lang/invoke/RicochetTest.java with MAX_ARITY=255 in -Xcomp mode overflows code cache Summary: reduce the scope of the unit test (mark high water mark of testing with @ignore tags) Reviewed-by: never ! test/java/lang/invoke/RicochetTest.java Changeset: 802994506203 Author: jrose Date: 2011-06-03 11:20 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/802994506203 7051206: JSR 292 method name SwitchPoint.isValid is misleading to unwary users; should be hasBeenInvalidated Reviewed-by: kvn, never, ysr ! src/share/classes/java/lang/invoke/SwitchPoint.java ! test/java/lang/invoke/JavaDocExamplesTest.java Changeset: e8e6cdff5995 Author: trims Date: 2011-06-03 20:13 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/e8e6cdff5995 Merge Changeset: 8f19b165347b Author: bae Date: 2011-06-04 23:08 +0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/8f19b165347b 7042594: 3 testis api/java_awt/Color/ICC_ProfileRGB/index.html fail against RI b138 OEL6x64. Reviewed-by: prr ! src/share/classes/java/awt/color/ICC_Profile.java ! src/share/native/sun/java2d/cmm/lcms/LCMS.c ! src/share/native/sun/java2d/cmm/lcms/cmsio0.c ! test/sun/java2d/cmm/ProfileOp/ReadWriteProfileTest.java + test/sun/java2d/cmm/ProfileOp/SetDataTest.java Changeset: bbb4cef2208b Author: lana Date: 2011-06-04 17:30 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/bbb4cef2208b Merge Changeset: 03a828e368ca Author: rupashka Date: 2011-06-04 01:13 +0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/03a828e368ca 6977587: GTK L&F: jnlp: java.io.IOException thrown when choosing more than 1 file in the dialog Reviewed-by: alexp ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKFileChooserUI.java Changeset: 6c9c55ae313b Author: lana Date: 2011-06-03 22:14 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/6c9c55ae313b Merge Changeset: e81d259442ed Author: lana Date: 2011-06-04 17:32 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/e81d259442ed Merge Changeset: 53d759eb580c Author: alanb Date: 2011-06-04 11:18 +0100 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/53d759eb580c 7050358: (fs spec) Path.toUri doesn't allow custom providers to use opaque URIs Reviewed-by: sherman ! src/share/classes/java/nio/file/Path.java Changeset: 49aef5a5416e Author: mullan Date: 2011-06-04 06:45 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/49aef5a5416e 7050329: test/java/security/Policy/GetPermissions/JarURL.java fails on Windows Reviewed-by: alanb ! test/java/security/Policy/GetPermissions/JarURL.java + test/java/security/Policy/GetPermissions/JarURL.policy Changeset: 1f39ca0b9598 Author: mullan Date: 2011-06-04 06:52 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/1f39ca0b9598 Merge Changeset: 1e04b38b3824 Author: lana Date: 2011-06-04 17:33 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/1e04b38b3824 Merge Changeset: 7a341c412ea9 Author: schien Date: 2011-06-07 14:01 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/7a341c412ea9 Added tag jdk7-b145 for changeset 1e04b38b3824 ! .hgtags Changeset: e7493c32e598 Author: schien Date: 2011-06-08 10:24 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/e7493c32e598 Merge Changeset: ae731399e525 Author: dav Date: 2011-06-07 22:58 +0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/ae731399e525 7048568: Crash in Java_sun_awt_Win32GraphicsEnvironment_isVistaOS Reviewed-by: dcherepanov, art, amenkov ! src/windows/native/sun/windows/awt_Win32GraphicsDevice.cpp Changeset: f08fcae94813 Author: lana Date: 2011-06-10 11:43 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/f08fcae94813 Merge Changeset: 6e961c328276 Author: michaelm Date: 2011-06-08 10:56 +0100 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/6e961c328276 7050028: ISE "zip file closed" from JarURLConnection.getInputStream on JDK 7 when !useCaches Reviewed-by: chegar, alanb ! src/share/classes/sun/misc/URLClassPath.java + test/java/net/URLClassLoader/B7050028.java Changeset: b6ced5ad7a62 Author: dwanvik Date: 2011-06-10 17:44 +0200 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/b6ced5ad7a62 7046557: Changes to the Java DB README files in JDK7 Summary: Update /README.html with correct mention of Java DB, add JDK specific README files to /db and /demo/db. Reviewed-by: ohair ! make/common/Release.gmk Changeset: 646ab254ff80 Author: lana Date: 2011-06-10 11:44 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/646ab254ff80 Merge Changeset: aca0dc2b921c Author: weijun Date: 2011-02-09 11:50 +0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/aca0dc2b921c 6618658: Deserialization allows creation of mutable SignedObject Reviewed-by: hawtin, mullan ! src/share/classes/java/security/SignedObject.java + test/java/security/SignedObject/Correctness.java Changeset: df445f522425 Author: bae Date: 2011-02-17 12:21 +0300 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/df445f522425 7013519: [parfait] Integer overflows in 2D code Reviewed-by: prr, valeriep ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c ! src/share/native/sun/font/layout/SunLayoutEngine.cpp Changeset: ccb2fcfb6d6b Author: chegar Date: 2011-02-18 13:31 +0000 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/ccb2fcfb6d6b 7013969: NetworkInterface.toString can reveal bindings Reviewed-by: alanb, michaelm, hawtin ! src/share/classes/java/net/NetworkInterface.java Changeset: 026adaac71f1 Author: dcherepanov Date: 2011-02-25 15:54 +0300 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/026adaac71f1 7012520: Heap overflow vulnerability in FileDialog.show() Reviewed-by: art, anthony ! src/windows/native/sun/windows/awt_FileDialog.cpp Changeset: d489f00d6c65 Author: flar Date: 2011-03-02 05:35 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/d489f00d6c65 7016495: Crash in Java 2D transforming an image with scale close to zero Reviewed-by: prr, bae ! src/share/classes/sun/java2d/pipe/DrawImage.java ! src/share/native/sun/java2d/loops/TransformHelper.c + test/java/awt/image/BufferedImage/TinyScale.java Changeset: fe27fe44ac51 Author: ksrini Date: 2011-03-03 14:16 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/fe27fe44ac51 7016985: (launcher) implement safe secure dll loading Reviewed-by: mchung ! src/windows/bin/java_md.c Changeset: 0efa64f13302 Author: chegar Date: 2011-04-05 14:49 +0100 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/0efa64f13302 7033865: JDK: Add private API for secure/restrictive loading of system dlls Reviewed-by: alanb ! src/share/native/common/jdk_util.h + src/solaris/native/common/jdk_util_md.h ! src/windows/native/common/jdk_util_md.c + src/windows/native/common/jdk_util_md.h Changeset: 67992a58bfba Author: ksrini Date: 2011-04-05 16:19 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/67992a58bfba 7032593: DLL_LOADING: Upgrade solution to 7016985 to reflect JDK7 solution Reviewed-by: mchung, asaha ! src/windows/bin/java_md.c Changeset: 7181441faf72 Author: dcherepanov Date: 2011-04-08 16:44 +0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/7181441faf72 7003962: AWT: securely load DLLs and launch executables using fully qualified path Reviewed-by: art, bae, alanb ! src/windows/native/sun/java2d/d3d/D3DPipelineManager.cpp ! src/windows/native/sun/java2d/opengl/OGLFuncs_md.h ! src/windows/native/sun/windows/DllUtil.cpp ! src/windows/native/sun/windows/DllUtil.h ! src/windows/native/sun/windows/ShellFolder2.cpp ! src/windows/native/sun/windows/ThemeReader.cpp ! src/windows/native/sun/windows/awt_Mlib.cpp ! src/windows/native/sun/windows/awt_TextArea.cpp ! src/windows/native/sun/windows/awt_TrayIcon.cpp ! src/windows/native/sun/windows/awt_Win32GraphicsEnv.cpp ! src/windows/native/sun/windows/stdhdrs.h Changeset: 05a3923f516f Author: dcherepanov Date: 2011-04-08 17:58 +0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/05a3923f516f 7035077: Minor addition to the changes for 7003962 Reviewed-by: chegar ! src/windows/native/sun/windows/DllUtil.cpp Changeset: afcc1530e68b Author: asaha Date: 2011-04-08 10:27 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/afcc1530e68b Merge - make/java/dyn/Makefile - src/share/classes/java/dyn/CallSite.java - src/share/classes/java/dyn/ClassValue.java - src/share/classes/java/dyn/ConstantCallSite.java - src/share/classes/java/dyn/InvokeDynamic.java - src/share/classes/java/dyn/InvokeDynamicBootstrapError.java - src/share/classes/java/dyn/Linkage.java - src/share/classes/java/dyn/MethodHandle.java - src/share/classes/java/dyn/MethodHandles.java - src/share/classes/java/dyn/MethodType.java - src/share/classes/java/dyn/MethodTypeForm.java - src/share/classes/java/dyn/MutableCallSite.java - src/share/classes/java/dyn/SwitchPoint.java - src/share/classes/java/dyn/VolatileCallSite.java - src/share/classes/java/dyn/WrongMethodTypeException.java - src/share/classes/java/dyn/package-info.java - src/share/classes/sun/dyn/Access.java - src/share/classes/sun/dyn/AdapterMethodHandle.java - src/share/classes/sun/dyn/BoundMethodHandle.java - src/share/classes/sun/dyn/CallSiteImpl.java - src/share/classes/sun/dyn/DirectMethodHandle.java - src/share/classes/sun/dyn/FilterGeneric.java - src/share/classes/sun/dyn/FilterOneArgument.java - src/share/classes/sun/dyn/FromGeneric.java - src/share/classes/sun/dyn/InvokeGeneric.java - src/share/classes/sun/dyn/Invokers.java - src/share/classes/sun/dyn/MemberName.java - src/share/classes/sun/dyn/MethodHandleImpl.java - src/share/classes/sun/dyn/MethodHandleNatives.java - src/share/classes/sun/dyn/MethodTypeImpl.java - src/share/classes/sun/dyn/SpreadGeneric.java - src/share/classes/sun/dyn/ToGeneric.java - src/share/classes/sun/dyn/WrapperInstance.java - src/share/classes/sun/dyn/anon/AnonymousClassLoader.java - src/share/classes/sun/dyn/anon/ConstantPoolParser.java - src/share/classes/sun/dyn/anon/ConstantPoolPatch.java - src/share/classes/sun/dyn/anon/ConstantPoolVisitor.java - src/share/classes/sun/dyn/anon/InvalidConstantPoolFormatException.java - src/share/classes/sun/dyn/empty/Empty.java - src/share/classes/sun/dyn/package-info.java - src/share/classes/sun/dyn/util/BytecodeDescriptor.java - src/share/classes/sun/dyn/util/BytecodeName.java - src/share/classes/sun/dyn/util/ValueConversions.java - src/share/classes/sun/dyn/util/VerifyAccess.java - src/share/classes/sun/dyn/util/VerifyType.java - src/share/classes/sun/dyn/util/Wrapper.java - src/share/classes/sun/dyn/util/package-info.java ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c - test/java/dyn/ClassValueTest.java - test/java/dyn/InvokeDynamicPrintArgs.java - test/java/dyn/InvokeGenericTest.java - test/java/dyn/JavaDocExamplesTest.java - test/java/dyn/MethodHandlesTest.java - test/java/dyn/MethodTypeTest.java - test/java/dyn/indify/Indify.java Changeset: 557bd9b5d92f Author: asaha Date: 2011-04-08 10:31 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/557bd9b5d92f Merge Changeset: e142148d8b54 Author: asaha Date: 2011-04-12 14:23 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/e142148d8b54 Merge - src/share/classes/sun/security/ssl/DefaultSSLContextImpl.java Changeset: 76e0e562b617 Author: dcherepanov Date: 2011-04-15 17:06 +0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/76e0e562b617 7036952: build warning after the changes for 7003962 Reviewed-by: art, bae ! src/windows/native/sun/java2d/opengl/OGLFuncs_md.h Changeset: f8eddc85cc02 Author: zgu Date: 2011-04-15 09:53 -0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/f8eddc85cc02 7003964: SERV: securely load DLLs and launch executables using fully qualified path Summary: Linked in Windows libraries that are available on jdk7 supported platforms, and used GetModuleHandle instead of LoadLibrary for already loaded Dlls. Reviewed-by: dcubed, alanb ! make/com/sun/tools/attach/Makefile ! src/windows/classes/sun/tools/attach/WindowsAttachProvider.java ! src/windows/native/sun/tools/attach/WindowsAttachProvider.c ! src/windows/native/sun/tools/attach/WindowsVirtualMachine.c ! src/windows/native/sun/tracing/dtrace/jvm_symbols_md.c ! src/windows/npt/npt_md.h Changeset: 0865aa0ad9b2 Author: zgu Date: 2011-04-19 10:26 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/0865aa0ad9b2 Merge Changeset: 6f8a4d334fb2 Author: asaha Date: 2011-04-20 09:31 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/6f8a4d334fb2 Merge ! make/com/sun/tools/attach/Makefile ! src/share/classes/java/net/NetworkInterface.java ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c ! src/windows/bin/java_md.c ! src/windows/native/sun/windows/awt_TrayIcon.cpp ! src/windows/native/sun/windows/awt_Win32GraphicsEnv.cpp Changeset: f3645b5d6e62 Author: asaha Date: 2011-04-20 21:24 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/f3645b5d6e62 Merge Changeset: b626f78c57e1 Author: asaha Date: 2011-04-21 08:38 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/b626f78c57e1 Merge Changeset: cec45f3353be Author: asaha Date: 2011-04-21 08:37 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/cec45f3353be Merge Changeset: 6133c9ee3a01 Author: asaha Date: 2011-04-21 08:39 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/6133c9ee3a01 Merge Changeset: dd06e8d3da91 Author: asaha Date: 2011-04-21 15:43 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/dd06e8d3da91 Merge Changeset: b2295905901a Author: asaha Date: 2011-04-21 16:42 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/b2295905901a Merge - src/share/classes/sun/security/ssl/DefaultSSLContextImpl.java Changeset: 3fedf261fb4f Author: valeriep Date: 2011-04-26 15:59 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/3fedf261fb4f 7003952: SEC: securely load DLLs and launch executables using fully qualified path Summary: Enforce full path when specifying library locations. Reviewed-by: wetmore, ohair ! make/sun/security/pkcs11/Makefile ! src/share/classes/sun/security/pkcs11/Config.java ! src/share/classes/sun/security/pkcs11/Secmod.java ! src/share/native/sun/security/pkcs11/j2secmod.c + test/sun/security/pkcs11/Provider/Absolute.cfg + test/sun/security/pkcs11/Provider/Absolute.java Changeset: 94ea3b8288f1 Author: alexp Date: 2011-05-04 11:35 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/94ea3b8288f1 7020198: ImageIcon creates Component with null acc Reviewed-by: rupashka, hawtin ! src/share/classes/javax/swing/ImageIcon.java Changeset: e6fdfb249e31 Author: asaha Date: 2011-05-04 16:39 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/e6fdfb249e31 Merge - src/share/native/sun/font/layout/Features.h ! src/windows/native/sun/windows/awt_FileDialog.cpp - test/javax/swing/text/GlyphView/6539700/bug6539700.java Changeset: 49244980d692 Author: asaha Date: 2011-05-05 22:29 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/49244980d692 Merge - src/share/classes/sun/security/util/SignatureFileManifest.java Changeset: 647b031200f0 Author: asaha Date: 2011-05-06 14:33 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/647b031200f0 Merge Changeset: 92b5197e9ff5 Author: asaha Date: 2011-05-26 21:37 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/92b5197e9ff5 Merge ! src/windows/native/sun/java2d/d3d/D3DPipelineManager.cpp ! src/windows/native/sun/windows/awt_TrayIcon.cpp Changeset: cca9ea306c6e Author: asaha Date: 2011-05-26 21:51 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/cca9ea306c6e Merge Changeset: dab3e66ebda7 Author: lana Date: 2011-06-06 19:04 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/dab3e66ebda7 Merge Changeset: 9f17be5136d1 Author: wetmore Date: 2011-06-09 14:24 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/9f17be5136d1 7052537: java/security/Security/NotInstalledProviders.java is causing -samevm tests to fail. Reviewed-by: valeriep, asaha, alanb ! test/java/security/Security/NoInstalledProviders.java Changeset: 4961be00d3b5 Author: lana Date: 2011-06-15 16:10 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/4961be00d3b5 Merge Changeset: cf0632d2db2c Author: jrose Date: 2011-06-14 22:47 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/cf0632d2db2c 7052202: JSR 292: Crash in sun.invoke.util.ValueConversions.fillArray Summary: Fix corner cases involving MethodHandles.permuteArguments with long or double argument lists. Reviewed-by: twisti, never ! src/share/classes/java/lang/invoke/AdapterMethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleNatives.java ! src/share/classes/java/lang/invoke/SwitchPoint.java + test/java/lang/invoke/PermuteArgsTest.java Changeset: a65fa0f6717e Author: trims Date: 2011-06-17 16:25 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/a65fa0f6717e Merge Changeset: c46f97579fe6 Author: alanb Date: 2011-06-17 16:47 +0100 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/c46f97579fe6 7055508: (aio) EXCEPTION_ACCESS_VIOLATION in AsynchronousSocketChannel.connect on Windows 7 Reviewed-by: chegar ! src/windows/native/sun/nio/ch/WindowsAsynchronousSocketChannelImpl.c Changeset: c102e1221afa Author: lana Date: 2011-06-17 10:27 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/c102e1221afa Merge Changeset: 539e576793a8 Author: lana Date: 2011-06-18 10:12 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/539e576793a8 Merge Changeset: 7b4f4230fecf Author: schien Date: 2011-06-20 16:25 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/7b4f4230fecf Added tag jdk7-b146 for changeset 539e576793a8 ! .hgtags Changeset: f2928d86aab0 Author: schien Date: 2011-06-20 17:38 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/f2928d86aab0 Merge Changeset: cfd7602f5c52 Author: jeff Date: 2011-06-22 10:11 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/cfd7602f5c52 7057046: Add embedded license to THIRD PARTY README Reviewed-by: lana ! THIRD_PARTY_README Changeset: f097ca2434b1 Author: lana Date: 2011-06-22 12:41 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/f097ca2434b1 Merge Changeset: 9b8c96f96a0f Author: schien Date: 2011-06-27 13:21 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/9b8c96f96a0f Added tag jdk7-b147 for changeset f097ca2434b1 ! .hgtags Changeset: fc350fd41f31 Author: schien Date: 2011-06-27 14:10 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/fc350fd41f31 Merge Changeset: 685a01aa8cd2 Author: prr Date: 2011-05-25 19:53 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/685a01aa8cd2 7044394: TrueTypeFont inner class DirectoryEntry should be static Reviewed-by: bae, jgodinez ! src/share/classes/sun/font/TrueTypeFont.java Changeset: 73d420a7199b Author: dlila Date: 2011-06-24 16:22 -0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/73d420a7199b 7049339: AnyBlit is broken with non-rectangular clips. Reviewed-by: flar ! src/share/classes/sun/java2d/loops/Blit.java + test/sun/java2d/loops/Bug7049339.java Changeset: bb481604e929 Author: lana Date: 2011-06-30 14:16 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/bb481604e929 Merge Changeset: b8bcb12acea6 Author: weijun Date: 2011-05-27 09:01 +0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/b8bcb12acea6 7048466: Move sun.misc.JavaxSecurityAuthKerberosAccess to sun.security.krb5 package Reviewed-by: weijun, alanb Contributed-by: Mandy Chung ! src/share/classes/javax/security/auth/kerberos/JavaxSecurityAuthKerberosAccessImpl.java ! src/share/classes/javax/security/auth/kerberos/KeyTab.java - src/share/classes/sun/misc/JavaxSecurityAuthKerberosAccess.java ! src/share/classes/sun/misc/SharedSecrets.java ! src/share/classes/sun/security/jgss/krb5/Krb5Util.java + src/share/classes/sun/security/krb5/JavaxSecurityAuthKerberosAccess.java + src/share/classes/sun/security/krb5/KerberosSecrets.java Changeset: 0da0a4d22fba Author: dcubed Date: 2011-06-01 17:10 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/0da0a4d22fba 7048308: 4/4 LoggingDeadlock3 test timeout is too small Summary: Change timeout for test from 15 seconds to 80 seconds. Reviewed-by: dholmes ! test/java/util/logging/LoggingDeadlock3.java Changeset: 4a221501079a Author: dcubed Date: 2011-06-01 17:11 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/4a221501079a 7045594: 4/4 fix for 6977677 introduced a ResourceBundle race Summary: Fix Logger.getLogger() ResourceBundle name race. Reviewed-by: dholmes, mchung ! src/share/classes/java/util/logging/Logger.java + test/java/util/logging/LoggerResourceBundleRace.java + test/java/util/logging/RacingThreadsTest.java Changeset: 9b678733fa51 Author: weijun Date: 2011-06-08 14:01 +0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/9b678733fa51 7043737: klist does not detect non-existing keytab Reviewed-by: valeriep ! src/windows/classes/sun/security/krb5/internal/tools/Klist.java + test/sun/security/krb5/tools/ktmissing.sh Changeset: 958eea7dd46e Author: darcy Date: 2011-06-13 12:17 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/958eea7dd46e 7052122: Update JDK_MINOR_VERSION for JDK 8 Reviewed-by: mr, katleman ! make/common/shared/Defs.gmk ! make/docs/Makefile Changeset: 08fdfdb19ad6 Author: coffeys Date: 2011-06-14 18:05 +0100 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/08fdfdb19ad6 7049774: UID construction appears to hang if time changed backwards Reviewed-by: alanb, dholmes, chegar, mduigou ! src/share/classes/java/rmi/server/UID.java Changeset: 4e7a9fa84dea Author: darcy Date: 2011-06-14 12:31 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/4e7a9fa84dea 7054669: javadoc warnings from java.awt.Toolkit Reviewed-by: anthony ! src/share/classes/java/awt/Toolkit.java Changeset: 33e6291f3251 Author: darcy Date: 2011-06-15 08:37 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/33e6291f3251 7041252: Use j.u.Objects.equals in security classes Reviewed-by: weijun ! src/share/classes/sun/security/tools/KeyTool.java ! src/share/classes/sun/security/x509/DistributionPoint.java ! src/share/classes/sun/security/x509/DistributionPointName.java Changeset: 85480980cd5e Author: darcy Date: 2011-06-17 10:34 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/85480980cd5e 7021922: java.lang.annoation.IncompleteExceptions throws NPE when type is null Reviewed-by: alanb, forax ! src/share/classes/java/lang/annotation/IncompleteAnnotationException.java + test/java/lang/annotation/TestIncompleteAnnotationExceptionNPE.java Changeset: e373b4c95b4b Author: ksrini Date: 2011-06-17 15:17 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/e373b4c95b4b 7043125: TEST: tools/launcher/VersionCheck.java fails just against openjdk7 (b141 & b138-nightly) promoted Reviewed-by: darcy ! test/tools/launcher/ExecutionEnvironment.java ! test/tools/launcher/VersionCheck.java Changeset: b29888e74be3 Author: alanb Date: 2011-06-19 11:15 +0100 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/b29888e74be3 7056489: test/com/sun/jndi/ldap/ReadTimeoutTest.java hangs or times out Reviewed-by: forax, vinnie ! test/ProblemList.txt ! test/com/sun/jndi/ldap/ReadTimeoutTest.java Changeset: 82706552f7a3 Author: weijun Date: 2011-06-20 17:38 +0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/82706552f7a3 7054428: test/java/security/SecureClassLoader/DefineClassByteBuffer.java error Reviewed-by: alanb ! test/ProblemList.txt ! test/java/security/SecureClassLoader/DefineClassByteBuffer.java Changeset: 411d02c13385 Author: dl Date: 2011-06-20 12:27 +0100 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/411d02c13385 7051516: ThreadLocalRandom seed is never initialized so all instances generate the same sequence Reviewed-by: chegar, dholmes, mduigou ! src/share/classes/java/util/Random.java Changeset: a015dda3bdc6 Author: weijun Date: 2011-06-20 19:17 +0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/a015dda3bdc6 7054918: jdk_security1 test target cleanup Reviewed-by: alanb, smarks, vinnie ! test/ProblemList.txt ! test/java/security/BasicPermission/PermClass.java ! test/java/security/BasicPermission/SerialVersion.java ! test/java/security/KeyFactory/Failover.java ! test/java/security/KeyPairGenerator/Failover.java ! test/java/security/Provider/ChangeProviders.java ! test/java/security/Provider/GetInstance.java ! test/java/security/Provider/RemoveProvider.java ! test/java/security/Provider/Turkish.java ! test/java/security/Security/ClassLoaderDeadlock/Deadlock2.sh ! test/java/security/Security/NoInstalledProviders.java ! test/java/security/Security/SynchronizedAccess.java ! test/java/security/Security/removing/RemoveProviders.java ! test/java/security/UnresolvedPermission/Equals.java ! test/java/security/spec/EllipticCurveMatch.java + test/java/security/testlibrary/ProvidersSnapshot.java Changeset: 3c8f939ced1c Author: darcy Date: 2011-06-20 17:20 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/3c8f939ced1c 7055295: (reflect) add conventional constructor to GenericSignatureFormatError Reviewed-by: lancea, mduigou ! src/share/classes/java/lang/reflect/GenericSignatureFormatError.java Changeset: 70f14c2db078 Author: alanb Date: 2011-06-21 16:11 +0100 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/70f14c2db078 7056815: test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh times out intermittently on busy machine Reviewed-by: mchung ! test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh Changeset: 0bde4bed86e5 Author: alanb Date: 2011-06-22 15:13 +0100 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/0bde4bed86e5 7056447: test/java/lang/management/ManagementFactory/MBeanServerMXBeanUnsupportedTest.java fails in agentvm Reviewed-by: emcmanus ! test/java/lang/management/ManagementFactory/MBeanServerMXBeanUnsupportedTest.java Changeset: febb7f557135 Author: weijun Date: 2011-06-23 09:27 +0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/febb7f557135 7055362: jdk_security2 test target cleanup Reviewed-by: alanb ! test/Makefile ! test/ProblemList.txt ! test/com/sun/crypto/provider/Cipher/DES/Sealtest.java ! test/com/sun/crypto/provider/Cipher/RSA/TestOAEP_KAT.java ! test/javax/crypto/EncryptedPrivateKeyInfo/GetKeySpecException.java ! test/javax/crypto/JceSecurity/SunJCE_BC_LoadOrdering.java Changeset: 3b7193ab0d87 Author: xuelei Date: 2011-06-22 19:37 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/3b7193ab0d87 6952814: sun/security/ssl/com/sun/net/ssl/internal/ssl/InputRecord/InterruptedIO.java failing in PIT Reviewed-by: alanb - test/sun/security/ssl/com/sun/net/ssl/internal/ssl/InputRecord/InterruptedIO.java Changeset: 57265bf4b36b Author: xuelei Date: 2011-06-22 21:21 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/57265bf4b36b 7058271: Remove InterruptedIO.java record from ProblemList.txt Reviewed-by: weijun ! test/ProblemList.txt Changeset: 6b2c14dfe9b9 Author: chegar Date: 2011-06-23 13:00 +0100 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/6b2c14dfe9b9 7057935: com/sun/nio/sctp tests should be moved out of jdk_nio and into their own target, jdk_sctp Reviewed-by: alanb ! test/Makefile ! test/ProblemList.txt Changeset: ae7211979179 Author: chegar Date: 2011-06-23 13:15 +0100 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/ae7211979179 7021010: java/lang/Thread/ThreadStateTest.java fails intermittently Reviewed-by: dholmes, alanb, mchung ! test/ProblemList.txt ! test/java/lang/Thread/ThreadStateTest.java Changeset: cd7adb545f71 Author: xuelei Date: 2011-06-23 04:23 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/cd7adb545f71 7057022: test/sun/security/pkcs11/fips/ClientJSSEServerJSSE.java has invalid jtreg tags Reviewed-by: weijun ! test/sun/security/pkcs11/fips/ClientJSSEServerJSSE.java Changeset: 151756a4037b Author: darcy Date: 2011-06-23 14:57 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/151756a4037b 6253144: Long narrowing conversion should describe the algorithm used and implied "risks" Reviewed-by: mduigou, alanb ! src/share/classes/java/lang/Byte.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/Number.java ! src/share/classes/java/lang/Short.java ! src/share/classes/java/util/concurrent/atomic/AtomicInteger.java ! src/share/classes/java/util/concurrent/atomic/AtomicLong.java Changeset: 5838c5bd185d Author: lana Date: 2011-06-22 23:23 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/5838c5bd185d Merge ! src/share/classes/java/awt/Toolkit.java ! test/java/security/Security/NoInstalledProviders.java Changeset: 5dedb265ba3e Author: lana Date: 2011-06-23 14:56 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/5dedb265ba3e Merge Changeset: b037a8bc1be8 Author: lana Date: 2011-06-23 17:21 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/b037a8bc1be8 Merge Changeset: 0ad50d4ed1cf Author: alanb Date: 2011-06-24 19:30 +0100 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/0ad50d4ed1cf 6965150: TEST_BUG: java/nio/channels/AsynchronousSocketChannel/Basic.java takes too long Reviewed-by: chegar ! test/java/nio/channels/AsynchronousSocketChannel/Basic.java Changeset: 113c75db6c8b Author: michaelm Date: 2011-06-27 12:15 +0100 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/113c75db6c8b 7059777: Remove lang tests from Problemlist.txt Reviewed-by: alanb ! test/ProblemList.txt Changeset: a053c28304e8 Author: ksrini Date: 2011-06-27 12:21 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/a053c28304e8 7046007: (launcher) Improve usage information for -verbose option Reviewed-by: darcy, alanb ! src/share/classes/sun/launcher/resources/launcher.properties Changeset: 3abc52f0a4dc Author: dholmes Date: 2011-06-27 20:13 -0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/3abc52f0a4dc 7039182: PPC: NIO: java.io.IOException: Invalid argument in sun.nio.ch.FileDispatcherImpl.read0 Summary: Allow platform specific files to be located at build time instead of generating them Reviewed-by: alanb, ohair ! make/common/Defs-embedded.gmk ! make/java/nio/Makefile Changeset: 7b5a0a141b8b Author: michaelm Date: 2011-06-28 10:07 +0100 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/7b5a0a141b8b 7058832: com/sun/net/httpserver/bugs/B6373555.java failing intermittently Reviewed-by: alanb ! test/com/sun/net/httpserver/bugs/B6373555.java Changeset: 585cc4a4528d Author: michaelm Date: 2011-06-28 10:09 +0100 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/585cc4a4528d Merge Changeset: 9bcf6217a374 Author: lana Date: 2011-06-30 14:18 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/9bcf6217a374 Merge - src/share/classes/sun/misc/JavaxSecurityAuthKerberosAccess.java - test/sun/security/ssl/com/sun/net/ssl/internal/ssl/InputRecord/InterruptedIO.java Changeset: 6444b0a364d7 Author: jrose Date: 2011-06-14 22:47 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/6444b0a364d7 7054590: (JSR-292) MethodHandleProxies.asInterfaceInstance() accepts private/protected nested interfaces Summary: fix non-compliant logic in MethodHandleProxies, fix invalid private classes in MethodHandlesTest Reviewed-by: twisti, never ! src/share/classes/java/lang/invoke/MethodHandleProxies.java ! test/java/lang/invoke/MethodHandlesTest.java Changeset: 5f3cd0cbad56 Author: jrose Date: 2011-07-13 01:40 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/5f3cd0cbad56 Merge - src/share/classes/sun/misc/JavaxSecurityAuthKerberosAccess.java - test/sun/security/ssl/com/sun/net/ssl/internal/ssl/InputRecord/InterruptedIO.java Changeset: bfc5ec581c48 Author: jrose Date: 2011-07-16 15:40 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/bfc5ec581c48 7058630: JSR 292 method handle proxy violates contract for Object methods Reviewed-by: never, twisti ! src/share/classes/java/lang/invoke/MethodHandleProxies.java ! test/java/lang/invoke/MethodHandlesTest.java Changeset: 668edf27e9c7 Author: jrose Date: 2011-07-16 15:44 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/668edf27e9c7 7058651: JSR 292 unit tests need a refresh Summary: Enhancements to unit tests. Reviewed-by: never, twisti ! test/java/lang/invoke/JavaDocExamplesTest.java ! test/java/lang/invoke/MethodHandlesTest.java ! test/java/lang/invoke/RicochetTest.java + test/java/lang/invoke/ThrowExceptionsTest.java Changeset: b42029cd1744 Author: jrose Date: 2011-07-16 15:47 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/b42029cd1744 6983728: JSR 292 remove argument count limitations Summary: Remove workarounds and limitations from before 6939861. Reviewed-by: never ! src/share/classes/java/lang/invoke/AdapterMethodHandle.java - src/share/classes/java/lang/invoke/FilterGeneric.java - src/share/classes/java/lang/invoke/FilterOneArgument.java - src/share/classes/java/lang/invoke/FromGeneric.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleNatives.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/java/lang/invoke/MethodTypeForm.java - src/share/classes/java/lang/invoke/SpreadGeneric.java - src/share/classes/java/lang/invoke/ToGeneric.java Changeset: d1771ab0a90a Author: mchung Date: 2011-08-12 14:10 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/d1771ab0a90a Merge ! .hgtags ! make/com/sun/tools/attach/Makefile ! make/common/Release.gmk ! make/common/internal/ImportComponents.gmk ! make/common/shared/Defs.gmk ! make/java/nio/Makefile ! make/javax/crypto/Makefile ! make/sun/security/pkcs11/Makefile ! src/share/bin/java.c ! src/share/bin/wildcard.c - src/share/classes/java/lang/invoke/FilterGeneric.java - src/share/classes/java/lang/invoke/FilterOneArgument.java - src/share/classes/java/lang/invoke/FromGeneric.java - src/share/classes/java/lang/invoke/SpreadGeneric.java - src/share/classes/java/lang/invoke/ToGeneric.java ! src/share/classes/org/openjdk/jigsaw/Platform.java ! src/share/classes/sun/launcher/resources/launcher.properties ! src/share/classes/sun/misc/SharedSecrets.java ! test/Makefile ! test/java/lang/module/_ModuleInfoReader.java - test/sun/security/ssl/com/sun/net/ssl/internal/ssl/InputRecord/InterruptedIO.java From mandy.chung at oracle.com Fri Aug 12 23:00:46 2011 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Sat, 13 Aug 2011 06:00:46 +0000 Subject: hg: jigsaw/jigsaw/hotspot: 84 new changesets Message-ID: <20110813060320.CE5B547B44@hg.openjdk.java.net> Changeset: e6e7d76b2bd3 Author: mr Date: 2011-05-24 15:28 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/e6e7d76b2bd3 7048009: Update .jcheck/conf files for JDK 8 Reviewed-by: jjh ! .jcheck/conf Changeset: 2b27ef5c2173 Author: kvn Date: 2011-05-20 12:46 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/2b27ef5c2173 7046096: SEGV IN C2 WITH 6U25 Summary: Missing fail flag set in strings concatenation code. Reviewed-by: never ! src/share/vm/opto/stringopts.cpp Changeset: cfbca4d74a61 Author: jcoomes Date: 2011-05-20 22:27 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/cfbca4d74a61 Merge Changeset: 789d04408ca3 Author: kvn Date: 2011-05-21 11:44 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/789d04408ca3 7045693: java/util/EnumSet/EnumSetBash.java still failing intermittently Summary: New limit for unrolled loop should be set only for zero trip guard and loop iteration test. Reviewed-by: never ! src/share/vm/opto/loopTransform.cpp Changeset: b55f5bd7ec66 Author: kvn Date: 2011-05-21 13:59 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/b55f5bd7ec66 7045506: assert(!can_reshape || !new_phi) failed: for igvn new phi should be hooked Summary: Replace the assert in PhiNode::Ideal with check to avoid transformation of new phi. Reviewed-by: never ! src/share/vm/opto/cfgnode.cpp Changeset: 7523488edce5 Author: kvn Date: 2011-05-24 12:54 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/7523488edce5 7047300: VM crashes with assert(_base == InstPtr) failed: Not an object pointer Summary: The code incorrectly used is_instptr() instead of is_oopptr() to get const_oop. Reviewed-by: never ! src/share/vm/opto/output.cpp Changeset: ccf072cdba91 Author: iveresov Date: 2011-05-24 15:30 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/ccf072cdba91 7046893: LP64 problem with double_quadword in c1_LIRAssembler_x86.cpp Summary: Fixed invalid casts in address computation Reviewed-by: kvn, never Contributed-by: thomas.salter at unisys.com ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp Changeset: 28a9fe9534ea Author: kvn Date: 2011-05-24 20:24 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/28a9fe9534ea 7048030: is_scavengable changes causing compiler to embed more constants Summary: ciObject::can_be_constant() and should_be_constant() should use is_perm() instead of !is_scavengable() Reviewed-by: never, jrose ! src/share/vm/ci/ciObject.cpp ! src/share/vm/ci/ciObject.hpp Changeset: 7db2b9499c36 Author: never Date: 2011-05-25 16:04 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/7db2b9499c36 7046732: JSR 292 assert(result == cpce->f1()) failed: expected result for assembly code Reviewed-by: kvn, iveresov, jrose ! src/share/vm/interpreter/interpreterRuntime.cpp Changeset: c7c81f18c834 Author: kvn Date: 2011-05-25 21:17 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/c7c81f18c834 7048332: Cadd_cmpLTMask doesn't handle 64-bit tmp register properly Summary: Use ins_encode %{ %} form to encode cadd_cmpLTMask() instruction and remove unused code. Reviewed-by: never ! src/cpu/x86/vm/x86_64.ad + test/compiler/7048332/Test7048332.java Changeset: 28263a73ebfb Author: iveresov Date: 2011-05-26 13:15 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/28263a73ebfb 7047491: C1: registers saved incorrectly when calling checkcast_arraycopy stub Summary: Save and restore the argument registers around the call to checkcast_arraycopy Reviewed-by: never, roland ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp Changeset: 5ac411b3b8fc Author: never Date: 2011-05-26 14:44 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/5ac411b3b8fc 7047961: JSR 292 MethodHandleWalk swap args doesn't handle T_LONG and T_DOUBLE properly Reviewed-by: kvn, jrose ! src/share/vm/prims/methodHandleWalk.cpp ! src/share/vm/prims/methodHandleWalk.hpp ! src/share/vm/prims/methodHandles.cpp Changeset: c76c13577460 Author: never Date: 2011-05-26 16:39 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/c76c13577460 Merge Changeset: b2cb497dec28 Author: kvn Date: 2011-05-27 12:47 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/b2cb497dec28 7047069: Array can dynamically change size when assigned to an object field Summary: Fix initialization of a newly-allocated array with arraycopy Reviewed-by: never ! src/share/vm/opto/library_call.cpp + test/compiler/7047069/Test7047069.java Changeset: 33e2b8f1d466 Author: kvn Date: 2011-05-31 10:05 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/33e2b8f1d466 6956668: misbehavior of XOR operator (^) with int Summary: optimize cmp_ne(xor(X,1),0) to cmp_eq(X,0) only for boolean values X. Reviewed-by: never ! src/share/vm/opto/subnode.cpp + test/compiler/6956668/Test6956668.java Changeset: 60b8287df30e Author: jrose Date: 2011-06-01 23:25 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/60b8287df30e 7049415: Failure of resolution of sym.reference to the c.s.s. should be wrapped in BootstrapMethodError Summary: Delegate invokedynamic linkage errors to MethodHandleNatives.raiseException. Reviewed-by: never ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/methodHandles.hpp Changeset: a93146d0e4be Author: jrose Date: 2011-06-01 23:25 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/a93146d0e4be 7049410: JSR 292 old method name MethodHandle.invokeGeneric should not be accepted by the JVM Summary: change the default setting of the flag AllowInvokeGeneric to false Reviewed-by: never ! src/share/vm/runtime/globals.hpp Changeset: 537a4053b0f9 Author: ysr Date: 2011-05-23 16:42 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/537a4053b0f9 7042740: CMS: assert(n> q) failed: Looping at: ... blockOffsetTable.cpp:557 Summary: Do a one-step look-ahead, when sweeping free or garbage blocks, to avoid overstepping sweep limit, which may become a non-block-boundary because of a heap expansion delta coalescing with a previously co-terminal free block. Reviewed-by: brutisso, tonyp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/memory/blockOffsetTable.cpp Changeset: f153114134c8 Author: jcoomes Date: 2011-06-07 13:17 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/f153114134c8 Merge Changeset: d3b9f2be46ab Author: coleenp Date: 2011-05-21 15:39 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/d3b9f2be46ab 7033141: assert(has_cp_cache(i)) failed: oob Summary: Unrewrite bytecodes for OOM error allocating the constant pool cache. Reviewed-by: dcubed, acorn, never ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/interpreter/rewriter.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/methodHandleWalk.cpp Changeset: 9dd6c4ba364f Author: coleenp Date: 2011-06-02 14:17 -0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/9dd6c4ba364f 7049928: VM crashes with "assert(_adapter != NULL) failed: must have" at methodOop.cpp:63 Summary: Removed extra change from another bug fix that caused this regression Reviewed-by: phh, dcubed, kvn, kamg, never ! src/share/vm/oops/methodOop.cpp Changeset: 96c891ebe56a Author: coleenp Date: 2011-06-02 21:01 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/96c891ebe56a Merge ! src/share/vm/prims/methodHandleWalk.cpp Changeset: ae1d716e395c Author: dsamersoff Date: 2011-06-09 01:33 +0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/ae1d716e395c Merge Changeset: f918d6096e23 Author: never Date: 2011-06-02 13:36 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/f918d6096e23 7050554: JSR 292 - need optimization for selectAlternative Reviewed-by: kvn, jrose ! src/share/vm/ci/ciCallProfile.hpp ! src/share/vm/ci/ciMethodHandle.cpp ! src/share/vm/ci/ciMethodHandle.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/doCall.cpp Changeset: cba7b5c2d53f Author: never Date: 2011-06-03 22:31 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/cba7b5c2d53f 7045514: SPARC assembly code for JSR 292 ricochet frames Reviewed-by: kvn, jrose ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/assembler_sparc.inline.hpp ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp + src/cpu/sparc/vm/methodHandles_sparc.hpp ! src/cpu/sparc/vm/registerMap_sparc.hpp ! src/cpu/sparc/vm/runtime_sparc.cpp ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/sparc/vm/stubRoutines_sparc.hpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.hpp ! src/cpu/x86/vm/runtime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_32.hpp ! src/cpu/x86/vm/stubRoutines_x86_64.hpp ! src/share/vm/compiler/oopMap.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/prims/methodHandleWalk.cpp ! src/share/vm/prims/methodHandleWalk.hpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/methodHandles.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp Changeset: 642c68c75db9 Author: kvn Date: 2011-06-04 10:36 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/642c68c75db9 7050280: assert(u->as_Unlock()->is_eliminated()) failed: sanity Summary: Mark all associated (same box and obj) lock and unlock nodes for elimination if some of them marked already. Reviewed-by: iveresov, never ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/macro.hpp Changeset: 5cf771a79037 Author: jrose Date: 2011-06-08 17:04 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/5cf771a79037 7047697: MethodHandle.invokeExact call for wrong method causes VM failure if run with -Xcomp Reviewed-by: never, twisti ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/frame_x86.inline.hpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/share/vm/code/pcDesc.cpp Changeset: c8f2186acf6d Author: twisti Date: 2011-06-14 12:25 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/c8f2186acf6d 7053520: JSR292: crash in invokedynamic with C1 using tiered and compressed oops Reviewed-by: iveresov, never ! src/share/vm/c1/c1_LIRGenerator.cpp Changeset: f8c9417e3571 Author: never Date: 2011-06-14 14:41 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/f8c9417e3571 7052219: JSR 292: Crash in ~BufferBlob::MethodHandles adapters Reviewed-by: twisti, kvn, jrose ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/share/vm/prims/methodHandleWalk.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/methodHandles.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/stubCodeGenerator.cpp ! src/share/vm/runtime/stubCodeGenerator.hpp Changeset: e2ce15aa3daf Author: never Date: 2011-06-14 15:20 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/e2ce15aa3daf Merge Changeset: cfcf2ba8f3eb Author: never Date: 2011-06-15 10:20 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/cfcf2ba8f3eb Merge ! src/share/vm/prims/methodHandleWalk.cpp Changeset: e2af886d540b Author: trims Date: 2011-07-01 13:07 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/e2af886d540b 7061691: Fork HS21 to HS22 - renumber Minor and build numbers of JVM Summary: Update the Minor and Build numbers for HS22 fork Reviewed-by: jcoomes ! make/hotspot_version Changeset: 1e3493ac2d11 Author: ysr Date: 2011-05-27 10:23 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/1e3493ac2d11 7048342: CMS: eob == _limit || fc->isFree() failed: Only a free chunk should allow us to cross over the limit Summary: The freeness bit was being cleared in debug code when it shouldn't have been. Also removed unused FreeChunk methods linkAfterNonNull and clearPrev. Reviewed-by: brutisso ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeChunk.hpp Changeset: 5c0a3c1858b1 Author: ysr Date: 2011-06-02 10:23 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/5c0a3c1858b1 7048782: CMS: assert(last_chunk_index_to_check<= last_chunk_index) failed: parCardTableModRefBS.cpp:359 Summary: The LNC array is sized before the start of a scavenge, while the heap may expand during a scavenge. With CMS, the last block of an arbitrary suffice of the LNC array may expand due to coalition with the expansion delta. We now take care not to attempt access past the end of the LNC array. LNC array code will be cleaned up and suitably encapsulated as part of the forthcoming performance RFE 7043675. Reviewed-by: brutisso ! src/share/vm/gc_implementation/parNew/parCardTableModRefBS.cpp Changeset: e66f38dd58a9 Author: ysr Date: 2011-06-08 08:39 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/e66f38dd58a9 Merge Changeset: 053d84a76d3d Author: tonyp Date: 2011-06-08 15:31 -0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/053d84a76d3d 7032531: G1: enhance GC logging to include more accurate eden / survivor size transitions Summary: This changeset extends the logging information generated by +PrintGCDetails to also print out separate size transitions for the eden, survivors, and old regions. Reviewed-by: ysr, brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp Changeset: ae5b2f1dcf12 Author: tonyp Date: 2011-06-08 21:48 -0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/ae5b2f1dcf12 7045662: G1: OopsInHeapRegionClosure::set_region() should not be virtual Summary: make the method non-virtual, remove five unused closures, and fix a couple of copyright typos. Reviewed-by: stefank, johnc, poonam ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1OopClosures.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.inline.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1_specialized_oop_closures.hpp ! src/share/vm/gc_implementation/g1/heapRegionSet.hpp ! src/share/vm/gc_implementation/g1/heapRegionSets.hpp Changeset: c3f1170908be Author: tonyp Date: 2011-06-10 13:16 -0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/c3f1170908be 7045330: G1: Simplify/fix the HeapRegionSeq class 7042285: G1: native memory leak during humongous object allocation 6804436: G1: heap region indices should be size_t Summary: A series of fixes and improvements to the HeapRegionSeq class: a) replace the _regions growable array with a standard C array, b) avoid de-allocating / re-allocating HeapRegion instances when the heap shrinks / grows (fix for 7042285), c) introduce fast method to map address to HeapRegion via a "biased" array pointer, d) embed the _hrs object in G1CollectedHeap, instead of pointing to it via an indirection, e) assume that all the regions added to the HeapRegionSeq instance are contiguous, f) replace int's with size_t's for indexes (and expand that to HeapRegion as part of 6804436), g) remove unnecessary / unused methods, h) rename a couple of fields (_alloc_search_start and _seq_bottom), i) fix iterate_from() not to always start from index 0 irrespective of the region passed to it, j) add a verification method to check the HeapRegionSeq assumptions, k) always call the wrappers for _hrs.iterate(), _hrs_length(), and _hrs.at() from G1CollectedHeap, not those methods di rectly, and l) unify the code that expands the sequence (by either re-using or creating a new HeapRegion) and make it robust wrt to a HeapRegion allocation failing. Reviewed-by: stefank, johnc, brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.inline.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.cpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.hpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.inline.hpp ! src/share/vm/gc_implementation/g1/sparsePRT.cpp Changeset: 2a241e764894 Author: minqi Date: 2011-06-10 15:08 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/2a241e764894 6941923: RFE: Handling large log files produced by long running Java Applications Summary: supply optinal flags to realize gc log rotation Reviewed-by: ysr, jwilhelm ! src/share/vm/gc_implementation/shared/concurrentGCThread.cpp ! src/share/vm/gc_implementation/shared/concurrentGCThread.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/atomic.cpp ! src/share/vm/runtime/atomic.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/utilities/ostream.cpp ! src/share/vm/utilities/ostream.hpp + test/gc/6941923/test6941923.sh Changeset: 42df21744b50 Author: minqi Date: 2011-06-10 15:44 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/42df21744b50 Merge Changeset: ef2d1b8f2dd4 Author: ysr Date: 2011-06-13 09:58 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/ef2d1b8f2dd4 7051430: CMS: ongoing CMS cycle should terminate abruptly to allow prompt JVM termination at exit Summary: It turns out that there is no need to explicitly stop CMS since the JVM is taken down at a terminal safepoint during which CMS threads are (terminally) inactive. This will need to be revised if and when we evolve in the future to a point where we allow JVM reincarnation in the same process, but those changes will be much more sweeping than just terminating CMS threads. The unused ::stop() methods will be removed in a separate CR. Also include in this CR is the fix for a small typo in the spelling of UseGCLogFileRotation in a message in arguments.cpp, brought to our attention by Rainer Jung and reviewed by minqi. Reviewed-by: johnc, jwilhelm ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/thread.cpp Changeset: 74cd10898bea Author: brutisso Date: 2011-06-13 13:48 +0200 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/74cd10898bea 6918185: Remove unused code for lost card-marking optimization in BacktraceBuilder Summary: Removed dead code Reviewed-by: ysr, coleenp, dholmes ! src/share/vm/classfile/javaClasses.cpp Changeset: 842b840e67db Author: tonyp Date: 2011-06-14 10:33 -0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/842b840e67db 7046558: G1: concurrent marking optimizations Summary: Some optimizations to improve the concurrent marking phase: specialize the main oop closure, make sure a few methods in the fast path are properly inlined, a few more bits and pieces, and some cosmetic fixes. Reviewed-by: stefank, johnc ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp + src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.inline.hpp ! src/share/vm/gc_implementation/g1/g1_specialized_oop_closures.hpp ! src/share/vm/utilities/bitMap.hpp Changeset: 6747fd0512e0 Author: johnc Date: 2011-06-14 11:01 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/6747fd0512e0 7004681: G1: Extend marking verification to Full GCs Summary: Perform a heap verification after the first phase of G1's full GC using objects' mark words to determine liveness. The third parameter of the heap verification routines, which was used in G1 to determine which marking bitmap to use in liveness calculations, has been changed from a boolean to an enum with values defined for using the mark word, and the 'prev' and 'next' bitmaps. Reviewed-by: tonyp, ysr ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp Changeset: 5130fa1b24f1 Author: johnc Date: 2011-06-15 10:18 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/5130fa1b24f1 7045751: G1: +ExplicitGCInvokesConcurrent causes excessive single region evacuation pauses Summary: When ExplicitGCInvokesConcurrent is enabled, do not perform an evacuation pause if a marking cycle is already in progress and block the requesting thread until the marking cycle completes. Reviewed-by: tonyp, ysr ! src/share/vm/gc_implementation/g1/vm_operations_g1.cpp Changeset: c9ca3f51cf41 Author: tonyp Date: 2011-06-16 15:51 -0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/c9ca3f51cf41 6994322: Remove the is_tlab and is_noref / is_large_noref parameters from the CollectedHeap Summary: Remove two unused parameters from the mem_allocate() method and update its uses accordingly. Reviewed-by: stefank, johnc ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp ! src/share/vm/gc_implementation/parallelScavenge/psOldGen.cpp ! src/share/vm/gc_implementation/parallelScavenge/psOldGen.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPermGen.cpp ! src/share/vm/gc_implementation/parallelScavenge/psYoungGen.hpp ! src/share/vm/gc_implementation/parallelScavenge/vmPSOperations.cpp ! src/share/vm/gc_implementation/parallelScavenge/vmPSOperations.hpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/oops/typeArrayKlass.cpp Changeset: f75137faa7fe Author: ysr Date: 2011-06-20 09:42 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/f75137faa7fe 6916968: CMS: freeList.cpp:304 assert(_allocation_stats.prevSweep() + ..., "Conservation Principle") Summary: Fix assert and adjust demand volume computation by adding missing factor. Reviewed-by: jmasa, tonyp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeList.cpp ! src/share/vm/gc_implementation/shared/allocationStats.hpp Changeset: 23d434c6290d Author: tonyp Date: 2011-06-20 22:03 -0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/23d434c6290d 7055073: G1: code cleanup in the concurrentMark.* files Summary: Only cosmetic changes to make the concurrentMark.* more consistent, code-style-wise, with the rest of the codebase. Reviewed-by: johnc, ysr ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp Changeset: e8b0b0392037 Author: tonyp Date: 2011-06-21 15:23 -0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/e8b0b0392037 7046182: G1: remove unnecessary iterations over the collection set Summary: Remove two unnecessary iterations over the collection set which are supposed to prepare the RSet's of the CSet regions for parallel iterations (we'll make sure this is done incrementally). I'll piggyback on this CR the removal of the G1_REM_SET_LOGGING code. Reviewed-by: brutisso, johnc ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.inline.hpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.hpp ! src/share/vm/gc_implementation/g1/heapRegionSets.cpp ! src/share/vm/gc_implementation/g1/heapRegionSets.hpp Changeset: 5f6f2615433a Author: tonyp Date: 2011-06-24 12:38 -0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/5f6f2615433a 7049999: G1: Make the G1PrintHeapRegions output consistent and complete Summary: Extend and make more consistent the output from the G1PrintHeapRegions flag. Reviewed-by: johnc, jmasa ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp + src/share/vm/gc_implementation/g1/g1HRPrinter.cpp + src/share/vm/gc_implementation/g1/g1HRPrinter.hpp Changeset: 04760e41b01e Author: brutisso Date: 2011-06-28 14:23 +0200 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/04760e41b01e 7016112: CMS: crash during promotion testing Summary: Also reviewed by mikael.gerdin at oracle.com; stdlib:qsort() does byte-by-byte swapping on Windows. This leads to pointer shearing. Fix is to implement a quicksort that does full pointer updates. Reviewed-by: never, coleenp, ysr ! src/share/vm/oops/methodOop.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/runtime/globals.hpp + src/share/vm/utilities/quickSort.cpp + src/share/vm/utilities/quickSort.hpp Changeset: 4bf3cbef0b3e Author: jcoomes Date: 2011-07-06 08:43 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/4bf3cbef0b3e Merge ! src/share/vm/oops/methodOop.cpp ! src/share/vm/runtime/globals.hpp Changeset: d83ac25d0304 Author: never Date: 2011-06-16 13:46 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/d83ac25d0304 7055355: JSR 292: crash while throwing WrongMethodTypeException Reviewed-by: jrose, twisti, bdelsart ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/zero/vm/cppInterpreter_zero.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/interpreterRuntime.hpp ! src/share/vm/interpreter/templateInterpreter.cpp ! src/share/vm/interpreter/templateInterpreterGenerator.hpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/stubRoutines.hpp Changeset: aacaff365100 Author: kvn Date: 2011-06-20 16:45 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/aacaff365100 7052494: Eclipse test fails on JDK 7 b142 Summary: Keep 'ne' test in Counted loop when we can't guarantee during compilation that init < limit. Reviewed-by: never ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopnode.cpp + test/compiler/7052494/Test7052494.java Changeset: de6a837d75cf Author: never Date: 2011-06-21 09:04 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/de6a837d75cf 7056380: VM crashes with SIGSEGV in compiled code Summary: code was using andq reg, imm instead of addq addr, imm Reviewed-by: kvn, jrose, twisti ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/x86_64.ad Changeset: aabf25fa3f05 Author: never Date: 2011-06-22 14:45 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/aabf25fa3f05 7057587: JSR 292 - crash with jruby in test/test_respond_to.rb Summary: don't skip receiver when GC'ing compiled invokedynamic callsites Reviewed-by: twisti, kvn, jrose ! src/share/vm/code/nmethod.cpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/parse.hpp Changeset: ddd894528dbc Author: jrose Date: 2011-06-23 17:14 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/ddd894528dbc 7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path Reviewed-by: never ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/ci/ciField.cpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethodHandle.cpp ! src/share/vm/ci/ciObjArrayKlass.cpp ! src/share/vm/ci/ciSignature.cpp ! src/share/vm/ci/ciSignature.hpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/oops/constantPoolKlass.cpp ! src/share/vm/oops/constantPoolOop.cpp ! src/share/vm/oops/constantPoolOop.hpp ! src/share/vm/oops/cpCacheOop.cpp ! src/share/vm/oops/cpCacheOop.hpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp ! src/share/vm/prims/methodHandleWalk.cpp ! src/share/vm/prims/methodHandleWalk.hpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/methodHandles.hpp Changeset: 498c6cf70f7e Author: kvn Date: 2011-06-28 14:30 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/498c6cf70f7e 7058036: FieldsAllocationStyle=2 does not work in 32-bit VM Summary: parseClassFile() incorrectly uses nonstatic_oop_map_size() method instead of nonstatic_oop_map_count(). Reviewed-by: never Contributed-by: Krystal Mok ! src/share/vm/classfile/classFileParser.cpp Changeset: 6ae7a1561b53 Author: kvn Date: 2011-06-28 15:04 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/6ae7a1561b53 6990015: Incorrect Icache line size is used for 64 bit x86 Summary: correct Icache::line_size for x64 and add verification code into vm_version_x86. Reviewed-by: never, phh ! src/cpu/x86/vm/icache_x86.hpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/vm_version_x86.hpp Changeset: e3cbc9ddd434 Author: kvn Date: 2011-06-28 15:24 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/e3cbc9ddd434 7044738: Loop unroll optimization causes incorrect result Summary: take into account memory dependencies when clonning nodes in clone_up_backedge_goo(). Reviewed-by: never ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp + test/compiler/7044738/Test7044738.java + test/compiler/7046096/Test7046096.java Changeset: 7889bbcc7f88 Author: kvn Date: 2011-06-28 15:50 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/7889bbcc7f88 7047954: VM crashes with assert(is_Mem()) failed Summary: cast constant array ptrs to bottom Reviewed-by: never ! src/share/vm/opto/compile.cpp Changeset: 6f6e91603a45 Author: iveresov Date: 2011-07-01 10:35 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/6f6e91603a45 7058689: Tiered: Reprofiling doesn't happen in presence of level 4 OSR methods Summary: Take into account current state of profiling before believing that existing higher level versions are valid Reviewed-by: kvn, never ! src/share/vm/runtime/advancedThresholdPolicy.cpp ! src/share/vm/runtime/simpleThresholdPolicy.cpp Changeset: 2c359f27615c Author: iveresov Date: 2011-07-01 10:37 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/2c359f27615c 7057120: Tiered: Allow C1 to inline methods with loops Summary: Recompile the enclosing methods without inlining of the method that has OSRed to level 4 or recompile the enclosing method at level 4. Reviewed-by: kvn, never ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/runtime/advancedThresholdPolicy.cpp ! src/share/vm/runtime/advancedThresholdPolicy.hpp ! src/share/vm/runtime/compilationPolicy.cpp ! src/share/vm/runtime/compilationPolicy.hpp ! src/share/vm/runtime/simpleThresholdPolicy.cpp ! src/share/vm/runtime/simpleThresholdPolicy.hpp Changeset: 15559220ce79 Author: never Date: 2011-07-05 16:07 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/15559220ce79 6478991: C1 NullCheckEliminator yields incorrect exceptions Reviewed-by: twisti, iveresov ! src/share/vm/c1/c1_Optimizer.cpp + test/compiler/6478991/NullCheckTest.java Changeset: fe240d87c6ec Author: never Date: 2011-07-06 09:27 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/fe240d87c6ec 7061101: adlc should complain about mixing block and expression forms of ins_encode Reviewed-by: kvn ! src/share/vm/adlc/adlparse.cpp Changeset: 3e23978ea0c3 Author: never Date: 2011-07-06 18:15 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/3e23978ea0c3 7062856: Disassembler needs to be smarter about finding hsdis after 1.7 launcher changes Summary: do explicit lookup emulating old LD_LIBRARY_PATH search Reviewed-by: kvn, jrose ! src/share/tools/hsdis/README ! src/share/vm/compiler/disassembler.cpp Changeset: b16582d6c7db Author: kvn Date: 2011-07-07 10:51 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/b16582d6c7db Merge ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/oops/methodOop.cpp Changeset: 7d9e451f5416 Author: jcoomes Date: 2011-07-06 12:03 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/7d9e451f5416 7061187: need some includes for arm/ppc Reviewed-by: dholmes, never, jwilhelm, kvn ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/runtime/atomic.cpp Changeset: eb94b7226b7a Author: jcoomes Date: 2011-07-06 12:17 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/eb94b7226b7a 7061192: option handling adjustments for oracle and embedded builds Reviewed-by: dholmes, never, jwilhelm, kvn ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 65dba8692db7 Author: jcoomes Date: 2011-07-06 12:22 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/65dba8692db7 7061197: ThreadLocalStorage sp map table should be optional Reviewed-by: dholmes, never, jwilhelm, kvn ! src/os_cpu/linux_x86/vm/assembler_linux_x86.cpp ! src/os_cpu/linux_x86/vm/threadLS_linux_x86.cpp ! src/os_cpu/linux_x86/vm/threadLS_linux_x86.hpp Changeset: 48048b59a551 Author: jcoomes Date: 2011-07-06 12:28 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/48048b59a551 7061204: clean the chunk table synchronously in embedded builds Reviewed-by: dholmes, never, jwilhelm, kvn ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp Changeset: bf6481e5f96d Author: jcoomes Date: 2011-07-06 13:02 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/bf6481e5f96d 7061225: os::print_cpu_info() should support os-specific data Reviewed-by: dholmes, never, jwilhelm, kvn ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp Changeset: 8a4fc2990229 Author: jcoomes Date: 2011-07-07 15:44 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/8a4fc2990229 7053189: remove some unnecessary platform-dependent includes Reviewed-by: dholmes, never, jwilhelm, kvn ! src/share/vm/prims/jni.cpp ! src/share/vm/runtime/arguments.cpp Changeset: b0b8491925fe Author: jcoomes Date: 2011-07-11 14:15 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/b0b8491925fe 7061212: use o/s low memory notification in embedded builds Reviewed-by: dholmes, never, jwilhelm, kvn ! src/os/linux/vm/os_linux.cpp Changeset: 0defeba52583 Author: jcoomes Date: 2011-07-12 16:32 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/0defeba52583 Merge Changeset: faa472957b38 Author: kvn Date: 2011-07-08 09:38 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/faa472957b38 7059034: Use movxtod/movdtox on T4 Summary: Use new VIS3 mov instructions on T4 for move data between general and float registers. Reviewed-by: never, twisti ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/share/vm/runtime/globals.hpp Changeset: 263247c478c5 Author: iveresov Date: 2011-07-08 15:33 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/263247c478c5 7058510: multinewarray with 6 dimensions uncommon traps in server compiler Summary: Pass arguments to runtime via java array for arrays with > 5 dimensions Reviewed-by: never, kvn, jrose, pbk ! src/share/vm/opto/parse3.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/opto/runtime.hpp Changeset: 1f4f4ae84625 Author: kvn Date: 2011-07-13 10:48 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/1f4f4ae84625 Merge ! src/share/vm/runtime/globals.hpp Changeset: 3fbb609d9e96 Author: kvn Date: 2011-07-14 15:39 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/3fbb609d9e96 7067288: compiler regression test Test7052494 timeouts with client VM Summary: Test is modified to reduce number of iterations in test5() and test6(). Reviewed-by: never, iveresov ! test/compiler/7052494/Test7052494.java Changeset: 341a57af9b0a Author: never Date: 2011-07-15 15:35 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/341a57af9b0a 6990212: JSR 292 JVMTI MethodEnter hook is not called for JSR 292 bootstrap and target methods Summary: check for single stepping when dispatching invokes from method handles Reviewed-by: coleenp, twisti, kvn, dsamersoff ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.hpp ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.hpp + test/compiler/6990212/Test6990212.java Changeset: 968305b802ee Author: trims Date: 2011-07-23 01:56 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/968305b802ee Merge Changeset: 8e5d4aa73a8c Author: trims Date: 2011-07-22 23:47 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/8e5d4aa73a8c 7069176: Update the JDK version numbers in Hotspot for JDK 8 Summary: Change JDK_MINOR_VER and JDK_PREVIOUS_VERSION to reflect JDK8 values Reviewed-by: jcoomes ! make/hotspot_version Changeset: 0cc8a70952c3 Author: trims Date: 2011-07-22 23:42 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/0cc8a70952c3 7070061: Adjust Hotspot make/jprt.properties for new JDK8 settings Summary: Fix so the JPRT can build with -release jdk8 now Reviewed-by: ohair ! make/jprt.properties Changeset: 168df94d47af Author: mchung Date: 2011-08-12 14:10 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/168df94d47af Merge ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/vm_version_x86.hpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/share/tools/hsdis/README ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/gc_implementation/parNew/parCardTableModRefBS.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/oops/constantPoolKlass.cpp ! src/share/vm/oops/constantPoolOop.cpp ! src/share/vm/oops/constantPoolOop.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/methodOop.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/os.cpp From mandy.chung at oracle.com Fri Aug 12 23:54:48 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Fri, 12 Aug 2011 23:54:48 -0700 Subject: sync'ing up jigsaw/jigsaw? In-Reply-To: <4E45A433.1020308@oracle.com> References: <4E41729E.5050502@oracle.com> <4E4590AD.5030802@oracle.com> <4E45A433.1020308@oracle.com> Message-ID: <4E461FB8.6060500@oracle.com> Thanks, Jon. jigsaw/jigsaw is now sync'ed with jdk 8. For jprt users, please add "-bootproduct jdk7" in your jprt submit command for the time being until make/jprt.properties is updated to use jdk7 as the boot JDK. The changeset for 7069993 is already in jdk8/tl/jdk repo but it also depends on many test fixes to add cygwin support. As TL is going to be integrated into the jdk8 master next week, I'll wait for the TL integration and sync again. Mandy On 8/12/11 3:07 PM, Jonathan Gibbons wrote: > Yeah, the workaround is fine. > > -- Jon > > On 08/12/2011 01:44 PM, Mandy Chung wrote: >> I have the merge ready. Besides changing everything to 8-ea from >> 7-ea, I also have to change the langtools to build with JDK 7: >> (1) to use the jigsaw class to determine if the stubs need to be >> generated >> (2) to add "-options" to the -Xlint option (the "javac.lint.opts" >> property). >> This is needed for the boot cycle build when it bootstraps to build >> langtools with the module image. jdk-module-image no longer has >> rt.jar and thus -Xbootclasspath is not set but the boot.javac.source >> = 1.6. The langtools build failed with this: >> >> [javac] warning: [options] bootstrap class path not set in >> conjunction with -source 1.6 >> [javac] error: warnings found and -Werror specified >> >> It seems to me that the langtools build needs further cleanup for >> building with jdk-module-image. So ignoring javac options warning in >> -Xlint is just a workaround for now. >> >> Jon, >> Does this workaround look okay to you (see >> langtools/make/build.properties and build.xml)? I'll leave it to you >> to do a better fix :) >> >> Webrev: >> http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/jigsaw-jdk8-merge/ >> >> Mandy >> >> On 08/09/11 10:47, Alan Bateman wrote: >>> Mandy, >>> >>> I'm cleaning up my environment and wondering about moving >>> jigsaw/jigsaw to jdk8 (which would mean changing everything to 8-ea >>> form 7-ea in addition to sync'ing up the forest). Is this something >>> you are doing? Just checking (I don't mind doing it, seems like >>> you've done more than your fair share of sync'ing up over the last >>> year). >>> >>> -Alan >> > From mandy.chung at oracle.com Tue Aug 23 09:28:31 2011 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Tue, 23 Aug 2011 16:28:31 +0000 Subject: hg: jigsaw/jigsaw/corba: 3 new changesets Message-ID: <20110823162834.1E91347029@hg.openjdk.java.net> Changeset: 949fb60ca830 Author: ohair Date: 2011-07-22 17:34 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/corba/rev/949fb60ca830 7069993: Adjust make/jprt.properties file for jdk8 Reviewed-by: katleman ! make/jprt.properties Changeset: ed8d94519a87 Author: cl Date: 2011-08-18 18:55 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/corba/rev/ed8d94519a87 Added tag jdk8-b01 for changeset 949fb60ca830 ! .hgtags Changeset: 49d8f5c0eb80 Author: mchung Date: 2011-08-22 10:14 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/corba/rev/49d8f5c0eb80 Merge ! .hgtags From mandy.chung at oracle.com Tue Aug 23 09:28:38 2011 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Tue, 23 Aug 2011 16:28:38 +0000 Subject: hg: jigsaw/jigsaw: 6 new changesets Message-ID: <20110823162838.63BAB4702A@hg.openjdk.java.net> Changeset: 0b615980879e Author: jjg Date: 2011-06-30 16:51 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/rev/0b615980879e 7061195: Clean up makefiles for JDK 8 Reviewed-by: ohair, jjg Contributed-by: alexandre.boulgakov at oracle.com ! make/sanity-rules.gmk Changeset: 05e24d6ed56d Author: lana Date: 2011-07-14 18:56 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/rev/05e24d6ed56d Merge Changeset: fd8615098a54 Author: ohair Date: 2011-07-22 17:35 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/rev/fd8615098a54 7069993: Adjust make/jprt.properties file for jdk8 Reviewed-by: katleman ! make/jprt.properties Changeset: f42e3d9394b4 Author: ohair Date: 2011-07-22 21:31 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/rev/f42e3d9394b4 Merge Changeset: 3bec5415a227 Author: cl Date: 2011-08-18 18:55 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/rev/3bec5415a227 Added tag jdk8-b01 for changeset f42e3d9394b4 ! .hgtags Changeset: db00b7627ab1 Author: mchung Date: 2011-08-22 10:14 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/rev/db00b7627ab1 Merge ! .hgtags ! make/jprt.properties From mandy.chung at oracle.com Tue Aug 23 09:28:41 2011 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Tue, 23 Aug 2011 16:28:41 +0000 Subject: hg: jigsaw/jigsaw/jaxp: 3 new changesets Message-ID: <20110823162841.C429E4702B@hg.openjdk.java.net> Changeset: 4f0fcb812767 Author: ohair Date: 2011-07-22 17:34 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxp/rev/4f0fcb812767 7069993: Adjust make/jprt.properties file for jdk8 Reviewed-by: katleman ! make/jprt.properties Changeset: ca4d6ad55a66 Author: cl Date: 2011-08-18 18:55 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxp/rev/ca4d6ad55a66 Added tag jdk8-b01 for changeset 4f0fcb812767 ! .hgtags Changeset: 3649eea6acec Author: mchung Date: 2011-08-22 10:14 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxp/rev/3649eea6acec Merge ! .hgtags From mandy.chung at oracle.com Tue Aug 23 09:28:35 2011 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Tue, 23 Aug 2011 16:28:35 +0000 Subject: hg: jigsaw/jigsaw/hotspot: 2 new changesets Message-ID: <20110823162842.1154E4702C@hg.openjdk.java.net> Changeset: 31e253c1da42 Author: cl Date: 2011-08-18 18:55 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/31e253c1da42 Added tag jdk8-b01 for changeset 0cc8a70952c3 ! .hgtags Changeset: 86a8aa7fc843 Author: mchung Date: 2011-08-22 10:15 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/86a8aa7fc843 Merge ! .hgtags From mandy.chung at oracle.com Tue Aug 23 09:28:44 2011 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Tue, 23 Aug 2011 16:28:44 +0000 Subject: hg: jigsaw/jigsaw/jaxws: 3 new changesets Message-ID: <20110823162845.13F9B4702D@hg.openjdk.java.net> Changeset: 64df57a1edec Author: ohair Date: 2011-07-22 17:35 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxws/rev/64df57a1edec 7069993: Adjust make/jprt.properties file for jdk8 Reviewed-by: katleman ! make/jprt.properties Changeset: 1034127ed402 Author: cl Date: 2011-08-18 18:55 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxws/rev/1034127ed402 Added tag jdk8-b01 for changeset 64df57a1edec ! .hgtags Changeset: 3dcdb7136972 Author: mchung Date: 2011-08-22 10:14 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jaxws/rev/3dcdb7136972 Merge ! .hgtags From mandy.chung at oracle.com Tue Aug 23 09:28:50 2011 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Tue, 23 Aug 2011 16:28:50 +0000 Subject: hg: jigsaw/jigsaw/jdk: 73 new changesets Message-ID: <20110823164100.CD5BE4702F@hg.openjdk.java.net> Changeset: 74598b748a57 Author: lana Date: 2011-07-01 12:26 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/74598b748a57 Merge Changeset: 0a00216a858c Author: lana Date: 2011-07-07 19:18 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/0a00216a858c Merge - src/share/classes/sun/misc/JavaxSecurityAuthKerberosAccess.java - test/sun/security/ssl/com/sun/net/ssl/internal/ssl/InputRecord/InterruptedIO.java Changeset: 77d5cc943286 Author: prr Date: 2011-07-19 14:09 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/77d5cc943286 7068471: NPE in sun.font.FontConfigManager.getFontConfigFont() when libfontconfig.so is not installed Reviewed-by: jgodinez, prr Contributed-by: spoole at linux.vnet.ibm.com ! src/solaris/classes/sun/font/FontConfigManager.java Changeset: ae05aa9ede7b Author: bae Date: 2011-07-20 16:18 +0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/ae05aa9ede7b 7044285: 64 bit VM crashes in Java_sun_java2d_loops_MaskFill_MaskFill Reviewed-by: jgodinez, prr ! src/share/native/sun/java2d/loops/GraphicsPrimitiveMgr.h Changeset: 40d0dea5d0fc Author: neugens Date: 2011-07-26 21:34 +0200 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/40d0dea5d0fc 7070155: A small refactoring patch for the abstract RenderingEngine. Summary: Simplify code by using ReflectiveOperationException instead of 3 ignored catch blocks Reviewed-by: prr ! src/share/classes/sun/java2d/pipe/RenderingEngine.java Changeset: 0795f0dacfec Author: bagiras Date: 2011-07-11 15:59 +0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/0795f0dacfec 7050935: closed/java/awt/Choice/WheelEventsConsumed/WheelEventsConsumed.html fails on win32 Reviewed-by: art, dcherepanov ! src/windows/native/sun/windows/awt_Choice.cpp ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Toolkit.cpp + test/java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java Changeset: acea32663757 Author: peytoia Date: 2011-07-12 08:00 +0900 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/acea32663757 7042148: closed/java/awt/font/TextLayout/CheckLayoutLTR.java failed Reviewed-by: okutsu ! src/share/classes/sun/text/bidi/BidiBase.java + test/java/text/Bidi/Bug7042148.java Changeset: 75ee78eb7322 Author: peytoia Date: 2011-07-12 08:46 +0900 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/75ee78eb7322 7051769: java.text.Bidi.toString() output is wrong Reviewed-by: okutsu ! src/share/classes/sun/text/bidi/BidiBase.java + test/java/text/Bidi/Bug7051769.java Changeset: 6bc0e1709d97 Author: lana Date: 2011-07-11 16:54 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/6bc0e1709d97 Merge Changeset: cce5659427bb Author: rupashka Date: 2011-07-12 11:41 +0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/cce5659427bb 7019963: The goto parent directory button doesn't operate in JFileChooser Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java Changeset: 5c22624d193e Author: rupashka Date: 2011-07-15 14:43 +0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/5c22624d193e 4909150: WindowsTreeUI can cause NullPointerException occasionally Reviewed-by: alexp ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsTreeUI.java Changeset: 6ee24f03760d Author: serb Date: 2011-07-15 19:18 +0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/6ee24f03760d 7043679: Wrong class name is used in Java_sun_awt_windows_WPrinterJob_initIDs Reviewed-by: dav, art ! src/windows/native/sun/windows/awt_PrintJob.cpp Changeset: c90a43ebf8fd Author: serb Date: 2011-07-15 19:19 +0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/c90a43ebf8fd 7043815: AWT-XAWT - AWT-EventQueue-0 deadlock. Reviewed-by: art, dcherepanov ! src/solaris/classes/sun/awt/X11/XTextAreaPeer.java Changeset: 252f71b26b23 Author: serb Date: 2011-07-15 19:23 +0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/252f71b26b23 6596915: JCK-runtime-6a/tests/api/java_awt/Component/index.html tesPaintAll fails Reviewed-by: art, dcherepanov, anthony ! src/solaris/classes/sun/awt/X11/XButtonPeer.java ! src/solaris/classes/sun/awt/X11/XCheckboxPeer.java ! src/solaris/classes/sun/awt/X11/XChoicePeer.java ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/solaris/classes/sun/awt/X11/XLabelPeer.java ! src/solaris/classes/sun/awt/X11/XListPeer.java ! src/solaris/classes/sun/awt/X11/XMenuBarPeer.java ! src/solaris/classes/sun/awt/X11/XMenuWindow.java ! src/solaris/classes/sun/awt/X11/XPanelPeer.java ! src/solaris/classes/sun/awt/X11/XRepaintArea.java ! src/solaris/classes/sun/awt/X11/XScrollPanePeer.java ! src/solaris/classes/sun/awt/X11/XScrollbarPeer.java ! src/solaris/classes/sun/awt/X11/XTextAreaPeer.java ! src/solaris/classes/sun/awt/X11/XTextFieldPeer.java ! src/solaris/classes/sun/awt/X11/XWarningWindow.java ! src/solaris/classes/sun/awt/X11/XWindow.java + test/java/awt/Component/PaintAll/PaintAll.java Changeset: 3ed58dbad819 Author: serb Date: 2011-07-15 19:24 +0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/3ed58dbad819 6642728: Use reflection to access ScrollPane's private method from within sun.awt package Reviewed-by: art, anthony ! src/share/classes/java/awt/ScrollPaneAdjustable.java ! src/share/classes/sun/awt/AWTAccessor.java ! src/solaris/classes/sun/awt/X11/XScrollPanePeer.java ! src/windows/classes/sun/awt/windows/WScrollPanePeer.java ! src/windows/native/sun/windows/awt_ScrollPane.cpp Changeset: 9c642ae9a543 Author: serb Date: 2011-07-15 19:25 +0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/9c642ae9a543 4717864: setFont() does not update Fonts of Menus already on screen Reviewed-by: art, bagiras ! src/windows/classes/sun/awt/windows/WMenuItemPeer.java ! src/windows/native/sun/windows/awt_Menu.cpp ! src/windows/native/sun/windows/awt_Menu.h ! src/windows/native/sun/windows/awt_MenuBar.cpp ! src/windows/native/sun/windows/awt_MenuBar.h ! src/windows/native/sun/windows/awt_MenuItem.cpp ! src/windows/native/sun/windows/awt_MenuItem.h Changeset: 3ac81907aa7d Author: rupashka Date: 2011-07-18 17:40 +0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/3ac81907aa7d 6509273: Password in JPasswordField gets Printed in clear text Reviewed-by: alexp ! src/share/classes/sun/swing/text/TextComponentPrintable.java Changeset: c05b36e4749e Author: rupashka Date: 2011-07-18 18:21 +0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/c05b36e4749e 7031941: Use generificated JComboBox and JList in core libraries Reviewed-by: alexp ! src/share/classes/com/sun/java/swing/plaf/motif/MotifFileChooserUI.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsFileChooserUI.java ! src/share/classes/javax/swing/plaf/basic/BasicComboPopup.java ! src/share/classes/javax/swing/plaf/synth/SynthComboBoxUI.java ! src/share/classes/javax/swing/text/html/FormView.java ! src/share/classes/javax/swing/text/html/HTMLDocument.java ! src/share/classes/javax/swing/text/html/HTMLWriter.java ! src/share/classes/javax/swing/text/html/OptionComboBoxModel.java ! src/share/classes/javax/swing/text/html/OptionListModel.java ! src/share/classes/sun/swing/FilePane.java ! src/share/classes/sun/swing/plaf/synth/SynthFileChooserUIImpl.java Changeset: 190b11164876 Author: lana Date: 2011-07-27 22:42 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/190b11164876 Merge Changeset: 996547848b00 Author: lana Date: 2011-08-01 17:40 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/996547848b00 Merge Changeset: 34fdcdb70d20 Author: rupashka Date: 2011-07-28 18:13 +0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/34fdcdb70d20 6995769: occasion NPE thrown from SwingUtilities.computeIntersection() Reviewed-by: alexp ! src/share/classes/javax/swing/RepaintManager.java Changeset: 86098b3f7789 Author: rupashka Date: 2011-07-28 18:24 +0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/86098b3f7789 7071166: LayoutStyle.getPreferredGap() - IAE is expected but not thrown Reviewed-by: peterz ! src/share/classes/sun/swing/DefaultLayoutStyle.java + test/javax/swing/GroupLayout/7071166/bug7071166.java Changeset: 0ce1f0b21446 Author: serb Date: 2011-08-01 17:05 +0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/0ce1f0b21446 7068060: closed/java/awt/MenuBar/MenuBarSetFont/MenuBarSetFont.java failed on windows Reviewed-by: art, dcherepanov + test/java/awt/MenuBar/MenuBarSetFont/MenuBarSetFont.java Changeset: 854e74d8d956 Author: rupashka Date: 2011-08-03 16:59 +0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/854e74d8d956 7072328: Sun URL in the MetalLookAndFeel.getLayoutStyle() specification should be replaced with Oracle one Reviewed-by: peterz ! src/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java Changeset: 634c2a492cf5 Author: lana Date: 2011-08-05 15:35 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/634c2a492cf5 Merge - src/share/classes/java/lang/invoke/FilterGeneric.java - src/share/classes/java/lang/invoke/FilterOneArgument.java - src/share/classes/java/lang/invoke/FromGeneric.java - src/share/classes/java/lang/invoke/SpreadGeneric.java - src/share/classes/java/lang/invoke/ToGeneric.java Changeset: e4c936c28960 Author: jjg Date: 2011-06-30 16:48 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/e4c936c28960 7061190: Update boot JDK version for JDK 8 Reviewed-by: ohair, jjg Contributed-by: alexandre.boulgakov at oracle.com ! make/common/shared/Defs-versions.gmk Changeset: cf4edfcd7119 Author: jjg Date: 2011-06-30 16:50 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/cf4edfcd7119 7061195: Clean up makefiles for JDK 8 Reviewed-by: ohair, jjg Contributed-by: alexandre.boulgakov at oracle.com ! make/common/shared/Defs-java.gmk Changeset: 74328e59a4bf Author: jjg Date: 2011-06-30 17:59 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/74328e59a4bf 7058708: Eliminate JDK build tools build warnings Reviewed-by: ohair, jjg Contributed-by: alexandre.boulgakov at oracle.com ! make/tools/Makefile ! make/tools/src/build/tools/buildmetaindex/BuildMetaIndex.java ! make/tools/src/build/tools/compileproperties/CompileProperties.java ! make/tools/src/build/tools/dirdiff/DirDiff.java ! make/tools/src/build/tools/dtdbuilder/DTDBuilder.java ! make/tools/src/build/tools/dtdbuilder/DTDInputStream.java ! make/tools/src/build/tools/dtdbuilder/DTDParser.java ! make/tools/src/build/tools/dtdbuilder/PublicMapping.java ! make/tools/src/build/tools/generatebreakiteratordata/CharSet.java ! make/tools/src/build/tools/generatebreakiteratordata/DictionaryBasedBreakIteratorBuilder.java ! make/tools/src/build/tools/generatebreakiteratordata/GenerateBreakIteratorData.java ! make/tools/src/build/tools/generatebreakiteratordata/RuleBasedBreakIteratorBuilder.java ! make/tools/src/build/tools/generatebreakiteratordata/SupplementaryCharacterData.java ! make/tools/src/build/tools/generatecharacter/GenerateCharacter.java ! make/tools/src/build/tools/generatecharacter/SpecialCaseMap.java ! make/tools/src/build/tools/generatecharacter/UnicodeSpec.java ! make/tools/src/build/tools/generatecurrencydata/GenerateCurrencyData.java ! make/tools/src/build/tools/hasher/Hasher.java ! make/tools/src/build/tools/jarsplit/JarSplit.java ! make/tools/src/build/tools/javazic/Gen.java ! make/tools/src/build/tools/javazic/GenDoc.java ! make/tools/src/build/tools/javazic/Main.java ! make/tools/src/build/tools/javazic/Mappings.java ! make/tools/src/build/tools/javazic/Simple.java ! make/tools/src/build/tools/javazic/Time.java ! make/tools/src/build/tools/javazic/Zoneinfo.java ! make/tools/src/build/tools/jdwpgen/AbstractCommandNode.java ! make/tools/src/build/tools/jdwpgen/AbstractGroupNode.java ! make/tools/src/build/tools/jdwpgen/AbstractNamedNode.java ! make/tools/src/build/tools/jdwpgen/AbstractTypeListNode.java ! make/tools/src/build/tools/jdwpgen/AltNode.java ! make/tools/src/build/tools/jdwpgen/CommandSetNode.java ! make/tools/src/build/tools/jdwpgen/ConstantSetNode.java ! make/tools/src/build/tools/jdwpgen/ErrorSetNode.java ! make/tools/src/build/tools/jdwpgen/Node.java ! make/tools/src/build/tools/jdwpgen/OutNode.java ! make/tools/src/build/tools/jdwpgen/RootNode.java ! make/tools/src/build/tools/jdwpgen/SelectNode.java ! make/tools/src/build/tools/makeclasslist/MakeClasslist.java ! make/tools/src/build/tools/stripproperties/StripProperties.java Changeset: e93679cf1e1a Author: valeriep Date: 2011-06-30 18:42 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/e93679cf1e1a 7058133: Javah should use the freshly built classes instead of those from the BOOTDIR jdk Summary: Changed javah to use the newly built classes specified by $(CLASSDESTDIR) Reviewed-by: vinnie ! make/sun/security/ec/Makefile ! make/sun/security/mscapi/Makefile Changeset: f0ec49c21d09 Author: valeriep Date: 2011-07-01 17:12 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/f0ec49c21d09 Merge Changeset: e88093d75e36 Author: coffeys Date: 2011-07-05 15:25 +0100 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/e88093d75e36 7041125: LDAP API does not catch malformed filters that contain two operands for the ! operator Reviewed-by: weijun, xuelei ! src/share/classes/com/sun/jndi/ldap/Filter.java ! test/com/sun/jndi/ldap/InvalidLdapFilters.java Changeset: f68d30c0a2e3 Author: mullan Date: 2011-07-06 11:08 -0400 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/f68d30c0a2e3 7054969: Null-check-in-finally pattern in java/security documentation Reviewed-by: vinnie ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/security/cert/X509CRL.java ! src/share/classes/java/security/cert/X509Certificate.java ! src/share/classes/java/security/cert/X509Extension.java Changeset: 63be90976177 Author: ksrini Date: 2011-07-08 10:25 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/63be90976177 7060849: Eliminate pack200 build warnings Reviewed-by: ksrini, jjg Contributed-by: alexandre.boulgakov at oracle.com ! make/com/sun/java/pack/Makefile ! make/common/shared/Defs-java.gmk ! src/share/classes/com/sun/java/util/jar/pack/Attribute.java ! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java ! src/share/classes/com/sun/java/util/jar/pack/ClassReader.java ! src/share/classes/com/sun/java/util/jar/pack/ClassWriter.java ! src/share/classes/com/sun/java/util/jar/pack/Code.java ! src/share/classes/com/sun/java/util/jar/pack/Coding.java ! src/share/classes/com/sun/java/util/jar/pack/ConstantPool.java ! src/share/classes/com/sun/java/util/jar/pack/Constants.java ! src/share/classes/com/sun/java/util/jar/pack/Fixups.java ! src/share/classes/com/sun/java/util/jar/pack/Instruction.java ! src/share/classes/com/sun/java/util/jar/pack/NativeUnpack.java ! src/share/classes/com/sun/java/util/jar/pack/Package.java ! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java ! src/share/classes/com/sun/java/util/jar/pack/PackerImpl.java ! src/share/classes/com/sun/java/util/jar/pack/PropMap.java ! src/share/classes/com/sun/java/util/jar/pack/TLGlobals.java ! src/share/classes/com/sun/java/util/jar/pack/UnpackerImpl.java ! src/share/classes/com/sun/java/util/jar/pack/Utils.java Changeset: 5adf431673ac Author: peytoia Date: 2011-07-12 07:32 +0900 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/5adf431673ac 7012364: test/java/util/Locale/LocaleCategory.sh fails on Cygwin Reviewed-by: okutsu ! test/java/util/Locale/LocaleCategory.sh Changeset: 549b7c3f0bdc Author: dl Date: 2011-07-12 15:23 +0100 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/549b7c3f0bdc 7058828: test/java/util/concurrent/Phaser/Arrive.java fails intermittently Reviewed-by: chegar ! test/java/util/concurrent/Phaser/Arrive.java Changeset: 42fe05e54e69 Author: naoto Date: 2011-07-12 10:28 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/42fe05e54e69 7022407: Spinning CPU in LocaleObjectCache.get() Reviewed-by: okutsu ! src/share/classes/sun/util/locale/LocaleObjectCache.java Changeset: db419c454f92 Author: dl Date: 2011-07-13 12:24 +0100 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/db419c454f92 7057320: test/java/util/concurrent/Executors/AutoShutdown.java failing intermittently Summary: Add retry/timeout for checking activeCount Reviewed-by: chegar ! test/java/util/concurrent/Executors/AutoShutdown.java Changeset: 7ac6a297f9a0 Author: lana Date: 2011-07-14 18:57 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/7ac6a297f9a0 Merge Changeset: c0c983ca797b Author: ksrini Date: 2011-07-15 16:38 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/c0c983ca797b 7062969: java -help still shows http://java.sun.com/javase/reference Reviewed-by: ohair, darcy ! src/share/classes/sun/launcher/resources/launcher.properties Changeset: d987f8738096 Author: darcy Date: 2011-07-17 18:53 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/d987f8738096 7062430: Minor inconsistency in ulp descriptions Reviewed-by: smarks, alanb ! src/share/classes/java/lang/Math.java ! src/share/classes/java/lang/StrictMath.java Changeset: cbfc7f910af3 Author: alanb Date: 2011-07-18 13:10 +0100 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/cbfc7f910af3 7068059: Update jdk/test/ProblemList.txt Reviewed-by: mchung, chegar ! test/ProblemList.txt Changeset: 8bbea505b060 Author: chegar Date: 2011-07-18 22:25 +0100 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/8bbea505b060 7021280: SocketPermission should accept wildcards Reviewed-by: michaelm ! src/share/classes/java/net/SocketPermission.java + test/java/net/SocketPermission/Wildcard.java Changeset: 5355b9ccd19d Author: xuelei Date: 2011-07-19 08:21 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/5355b9ccd19d 7059709: close the IO in a final block Reviewed-by: smarks, mullan, wetmore ! src/share/classes/sun/security/ssl/SSLContextImpl.java ! src/share/classes/sun/security/ssl/TrustManagerFactoryImpl.java Changeset: d17eb3380a49 Author: ksrini Date: 2011-07-19 10:58 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/d17eb3380a49 7067922: (launcher) java -jar throws NPE if JAR file does not contain Main-Class attribute Reviewed-by: darcy, ohair, alanb, mduigou ! src/share/classes/sun/launcher/LauncherHelper.java ! test/tools/launcher/Arrrghs.java ! test/tools/launcher/TestHelper.java Changeset: d083644bc615 Author: darcy Date: 2011-07-19 17:45 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/d083644bc615 7007535: (reflect) Please generalize Constructor and Method Reviewed-by: mduigou, peterjones, dholmes, andrew ! src/share/classes/java/lang/reflect/Constructor.java + src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Method.java Changeset: 99dc852080e1 Author: xuelei Date: 2011-07-19 21:47 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/99dc852080e1 7065972: Some race condition may happen in SSLSocketImpl class Reviewed-by: wetmore, weijun, dgu ! src/share/classes/sun/security/ssl/SSLSocketImpl.java Changeset: 9505edecc8b5 Author: jjg Date: 2011-07-20 12:19 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/9505edecc8b5 7068617: Core libraries don't build with javac -Xlint:all -Werror Reviewed-by: darcy Contributed-by: alexandre.boulgakov at oracle.com ! make/java/java/Makefile ! src/share/classes/sun/reflect/generics/reflectiveObjects/NotImplementedException.java ! src/share/classes/sun/reflect/misc/ConstructorUtil.java ! src/share/classes/sun/reflect/misc/FieldUtil.java ! src/share/classes/sun/reflect/misc/MethodUtil.java ! src/share/classes/sun/reflect/misc/ReflectUtil.java Changeset: 70ec3aa8e99a Author: chegar Date: 2011-07-21 17:28 +0100 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/70ec3aa8e99a 7068416: Lightweight HTTP Server should support TCP_NODELAY Reviewed-by: alanb, michaelm ! src/share/classes/sun/net/httpserver/ServerConfig.java ! src/share/classes/sun/net/httpserver/ServerImpl.java ! test/com/sun/net/httpserver/Test1.java Changeset: c8dbb9e19355 Author: weijun Date: 2011-07-22 10:25 +0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/c8dbb9e19355 6330275: Rework the PaddingTest regression test. Reviewed-by: wetmore, smarks ! test/ProblemList.txt ! test/com/sun/crypto/provider/Cipher/DES/PaddingTest.java Changeset: 0ec4b6498a69 Author: ohair Date: 2011-07-22 17:35 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/0ec4b6498a69 7069993: Adjust make/jprt.properties file for jdk8 Reviewed-by: katleman ! make/jprt.properties Changeset: a499fdfbe723 Author: ohair Date: 2011-07-22 21:31 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/a499fdfbe723 Merge Changeset: 07a12583d4ea Author: chegar Date: 2011-07-25 14:35 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/07a12583d4ea 7035556: DatagramSocket.java:183: warning: unreachable catch clause Summary: Remove redundant catches in bind Reviewed-by: alanb, michaelm, wetmore, chegar Contributed-by: kurchi.subhra.hazra at oracle.com ! src/share/classes/java/net/DatagramSocket.java Changeset: c563e8060adf Author: jjg Date: 2011-07-25 16:20 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/c563e8060adf 7069870: Parts of the JDK erroneously rely on generic array initializers with diamond Reviewed-by: ksrini, mcimadamore Contributed-by: alexandre.boulgakov at oracle.com ! make/tools/src/build/tools/jarsplit/JarSplit.java ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java Changeset: a80562f7ea50 Author: chegar Date: 2011-07-27 18:10 +0100 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/a80562f7ea50 6670868: StackOverFlow with bad authenticated Proxy tunnels Reviewed-by: michaelm ! src/share/classes/sun/net/www/http/HttpClient.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/HttpsProxyStackOverflow.java Changeset: 7525866a4046 Author: jjg Date: 2011-07-28 13:34 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/7525866a4046 7068616: NIO libraries do not build with javac -Xlint:all,-deprecation -Werror Reviewed-by: alanb, chegar Contributed-by: alexandre.boulgakov at oracle.com ! make/com/sun/nio/Makefile ! make/com/sun/nio/sctp/Makefile ! make/java/nio/Makefile ! make/java/sun_nio/Makefile ! make/sun/nio/Makefile ! make/sun/nio/cs/Makefile ! src/share/classes/java/nio/X-Buffer.java.template ! src/share/classes/java/nio/channels/AsynchronousFileChannel.java ! src/share/classes/java/nio/channels/FileChannel.java ! src/share/classes/java/nio/charset/Charset.java ! src/share/classes/sun/nio/ch/DatagramSocketAdaptor.java ! src/share/classes/sun/nio/ch/Reflect.java ! src/share/classes/sun/nio/ch/SelectorImpl.java ! src/share/classes/sun/nio/ch/Util.java ! src/share/classes/sun/nio/cs/FastCharsetProvider.java ! src/share/classes/sun/nio/cs/StreamDecoder.java ! src/share/classes/sun/nio/cs/ThreadLocalCoders.java ! src/share/classes/sun/nio/fs/Util.java ! src/solaris/classes/sun/nio/ch/SctpChannelImpl.java ! src/solaris/classes/sun/nio/ch/SctpMultiChannelImpl.java ! src/solaris/classes/sun/nio/ch/SctpNet.java ! src/solaris/classes/sun/nio/ch/SctpServerChannelImpl.java ! src/windows/classes/sun/nio/ch/PendingIoCache.java ! src/windows/classes/sun/nio/ch/WindowsAsynchronousFileChannelImpl.java ! src/windows/classes/sun/nio/ch/WindowsAsynchronousSocketChannelImpl.java Changeset: cea7c749f805 Author: xuelei Date: 2011-07-29 02:50 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/cea7c749f805 7068662: Reserve and restore the default locale Reviewed-by: alanb, weijun ! test/com/sun/org/apache/xml/internal/security/exceptions/LocaleTest.java ! test/java/beans/XMLDecoder/Test6341798.java ! test/java/io/pathNames/win32/bug6344646.java ! test/java/net/CookieHandler/B6791927.java ! test/java/net/URLConnection/SetIfModifiedSince.java ! test/java/util/Locale/LocaleCategory.java ! test/java/util/PluggableLocale/CurrencyNameProviderTest.java ! test/java/util/PluggableLocale/TimeZoneNameProviderTest.java ! test/java/util/ResourceBundle/Bug6190861.java ! test/java/util/ResourceBundle/Control/Bug6530694.java ! test/java/util/ResourceBundle/Control/StressTest.java ! test/java/util/ResourceBundle/Test4314141.java ! test/java/util/ResourceBundle/Test4318520.java ! test/java/util/jar/JarFile/TurkCert.java ! test/javax/crypto/Cipher/Turkish.java ! test/javax/swing/JColorChooser/Test6524757.java ! test/sun/security/tools/keytool/KeyToolTest.java ! test/sun/text/resources/Collator/Bug4248694.java ! test/sun/text/resources/Collator/Bug4804273.java ! test/sun/text/resources/Collator/Bug4848897.java ! test/sun/text/resources/Format/Bug4651568.java ! test/sun/util/resources/Locale/Bug4965260.java ! test/sun/util/resources/TimeZone/Bug4640234.java Changeset: 4030297803eb Author: jjg Date: 2011-07-29 16:45 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/4030297803eb 7072523: java.math should be built with javac -Xlint:all -Werror Reviewed-by: darcy Contributed-by: alexandre.boulgakov at oracle.com ! make/java/math/Makefile Changeset: 809e8db0c142 Author: chegar Date: 2011-07-29 10:55 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/809e8db0c142 6978200: ServerSocket.toString include "port=0" in the returned String Summary: Removal of "port=0" from ServerSocket.toString method Reviewed-by: alanb, chegar Contributed-by: kurchi.subhra.hazra at oracle.com ! src/share/classes/java/net/ServerSocket.java Changeset: e68db408d08c Author: weijun Date: 2011-08-04 18:18 +0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/e68db408d08c 7061379: [Kerberos] Cross-realm authentication fails, due to nameType problem Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/PrincipalName.java ! test/sun/security/krb5/auto/KDC.java + test/sun/security/krb5/auto/PrincipalNameEquals.java Changeset: 565555e89034 Author: mduigou Date: 2011-08-04 08:53 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/565555e89034 7073296: Executable.equalParamTypes() incorrectly returns true when the number of params differs. Reviewed-by: alanb, darcy ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/reflect/Executable.java + test/java/lang/reflect/Constructor/Equals.java Changeset: b9fffbe98230 Author: darcy Date: 2011-08-06 14:35 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/b9fffbe98230 7075098: Remove unused fdlibm files Reviewed-by: alanb, mduigou ! make/java/fdlibm/FILES_c.gmk ! src/share/native/java/lang/fdlibm/include/fdlibm.h ! src/share/native/java/lang/fdlibm/include/jfdlibm.h - src/share/native/java/lang/fdlibm/src/e_acosh.c - src/share/native/java/lang/fdlibm/src/e_gamma.c - src/share/native/java/lang/fdlibm/src/e_gamma_r.c - src/share/native/java/lang/fdlibm/src/e_j0.c - src/share/native/java/lang/fdlibm/src/e_j1.c - src/share/native/java/lang/fdlibm/src/e_jn.c - src/share/native/java/lang/fdlibm/src/e_lgamma.c - src/share/native/java/lang/fdlibm/src/e_lgamma_r.c - src/share/native/java/lang/fdlibm/src/s_asinh.c - src/share/native/java/lang/fdlibm/src/s_erf.c - src/share/native/java/lang/fdlibm/src/w_acosh.c - src/share/native/java/lang/fdlibm/src/w_gamma.c - src/share/native/java/lang/fdlibm/src/w_gamma_r.c - src/share/native/java/lang/fdlibm/src/w_j0.c - src/share/native/java/lang/fdlibm/src/w_j1.c - src/share/native/java/lang/fdlibm/src/w_jn.c - src/share/native/java/lang/fdlibm/src/w_lgamma.c - src/share/native/java/lang/fdlibm/src/w_lgamma_r.c Changeset: 3f3a59423a7e Author: lana Date: 2011-08-05 16:03 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/3f3a59423a7e Merge - src/share/classes/java/lang/invoke/FilterGeneric.java - src/share/classes/java/lang/invoke/FilterOneArgument.java - src/share/classes/java/lang/invoke/FromGeneric.java - src/share/classes/java/lang/invoke/SpreadGeneric.java - src/share/classes/java/lang/invoke/ToGeneric.java Changeset: a5f825ef8587 Author: lana Date: 2011-08-07 17:03 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/a5f825ef8587 Merge - src/share/native/java/lang/fdlibm/src/e_acosh.c - src/share/native/java/lang/fdlibm/src/e_gamma.c - src/share/native/java/lang/fdlibm/src/e_gamma_r.c - src/share/native/java/lang/fdlibm/src/e_j0.c - src/share/native/java/lang/fdlibm/src/e_j1.c - src/share/native/java/lang/fdlibm/src/e_jn.c - src/share/native/java/lang/fdlibm/src/e_lgamma.c - src/share/native/java/lang/fdlibm/src/e_lgamma_r.c - src/share/native/java/lang/fdlibm/src/s_asinh.c - src/share/native/java/lang/fdlibm/src/s_erf.c - src/share/native/java/lang/fdlibm/src/w_acosh.c - src/share/native/java/lang/fdlibm/src/w_gamma.c - src/share/native/java/lang/fdlibm/src/w_gamma_r.c - src/share/native/java/lang/fdlibm/src/w_j0.c - src/share/native/java/lang/fdlibm/src/w_j1.c - src/share/native/java/lang/fdlibm/src/w_jn.c - src/share/native/java/lang/fdlibm/src/w_lgamma.c - src/share/native/java/lang/fdlibm/src/w_lgamma_r.c Changeset: 94934ebbb654 Author: alanb Date: 2011-08-08 13:20 +0100 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/94934ebbb654 7076215: (jli) jdk/src/share/bin/jli_util.h should include function prototypes for str functions Reviewed-by: alanb Contributed-by: neil.richards at ngmr.net ! src/share/bin/jli_util.h Changeset: d4ab25d65adb Author: darcy Date: 2011-08-08 09:07 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/d4ab25d65adb 6380161: (reflect) Exception from newInstance() not chained to cause. Reviewed-by: dholmes, lancea, forax ! src/share/classes/java/lang/Class.java Changeset: 0f1b4b3bc833 Author: mchung Date: 2011-08-08 16:26 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/0f1b4b3bc833 7036518: TEST_BUG: add cygwin support to test/java/nio/charset/coders/CheckSJISMappingProp.sh 7036519: TEST_BUG: add cygwin support to test/demo/zipfs/basic.sh Reviewed-by: sherman ! test/demo/zipfs/basic.sh ! test/java/nio/charset/coders/CheckSJISMappingProp.sh Changeset: 39498fc31d63 Author: mchung Date: 2011-08-08 16:27 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/39498fc31d63 7012365: TEST_BUG: test/java/nio/charset/spi/basic.sh can be run with Cygwin Reviewed-by: darcy ! test/java/nio/charset/spi/basic.sh Changeset: 26fe74aa48ef Author: chegar Date: 2011-08-09 16:39 +0100 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/26fe74aa48ef 7073295: TEST_BUG: test/java/lang/instrument/ManifestTest.sh causing havoc (win) Reviewed-by: mchung ! test/java/lang/instrument/ManifestTest.sh Changeset: cf203f293b4e Author: chegar Date: 2011-08-09 16:59 +0100 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/cf203f293b4e 7076756: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails to cleanup in Cygwin Reviewed-by: alanb, dcubed ! test/com/sun/jdi/ShellScaffold.sh Changeset: 2cdbbc4a6359 Author: lana Date: 2011-08-09 17:38 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/2cdbbc4a6359 Merge - src/share/native/java/lang/fdlibm/src/e_acosh.c - src/share/native/java/lang/fdlibm/src/e_gamma.c - src/share/native/java/lang/fdlibm/src/e_gamma_r.c - src/share/native/java/lang/fdlibm/src/e_j0.c - src/share/native/java/lang/fdlibm/src/e_j1.c - src/share/native/java/lang/fdlibm/src/e_jn.c - src/share/native/java/lang/fdlibm/src/e_lgamma.c - src/share/native/java/lang/fdlibm/src/e_lgamma_r.c - src/share/native/java/lang/fdlibm/src/s_asinh.c - src/share/native/java/lang/fdlibm/src/s_erf.c - src/share/native/java/lang/fdlibm/src/w_acosh.c - src/share/native/java/lang/fdlibm/src/w_gamma.c - src/share/native/java/lang/fdlibm/src/w_gamma_r.c - src/share/native/java/lang/fdlibm/src/w_j0.c - src/share/native/java/lang/fdlibm/src/w_j1.c - src/share/native/java/lang/fdlibm/src/w_jn.c - src/share/native/java/lang/fdlibm/src/w_lgamma.c - src/share/native/java/lang/fdlibm/src/w_lgamma_r.c Changeset: 13e70aa1398e Author: cl Date: 2011-08-18 18:55 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/13e70aa1398e Added tag jdk8-b01 for changeset 2cdbbc4a6359 ! .hgtags Changeset: 72723f1de043 Author: mchung Date: 2011-08-22 10:15 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/72723f1de043 Merge ! .hgtags ! make/com/sun/java/pack/Makefile ! make/com/sun/nio/sctp/Makefile ! make/common/shared/Defs-java.gmk ! make/java/java/Makefile ! make/java/nio/Makefile ! make/jprt.properties ! make/sun/nio/cs/Makefile ! make/sun/security/ec/Makefile ! make/sun/security/mscapi/Makefile ! src/share/classes/java/lang/Class.java ! src/share/classes/sun/launcher/LauncherHelper.java ! src/share/classes/sun/launcher/resources/launcher.properties ! src/share/classes/sun/reflect/misc/MethodUtil.java - src/share/native/java/lang/fdlibm/src/e_acosh.c - src/share/native/java/lang/fdlibm/src/e_gamma.c - src/share/native/java/lang/fdlibm/src/e_gamma_r.c - src/share/native/java/lang/fdlibm/src/e_j0.c - src/share/native/java/lang/fdlibm/src/e_j1.c - src/share/native/java/lang/fdlibm/src/e_jn.c - src/share/native/java/lang/fdlibm/src/e_lgamma.c - src/share/native/java/lang/fdlibm/src/e_lgamma_r.c - src/share/native/java/lang/fdlibm/src/s_asinh.c - src/share/native/java/lang/fdlibm/src/s_erf.c - src/share/native/java/lang/fdlibm/src/w_acosh.c - src/share/native/java/lang/fdlibm/src/w_gamma.c - src/share/native/java/lang/fdlibm/src/w_gamma_r.c - src/share/native/java/lang/fdlibm/src/w_j0.c - src/share/native/java/lang/fdlibm/src/w_j1.c - src/share/native/java/lang/fdlibm/src/w_jn.c - src/share/native/java/lang/fdlibm/src/w_lgamma.c - src/share/native/java/lang/fdlibm/src/w_lgamma_r.c Changeset: ed4c673a9e2f Author: mchung Date: 2011-08-22 10:27 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/ed4c673a9e2f Fix timestamp-test.sh test to use proper shell syntax ! test/org/openjdk/jigsaw/cli/timestamp-test.sh From mandy.chung at oracle.com Tue Aug 23 09:46:59 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Tue, 23 Aug 2011 09:46:59 -0700 Subject: jigsaw sync'ed with jdk8 b01 In-Reply-To: <4E461FB8.6060500@oracle.com> References: <4E41729E.5050502@oracle.com> <4E4590AD.5030802@oracle.com> <4E45A433.1020308@oracle.com> <4E461FB8.6060500@oracle.com> Message-ID: <4E53D983.4050403@oracle.com> Jigsaw is now sync'ed with jdk8 b01. On 08/12/11 23:54, Mandy Chung wrote: > > For jprt users, please add "-bootproduct jdk7" in your jprt submit > command for the time being until make/jprt.properties is updated to > use jdk7 as the boot JDK. The changeset for 7069993 is already in > jdk8/tl/jdk repo but it also depends on many test fixes to add cygwin > support. As TL is going to be integrated into the jdk8 master next > week, I'll wait for the TL integration and sync again. The changeset for 7069993 is in jigsaw repo and so no longer need to specify -bootproduct option in your jprt job. Mandy From david.bosschaert at gmail.com Thu Aug 25 06:00:57 2011 From: david.bosschaert at gmail.com (David Bosschaert) Date: Thu, 25 Aug 2011 14:00:57 +0100 Subject: module-info.class spec and attributes In-Reply-To: References: <4E00E72A.8020104@oracle.com> <4E052910.5080001@oracle.com> <4E05335F.6090609@oracle.com> <4E053859.3060703@oracle.com> <4E0BBE2B.9090907@oracle.com> <4E0BC231.7000200@redhat.com> <4E0BC764.3030300@oracle.com> <4E0BCA9E.8020003@redhat.com> <4E0BE4CF.6000502@oracle.com> <4E0C2145.4070004@univ-mlv.fr> Message-ID: Reviving an old thread... it seems like this discussion is left without coming to an agreed conclusion. On the one hand we have Alex and Remi arguing for a binary runtime format for the module-metadata. On the other we have a number of people (Peter, David L and me) arguing for a textual format for the module metadata. Let me try to summarize the points made so far. Points in favour of a binary, compiled format: * More efficient to read at runtime (have we got numbers to prove this?) * Because the source is in a .java file the runtime must be in a .class file * Helps to ensure validity * Can more easily be handled by javac Not compiled (e.g. a DSL, XML or a text file similar to that) * Can easily be processed by external tools * Can easily be read and understood by humans * Can easily be processed by other module systems (e.g. OSGi, JBoss Modules) * The .class file structure is not the best format for storing module metadata I hope I captured both sides accurately - please chime in if I didn't :) It would be great if we could come to some common agreement here... Anyone else any thoughts? Best regards, David On 4 July 2011 09:50, Peter Kriens wrote: > I think you conflate the fact that a file is based on a textual format with the fact that it is edited. Files like the manifest and XML files are not human editable although many developers are too lazy to provide a proper front end and offer those files as human editable. They are intended for machine-machine communication with the added benefit that they are easy to verify when things go awry. Our industry learned that lesson the hard way over the past few decades. > > The biggest problem with the current design is that it is very hard to make things extensible. Not only for OSGi, but also for Jigsaw in the future as the current design usurps the extension mechanism of class files itself and you cannot extend extensions in class files. If a module was defined as an entity with members, like an interface or class, we could have reused annotations: > > ? ? ? ?@VersionRange(1.8,2.0) > ? ? ? ?@Resolution(Optional) > ? ? ? ?import package com.acme.foo.*; > > ? ? ? ?@Version(1.8.8) > ? ? ? ?module BAR implements JDK17 { > > ? ? ? ? ? ? ? ?@Version(1.7) > ? ? ? ? ? ? ? ?package com.sun.misc; > > ? ? ? ? ? ? ? ?@Version(1.7) > ? ? ? ? ? ? ? ?@Attribute(name="api",value"true") > ? ? ? ? ? ? ? ?@Mandatory("api") > ? ? ? ? ? ? ? ?package com.sun.impl.java.lang; > > ? ? ? ? ? ? ? ?void main(String args[] ) { > ? ? ? ? ? ? ? ? ? ? ? ?... > ? ? ? ? ? ? ? ?} > ? ? ? ?} > > As it is now, the class file is just a set of attributes. XML was invented for exactly this purpose, not as a human editable file, but as a file that allows different parties to integrate their information in a single file without having to worry about character sets and collisions. If Jigsaw defines a proper schema, the OSGi and others can add a namespace on each element to carry their metadata. > > Further inline: > > On 30 jun 2011, at 09:09, R?mi Forax wrote: >> David, >> I think storing the module metadata as a class file is a brilliant idea. > :-) > >> First you have to think that what we want is not one text file but two. >> Some module metadata are generated (the one marked synthetic in the current format) >> by the compiler and as a user I don't want to see them, edit them, etc. > Fully agree, the "binary" version is like the manifest in OSGi, not intended for human consumption with its limited line length. However, when things go awry it is very nice to be able to see them without requiring specialized tools. > >> Eclipse plugins use the approach of having one file for the two purposes, be a module >> descriptor editable by a human and be a module deployment descriptor readable >> by the module runtime. As a user, the experience is painful, the file is big and a big part of the data are useless >> and sometimes you have to reconcile the state of the source and the plugin descriptor >> by hand. > That is why this method is disputed. Manifest is a binary format and you should not be edited by hand. That is why for example bndtools and maven generate the manifest. > >> To summarize, we need a file which is readable/writable by a human, readable by the compiler >> and the compiler need to generate a module deployment from it that need to be readable >> by the module runtime system. Hence, it's logical to have a Java file and a class file. > Though I agree with the Java source file I fail to see why the output needs to be a Java class file as the module as currently designed does not even remotely look like a class. If it did, (a Module also has members) the story would be different. > >> Also a classfile is versioned, compact, has no character encoding problem, >> is well integrated with the other files and as Alex said is more efficient than an XML file. > As the manifest will be compressed by the JAR file the efficiency gain is minimal as the binary class file compresses worse, if relevant at the first place. And if this is an issue, there are even better formats. > >> Another cool point is that because the module descriptor is a Java file you know >> where to put the module doc :) > Which makes the module namespace overlap with the package namespace ... which I think will cause some nasty unnecessary constraints as a modules should encapsulate a package namespace and not be part of it. > > Kind regards, > > ? ? ? ?Peter Kriens > > >> >> R?mi >> >> On 06/30/2011 04:51 AM, Alex Buckley wrote: >>> I think we're slightly missing each other here. I wasn't implying javac is unable to cache module declarations; rather that module declarations are now woven deeply into compilation because determining the visibility of _any_ type (whether available in source or class file form) is dependent on a graph of module declarations (possibly cached by the module system, but not when the world is being built from source). Jigsaw is just keeping the structure of those module declarations in source/binary forms that compilers are familiar with. >>> >>> Alex >>> >>> On 6/29/2011 6:00 PM, David M. Lloyd wrote: >>>> Not really. ?In fact that's basically using the (apparently poor) design choices of the compiler to justify this, which I find to be exceedingly weak. >>>> >>>> The compiler should never need to parse module information more than once per compilation, regardless of how many source files are compiled. ?If it's requiring that, fix the real problem, rather than using it as justification for crap decisions elsewhere. >>>> >>>> On 06/29/2011 07:46 PM, Alex Buckley wrote: >>>>> In the context of Project Jigsaw, javac parses module declarations every >>>>> time a source file in a modular directory structure is compiled. That's >>>>> a powerful driver for Java-like source syntax and a class file form. >>>>> >>>>> Projects which don't put module information so close to the compiler may >>>>> well choose other forms. >>>>> >>>>> Alex >>>>> >>>>> On 6/29/2011 5:24 PM, David M. Lloyd wrote: >>>>>> On 06/29/2011 07:07 PM, Alex Buckley wrote: >>>>>>> (Sent this mail yesterday but I think it got lost.) >>>>>>> >>>>>>> On 6/28/2011 2:24 PM, David Bosschaert wrote: >>>>>>>> I wonder why such a binary .class file for module declarations is >>>>>>>> really needed. Why not go for a textual file, for instance >>>>>>>> META-INF/module-info.jmod (or something like that) and declare the >>>>>>>> module declarations in there using a textual format of some sort? >>>>>>> >>>>>>> The arguments for a binary compiled form are given at: >>>>>>> >>>>>>> http://openjdk.java.net/projects/jigsaw/doc/draft-java-module-system-requirements-12#_C >>>>>>> >>>>>> >>>>>> All of which are trivially debunkable. Yes, it is *slightly* more >>>>>> efficient to read structured binary than a text format. It is an >>>>>> insignificant difference though. We actually parse ours as XML using >>>>>> StAX, which should be somewhat more expensive than a dedicated text >>>>>> parser, and it's so fast that I'm not even able to get a significant >>>>>> measurement of the time when booting up a 100+ module project. The >>>>>> performance argument is invalid. >>>>>> >>>>>> And constraining the module metadata to a Java-like syntax with a >>>>>> Java-like file name is just a dumb idea. There's no reason for it. >>>>>> >>>>>> Saying that requiring a tool to modify the metadata for a module is >>>>>> somehow a good thing is pretty off the wall too. I mean just crazy. >>>>>> >>>>>> Come down to Earth guys. >>>>>> >>>>>>>> IMO there are multiple benefits associated keeping the textual format. >>>>>>>> People using the jar can use a simple zip tool to look inside the jar >>>>>>>> to see what its dependencies are. Additionally tools can easily be >>>>>>>> written to read the module-info.jmod file without needing to resort to >>>>>>>> classfile parsing libraries. The module information can be of use to >>>>>>>> both developer as well as deployer tools. >>>>>>>> >>>>>>>> Finally it's probably easier to make the textual file extensible, as >>>>>>>> required by [1], without resorting to inefficient reflection-style >>>>>>>> operations. >>>>>>> >>>>>>> I think these points are also captured in Appendix C. Could not the same >>>>>>> points have been made in favor of a textual format for class and >>>>>>> interface declarations? >>>>>> >>>>>> Yup. But that ship has sailed. A binary format for module >>>>>> meta-information is going to be yet another annoying disaster. >>>> >>>> >> > > From Alan.Bateman at oracle.com Thu Aug 25 06:22:13 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 25 Aug 2011 14:22:13 +0100 Subject: module-info.class spec and attributes In-Reply-To: References: <4E00E72A.8020104@oracle.com> <4E052910.5080001@oracle.com> <4E05335F.6090609@oracle.com> <4E053859.3060703@oracle.com> <4E0BBE2B.9090907@oracle.com> <4E0BC231.7000200@redhat.com> <4E0BC764.3030300@oracle.com> <4E0BCA9E.8020003@redhat.com> <4E0BE4CF.6000502@oracle.com> <4E0C2145.4070004@univ-mlv.fr> Message-ID: <4E564C85.3010908@oracle.com> David Bosschaert wrote: > Reviving an old thread... it seems like this discussion is left > without coming to an agreed conclusion. > It's an issue where there are divergent views so I don't think you'll see agreement here. For now, capturing the arguments in the requirements document seems the right approach. -Alan. From gnormington at vmware.com Thu Aug 25 06:38:06 2011 From: gnormington at vmware.com (Glyn Normington) Date: Thu, 25 Aug 2011 14:38:06 +0100 Subject: Project Jigsaw goals and requirements In-Reply-To: References: Message-ID: <2AC18653-53F6-4021-B73E-66F3666C6DF2@vmware.com> For the third time of asking, what do folks think of the requirement below? I don't mind if the requirement gets thrown out for valid technical reasons, but to not even consider it would be a shame. Regards, Glyn On 22 Jun 2011, at 09:54, Glyn Normington wrote: > This proposal didn't get a response. What do others think of the requirement? > > Regards, > Glyn > > On 3 Jun 2011, at 12:19, Glyn Normington wrote: > >> Hi Mark >> >> I'm pleased to see the explicit acknowledgement of some basic OSGi interoperation requirements in the requirements document ([1]). >> >> I agree with David Bosschaert ([2]), that it would make sense for OSGi to support the Java SE 8 module format and, for modules which can serve equally well as OSGi bundles, I'd like to avoid dual-maintenance of module metadata and OSGi manifest. I'd like to be able to "decorate" the standard metadata. >> >> However, the requirement "The syntax must place all extended metadata after all standard metadata, with a clear delineation between them." precludes inline decorations. The result would be duplication and clunkiness. >> >> I propose that this requirement be changed so that standard metadata could be decorated inline (the decorations would be ignored by the Java SE module system). >> >> What do you think? >> >> Regards, >> Glyn >> [1] http://openjdk.java.net/projects/jigsaw/doc/draft-java-module-system-requirements-12 >> [2] http://osgithoughts.blogspot.com/2011/05/java-se-8-modularity-requirements.html > From alex.buckley at oracle.com Thu Aug 25 16:54:28 2011 From: alex.buckley at oracle.com (Alex Buckley) Date: Thu, 25 Aug 2011 16:54:28 -0700 Subject: module-info.class spec and attributes In-Reply-To: <4E564C85.3010908@oracle.com> References: <4E00E72A.8020104@oracle.com> <4E052910.5080001@oracle.com> <4E05335F.6090609@oracle.com> <4E053859.3060703@oracle.com> <4E0BBE2B.9090907@oracle.com> <4E0BC231.7000200@redhat.com> <4E0BC764.3030300@oracle.com> <4E0BCA9E.8020003@redhat.com> <4E0BE4CF.6000502@oracle.com> <4E0C2145.4070004@univ-mlv.fr> <4E564C85.3010908@oracle.com> Message-ID: <4E56E0B4.1060404@oracle.com> On 8/25/2011 6:22 AM, Alan Bateman wrote: > David Bosschaert wrote: >> Reviving an old thread... it seems like this discussion is left >> without coming to an agreed conclusion. >> > It's an issue where there are divergent views so I don't think you'll > see agreement here. For now, capturing the arguments in the requirements > document seems the right approach. Right. As David says, the arguments for and against various schemes are very well understood. OpenJDK Project Jigsaw is prototyping one scheme, but the final choice of scheme is not up to the Project, it's up to the Expert Group of the Java SE Module System JSR. Alex From mandy.chung at oracle.com Thu Aug 25 18:20:59 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Thu, 25 Aug 2011 18:20:59 -0700 Subject: Review request: jar tool to transform a plain jar file to a modular jar Message-ID: <4E56F4FB.6060205@oracle.com> I implemented the support in the jar tool to transform a plain JAR file to a modular JAR file [1]: http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/modularize-jar/ Simple example: To modularize an existing jar file (two ways - see below): $ jar uf astro.jar -module org.astro at 2.0 $ jar uf greetings.jar -C modules/com.greetings module-info.class $ java -jar greetings.jar # launch in legacy mode Installing a modular JAR file in the module library $ jmod install greetings.jar astro.jar -L mlib Run in module mode $ java -L mlib -m com.greetings Details: The jar tool provides a new option to transform a plain old JAR file into a modular JAR: -module {module-name at version} Generate META-INF/module-info.class entry in the JAR file [a] It is designed to handle simple cases that: * requires the default Java platform module [b] * exports all public types * main entry point as specified in the manifest or in the 'e' flag, if any * infers the dependencies from 'Class-Path' attribute if it is a modular JAR file, and the specific module name of that version will be added in the module dependency [c]. The jar tool will determine if the inputfiles include a "module-info.class" entry that indicates that it is a modular application. If exists, it will create a modular JAR by copying the module-info.class file in the META-INF directory [d]. The "-module" option is not required in this case. Initially I propose to use the GNU-style option (--module) but it should really be a separate project to have the existing command-line tools to support GNU-style options that deserves its own JEP [2]. I like the option be a long-name option rather than the traditional single letter option which I don't see such inconsistency is an issue or find a good letter for it :) Since the generated module-info.class is typically fairly simple, it doesn't seem really necessary to output the module-info.java and so didn't implement that. Implementation: I use the classfile library that Jon Gibbons wrote to generate the module-info.class. Since Jon will be updating javac and classfile per the module-info spec [3], I modified ModuleExport_attribute and ModuleRequires_attribute classes in a simple way but the right change will come when they are updated per the proposed spec. Footnotes: [a] jarfile name tends to be unnamed or contains '-' character. The module name will not be inferred from the jarfile name. [b] Private and internal APIs in the jdk are not exported. If the JAR file depends on any of these APIs and running in module mode, this will result in a runtime error. [c] If the path listed in the 'Class-Path' attribute is not a modular JAR, it will simply issue a warning and continue. Module dependencies may be incomplete in this case. [d] If an application has been modularized, module-info.java that describes the module definition is placed in the root of the source tree and compiled in the same destination directory as its classes. BTW, I'm working on adding a new regression test for this new functionality. It looks like I have to write a better framework to cover different test cases and do the validation that may take some time. Thanks Mandy [1] http://mail.openjdk.java.net/pipermail/jigsaw-dev/2011-April/001251.html [2] http://openjdk.java.net/jeps [3] http://openjdk.java.net/projects/jigsaw/doc/topics/modules-classfile.html From david.bosschaert at gmail.com Fri Aug 26 00:48:08 2011 From: david.bosschaert at gmail.com (David Bosschaert) Date: Fri, 26 Aug 2011 08:48:08 +0100 Subject: module-info.class spec and attributes In-Reply-To: <4E56E0B4.1060404@oracle.com> References: <4E00E72A.8020104@oracle.com> <4E052910.5080001@oracle.com> <4E05335F.6090609@oracle.com> <4E053859.3060703@oracle.com> <4E0BBE2B.9090907@oracle.com> <4E0BC231.7000200@redhat.com> <4E0BC764.3030300@oracle.com> <4E0BCA9E.8020003@redhat.com> <4E0BE4CF.6000502@oracle.com> <4E0C2145.4070004@univ-mlv.fr> <4E564C85.3010908@oracle.com> <4E56E0B4.1060404@oracle.com> Message-ID: On 26 August 2011 00:54, Alex Buckley wrote: > On 8/25/2011 6:22 AM, Alan Bateman wrote: >> >> David Bosschaert wrote: >>> >>> Reviving an old thread... it seems like this discussion is left >>> without coming to an agreed conclusion. >>> >> >> It's an issue where there are divergent views so I don't think you'll see >> agreement here. For now, capturing the arguments in the requirements >> document seems the right approach. > > Right. As David says, the arguments for and against various schemes are very > well understood. OpenJDK Project Jigsaw is prototyping one scheme, but the > final choice of scheme is not up to the Project, it's up to the Expert Group > of the Java SE Module System JSR. > > Alex Hi Alex, When can we expect that JSR being formed? It's currently listed on http://jcp.org/en/jsr/detail?id=337 as 'JSR TBD: Java Platform Module System'. Thanks, David From alex.buckley at oracle.com Fri Aug 26 11:02:26 2011 From: alex.buckley at oracle.com (Alex Buckley) Date: Fri, 26 Aug 2011 11:02:26 -0700 Subject: module-info.class spec and attributes In-Reply-To: References: <4E00E72A.8020104@oracle.com> <4E052910.5080001@oracle.com> <4E05335F.6090609@oracle.com> <4E053859.3060703@oracle.com> <4E0BBE2B.9090907@oracle.com> <4E0BC231.7000200@redhat.com> <4E0BC764.3030300@oracle.com> <4E0BCA9E.8020003@redhat.com> <4E0BE4CF.6000502@oracle.com> <4E0C2145.4070004@univ-mlv.fr> <4E564C85.3010908@oracle.com> <4E56E0B4.1060404@oracle.com> Message-ID: <4E57DFB2.7070804@oracle.com> On 8/26/2011 12:48 AM, David Bosschaert wrote: > When can we expect that JSR being formed? It's currently listed on > http://jcp.org/en/jsr/detail?id=337 as 'JSR TBD: Java Platform Module > System'. I don't know, and the question is better directed to Oracle's JCP EC rep. Alex From enewcomer at gmail.com Fri Aug 26 12:32:26 2011 From: enewcomer at gmail.com (Eric Newcomer) Date: Fri, 26 Aug 2011 15:32:26 -0400 Subject: module-info.class spec and attributes In-Reply-To: <4E57DFB2.7070804@oracle.com> References: <4E00E72A.8020104@oracle.com> <4E052910.5080001@oracle.com> <4E05335F.6090609@oracle.com> <4E053859.3060703@oracle.com> <4E0BBE2B.9090907@oracle.com> <4E0BC231.7000200@redhat.com> <4E0BC764.3030300@oracle.com> <4E0BCA9E.8020003@redhat.com> <4E0BE4CF.6000502@oracle.com> <4E0C2145.4070004@univ-mlv.fr> <4E564C85.3010908@oracle.com> <4E56E0B4.1060404@oracle.com> <4E57DFB2.7070804@oracle.com> Message-ID: <857B62F1-3B91-4A72-A38B-73369D611DC9@gmail.com> Maybe I can find out from our JCP EC rep (Credit Suisse). I also keep asking about Oracle's plans to support the OSGi APIs in WebLogic similar to JBoss and WebSphere but it seems like we keep getting a similar story - Jigsaw is going to be in Java 8 and that's how our modularity requirements will be met, using a different type of "kitchen utensil" better suited for the job. But I still don't think the original question has ever really been answered about why Jigsaw could not have started with OSGi. What you always seem to get are these "difference of opinion" replies and "we are going ahead with what we're doing in OpenJDK anyway." Eric Sent from my iPad On Aug 26, 2011, at 2:02 PM, Alex Buckley wrote: > On 8/26/2011 12:48 AM, David Bosschaert wrote: >> When can we expect that JSR being formed? It's currently listed on >> http://jcp.org/en/jsr/detail?id=337 as 'JSR TBD: Java Platform Module >> System'. > > I don't know, and the question is better directed to Oracle's JCP EC rep. > > Alex From mandy.chung at oracle.com Fri Aug 26 14:17:38 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Fri, 26 Aug 2011 14:17:38 -0700 Subject: Review request: jar tool to transform a plain jar file to a modular jar In-Reply-To: <4E56F4FB.6060205@oracle.com> References: <4E56F4FB.6060205@oracle.com> Message-ID: <4E580D72.70605@oracle.com> The jigsaw team discussed the option name and the location of the module metadata in the jar file. We decide to follow the single letter convention for the option name and will use letter 'I' which is the closest one to specify a "module ID". When module-info.class exists in the inputfiles, if the metadata is in META-INF/module-info.class, there will be two copies of module-info.class (module-info.class and META-INF/module-info.class) in the jar file. It'd be error-prone for tools that manipulates the module metadata [1]. We decide to keep "module-info.class" as the path for the module metadata in a modular jar file as it's in the modulepath. I'll send out a new webrev once I update the implementation. Mandy [1] http://openjdk.java.net/projects/jigsaw/doc/draft-java-module-system-requirements-12#manipulable-module-metadata On 08/25/11 18:20, Mandy Chung wrote: > I implemented the support in the jar tool to transform a plain JAR file > to a modular JAR file [1]: > http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/modularize-jar/ > > Simple example: > To modularize an existing jar file (two ways - see below): > $ jar uf astro.jar -module org.astro at 2.0 > $ jar uf greetings.jar -C modules/com.greetings module-info.class > $ java -jar greetings.jar # launch in legacy mode > > Installing a modular JAR file in the module library > $ jmod install greetings.jar astro.jar -L mlib > > Run in module mode > $ java -L mlib -m com.greetings > > Details: > The jar tool provides a new option to transform a plain old JAR file > into a modular JAR: > -module {module-name at version} > Generate META-INF/module-info.class entry in the JAR file [a] > > It is designed to handle simple cases that: > * requires the default Java platform module [b] > * exports all public types > * main entry point as specified in the manifest or in the 'e' > flag, if any > * infers the dependencies from 'Class-Path' attribute if it is > a modular JAR file, and the specific module name of > that version will be added in the module dependency [c]. > > The jar tool will determine if the inputfiles include a > "module-info.class" entry that indicates that it is a modular > application. If exists, it will create a modular JAR by copying > the module-info.class file in the META-INF directory [d]. > The "-module" option is not required in this case. > > Initially I propose to use the GNU-style option (--module) but > it should really be a separate project to have the existing > command-line tools to support GNU-style options that deserves > its own JEP [2]. I like the option be a long-name option rather > than the traditional single letter option which I don't see such > inconsistency is an issue or find a good letter for it :) > > Since the generated module-info.class is typically fairly simple, > it doesn't seem really necessary to output the module-info.java > and so didn't implement that. > > Implementation: I use the classfile library that Jon Gibbons wrote > to generate the module-info.class. Since Jon will be updating > javac and classfile per the module-info spec [3], I modified > ModuleExport_attribute and ModuleRequires_attribute classes in > a simple way but the right change will come when they are updated > per the proposed spec. > > Footnotes: > [a] jarfile name tends to be unnamed or contains '-' character. > The module name will not be inferred from the jarfile name. > [b] Private and internal APIs in the jdk are not exported. > If the JAR file depends on any of these APIs and running > in module mode, this will result in a runtime error. > [c] If the path listed in the 'Class-Path' attribute is not a > modular JAR, it will simply issue a warning and continue. > Module dependencies may be incomplete in this case. > [d] If an application has been modularized, module-info.java that > describes the module definition is placed in the root of the > source tree and compiled in the same destination directory as > its classes. > > BTW, I'm working on adding a new regression test for this new > functionality. It looks like I have to write a better framework > to cover different test cases and do the validation that may take > some time. > > Thanks > Mandy > > [1] > http://mail.openjdk.java.net/pipermail/jigsaw-dev/2011-April/001251.html > [2] http://openjdk.java.net/jeps > [3] > http://openjdk.java.net/projects/jigsaw/doc/topics/modules-classfile.html > From mark.reinhold at oracle.com Fri Aug 26 14:57:05 2011 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Fri, 26 Aug 2011 14:57:05 -0700 Subject: module-info.class spec and attributes In-Reply-To: alex.buckley@oracle.com; Thu, 25 Aug 2011 16:54:28 PDT; <4E56E0B4.1060404@oracle.com> Message-ID: <20110826215705.3ABB96E0@eggemoggin.niobe.net> 2011/8/25 16:54 -0700, alex.buckley at oracle.com: > On 8/25/2011 6:22 AM, Alan Bateman wrote: >> David Bosschaert wrote: >>> Reviving an old thread... it seems like this discussion is left >>> without coming to an agreed conclusion. >>> >> It's an issue where there are divergent views so I don't think you'll see >> agreement here. For now, capturing the arguments in the requirements document >> seems the right approach. > > Right. As David says, the arguments for and against various schemes are very > well understood. OpenJDK Project Jigsaw is prototyping one scheme, but the > final choice of scheme is not up to the Project, it's up to the Expert Group of > the Java SE Module System JSR. Exactly so. FYI I expect to submit that JSR some time this October. - Mark From lvjing at linux.vnet.ibm.com Tue Aug 30 00:54:49 2011 From: lvjing at linux.vnet.ibm.com (Jing LV) Date: Tue, 30 Aug 2011 15:54:49 +0800 Subject: Build issue : missing classanalyzer? Message-ID: <4E5C9749.5050807@linux.vnet.ibm.com> Hello, I am trying to build jigsaw with openjdk7 (I am working on win2008 64bit). Download the source and overcome some configuration problems can the build work till I see these these messages: D:/cygwin/home/jdk7/build/windows-amd64/bin/java -XX:-PrintVMOptions -XX:+UnlockDiagnosticVMOptions -XX:-LogVMOutput -Xmx512m -Xms512m -XX:PermSi ze=32m -XX:MaxPermSize=160m \ -cp D:/cygwin/home/jdk7/build/windows-amd64/btjars/classanalyzer.jar \ com.sun.classanalyzer.Modularizer \ -jdkhome D:/cygwin/home/jdk7/build/windows-amd64 \ -update \ -classlistdir D:/cygwin/home/jdk7/build/windows-amd64/moduleinfo/classlist \ -modulepath D:/cygwin/home/jdk7/build/windows-amd64/modules Error: Could not find or load main class com.sun.classanalyzer.Modularizer make[3]: *** [D:/cygwin/home/jdk7/build/windows-amd64/btjars/classanalyzer.jar] Error 1 Checking the directory and find no classanalyzer.jar. I find classanalyzer(JSR308?) was not in the JDK7. Anyway I see this classanalyzer may used in jigsaw project which I am studying, I am not willing to omit it to pass the build. Can someone tell me how can I do to build classanalyzer, or where to download a workable jar? Thanks a lot. -- Best Regards, Jimmy, Jing LV From Alan.Bateman at oracle.com Tue Aug 30 07:11:51 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 30 Aug 2011 15:11:51 +0100 Subject: Build issue : missing classanalyzer? In-Reply-To: <4E5C9749.5050807@linux.vnet.ibm.com> References: <4E5C9749.5050807@linux.vnet.ibm.com> Message-ID: <4E5CEFA7.9000309@oracle.com> Jing LV wrote: > Hello, > > I am trying to build jigsaw with openjdk7 (I am working on win2008 > 64bit). Download the source and overcome some configuration problems can > the build work till I see these these messages: > > D:/cygwin/home/jdk7/build/windows-amd64/bin/java -XX:-PrintVMOptions > -XX:+UnlockDiagnosticVMOptions -XX:-LogVMOutput -Xmx512m -Xms512m -XX:PermSi > ze=32m -XX:MaxPermSize=160m \ > -cp D:/cygwin/home/jdk7/build/windows-amd64/btjars/classanalyzer.jar \ > com.sun.classanalyzer.Modularizer \ > -jdkhome D:/cygwin/home/jdk7/build/windows-amd64 \ > -update \ > -classlistdir D:/cygwin/home/jdk7/build/windows-amd64/moduleinfo/classlist \ > -modulepath D:/cygwin/home/jdk7/build/windows-amd64/modules > Error: Could not find or load main class com.sun.classanalyzer.Modularizer > make[3]: *** > [D:/cygwin/home/jdk7/build/windows-amd64/btjars/classanalyzer.jar] Error 1 > > Checking the directory and find no classanalyzer.jar. I find > classanalyzer(JSR308?) was not in the JDK7. Anyway I see this > classanalyzer may used in jigsaw project which I am studying, I am not > willing to omit it to pass the build. Can someone tell me how can I do > to build classanalyzer, or where to download a workable jar? Thanks a lot. > > I can't tell from this snippet why the class analyzer hasn't been built. Did you keep a full log that you could point us too? All I can guess is that the HOST_JAVA_CMD isn't getting set but I would have thought that would cause the build to fail much earlier (this is something the build sets, you don't set it explicitly). In any case, the class analyzer isn't anything to do with JSR-308. Another thing is that once we are further along then the build is going to change very significantly so that it generates modules directly (as opposed to the current post-processing step). It will be a big change. -Alan. From mandy.chung at oracle.com Tue Aug 30 16:29:17 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Tue, 30 Aug 2011 16:29:17 -0700 Subject: Review request: jar tool to transform a plain jar file to a modular jar In-Reply-To: <4E580D72.70605@oracle.com> References: <4E56F4FB.6060205@oracle.com> <4E580D72.70605@oracle.com> Message-ID: <4E5D724D.5050606@oracle.com> Updated webrev: http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/modularize-jar.01/ To modularize an existing jar file: 1. use 'I' flag to specify the module name $ jar ufI astro.jar org.astro at 2.0 $ jar tvf astro.jar 0 Tue Aug 30 16:15:04 PDT 2011 META-INF/ 74 Tue Aug 30 16:15:04 PDT 2011 META-INF/MANIFEST.MF 0 Tue Aug 30 16:15:00 PDT 2011 org/ 0 Tue Aug 30 16:15:00 PDT 2011 org/astro/ 276 Tue Aug 30 16:15:00 PDT 2011 org/astro/World.class 172 Tue Aug 30 16:21:26 PDT 2011 module-info.class<---- newly generated 2. add module-info.class to the jar file as an input file $ jar uf greetings.jar -C modules/com.greetings module-info.class Installing a modular JAR file in the module library $ jmod install greetings.jar astro.jar -L mlib Run in module mode $ java -L mlib -m com.greetings Details: The jar tool provides a new option to transform a plain old JAR file into a modular JAR: -I {module-name at version} Generate "module-info.class" entry in the JAR file [a] It is designed to handle simple cases that: * requires the default Java platform module [b] * exports all public types * main entry point as specified in the manifest or in the 'e' flag, if any * infers the dependencies from 'Class-Path' attribute if it is a modular JAR file, and the specific module name of that version will be added in the module dependency [c]. The jar tool will determine if the inputfiles include a "module-info.class" entry that indicates that it is a modular application [d]. If exists, 'I' flag cannot be specified. Implementation: I use the classfile library that Jon Gibbons wrote to generate the module-info.class. Since Jon will be updating javac and classfile per the module-info spec [3], I modified ModuleExport_attribute and ModuleRequires_attribute classes in a simple way but the right change will come when they are updated per the proposed spec. Footnotes: [a] jarfile name tends to be unnamed or contains '-' character. The module name will not be inferred from the jarfile name. [b] Private and internal APIs in the jdk are not exported. If the JAR file depends on any of these APIs and running in module mode, this will result in a runtime error. [c] If the path listed in the 'Class-Path' attribute is not a modular JAR, it will simply issue a warning and continue. Module dependencies may be incomplete in this case. [d] If an application has been modularized, module-info.java that describes the module definition is placed in the root of the source tree and compiled in the same destination directory as its classes. Mandy [1] http://mail.openjdk.java.net/pipermail/jigsaw-dev/2011-August/001452.html From Alan.Bateman at oracle.com Wed Aug 31 04:04:00 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 31 Aug 2011 12:04:00 +0100 Subject: Build issue : missing classanalyzer? In-Reply-To: <4E5E1197.9010809@linux.vnet.ibm.com> References: <4E5C9749.5050807@linux.vnet.ibm.com> <4E5CEFA7.9000309@oracle.com> <4E5E1197.9010809@linux.vnet.ibm.com> Message-ID: <4E5E1520.6010509@oracle.com> Jing LV wrote: > Hi Alan, > > Thank you for reply. I've checked with the log (it's of ~300K in > size so unable to upload to the list) but do not have something > related to "HOST_JAVA_CMD" - yes anyway the build has pass nearly all > modules. Only blocked by the classanalyzer. > > I take a little more search in the log, it seems the problem is > due to the class "CONSTANT_ModuleId_info": > src\com\sun\classanalyzer\ > ConstantPoolParser.java:270: error: cannot find symbol > public String visitModuleId(CONSTANT_ModuleId_info info, Void p) { > ^ > symbol: class CONSTANT_ModuleId_info > location: class ConstantPoolParser.StringValueVisitor > > Search in the full openjdk directory for "CONSTANT_ModuleId_info" but > find nothing - am I miss somthing? (I see in google that some archive > mail discussed about this variable, anyway have some trouble to open > the link due to the network problem). Is your langtools repository up to date? -Alan. From mandy.chung at oracle.com Wed Aug 31 07:25:48 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Wed, 31 Aug 2011 07:25:48 -0700 Subject: Build issue : missing classanalyzer? In-Reply-To: <4E5E1520.6010509@oracle.com> References: <4E5C9749.5050807@linux.vnet.ibm.com> <4E5CEFA7.9000309@oracle.com> <4E5E1197.9010809@linux.vnet.ibm.com> <4E5E1520.6010509@oracle.com> Message-ID: <4E5E446C.30701@oracle.com> On 8/31/11 4:04 AM, Alan Bateman wrote: > Jing LV wrote: >> Hi Alan, >> >> Thank you for reply. I've checked with the log (it's of ~300K >> in size so unable to upload to the list) but do not have something >> related to "HOST_JAVA_CMD" - yes anyway the build has pass nearly all >> modules. Only blocked by the classanalyzer. >> >> I take a little more search in the log, it seems the problem is >> due to the class "CONSTANT_ModuleId_info": >> src\com\sun\classanalyzer\ >> ConstantPoolParser.java:270: error: cannot find symbol >> public String visitModuleId(CONSTANT_ModuleId_info info, Void >> p) { >> ^ >> symbol: class CONSTANT_ModuleId_info >> location: class ConstantPoolParser.StringValueVisitor >> >> Search in the full openjdk directory for "CONSTANT_ModuleId_info" but >> find nothing - am I miss somthing? (I see in google that some archive >> mail discussed about this variable, anyway have some trouble to open >> the link due to the network problem). > Is your langtools repository up to date? In case you are just building the jigsaw/jdk repository, for building jigsaw, you need to build jigsaw/langtools, jigsaw/hotspot, and jigsaw/jdk repository together as there are jigsaw changes in the VM and javac. The simplest way is to build the entire forest from the top repo and do "make modules". Mandy From lvjing at linux.vnet.ibm.com Wed Aug 31 03:48:55 2011 From: lvjing at linux.vnet.ibm.com (Jing LV) Date: Wed, 31 Aug 2011 18:48:55 +0800 Subject: Build issue : missing classanalyzer? In-Reply-To: <4E5CEFA7.9000309@oracle.com> References: <4E5C9749.5050807@linux.vnet.ibm.com> <4E5CEFA7.9000309@oracle.com> Message-ID: <4E5E1197.9010809@linux.vnet.ibm.com> Hi Alan, Thank you for reply. I've checked with the log (it's of ~300K in size so unable to upload to the list) but do not have something related to "HOST_JAVA_CMD" - yes anyway the build has pass nearly all modules. Only blocked by the classanalyzer. I take a little more search in the log, it seems the problem is due to the class "CONSTANT_ModuleId_info": src\com\sun\classanalyzer\ ConstantPoolParser.java:270: error: cannot find symbol public String visitModuleId(CONSTANT_ModuleId_info info, Void p) { ^ symbol: class CONSTANT_ModuleId_info location: class ConstantPoolParser.StringValueVisitor Search in the full openjdk directory for "CONSTANT_ModuleId_info" but find nothing - am I miss somthing? (I see in google that some archive mail discussed about this variable, anyway have some trouble to open the link due to the network problem). ? 2011-8-30 22:11, Alan Bateman ??: > Jing LV wrote: >> Hello, >> >> I am trying to build jigsaw with openjdk7 (I am working on win2008 >> 64bit). Download the source and overcome some configuration problems can >> the build work till I see these these messages: >> >> D:/cygwin/home/jdk7/build/windows-amd64/bin/java -XX:-PrintVMOptions >> -XX:+UnlockDiagnosticVMOptions -XX:-LogVMOutput -Xmx512m -Xms512m >> -XX:PermSi >> ze=32m -XX:MaxPermSize=160m \ >> -cp D:/cygwin/home/jdk7/build/windows-amd64/btjars/classanalyzer.jar \ >> com.sun.classanalyzer.Modularizer \ >> -jdkhome D:/cygwin/home/jdk7/build/windows-amd64 \ >> -update \ >> -classlistdir >> D:/cygwin/home/jdk7/build/windows-amd64/moduleinfo/classlist \ >> -modulepath D:/cygwin/home/jdk7/build/windows-amd64/modules >> Error: Could not find or load main class >> com.sun.classanalyzer.Modularizer >> make[3]: *** >> [D:/cygwin/home/jdk7/build/windows-amd64/btjars/classanalyzer.jar] >> Error 1 >> >> Checking the directory and find no classanalyzer.jar. I find >> classanalyzer(JSR308?) was not in the JDK7. Anyway I see this >> classanalyzer may used in jigsaw project which I am studying, I am not >> willing to omit it to pass the build. Can someone tell me how can I do >> to build classanalyzer, or where to download a workable jar? Thanks a >> lot. >> > I can't tell from this snippet why the class analyzer hasn't been > built. Did you keep a full log that you could point us too? All I can > guess is that the HOST_JAVA_CMD isn't getting set but I would have > thought that would cause the build to fail much earlier (this is > something the build sets, you don't set it explicitly). > > In any case, the class analyzer isn't anything to do with JSR-308. > Another thing is that once we are further along then the build is > going to change very significantly so that it generates modules > directly (as opposed to the current post-processing step). It will be > a big change. > > -Alan. -- Best Regards, Jimmy, Jing LV From mark.reinhold at oracle.com Wed Aug 31 10:13:13 2011 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Wed, 31 Aug 2011 10:13:13 -0700 Subject: Project Jigsaw goals and requirements In-Reply-To: gnormington@vmware.com; Fri, 03 Jun 2011 11:19:40 BST; Message-ID: <20110831171313.F3C77C1E@eggemoggin.niobe.net> Apologies for the delayed reply. Unfortunately I've had limited time to devote to the modularity topic over the past couple of months. Between getting JDK 7 out the door, taking some much-needed vacation time, and tending to various non-technical tasks at the request of my management it's been an unexpectedly busy summer. I'm in the process of ramping back up on modularity now, however, and I expect to be more fully engaged going forward. 2011/6/3 3:19 -0700, gnormington at vmware.com: > I'm pleased to see the explicit acknowledgement of some basic OSGi > interoperation requirements in the requirements document ([1]). > > I agree with David Bosschaert ([2]), that it would make sense for OSGi > to support the Java SE 8 module format and, for modules which can serve > equally well as OSGi bundles, I'd like to avoid dual-maintenance of > module metadata and OSGi manifest. I'd like to be able to "decorate" > the standard metadata. > > However, the requirement "The syntax must place all extended metadata > after all standard metadata, with a clear delineation between them." > precludes inline decorations. The result would be duplication and > clunkiness. > > I propose that this requirement be changed so that standard metadata > could be decorated inline (the decorations would be ignored by the Java > SE module system). > > What do you think? Like all other design issues this one will, ultimately, be decided by the EG of the upcoming module-system JSR, which I expect to submit some time in October. What you see in the Jigsaw code right now is just a prototype. For now, my own view on this is that we need to find the right balance between readability and extensibility. It's critical that the standard metadata be easy for every developer to read. In-line decorations tend to reduce readability, especially when their semantics are non-standard and module-system-dependent. Placing extended metadata at the end of a module declaration allows it to be maintained along with the standard metadata but in a way that doesn't harm readability. To put it another way, should the burden of "clunkiness" be borne by all developers, or just by those who need to deal with extended metadata? - Mark From xueming.shen at oracle.com Wed Aug 31 12:37:34 2011 From: xueming.shen at oracle.com (Xueming Shen) Date: Wed, 31 Aug 2011 12:37:34 -0700 Subject: Review request: jar tool to transform a plain jar file to a modular jar In-Reply-To: <4E5D724D.5050606@oracle.com> References: <4E56F4FB.6060205@oracle.com> <4E580D72.70605@oracle.com> <4E5D724D.5050606@oracle.com> Message-ID: <4E5E8D7E.1010906@oracle.com> Comments on the sun.tools.jar.Main (1) #197-#201 Shouldn't the "equals" be the "ignore case equals"? (2) #202-#214 The code might be better(?) organized as if (moduled != null) { if (mif != nuill) { ... return false; } .... } (3) It might be better to move the addModuleRequires() functionality into ModuleInfo implementation? in which it can simply take a Manifest object and take whatever info it might need from the manifest to create the new ModuleInfo object. The sun.tools.jar.Main might not want to know the details of how to transfer the necessary from a Manifest to a ModuleInfo. For example, later you might find you would need an additional attribute from a existing Manifest, ideally you should be able to simply update the ModuleInfo implementation, without touching the sun.tools.jar.Main (the minfo.write(zos) will take care of the writing...) (4) With the migration of new try-resource in getJarPath(), the code might look much better by simply do if (man == null) return files; ... if (value == null) return files And we probably don't need check if (rt != null) new JarFile() should never return null, it will through an IOException if it fails. -Sherman On 08/30/2011 04:29 PM, Mandy Chung wrote: > Updated webrev: > http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/modularize-jar.01/ > > To modularize an existing jar file: > 1. use 'I' flag to specify the module name > > $ jar ufI astro.jar org.astro at 2.0 > > $ jar tvf astro.jar > 0 Tue Aug 30 16:15:04 PDT 2011 META-INF/ > 74 Tue Aug 30 16:15:04 PDT 2011 META-INF/MANIFEST.MF > 0 Tue Aug 30 16:15:00 PDT 2011 org/ > 0 Tue Aug 30 16:15:00 PDT 2011 org/astro/ > 276 Tue Aug 30 16:15:00 PDT 2011 org/astro/World.class > 172 Tue Aug 30 16:21:26 PDT 2011 module-info.class<---- newly generated > > 2. add module-info.class to the jar file as an input file > > $ jar uf greetings.jar -C modules/com.greetings module-info.class > > Installing a modular JAR file in the module library > $ jmod install greetings.jar astro.jar -L mlib > > Run in module mode > $ java -L mlib -m com.greetings > > Details: > The jar tool provides a new option to transform a plain old JAR file > into a modular JAR: > -I {module-name at version} > Generate "module-info.class" entry in the JAR file [a] > > It is designed to handle simple cases that: > * requires the default Java platform module [b] > * exports all public types > * main entry point as specified in the manifest or in the 'e' > flag, if any > * infers the dependencies from 'Class-Path' attribute if it is > a modular JAR file, and the specific module name of > that version will be added in the module dependency [c]. > > The jar tool will determine if the inputfiles include a > "module-info.class" entry that indicates that it is a modular > application [d]. If exists, 'I' flag cannot be specified. > > Implementation: I use the classfile library that Jon Gibbons wrote > to generate the module-info.class. Since Jon will be updating > javac and classfile per the module-info spec [3], I modified > ModuleExport_attribute and ModuleRequires_attribute classes in > a simple way but the right change will come when they are updated > per the proposed spec. > > Footnotes: > [a] jarfile name tends to be unnamed or contains '-' character. > The module name will not be inferred from the jarfile name. > [b] Private and internal APIs in the jdk are not exported. > If the JAR file depends on any of these APIs and running > in module mode, this will result in a runtime error. > [c] If the path listed in the 'Class-Path' attribute is not a > modular JAR, it will simply issue a warning and continue. > Module dependencies may be incomplete in this case. > [d] If an application has been modularized, module-info.java that > describes the module definition is placed in the root of the > source tree and compiled in the same destination directory as > its classes. > > Mandy > [1] > http://mail.openjdk.java.net/pipermail/jigsaw-dev/2011-August/001452.html From sean.mullan at oracle.com Wed Aug 31 13:03:17 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Wed, 31 Aug 2011 16:03:17 -0400 Subject: How can you run jtreg with jdk-base-image? Message-ID: <4E5E9385.6070804@oracle.com> I'm trying to run tests with only a jdk-base-image but I am getting errors because jtreg can't find classes that aren't in the installed modules. Is it possible to run jtreg with this type of setup? Thanks, Sean From mandy.chung at oracle.com Wed Aug 31 13:21:49 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Wed, 31 Aug 2011 13:21:49 -0700 Subject: How can you run jtreg with jdk-base-image? In-Reply-To: <4E5E9385.6070804@oracle.com> References: <4E5E9385.6070804@oracle.com> Message-ID: <4E5E97DD.6080202@oracle.com> On 08/31/11 13:03, Sean Mullan wrote: > I'm trying to run tests with only a jdk-base-image but I am getting errors > because jtreg can't find classes that aren't in the installed modules. Is it > possible to run jtreg with this type of setup? What error did you get? I think most of the jigsaw tests requires the default platform module which is currently the full JDK and so they will fail when running with jdk-base-image. Mandy From sean.mullan at oracle.com Wed Aug 31 13:36:36 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Wed, 31 Aug 2011 16:36:36 -0400 Subject: How can you run jtreg with jdk-base-image? In-Reply-To: <4E5E99C3.8000100@oracle.com> References: <4E5E9385.6070804@oracle.com> <4E5E99C3.8000100@oracle.com> Message-ID: <4E5E9B54.4020509@oracle.com> On 8/31/11 4:29 PM, Alan Bateman wrote: > Sean Mullan wrote: >> I'm trying to run tests with only a jdk-base-image but I am getting errors >> because jtreg can't find classes that aren't in the installed modules. Is it >> possible to run jtreg with this type of setup? >> > Is it classes that jtreg needs or classes that the tests need? jtreg. Here's the exception stack trace: Exception in thread "main" java.lang.NoClassDefFoundError: java/awt/IllegalComponentStateException at javax.help.HelpSet.findHelpSet(HelpSet.java:169) at javax.help.HelpSet.findHelpSet(HelpSet.java:200) at javax.help.HelpSet.findHelpSet(HelpSet.java:213) at com.sun.interview.Interview.setHelpSet(Interview.java:380) at com.sun.javatest.interview.TestsInterview.(TestsInterview.java:72) at com.sun.javatest.interview.BasicInterviewParameters.createTestsInterview(BasicInterviewParameters.java:96) at com.sun.javatest.interview.BasicInterviewParameters.(BasicInterviewParameters.java:64) at com.sun.javatest.interview.BasicInterviewParameters.(BasicInterviewParameters.java:83) at com.sun.javatest.regtest.RegressionParameters.(RegressionParameters.java:56) at com.sun.javatest.regtest.RegressionTestSuite.createInterview(RegressionTestSuite.java:106) at com.sun.javatest.regtest.Main.createParameters(Main.java:1434) at com.sun.javatest.regtest.Main.run(Main.java:979) at com.sun.javatest.regtest.Main.run(Main.java:877) at com.sun.javatest.regtest.Main.main(Main.java:821) > I recall > there were issues with jtreg (may have been JavaTest, which jtreg uses) > needing JavaHelp and AWT and I remember having to do a bit of hacking to > get it to work. yep - do you remember what you did? > The jdk-base-image has the compiler and tools so we > should be able to get this to work. The other useful thing to know is > the -compilejdk option so we should be able to run tests with a > jre-base-image too. Is that a jtreg option? > Anyway, once you get past that then the real fun > begins because our tests aren't organized by module and will have > dependency on modules that aren't in the base image (and since jtreg > will be running the tests in legacy mode then it means ClassNotFoundErrors). I'm mostly interested in running the security tests, validating signed modules and so forth. --Sean From Alan.Bateman at oracle.com Wed Aug 31 13:29:55 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 31 Aug 2011 21:29:55 +0100 Subject: How can you run jtreg with jdk-base-image? In-Reply-To: <4E5E9385.6070804@oracle.com> References: <4E5E9385.6070804@oracle.com> Message-ID: <4E5E99C3.8000100@oracle.com> Sean Mullan wrote: > I'm trying to run tests with only a jdk-base-image but I am getting errors > because jtreg can't find classes that aren't in the installed modules. Is it > possible to run jtreg with this type of setup? > Is it classes that jtreg needs or classes that the tests need? I recall there were issues with jtreg (may have been JavaTest, which jtreg uses) needing JavaHelp and AWT and I remember having to do a bit of hacking to get it to work. The jdk-base-image has the compiler and tools so we should be able to get this to work. The other useful thing to know is the -compilejdk option so we should be able to run tests with a jre-base-image too. Anyway, once you get past that then the real fun begins because our tests aren't organized by module and will have dependency on modules that aren't in the base image (and since jtreg will be running the tests in legacy mode then it means ClassNotFoundErrors). -Alan. From mandy.chung at oracle.com Wed Aug 31 13:59:26 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Wed, 31 Aug 2011 13:59:26 -0700 Subject: How can you run jtreg with jdk-base-image? In-Reply-To: <4E5E9B54.4020509@oracle.com> References: <4E5E9385.6070804@oracle.com> <4E5E99C3.8000100@oracle.com> <4E5E9B54.4020509@oracle.com> Message-ID: <4E5EA0AE.4090201@oracle.com> On 08/31/11 13:36, Sean Mullan wrote: > On 8/31/11 4:29 PM, Alan Bateman wrote: >> Sean Mullan wrote: >>> I'm trying to run tests with only a jdk-base-image but I am getting errors >>> because jtreg can't find classes that aren't in the installed modules. Is it >>> possible to run jtreg with this type of setup? >>> >> Is it classes that jtreg needs or classes that the tests need? > jtreg. Here's the exception stack trace: > > Exception in thread "main" java.lang.NoClassDefFoundError: > java/awt/IllegalComponentStateException > at javax.help.HelpSet.findHelpSet(HelpSet.java:169) > at javax.help.HelpSet.findHelpSet(HelpSet.java:200) > at javax.help.HelpSet.findHelpSet(HelpSet.java:213) > at com.sun.interview.Interview.setHelpSet(Interview.java:380) > at com.sun.javatest.interview.TestsInterview.(TestsInterview.java:72) > at > com.sun.javatest.interview.BasicInterviewParameters.createTestsInterview(BasicInterviewParameters.java:96) > at > com.sun.javatest.interview.BasicInterviewParameters.(BasicInterviewParameters.java:64) > at > com.sun.javatest.interview.BasicInterviewParameters.(BasicInterviewParameters.java:83) > at > com.sun.javatest.regtest.RegressionParameters.(RegressionParameters.java:56) > at > com.sun.javatest.regtest.RegressionTestSuite.createInterview(RegressionTestSuite.java:106) > at com.sun.javatest.regtest.Main.createParameters(Main.java:1434) > at com.sun.javatest.regtest.Main.run(Main.java:979) > at com.sun.javatest.regtest.Main.run(Main.java:877) > at com.sun.javatest.regtest.Main.main(Main.java:821) > >> I recall >> there were issues with jtreg (may have been JavaTest, which jtreg uses) >> needing JavaHelp and AWT and I remember having to do a bit of hacking to >> get it to work. > yep - do you remember what you did? > Is JAVA_HOME set to jdk-base-image? Are you using jtreg -jdk option to specify the jdk to run the tests? For testing purpose, you can run jtreg with jdk 7. You can either unset JAVA_HOME or set ST_JAVA to the runtime for launching jtreg. >> The jdk-base-image has the compiler and tools so we >> should be able to get this to work. The other useful thing to know is >> the -compilejdk option so we should be able to run tests with a >> jre-base-image too. > Is that a jtreg option? > If you unset JAVA_HOME, jtreg should use java on your path. I think this command should work (except that some tests may fail if they depend on classes not in the base module): $ jtreg -jdk:jdk-base-image jdk/test/.... Or $ jtreg -compilejdk:jdk-base-image -jdk:jre-base-image .... >> Anyway, once you get past that then the real fun >> begins because our tests aren't organized by module and will have >> dependency on modules that aren't in the base image (and since jtreg >> will be running the tests in legacy mode then it means ClassNotFoundErrors). > I'm mostly interested in running the security tests, validating signed modules > and so forth. > The above commands should work. Mandy From Alan.Bateman at oracle.com Wed Aug 31 14:09:41 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 31 Aug 2011 22:09:41 +0100 Subject: How can you run jtreg with jdk-base-image? In-Reply-To: <4E5E9B54.4020509@oracle.com> References: <4E5E9385.6070804@oracle.com> <4E5E99C3.8000100@oracle.com> <4E5E9B54.4020509@oracle.com> Message-ID: <4E5EA315.9080800@oracle.com> Sean Mullan wrote: > : > jtreg. Here's the exception stack trace: > > Exception in thread "main" java.lang.NoClassDefFoundError: > java/awt/IllegalComponentStateException > at javax.help.HelpSet.findHelpSet(HelpSet.java:169) > at javax.help.HelpSet.findHelpSet(HelpSet.java:200) > at javax.help.HelpSet.findHelpSet(HelpSet.java:213) > at com.sun.interview.Interview.setHelpSet(Interview.java:380) > at com.sun.javatest.interview.TestsInterview.(TestsInterview.java:72) > at > com.sun.javatest.interview.BasicInterviewParameters.createTestsInterview(BasicInterviewParameters.java:96) > at > com.sun.javatest.interview.BasicInterviewParameters.(BasicInterviewParameters.java:64) > at > com.sun.javatest.interview.BasicInterviewParameters.(BasicInterviewParameters.java:83) > at > com.sun.javatest.regtest.RegressionParameters.(RegressionParameters.java:56) > at > com.sun.javatest.regtest.RegressionTestSuite.createInterview(RegressionTestSuite.java:106) > at com.sun.javatest.regtest.Main.createParameters(Main.java:1434) > at com.sun.javatest.regtest.Main.run(Main.java:979) > at com.sun.javatest.regtest.Main.run(Main.java:877) > at com.sun.javatest.regtest.Main.main(Main.java:821) > Ah, this is running jtreg with the base image whereas you want to run jtreg with a full JDK image. You can do that by setting JT_JAVA to a JDK (legacy or a modular JDK that has all modules installed). Then specify the base image that you want to test by specifying the -jdk option. -Alan. From sean.mullan at oracle.com Wed Aug 31 14:24:43 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Wed, 31 Aug 2011 17:24:43 -0400 Subject: How can you run jtreg with jdk-base-image? In-Reply-To: <4E5EA315.9080800@oracle.com> References: <4E5E9385.6070804@oracle.com> <4E5E99C3.8000100@oracle.com> <4E5E9B54.4020509@oracle.com> <4E5EA315.9080800@oracle.com> Message-ID: <4E5EA69B.5060607@oracle.com> On 8/31/11 5:09 PM, Alan Bateman wrote: > Sean Mullan wrote: >> : >> jtreg. Here's the exception stack trace: >> >> Exception in thread "main" java.lang.NoClassDefFoundError: >> java/awt/IllegalComponentStateException >> at javax.help.HelpSet.findHelpSet(HelpSet.java:169) >> at javax.help.HelpSet.findHelpSet(HelpSet.java:200) >> at javax.help.HelpSet.findHelpSet(HelpSet.java:213) >> at com.sun.interview.Interview.setHelpSet(Interview.java:380) >> at com.sun.javatest.interview.TestsInterview.(TestsInterview.java:72) >> at >> com.sun.javatest.interview.BasicInterviewParameters.createTestsInterview(BasicInterviewParameters.java:96) >> at >> com.sun.javatest.interview.BasicInterviewParameters.(BasicInterviewParameters.java:64) >> at >> com.sun.javatest.interview.BasicInterviewParameters.(BasicInterviewParameters.java:83) >> at >> com.sun.javatest.regtest.RegressionParameters.(RegressionParameters.java:56) >> at >> com.sun.javatest.regtest.RegressionTestSuite.createInterview(RegressionTestSuite.java:106) >> at com.sun.javatest.regtest.Main.createParameters(Main.java:1434) >> at com.sun.javatest.regtest.Main.run(Main.java:979) >> at com.sun.javatest.regtest.Main.run(Main.java:877) >> at com.sun.javatest.regtest.Main.main(Main.java:821) >> > Ah, this is running jtreg with the base image whereas you want to run > jtreg with a full JDK image. You can do that by setting JT_JAVA to a JDK > (legacy or a modular JDK that has all modules installed). Then specify > the base image that you want to test by specifying the -jdk option. Yep that works. --Sean From sean.mullan at oracle.com Wed Aug 31 14:34:18 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Wed, 31 Aug 2011 17:34:18 -0400 Subject: keytool is not in jdk-base-image Message-ID: <4E5EA8DA.7080607@oracle.com> It will be difficult to sign modules without keytool. (It's possible, but you would have to have a keystore already setup with your keys and certificates and know the alias name, etc). --Sean From mandy.chung at oracle.com Wed Aug 31 14:53:18 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Wed, 31 Aug 2011 14:53:18 -0700 Subject: keytool is not in jdk-base-image In-Reply-To: <4E5EA8DA.7080607@oracle.com> References: <4E5EA8DA.7080607@oracle.com> Message-ID: <4E5EAD4E.4090504@oracle.com> On 8/31/11 2:34 PM, Sean Mullan wrote: > It will be difficult to sign modules without keytool. (It's possible, but you > would have to have a keystore already setup with your keys and certificates and > know the alias name, etc). But keytool depends on jsse and jndi. Can these dependencies be eliminated or as optional? sun.security.tools.JarSigner -> sun.security.util.PathList (sun.jsse) sun.security.tools.KeyTool -> javax.net.ssl.HttpsURLConnection (sun.jsse) sun.security.tools.KeyTool -> javax.net.ssl.SSLContext (sun.jsse) sun.security.tools.KeyTool -> javax.net.ssl.TrustManager (sun.jsse) sun.security.tools.KeyTool -> sun.security.pkcs.PKCS10 (sun.jsse) sun.security.tools.KeyTool -> sun.security.pkcs.PKCS10Attribute (sun.jsse) sun.security.tools.KeyTool -> sun.security.pkcs.PKCS10Attributes (sun.jsse) sun.security.tools.KeyTool -> sun.security.provider.certpath.ldap.LDAPCertStoreHelper (sun.jndi) sun.security.tools.KeyTool -> sun.security.util.PathList (sun.jsse) sun.security.tools.KeyTool -> sun.security.x509.CertAndKeyGen (sun.jsse) sun.security.tools.KeyTool$2 -> javax.net.ssl.X509TrustManager (sun.jsse) sun.security.tools.KeyTool$3 -> javax.net.ssl.HostnameVerifier (sun.jsse) sun.security.tools.KeyTool$3 -> javax.net.ssl.SSLSession (sun.jsse) Mandy From weijun.wang at oracle.com Wed Aug 31 17:46:30 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 01 Sep 2011 08:46:30 +0800 Subject: keytool is not in jdk-base-image In-Reply-To: <4E5EAD4E.4090504@oracle.com> References: <4E5EA8DA.7080607@oracle.com> <4E5EAD4E.4090504@oracle.com> Message-ID: <4E5ED5E6.8040103@oracle.com> On 09/01/2011 05:53 AM, Mandy Chung wrote: > On 8/31/11 2:34 PM, Sean Mullan wrote: >> It will be difficult to sign modules without keytool. (It's possible, >> but you >> would have to have a keystore already setup with your keys and >> certificates and >> know the alias name, etc). > > But keytool depends on jsse and jndi. Can these dependencies be > eliminated or as optional? The jndi dependence can be optional, but keytool needs the jsse module to generate certs. See below: > > sun.security.tools.JarSigner -> sun.security.util.PathList (sun.jsse) JarSigner? > sun.security.tools.KeyTool -> javax.net.ssl.HttpsURLConnection (sun.jsse) > sun.security.tools.KeyTool -> javax.net.ssl.SSLContext (sun.jsse) > sun.security.tools.KeyTool -> javax.net.ssl.TrustManager (sun.jsse) > sun.security.tools.KeyTool$2 -> javax.net.ssl.X509TrustManager (sun.jsse) > sun.security.tools.KeyTool$3 -> javax.net.ssl.HostnameVerifier (sun.jsse) > sun.security.tools.KeyTool$3 -> javax.net.ssl.SSLSession (sun.jsse) for keytool -printcert -sslserver > sun.security.tools.KeyTool -> sun.security.pkcs.PKCS10 (sun.jsse) > sun.security.tools.KeyTool -> sun.security.pkcs.PKCS10Attribute (sun.jsse) > sun.security.tools.KeyTool -> sun.security.pkcs.PKCS10Attributes (sun.jsse) for keytool -certreq > sun.security.tools.KeyTool -> > sun.security.provider.certpath.ldap.LDAPCertStoreHelper (sun.jndi) for keytool -printcrl -file ldap://.... > sun.security.tools.KeyTool -> sun.security.util.PathList (sun.jsse) PathList is a utility class to create "a:b:c" on Unix and "a;b;c" on Windows. Is there a similar tool inside base? > sun.security.tools.KeyTool -> sun.security.x509.CertAndKeyGen (sun.jsse) for keytool -genkeypair and keytool -gencert -Max > > > Mandy From mark.reinhold at oracle.com Wed Aug 31 20:53:30 2011 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Wed, 31 Aug 2011 20:53:30 -0700 Subject: Project Jigsaw goals and requirements In-Reply-To: enewcomer@gmail.com; Wed, 31 Aug 2011 20:48:10 EDT; Message-ID: <20110901035330.33320C23@eggemoggin.niobe.net> 2011/8/31 17:48 -0700, enewcomer at gmail.com: > Who will be the spec lead for the modularity JSR? Will it be an open > process, or will the spec lead be someone from Oracle? I will serve as the spec lead for the module-system JSR. Whether having an Oracle spec lead is mutually exclusive with having an "open" process depends, I suppose, upon your definition of "open". The module-system JSR will be run in a fully transparent manner from the start, per the guidelines presently being worked out in JSR 348. - Mark From enewcomer at gmail.com Wed Aug 31 17:48:10 2011 From: enewcomer at gmail.com (Eric Newcomer) Date: Wed, 31 Aug 2011 20:48:10 -0400 Subject: Project Jigsaw goals and requirements In-Reply-To: <20110831171313.F3C77C1E@eggemoggin.niobe.net> References: <20110831171313.F3C77C1E@eggemoggin.niobe.net> Message-ID: Who will be the spec lead for the modularity JSR? Will it be an open process, or will the spec lead be someone from Oracle? Eric Sent from my iPad On Aug 31, 2011, at 1:13 PM, mark.reinhold at oracle.com wrote: > Apologies for the delayed reply. Unfortunately I've had limited time to > devote to the modularity topic over the past couple of months. Between > getting JDK 7 out the door, taking some much-needed vacation time, and > tending to various non-technical tasks at the request of my management > it's been an unexpectedly busy summer. I'm in the process of ramping > back up on modularity now, however, and I expect to be more fully > engaged going forward. > > 2011/6/3 3:19 -0700, gnormington at vmware.com: >> I'm pleased to see the explicit acknowledgement of some basic OSGi >> interoperation requirements in the requirements document ([1]). >> >> I agree with David Bosschaert ([2]), that it would make sense for OSGi >> to support the Java SE 8 module format and, for modules which can serve >> equally well as OSGi bundles, I'd like to avoid dual-maintenance of >> module metadata and OSGi manifest. I'd like to be able to "decorate" >> the standard metadata. >> >> However, the requirement "The syntax must place all extended metadata >> after all standard metadata, with a clear delineation between them." >> precludes inline decorations. The result would be duplication and >> clunkiness. >> >> I propose that this requirement be changed so that standard metadata >> could be decorated inline (the decorations would be ignored by the Java >> SE module system). >> >> What do you think? > > Like all other design issues this one will, ultimately, be decided by > the EG of the upcoming module-system JSR, which I expect to submit some > time in October. What you see in the Jigsaw code right now is just a > prototype. > > For now, my own view on this is that we need to find the right balance > between readability and extensibility. It's critical that the standard > metadata be easy for every developer to read. In-line decorations tend > to reduce readability, especially when their semantics are non-standard > and module-system-dependent. Placing extended metadata at the end of a > module declaration allows it to be maintained along with the standard > metadata but in a way that doesn't harm readability. > > To put it another way, should the burden of "clunkiness" be borne by all > developers, or just by those who need to deal with extended metadata? > > - Mark