RFR 8141521: jrt file system's DirectoryStream reports child paths with wrong paths for directories under /packages

Alan Bateman Alan.Bateman at oracle.com
Thu Nov 5 15:34:19 UTC 2015

On 05/11/2015 09:45, Sundararajan Athijegannathan wrote:
> Please review http://cr.openjdk.java.net/~sundar/8141521/webrev.00/ 
> for https://bugs.openjdk.java.net/browse/JDK-8141521
The NodeAndImage.symLink field looks very strange as a DirectoryStream 
just needs the names of the entries where each is resolved against the 
Path that newDirectoryStream is called on. I just wonder how it works 
with a combination of "." and ".." and other interesting paths.

In the test then shouldn't L608 be child.startsWith(path) as this should 
not be a String comparison. I also wonder having a much more expanded 
test for newDirectoryStream as this should have been caught by unit tests.

BTW: A small request but would it be possible to reduce the length of 
the some of the really long lines. It makes it a bit easier to do 
side-by-side reviews when there isn't horizontal scrolling.


More information about the jigsaw-dev mailing list