Review request 8136930: Simplify use of module-system options by custom launchers

Sundararajan Athijegannathan sundararajan.athijegannathan at
Mon Aug 8 10:57:16 UTC 2016

Nashorn portion of the changes look fine - except for minor comment:


needs to be fixed as well [uses -XaddExports]


On 8/8/2016 4:21 PM, Alan Bateman wrote:
> On 05/08/2016 21:11, Mandy Chung wrote:
>> This patch renames the module-system options to GNU-style as specified
>> in JEP 293 [1] (see below for the new proposed option names).  This
>> addresses the problems discussed in [2] that the launcher will pass
>> the module-system options down to the VM in the form of
>> <option>=<value>.
>> This provides a consistent way to configure the module system and
>> simplify use of module-system options by custom launcher.  This patch
>> also updates several JDK tools including jlink, jmod, jimage, jar,
>> javac, javap, javadoc, javah, jdeps such that the GNU-style
>> module-system options are consistent across all tools.
>> Webrev:
> One thing to check is java.c L1299 where it should have failed if
> has_arg is false (0). Also since the initial module/class is being set
> here then maybe we should have -jar pick up the next arg rather than
> having two different ways to set pwhat.
> I wonder if "This option can be specified more
> than once" should be clearer than it can be used more than once with
> different module/packages. Alternatively maybe it should be just
> dropped from the usage output if the text ends up too wordy.
> In then there is a typo in "instead whitespace"
> (missing "of"). Also probably best to say a "file URL" instead of
> "URL" as I don't think it accepts an arbitrary URL.
> I don't have any other comments, overall it's looking very good.
> -Alan

More information about the jigsaw-dev mailing list