Review request 8136930: Simplify use of module-system options by custom launchers

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Tue Aug 9 04:36:36 UTC 2016


Based on find-in-files on make/properties files, that's all I could
find. +1 on nashorn changes.

-Sundar


On 8/9/2016 1:46 AM, Mandy Chung wrote:
> On Aug 8, 2016, at 3:57 AM, Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com> wrote:
>> Nashorn portion of the changes look fine - except for minor comment:
>>
>> $jdk9-dev/nashorn/buildtools/nasgen/build.properties
>>
>> needs to be fixed as well [uses -XaddExports]
> Fixed.
>
> diff --git a/buildtools/nasgen/project.properties b/buildtools/nasgen/project.properties
> --- a/buildtools/nasgen/project.properties
> +++ b/buildtools/nasgen/project.properties
> @@ -40,8 +40,8 @@
>  javac.debug=true
>  
>  nasgen.module.imports=\
> -    -XaddExports:java.base/jdk.internal.org.objectweb.asm=ALL-UNNAMED \
> -    -XaddExports:java.base/jdk.internal.org.objectweb.asm.util=ALL-UNNAMED
> +    --add-exports java.base/jdk.internal.org.objectweb.asm=ALL-UNNAMED \
> +    --add-exports java.base/jdk.internal.org.objectweb.asm.util=ALL-UNNAMED
>  
>  meta.inf.dir=${src.dir}/META-INF
>  run.classpath=\
>
> Mandy



More information about the jigsaw-dev mailing list