Review Request: JDK-8160851: Remove old module-related options

Mandy Chung mandy.chung at oracle.com
Fri Aug 26 23:24:03 UTC 2016


On Aug 26, 2016, at 4:17 PM, Kevin Rushforth <kevin.rushforth at oracle.com> wrote:
> 
> Hi Mandy,
> 
> How soon were you thinking to push this to 9-dev? Until we change JavaFX to use the new options, which is planned to go into our dev repo on Monday for the following week's promoted build (b135)

So JDK-8163316 does not make b134 (that’s what I thought it’s target for)?

I initially plan to push this next Tuesday for jdk-9+135 integration, specifically for JDK-8163316.

> so if you push the changes to jdk9/dev before build 135 is promoted, it will break JavaFX.
> 

Noted.  I’ll follow up with you.

Mandy

> The following is tracking the FX changes:
> 
> https://bugs.openjdk.java.net/browse/JDK-8163316
> 
> -- Kevin
> 
> 
> Mandy Chung wrote:
>> This patch removes the old module options from java, javac, javadoc, etc.  The new options are in jdk-9+132 [1].  I did a scan on the jdk9/dev forest to replace any remaining reference to the old options.  I find some tests in jdk9/hs/hotspot using the old options that I will file a separate issue.
>> 
>> Webrev at:
>>  http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8160851/webrev.00/index.html
>> 
>> Mandy
>> [1] http://mail.openjdk.java.net/pipermail/jigsaw-dev/2016-August/009025.html
>> 
>> 
>>  



More information about the jigsaw-dev mailing list