Java 9 build 148 causes trouble in Apache Lucene/Solr/Elasticsearch

[Peter Levart]

I think this is OK.

Just a couple of nits in test:

1. You create a static Path bob = Paths.get("bob") field, but then you 
don't use it in:

   56         try (FileChannel fc = FileChannel.open(Paths.get("bob"), 
CREATE, WRITE)) {

2. badBuffers could include a duplicate and a slice of a direct buffer 
allocated with ByteBuffer.allocateDirect()

3. The comment in the test is referencing the old method name:

   26  * @summary Basic test for Unsafe::deallocate


Regards, Peter

On 12/13/2016 08:47 PM, Chris Hegarty wrote:
> Taking into account the feedback so far, and changing the method name ( since
> it is an attractive nuisance ), here is where I think we ended up.
>
> http://cr.openjdk.java.net/~chegar/Unsafe_invokeCleaner/
>
> If this is agreeable, I’ll file an issue in JIRA to track the code changes, and
> update JEP 260.
>
> -Chris.