RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

[Wang Weijun]

> On Feb 19, 2016, at 4:42 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
> On 19/02/2016 08:22, Wang Weijun wrote:
>> A new webrev at
>> 
>>    http://cr.openjdk.java.net/~weijun/8130302/webrev.01/
>> 
>> The options for keytool have
>> 
>>  -provider <name> [-providerArg <arg>]        add a provider by name
>>  -providerclass <class> [-providerArg <arg>]  add a provider by classname
>> 
>> (omit some words because line is too long)
>> 
>> for jarsigner
>> 
>>   [-provider <name>           add a security provider by a provider name
>>     [-providerArg <arg>]] ... configure argument for -provider
>> 
>>   [-providerClass <class>     add a security provider by a fully-qualified classname
>>     [-providerArg <arg>]] ... configure argument for -providerClass
>> 
>> In the test AltProvider.java, I compiled 2 classes (DummyProvider and module-info) for a new module and they manually create the modulepath directory. Is there a more formal way to do that?
>> 
> Thanks, this looks quite good. If the usage output "add a provider by name" had something like "e.g. SunPKCS11" or other example name then I think it would be clearer.

I don't want the line to be too long. Is the preferred terminal width still 80 now? I noticed the java help output still fits with 80 chars but javac is already not. 

> 
> A minor annoyance but the list of providers (and provide classes) is a maintained in jarsigner as a Vector, any reason why this can't be a List?

No reason. It's just history. I can fix it.

--Max


> 
> -Alan.