RFR 8155088, Fix module dependencies in java/sql/* and javax/* tests

Felix Yang felix.yang at oracle.com
Wed May 4 15:44:01 UTC 2016


Hi Alan,


On 2016/5/4 22:45, Alan Bateman wrote:
>
>
> On 04/05/2016 15:39, Felix Yang wrote:
>> Hi Alan,
>>
>>     please review the updated webrev. Reverted changes for those 
>> tests with "-addmods".
>>
>> http://cr.openjdk.java.net/~xiaofeya/8155088/webrev.01/
> For the javax.transaction test then don't you also add 
> "java.transaction" in the @modules value? The rest looks fine.
I'm a bit confused here. There is "-addmods java.transaction" for 
@compile. Is it still necessary to declare in @modules?
Actually, if add java.transaction in the @modules, the test will be 
skipped by jtreg. Filed 
https://bugs.openjdk.java.net/browse/CODETOOLS-7901671 for jtreg, 
because it looks to be not a good practice for either situation.

-Felix
>
> -Alan



More information about the jigsaw-dev mailing list