RFR 8154182: Fix java/lang/Class/getDeclaredField/FieldSetAccessibleTest.java to only use available modules

Mandy Chung mandy.chung at oracle.com
Wed May 4 20:07:06 UTC 2016


> On Apr 13, 2016, at 10:29 AM, Alexandre (Shura) Iline <alexandre.iline at oracle.com> wrote:
> 
> Hi,
> 
> Could you be so kind to take a look on this fix:
> http://cr.openjdk.java.net/~shurailine/8154182/webrev.00/

Looks okay.  Some suggestion:

You only need to walk one root:
   root = fs.getPath("/modules”)

and instead of caching the available modules, you could
   .filter(x -> Layer.boot().findModule(x.getName(1).toString())).isPresent()

I can sponsor your patch - please send me the changeset.

Mandy


More information about the jigsaw-dev mailing list