RFR 8154182: Fix java/lang/Class/getDeclaredField/FieldSetAccessibleTest.java to only use available modules

Mandy Chung mandy.chung at oracle.com
Thu May 5 20:45:38 UTC 2016


Looks fine.

Mandy

> On May 5, 2016, at 1:09 PM, Alexandre (Shura) Iline <alexandre.iline at oracle.com> wrote:
> 
> http://cr.openjdk.java.net/~shurailine/8154182/webrev.01/
> 
> I was storing the module list in a collection before to get the things more “effective”. It did not make it more effective, you are right about that.
> 
> Thanks for the tip on “/modules”.
> 
> Please take a look.
> 
> Shura
> 
>> On May 4, 2016, at 1:07 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
>> 
>> 
>>> On Apr 13, 2016, at 10:29 AM, Alexandre (Shura) Iline <alexandre.iline at oracle.com> wrote:
>>> 
>>> Hi,
>>> 
>>> Could you be so kind to take a look on this fix:
>>> http://cr.openjdk.java.net/~shurailine/8154182/webrev.00/
>> 
>> Looks okay.  Some suggestion:
>> 
>> You only need to walk one root:
>>  root = fs.getPath("/modules”)
>> 
>> and instead of caching the available modules, you could
>>  .filter(x -> Layer.boot().findModule(x.getName(1).toString())).isPresent()
>> 
>> I can sponsor your patch - please send me the changeset.
>> 
>> Mandy
> 



More information about the jigsaw-dev mailing list