RFR 8156972: java/lang/reflect/Layer/LayerAndLoadersTest.java test requires jdk.compiler
Alan Bateman
Alan.Bateman at oracle.com
Sat May 14 15:37:14 UTC 2016
On 13/05/2016 23:54, Alexandre (Shura) Iline wrote:
> Hi.
>
> Could you please take a look on the fix:
> http://cr.openjdk.java.net/~shurailine/8156972/webrev.00/
>
> Besides adding @modules, I have also added a couple of lines to the library class, because I have found the NPE which I was getting originally non-informative.
>
The @modules looks good. For CompileUtils then it might be better to
throw UOE instead of ISE for this case. Also would be good to add this
exception to the @throws list in the javadoc.
-Alan.
More information about the jigsaw-dev
mailing list