RFR 8156497: Add jar tool support for Multi-release modular JARs

Chris Hegarty chris.hegarty at oracle.com
Tue May 24 08:31:06 UTC 2016


On 24 May 2016, at 06:28, Mandy Chung <mandy.chung at oracle.com> wrote:
> 
> 
>> On May 23, 2016, at 8:05 AM, Chris Hegarty <chris.hegarty at oracle.com> wrote:
>> 
>> Updated webrev:
>> http://cr.openjdk.java.net/~chegar/8156497.01/
> 
> 
> Looks fine to me.

Thanks Mandy.

> Minor comment on the test, “9” is hardcoded in a few places.  It might be good to prepare for the future release e.g. use Runtime.version().major() + 1 instead.
> 
> e.g.
> 257             "-C", mrjarDir.toString(), "META-INF/versions/9/module-info.class”,
> 760         Path versionSection = metaInfDir.resolve("versions").resolve("9”);

Since this is already pushed, and I want to revisit the test once other
MRJAR tooling support is in, I filed the following bug to track this:
  https://bugs.openjdk.java.net/browse/JDK-8157658

-Chris.


More information about the jigsaw-dev mailing list