RFR 8157931, jdk/internal/jrtfs/Basic.java fails with exploded builds
Felix Yang
felix.yang at oracle.com
Thu May 26 14:50:22 UTC 2016
Hi all,
thanks for review. A clean-up version:
http://cr.openjdk.java.net/~xiaofeya/8157931/webrev.01/
- Felix
On 2016/5/26 19:22, Alan Bateman wrote:
>
>
> On 26/05/2016 11:58, Felix Yang wrote:
>> Hi there,
>>
>> please review the following change.
>>
>> Webrev: http://cr.openjdk.java.net/~xiaofeya/8157931/webrev.00/
>>
> The approach looks okay but would be good to do a few clean ups before
> pushing this.
>
> One thing is the indentation in setup() is messed up by the removal of
> try/catch.
>
> I also think it should use notExists rather than !exists (remember
> !exists will return true if the existence cannot be determined so the
> test should fail for this case).
>
> testKnownClassFiles now prints the file size, I assume that is for
> another issue.
>
> -Alan
More information about the jigsaw-dev
mailing list