Review Request JDK-8160286: jmod hash is creating unlinkable modules.

Chris Hegarty chris.hegarty at oracle.com
Thu Jan 12 13:58:34 UTC 2017


> On 11 Jan 2017, at 23:47, Mandy Chung <mandy.chung at oracle.com> wrote:
> 
> Webrev:
>  http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8160286/webrev.00/

Looks fine. It’s good to share as much of this code as possible between
these packaging tools.

I didn’t look too hard at Graph and TopoSorter, these look similar to
what is in other areas, e.g. jdeps, 

In the jar option parsing did you mean to construct ModulePath with true?
This will support jmod files.

-Chris.


More information about the jigsaw-dev mailing list