Review Request JDK-8160286: jmod hash is creating unlinkable modules.

Mandy Chung mandy.chung at oracle.com
Thu Jan 12 15:53:47 UTC 2017


> On Jan 12, 2017, at 5:58 AM, Chris Hegarty <chris.hegarty at oracle.com> wrote:
> 
> 
>> On 11 Jan 2017, at 23:47, Mandy Chung <mandy.chung at oracle.com> wrote:
>> 
>> Webrev:
>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8160286/webrev.00/
> 
> Looks fine. It’s good to share as much of this code as possible between
> these packaging tools.
> 
> I didn’t look too hard at Graph and TopoSorter, these look similar to
> what is in other areas, e.g. jdeps, 
> 

Yes it is from jdeps.

> In the jar option parsing did you mean to construct ModulePath with true?
> This will support jmod files.

Yes that will allow a modular JAR to tie with a specific JDK build or packaged modules with native library.

Mandy


More information about the jigsaw-dev mailing list