8174823: Module system implementation refresh (3/2017)

Alan Bateman Alan.Bateman at oracle.com
Wed Mar 22 17:27:08 UTC 2017

On 22/03/2017 17:20, Remi Forax wrote:

> So ModuleTarget.osVersion is removed, i will have to update ASM accordingly.
ModuleTarget is JDK-specific now, I think JEP 261 will be the place to 
document it.

> In jdk/internal/module/ModuleBootstrap.java,
>    addExtraExportsOrOpens(bootLayer, extraOpens, true, builder);
> should be
>    addExtraExportsOrOpens(bootLayer, extraOpens, ADD_OPENS, builder);
> there is no point to introduce a boolean here.
This hasn't changed in this patch but I agree it could be a bit cleaner.

> In java.lang.reflect.Method,
> the StringJoiner is created even if there are no parameters.
> AccessibleObject.toShortString() should have a javadoc.
The javadoc is brief but it's not a public method.


More information about the jigsaw-dev mailing list