Review Request: JDK-8174826 jlink does not provide support for linking in service provider modules

Mandy Chung mandy.chung at
Thu Mar 23 18:16:21 UTC 2017

> On Mar 23, 2017, at 11:07 AM, Mandy Chung <mandy.chung at> wrote:
>> Instead of "copy-paste" code to run Jlink in tests ProcessTools and OutputAnalyzer can be used from standard test library test/lib/share/classes/jdk/test/lib/process
> I agree that it’d be good to move it to a test library but this does not need to be the general one since it’s jlink-specific.  jlink has a test library under jdk/tests/tools/lib/tests that needs big cleanup.  At some point we should look at all jlink tests and see what makes sense. 
> For these new tests, I can move the helper class to jdk/tests/tools/lib/tests. 

Having another look at jdk/tests/tools/lib/tests/*, I think it’s probably best to leave these new tests as is and avoid adding more helper classes until they are cleaned up/unified.


More information about the jigsaw-dev mailing list