RFR 8194922: jlink --exclude-resources should never exclude module-info.class

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Tue Feb 20 08:08:49 UTC 2018


Updated: http://cr.openjdk.java.net/~sundar/8194922/webrev.01/

* replaced endsWith with equals on $MODULE/module-info.class
* jlink shows warning when module-info.class is not included (but 
implied to be excluded by --exclude-resources pattern)
* Renamed the test.

Thanks,
-Sundar

On 19/02/18, 9:52 PM, Alan Bateman wrote:
> On 19/02/2018 16:12, Sundararajan Athijegannathan wrote:
>> Please review.
>>
>> Webrev: http://cr.openjdk.java.net/~sundar/8194922/webrev.00/
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8194922
> I assume it should be testing the resource name with equals rather 
> than endsWith. I also wonder if jlink should fail for this case as it 
> means the jlink user has specified the wrong path to --exclude-resources.
>
> JDK_8194922_Test.java needs a better name to be consistent with the 
> tests in this area.
>
> -Alan


More information about the jigsaw-dev mailing list