RFR 8194922: jlink --exclude-resources should never exclude module-info.class
mandy chung
mandy.chung at oracle.com
Tue Feb 20 18:33:51 UTC 2018
Looks good. I agree that this should be an error when excluding module
declaration. Mandy
On 2/20/18 1:50 AM, Sundararajan Athijegannathan wrote:
> Throwing exception now ->
> http://cr.openjdk.java.net/~sundar/8194922/webrev.02/
>
> Thanks
> -Sundar
>
> On 20/02/18, 2:54 PM, Alan Bateman wrote:
>> On 20/02/2018 08:08, Sundararajan Athijegannathan wrote:
>>>
>>> Updated: http://cr.openjdk.java.net/~sundar/8194922/webrev.01/
>>>
>>> * replaced endsWith with equals on $MODULE/module-info.class
>>> * jlink shows warning when module-info.class is not included (but
>>> implied to be excluded by --exclude-resources pattern)
>>> * Renamed the test.
>> Thinking about more, it might be better for this to be an error
>> rather than a warning so the jlink user fixes the filter. The test
>> changes look good.
>>
>> -Alan
More information about the jigsaw-dev
mailing list