SV: Review request: JMC-6395: update jetty-maven-plugin from org.morbay.jetty to org.eclipse.jetty

[Marcus Hirt]

Hi Guru,

Looks good!

Kind regards,
Marcus

-----Ursprungligt meddelande-----
Från: jmc-dev <jmc-dev-bounces at openjdk.java.net> För Guru
Skickat: den 9 april 2019 12:58
Till: Marcus Hirt <marcus.hirt at datadoghq.com>; jmc-dev at openjdk.java.net
Ämne: Re: Review request: JMC-6395: update jetty-maven-plugin from org.morbay.jetty to org.eclipse.jetty

Thanks Marcus, 

Please find updated web rev : http://cr.openjdk.java.net/~ghb/JMC-6395/webrev.1/ <http://cr.openjdk.java.net/~ghb/JMC-6395/webrev.1/> 
RC : updated packaging type to “war” instead of “pom”. Updated jetty-maven-plugin expects deployable module to be of type “war”. 

Thanks,
Guru 
> On 09-Apr-2019, at 4:22 PM, Marcus Hirt <marcus.hirt at datadoghq.com> wrote:
> 
> Hi Guru,
> 
> The upgrade applies and builds properly, but the p2 site will no longer start with mvn jetty:run. Some additional work will be required.
> 
> Kind regards,
> Marcus
> 
> On Tue, Apr 9, 2019 at 12:36 PM Guru <guru.hb at oracle.com <mailto:guru.hb at oracle.com>> wrote:
> Hi,
> 
> Please review the fix for 
> JBS : https://bugs.openjdk.java.net/browse/JMC-6395
>  <https://bugs.openjdk.java.net/browse/JMC-6395>Web rev : http://cr.openjdk.java.net/~ghb/JMC-6395/webrev.0/ <http://cr.openjdk.java.net/~ghb/JMC-6395/webrev.0/>
> RC : updated jetty-maven-plugin to latest version (which is not maintained by eclipse community). 
> 
> Thanks,
> Guru