SV: Review request for JMC-6460: Simple mechanism for building JMC under docker.

[Marcus Hirt]

Hi Jie,

Agreed - that would be a great upgrade! :) We should actually be building
core with JDK 7 and the rest with JDK 8 (for now).

Regarding the copy statements, that is true. I added the license folder.

Kind regards,
Marcus

-----Ursprungligt meddelande-----
Från: Jie Kang <jkang at redhat.com> 
Skickat: den 30 april 2019 23:11
Till: Marcus Hirt <marcus at hirt.se>
Kopia: jmc-dev at openjdk.java.net
Ämne: Re: Review request for JMC-6460: Simple mechanism for building JMC under docker.

Oh this looks neat!

Maybe this can be a further patch, but what are your thoughts on also separating the builds of jmc and jmc-core into two containers? This way we can easily create composes that build jmc via container without necessarily building jmc core and vice versa. As well if we ever want a different build jdk for jmc versus jmc-core, maybe 8 for core and
11+ for jmc, it will be quite easily done by changing the base image
for whichever (though I am not sure if this would ever happen)

--- old/./README.md 2019-04-30 22:09:38.547931000 +0200
+++ new/./README.md 2019-04-30 22:09:38.433931200 +0200
@@ -276,6 +276,15 @@
[...]
+## Building using docker and docker-compose
+
+```
+docker-compose -f docker/docker-compose.yml run jmc ```
+
+Once build has finished the results will be in the `target` directory

For the README entry, would it be worthwhile to expand on "supported"
versions for Docker and Docker-Compose? Any version that isn't years old would be okay to start with.

--- /dev/null 2019-04-30 21:08:09.544941500 +0200
+++ new/docker/Dockerfile-jmc 2019-04-30 22:09:39.145930700 +0200
@@ -0,0 +1,14 @@
[...]
+WORKDIR /jmc
+COPY core core/
+COPY application application/
+COPY configuration configuration/
+COPY releng releng/
+COPY pom.xml ./

I found the COPY statements of each individual folder under jmc to be curious. It looks like the license folder is excluded but I would have expected files under it to be used in the build process. Is it not needed?


Regards,


On Tue, Apr 30, 2019 at 4:18 PM Marcus Hirt <marcus at hirt.se> wrote:
>
> Hi all,
>
> Please review this patch from Will Thames to provide a simple 
> mechanism for building JMC under docker.
>
> Jira:   https://bugs.openjdk.java.net/browse/JMC-6460
> Patch:  http://cr.openjdk.java.net/~hirt/JMC-6460/webrev.0/
>
> Kind regards,
> Marcus
>