From hirt at openjdk.java.net  Wed Dec  1 09:26:34 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 1 Dec 2021 09:26:34 GMT
Subject: RFR: 7439: Introduced IConstantPoolExtension for Constant Pools
 [v5]
In-Reply-To: <YgJDaJ6M4ud3pW06DLelKWVQ-24LzwWBdXQF1ZCZVsI=.2a057cda-8ee6-48ec-a288-ca7e6c7e5de6@github.com>
References: <yr6Hwt8RLp5vDKKxZNrB55aBiyZaP00et_A_BsBw6Dc=.32b3e0bd-ffdb-4a43-8020-c0305d586a52@github.com>
 <tEPoe4rCFtYF8UlIJjqL37kF8Yi0r01TT2KTLUhlPpQ=.4a30577c-c270-46ba-be1c-0124a80d0d80@github.com>
 <YgJDaJ6M4ud3pW06DLelKWVQ-24LzwWBdXQF1ZCZVsI=.2a057cda-8ee6-48ec-a288-ca7e6c7e5de6@github.com>
Message-ID: <63uTN4CAQkOccR5MsXSACHn-oBZ-ddLQMmg2K67dhKs=.94223fb2-a0cc-4e75-aef5-a7b08bd96df3@github.com>

On Mon, 22 Nov 2021 21:19:42 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

>> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   formatting
>
> It would be nice to have your feedback on this, because I came back a lot on the design to implement my needs. So depending on yours, we may revisit some parts...

Hi @jpbempel - you can now integrate this PR. :)

-------------

PR: https://git.openjdk.java.net/jmc/pull/333

From hirt at openjdk.java.net  Wed Dec  1 09:28:31 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 1 Dec 2021 09:28:31 GMT
Subject: RFR: 7248: JMC7/8 Automated Analysis taking very long time to
 produce results for Class Leak Rule. [v2]
In-Reply-To: <vXvJemqDdMB3c28EsUYq4rZBlGyBlN17oSKsh2uXK-w=.0c147ce4-152a-4528-9250-20fd19bb8296@github.com>
References: <Z3iBC1F9opjtmLT4pLMnbppdQ6n8HtShSr6VGKPZ9TI=.88ec1592-1ec6-4d2c-901f-e215f6d3dfd5@github.com>
 <HNM7GkfvFzkYhzGVT0Tq4vLCyzCMrkzQ98upmJlG54w=.b227c920-302e-4882-bd15-dc533622cab9@github.com>
 <vXvJemqDdMB3c28EsUYq4rZBlGyBlN17oSKsh2uXK-w=.0c147ce4-152a-4528-9250-20fd19bb8296@github.com>
Message-ID: <m2dPkD_GVD5KpqnuqgGTMoPhpXtwiB0JTXJQVHpfPbk=.17785d30-5203-4a76-b826-2a4ff28f6eaf@github.com>

On Wed, 26 May 2021 13:17:20 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> Hi,
>> 
>> I believe the executor code has some issues that should be tackled.
>
> Hi @bric3 thanks for your review. Looks like we need to redesign this rule because 15 min is too much time in itself to calculate rule results. I tried Stream::parallelStream approach as well but unfortunately that is taking around 25-30 min which is unacceptable. So I will look into it again.

Hi @Suchitainf - just checking on how you want to proceed with this one.

-------------

PR: https://git.openjdk.java.net/jmc/pull/248

From jpbempel at openjdk.java.net  Wed Dec  1 09:39:57 2021
From: jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Wed, 1 Dec 2021 09:39:57 GMT
Subject: RFR: 7463: JfrEditor instances are kept in memory by
 NavigationHistory [v2]
In-Reply-To: <I3otvvCcgDHzI1e35HUsmqk5H9gpWcL0uqmz0NOIvJI=.17b8d56b-22f2-4c84-b68b-17f5b2013d2f@github.com>
References: <I3otvvCcgDHzI1e35HUsmqk5H9gpWcL0uqmz0NOIvJI=.17b8d56b-22f2-4c84-b68b-17f5b2013d2f@github.com>
Message-ID: <10qolMGhenwzGtfHz2l6H6yvnAe-WBxuG_AspaFh8S4=.73a15714-f39c-4747-a857-e61703ac3b78@github.com>

> Provide a sub class of NavigationHistory instead of implementing a
> full INavigationHistory.
> JfrEditor is not kept anymore when releasing state/disposing.
> 
> Provide a sub class of NavigationHistory instead of implementing a
> full INavigationHistory.
> JfrEditor is not kept anymore when releasing state/disposing.
> 
> JMC 8.1, opening 13 recordings, then closing them:
> 
> COMP11909:~/git/jmc-jpbempel$ jcmd 55089 GC.heap_info
> 55089:
>  garbage-first heap   total 989184K, used 488772K [0x0000000700000000, 0x0000000800000000)
>   region size 1024K, 1 young (1024K), 0 survivors (0K)
>  Metaspace       used 60486K, capacity 65423K, committed 65584K, reserved 1105920K
>   class space    used 6822K, capacity 8453K, committed 8576K, reserved 1048576K
> COMP11909:~/git/jmc-jpbempel$ jcmd 55089 GC.run
> 55089:
> Command executed successfully
> COMP11909:~/git/jmc-jpbempel$ jcmd 55089 GC.heap_info
> 55089:
>  garbage-first heap   total 989184K, used 488410K [0x0000000700000000, 0x0000000800000000)
>   region size 1024K, 1 young (1024K), 0 survivors (0K)
>  Metaspace       used 61621K, capacity 66457K, committed 66736K, reserved 1107968K
>   class space    used 6938K, capacity 8583K, committed 8704K, reserved 1048576K
> 
> memory is not released even after GC
> 
> JMC 8.2 + fix:
> 
> COMP11909:~/git/jmc-jpbempel$ jcmd 56259 GC.heap_info
> 56259:
>  garbage-first heap   total 1625088K, used 556392K [0x0000000700000000, 0x0000000800000000)
>   region size 1024K, 1 young (1024K), 0 survivors (0K)
>  Metaspace       used 61931K, capacity 66724K, committed 66992K, reserved 1107968K
>   class space    used 6991K, capacity 8586K, committed 8704K, reserved 1048576K
> COMP11909:~/git/jmc-jpbempel$ jcmd 56259 GC.run
> 56259:
> Command executed successfully
> COMP11909:~/git/jmc-jpbempel$ jcmd 56259 GC.heap_info
> 56259:
>  garbage-first heap   total 109568K, used 28592K [0x0000000700000000, 0x0000000800000000)
>   region size 1024K, 1 young (1024K), 0 survivors (0K)
>  Metaspace       used 62269K, capacity 67053K, committed 67248K, reserved 1107968K
>   class space    used 6994K, capacity 8588K, committed 8704K, reserved 1048576K

Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:

  keep navigation to the right page
  
  as long as the page is still open

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/338/files
  - new: https://git.openjdk.java.net/jmc/pull/338/files/749158b4..edcb96d7

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=338&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=338&range=00-01

  Stats: 14 lines in 2 files changed: 10 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jmc/pull/338.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/338/head:pull/338

PR: https://git.openjdk.java.net/jmc/pull/338

From jpbempel at openjdk.java.net  Wed Dec  1 09:39:58 2021
From: jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Wed, 1 Dec 2021 09:39:58 GMT
Subject: RFR: 7463: JfrEditor instances are kept in memory by
 NavigationHistory
In-Reply-To: <xEvu63EkFDXGwbXc69z_h0Tr7k3l4i1z2Ikb4wLbW0g=.e6876620-7427-4321-b0ab-6530cdd2bbc1@github.com>
References: <I3otvvCcgDHzI1e35HUsmqk5H9gpWcL0uqmz0NOIvJI=.17b8d56b-22f2-4c84-b68b-17f5b2013d2f@github.com>
 <xEvu63EkFDXGwbXc69z_h0Tr7k3l4i1z2Ikb4wLbW0g=.e6876620-7427-4321-b0ab-6530cdd2bbc1@github.com>
Message-ID: <DMhc7Z2CfMZN3cf9MH5lc70D5NMxR1GSa24ObU57Hb0=.1de9ad09-9279-4682-a239-3fa999f00336@github.com>

On Tue, 30 Nov 2021 18:13:18 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Do we want to keep the ability to open on the right page?

Yes, as long as the recording is still open, we navigate back to the specific previous page.
However when it's closed, the navigation can only reopen the recording and land on the default page.

-------------

PR: https://git.openjdk.java.net/jmc/pull/338

From jpbempel at openjdk.java.net  Wed Dec  1 09:59:32 2021
From: jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Wed, 1 Dec 2021 09:59:32 GMT
Subject: Integrated: 7439: Introduced IConstantPoolExtension for Constant Pools
In-Reply-To: <yr6Hwt8RLp5vDKKxZNrB55aBiyZaP00et_A_BsBw6Dc=.32b3e0bd-ffdb-4a43-8020-c0305d586a52@github.com>
References: <yr6Hwt8RLp5vDKKxZNrB55aBiyZaP00et_A_BsBw6Dc=.32b3e0bd-ffdb-4a43-8020-c0305d586a52@github.com>
Message-ID: <mVpeYY8YpM6_YK6An58Qk-XVRqamtNGtX6gSWx974_Y=.8a70599a-fecd-4111-a72c-8cdeed85fa65@github.com>

On Fri, 29 Oct 2021 14:28:24 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

> Add extension methods when constants are read, referenced, resolved, constant pools fully resolved and parsing finished to be able for example:
> 
>  * track constant pool usage inside events
>  * replace or translate symbols, method names, etc... like
> de-obfuscations of stack traces

This pull request has now been integrated.

Changeset: d4449cec
Author:    Jean-Philippe Bempel <jpbempel at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/d4449cec8804ee087b9a3e2937fb58ce061b17df
Stats:     455 lines in 13 files changed: 438 ins; 0 del; 17 mod

7439: Introduced IConstantPoolExtension for Constant Pools

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/333

From hirt at openjdk.java.net  Thu Dec  2 15:18:33 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 2 Dec 2021 15:18:33 GMT
Subject: RFR: 7463: JfrEditor instances are kept in memory by
 NavigationHistory [v2]
In-Reply-To: <10qolMGhenwzGtfHz2l6H6yvnAe-WBxuG_AspaFh8S4=.73a15714-f39c-4747-a857-e61703ac3b78@github.com>
References: <I3otvvCcgDHzI1e35HUsmqk5H9gpWcL0uqmz0NOIvJI=.17b8d56b-22f2-4c84-b68b-17f5b2013d2f@github.com>
 <10qolMGhenwzGtfHz2l6H6yvnAe-WBxuG_AspaFh8S4=.73a15714-f39c-4747-a857-e61703ac3b78@github.com>
Message-ID: <TZ1WtL8PJxNSgbU6d0XqS9K-9ViPePRCyxzDdScyD_U=.6b247db8-cea4-4cb3-9707-2617af703812@github.com>

On Wed, 1 Dec 2021 09:39:57 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

>> Provide a sub class of NavigationHistory instead of implementing a
>> full INavigationHistory.
>> JfrEditor is not kept anymore when releasing state/disposing.
>> 
>> Provide a sub class of NavigationHistory instead of implementing a
>> full INavigationHistory.
>> JfrEditor is not kept anymore when releasing state/disposing.
>> 
>> JMC 8.1, opening 13 recordings, then closing them:
>> 
>> COMP11909:~/git/jmc-jpbempel$ jcmd 55089 GC.heap_info
>> 55089:
>>  garbage-first heap   total 989184K, used 488772K [0x0000000700000000, 0x0000000800000000)
>>   region size 1024K, 1 young (1024K), 0 survivors (0K)
>>  Metaspace       used 60486K, capacity 65423K, committed 65584K, reserved 1105920K
>>   class space    used 6822K, capacity 8453K, committed 8576K, reserved 1048576K
>> COMP11909:~/git/jmc-jpbempel$ jcmd 55089 GC.run
>> 55089:
>> Command executed successfully
>> COMP11909:~/git/jmc-jpbempel$ jcmd 55089 GC.heap_info
>> 55089:
>>  garbage-first heap   total 989184K, used 488410K [0x0000000700000000, 0x0000000800000000)
>>   region size 1024K, 1 young (1024K), 0 survivors (0K)
>>  Metaspace       used 61621K, capacity 66457K, committed 66736K, reserved 1107968K
>>   class space    used 6938K, capacity 8583K, committed 8704K, reserved 1048576K
>> 
>> memory is not released even after GC
>> 
>> JMC 8.2 + fix:
>> 
>> COMP11909:~/git/jmc-jpbempel$ jcmd 56259 GC.heap_info
>> 56259:
>>  garbage-first heap   total 1625088K, used 556392K [0x0000000700000000, 0x0000000800000000)
>>   region size 1024K, 1 young (1024K), 0 survivors (0K)
>>  Metaspace       used 61931K, capacity 66724K, committed 66992K, reserved 1107968K
>>   class space    used 6991K, capacity 8586K, committed 8704K, reserved 1048576K
>> COMP11909:~/git/jmc-jpbempel$ jcmd 56259 GC.run
>> 56259:
>> Command executed successfully
>> COMP11909:~/git/jmc-jpbempel$ jcmd 56259 GC.heap_info
>> 56259:
>>  garbage-first heap   total 109568K, used 28592K [0x0000000700000000, 0x0000000800000000)
>>   region size 1024K, 1 young (1024K), 0 survivors (0K)
>>  Metaspace       used 62269K, capacity 67053K, committed 67248K, reserved 1107968K
>>   class space    used 6994K, capacity 8588K, committed 8704K, reserved 1048576K
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   keep navigation to the right page
>   
>   as long as the page is still open

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/338

From jpbempel at openjdk.java.net  Thu Dec  2 18:49:19 2021
From: jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Thu, 2 Dec 2021 18:49:19 GMT
Subject: Integrated: 7463: JfrEditor instances are kept in memory by
 NavigationHistory
In-Reply-To: <I3otvvCcgDHzI1e35HUsmqk5H9gpWcL0uqmz0NOIvJI=.17b8d56b-22f2-4c84-b68b-17f5b2013d2f@github.com>
References: <I3otvvCcgDHzI1e35HUsmqk5H9gpWcL0uqmz0NOIvJI=.17b8d56b-22f2-4c84-b68b-17f5b2013d2f@github.com>
Message-ID: <V8nLdQkdKXAO1zOjx72ZtHItPBi8JH-YCcX8upYdmh4=.bf2886e6-e369-4633-ae86-9881a38cbf2a@github.com>

On Tue, 30 Nov 2021 10:48:47 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

> Provide a sub class of NavigationHistory instead of implementing a
> full INavigationHistory.
> JfrEditor is not kept anymore when releasing state/disposing.
> 
> Provide a sub class of NavigationHistory instead of implementing a
> full INavigationHistory.
> JfrEditor is not kept anymore when releasing state/disposing.
> 
> JMC 8.1, opening 13 recordings, then closing them:
> 
> COMP11909:~/git/jmc-jpbempel$ jcmd 55089 GC.heap_info
> 55089:
>  garbage-first heap   total 989184K, used 488772K [0x0000000700000000, 0x0000000800000000)
>   region size 1024K, 1 young (1024K), 0 survivors (0K)
>  Metaspace       used 60486K, capacity 65423K, committed 65584K, reserved 1105920K
>   class space    used 6822K, capacity 8453K, committed 8576K, reserved 1048576K
> COMP11909:~/git/jmc-jpbempel$ jcmd 55089 GC.run
> 55089:
> Command executed successfully
> COMP11909:~/git/jmc-jpbempel$ jcmd 55089 GC.heap_info
> 55089:
>  garbage-first heap   total 989184K, used 488410K [0x0000000700000000, 0x0000000800000000)
>   region size 1024K, 1 young (1024K), 0 survivors (0K)
>  Metaspace       used 61621K, capacity 66457K, committed 66736K, reserved 1107968K
>   class space    used 6938K, capacity 8583K, committed 8704K, reserved 1048576K
> 
> memory is not released even after GC
> 
> JMC 8.2 + fix:
> 
> COMP11909:~/git/jmc-jpbempel$ jcmd 56259 GC.heap_info
> 56259:
>  garbage-first heap   total 1625088K, used 556392K [0x0000000700000000, 0x0000000800000000)
>   region size 1024K, 1 young (1024K), 0 survivors (0K)
>  Metaspace       used 61931K, capacity 66724K, committed 66992K, reserved 1107968K
>   class space    used 6991K, capacity 8586K, committed 8704K, reserved 1048576K
> COMP11909:~/git/jmc-jpbempel$ jcmd 56259 GC.run
> 56259:
> Command executed successfully
> COMP11909:~/git/jmc-jpbempel$ jcmd 56259 GC.heap_info
> 56259:
>  garbage-first heap   total 109568K, used 28592K [0x0000000700000000, 0x0000000800000000)
>   region size 1024K, 1 young (1024K), 0 survivors (0K)
>  Metaspace       used 62269K, capacity 67053K, committed 67248K, reserved 1107968K
>   class space    used 6994K, capacity 8588K, committed 8704K, reserved 1048576K

This pull request has now been integrated.

Changeset: 8b8aa7c2
Author:    Jean-Philippe Bempel <jpbempel at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/8b8aa7c299b92b655ba669a92d16f193beb406bc
Stats:     42 lines in 1 file changed: 5 ins; 25 del; 12 mod

7463: JfrEditor instances are kept in memory by NavigationHistory

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/338

From hirt at openjdk.java.net  Fri Dec  3 15:26:17 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 3 Dec 2021 15:26:17 GMT
Subject: RFR: 7451: Add heat map view [v3]
In-Reply-To: <LFE83KLJ913gorp3RLYDyHLurB1xCDynvP08UoObEHw=.9455d95d-58d9-4acb-b25a-706b6b1c8002@github.com>
References: <aU949NSHXUvfLxLOb4ULNjmVg3RShI7gw1U4To4jvds=.6c9c7080-fa42-4297-a53f-286584ac521f@github.com>
 <LFE83KLJ913gorp3RLYDyHLurB1xCDynvP08UoObEHw=.9455d95d-58d9-4acb-b25a-706b6b1c8002@github.com>
Message-ID: <uvLYMyYphKqXTDkAeFWOLD1gyQ_5yTCSrJHLEvQVpB0=.46551ee5-ad7b-4a43-b058-8e5c71175f10@github.com>

On Tue, 30 Nov 2021 22:38:12 GMT, Alex Ciminian <duke at openjdk.java.net> wrote:

>> This PR adds a new plugin (`flightrecorder.heatmap`) which renders a visualisation similar to the one in [this Observable notebook](https://observablehq.com/@cimi/jfr-heatmap).
>> 
>> The code is simpler than both the flame view and the graph view, because of less rendering options and less dependencies - the heatmap only requires d3 and currently does not support any user configuration.
>> 
>> Each cell represents 100 milliseconds from the recording. We decided to automatically adjust the size of the cell so that the entire heatmap fits inside the window. This is different from the observable notebook which ensured each row represented 6s (i.e. it had a fixed number of 60 columns). The auto-sizing seems to work well with both small and large recordings, although we lose consistency when we resize the window and some periodic patterns are no longer visible when we vary the number of columns.
>> 
>> Feedback welcome, here's how this looks now:
>> 
>> 
>> ![Screenshot 2021-11-30 at 22 29 46](https://user-images.githubusercontent.com/348973/144139450-a6ec9cb9-4a38-4678-82ad-3f0d1c30ad29.png)
>> (short recording - 2 min)
>> 
>> 
>> ![Screenshot 2021-11-30 at 22 29 11](https://user-images.githubusercontent.com/348973/144139426-d3dc0d01-5d28-4f29-8199-0b020b5e4fb7.png)
>> 
>> (long recording - 15 min)
>
> Alex Ciminian has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 20 commits:
> 
>  - Add comment about setting 0 to white in heatmap
>  - Clean up logging and unused variables from heatmap.js
>  - Add right margin to prevent horizontal scroll
>  - Add 'no data' message to heatmap
>  - Add heatmap title with event count and start end time
>  - Remove right margin, fix axes misalignment
>  - Set minimum heatmap cell size to 4px
>  - Fix copyright notices
>  - Extract heatmap javascript to a separate file to avoid escaping %
>  - Remove debug logging from heatmap javascript
>  - ... and 10 more: https://git.openjdk.java.net/jmc/compare/ca204424...768ec2a0

This looks great! :)

-------------

PR: https://git.openjdk.java.net/jmc/pull/337

From hirt at openjdk.java.net  Fri Dec  3 15:49:12 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 3 Dec 2021 15:49:12 GMT
Subject: RFR: 7451: Add heat map view [v3]
In-Reply-To: <LFE83KLJ913gorp3RLYDyHLurB1xCDynvP08UoObEHw=.9455d95d-58d9-4acb-b25a-706b6b1c8002@github.com>
References: <aU949NSHXUvfLxLOb4ULNjmVg3RShI7gw1U4To4jvds=.6c9c7080-fa42-4297-a53f-286584ac521f@github.com>
 <LFE83KLJ913gorp3RLYDyHLurB1xCDynvP08UoObEHw=.9455d95d-58d9-4acb-b25a-706b6b1c8002@github.com>
Message-ID: <5iZL8aczgicTvILZPth3igHnJwreoicMjVx1MHJTOo4=.bd0d5aea-c0cf-4788-8b46-01892f8a5e7a@github.com>

On Tue, 30 Nov 2021 22:38:12 GMT, Alex Ciminian <duke at openjdk.java.net> wrote:

>> This PR adds a new plugin (`flightrecorder.heatmap`) which renders a visualisation similar to the one in [this Observable notebook](https://observablehq.com/@cimi/jfr-heatmap).
>> 
>> The code is simpler than both the flame view and the graph view, because of less rendering options and less dependencies - the heatmap only requires d3 and currently does not support any user configuration.
>> 
>> Each cell represents 100 milliseconds from the recording. We decided to automatically adjust the size of the cell so that the entire heatmap fits inside the window. This is different from the observable notebook which ensured each row represented 6s (i.e. it had a fixed number of 60 columns). The auto-sizing seems to work well with both small and large recordings, although we lose consistency when we resize the window and some periodic patterns are no longer visible when we vary the number of columns.
>> 
>> Feedback welcome, here's how this looks now:
>> 
>> 
>> ![Screenshot 2021-11-30 at 22 29 46](https://user-images.githubusercontent.com/348973/144139450-a6ec9cb9-4a38-4678-82ad-3f0d1c30ad29.png)
>> (short recording - 2 min)
>> 
>> 
>> ![Screenshot 2021-11-30 at 22 29 11](https://user-images.githubusercontent.com/348973/144139426-d3dc0d01-5d28-4f29-8199-0b020b5e4fb7.png)
>> 
>> (long recording - 15 min)
>
> Alex Ciminian has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 20 commits:
> 
>  - Add comment about setting 0 to white in heatmap
>  - Clean up logging and unused variables from heatmap.js
>  - Add right margin to prevent horizontal scroll
>  - Add 'no data' message to heatmap
>  - Add heatmap title with event count and start end time
>  - Remove right margin, fix axes misalignment
>  - Set minimum heatmap cell size to 4px
>  - Fix copyright notices
>  - Extract heatmap javascript to a separate file to avoid escaping %
>  - Remove debug logging from heatmap javascript
>  - ... and 10 more: https://git.openjdk.java.net/jmc/compare/ca204424...768ec2a0

Changes requested by hirt (Lead).

application/org.openjdk.jmc.flightrecorder.heatmap/src/main/resources/heatmap.js line 1:

> 1: class Logger {

Needs a copyright header, see flameview.js.

application/org.openjdk.jmc.flightrecorder.heatmap/src/main/resources/heatmap.js line 3:

> 1: class Logger {
> 2:   constructor() {
> 3:     this.domElement = document.createElement("pre");

Yes, we're evil, but we're using tabs in javascript too. ;)

-------------

PR: https://git.openjdk.java.net/jmc/pull/337

From aptmac at openjdk.java.net  Fri Dec  3 16:28:36 2021
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Fri, 3 Dec 2021 16:28:36 GMT
Subject: RFR: 7456: Remove the JDK 8 Eclipse launchers
Message-ID: <ovrWrh9WYtBjFJJ7nor36iI60Se4bMxLmdZLG2APhn8=.7377e4d5-07e1-49d0-bb87-384122ad1611@github.com>

This PR addresses JMC-7456 [[0]](https://bugs.openjdk.java.net/browse/JMC-7456), in which the JDK-8 Eclipse launchers should be removed due to their incompatibility with Eclipse (as of 2020-09).

[0] https://bugs.openjdk.java.net/browse/JMC-7456

-------------

Commit messages:
 - 7456: Remove the JDK 8 Eclipse launchers

Changes: https://git.openjdk.java.net/jmc/pull/339/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=339&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7456
  Stats: 435 lines in 4 files changed: 0 ins; 435 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/339.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/339/head:pull/339

PR: https://git.openjdk.java.net/jmc/pull/339

From hirt at openjdk.java.net  Fri Dec  3 16:34:17 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 3 Dec 2021 16:34:17 GMT
Subject: RFR: 7456: Remove the JDK 8 Eclipse launchers
In-Reply-To: <ovrWrh9WYtBjFJJ7nor36iI60Se4bMxLmdZLG2APhn8=.7377e4d5-07e1-49d0-bb87-384122ad1611@github.com>
References: <ovrWrh9WYtBjFJJ7nor36iI60Se4bMxLmdZLG2APhn8=.7377e4d5-07e1-49d0-bb87-384122ad1611@github.com>
Message-ID: <S5Hp9wIComCsdF7Ey85nVDds6qrvK-GNiZkrZ08UXuo=.56c8327c-794a-4992-b4cd-249a48c3e93a@github.com>

On Fri, 3 Dec 2021 16:22:02 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> This PR addresses JMC-7456 [[0]](https://bugs.openjdk.java.net/browse/JMC-7456), in which the JDK-8 Eclipse launchers should be removed due to their incompatibility with Eclipse (as of 2020-09).
> 
> [0] https://bugs.openjdk.java.net/browse/JMC-7456

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/339

From duke at openjdk.java.net  Fri Dec  3 17:34:49 2021
From: duke at openjdk.java.net (Alex Ciminian)
Date: Fri, 3 Dec 2021 17:34:49 GMT
Subject: RFR: 7451: Add heat map view [v4]
In-Reply-To: <aU949NSHXUvfLxLOb4ULNjmVg3RShI7gw1U4To4jvds=.6c9c7080-fa42-4297-a53f-286584ac521f@github.com>
References: <aU949NSHXUvfLxLOb4ULNjmVg3RShI7gw1U4To4jvds=.6c9c7080-fa42-4297-a53f-286584ac521f@github.com>
Message-ID: <6SapOPHUTA26KThvUpjWk1szqgJOQtt2skLiHpaarkA=.c4dc9ee8-4ee1-470b-b087-3dd74d973fa4@github.com>

> This PR adds a new plugin (`flightrecorder.heatmap`) which renders a visualisation similar to the one in [this Observable notebook](https://observablehq.com/@cimi/jfr-heatmap).
> 
> The code is simpler than both the flame view and the graph view, because of less rendering options and less dependencies - the heatmap only requires d3 and currently does not support any user configuration.
> 
> Each cell represents 100 milliseconds from the recording. We decided to automatically adjust the size of the cell so that the entire heatmap fits inside the window. This is different from the observable notebook which ensured each row represented 6s (i.e. it had a fixed number of 60 columns). The auto-sizing seems to work well with both small and large recordings, although we lose consistency when we resize the window and some periodic patterns are no longer visible when we vary the number of columns.
> 
> Feedback welcome, here's how this looks now:
> 
> 
> ![Screenshot 2021-11-30 at 22 29 46](https://user-images.githubusercontent.com/348973/144139450-a6ec9cb9-4a38-4678-82ad-3f0d1c30ad29.png)
> (short recording - 2 min)
> 
> 
> ![Screenshot 2021-11-30 at 22 29 11](https://user-images.githubusercontent.com/348973/144139426-d3dc0d01-5d28-4f29-8199-0b020b5e4fb7.png)
> 
> (long recording - 15 min)

Alex Ciminian has updated the pull request incrementally with two additional commits since the last revision:

 - Convert indentation to tabs in heatmap.js
 - Add copyright notice to heatmap.js

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/337/files
  - new: https://git.openjdk.java.net/jmc/pull/337/files/768ec2a0..7ad43eed

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=337&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=337&range=02-03

  Stats: 262 lines in 1 file changed: 33 ins; 0 del; 229 mod
  Patch: https://git.openjdk.java.net/jmc/pull/337.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/337/head:pull/337

PR: https://git.openjdk.java.net/jmc/pull/337

From aptmac at openjdk.java.net  Fri Dec  3 17:39:09 2021
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Fri, 3 Dec 2021 17:39:09 GMT
Subject: Integrated: 7456: Remove the JDK 8 Eclipse launchers
In-Reply-To: <ovrWrh9WYtBjFJJ7nor36iI60Se4bMxLmdZLG2APhn8=.7377e4d5-07e1-49d0-bb87-384122ad1611@github.com>
References: <ovrWrh9WYtBjFJJ7nor36iI60Se4bMxLmdZLG2APhn8=.7377e4d5-07e1-49d0-bb87-384122ad1611@github.com>
Message-ID: <ZNNZTy8Csn4FzPZ0l_i1dSAX8n0gZvjeCVKsV_lFHRI=.e95fe97b-8191-441b-a329-86f9747b2b9d@github.com>

On Fri, 3 Dec 2021 16:22:02 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> This PR addresses JMC-7456 [[0]](https://bugs.openjdk.java.net/browse/JMC-7456), in which the JDK-8 Eclipse launchers should be removed due to their incompatibility with Eclipse (as of 2020-09).
> 
> [0] https://bugs.openjdk.java.net/browse/JMC-7456

This pull request has now been integrated.

Changeset: 787bf0a9
Author:    Alex Macdonald <aptmac at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/787bf0a9d04c6a78ef5d28ff735611f5df1019ed
Stats:     435 lines in 4 files changed: 0 ins; 435 del; 0 mod

7456: Remove the JDK 8 Eclipse launchers

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/339

From aptmac at openjdk.java.net  Fri Dec  3 19:45:16 2021
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Fri, 3 Dec 2021 19:45:16 GMT
Subject: RFR: 7451: Add heat map view [v4]
In-Reply-To: <6SapOPHUTA26KThvUpjWk1szqgJOQtt2skLiHpaarkA=.c4dc9ee8-4ee1-470b-b087-3dd74d973fa4@github.com>
References: <aU949NSHXUvfLxLOb4ULNjmVg3RShI7gw1U4To4jvds=.6c9c7080-fa42-4297-a53f-286584ac521f@github.com>
 <6SapOPHUTA26KThvUpjWk1szqgJOQtt2skLiHpaarkA=.c4dc9ee8-4ee1-470b-b087-3dd74d973fa4@github.com>
Message-ID: <a4UN1gVrF5X3aWznWUnwnnnXhG8QimetGKbnLsSUMUU=.fbfdff16-d143-4a1e-878c-ac6952176914@github.com>

On Fri, 3 Dec 2021 17:34:49 GMT, Alex Ciminian <duke at openjdk.java.net> wrote:

>> This PR adds a new plugin (`flightrecorder.heatmap`) which renders a visualisation similar to the one in [this Observable notebook](https://observablehq.com/@cimi/jfr-heatmap).
>> 
>> The code is simpler than both the flame view and the graph view, because of less rendering options and less dependencies - the heatmap only requires d3 and currently does not support any user configuration.
>> 
>> Each cell represents 100 milliseconds from the recording. We decided to automatically adjust the size of the cell so that the entire heatmap fits inside the window. This is different from the observable notebook which ensured each row represented 6s (i.e. it had a fixed number of 60 columns). The auto-sizing seems to work well with both small and large recordings, although we lose consistency when we resize the window and some periodic patterns are no longer visible when we vary the number of columns.
>> 
>> Feedback welcome, here's how this looks now:
>> 
>> 
>> ![Screenshot 2021-11-30 at 22 29 46](https://user-images.githubusercontent.com/348973/144139450-a6ec9cb9-4a38-4678-82ad-3f0d1c30ad29.png)
>> (short recording - 2 min)
>> 
>> 
>> ![Screenshot 2021-11-30 at 22 29 11](https://user-images.githubusercontent.com/348973/144139426-d3dc0d01-5d28-4f29-8199-0b020b5e4fb7.png)
>> 
>> (long recording - 15 min)
>
> Alex Ciminian has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Convert indentation to tabs in heatmap.js
>  - Add copyright notice to heatmap.js

application/org.openjdk.jmc.flightrecorder.heatmap/src/main/resources/page.template line 11:

> 9: 
> 10:   <body>
> 11:     <div id="heatmap" width="100%%" style="text-align: center"></div>

Extra "%" here ?

-------------

PR: https://git.openjdk.java.net/jmc/pull/337

From duke at openjdk.java.net  Fri Dec  3 19:56:20 2021
From: duke at openjdk.java.net (Alex Ciminian)
Date: Fri, 3 Dec 2021 19:56:20 GMT
Subject: RFR: 7451: Add heat map view [v4]
In-Reply-To: <a4UN1gVrF5X3aWznWUnwnnnXhG8QimetGKbnLsSUMUU=.fbfdff16-d143-4a1e-878c-ac6952176914@github.com>
References: <aU949NSHXUvfLxLOb4ULNjmVg3RShI7gw1U4To4jvds=.6c9c7080-fa42-4297-a53f-286584ac521f@github.com>
 <6SapOPHUTA26KThvUpjWk1szqgJOQtt2skLiHpaarkA=.c4dc9ee8-4ee1-470b-b087-3dd74d973fa4@github.com>
 <a4UN1gVrF5X3aWznWUnwnnnXhG8QimetGKbnLsSUMUU=.fbfdff16-d143-4a1e-878c-ac6952176914@github.com>
Message-ID: <SZDU7qt1hie3Z3Ctu5sK53ZMHTaw-5GmT4TFfv2aJa4=.f1a18c80-2a2d-4171-b42a-12afcb546744@github.com>

On Fri, 3 Dec 2021 19:41:59 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Alex Ciminian has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Convert indentation to tabs in heatmap.js
>>  - Add copyright notice to heatmap.js
>
> application/org.openjdk.jmc.flightrecorder.heatmap/src/main/resources/page.template line 11:
> 
>> 9: 
>> 10:   <body>
>> 11:     <div id="heatmap" width="100%%" style="text-align: center"></div>
> 
> Extra "%" here ?

That?s intentional ?? We use `String.format` to build the HTML from this template file and we need to escape `%` so it doesn?t confuse it with the arguments.

This is one of the reasons I extracted the JS to a separate file, it was annoying to have to escape this everywhere (e.g. remainder operator, other percentages).

-------------

PR: https://git.openjdk.java.net/jmc/pull/337

From aptmac at openjdk.java.net  Fri Dec  3 19:56:20 2021
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Fri, 3 Dec 2021 19:56:20 GMT
Subject: RFR: 7451: Add heat map view [v4]
In-Reply-To: <SZDU7qt1hie3Z3Ctu5sK53ZMHTaw-5GmT4TFfv2aJa4=.f1a18c80-2a2d-4171-b42a-12afcb546744@github.com>
References: <aU949NSHXUvfLxLOb4ULNjmVg3RShI7gw1U4To4jvds=.6c9c7080-fa42-4297-a53f-286584ac521f@github.com>
 <6SapOPHUTA26KThvUpjWk1szqgJOQtt2skLiHpaarkA=.c4dc9ee8-4ee1-470b-b087-3dd74d973fa4@github.com>
 <a4UN1gVrF5X3aWznWUnwnnnXhG8QimetGKbnLsSUMUU=.fbfdff16-d143-4a1e-878c-ac6952176914@github.com>
 <SZDU7qt1hie3Z3Ctu5sK53ZMHTaw-5GmT4TFfv2aJa4=.f1a18c80-2a2d-4171-b42a-12afcb546744@github.com>
Message-ID: <hYQsNBiOH_FHdKpMybZ4v8gjXA2qf_0yT7ZEI0bbpL4=.11270e50-a60c-401e-a817-141e94cd6367@github.com>

On Fri, 3 Dec 2021 19:50:57 GMT, Alex Ciminian <duke at openjdk.java.net> wrote:

>> application/org.openjdk.jmc.flightrecorder.heatmap/src/main/resources/page.template line 11:
>> 
>>> 9: 
>>> 10:   <body>
>>> 11:     <div id="heatmap" width="100%%" style="text-align: center"></div>
>> 
>> Extra "%" here ?
>
> That?s intentional ?? We use `String.format` to build the HTML from this template file and we need to escape `%` so it doesn?t confuse it with the arguments.
> 
> This is one of the reasons I extracted the JS to a separate file, it was annoying to have to escape this everywhere (e.g. remainder operator, other percentages).

Ah, neat! Thanks for the explanation!

-------------

PR: https://git.openjdk.java.net/jmc/pull/337

From aptmac at openjdk.java.net  Fri Dec  3 20:00:41 2021
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Fri, 3 Dec 2021 20:00:41 GMT
Subject: RFR: 7468: Fix jdp test coverage
Message-ID: <F-CczLBBiYYZ_TkIHcz_DkdE_k0vTPVJIrO_NcYHfbQ=.0109e65f-f333-4fba-b884-2777381e7023@github.com>

This PR addresses JMC-7468 [[0]](https://bugs.openjdk.java.net/browse/JMC-7468), in which the jdp test coverage is not added to the core coverage report.

The one-liner fix here is to make sure the argLine used by Jacoco is not overwritten by the surefire-plugin in the jdp.test pom.

Before (0%):
![2021-12-03-141742_1091x251_scrot](https://user-images.githubusercontent.com/10425301/144663611-4424aae8-947c-4006-a26d-335ab325bfef.png)

After (60%):
![2021-12-03-144244_1092x258_scrot](https://user-images.githubusercontent.com/10425301/144663625-5fc72bc8-c243-4f86-b00a-6f9d6a8cc3e7.png)

[0] https://bugs.openjdk.java.net/browse/JMC-7468

-------------

Commit messages:
 - 7468: Fix jdp test coverage

Changes: https://git.openjdk.java.net/jmc/pull/340/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=340&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7468
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/340.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/340/head:pull/340

PR: https://git.openjdk.java.net/jmc/pull/340

From hirt at openjdk.java.net  Fri Dec  3 21:00:14 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 3 Dec 2021 21:00:14 GMT
Subject: RFR: 7468: Fix jdp test coverage
In-Reply-To: <F-CczLBBiYYZ_TkIHcz_DkdE_k0vTPVJIrO_NcYHfbQ=.0109e65f-f333-4fba-b884-2777381e7023@github.com>
References: <F-CczLBBiYYZ_TkIHcz_DkdE_k0vTPVJIrO_NcYHfbQ=.0109e65f-f333-4fba-b884-2777381e7023@github.com>
Message-ID: <zDcPyoQam32buO6OtD-yg08wQ0BnhZNXoq2jezBUoeM=.eebc7a85-4e85-41f2-8803-a25f08562478@github.com>

On Fri, 3 Dec 2021 19:52:34 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> This PR addresses JMC-7468 [[0]](https://bugs.openjdk.java.net/browse/JMC-7468), in which the jdp test coverage is not added to the core coverage report.
> 
> The one-liner fix here is to make sure the argLine used by Jacoco is not overwritten by the surefire-plugin in the jdp.test pom.
> 
> Before (0%):
> ![2021-12-03-141742_1091x251_scrot](https://user-images.githubusercontent.com/10425301/144663611-4424aae8-947c-4006-a26d-335ab325bfef.png)
> 
> After (60%):
> ![2021-12-03-144244_1092x258_scrot](https://user-images.githubusercontent.com/10425301/144663625-5fc72bc8-c243-4f86-b00a-6f9d6a8cc3e7.png)
> 
> [0] https://bugs.openjdk.java.net/browse/JMC-7468

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/340

From aptmac at openjdk.java.net  Fri Dec  3 21:00:14 2021
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Fri, 3 Dec 2021 21:00:14 GMT
Subject: RFR: 7468: Fix jdp test coverage
In-Reply-To: <F-CczLBBiYYZ_TkIHcz_DkdE_k0vTPVJIrO_NcYHfbQ=.0109e65f-f333-4fba-b884-2777381e7023@github.com>
References: <F-CczLBBiYYZ_TkIHcz_DkdE_k0vTPVJIrO_NcYHfbQ=.0109e65f-f333-4fba-b884-2777381e7023@github.com>
Message-ID: <_tnncdmtusUxZ5UDU18ANmD8WbB3ifTa4moobRk4QAo=.c7286514-b300-4fc8-8d77-570d261c764a@github.com>

On Fri, 3 Dec 2021 19:52:34 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> This PR addresses JMC-7468 [[0]](https://bugs.openjdk.java.net/browse/JMC-7468), in which the jdp test coverage is not added to the core coverage report.
> 
> The one-liner fix here is to make sure the argLine used by Jacoco is not overwritten by the surefire-plugin in the jdp.test pom.
> 
> Before (0%):
> ![2021-12-03-141742_1091x251_scrot](https://user-images.githubusercontent.com/10425301/144663611-4424aae8-947c-4006-a26d-335ab325bfef.png)
> 
> After (60%):
> ![2021-12-03-144244_1092x258_scrot](https://user-images.githubusercontent.com/10425301/144663625-5fc72bc8-c243-4f86-b00a-6f9d6a8cc3e7.png)
> 
> [0] https://bugs.openjdk.java.net/browse/JMC-7468

Hm, it looks like the Windows validate action isn't having a good time at the moment, I'll re-run the checks later to see if that's the problem.


 win
The hosted runner: Hosted Agent lost communication with the server. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error.

-------------

PR: https://git.openjdk.java.net/jmc/pull/340

From hirt at openjdk.java.net  Fri Dec  3 21:03:20 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 3 Dec 2021 21:03:20 GMT
Subject: RFR: 7451: Add heat map view [v4]
In-Reply-To: <6SapOPHUTA26KThvUpjWk1szqgJOQtt2skLiHpaarkA=.c4dc9ee8-4ee1-470b-b087-3dd74d973fa4@github.com>
References: <aU949NSHXUvfLxLOb4ULNjmVg3RShI7gw1U4To4jvds=.6c9c7080-fa42-4297-a53f-286584ac521f@github.com>
 <6SapOPHUTA26KThvUpjWk1szqgJOQtt2skLiHpaarkA=.c4dc9ee8-4ee1-470b-b087-3dd74d973fa4@github.com>
Message-ID: <U0Bt0zoMODzTcYd-jnCPu-LIJTgKdvqsZbh8F5hxxRA=.65861089-0c56-4025-9a86-b90f18e39e8f@github.com>

On Fri, 3 Dec 2021 17:34:49 GMT, Alex Ciminian <duke at openjdk.java.net> wrote:

>> This PR adds a new plugin (`flightrecorder.heatmap`) which renders a visualisation similar to the one in [this Observable notebook](https://observablehq.com/@cimi/jfr-heatmap).
>> 
>> The code is simpler than both the flame view and the graph view, because of less rendering options and less dependencies - the heatmap only requires d3 and currently does not support any user configuration.
>> 
>> Each cell represents 100 milliseconds from the recording. We decided to automatically adjust the size of the cell so that the entire heatmap fits inside the window. This is different from the observable notebook which ensured each row represented 6s (i.e. it had a fixed number of 60 columns). The auto-sizing seems to work well with both small and large recordings, although we lose consistency when we resize the window and some periodic patterns are no longer visible when we vary the number of columns.
>> 
>> Feedback welcome, here's how this looks now:
>> 
>> 
>> ![Screenshot 2021-11-30 at 22 29 46](https://user-images.githubusercontent.com/348973/144139450-a6ec9cb9-4a38-4678-82ad-3f0d1c30ad29.png)
>> (short recording - 2 min)
>> 
>> 
>> ![Screenshot 2021-11-30 at 22 29 11](https://user-images.githubusercontent.com/348973/144139426-d3dc0d01-5d28-4f29-8199-0b020b5e4fb7.png)
>> 
>> (long recording - 15 min)
>
> Alex Ciminian has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Convert indentation to tabs in heatmap.js
>  - Add copyright notice to heatmap.js

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/337

From schaturvedi at openjdk.java.net  Sat Dec  4 07:40:31 2021
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Sat, 4 Dec 2021 07:40:31 GMT
Subject: RFR: 7469: Upgrade third parties to latest versions
Message-ID: <prRTaiYwAgK37fHEh6ubs0IDYgkfdGsqtkbcIxxa660=.3a9c0d8c-327b-4591-81da-be834e545335@github.com>

Upgrading following third parties to their latest released versions

jakarta mail - 1.6.5 --> 2.0.1
JavaBeans Activation Framework (JAF) 1.2.2 --> 2.0.1
lz4-java 1.7.1 --> 1.8.0
Owasp encoder 1.2.2 --> 1.2.3

-------------

Commit messages:
 - 7469: Upgrade third parties to latest versions

Changes: https://git.openjdk.java.net/jmc/pull/341/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=341&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7469
  Stats: 34 lines in 8 files changed: 0 ins; 0 del; 34 mod
  Patch: https://git.openjdk.java.net/jmc/pull/341.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/341/head:pull/341

PR: https://git.openjdk.java.net/jmc/pull/341

From hirt at openjdk.java.net  Sun Dec  5 13:42:12 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sun, 5 Dec 2021 13:42:12 GMT
Subject: RFR: 7451: Add heat map view [v4]
In-Reply-To: <6SapOPHUTA26KThvUpjWk1szqgJOQtt2skLiHpaarkA=.c4dc9ee8-4ee1-470b-b087-3dd74d973fa4@github.com>
References: <aU949NSHXUvfLxLOb4ULNjmVg3RShI7gw1U4To4jvds=.6c9c7080-fa42-4297-a53f-286584ac521f@github.com>
 <6SapOPHUTA26KThvUpjWk1szqgJOQtt2skLiHpaarkA=.c4dc9ee8-4ee1-470b-b087-3dd74d973fa4@github.com>
Message-ID: <uIp--iz_NOBHtvrrsZHhkQnNl1ApsLn-Ew43vY8p6lc=.684bdb37-a981-4bb0-8a5a-773c7454d272@github.com>

On Fri, 3 Dec 2021 17:34:49 GMT, Alex Ciminian <duke at openjdk.java.net> wrote:

>> This PR adds a new plugin (`flightrecorder.heatmap`) which renders a visualisation similar to the one in [this Observable notebook](https://observablehq.com/@cimi/jfr-heatmap).
>> 
>> The code is simpler than both the flame view and the graph view, because of less rendering options and less dependencies - the heatmap only requires d3 and currently does not support any user configuration.
>> 
>> Each cell represents 100 milliseconds from the recording. We decided to automatically adjust the size of the cell so that the entire heatmap fits inside the window. This is different from the observable notebook which ensured each row represented 6s (i.e. it had a fixed number of 60 columns). The auto-sizing seems to work well with both small and large recordings, although we lose consistency when we resize the window and some periodic patterns are no longer visible when we vary the number of columns.
>> 
>> Feedback welcome, here's how this looks now:
>> 
>> 
>> ![Screenshot 2021-11-30 at 22 29 46](https://user-images.githubusercontent.com/348973/144139450-a6ec9cb9-4a38-4678-82ad-3f0d1c30ad29.png)
>> (short recording - 2 min)
>> 
>> 
>> ![Screenshot 2021-11-30 at 22 29 11](https://user-images.githubusercontent.com/348973/144139426-d3dc0d01-5d28-4f29-8199-0b020b5e4fb7.png)
>> 
>> (long recording - 15 min)
>
> Alex Ciminian has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Convert indentation to tabs in heatmap.js
>  - Add copyright notice to heatmap.js

@cimi - this one is ready for /integrate.

-------------

PR: https://git.openjdk.java.net/jmc/pull/337

From hirt at openjdk.java.net  Sun Dec  5 13:43:19 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sun, 5 Dec 2021 13:43:19 GMT
Subject: RFR: 7468: Fix jdp test coverage
In-Reply-To: <F-CczLBBiYYZ_TkIHcz_DkdE_k0vTPVJIrO_NcYHfbQ=.0109e65f-f333-4fba-b884-2777381e7023@github.com>
References: <F-CczLBBiYYZ_TkIHcz_DkdE_k0vTPVJIrO_NcYHfbQ=.0109e65f-f333-4fba-b884-2777381e7023@github.com>
Message-ID: <pi6IX5WMsNozYnD3G-fpnUbO9RuduZMOJCyDreYmY1M=.2c9ead6b-3b57-4040-889e-77d1ca8e0634@github.com>

On Fri, 3 Dec 2021 19:52:34 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> This PR addresses JMC-7468 [[0]](https://bugs.openjdk.java.net/browse/JMC-7468), in which the jdp test coverage is not added to the core coverage report.
> 
> The one-liner fix here is to make sure the argLine used by Jacoco is not overwritten by the surefire-plugin in the jdp.test pom.
> 
> Before (0%):
> ![2021-12-03-141742_1091x251_scrot](https://user-images.githubusercontent.com/10425301/144663611-4424aae8-947c-4006-a26d-335ab325bfef.png)
> 
> After (60%):
> ![2021-12-03-144244_1092x258_scrot](https://user-images.githubusercontent.com/10425301/144663625-5fc72bc8-c243-4f86-b00a-6f9d6a8cc3e7.png)
> 
> [0] https://bugs.openjdk.java.net/browse/JMC-7468

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/340

From duke at openjdk.java.net  Sun Dec  5 19:39:38 2021
From: duke at openjdk.java.net (Alex Ciminian)
Date: Sun, 5 Dec 2021 19:39:38 GMT
Subject: RFR: 7449: Add GitHub action to verify copyright year
Message-ID: <va8OiL7O92WOuIQR0pHi0TDa5LXRka7XS_672iUQUhA=.b9168167-c1c4-4597-9a76-d086b4376e4e@github.com>

This PR adds a script to check copyright notices on changed files. I've not added a GitHub action yet, I'd like to get some feedback before doing that ?? 

The script is written in Kotlin and uses [JGit](https://www.eclipse.org/jgit/) to interface with the git repository. To run, it only needs the kotlin compiler which is [preinstalled on GitHub Actions runners](https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md).

It works as follows:

* diff the HEAD commit and the merge base between it and master (i.e. where the feature branch diverged from)
* for every changed file (except deletions), validate the copyright header
  - if the file is new, it should have Oracle and Datadog copyright starting from the year of the HEAD commit
  - if the file is not new, it should keep the existing copyright holders and update the year range if necessary
* we compare file contents from objects in the git repo, not the files themselves
* currently we don't validate we're in the correct directory or the commits

The output looks like this:


kotlinc -script scripts/copyrightchecker.main.kts                                                                                                                                                     
Checked out at: 759788185939b16f447e553b3ee64121187ea311 (base: 8b8aa7c299b92b655ba669a92d16f193beb406bc)
?? scripts/copyrightchecker.main.kts
? Validation succeeded



kotlinc -script scripts/copyrightchecker.main.kts                                                                                                                                                       
Checked out at: 7ad43eed12c9eb85a96882c9518a9acbe12e74c5 (base: ca204424ce32336f2923aff66f619d571b1fc720)
?? .gitignore
?? application/org.openjdk.jmc.feature.flightrecorder/feature.xml
?? Failed to parse:    Copyright (c) 2018, 2021 Oracle and/or its affiliates. All rights reserved.
?? application/org.openjdk.jmc.flightrecorder.heatmap/.classpath
?? application/org.openjdk.jmc.flightrecorder.heatmap/.gitignore
?? application/org.openjdk.jmc.flightrecorder.heatmap/META-INF/MANIFEST.MF
?? application/org.openjdk.jmc.flightrecorder.heatmap/build.properties
?? application/org.openjdk.jmc.flightrecorder.heatmap/icons/heatmap.png
?? application/org.openjdk.jmc.flightrecorder.heatmap/icons/heatmap at 2x.png
?? application/org.openjdk.jmc.flightrecorder.heatmap/plugin.properties
?? application/org.openjdk.jmc.flightrecorder.heatmap/plugin.xml
?? application/org.openjdk.jmc.flightrecorder.heatmap/pom.xml
Expected:
<?xml version="1.0" encoding="UTF-8"?>
<!--
	Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
	Copyright (c) 2021, Datadog, Inc. All rights reserved.

	DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
Actual:
<?xml version="1.0" encoding="UTF-8"?>
<!--
   Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
   Copyright (c) 2021, Datadog, Inc. All rights reserved.

   DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HE
(check whitespace if strings seem to match)
?? application/org.openjdk.jmc.flightrecorder.heatmap/src/main/java/org/openjdk/jmc/flightrecorder/heatmap/views/HeatmapView.java
?? application/org.openjdk.jmc.flightrecorder.heatmap/src/main/resources/heatmap.js
?? application/org.openjdk.jmc.flightrecorder.heatmap/src/main/resources/page.template
?? application/pom.xml
Expected:
<?xml version="1.0" encoding="UTF-8"?>
<!--
	Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.

	DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
Actual:
<?xml version="1.0" encoding="UTF-8"?>
<!--
   Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.

   DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEAD
(check whitespace if strings seem to match)

? Validation failed

-------------

Commit messages:
 - Add script to check copyright header on changed files

Changes: https://git.openjdk.java.net/jmc/pull/342/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=342&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7449
  Stats: 285 lines in 1 file changed: 285 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/342.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/342/head:pull/342

PR: https://git.openjdk.java.net/jmc/pull/342

From jpbempel at openjdk.java.net  Sun Dec  5 22:21:11 2021
From: jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Sun, 5 Dec 2021 22:21:11 GMT
Subject: RFR: 7449: Add GitHub action to verify copyright year
In-Reply-To: <va8OiL7O92WOuIQR0pHi0TDa5LXRka7XS_672iUQUhA=.b9168167-c1c4-4597-9a76-d086b4376e4e@github.com>
References: <va8OiL7O92WOuIQR0pHi0TDa5LXRka7XS_672iUQUhA=.b9168167-c1c4-4597-9a76-d086b4376e4e@github.com>
Message-ID: <Ua2x6tncuDIBYF2wn2leK2aunNPwxdQpJILdPUWih6Q=.49d6630f-16c6-4bd0-8451-daa608aea07f@github.com>

On Sun, 5 Dec 2021 19:33:50 GMT, Alex Ciminian <duke at openjdk.java.net> wrote:

>   * if the file is new, it should have Oracle and Datadog copyright starting from the year of the HEAD commit

It's not only Datadog for new file can be just Oracle, but also Red Hat, Azul, ... :)

-------------

PR: https://git.openjdk.java.net/jmc/pull/342

From hirt at openjdk.java.net  Mon Dec  6 10:29:22 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 6 Dec 2021 10:29:22 GMT
Subject: RFR: 7469: Upgrade third parties to latest versions
In-Reply-To: <prRTaiYwAgK37fHEh6ubs0IDYgkfdGsqtkbcIxxa660=.3a9c0d8c-327b-4591-81da-be834e545335@github.com>
References: <prRTaiYwAgK37fHEh6ubs0IDYgkfdGsqtkbcIxxa660=.3a9c0d8c-327b-4591-81da-be834e545335@github.com>
Message-ID: <V1OK9NiC_31EB5swPLm8C0avIwxinUK6y2Q1uR6hiM4=.b1920b6c-c932-4a10-bbaf-8609a8d18a0c@github.com>

On Sat, 4 Dec 2021 07:34:22 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> Upgrading following third parties to their latest released versions
> 
> jakarta mail - 1.6.5 --> 2.0.1
> JavaBeans Activation Framework (JAF) 1.2.2 --> 2.0.1
> lz4-java 1.7.1 --> 1.8.0
> Owasp encoder 1.2.2 --> 1.2.3

THIRDPARTYREADME.txt also needs updating.

-------------

PR: https://git.openjdk.java.net/jmc/pull/341

From duke at openjdk.java.net  Mon Dec  6 10:31:15 2021
From: duke at openjdk.java.net (Alex Ciminian)
Date: Mon, 6 Dec 2021 10:31:15 GMT
Subject: Integrated: 7451: Add heat map view
In-Reply-To: <aU949NSHXUvfLxLOb4ULNjmVg3RShI7gw1U4To4jvds=.6c9c7080-fa42-4297-a53f-286584ac521f@github.com>
References: <aU949NSHXUvfLxLOb4ULNjmVg3RShI7gw1U4To4jvds=.6c9c7080-fa42-4297-a53f-286584ac521f@github.com>
Message-ID: <v4pnMlG6teKn3SqNah0Xb3D7-Ct8oNz5Xu8DQrHHjeY=.62e17395-8957-4737-ae0f-746adf27c1da@github.com>

On Wed, 24 Nov 2021 17:46:13 GMT, Alex Ciminian <duke at openjdk.java.net> wrote:

> This PR adds a new plugin (`flightrecorder.heatmap`) which renders a visualisation similar to the one in [this Observable notebook](https://observablehq.com/@cimi/jfr-heatmap).
> 
> The code is simpler than both the flame view and the graph view, because of less rendering options and less dependencies - the heatmap only requires d3 and currently does not support any user configuration.
> 
> Each cell represents 100 milliseconds from the recording. We decided to automatically adjust the size of the cell so that the entire heatmap fits inside the window. This is different from the observable notebook which ensured each row represented 6s (i.e. it had a fixed number of 60 columns). The auto-sizing seems to work well with both small and large recordings, although we lose consistency when we resize the window and some periodic patterns are no longer visible when we vary the number of columns.
> 
> Feedback welcome, here's how this looks now:
> 
> 
> ![Screenshot 2021-11-30 at 22 29 46](https://user-images.githubusercontent.com/348973/144139450-a6ec9cb9-4a38-4678-82ad-3f0d1c30ad29.png)
> (short recording - 2 min)
> 
> 
> ![Screenshot 2021-11-30 at 22 29 11](https://user-images.githubusercontent.com/348973/144139426-d3dc0d01-5d28-4f29-8199-0b020b5e4fb7.png)
> 
> (long recording - 15 min)

This pull request has now been integrated.

Changeset: ba365fb2
Author:    Alex Ciminian <alexandru.ciminian at datadoghq.com>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/ba365fb282bbb4a90ef21a0962a5f204f011b3e3
Stats:     684 lines in 15 files changed: 671 ins; 0 del; 13 mod

7451: Add heat map view

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/337

From schaturvedi at openjdk.java.net  Mon Dec  6 13:05:52 2021
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Mon, 6 Dec 2021 13:05:52 GMT
Subject: RFR: 7469: Upgrade third parties to latest versions [v2]
In-Reply-To: <prRTaiYwAgK37fHEh6ubs0IDYgkfdGsqtkbcIxxa660=.3a9c0d8c-327b-4591-81da-be834e545335@github.com>
References: <prRTaiYwAgK37fHEh6ubs0IDYgkfdGsqtkbcIxxa660=.3a9c0d8c-327b-4591-81da-be834e545335@github.com>
Message-ID: <G8I6XISBAvlspgNZ6UjJGjsuvdkRHmlAAAjKJo1aumo=.e2660b1f-d798-4de8-b420-545b2b39447c@github.com>

> Upgrading following third parties to their latest released versions
> 
> jakarta mail - 1.6.5 --> 2.0.1
> JavaBeans Activation Framework (JAF) 1.2.2 --> 2.0.1
> lz4-java 1.7.1 --> 1.8.0
> Owasp encoder 1.2.2 --> 1.2.3

Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:

  Updated thirdpartyreadme file

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/341/files
  - new: https://git.openjdk.java.net/jmc/pull/341/files/c937f3b1..71d8eaed

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=341&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=341&range=00-01

  Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod
  Patch: https://git.openjdk.java.net/jmc/pull/341.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/341/head:pull/341

PR: https://git.openjdk.java.net/jmc/pull/341

From hirt at openjdk.java.net  Mon Dec  6 13:47:24 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 6 Dec 2021 13:47:24 GMT
Subject: RFR: 7469: Upgrade third parties to latest versions [v2]
In-Reply-To: <G8I6XISBAvlspgNZ6UjJGjsuvdkRHmlAAAjKJo1aumo=.e2660b1f-d798-4de8-b420-545b2b39447c@github.com>
References: <prRTaiYwAgK37fHEh6ubs0IDYgkfdGsqtkbcIxxa660=.3a9c0d8c-327b-4591-81da-be834e545335@github.com>
 <G8I6XISBAvlspgNZ6UjJGjsuvdkRHmlAAAjKJo1aumo=.e2660b1f-d798-4de8-b420-545b2b39447c@github.com>
Message-ID: <EGywvxvGpmjRzVU2qu-BmVvOaMEPclR4-6n_RzvrY5s=.b1d86d2d-dec9-4986-93b7-08d0c4ac7467@github.com>

On Mon, 6 Dec 2021 13:05:52 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> Upgrading following third parties to their latest released versions
>> 
>> jakarta mail - 1.6.5 --> 2.0.1
>> JavaBeans Activation Framework (JAF) 1.2.2 --> 2.0.1
>> lz4-java 1.7.1 --> 1.8.0
>> Owasp encoder 1.2.2 --> 1.2.3
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated thirdpartyreadme file

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/341

From aptmac at openjdk.java.net  Mon Dec  6 14:31:17 2021
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Mon, 6 Dec 2021 14:31:17 GMT
Subject: Integrated: 7468: Fix jdp test coverage
In-Reply-To: <F-CczLBBiYYZ_TkIHcz_DkdE_k0vTPVJIrO_NcYHfbQ=.0109e65f-f333-4fba-b884-2777381e7023@github.com>
References: <F-CczLBBiYYZ_TkIHcz_DkdE_k0vTPVJIrO_NcYHfbQ=.0109e65f-f333-4fba-b884-2777381e7023@github.com>
Message-ID: <S3vzO1RNPgCseYs7ID7Y5WmQHz5hQkbY697CwTHMi9o=.f5d29eef-0b1b-4ba1-a934-5e544853e88c@github.com>

On Fri, 3 Dec 2021 19:52:34 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> This PR addresses JMC-7468 [[0]](https://bugs.openjdk.java.net/browse/JMC-7468), in which the jdp test coverage is not added to the core coverage report.
> 
> The one-liner fix here is to make sure the argLine used by Jacoco is not overwritten by the surefire-plugin in the jdp.test pom.
> 
> Before (0%):
> ![2021-12-03-141742_1091x251_scrot](https://user-images.githubusercontent.com/10425301/144663611-4424aae8-947c-4006-a26d-335ab325bfef.png)
> 
> After (60%):
> ![2021-12-03-144244_1092x258_scrot](https://user-images.githubusercontent.com/10425301/144663625-5fc72bc8-c243-4f86-b00a-6f9d6a8cc3e7.png)
> 
> [0] https://bugs.openjdk.java.net/browse/JMC-7468

This pull request has now been integrated.

Changeset: 9148435e
Author:    Alex Macdonald <aptmac at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/9148435e23f746dd82422acd9d24c32874573dc9
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

7468: Fix jdp test coverage

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/340

From schaturvedi at openjdk.java.net  Mon Dec  6 17:03:18 2021
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Mon, 6 Dec 2021 17:03:18 GMT
Subject: Integrated: 7469: Upgrade third parties to latest versions
In-Reply-To: <prRTaiYwAgK37fHEh6ubs0IDYgkfdGsqtkbcIxxa660=.3a9c0d8c-327b-4591-81da-be834e545335@github.com>
References: <prRTaiYwAgK37fHEh6ubs0IDYgkfdGsqtkbcIxxa660=.3a9c0d8c-327b-4591-81da-be834e545335@github.com>
Message-ID: <qRA8m3ERW4pnXLjF6Y3welom-PlVDL1Jgsva67nnvzc=.139b6860-64bf-4461-a102-8e4b93f04d7f@github.com>

On Sat, 4 Dec 2021 07:34:22 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> Upgrading following third parties to their latest released versions
> 
> jakarta mail - 1.6.5 --> 2.0.1
> JavaBeans Activation Framework (JAF) 1.2.2 --> 2.0.1
> lz4-java 1.7.1 --> 1.8.0
> Owasp encoder 1.2.2 --> 1.2.3

This pull request has now been integrated.

Changeset: a8b3614e
Author:    Suchita Chaturvedi <schaturvedi at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/a8b3614ebb29366e5835ea3b02709be3ab9a32a1
Stats:     39 lines in 9 files changed: 0 ins; 0 del; 39 mod

7469: Upgrade third parties to latest versions

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/341

From reinhapa at openjdk.java.net  Tue Dec  7 12:05:38 2021
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Tue, 7 Dec 2021 12:05:38 GMT
Subject: RFR: 7432: Update the spotbugs maven plugin [v5]
In-Reply-To: <NogwuacUT7-ztkHijbnhluiiz_FDlrP36v9t3ggK0g0=.d3f15cbf-44ea-4f94-b470-8e0c15deba5d@github.com>
References: <NogwuacUT7-ztkHijbnhluiiz_FDlrP36v9t3ggK0g0=.d3f15cbf-44ea-4f94-b470-8e0c15deba5d@github.com>
Message-ID: <ZWjn2qmzuppyQkFNJFDIp6n3d-b507yeA4olOiTUl58=.c76b8500-69c4-4eb8-a9b8-132b3916706f@github.com>

> Signed-off-by: Patrick Reinhart <patrick at reini.net>

Patrick Reinhart has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  7432: Update the spotbugs maven plugin
  
  Signed-off-by: Patrick Reinhart <patrick at reini.net>

-------------

Changes: https://git.openjdk.java.net/jmc/pull/324/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=324&range=04
  Stats: 94 lines in 3 files changed: 91 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jmc/pull/324.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/324/head:pull/324

PR: https://git.openjdk.java.net/jmc/pull/324

From reinhapa at openjdk.java.net  Fri Dec 10 19:06:18 2021
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Fri, 10 Dec 2021 19:06:18 GMT
Subject: RFR: 7432: Update the spotbugs maven plugin [v5]
In-Reply-To: <PvdpMiSPbx3lwlzKRZv7HmIyWW405_IhnTd0naUrK_M=.4416c7fb-a985-4695-b02f-db3f7e109e23@github.com>
References: <NogwuacUT7-ztkHijbnhluiiz_FDlrP36v9t3ggK0g0=.d3f15cbf-44ea-4f94-b470-8e0c15deba5d@github.com>
 <ZWjn2qmzuppyQkFNJFDIp6n3d-b507yeA4olOiTUl58=.c76b8500-69c4-4eb8-a9b8-132b3916706f@github.com>
 <PvdpMiSPbx3lwlzKRZv7HmIyWW405_IhnTd0naUrK_M=.4416c7fb-a985-4695-b02f-db3f7e109e23@github.com>
Message-ID: <3FK1mTL0qOQjt0gHfMbThRQWOeF3mqs3HkWTd2M7W9w=.ee4a808b-b03a-4bf2-9e37-4be0fb62c978@github.com>

On Tue, 7 Dec 2021 15:43:50 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Patrick Reinhart has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>> 
>>   7432: Update the spotbugs maven plugin
>>   
>>   Signed-off-by: Patrick Reinhart <patrick at reini.net>
>
> Error:
> 
> Error:  High: Random object created and used only once in org.openjdk.jmc.console.twitter.TwitterOAuthHeaderGenerator.getNonce() [org.openjdk.jmc.console.twitter.TwitterOAuthHeaderGenerator] At TwitterOAuthHeaderGenerator.java:[line 188] DMI_RANDOM_USED_ONLY_ONCE
> 
> Bug description: https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html#dmi-random-object-created-and-used-only-once-dmi-random-used-only-once
> 
> TwitterOAuthHeaderGenerator @ line 188: https://github.com/openjdk/jmc/blob/master/application/org.openjdk.jmc.console.twitter/src/main/java/org/openjdk/jmc/console/twitter/TwitterOAuthHeaderGenerator.java#L188
> 
> It looks to be complaining that we're creating a new Random object at line 186 everytime `getNonce()` is used.

@aptmac I already got a working version here locally but I'm not yet happy with it... Seems that storing the Random in an instance variable does not help. The only way things pass at the moment is using a `ThreadLocalRandom.current()` instance...

-------------

PR: https://git.openjdk.java.net/jmc/pull/324

From reinhapa at openjdk.java.net  Fri Dec 10 19:50:53 2021
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Fri, 10 Dec 2021 19:50:53 GMT
Subject: RFR: 7432: Update the spotbugs maven plugin [v6]
In-Reply-To: <NogwuacUT7-ztkHijbnhluiiz_FDlrP36v9t3ggK0g0=.d3f15cbf-44ea-4f94-b470-8e0c15deba5d@github.com>
References: <NogwuacUT7-ztkHijbnhluiiz_FDlrP36v9t3ggK0g0=.d3f15cbf-44ea-4f94-b470-8e0c15deba5d@github.com>
Message-ID: <TfNiJKluWElAdv7GVW8vEOrmzzhF7XDaKlqGzuBa6jk=.c514fb4c-5455-4c0a-9216-c8aae2b62407@github.com>

> Signed-off-by: Patrick Reinhart <patrick at reini.net>

Patrick Reinhart has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  7432: Update the spotbugs maven plugin
  
  Signed-off-by: Patrick Reinhart <patrick at reini.net>

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/324/files
  - new: https://git.openjdk.java.net/jmc/pull/324/files/d21e62cb..21a20fb1

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=324&range=05
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=324&range=04-05

  Stats: 7 lines in 1 file changed: 3 ins; 1 del; 3 mod
  Patch: https://git.openjdk.java.net/jmc/pull/324.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/324/head:pull/324

PR: https://git.openjdk.java.net/jmc/pull/324

From reinhapa at openjdk.java.net  Fri Dec 10 20:08:37 2021
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Fri, 10 Dec 2021 20:08:37 GMT
Subject: RFR: 7432: Update the spotbugs maven plugin [v7]
In-Reply-To: <NogwuacUT7-ztkHijbnhluiiz_FDlrP36v9t3ggK0g0=.d3f15cbf-44ea-4f94-b470-8e0c15deba5d@github.com>
References: <NogwuacUT7-ztkHijbnhluiiz_FDlrP36v9t3ggK0g0=.d3f15cbf-44ea-4f94-b470-8e0c15deba5d@github.com>
Message-ID: <wCgSC19Dkq-RcVa01onHijEEYQi8YuVFe2uJ19XHWNk=.4df64e2e-f076-450d-b771-e3d9713d84c0@github.com>

> Signed-off-by: Patrick Reinhart <patrick at reini.net>

Patrick Reinhart has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  7432: Update the spotbugs maven plugin
  
  Signed-off-by: Patrick Reinhart <patrick at reini.net>

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/324/files
  - new: https://git.openjdk.java.net/jmc/pull/324/files/21a20fb1..3b2b45d9

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=324&range=06
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=324&range=05-06

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/324.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/324/head:pull/324

PR: https://git.openjdk.java.net/jmc/pull/324

From aptmac at openjdk.java.net  Tue Dec  7 15:47:16 2021
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Tue, 7 Dec 2021 15:47:16 GMT
Subject: RFR: 7432: Update the spotbugs maven plugin [v5]
In-Reply-To: <ZWjn2qmzuppyQkFNJFDIp6n3d-b507yeA4olOiTUl58=.c76b8500-69c4-4eb8-a9b8-132b3916706f@github.com>
References: <NogwuacUT7-ztkHijbnhluiiz_FDlrP36v9t3ggK0g0=.d3f15cbf-44ea-4f94-b470-8e0c15deba5d@github.com>
 <ZWjn2qmzuppyQkFNJFDIp6n3d-b507yeA4olOiTUl58=.c76b8500-69c4-4eb8-a9b8-132b3916706f@github.com>
Message-ID: <PvdpMiSPbx3lwlzKRZv7HmIyWW405_IhnTd0naUrK_M=.4416c7fb-a985-4695-b02f-db3f7e109e23@github.com>

On Tue, 7 Dec 2021 12:05:38 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

>> Signed-off-by: Patrick Reinhart <patrick at reini.net>
>
> Patrick Reinhart has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>
>   7432: Update the spotbugs maven plugin
>
>   Signed-off-by: Patrick Reinhart <patrick at reini.net>

Error:

Error:  High: Random object created and used only once in org.openjdk.jmc.console.twitter.TwitterOAuthHeaderGenerator.getNonce() [org.openjdk.jmc.console.twitter.TwitterOAuthHeaderGenerator] At TwitterOAuthHeaderGenerator.java:[line 188] DMI_RANDOM_USED_ONLY_ONCE

Bug description: https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html#dmi-random-object-created-and-used-only-once-dmi-random-used-only-once

TwitterOAuthHeaderGenerator @ line 188: https://github.com/openjdk/jmc/blob/master/application/org.openjdk.jmc.console.twitter/src/main/java/org/openjdk/jmc/console/twitter/TwitterOAuthHeaderGenerator.java#L188

It looks to be complaining that we're creating a new Random object at line 186 everytime `getNonce()` is used.

-------------

PR: https://git.openjdk.java.net/jmc/pull/324


From duke at openjdk.java.net  Wed Dec  8 16:11:59 2021
From: duke at openjdk.java.net (Alex Ciminian)
Date: Wed, 8 Dec 2021 16:11:59 GMT
Subject: RFR: 7449: Add GitHub action to verify copyright year [v2]
In-Reply-To: <va8OiL7O92WOuIQR0pHi0TDa5LXRka7XS_672iUQUhA=.b9168167-c1c4-4597-9a76-d086b4376e4e@github.com>
References: <va8OiL7O92WOuIQR0pHi0TDa5LXRka7XS_672iUQUhA=.b9168167-c1c4-4597-9a76-d086b4376e4e@github.com>
Message-ID: <QOZShg4jFlF2x-CVMPnEumcm5DlnTmQStc4DyD8EMqg=.4c1f2962-4a48-4142-a106-5fa23f6ec41d@github.com>

> This PR adds a script to check copyright notices on changed files. I've not added a GitHub action yet, I'd like to get some feedback before doing that ??
>
> The script is written in Kotlin and uses [JGit](https://www.eclipse.org/jgit/) to interface with the git repository. To run, it only needs the kotlin compiler which is [preinstalled on GitHub Actions runners](https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md).
>
> It works as follows:
>
> * diff the HEAD commit and the merge base between it and master (i.e. where the feature branch diverged from)
> * for every changed file (except deletions), validate the copyright header
>   - if the file is new, it should have Oracle and Datadog copyright starting from the year of the HEAD commit
>   - if the file is not new, it should keep the existing copyright holders and update the year range if necessary
> * we compare file contents from objects in the git repo, not the files themselves
> * currently we don't validate we're in the correct directory or the commits
>
> The output looks like this:
>
>
> kotlinc -script scripts/copyrightchecker.main.kts
> Checked out at: 759788185939b16f447e553b3ee64121187ea311 (base: 8b8aa7c299b92b655ba669a92d16f193beb406bc)
> ?? scripts/copyrightchecker.main.kts
> ? Validation succeeded
>
>
>
> kotlinc -script scripts/copyrightchecker.main.kts
> Checked out at: 7ad43eed12c9eb85a96882c9518a9acbe12e74c5 (base: ca204424ce32336f2923aff66f619d571b1fc720)
> ?? .gitignore
> ?? application/org.openjdk.jmc.feature.flightrecorder/feature.xml
> ?? Failed to parse:    Copyright (c) 2018, 2021 Oracle and/or its affiliates. All rights reserved.
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/.classpath
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/.gitignore
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/META-INF/MANIFEST.MF
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/build.properties
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/icons/heatmap.png
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/icons/heatmap at 2x.png
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/plugin.properties
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/plugin.xml
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/pom.xml
> Expected:
> <?xml version="1.0" encoding="UTF-8"?>
> <!--
> 	Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
> 	Copyright (c) 2021, Datadog, Inc. All rights reserved.
>
> 	DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
> Actual:
> <?xml version="1.0" encoding="UTF-8"?>
> <!--
>    Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
>    Copyright (c) 2021, Datadog, Inc. All rights reserved.
>
>    DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HE
> (check whitespace if strings seem to match)
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/src/main/java/org/openjdk/jmc/flightrecorder/heatmap/views/HeatmapView.java
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/src/main/resources/heatmap.js
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/src/main/resources/page.template
> ?? application/pom.xml
> Expected:
> <?xml version="1.0" encoding="UTF-8"?>
> <!--
> 	Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
>
> 	DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
> Actual:
> <?xml version="1.0" encoding="UTF-8"?>
> <!--
>    Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
>
>    DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEAD
> (check whitespace if strings seem to match)
>
> ? Validation failed

Alex Ciminian has updated the pull request incrementally with three additional commits since the last revision:

- Use regex to parse copyright strings
- Add tree walk to check all files in repo
- Check new files have correct year and Oracle copyright

-------------

Changes:
- all: https://git.openjdk.java.net/jmc/pull/342/files
- new: https://git.openjdk.java.net/jmc/pull/342/files/75978818..82eb4012

Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jmc&pr=342&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=342&range=00-01

Stats: 131 lines in 1 file changed: 63 ins; 12 del; 56 mod
Patch: https://git.openjdk.java.net/jmc/pull/342.diff
Fetch: git fetch https://git.openjdk.java.net/jmc pull/342/head:pull/342

PR: https://git.openjdk.java.net/jmc/pull/342

From duke at openjdk.java.net  Sat Dec 11 20:20:44 2021
From: duke at openjdk.java.net (Alex Ciminian)
Date: Sat, 11 Dec 2021 20:20:44 GMT
Subject: RFR: 7449: Add GitHub action to verify copyright year [v3]
In-Reply-To: <va8OiL7O92WOuIQR0pHi0TDa5LXRka7XS_672iUQUhA=.b9168167-c1c4-4597-9a76-d086b4376e4e@github.com>
References: <va8OiL7O92WOuIQR0pHi0TDa5LXRka7XS_672iUQUhA=.b9168167-c1c4-4597-9a76-d086b4376e4e@github.com>
Message-ID: <QSPAx7l74ZNGYG35CA55z9GBo4Fvs-qXigZoLe-UXl4=.4ede5341-4d70-4f17-829f-aa933b39cbe9@github.com>

> This PR adds a script to check copyright notices on changed files. I've not added a GitHub action yet, I'd like to get some feedback before doing that ?? 
> 
> The script is written in Kotlin and uses [JGit](https://www.eclipse.org/jgit/) to interface with the git repository. To run, it only needs the kotlin compiler which is [preinstalled on GitHub Actions runners](https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md).
> 
> It works as follows:
> 
> * diff the HEAD commit and the merge base between it and master (i.e. where the feature branch diverged from)
> * for every changed file (except deletions), validate the copyright header
>   - if the file is new, it should have Oracle and Datadog copyright starting from the year of the HEAD commit
>   - if the file is not new, it should keep the existing copyright holders and update the year range if necessary
> * we compare file contents from objects in the git repo, not the files themselves
> * currently we don't validate we're in the correct directory or the commits
> 
> The output looks like this:
> 
> 
> kotlinc -script scripts/copyrightchecker.main.kts                                                                                                                                                     
> Checked out at: 759788185939b16f447e553b3ee64121187ea311 (base: 8b8aa7c299b92b655ba669a92d16f193beb406bc)
> ?? scripts/copyrightchecker.main.kts
> ? Validation succeeded
> 
> 
> 
> kotlinc -script scripts/copyrightchecker.main.kts                                                                                                                                                       
> Checked out at: 7ad43eed12c9eb85a96882c9518a9acbe12e74c5 (base: ca204424ce32336f2923aff66f619d571b1fc720)
> ?? .gitignore
> ?? application/org.openjdk.jmc.feature.flightrecorder/feature.xml
> ?? Failed to parse:    Copyright (c) 2018, 2021 Oracle and/or its affiliates. All rights reserved.
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/.classpath
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/.gitignore
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/META-INF/MANIFEST.MF
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/build.properties
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/icons/heatmap.png
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/icons/heatmap at 2x.png
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/plugin.properties
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/plugin.xml
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/pom.xml
> Expected:
> <?xml version="1.0" encoding="UTF-8"?>
> <!--
> 	Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
> 	Copyright (c) 2021, Datadog, Inc. All rights reserved.
> 
> 	DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
> Actual:
> <?xml version="1.0" encoding="UTF-8"?>
> <!--
>    Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
>    Copyright (c) 2021, Datadog, Inc. All rights reserved.
> 
>    DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HE
> (check whitespace if strings seem to match)
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/src/main/java/org/openjdk/jmc/flightrecorder/heatmap/views/HeatmapView.java
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/src/main/resources/heatmap.js
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/src/main/resources/page.template
> ?? application/pom.xml
> Expected:
> <?xml version="1.0" encoding="UTF-8"?>
> <!--
> 	Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
> 
> 	DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
> Actual:
> <?xml version="1.0" encoding="UTF-8"?>
> <!--
>    Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
> 
>    DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEAD
> (check whitespace if strings seem to match)
> 
> ? Validation failed

Alex Ciminian has updated the pull request incrementally with one additional commit since the last revision:

  Run copyright checker during validate workflow on linux

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/342/files
  - new: https://git.openjdk.java.net/jmc/pull/342/files/82eb4012..f67d2fc8

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=342&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=342&range=01-02

  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/342.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/342/head:pull/342

PR: https://git.openjdk.java.net/jmc/pull/342

From hirt at openjdk.java.net  Sun Dec 12 21:28:12 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sun, 12 Dec 2021 21:28:12 GMT
Subject: RFR: 7432: Update the spotbugs maven plugin [v7]
In-Reply-To: <wCgSC19Dkq-RcVa01onHijEEYQi8YuVFe2uJ19XHWNk=.4df64e2e-f076-450d-b771-e3d9713d84c0@github.com>
References: <NogwuacUT7-ztkHijbnhluiiz_FDlrP36v9t3ggK0g0=.d3f15cbf-44ea-4f94-b470-8e0c15deba5d@github.com>
 <wCgSC19Dkq-RcVa01onHijEEYQi8YuVFe2uJ19XHWNk=.4df64e2e-f076-450d-b771-e3d9713d84c0@github.com>
Message-ID: <nDAO8sQu9dWD1zOm5fxX6Zuemq8k8wKM6EOOypLQi94=.38fb8829-c469-4f48-b105-c06812a69b58@github.com>

On Fri, 10 Dec 2021 20:08:37 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

>> Signed-off-by: Patrick Reinhart <patrick at reini.net>
>
> Patrick Reinhart has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.

configuration/spotbugs/spotbugs-exclude.xml line 158:

> 156:     </Match>
> 157: 
> 158:     <!-- Allowing catching a NullPointerException that has no specific reason?? -->

I'd skip the "??".

-------------

PR: https://git.openjdk.java.net/jmc/pull/324

From marcus.hirt at datadoghq.com  Mon Dec 13 15:31:30 2021
From: marcus.hirt at datadoghq.com (Marcus Hirt)
Date: Mon, 13 Dec 2021 16:31:30 +0100
Subject: CFV: New jmc Reviewer: Alex Macdonald
Message-ID: <CAOpWGx1tdNGixBjte1xyoAdP09Lo+7qWgXG_dQTvBWaHifrRAQ@mail.gmail.com>

I hereby nominate Alex Macdonald to jmc Reviewer.

Alex has been involved in the JMC community now for a long time, not
only doing many and significant commits to the project. He has also
participated in many code reviews and is a regular in the slack and in
the JMC dev meetings.

https://github.com/openjdk/jmc/graphs/contributors

Votes are due by 2021-12-21 17:00 CET.

Only current jmc Reviewers [1] are eligible to vote
on this nomination. Votes must be cast in the open by replying
to this mailing list.

For Three-Vote Consensus voting instructions, see [2].

Kind regards,
Marcus

[1] https://openjdk.java.net/census
[2] https://openjdk.java.net/projects/#reviewer-vote

From reinhapa at openjdk.java.net  Mon Dec 13 17:47:42 2021
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Mon, 13 Dec 2021 17:47:42 GMT
Subject: RFR: 7432: Update the spotbugs maven plugin [v8]
In-Reply-To: <NogwuacUT7-ztkHijbnhluiiz_FDlrP36v9t3ggK0g0=.d3f15cbf-44ea-4f94-b470-8e0c15deba5d@github.com>
References: <NogwuacUT7-ztkHijbnhluiiz_FDlrP36v9t3ggK0g0=.d3f15cbf-44ea-4f94-b470-8e0c15deba5d@github.com>
Message-ID: <jdleqw_SZf0CJCLH7LcpwKVmo2oLrtkHU5_D2YBAu24=.fcded535-1c46-4c0c-8b7b-13aee2016c7f@github.com>

> Signed-off-by: Patrick Reinhart <patrick at reini.net>

Patrick Reinhart has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  7432: Update the spotbugs maven plugin
  
  Signed-off-by: Patrick Reinhart <patrick at reini.net>

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/324/files
  - new: https://git.openjdk.java.net/jmc/pull/324/files/3b2b45d9..6c6d2286

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=324&range=07
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=324&range=06-07

  Stats: 2 lines in 2 files changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/324.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/324/head:pull/324

PR: https://git.openjdk.java.net/jmc/pull/324

From reinhapa at openjdk.java.net  Mon Dec 13 17:47:47 2021
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Mon, 13 Dec 2021 17:47:47 GMT
Subject: RFR: 7432: Update the spotbugs maven plugin [v7]
In-Reply-To: <nDAO8sQu9dWD1zOm5fxX6Zuemq8k8wKM6EOOypLQi94=.38fb8829-c469-4f48-b105-c06812a69b58@github.com>
References: <NogwuacUT7-ztkHijbnhluiiz_FDlrP36v9t3ggK0g0=.d3f15cbf-44ea-4f94-b470-8e0c15deba5d@github.com>
 <wCgSC19Dkq-RcVa01onHijEEYQi8YuVFe2uJ19XHWNk=.4df64e2e-f076-450d-b771-e3d9713d84c0@github.com>
 <nDAO8sQu9dWD1zOm5fxX6Zuemq8k8wKM6EOOypLQi94=.38fb8829-c469-4f48-b105-c06812a69b58@github.com>
Message-ID: <KKBki1PJTpEwKvZ6LQR_JXlz3ClBXD4U8E8IFW8JCPI=.82c64650-317a-4467-bf3d-c016972680d0@github.com>

On Sun, 12 Dec 2021 21:25:07 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Patrick Reinhart has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.
>
> configuration/spotbugs/spotbugs-exclude.xml line 158:
> 
>> 156:     </Match>
>> 157: 
>> 158:     <!-- Allowing catching a NullPointerException that has no specific reason?? -->
> 
> I'd skip the "??".

@thegreystone added an according comment to the actual class

-------------

PR: https://git.openjdk.java.net/jmc/pull/324

From hirt at openjdk.java.net  Mon Dec 13 19:19:17 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 13 Dec 2021 19:19:17 GMT
Subject: RFR: 7432: Update the spotbugs maven plugin [v8]
In-Reply-To: <jdleqw_SZf0CJCLH7LcpwKVmo2oLrtkHU5_D2YBAu24=.fcded535-1c46-4c0c-8b7b-13aee2016c7f@github.com>
References: <NogwuacUT7-ztkHijbnhluiiz_FDlrP36v9t3ggK0g0=.d3f15cbf-44ea-4f94-b470-8e0c15deba5d@github.com>
 <jdleqw_SZf0CJCLH7LcpwKVmo2oLrtkHU5_D2YBAu24=.fcded535-1c46-4c0c-8b7b-13aee2016c7f@github.com>
Message-ID: <QaxmUu57w8IaJwFV_ZVhthlAOqjzYP0e64y2FBrerjc=.ddf29920-16fe-4e82-971e-6473f81badc0@github.com>

On Mon, 13 Dec 2021 17:47:42 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

>> Signed-off-by: Patrick Reinhart <patrick at reini.net>
>
> Patrick Reinhart has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   7432: Update the spotbugs maven plugin
>   
>   Signed-off-by: Patrick Reinhart <patrick at reini.net>

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/overview/ResultReportUi.java line 415:

> 413: 			this.showOk = Boolean.valueOf(state.getChild("report").getChild("showOk").getAttribute("value")); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
> 414: 		} catch (NullPointerException npe) {
> 415: 			// ignore NPE when there is no state value is available 

Need to update the copyright year.

-------------

PR: https://git.openjdk.java.net/jmc/pull/324

From reinhapa at openjdk.java.net  Mon Dec 13 20:05:40 2021
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Mon, 13 Dec 2021 20:05:40 GMT
Subject: RFR: 7432: Update the spotbugs maven plugin [v9]
In-Reply-To: <NogwuacUT7-ztkHijbnhluiiz_FDlrP36v9t3ggK0g0=.d3f15cbf-44ea-4f94-b470-8e0c15deba5d@github.com>
References: <NogwuacUT7-ztkHijbnhluiiz_FDlrP36v9t3ggK0g0=.d3f15cbf-44ea-4f94-b470-8e0c15deba5d@github.com>
Message-ID: <1R_61u_tn8f989Sl8QYAFxyrBKObKFx-wjjp3_qxzo4=.4e61a656-a1fd-43b6-a3de-c4b6b4e0dd55@github.com>

> Signed-off-by: Patrick Reinhart <patrick at reini.net>

Patrick Reinhart has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  7432: Update the spotbugs maven plugin
  
  Signed-off-by: Patrick Reinhart <patrick at reini.net>

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/324/files
  - new: https://git.openjdk.java.net/jmc/pull/324/files/6c6d2286..d13d907b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=324&range=08
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=324&range=07-08

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/324.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/324/head:pull/324

PR: https://git.openjdk.java.net/jmc/pull/324

From reinhapa at openjdk.java.net  Mon Dec 13 20:05:44 2021
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Mon, 13 Dec 2021 20:05:44 GMT
Subject: RFR: 7432: Update the spotbugs maven plugin [v8]
In-Reply-To: <QaxmUu57w8IaJwFV_ZVhthlAOqjzYP0e64y2FBrerjc=.ddf29920-16fe-4e82-971e-6473f81badc0@github.com>
References: <NogwuacUT7-ztkHijbnhluiiz_FDlrP36v9t3ggK0g0=.d3f15cbf-44ea-4f94-b470-8e0c15deba5d@github.com>
 <jdleqw_SZf0CJCLH7LcpwKVmo2oLrtkHU5_D2YBAu24=.fcded535-1c46-4c0c-8b7b-13aee2016c7f@github.com>
 <QaxmUu57w8IaJwFV_ZVhthlAOqjzYP0e64y2FBrerjc=.ddf29920-16fe-4e82-971e-6473f81badc0@github.com>
Message-ID: <gfZwHbiooUMqYTLztrqPNLAQYrCcN_B78tljTJNyjfI=.f1220277-d1e0-457e-b605-9d715f2af0b6@github.com>

On Mon, 13 Dec 2021 19:16:20 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Patrick Reinhart has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.
>
> application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/overview/ResultReportUi.java line 415:
> 
>> 413: 			this.showOk = Boolean.valueOf(state.getChild("report").getChild("showOk").getAttribute("value")); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
>> 414: 		} catch (NullPointerException npe) {
>> 415: 			// ignore NPE when there is no state value is available 
> 
> Need to update the copyright year.

Done

-------------

PR: https://git.openjdk.java.net/jmc/pull/324

From hdafgard at gmail.com  Tue Dec 14 15:42:17 2021
From: hdafgard at gmail.com (=?UTF-8?Q?Henrik_Dafg=C3=A5rd?=)
Date: Tue, 14 Dec 2021 16:42:17 +0100
Subject: CFV: New jmc Reviewer: Alex Macdonald
In-Reply-To: <CAOpWGx1tdNGixBjte1xyoAdP09Lo+7qWgXG_dQTvBWaHifrRAQ@mail.gmail.com>
References: <CAOpWGx1tdNGixBjte1xyoAdP09Lo+7qWgXG_dQTvBWaHifrRAQ@mail.gmail.com>
Message-ID: <CADFkdVQFiL=LpScXc4HhBpKH9ho_7dfGYr5+aaJwhJFAiBEb4g@mail.gmail.com>

Vote: yes

// Henrik Dafg?rd


On Mon, 13 Dec 2021 at 16:32, Marcus Hirt <marcus.hirt at datadoghq.com> wrote:

> I hereby nominate Alex Macdonald to jmc Reviewer.
>
> Alex has been involved in the JMC community now for a long time, not
> only doing many and significant commits to the project. He has also
> participated in many code reviews and is a regular in the slack and in
> the JMC dev meetings.
>
> https://github.com/openjdk/jmc/graphs/contributors
>
> Votes are due by 2021-12-21 17:00 CET.
>
> Only current jmc Reviewers [1] are eligible to vote
> on this nomination. Votes must be cast in the open by replying
> to this mailing list.
>
> For Three-Vote Consensus voting instructions, see [2].
>
> Kind regards,
> Marcus
>
> [1] https://openjdk.java.net/census
> [2] https://openjdk.java.net/projects/#reviewer-vote
>

From duke at openjdk.java.net  Tue Dec 14 20:14:38 2021
From: duke at openjdk.java.net (Martin Skarsaune)
Date: Tue, 14 Dec 2021 20:14:38 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v2]
In-Reply-To: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
Message-ID: <5ArNunDSWCVB9mPl0FrIJ2ukP9IMaq_1UbTzNTKlJTY=.e2760ebf-1cad-4ee5-93e1-125fd9fde339@github.com>

> Setting back for review. The azure problem requires a fix in Jolokia.
> 
> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.

Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:

  json.simple is needed by kubernetes plugin downstream

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/332/files
  - new: https://git.openjdk.java.net/jmc/pull/332/files/41ed1372..5af95b70

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=332&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=332&range=00-01

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/332.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/332/head:pull/332

PR: https://git.openjdk.java.net/jmc/pull/332

From duke at openjdk.java.net  Tue Dec 14 20:19:50 2021
From: duke at openjdk.java.net (Martin Skarsaune)
Date: Tue, 14 Dec 2021 20:19:50 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v3]
In-Reply-To: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
Message-ID: <lcj2oTaw_tby6RzOjyysdKWuqbKPkALeqK6dMftGn9M=.29c165ed-f2cc-4c60-8d01-fa1b5bc4226c@github.com>

> Setting back for review. The azure problem requires a fix in Jolokia.
> 
> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.

Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:

  Used spotbugs to format according to convention

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/332/files
  - new: https://git.openjdk.java.net/jmc/pull/332/files/5af95b70..cf9a170b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=332&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=332&range=01-02

  Stats: 128 lines in 20 files changed: 21 ins; 22 del; 85 mod
  Patch: https://git.openjdk.java.net/jmc/pull/332.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/332/head:pull/332

PR: https://git.openjdk.java.net/jmc/pull/332

From duke at openjdk.java.net  Tue Dec 14 20:24:59 2021
From: duke at openjdk.java.net (Martin Skarsaune)
Date: Tue, 14 Dec 2021 20:24:59 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v3]
In-Reply-To: <lcj2oTaw_tby6RzOjyysdKWuqbKPkALeqK6dMftGn9M=.29c165ed-f2cc-4c60-8d01-fa1b5bc4226c@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
 <lcj2oTaw_tby6RzOjyysdKWuqbKPkALeqK6dMftGn9M=.29c165ed-f2cc-4c60-8d01-fa1b5bc4226c@github.com>
Message-ID: <njj-jOHJNdNtMzh7Ozb7BZ8R-VeYDV8tZKwH6IFWeLg=.4eed7661-def5-4c88-8e45-9c1be9f78c5a@github.com>

On Tue, 14 Dec 2021 20:19:50 GMT, Martin Skarsaune <duke at openjdk.java.net> wrote:

>> Setting back for review. The azure problem requires a fix in Jolokia.
>> 
>> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.
>
> Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Used spotbugs to format according to convention

I noticed the failed test run. Have used spotbugs to reformat. Re-run please.

-------------

PR: https://git.openjdk.java.net/jmc/pull/332

From duke at openjdk.java.net  Tue Dec 14 21:45:45 2021
From: duke at openjdk.java.net (Martin Skarsaune)
Date: Tue, 14 Dec 2021 21:45:45 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v4]
In-Reply-To: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
Message-ID: <Iz2Sf1NSKWRQab1AQlALXo2VOK0wmqlR_S4IS1soWOE=.d6c0c43d-a89c-44ff-8500-f00489db060a@github.com>

> Setting back for review. The azure problem requires a fix in Jolokia.
> 
> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.

Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:

  Used spotbugs to format more code

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/332/files
  - new: https://git.openjdk.java.net/jmc/pull/332/files/cf9a170b..ab3085ce

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=332&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=332&range=02-03

  Stats: 18 lines in 1 file changed: 5 ins; 1 del; 12 mod
  Patch: https://git.openjdk.java.net/jmc/pull/332.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/332/head:pull/332

PR: https://git.openjdk.java.net/jmc/pull/332

From duke at openjdk.java.net  Wed Dec 15 06:52:23 2021
From: duke at openjdk.java.net (Martin Skarsaune)
Date: Wed, 15 Dec 2021 06:52:23 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v5]
In-Reply-To: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
Message-ID: <EIn8_qyAyG7RzdkBL45jYrH1f2B_2HH2kGkTf6RIVmc=.da608ca3-570a-4b26-b1d8-85b62b57f74f@github.com>

> Setting back for review. The azure problem requires a fix in Jolokia.
> 
> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.

Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains ten commits:

 - Used spotbugs to format more code
 - Used spotbugs to format according to convention
 - json.simple is needed by kubernetes plugin downstream
 - Adding test plugin for Jolokia
 - Revert unwanted change unrelated to new plugins
 - Added copyright notices. Removed author tag and meaningless comments
 - No reason more than Java 8 should be required
 - Working on spotbugs errors and build problems
 - [WIP] Jolokia support

-------------

Changes: https://git.openjdk.java.net/jmc/pull/332/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=332&range=04
  Stats: 3146 lines in 47 files changed: 3146 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/332.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/332/head:pull/332

PR: https://git.openjdk.java.net/jmc/pull/332

From duke at openjdk.java.net  Wed Dec 15 06:52:26 2021
From: duke at openjdk.java.net (Martin Skarsaune)
Date: Wed, 15 Dec 2021 06:52:26 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v4]
In-Reply-To: <Iz2Sf1NSKWRQab1AQlALXo2VOK0wmqlR_S4IS1soWOE=.d6c0c43d-a89c-44ff-8500-f00489db060a@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
 <Iz2Sf1NSKWRQab1AQlALXo2VOK0wmqlR_S4IS1soWOE=.d6c0c43d-a89c-44ff-8500-f00489db060a@github.com>
Message-ID: <mROKi3nxJy07ELkn3a--El_RTgI2KWh6ok6pIpX-qFI=.62401002-2ea9-426e-88d2-00a8a50544c4@github.com>

On Tue, 14 Dec 2021 21:45:45 GMT, Martin Skarsaune <duke at openjdk.java.net> wrote:

>> Setting back for review. The azure problem requires a fix in Jolokia.
>> 
>> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.
>
> Martin Skarsaune has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.

I have corrected the last formatting and rebased with master. When I run the shell scripts from the github action definition on my mac, the first 3 run fine, however in scripts/runagenttests.sh there is a test failure (test-permissions). Should not be related to this PR however.

-------------

PR: https://git.openjdk.java.net/jmc/pull/332

From duke at openjdk.java.net  Wed Dec 15 14:39:02 2021
From: duke at openjdk.java.net (Martin Skarsaune)
Date: Wed, 15 Dec 2021 14:39:02 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v5]
In-Reply-To: <EIn8_qyAyG7RzdkBL45jYrH1f2B_2HH2kGkTf6RIVmc=.da608ca3-570a-4b26-b1d8-85b62b57f74f@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
 <EIn8_qyAyG7RzdkBL45jYrH1f2B_2HH2kGkTf6RIVmc=.da608ca3-570a-4b26-b1d8-85b62b57f74f@github.com>
Message-ID: <HJLOvI7kRlsEt-cTlo9nazk-prQj8BdDHZ1ZDcppRG0=.f4143c56-fdf7-4a4c-bf5d-1e6b771e77b1@github.com>

On Wed, 15 Dec 2021 06:52:23 GMT, Martin Skarsaune <duke at openjdk.java.net> wrote:

>> Setting back for review. The azure problem requires a fix in Jolokia.
>> 
>> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.
>
> Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains ten commits:
> 
>  - Used spotbugs to format more code
>  - Used spotbugs to format according to convention
>  - json.simple is needed by kubernetes plugin downstream
>  - Adding test plugin for Jolokia
>  - Revert unwanted change unrelated to new plugins
>  - Added copyright notices. Removed author tag and meaningless comments
>  - No reason more than Java 8 should be required
>  - Working on spotbugs errors and build problems
>  - [WIP] Jolokia support

Fails on some platforms: "Unrecognized option: -XstartOnFirstThread" , will fix

-------------

PR: https://git.openjdk.java.net/jmc/pull/332

From duke at openjdk.java.net  Wed Dec 15 15:27:35 2021
From: duke at openjdk.java.net (Martin Skarsaune)
Date: Wed, 15 Dec 2021 15:27:35 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v6]
In-Reply-To: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
Message-ID: <HAQoe5btJRbXBpw3He4GnZGH8zAhBrZqz1GYL87hz6Q=.54908fac-83bb-46f9-ae7a-9ba7f2723079@github.com>

> Setting back for review. The azure problem requires a fix in Jolokia.
> 
> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.

Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:

  Removed -XstartOnFirstThread as it is not valid for some JVMs

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/332/files
  - new: https://git.openjdk.java.net/jmc/pull/332/files/69bbb53a..955e3f8a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=332&range=05
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=332&range=04-05

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/332.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/332/head:pull/332

PR: https://git.openjdk.java.net/jmc/pull/332

From duke at openjdk.java.net  Wed Dec 15 16:03:05 2021
From: duke at openjdk.java.net (Michael =?UTF-8?B?U8O8ZGthbXA=?=)
Date: Wed, 15 Dec 2021 16:03:05 GMT
Subject: RFR: 7439: Introduced IConstantPoolExtension for Constant Pools
 [v6]
In-Reply-To: <IFFEOXHsROnNc9MbR_ULppUzr0GnRQE69UP2ZA-TghE=.7849d5da-2a7d-4d08-9f63-e104ddc9d0ad@github.com>
References: <yr6Hwt8RLp5vDKKxZNrB55aBiyZaP00et_A_BsBw6Dc=.32b3e0bd-ffdb-4a43-8020-c0305d586a52@github.com>
 <IFFEOXHsROnNc9MbR_ULppUzr0GnRQE69UP2ZA-TghE=.7849d5da-2a7d-4d08-9f63-e104ddc9d0ad@github.com>
Message-ID: <kiFnPlQdimZWpL9ZI4TVS2q9OBZZV1mPZAnqO7NFAkU=.fa0eeb3a-606a-4226-9799-f13ef3c186aa@github.com>

On Fri, 26 Nov 2021 20:46:41 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

>> Add extension methods when constants are read, referenced, resolved, constant pools fully resolved and parsing finished to be able for example:
>> 
>>  * track constant pool usage inside events
>>  * replace or translate symbols, method names, etc... like
>> de-obfuscations of stack traces
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove unused import

The PR is merged, but I've resumed my tests and are in the middle of adapting my de-obfuscation code to the new extension mechanism. 
Question: How would you load such an extension in real life? By means of a plugin JAR? There are a lot of plugin JARs in the plugin folder of the build JMC, but I couldn't find a starting point for development. Could you point me to such a resource?

-------------

PR: https://git.openjdk.java.net/jmc/pull/333

From duke at openjdk.java.net  Fri Dec 17 09:54:28 2021
From: duke at openjdk.java.net (Michael =?UTF-8?B?U8O8ZGthbXA=?=)
Date: Fri, 17 Dec 2021 09:54:28 GMT
Subject: RFR: 7439: Introduced IConstantPoolExtension for Constant Pools
 [v5]
In-Reply-To: <YgJDaJ6M4ud3pW06DLelKWVQ-24LzwWBdXQF1ZCZVsI=.2a057cda-8ee6-48ec-a288-ca7e6c7e5de6@github.com>
References: <yr6Hwt8RLp5vDKKxZNrB55aBiyZaP00et_A_BsBw6Dc=.32b3e0bd-ffdb-4a43-8020-c0305d586a52@github.com>
 <tEPoe4rCFtYF8UlIJjqL37kF8Yi0r01TT2KTLUhlPpQ=.4a30577c-c270-46ba-be1c-0124a80d0d80@github.com>
 <YgJDaJ6M4ud3pW06DLelKWVQ-24LzwWBdXQF1ZCZVsI=.2a057cda-8ee6-48ec-a288-ca7e6c7e5de6@github.com>
Message-ID: <7F8t_FM2s1U4Vx1Idud6xI8vAesbMBEEqg_NvpK5aMQ=.a235cddb-53a7-4afa-a6fd-415402a064d4@github.com>

On Mon, 22 Nov 2021 21:19:42 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

>> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   formatting
>
> It would be nice to have your feedback on this, because I came back a lot on the design to implement my needs. So depending on yours, we may revisit some parts...

@jpbempel as assumed doing the deobfuscation using the IConstantPoolExtension is much more complicated than as I did it previously because it modifies internal state. I'm facing follow-up exceptions and have been trying for a while to sort them out. But I am clueless now.
I overwrote constantRead() and look for constants with instanceof String. Then I look up these Strings in my obfuscation mapping and if I get a hit, I replace the strings or the relevant substring with the deobfuscated string and return it. But this seem to create wrong internal state. I'm logging to console original and replaced strings and what Is see look fine to me according to my understanding.

Do you have any more hint? Otherwise I would push my current code to my fork and post the link here. If you can help I will continue, otherwise I'll have to stay with my existing solution doing the deobfuscation on formatting level, which is just fine for our purpose.

-------------

PR: https://git.openjdk.java.net/jmc/pull/333

From duke at openjdk.java.net  Sun Dec 19 16:20:47 2021
From: duke at openjdk.java.net (Gunnar Morling)
Date: Sun, 19 Dec 2021 16:20:47 GMT
Subject: RFR: 7480: Trim method descriptor value
Message-ID: <pXUiyIdLBjXLIYFBzBi96CdXfFNj8Jox4K6Ip5DH5e4=.e2b2a095-50a6-4dd2-9bd6-74cc411d5ac8@github.com>

Hey @thegreystone, here's a fix for trimming the method signature value when building the method descriptors in the agent. Without this, wrapping the tags around long signatures like that [will fail](https://github.com/moditect/jfrunit-examples/commit/bd4bc8023c760a3d719dc9295cbe010fb56d7f6f#diff-8999381a163c84127b7e94462f39060c054a984904f82c34713d0ade0954e4c5R81):


 <descriptor>
   (Ljava/sql/PreparedStatement;Ljava/lang/Object;ILorg/hibernate/type/descriptor/WrapperOptions;)V
</descriptor>


Could you log an issue if you think it's a worthwhile fix? The second commit is some unrelated clean-up I did along the way. Thx!

-------------

Commit messages:
 - 9999: Removing unused import and local var
 - 9999: Trimming descriptor

Changes: https://git.openjdk.java.net/jmc/pull/343/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=343&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7480
  Stats: 3 lines in 2 files changed: 0 ins; 1 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/343.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/343/head:pull/343

PR: https://git.openjdk.java.net/jmc/pull/343

From hirt at openjdk.java.net  Sun Dec 19 16:27:30 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sun, 19 Dec 2021 16:27:30 GMT
Subject: RFR: 7480: Trim method descriptor value
In-Reply-To: <pXUiyIdLBjXLIYFBzBi96CdXfFNj8Jox4K6Ip5DH5e4=.e2b2a095-50a6-4dd2-9bd6-74cc411d5ac8@github.com>
References: <pXUiyIdLBjXLIYFBzBi96CdXfFNj8Jox4K6Ip5DH5e4=.e2b2a095-50a6-4dd2-9bd6-74cc411d5ac8@github.com>
Message-ID: <3B4ieotvi_4Vki2G2wc6vU5wDjYq4_y2_rQ0euUEc0U=.e7126358-61c5-4c6a-a9f4-28a88f48f836@github.com>

On Sat, 18 Dec 2021 17:30:01 GMT, Gunnar Morling <duke at openjdk.java.net> wrote:

> Hey @thegreystone, here's a fix for trimming the method signature value when building the method descriptors in the agent. Without this, wrapping the tags around long signatures like that [will fail](https://github.com/moditect/jfrunit-examples/commit/bd4bc8023c760a3d719dc9295cbe010fb56d7f6f#diff-8999381a163c84127b7e94462f39060c054a984904f82c34713d0ade0954e4c5R81):
> 
> 
>  <descriptor>
>    (Ljava/sql/PreparedStatement;Ljava/lang/Object;ILorg/hibernate/type/descriptor/WrapperOptions;)V
> </descriptor>
> 
> 
> Could you log an issue if you think it's a worthwhile fix? The second commit is some unrelated clean-up I did along the way. Thx!

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/343

From hirt at openjdk.java.net  Mon Dec 20 10:45:35 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 20 Dec 2021 10:45:35 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v6]
In-Reply-To: <HAQoe5btJRbXBpw3He4GnZGH8zAhBrZqz1GYL87hz6Q=.54908fac-83bb-46f9-ae7a-9ba7f2723079@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
 <HAQoe5btJRbXBpw3He4GnZGH8zAhBrZqz1GYL87hz6Q=.54908fac-83bb-46f9-ae7a-9ba7f2723079@github.com>
Message-ID: <07YA3dr8ItooyEahwJ_DcBZRmAMQWopNjy1bJKUfX5o=.9447a826-e0db-47bd-ae41-d67c08320528@github.com>

On Wed, 15 Dec 2021 15:27:35 GMT, Martin Skarsaune <duke at openjdk.java.net> wrote:

>> Setting back for review. The azure problem requires a fix in Jolokia.
>> 
>> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.
>
> Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed -XstartOnFirstThread as it is not valid for some JVMs

I took a quick pass on (mainly) the javadocs.

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/AbstractCachedDescriptorProvider.java line 45:

> 43: 
> 44: /**
> 45:  * I cache a list if identified JVMs that can be refreshed in the background by some means of

"I" personal pronomen. "if" identified. 

Better to keep it impersonal and describe what the class does. E.g. "Keeps a list of identified JVMs..."
"The {@code AbstractCachedDescriptorProvider} keeps a list of identified JVMs..." would be even better.

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JmcJolokiaJmxConnection.java line 128:

> 126: 
> 127: 	/**
> 128: 	 * build / reverse engineer MBeanOperationInfo by using the local one if it is a match or try to

Punctuation.

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JmcJolokiaJmxConnection.java line 137:

> 135: 	 */
> 136: 	private MBeanOperationInfo stealOrBuildOperationInfo(MBeanOperationInfo original, MBeanInfo localInfo) {
> 137: 		// first attempt to get descriptor from local copy

Might want to break out into individual methods at the comment lines.

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JolokiaAgentDescriptor.java line 60:

> 58: import org.openjdk.jmc.ui.common.jvm.JVMType;
> 59: 
> 60: public class JolokiaAgentDescriptor implements ServerConnectionDescriptor {

Public class. Would prefer a class comment.

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JolokiaAgentDescriptor.java line 99:

> 97: 	/**
> 98: 	 * Best effort to extract JVM information from a connection if everything works. Can be adjusted
> 99: 	 * to support different flavors of JVM

Punctuation, last sentence.

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JolokiaDiscoveryListener.java line 48:

> 46: import org.openjdk.jmc.jolokia.preferences.PreferenceConstants;
> 47: 
> 48: public class JolokiaDiscoveryListener extends AbstractCachedDescriptorProvider implements PreferenceConstants {

Class comment.

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/ServerConnectionDescriptor.java line 42:

> 40: 
> 41: /**
> 42:  * Describes the JVM and how to connect to it

Punctuation.

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/preferences/PreferenceConstants.java line 37:

> 35: 
> 36: /**
> 37:  * Constant definitions for plug-in preferences

Punctuation.

application/org.openjdk.jmc.kubernetes/src/main/java/org/openjdk/jmc/kubernetes/JmcKubernetesJmxConnection.java line 50:

> 48: import org.openjdk.jmc.rjmx.ConnectionException;
> 49: 
> 50: public class JmcKubernetesJmxConnection extends JmcJolokiaJmxConnection {

Class comment.

application/org.openjdk.jmc.kubernetes/src/main/java/org/openjdk/jmc/kubernetes/JmcKubernetesJmxConnectionProvider.java line 44:

> 42: import javax.management.remote.JMXServiceURL;
> 43: 
> 44: public class JmcKubernetesJmxConnectionProvider implements JMXConnectorProvider {

Class comment. E.g. "This {@code JMXConnectionProvider} verifies that the protocol is kubernetes."

application/org.openjdk.jmc.kubernetes/src/main/java/org/openjdk/jmc/kubernetes/KubernetesDiscoveryListener.java line 81:

> 79: import io.fabric8.kubernetes.client.utils.Utils;
> 80: 
> 81: public class KubernetesDiscoveryListener extends AbstractCachedDescriptorProvider {

Class comment.

application/org.openjdk.jmc.kubernetes/src/main/java/org/openjdk/jmc/kubernetes/preferences/JmcKubernetesPreferenceForm.java line 57:

> 55:  * preference store.
> 56:  */
> 57: 

Line 57 is superfluous.

application/org.openjdk.jmc.kubernetes/src/main/java/org/openjdk/jmc/kubernetes/preferences/PreferenceConstants.java line 37:

> 35: 
> 36: /**
> 37:  * Constant definitions for plug-in preferences

Punctuation.

-------------

Changes requested by hirt (Lead).

PR: https://git.openjdk.java.net/jmc/pull/332

From duke at openjdk.java.net  Mon Dec 20 12:30:30 2021
From: duke at openjdk.java.net (Martin Skarsaune)
Date: Mon, 20 Dec 2021 12:30:30 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v6]
In-Reply-To: <07YA3dr8ItooyEahwJ_DcBZRmAMQWopNjy1bJKUfX5o=.9447a826-e0db-47bd-ae41-d67c08320528@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
 <HAQoe5btJRbXBpw3He4GnZGH8zAhBrZqz1GYL87hz6Q=.54908fac-83bb-46f9-ae7a-9ba7f2723079@github.com>
 <07YA3dr8ItooyEahwJ_DcBZRmAMQWopNjy1bJKUfX5o=.9447a826-e0db-47bd-ae41-d67c08320528@github.com>
Message-ID: <yfLMLFpba2bB2MqgeBvlLk1gWWHjCd9VTbUA_2JNQdk=.a1bf496a-cd5b-4cb7-93bb-db2635336af6@github.com>

On Mon, 20 Dec 2021 10:01:53 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed -XstartOnFirstThread as it is not valid for some JVMs
>
> application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/AbstractCachedDescriptorProvider.java line 45:
> 
>> 43: 
>> 44: /**
>> 45:  * I cache a list if identified JVMs that can be refreshed in the background by some means of
> 
> "I" personal pronomen. "if" identified. 
> 
> Better to keep it impersonal and describe what the class does. E.g. "Keeps a list of identified JVMs..."
> "The {@code AbstractCachedDescriptorProvider} keeps a list of identified JVMs..." would be even better.

I see. Will adjust ?? . FYI: I'm on the old Smalltalk extreme object oriented lingo. You may have seen it in SWT and JFace code as well. A bit out of date. 
I'm currently on 2 week holiday with family, will get back to the PR next year ??

-------------

PR: https://git.openjdk.java.net/jmc/pull/332

From marcus.hirt at datadoghq.com  Mon Dec 20 16:56:27 2021
From: marcus.hirt at datadoghq.com (Marcus Hirt)
Date: Mon, 20 Dec 2021 17:56:27 +0100
Subject: CFV: New jmc Reviewer: Alex Macdonald
In-Reply-To: <CADFkdVQFiL=LpScXc4HhBpKH9ho_7dfGYr5+aaJwhJFAiBEb4g@mail.gmail.com>
References: <CAOpWGx1tdNGixBjte1xyoAdP09Lo+7qWgXG_dQTvBWaHifrRAQ@mail.gmail.com>
 <CADFkdVQFiL=LpScXc4HhBpKH9ho_7dfGYr5+aaJwhJFAiBEb4g@mail.gmail.com>
Message-ID: <CAOpWGx0p5v0U1y+g2jZJT1sObJ4VD-Q=ct=s=49Vm4zvEGzCcQ@mail.gmail.com>

Vote: yes

/M

On Tue, Dec 14, 2021 at 4:42 PM Henrik Dafg?rd <hdafgard at gmail.com> wrote:

> Vote: yes
>
> // Henrik Dafg?rd
>
>
> On Mon, 13 Dec 2021 at 16:32, Marcus Hirt <marcus.hirt at datadoghq.com>
> wrote:
>
>> I hereby nominate Alex Macdonald to jmc Reviewer.
>>
>> Alex has been involved in the JMC community now for a long time, not
>> only doing many and significant commits to the project. He has also
>> participated in many code reviews and is a regular in the slack and in
>> the JMC dev meetings.
>>
>> https://github.com/openjdk/jmc/graphs/contributors
>>
>> Votes are due by 2021-12-21 17:00 CET.
>>
>> Only current jmc Reviewers [1] are eligible to vote
>> on this nomination. Votes must be cast in the open by replying
>> to this mailing list.
>>
>> For Three-Vote Consensus voting instructions, see [2].
>>
>> Kind regards,
>> Marcus
>>
>> [1] https://openjdk.java.net/census
>> [2] https://openjdk.java.net/projects/#reviewer-vote
>>
>

From duke at openjdk.java.net  Mon Dec 20 18:08:22 2021
From: duke at openjdk.java.net (Michael =?UTF-8?B?U8O8ZGthbXA=?=)
Date: Mon, 20 Dec 2021 18:08:22 GMT
Subject: RFR: 7439: Introduced IConstantPoolExtension for Constant Pools
 [v5]
In-Reply-To: <YgJDaJ6M4ud3pW06DLelKWVQ-24LzwWBdXQF1ZCZVsI=.2a057cda-8ee6-48ec-a288-ca7e6c7e5de6@github.com>
References: <yr6Hwt8RLp5vDKKxZNrB55aBiyZaP00et_A_BsBw6Dc=.32b3e0bd-ffdb-4a43-8020-c0305d586a52@github.com>
 <tEPoe4rCFtYF8UlIJjqL37kF8Yi0r01TT2KTLUhlPpQ=.4a30577c-c270-46ba-be1c-0124a80d0d80@github.com>
 <YgJDaJ6M4ud3pW06DLelKWVQ-24LzwWBdXQF1ZCZVsI=.2a057cda-8ee6-48ec-a288-ca7e6c7e5de6@github.com>
Message-ID: <NLRkOOuy2lOZq3ejp3tZK1u-9h-3s8V70-LBhdfHD-g=.11ba8e4e-3870-4733-bd13-c1ce3f2293b9@github.com>

On Mon, 22 Nov 2021 21:19:42 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

>> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   formatting
>
> It would be nice to have your feedback on this, because I came back a lot on the design to implement my needs. So depending on yours, we may revisit some parts...

@jpbempel in this branch https://github.com/docwarems/jmc/tree/PR-333-Deobfuscate you'll find a demonstration of my current problem. The README describes how to run the demo. I will/can not further investigate unless you come with a hint what I'm doing wrong.

-------------

PR: https://git.openjdk.java.net/jmc/pull/333

From klara.ward at gmail.com  Mon Dec 20 19:00:16 2021
From: klara.ward at gmail.com (Klara Ward)
Date: Mon, 20 Dec 2021 20:00:16 +0100
Subject: CFV: New jmc Reviewer: Alex Macdonald
In-Reply-To: <CAOpWGx0p5v0U1y+g2jZJT1sObJ4VD-Q=ct=s=49Vm4zvEGzCcQ@mail.gmail.com>
References: <CAOpWGx1tdNGixBjte1xyoAdP09Lo+7qWgXG_dQTvBWaHifrRAQ@mail.gmail.com>
 <CADFkdVQFiL=LpScXc4HhBpKH9ho_7dfGYr5+aaJwhJFAiBEb4g@mail.gmail.com>
 <CAOpWGx0p5v0U1y+g2jZJT1sObJ4VD-Q=ct=s=49Vm4zvEGzCcQ@mail.gmail.com>
Message-ID: <d691b375-26d7-c3da-663b-275e63a3506d@gmail.com>

Vote: yes

// Klara Ward

On 2021-12-20 17:56, Marcus Hirt wrote:
> Vote: yes
>
> /M
>
> On Tue, Dec 14, 2021 at 4:42 PM Henrik Dafg?rd <hdafgard at gmail.com> wrote:
>
>> Vote: yes
>>
>> // Henrik Dafg?rd
>>
>>
>> On Mon, 13 Dec 2021 at 16:32, Marcus Hirt <marcus.hirt at datadoghq.com>
>> wrote:
>>
>>> I hereby nominate Alex Macdonald to jmc Reviewer.
>>>
>>> Alex has been involved in the JMC community now for a long time, not
>>> only doing many and significant commits to the project. He has also
>>> participated in many code reviews and is a regular in the slack and in
>>> the JMC dev meetings.
>>>
>>> https://github.com/openjdk/jmc/graphs/contributors
>>>
>>> Votes are due by 2021-12-21 17:00 CET.
>>>
>>> Only current jmc Reviewers [1] are eligible to vote
>>> on this nomination. Votes must be cast in the open by replying
>>> to this mailing list.
>>>
>>> For Three-Vote Consensus voting instructions, see [2].
>>>
>>> Kind regards,
>>> Marcus
>>>
>>> [1] https://openjdk.java.net/census
>>> [2] https://openjdk.java.net/projects/#reviewer-vote
>>>


From hirt at openjdk.java.net  Mon Dec 20 23:26:25 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 20 Dec 2021 23:26:25 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v6]
In-Reply-To: <yfLMLFpba2bB2MqgeBvlLk1gWWHjCd9VTbUA_2JNQdk=.a1bf496a-cd5b-4cb7-93bb-db2635336af6@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
 <HAQoe5btJRbXBpw3He4GnZGH8zAhBrZqz1GYL87hz6Q=.54908fac-83bb-46f9-ae7a-9ba7f2723079@github.com>
 <07YA3dr8ItooyEahwJ_DcBZRmAMQWopNjy1bJKUfX5o=.9447a826-e0db-47bd-ae41-d67c08320528@github.com>
 <yfLMLFpba2bB2MqgeBvlLk1gWWHjCd9VTbUA_2JNQdk=.a1bf496a-cd5b-4cb7-93bb-db2635336af6@github.com>
Message-ID: <Wjovi_8fQBxm4zRY7p5sY5wdZ-rhrvi5Woc_6fnrBu0=.ab3ba568-52cd-4671-a182-b0a0ec25837c@github.com>

On Mon, 20 Dec 2021 12:27:42 GMT, Martin Skarsaune <duke at openjdk.java.net> wrote:

>> application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/AbstractCachedDescriptorProvider.java line 45:
>> 
>>> 43: 
>>> 44: /**
>>> 45:  * I cache a list if identified JVMs that can be refreshed in the background by some means of
>> 
>> "I" personal pronomen. "if" identified. 
>> 
>> Better to keep it impersonal and describe what the class does. E.g. "Keeps a list of identified JVMs..."
>> "The {@code AbstractCachedDescriptorProvider} keeps a list of identified JVMs..." would be even better.
>
> I see. Will adjust ?? . FYI: I'm on the old Smalltalk extreme object oriented lingo. You may have seen it in SWT and JFace code as well. A bit out of date. 
> I'm currently on 2 week holiday with family, will get back to the PR next year ??

Enjoy your vacation! :)

-------------

PR: https://git.openjdk.java.net/jmc/pull/332

From duke at openjdk.java.net  Tue Dec 21 09:11:55 2021
From: duke at openjdk.java.net (Gunnar Morling)
Date: Tue, 21 Dec 2021 09:11:55 GMT
Subject: RFR: 7480: Trim method descriptor value [v2]
In-Reply-To: <pXUiyIdLBjXLIYFBzBi96CdXfFNj8Jox4K6Ip5DH5e4=.e2b2a095-50a6-4dd2-9bd6-74cc411d5ac8@github.com>
References: <pXUiyIdLBjXLIYFBzBi96CdXfFNj8Jox4K6Ip5DH5e4=.e2b2a095-50a6-4dd2-9bd6-74cc411d5ac8@github.com>
Message-ID: <2bDjKJ-4MwldSQ487Mf12yO7CB9kRAjCoax3yNa0yzg=.0807c805-ec68-4e26-a69e-6b2ddf12d72b@github.com>

> Hey @thegreystone, here's a fix for trimming the method signature value when building the method descriptors in the agent. Without this, wrapping the tags around long signatures like that [will fail](https://github.com/moditect/jfrunit-examples/commit/bd4bc8023c760a3d719dc9295cbe010fb56d7f6f#diff-8999381a163c84127b7e94462f39060c054a984904f82c34713d0ade0954e4c5R81):
> 
> 
>  <descriptor>
>    (Ljava/sql/PreparedStatement;Ljava/lang/Object;ILorg/hibernate/type/descriptor/WrapperOptions;)V
> </descriptor>
> 
> 
> Could you log an issue if you think it's a worthwhile fix? The second commit is some unrelated clean-up I did along the way. Thx!

Gunnar Morling has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision:

 - 7480: Removing unused import and local var
 - 7480: Trimming descriptor

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/343/files
  - new: https://git.openjdk.java.net/jmc/pull/343/files/dcf167d0..9243d98b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=343&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=343&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/343.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/343/head:pull/343

PR: https://git.openjdk.java.net/jmc/pull/343

From duke at openjdk.java.net  Tue Dec 21 09:11:56 2021
From: duke at openjdk.java.net (Gunnar Morling)
Date: Tue, 21 Dec 2021 09:11:56 GMT
Subject: RFR: 7480: Trim method descriptor value [v2]
In-Reply-To: <3B4ieotvi_4Vki2G2wc6vU5wDjYq4_y2_rQ0euUEc0U=.e7126358-61c5-4c6a-a9f4-28a88f48f836@github.com>
References: <pXUiyIdLBjXLIYFBzBi96CdXfFNj8Jox4K6Ip5DH5e4=.e2b2a095-50a6-4dd2-9bd6-74cc411d5ac8@github.com>
 <3B4ieotvi_4Vki2G2wc6vU5wDjYq4_y2_rQ0euUEc0U=.e7126358-61c5-4c6a-a9f4-28a88f48f836@github.com>
Message-ID: <anA7OrsuTltJLt7r9IaTEmqrOtWQ_qsAbdLlTXpwKxk=.8f0d22d5-61e3-4f93-acdc-9e04953342e6@github.com>

On Sun, 19 Dec 2021 16:24:16 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Gunnar Morling has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision:
>> 
>>  - 7480: Removing unused import and local var
>>  - 7480: Trimming descriptor
>
> Marked as reviewed by hirt (Lead).

@thegreystone thx for logging 7480. Reworded the commit messages accordingly.

-------------

PR: https://git.openjdk.java.net/jmc/pull/343

From duke at openjdk.java.net  Tue Dec 21 16:21:23 2021
From: duke at openjdk.java.net (Gunnar Morling)
Date: Tue, 21 Dec 2021 16:21:23 GMT
Subject: Integrated: 7480: Trim method descriptor value
In-Reply-To: <pXUiyIdLBjXLIYFBzBi96CdXfFNj8Jox4K6Ip5DH5e4=.e2b2a095-50a6-4dd2-9bd6-74cc411d5ac8@github.com>
References: <pXUiyIdLBjXLIYFBzBi96CdXfFNj8Jox4K6Ip5DH5e4=.e2b2a095-50a6-4dd2-9bd6-74cc411d5ac8@github.com>
Message-ID: <NUvW_RVl4M2ktbwCUgO5mmpeZR7uNehnmsSjbAQeXmY=.41cf26c5-2da4-4dca-a548-f080403a0c2d@github.com>

On Sat, 18 Dec 2021 17:30:01 GMT, Gunnar Morling <duke at openjdk.java.net> wrote:

> Hey @thegreystone, here's a fix for trimming the method signature value when building the method descriptors in the agent. Without this, wrapping the tags around long signatures like that [will fail](https://github.com/moditect/jfrunit-examples/commit/bd4bc8023c760a3d719dc9295cbe010fb56d7f6f#diff-8999381a163c84127b7e94462f39060c054a984904f82c34713d0ade0954e4c5R81):
> 
> 
>  <descriptor>
>    (Ljava/sql/PreparedStatement;Ljava/lang/Object;ILorg/hibernate/type/descriptor/WrapperOptions;)V
> </descriptor>
> 
> 
> Could you log an issue if you think it's a worthwhile fix? The second commit is some unrelated clean-up I did along the way. Thx!

This pull request has now been integrated.

Changeset: 1c6ccc9b
Author:    Gunnar Morling <gunnar.morling at googlemail.com>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/1c6ccc9b644f7953ebb5f513aab5ada56760283b
Stats:     3 lines in 2 files changed: 0 ins; 1 del; 2 mod

7480: Trim method descriptor value

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/343

From marcus.hirt at datadoghq.com  Tue Dec 21 18:18:14 2021
From: marcus.hirt at datadoghq.com (Marcus Hirt)
Date: Tue, 21 Dec 2021 19:18:14 +0100
Subject: Result: New jmc Reviewer: Alex Macdonald
Message-ID: <CAOpWGx03GNL77q9TBVY56qfTLBBBzXqgfM6i-LnuoqAkwoMGWw@mail.gmail.com>

Voting for Alex Macdonald [1] is now closed.

Yes: 3
Veto: 0
Abstain: 0

According to the Bylaws definition of Three-Vote Consensus, this is
sufficient to approve the nomination.

Kind regards,
Marcus

[1] https://mail.openjdk.java.net/pipermail/jmc-dev/2021-December/004251.html

From reinhapa at openjdk.java.net  Wed Dec 22 13:18:48 2021
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Wed, 22 Dec 2021 13:18:48 GMT
Subject: RFR: 7432: Update the spotbugs maven plugin [v10]
In-Reply-To: <NogwuacUT7-ztkHijbnhluiiz_FDlrP36v9t3ggK0g0=.d3f15cbf-44ea-4f94-b470-8e0c15deba5d@github.com>
References: <NogwuacUT7-ztkHijbnhluiiz_FDlrP36v9t3ggK0g0=.d3f15cbf-44ea-4f94-b470-8e0c15deba5d@github.com>
Message-ID: <QnKh4I1Ohpny7H23kWiqXroSkafVbQjmfp-ndbRoBeQ=.731d1ba3-cf1d-4030-86be-47d63aa5c10d@github.com>

> Signed-off-by: Patrick Reinhart <patrick at reini.net>

Patrick Reinhart has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:

  7432: Update the spotbugs maven plugin
  
  Signed-off-by: Patrick Reinhart <patrick at reini.net>

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/324/files
  - new: https://git.openjdk.java.net/jmc/pull/324/files/d13d907b..5d933227

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=324&range=09
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=324&range=08-09

  Stats: 3 lines in 2 files changed: 0 ins; 1 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/324.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/324/head:pull/324

PR: https://git.openjdk.java.net/jmc/pull/324

From reinhapa at openjdk.java.net  Wed Dec 22 19:15:50 2021
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Wed, 22 Dec 2021 19:15:50 GMT
Subject: RFR: 7432: Update the spotbugs maven plugin [v11]
In-Reply-To: <NogwuacUT7-ztkHijbnhluiiz_FDlrP36v9t3ggK0g0=.d3f15cbf-44ea-4f94-b470-8e0c15deba5d@github.com>
References: <NogwuacUT7-ztkHijbnhluiiz_FDlrP36v9t3ggK0g0=.d3f15cbf-44ea-4f94-b470-8e0c15deba5d@github.com>
Message-ID: <iNc-bfixHgVlt00A6F3P0Utf_lAya_pHmMWGAQYI5yc=.25672dd3-525a-4c55-9416-713964ff2841@github.com>

> Signed-off-by: Patrick Reinhart <patrick at reini.net>

Patrick Reinhart has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  7432: Update the spotbugs maven plugin
  
  Signed-off-by: Patrick Reinhart <patrick at reini.net>

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/324/files
  - new: https://git.openjdk.java.net/jmc/pull/324/files/5d933227..9e14b46b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=324&range=10
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=324&range=09-10

  Stats: 88 lines in 2 files changed: 46 ins; 35 del; 7 mod
  Patch: https://git.openjdk.java.net/jmc/pull/324.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/324/head:pull/324

PR: https://git.openjdk.java.net/jmc/pull/324

From hirt at openjdk.java.net  Thu Dec 23 11:24:16 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 23 Dec 2021 11:24:16 GMT
Subject: RFR: 7432: Update the spotbugs maven plugin [v11]
In-Reply-To: <iNc-bfixHgVlt00A6F3P0Utf_lAya_pHmMWGAQYI5yc=.25672dd3-525a-4c55-9416-713964ff2841@github.com>
References: <NogwuacUT7-ztkHijbnhluiiz_FDlrP36v9t3ggK0g0=.d3f15cbf-44ea-4f94-b470-8e0c15deba5d@github.com>
 <iNc-bfixHgVlt00A6F3P0Utf_lAya_pHmMWGAQYI5yc=.25672dd3-525a-4c55-9416-713964ff2841@github.com>
Message-ID: <LY3Ko0yhU2H9aw0QrtULz_XMRkvD_zdROCVMDf0XbGI=.3f55530b-2a02-4d7e-a5bc-970b1c05d794@github.com>

On Wed, 22 Dec 2021 19:15:50 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

>> Signed-off-by: Patrick Reinhart <patrick at reini.net>
>
> Patrick Reinhart has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/324

From reinhapa at openjdk.java.net  Thu Dec 23 16:23:17 2021
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Thu, 23 Dec 2021 16:23:17 GMT
Subject: Integrated: 7432: Update the spotbugs maven plugin
In-Reply-To: <NogwuacUT7-ztkHijbnhluiiz_FDlrP36v9t3ggK0g0=.d3f15cbf-44ea-4f94-b470-8e0c15deba5d@github.com>
References: <NogwuacUT7-ztkHijbnhluiiz_FDlrP36v9t3ggK0g0=.d3f15cbf-44ea-4f94-b470-8e0c15deba5d@github.com>
Message-ID: <i6JYpSah58cxfdTERlAw70y6fhXbsrR7koZhYWN5amo=.08e1dd24-b323-48a6-b59b-e919839f7469@github.com>

On Mon, 18 Oct 2021 16:21:12 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

> Signed-off-by: Patrick Reinhart <patrick at reini.net>

This pull request has now been integrated.

Changeset: ae37757e
Author:    Patrick Reinhart <reinhapa at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/ae37757e6cd68cafbacbe8fda03e5bbb29a726b3
Stats:     114 lines in 5 files changed: 106 ins; 1 del; 7 mod

7432: Update the spotbugs maven plugin

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/324

From jpbempel at openjdk.java.net  Wed Dec 29 16:52:38 2021
From: jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Wed, 29 Dec 2021 16:52:38 GMT
Subject: RFR: 7482: Confusing display of stack traces when selecting event
 types with no events
Message-ID: <g3okfxG-AECC_KiMiPJUK-86qDiL8W1g9fycunp9oXM=.63c9157c-5b73-4d09-a25d-617ed97a56a6@github.com>

?th no events

In EventBrowser page, when there is no selection all events are
considered but if there is a selection we filtered events based on
this selection event if there is no events

-------------

Commit messages:
 - 7482: Confusing display of stack traces when selecting event types with no events

Changes: https://git.openjdk.java.net/jmc/pull/344/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=344&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7482
  Stats: 29 lines in 2 files changed: 28 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/344.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/344/head:pull/344

PR: https://git.openjdk.java.net/jmc/pull/344

From jpbempel at openjdk.java.net  Wed Dec 29 21:26:20 2021
From: jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Wed, 29 Dec 2021 21:26:20 GMT
Subject: RFR: 7439: Introduced IConstantPoolExtension for Constant Pools
 [v6]
In-Reply-To: <IFFEOXHsROnNc9MbR_ULppUzr0GnRQE69UP2ZA-TghE=.7849d5da-2a7d-4d08-9f63-e104ddc9d0ad@github.com>
References: <yr6Hwt8RLp5vDKKxZNrB55aBiyZaP00et_A_BsBw6Dc=.32b3e0bd-ffdb-4a43-8020-c0305d586a52@github.com>
 <IFFEOXHsROnNc9MbR_ULppUzr0GnRQE69UP2ZA-TghE=.7849d5da-2a7d-4d08-9f63-e104ddc9d0ad@github.com>
Message-ID: <sd2T8w8yxy7TlvtA9kPvceJQjxVsyeBIleNH5bD5TDU=.cf4f7bb9-cb1a-4a13-85fe-012b0d07691e@github.com>

On Fri, 26 Nov 2021 20:46:41 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

>> Add extension methods when constants are read, referenced, resolved, constant pools fully resolved and parsing finished to be able for example:
>> 
>>  * track constant pool usage inside events
>>  * replace or translate symbols, method names, etc... like
>> de-obfuscations of stack traces
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove unused import

is your stacktrace for the error similar to:

java.lang.StringIndexOutOfBoundsException: String index out of range: -11
        at java.base/java.lang.String.substring(String.java:1841)
        at org.openjdk.jmc.flightrecorder.internal.parser.v1.StructTypes$JfrJavaClass.convertNames(StructTypes.java:331)
        at org.openjdk.jmc.flightrecorder.internal.parser.v1.StructTypes$JfrJavaClass.getFullName(StructTypes.java:315)
        at org.openjdk.jmc.flightrecorder.internal.parser.v1.StructTypes$JfrJavaClass.hashCode(StructTypes.java:341)
        at java.base/java.util.Objects.hashCode(Objects.java:116)
        at org.openjdk.jmc.flightrecorder.internal.parser.v1.StructTypes$JfrMethod.hashCode(StructTypes.java:625)
        at org.openjdk.jmc.flightrecorder.stacktrace.graph.AggregatableFrame.hashCode(AggregatableFrame.java:90)
        at java.base/java.util.HashMap.hash(HashMap.java:339)
        at java.base/java.util.HashMap.get(HashMap.java:552)

?
in that case it's because you have changed the class name but not the package name associated. 
Then when referencing a class or a method, package name & class name are not the same, which is not expected.

in your example to fix the issue:


    private static Deobfuscator createFooDeobfuscator() {
    	Map<String, String> obfuscatorClassMap = new HashMap<String, String>();  // obfuscated class -> class
    	obfuscatorClassMap.put("se/hirt/jmc/tutorial/hotmethods/HotMethods", "de/docware/ms/foo/Foo");
		Map<String, String> obfuscatorPackageMap = new HashMap<String, String>();  // obfuscated package -> package
+++             obfuscatorPackageMap.put("se/hirt/jmc/tutorial/hotmethods", "de/docware/ms/foo");
		Map<String, Map<String, String>> obfuscatorClassMethodsMap = new HashMap<String, Map<String, String>>();  // (class, obfuscated method) -> method
    	return new Deobfuscator(obfuscatorClassMap, obfuscatorPackageMap, obfuscatorClassMethodsMap);
    }

-------------

PR: https://git.openjdk.java.net/jmc/pull/333