From schaturvedi at openjdk.java.net  Tue Feb  1 07:22:15 2022
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Tue, 1 Feb 2022 07:22:15 GMT
Subject: RFR: 7467: Only use one version of d3
In-Reply-To: <jKjQuTHdTe_Fk5eCo5Rjx7Mjf1ZWHDfo9s3l-mMtc50=.458a67e7-e369-4e80-baab-45cab71e2b36@github.com>
References: <jKjQuTHdTe_Fk5eCo5Rjx7Mjf1ZWHDfo9s3l-mMtc50=.458a67e7-e369-4e80-baab-45cab71e2b36@github.com>
Message-ID: <hPaqSzW7efNpEjp5b0wZCVKH_BTjVumNvx8YcMDcAuw=.c733bf7f-8122-4c63-97d3-6d356659083e@github.com>

On Mon, 31 Jan 2022 13:33:26 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Updating v5 to v6.

pom.xml line 62 <id>d3-v5-js</id> should be changed to <id>d3-v6-js</id> I guess.

-------------

PR: https://git.openjdk.java.net/jmc/pull/372

From hirt at openjdk.java.net  Tue Feb  1 12:04:55 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 1 Feb 2022 12:04:55 GMT
Subject: RFR: 7467: Only use one version of d3 [v2]
In-Reply-To: <jKjQuTHdTe_Fk5eCo5Rjx7Mjf1ZWHDfo9s3l-mMtc50=.458a67e7-e369-4e80-baab-45cab71e2b36@github.com>
References: <jKjQuTHdTe_Fk5eCo5Rjx7Mjf1ZWHDfo9s3l-mMtc50=.458a67e7-e369-4e80-baab-45cab71e2b36@github.com>
Message-ID: <tb4i3j8k9P7dygcBH1QrbY1rItMmTavt-rYRe3C0Cco=.ec0cf3b0-e476-4df8-89ce-7af755f85c37@github.com>

> Updating v5 to v6.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Better execution ids

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/372/files
  - new: https://git.openjdk.java.net/jmc/pull/372/files/4258ca8b..6417a075

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=372&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=372&range=00-01

  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jmc/pull/372.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/372/head:pull/372

PR: https://git.openjdk.java.net/jmc/pull/372

From duke at openjdk.java.net  Tue Feb  1 15:24:49 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Tue, 1 Feb 2022 15:24:49 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v8]
In-Reply-To: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
Message-ID: <gSPlKpKM_gn6jqQ_Pa6VSTKbnjlZdxZyS7rhxThI6IE=.21682ad4-235f-41d8-8fb0-b11dc24769d1@github.com>

> Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64.

Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:

  Improve devguide

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/363/files
  - new: https://git.openjdk.java.net/jmc/pull/363/files/db52a27b..df9b3ae1

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=07
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=06-07

  Stats: 7 lines in 1 file changed: 4 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jmc/pull/363.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/363/head:pull/363

PR: https://git.openjdk.java.net/jmc/pull/363

From duke at openjdk.java.net  Tue Feb  1 16:00:56 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Tue, 1 Feb 2022 16:00:56 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v9]
In-Reply-To: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
Message-ID: <HUwjVkqe-wu6JBAuAJpTLiad1u8IMeAZIVLtEVxIZA8=.b8833f2f-508a-47ad-b3ac-65b7ea03315f@github.com>

> Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64.

Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:

  Mention JVMKeepAlive
  
  Using a predefinied launcher does not work properly (in my setting)

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/363/files
  - new: https://git.openjdk.java.net/jmc/pull/363/files/df9b3ae1..386208c5

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=08
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=07-08

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/363.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/363/head:pull/363

PR: https://git.openjdk.java.net/jmc/pull/363

From duke at openjdk.java.net  Tue Feb  1 19:52:46 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Tue, 1 Feb 2022 19:52:46 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v10]
In-Reply-To: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
Message-ID: <XCw8dOSCSkEfvss8iCCNNF8mls7K9zb3ud1ZzUK9sDE=.a5c467ea-ed13-4bb3-8319-6504fe2d4211@github.com>

> Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64.

Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:

  Fix PropertyContentBuilderTest
  
  Related to differences in events between JDK11 and later JDKs

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/363/files
  - new: https://git.openjdk.java.net/jmc/pull/363/files/386208c5..6855bb23

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=09
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=08-09

  Stats: 46 lines in 2 files changed: 33 ins; 0 del; 13 mod
  Patch: https://git.openjdk.java.net/jmc/pull/363.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/363/head:pull/363

PR: https://git.openjdk.java.net/jmc/pull/363

From duke at openjdk.java.net  Wed Feb  2 08:09:54 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Wed, 2 Feb 2022 08:09:54 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v11]
In-Reply-To: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
Message-ID: <x4pzcegNwtT-aVxs2V2htYEb6piasekmYP-_jb5qFVU=.50d2b22b-5f66-4533-a3db-a73c66951abf@github.com>

> Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64.

Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:

  Improve GitHub actions

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/363/files
  - new: https://git.openjdk.java.net/jmc/pull/363/files/6855bb23..a61d516d

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=10
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=09-10

  Stats: 30 lines in 1 file changed: 1 ins; 27 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/363.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/363/head:pull/363

PR: https://git.openjdk.java.net/jmc/pull/363

From duke at openjdk.java.net  Wed Feb  2 08:20:56 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Wed, 2 Feb 2022 08:20:56 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v12]
In-Reply-To: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
Message-ID: <J7HBouizLm13YrzUeWyAIZuZHoYBcVF_Djj3i4zvi0E=.82307ebc-1a88-4078-8569-a0a7bab0440b@github.com>

> Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64.

Johannes Bechberger has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  Improve GitHub actions

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/363/files
  - new: https://git.openjdk.java.net/jmc/pull/363/files/a61d516d..53da0254

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=11
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=10-11

  Stats: 9 lines in 1 file changed: 2 ins; 0 del; 7 mod
  Patch: https://git.openjdk.java.net/jmc/pull/363.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/363/head:pull/363

PR: https://git.openjdk.java.net/jmc/pull/363

From duke at openjdk.java.net  Wed Feb  2 08:26:44 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Wed, 2 Feb 2022 08:26:44 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v13]
In-Reply-To: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
Message-ID: <_1GSB41JIGJd_NgU9yDILWOVCX2nBYPa6FOVhiPaYuU=.8aea3191-6776-479c-ab53-f597a59ed292@github.com>

> Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64.

Johannes Bechberger has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  Improve GitHub actions

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/363/files
  - new: https://git.openjdk.java.net/jmc/pull/363/files/53da0254..15da0d18

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=12
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=11-12

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/363.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/363/head:pull/363

PR: https://git.openjdk.java.net/jmc/pull/363

From duke at openjdk.java.net  Wed Feb  2 08:26:47 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Wed, 2 Feb 2022 08:26:47 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v12]
In-Reply-To: <J7HBouizLm13YrzUeWyAIZuZHoYBcVF_Djj3i4zvi0E=.82307ebc-1a88-4078-8569-a0a7bab0440b@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
 <J7HBouizLm13YrzUeWyAIZuZHoYBcVF_Djj3i4zvi0E=.82307ebc-1a88-4078-8569-a0a7bab0440b@github.com>
Message-ID: <7MVGov635RZJPTxyFvdm33FDbf9CEc5KnxXp1fAU3m4=.a2c0ed89-e371-4131-b0d6-7e7e427c72a5@github.com>

On Wed, 2 Feb 2022 08:20:56 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64.
>
> Johannes Bechberger has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Improve GitHub actions

The test are running on my machine, so hopefully they run in the CI as well.

-------------

PR: https://git.openjdk.java.net/jmc/pull/363

From duke at openjdk.java.net  Wed Feb  2 08:26:49 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Wed, 2 Feb 2022 08:26:49 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v7]
In-Reply-To: <ry9GBCJE0BsLj4nABh0-YuA2YyA-HXTzv8AsN4_Igho=.a54509f9-efc7-487f-a1ff-3b6776b5f6c4@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
 <DQNDWqkJ0SzVhrJNOtI-_7gQ3TjWy6XZxwlT2XV8kYg=.1b187e55-55db-4d6a-8277-0bca86726524@github.com>
 <v_de4jQ_Fva_2hJVL5mnFJlCDZEV5QrWQ5aGFpAcstM=.d593b8fb-ab68-44af-abcc-c0d869b842b2@github.com>
 <ry9GBCJE0BsLj4nABh0-YuA2YyA-HXTzv8AsN4_Igho=.a54509f9-efc7-487f-a1ff-3b6776b5f6c4@github.com>
Message-ID: <X4LkB22FEudsViNHJQqmMMkv_Enys5aRel9eyhxuigY=.dc97bfe3-06c6-4fea-893c-19b3456b93cf@github.com>

On Tue, 25 Jan 2022 10:44:12 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> .github/workflows/validate.yml line 15:
>> 
>>> 13:     - uses: actions/setup-java at v1
>>> 14:       with:
>>> 15:         java-version: {{ matrix.jdk }}
>> 
>> Did you see that the workflow seems to have some issues still? (https://github.com/parttimenerd/jmc/actions/runs/1728551346)
>
> I did not. But I consider working on this when I'm able to run successfully run all tests.

As a side note: the syntax is `${{ matrix.jdk }}` :)

-------------

PR: https://git.openjdk.java.net/jmc/pull/363

From clanger at openjdk.java.net  Wed Feb  2 09:32:15 2022
From: clanger at openjdk.java.net (Christoph Langer)
Date: Wed, 2 Feb 2022 09:32:15 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v13]
In-Reply-To: <_1GSB41JIGJd_NgU9yDILWOVCX2nBYPa6FOVhiPaYuU=.8aea3191-6776-479c-ab53-f597a59ed292@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
 <_1GSB41JIGJd_NgU9yDILWOVCX2nBYPa6FOVhiPaYuU=.8aea3191-6776-479c-ab53-f597a59ed292@github.com>
Message-ID: <v7PIEYz2vSZep7hgII6kJw3qPAMNSBEhCWfOd3zVIzQ=.a0200e40-af2d-44ef-9db0-9505daabfbf5@github.com>

On Wed, 2 Feb 2022 08:26:44 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64.
>
> Johannes Bechberger has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Improve GitHub actions

Cool, I will test and review this later. One question beforehand: Is tycho 2.6.0 available now? And if yes, did you test whether it changes something regarding the build peculiarities?

-------------

PR: https://git.openjdk.java.net/jmc/pull/363

From duke at openjdk.java.net  Wed Feb  2 09:54:15 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Wed, 2 Feb 2022 09:54:15 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v13]
In-Reply-To: <JOXv8C_qzcXJGrbBlZgQw-uH76xwfEP6LsJjHUICcHw=.a0143362-a7fd-450b-81a4-3c1b049939a9@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
 <PIqGicQrNln-OCKZmfUQaM0TqdYfpXxZGHGNCCKGUbA=.5bc9cdc3-aebd-4196-ac4e-cd3f371582f2@github.com>
 <wdxYjAMJCgw3nL2ZGEKtHuzu4Dk6hKNQiYOiI_Z5hMw=.6c7e8fec-cec1-4f3c-9dfe-a6bf2363d18b@github.com>
 <EhxvkglRaaYBBX2CCoWZO9enN_qg8zmKWsf59P41Q9M=.b2a759fc-150c-468c-899d-fa04d006e026@github.com>
 <onoqlPTsfyqhrzDJbCzwfHf1Vfs0DRpnUB6hFVetQdY=.a0b622d1-ebf3-468a-9dde-b374ed848d00@github.com>
 <IjrIeH20Fs1pD8IO0wmB5K1jV7YNQ5BCAS_xC4dGbo0=.ac1b9c16-7b29-45e8-9d58-99bb59c71c0d@github.com>
 <XH20E9JIu3Bjq1Rdr-83m4wlUolodJot8WtOBpjLocM=.36c0b8a4-b854-430d-b3b8-ad716520db56@github.com>
 <VEdaMf0wg7BHSBi8D74tPsmbshC2ziLB_js9Z3oSzDg=.dc3dec42-4bab-4d8f-bc24-b83794cde4b5@github.com>
 <Y-Pp7fWsAdnKNlYhsnh93l1p5r2wT-kM-P_RW5nnwPU=.b59f8003-12a8-4941-8cbb-45c819a58989@github.com>
 <KWDlkx1pRbmf3MB0r0wKXVhbQoBRAx5UBak-Nc7SajQ=.cd0ab07f-04f4-49ed-83d1-5ddc488b1482@github.com>
 <JOXv8C_qzcXJGrbBlZgQw-uH76xwfEP6LsJ
 jHUICcHw=.a0143362-a7fd-450b-81a4-3c1b049939a9@github.com>
Message-ID: <Uxt9wloxcjIYNUWKhDHBoAtSwG9yY5is8N7mBK4Tv-k=.7eb5aa0c-3b71-4734-8130-eddd2f5d4c48@github.com>

On Fri, 21 Jan 2022 16:50:12 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> I don't think that's possible, tycho overrides many aspects of maven, typicaly for the compiler the tycho _overlay_ will get depdencies from other tycho plugin, not from maven APIs.
>
> Yup, you're right. I figured that out. I guess we have to live with the workaround. We can try once again with tycho 2.6.0 which should be out really soon. But if that doesn't change a thing we can only open an issue with tycho.

The problem persists with tycho 2.6.0.

-------------

PR: https://git.openjdk.java.net/jmc/pull/363

From duke at openjdk.java.net  Wed Feb  2 09:54:14 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Wed, 2 Feb 2022 09:54:14 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v13]
In-Reply-To: <_1GSB41JIGJd_NgU9yDILWOVCX2nBYPa6FOVhiPaYuU=.8aea3191-6776-479c-ab53-f597a59ed292@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
 <_1GSB41JIGJd_NgU9yDILWOVCX2nBYPa6FOVhiPaYuU=.8aea3191-6776-479c-ab53-f597a59ed292@github.com>
Message-ID: <QTVVJX6rR2_5sx-vrzVs1P5yQG8XZdZJZYHvZOfpAx8=.ca13cc35-d9be-42cf-92da-78dcf9a4bf80@github.com>

On Wed, 2 Feb 2022 08:26:44 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64.
>
> Johannes Bechberger has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Improve GitHub actions

Tycho 2.6.0 is available but it does not change anything.

-------------

PR: https://git.openjdk.java.net/jmc/pull/363

From aptmac at openjdk.java.net  Wed Feb  2 15:51:14 2022
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Wed, 2 Feb 2022 15:51:14 GMT
Subject: RFR: 7538: Check in launcher for JVMKeepAlive
In-Reply-To: <yDJh1IreuieGCRRtOSF4mrgurEc2cw3IYBw4FqdJ1bM=.11376e1c-d7f4-4984-a7de-0902ebb21cc1@github.com>
References: <yDJh1IreuieGCRRtOSF4mrgurEc2cw3IYBw4FqdJ1bM=.11376e1c-d7f4-4984-a7de-0902ebb21cc1@github.com>
Message-ID: <o96jpy6zJ3MLCaRYvoQ645QXenyxr-EAHBI-50hFkdM=.b7795ceb-a5f9-4055-98f9-f16fa59e0aad@github.com>

On Fri, 21 Jan 2022 11:54:10 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Helpful for new developers.

Marked as reviewed by aptmac (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/368

From aptmac at openjdk.java.net  Wed Feb  2 16:30:16 2022
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Wed, 2 Feb 2022 16:30:16 GMT
Subject: RFR: 7420: Update Japanese translation for rules [v2]
In-Reply-To: <ZvXz35qApiWWfPY0R8ctJu_H8gn5m8E8OofXijVjlxA=.bb757a5d-c017-4882-a19a-755f0738fa08@github.com>
References: <_3eRPXBrbMr6uVo3lMVwefLwCSLj9Y_hnR21yY0T_vI=.a76a0f72-cb79-4fa9-921b-63d12432b8f4@github.com>
 <ZvXz35qApiWWfPY0R8ctJu_H8gn5m8E8OofXijVjlxA=.bb757a5d-c017-4882-a19a-755f0738fa08@github.com>
Message-ID: <H_hCw1J4lsbRHUp_EmTZpx7pBBzWKa2qjhQpQz1sS7o=.ebfc892f-68c1-4a0e-b863-1c48933e032c@github.com>

On Sat, 22 Jan 2022 01:07:52 GMT, mohno007 <duke at openjdk.java.net> wrote:

>> This PR updates/improves Japanese translation of rules and its descriptions.
>> 
>> ## Update
>> 
>> * Update texts based on new commits to `messages.properties` made after the last update date of the `messages_ja.properties`.
>> 	* Support a new placeholder format introduced in `Rule 2.0`.
>> 	* Use Markdown style link.
>> 	* Add translations for newly added texts.
>> * Update texts for translation correctness and understandability.
>> 	* Fix some wordings for understandability. Especially usage of Japanese particle.
>> 	* Add [Japanese counter word (???)](https://en.wikipedia.org/wiki/Japanese_counter_word) for numeric value.
>> 
>> You can see decoded version of `messages_ja` using this script:
>> 
>> 
>> native2ascii -reverse core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages_ja.properties
>
> mohno007 has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update copyright year

Marked as reviewed by aptmac (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/308

From hirt at openjdk.java.net  Wed Feb  2 17:15:17 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 2 Feb 2022 17:15:17 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v13]
In-Reply-To: <_1GSB41JIGJd_NgU9yDILWOVCX2nBYPa6FOVhiPaYuU=.8aea3191-6776-479c-ab53-f597a59ed292@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
 <_1GSB41JIGJd_NgU9yDILWOVCX2nBYPa6FOVhiPaYuU=.8aea3191-6776-479c-ab53-f597a59ed292@github.com>
Message-ID: <QYxpI3xbwI8hBzsSsi9Y8gZjowKrr94Xwc6tjfWXPP0=.b5d00c3e-5521-4485-9823-5ef742943540@github.com>

On Wed, 2 Feb 2022 08:26:44 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64.
>
> Johannes Bechberger has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Improve GitHub actions

application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/src/test/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/test/PropertyContentBuilderTest.java line 341:

> 339: 			if (!pathElement.getName().equals("jdk")) {
> 340: 				// jdk named root nodes are related to nodes that are not supported in newer
> 341: 				// JDKs

Funny formatting in this comment. Any chance you could bring up the third line?

-------------

PR: https://git.openjdk.java.net/jmc/pull/363

From hirt at openjdk.java.net  Wed Feb  2 17:37:11 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 2 Feb 2022 17:37:11 GMT
Subject: RFR: 7420: Update Japanese translation for rules [v2]
In-Reply-To: <3ifh0-pAlumb7yhlLu69TFfHtugMssKOKaK45-kVYnM=.2dc2c912-5556-4827-971c-3fcd4575db01@github.com>
References: <_3eRPXBrbMr6uVo3lMVwefLwCSLj9Y_hnR21yY0T_vI=.a76a0f72-cb79-4fa9-921b-63d12432b8f4@github.com>
 <ZvXz35qApiWWfPY0R8ctJu_H8gn5m8E8OofXijVjlxA=.bb757a5d-c017-4882-a19a-755f0738fa08@github.com>
 <3ifh0-pAlumb7yhlLu69TFfHtugMssKOKaK45-kVYnM=.2dc2c912-5556-4827-971c-3fcd4575db01@github.com>
Message-ID: <9pIFc1CeMtJnjkVqIY0hoOS91S6lj4IZOQYie2SreC0=.131509c8-3ca9-4899-83f3-5d7d3db07fbc@github.com>

On Sat, 22 Jan 2022 01:11:34 GMT, mohno007 <duke at openjdk.java.net> wrote:

>> mohno007 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update copyright year
>
> As you may know, I can sign the OCA.
> Thank you to the developers for your patience.
> Thank you to Dalibor-san and OCA support for resolving the issue.

Hi @mohno007! This PR is ready for integration! Please type /integrate in a new comment.

-------------

PR: https://git.openjdk.java.net/jmc/pull/308

From duke at openjdk.java.net  Thu Feb  3 08:18:04 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Thu, 3 Feb 2022 08:18:04 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v14]
In-Reply-To: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
Message-ID: <P0aqSW5p50rdkPMHpa_Ydxy269HXHvDqkK9jlP6Mcus=.5074e1a7-2281-4336-b941-71d68ad9fce4@github.com>

> Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64.

Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:

  Fix formatting

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/363/files
  - new: https://git.openjdk.java.net/jmc/pull/363/files/15da0d18..d7ca9343

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=13
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=12-13

  Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/363.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/363/head:pull/363

PR: https://git.openjdk.java.net/jmc/pull/363

From duke at openjdk.java.net  Thu Feb  3 09:36:11 2022
From: duke at openjdk.java.net (Brice Dutheil)
Date: Thu, 3 Feb 2022 09:36:11 GMT
Subject: RFR: 7467: Only use one version of d3 [v2]
In-Reply-To: <tb4i3j8k9P7dygcBH1QrbY1rItMmTavt-rYRe3C0Cco=.ec0cf3b0-e476-4df8-89ce-7af755f85c37@github.com>
References: <jKjQuTHdTe_Fk5eCo5Rjx7Mjf1ZWHDfo9s3l-mMtc50=.458a67e7-e369-4e80-baab-45cab71e2b36@github.com>
 <tb4i3j8k9P7dygcBH1QrbY1rItMmTavt-rYRe3C0Cco=.ec0cf3b0-e476-4df8-89ce-7af755f85c37@github.com>
Message-ID: <Oml4PjtAqK1yx540nnENGLxl4smK3ZtdLeOyc7_KC7o=.aa121cc5-3dfc-4a91-ba3b-a680cd10cca2@github.com>

On Tue, 1 Feb 2022 12:04:55 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Updating v5 to v6.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Better execution ids

Marked as reviewed by bric3 at github.com (no known OpenJDK username).

application/org.openjdk.jmc.flightrecorder.graphview/pom.xml line 68:

> 66: 						</goals>
> 67: 						<configuration>
> 68: 							<url>https://d3js.org/d3.v6.min.js</url>

Maybe put this in a property

application/org.openjdk.jmc.flightrecorder.graphview/src/main/java/org/openjdk/jmc/flightrecorder/graphview/views/GraphView.java line 89:

> 87: 	private static final String HTML_PAGE;
> 88: 	static {
> 89: 		String jsD3 = "jslibs/d3.v6.min.js";

I wonder if we can rename the js lib to avoid code modification. And only update the pom when changing version.

-------------

PR: https://git.openjdk.java.net/jmc/pull/372

From hirt at openjdk.java.net  Thu Feb  3 11:58:11 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 3 Feb 2022 11:58:11 GMT
Subject: RFR: 7467: Only use one version of d3 [v2]
In-Reply-To: <Oml4PjtAqK1yx540nnENGLxl4smK3ZtdLeOyc7_KC7o=.aa121cc5-3dfc-4a91-ba3b-a680cd10cca2@github.com>
References: <jKjQuTHdTe_Fk5eCo5Rjx7Mjf1ZWHDfo9s3l-mMtc50=.458a67e7-e369-4e80-baab-45cab71e2b36@github.com>
 <tb4i3j8k9P7dygcBH1QrbY1rItMmTavt-rYRe3C0Cco=.ec0cf3b0-e476-4df8-89ce-7af755f85c37@github.com>
 <Oml4PjtAqK1yx540nnENGLxl4smK3ZtdLeOyc7_KC7o=.aa121cc5-3dfc-4a91-ba3b-a680cd10cca2@github.com>
Message-ID: <9vKqCqtEPD-wJjkBVsS5v8n7VUaVGq3oleqN0aVlyck=.79e458c3-7211-470c-a47b-cc02fe9aa183@github.com>

On Thu, 3 Feb 2022 09:30:43 GMT, Brice Dutheil <duke at openjdk.java.net> wrote:

>> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Better execution ids
>
> application/org.openjdk.jmc.flightrecorder.graphview/pom.xml line 68:
> 
>> 66: 						</goals>
>> 67: 						<configuration>
>> 68: 							<url>https://d3js.org/d3.v6.min.js</url>
> 
> Maybe put this in a property

Smallest possible changes this close to release.

> application/org.openjdk.jmc.flightrecorder.graphview/src/main/java/org/openjdk/jmc/flightrecorder/graphview/views/GraphView.java line 89:
> 
>> 87: 	private static final String HTML_PAGE;
>> 88: 	static {
>> 89: 		String jsD3 = "jslibs/d3.v6.min.js";
> 
> I wonder if we can rename the js lib to avoid code modification. And only update the pom when changing version.

That's a good idea! Feel free to open a separate PR for this.

-------------

PR: https://git.openjdk.java.net/jmc/pull/372

From aptmac at openjdk.java.net  Thu Feb  3 16:03:42 2022
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Thu, 3 Feb 2022 16:03:42 GMT
Subject: RFR: 7307: Move org.openjdk.jmc.flightrecorder.configuration
 bundle from application to core [v4]
In-Reply-To: <L7gWCRuM7LXgjuNh3ENuHOJgxqXdJPcv3O0FQKCVZts=.589c3b2f-1fa5-4e7f-94d5-c1c896fd7880@github.com>
References: <L7gWCRuM7LXgjuNh3ENuHOJgxqXdJPcv3O0FQKCVZts=.589c3b2f-1fa5-4e7f-94d5-c1c896fd7880@github.com>
Message-ID: <znpj7QEcNO_oc00QoMqkzkrhr6QYJcoAWWvrauEMq9c=.d0c12f97-cdbe-48e8-ad88-b0870a3937d9@github.com>

> This PR addresses JMC-7307 [[0]](https://bugs.openjdk.java.net/browse/JMC-7307), in which it would be helpful to have `flightrecorder.configuration` distributed in jmc core.
> 
> `flightrecorder.configuration` itself is a pretty straightforward movement of code, as it doesn't have any dependencies. Having said that, there are some flightrecorder-configuration-related classes in `controlpanel.ui` which would be nice to have in core as well, and would probably do well in `flightrecorder.configuration`. This includes VolatileStorageDelegate, and the 12 classes in `configuration.model.xml`. The `controlpanel.ui.configuration` unit tests can also come over to core, because they only tested the model xml code anyways.
> 
> So in total, we're looking at `flightrecorder.configuration` and the former `controlpanel.ui.configuration` test coming over to core, and the following classes:
> - org.openjdk.jmc.flightrecorder.configuration.model.VolatileStorageDelegate
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.IXMLValidator
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.JFCGrammar
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.JFCXMLValidator
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.PrettyPrinter
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLAttribute
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLAttributeInstance
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLModel
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLNode
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLNodeType
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLTag
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLTagInstance
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLValidationResult
> 
> [0] https://bugs.openjdk.java.net/browse/JMC-7307

Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:

 - update license headers to 2022
 - fix package name in JFCXMLValidator logger
 - re-order flightrecorder.configuration.test in test pom
 - update license headers
 - migrate VolatileStorageDelegate to flightrecorder.configuration.model
 - revert .classpath files to their original from application
 - minor cleanup
 - move configuration.model.xml test from application to core; remove controlpanel.ui.configuration.test
   
   The controlpanel.ui.configuration only had the XML test, which is now
   located in flightrecorder.configuration.test in core. Currently all
   tests in both core and application will pass.
 - move flightrecorder.configuration coverage from application to core
 - temporarily silence test modules that are moved, will cleanup after
 - ... and 2 more: https://git.openjdk.java.net/jmc/compare/9ec05b30...511343e1

-------------

Changes: https://git.openjdk.java.net/jmc/pull/299/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=299&range=03
  Stats: 1009 lines in 99 files changed: 373 ins; 475 del; 161 mod
  Patch: https://git.openjdk.java.net/jmc/pull/299.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/299/head:pull/299

PR: https://git.openjdk.java.net/jmc/pull/299

From hirt at openjdk.java.net  Thu Feb  3 16:42:19 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 3 Feb 2022 16:42:19 GMT
Subject: RFR: 7420: Update Japanese translation for rules [v2]
In-Reply-To: <3ifh0-pAlumb7yhlLu69TFfHtugMssKOKaK45-kVYnM=.2dc2c912-5556-4827-971c-3fcd4575db01@github.com>
References: <_3eRPXBrbMr6uVo3lMVwefLwCSLj9Y_hnR21yY0T_vI=.a76a0f72-cb79-4fa9-921b-63d12432b8f4@github.com>
 <ZvXz35qApiWWfPY0R8ctJu_H8gn5m8E8OofXijVjlxA=.bb757a5d-c017-4882-a19a-755f0738fa08@github.com>
 <3ifh0-pAlumb7yhlLu69TFfHtugMssKOKaK45-kVYnM=.2dc2c912-5556-4827-971c-3fcd4575db01@github.com>
Message-ID: <Zt3TkK6Bttlnh0rmJgANKx39QlJL-fjrsKwUdsqBMxA=.42d130ea-a239-4f53-acd1-0f14e9619dd7@github.com>

On Sat, 22 Jan 2022 01:11:34 GMT, mohno007 <duke at openjdk.java.net> wrote:

>> mohno007 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update copyright year
>
> As you may know, I can sign the OCA.
> Thank you to the developers for your patience.
> Thank you to Dalibor-san and OCA support for resolving the issue.

Also - @mohno007, are you in the JMC dev slack? If not, would you like to be? Please ping me, and I'd be happy to invite you.

-------------

PR: https://git.openjdk.java.net/jmc/pull/308

From aptmac at openjdk.java.net  Thu Feb  3 16:42:44 2022
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Thu, 3 Feb 2022 16:42:44 GMT
Subject: RFR: 7308: Move non-Eclipse dependant classes from
 org.openjdk.jmc.ui.common to org.openjdk.jmc.common [v2]
In-Reply-To: <mP3keEeqtNDRTukWKvFdf9T0AS68bTnx94d1wDMA79k=.af5bb961-4fc5-4ab7-a4b9-fa4fc14f46cf@github.com>
References: <mP3keEeqtNDRTukWKvFdf9T0AS68bTnx94d1wDMA79k=.af5bb961-4fc5-4ab7-a4b9-fa4fc14f46cf@github.com>
Message-ID: <MAH_7N8CiiAUTZFCsWus501UEP2n1db6wjnBzn-GFew=.906fb300-4828-415e-9808-b68213261196@github.com>

> This PR addresses JMC-7308 [[0]](https://bugs.openjdk.java.net/browse/JMC-7308), in which it would be helpful to have some of the classes currently in jmc.ui.common shipped in core.
> 
> There are a number of classes currently in jmc.ui.common that would be a great asset to the core distribution (and the third-party applications that consume jmc-core), and these classes could live in jmc.common.
> 
> It isn't as straightforward as moving all of the packages to core, as there are still classes in these jmc.ui.common packages that have dependencies on Eclipse or rjmx. Having said that, the ones listed below can be moved without much difficulty:
> 
> - org.openjdk.jmc.ui.common.action (3)
>     Executable, IActionProvider, IUserAction
> 
> - org.openjdk.jmc.ui.common.jvm (5)
>     Connectable, JVMArch, JVMCommandLineToolkit, JVMDescriptor, JVMType
> 
> - org.openjdk.jmc.ui.common.resource (2)
>     IImageResource, Resource
> 
> - org.openjdk.jmc.ui.common.security (10)
>     ActionNotGrantedException, CredentialsNotAvailableException, FailedToSaveException, ICredentials, InMemoryCredentials, ISecurityManager, PersistentCredentials, SecurlyStoredByteArray, SecurityException, SecurityManagerFactory
> 
> - org.opendjk.jmc.ui.common.tree (3)
>     IArray, IChild, IParent
> 
> - org.openjdk.jmc.ui.common.util (4)
>     Environment, Filename, ICopyable, IObservable
> 
> - org.openjdk.jmc.ui.common.xydata (5)
>     DataSeries, DefautlTimestampedData, DefaultXYData, ITimeStampedData, IXYData
> 
> [0] https://bugs.openjdk.java.net/browse/JMC-7308

Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:

 - update license headers to 2022
 - update license headers
 - update agent plugin imports
 - migrate classes from ui.common.resource to core
 - migrate interfaces from ui.common.action to core
 - migrate most of the remainder from ui.common.security to core
 - migrate ui.common.xydata to core
 - migrate Environment, Filename, ICopyable, and IObservable from ui.common.util to core
 - migrate ui.common.tree to core
 - migrate ui.common.jvm to core
 - ... and 1 more: https://git.openjdk.java.net/jmc/compare/9ec05b30...69aeed33

-------------

Changes: https://git.openjdk.java.net/jmc/pull/300/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=300&range=01
  Stats: 624 lines in 172 files changed: 147 ins; 172 del; 305 mod
  Patch: https://git.openjdk.java.net/jmc/pull/300.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/300/head:pull/300

PR: https://git.openjdk.java.net/jmc/pull/300

From aptmac at openjdk.java.net  Thu Feb  3 17:14:11 2022
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Thu, 3 Feb 2022 17:14:11 GMT
Subject: RFR: 7467: Only use one version of d3 [v2]
In-Reply-To: <tb4i3j8k9P7dygcBH1QrbY1rItMmTavt-rYRe3C0Cco=.ec0cf3b0-e476-4df8-89ce-7af755f85c37@github.com>
References: <jKjQuTHdTe_Fk5eCo5Rjx7Mjf1ZWHDfo9s3l-mMtc50=.458a67e7-e369-4e80-baab-45cab71e2b36@github.com>
 <tb4i3j8k9P7dygcBH1QrbY1rItMmTavt-rYRe3C0Cco=.ec0cf3b0-e476-4df8-89ce-7af755f85c37@github.com>
Message-ID: <jmYc7aJspFx7tRnlsoIcxW3lb-KN70K-6nTw5a4BDyI=.d8e6a731-63db-405e-a44f-bb52fb9c13d8@github.com>

On Tue, 1 Feb 2022 12:04:55 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Updating v5 to v6.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Better execution ids

Marked as reviewed by aptmac (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/372

From hirt at openjdk.java.net  Fri Feb  4 02:46:16 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 4 Feb 2022 02:46:16 GMT
Subject: Integrated: 7467: Only use one version of d3
In-Reply-To: <jKjQuTHdTe_Fk5eCo5Rjx7Mjf1ZWHDfo9s3l-mMtc50=.458a67e7-e369-4e80-baab-45cab71e2b36@github.com>
References: <jKjQuTHdTe_Fk5eCo5Rjx7Mjf1ZWHDfo9s3l-mMtc50=.458a67e7-e369-4e80-baab-45cab71e2b36@github.com>
Message-ID: <ALKWzzfNd2W6A9uTdW_28OUL9I1yFd3l-ztbb3yfiNI=.5dcae116-ba54-4fd4-b6c9-0201394858aa@github.com>

On Mon, 31 Jan 2022 13:33:26 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Updating v5 to v6.

This pull request has now been integrated.

Changeset: 7f42e4a1
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/7f42e4a10291d7e9316711edd81a183951cdae57
Stats:     7 lines in 2 files changed: 0 ins; 0 del; 7 mod

7467: Only use one version of d3

Reviewed-by: aptmac

-------------

PR: https://git.openjdk.java.net/jmc/pull/372

From duke at openjdk.java.net  Sun Feb  6 10:32:39 2022
From: duke at openjdk.java.net (Martin Skarsaune)
Date: Sun, 6 Feb 2022 10:32:39 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v13]
In-Reply-To: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
Message-ID: <Ua8JMxyw7Sya-o1UoEO_Qcpj_0qnK1fAKg4Cl4m0LaI=.51e3713c-b50e-4037-8e05-56e6af6f7a7d@github.com>

> Setting back for review. The azure problem requires a fix in Jolokia.
> 
> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.

Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits:

 - JMC-7455: Remaining OSGi cleanup
 - JMC-7455: Re-export jolokia JMX adapter for simplicity
 - JMC-7455: Use third party to pull inn Jolokia modules
 - Review corrections: Javadoc and refactoring attempt to use local operation info
 - Removed -XstartOnFirstThread as it is not valid for some JVMs
 - Used spotbugs to format more code
 - Used spotbugs to format according to convention
 - json.simple is needed by kubernetes plugin downstream
 - Adding test plugin for Jolokia
 - Revert unwanted change unrelated to new plugins
 - ... and 4 more: https://git.openjdk.java.net/jmc/compare/7f42e4a1...37d06c4e

-------------

Changes: https://git.openjdk.java.net/jmc/pull/332/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=332&range=12
  Stats: 3169 lines in 52 files changed: 3169 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/332.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/332/head:pull/332

PR: https://git.openjdk.java.net/jmc/pull/332

From hirt at openjdk.java.net  Tue Feb  8 16:12:15 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 8 Feb 2022 16:12:15 GMT
Subject: RFR: 7420: Update Japanese translation for rules [v2]
In-Reply-To: <3ifh0-pAlumb7yhlLu69TFfHtugMssKOKaK45-kVYnM=.2dc2c912-5556-4827-971c-3fcd4575db01@github.com>
References: <_3eRPXBrbMr6uVo3lMVwefLwCSLj9Y_hnR21yY0T_vI=.a76a0f72-cb79-4fa9-921b-63d12432b8f4@github.com>
 <ZvXz35qApiWWfPY0R8ctJu_H8gn5m8E8OofXijVjlxA=.bb757a5d-c017-4882-a19a-755f0738fa08@github.com>
 <3ifh0-pAlumb7yhlLu69TFfHtugMssKOKaK45-kVYnM=.2dc2c912-5556-4827-971c-3fcd4575db01@github.com>
Message-ID: <i-6D-Eovv8z_F9YxJkRVid85WHsRYgejl97LymZtwQE=.cba1bdda-3232-4297-8983-a59c167cf638@github.com>

On Sat, 22 Jan 2022 01:11:34 GMT, mohno007 <duke at openjdk.java.net> wrote:

>> mohno007 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update copyright year
>
> As you may know, I can sign the OCA.
> Thank you to the developers for your patience.
> Thank you to Dalibor-san and OCA support for resolving the issue.

Hi @mohno007 - a friendly reminder that this PR is ready for integration! Please write /integrate in a new comment in this PR to integrate.

-------------

PR: https://git.openjdk.java.net/jmc/pull/308

From duke at openjdk.java.net  Wed Feb  9 01:56:31 2022
From: duke at openjdk.java.net (Virag Purnam)
Date: Wed, 9 Feb 2022 01:56:31 GMT
Subject: RFR: 6792: Outline shows as not available when starting up with open
 recording
Message-ID: <PV1ESX8NKTujz66CpKcCl83OB-s-xjx2gMu_C8EmBn0=.06ac72fd-b717-4155-b50a-aee5f9b509f2@github.com>

Problem: On Re-launch of JMC, previously opened JFR gets loaded and shown in JFR editor. But the outline appears blank. Workaround is to click on the JFR Editor. Please refer the attached files.

![OutlineIsBlank](https://user-images.githubusercontent.com/97600378/151947215-0a445f64-f4f8-43bd-9936-11ddf9ad4f66.jpg)

Fix: On Re-launch of JMC, setting the focus on active JFR editor. This solves the problem and outline gets displayed properly.

![OutlineGetsDisplayed](https://user-images.githubusercontent.com/97600378/151947205-25d9d5dd-5256-4f3f-ba97-327b7ea6b406.jpg)

-------------

Commit messages:
 - 6792: Previously opened JFR remains opened in JMC despite graceful relaunch

Changes: https://git.openjdk.java.net/jmc/pull/373/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=373&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6792
  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/373.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/373/head:pull/373

PR: https://git.openjdk.java.net/jmc/pull/373

From hirt at openjdk.java.net  Wed Feb  9 01:56:32 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 9 Feb 2022 01:56:32 GMT
Subject: RFR: 6792: Outline shows as not available when starting up with
 open recording
In-Reply-To: <PV1ESX8NKTujz66CpKcCl83OB-s-xjx2gMu_C8EmBn0=.06ac72fd-b717-4155-b50a-aee5f9b509f2@github.com>
References: <PV1ESX8NKTujz66CpKcCl83OB-s-xjx2gMu_C8EmBn0=.06ac72fd-b717-4155-b50a-aee5f9b509f2@github.com>
Message-ID: <dBJUUwamIdEHDce5EPcgtHRfyaycs_0-gSEfTv6bupk=.c6651e1a-74ef-4f9d-a108-5063ec864f34@github.com>

On Tue, 1 Feb 2022 09:54:52 GMT, Virag Purnam <duke at openjdk.java.net> wrote:

> Problem: On Re-launch of JMC, previously opened JFR gets loaded and shown in JFR editor. But the outline appears blank. Workaround is to click on the JFR Editor. Please refer the attached files.
> 
> ![OutlineIsBlank](https://user-images.githubusercontent.com/97600378/151947215-0a445f64-f4f8-43bd-9936-11ddf9ad4f66.jpg)
> 
> Fix: On Re-launch of JMC, setting the focus on active JFR editor. This solves the problem and outline gets displayed properly.
> 
> ![OutlineGetsDisplayed](https://user-images.githubusercontent.com/97600378/151947205-25d9d5dd-5256-4f3f-ba97-327b7ea6b406.jpg)

Great first PR! This issue has been open for far too long. Thanks Virag!

-------------

Marked as reviewed by hirt (Lead).

PR: https://git.openjdk.java.net/jmc/pull/373

From duke at openjdk.java.net  Wed Feb  9 01:56:33 2022
From: duke at openjdk.java.net (Virag Purnam)
Date: Wed, 9 Feb 2022 01:56:33 GMT
Subject: RFR: 7532: Delay in realtime rendering of graphs  in JMX Console
Message-ID: <0S-tNA5qzHwhlFn4kuHbPhQ7k7yOGJIoO61OhZZEwIs=.68c21194-778b-4f7a-a66e-cb41e874ba7a@github.com>

Issue: Dials and Charts in JMX Console was not rendering with the change. 

<img width="1302" alt="image-2022-01-18-21-36-49-712" src="https://user-images.githubusercontent.com/97600378/152590022-262d4ce1-fe1a-4b52-bb43-d1b61b96d4d0.png">
 
Root cause: Control redraw() method was conditionally called. This method was called for windows and Linux OS. For mac OS, this redraw() method was not called to solve "console dials causing high CPU load on Mac". But because of this rendering was not happening for dials and charts. 
I do not see any high CPU load (May be issue with older versions of OS). Could you please review the changes and let me know if you see any performance issue with this fix (mainly on macOS) ? 

Fix: Control redraw() method has been called for macOS as well.

<img width="928" alt="Fix_7532" src="https://user-images.githubusercontent.com/97600378/152590703-0c385f22-be14-4ad6-b592-927c37fa2385.png">

-------------

Commit messages:
 - 7532: Delay in realtime rending of graphs  in JMX Console
 - 7532: Delay in realtime rending of graphs  in JMX Console

Changes: https://git.openjdk.java.net/jmc/pull/375/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=375&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7532
  Stats: 34 lines in 2 files changed: 0 ins; 24 del; 10 mod
  Patch: https://git.openjdk.java.net/jmc/pull/375.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/375/head:pull/375

PR: https://git.openjdk.java.net/jmc/pull/375

From duke at openjdk.java.net  Wed Feb  9 01:56:34 2022
From: duke at openjdk.java.net (Virag Purnam)
Date: Wed, 9 Feb 2022 01:56:34 GMT
Subject: RFR: 7532: Delay in realtime rendering of graphs  in JMX Console
In-Reply-To: <0S-tNA5qzHwhlFn4kuHbPhQ7k7yOGJIoO61OhZZEwIs=.68c21194-778b-4f7a-a66e-cb41e874ba7a@github.com>
References: <0S-tNA5qzHwhlFn4kuHbPhQ7k7yOGJIoO61OhZZEwIs=.68c21194-778b-4f7a-a66e-cb41e874ba7a@github.com>
Message-ID: <gqbtWAInfAlNHxAxwTdS9WDbgQiLiCHJ9V3NEuim4bQ=.b7278431-59ef-4854-8cdd-07d5f1ee7b5b@github.com>

On Fri, 4 Feb 2022 19:31:30 GMT, Virag Purnam <duke at openjdk.java.net> wrote:

> Issue: Dials and Charts in JMX Console was not rendering with the change. 
> 
> <img width="1302" alt="image-2022-01-18-21-36-49-712" src="https://user-images.githubusercontent.com/97600378/152590022-262d4ce1-fe1a-4b52-bb43-d1b61b96d4d0.png">
>  
> Root cause: Control redraw() method was conditionally called. This method was called for windows and Linux OS. For mac OS, this redraw() method was not called to solve "console dials causing high CPU load on Mac". But because of this rendering was not happening for dials and charts. 
> I do not see any high CPU load (May be issue with older versions of OS). Could you please review the changes and let me know if you see any performance issue with this fix (mainly on macOS) ? 
> 
> Fix: Control redraw() method has been called for macOS as well.
> 
> <img width="928" alt="Fix_7532" src="https://user-images.githubusercontent.com/97600378/152590703-0c385f22-be14-4ad6-b592-927c37fa2385.png">

Fixed the issue reported by spotbug.

-------------

PR: https://git.openjdk.java.net/jmc/pull/375

From aptmac at openjdk.java.net  Wed Feb  9 01:56:32 2022
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Wed, 9 Feb 2022 01:56:32 GMT
Subject: RFR: 6792: Outline shows as not available when starting up with
 open recording
In-Reply-To: <PV1ESX8NKTujz66CpKcCl83OB-s-xjx2gMu_C8EmBn0=.06ac72fd-b717-4155-b50a-aee5f9b509f2@github.com>
References: <PV1ESX8NKTujz66CpKcCl83OB-s-xjx2gMu_C8EmBn0=.06ac72fd-b717-4155-b50a-aee5f9b509f2@github.com>
Message-ID: <UcQbgfhsbEKLSrHOyy5a6TWW9a9W12M8Z1ZDgY7-j9o=.2b88981f-3f12-468b-80d8-f25d3614bee2@github.com>

On Tue, 1 Feb 2022 09:54:52 GMT, Virag Purnam <duke at openjdk.java.net> wrote:

> Problem: On Re-launch of JMC, previously opened JFR gets loaded and shown in JFR editor. But the outline appears blank. Workaround is to click on the JFR Editor. Please refer the attached files.
> 
> ![OutlineIsBlank](https://user-images.githubusercontent.com/97600378/151947215-0a445f64-f4f8-43bd-9936-11ddf9ad4f66.jpg)
> 
> Fix: On Re-launch of JMC, setting the focus on active JFR editor. This solves the problem and outline gets displayed properly.
> 
> ![OutlineGetsDisplayed](https://user-images.githubusercontent.com/97600378/151947205-25d9d5dd-5256-4f3f-ba97-327b7ea6b406.jpg)

Marked as reviewed by aptmac (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/373

From hirt at openjdk.java.net  Wed Feb  9 01:56:36 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 9 Feb 2022 01:56:36 GMT
Subject: RFR: 7532: Delay in realtime rendering of graphs  in JMX Console
In-Reply-To: <0S-tNA5qzHwhlFn4kuHbPhQ7k7yOGJIoO61OhZZEwIs=.68c21194-778b-4f7a-a66e-cb41e874ba7a@github.com>
References: <0S-tNA5qzHwhlFn4kuHbPhQ7k7yOGJIoO61OhZZEwIs=.68c21194-778b-4f7a-a66e-cb41e874ba7a@github.com>
Message-ID: <cFY81Q9CrdKv8pOIKZITpUMWyIFyq_AvSjxJjhIzW3c=.6aee9598-39f4-47b2-b5d7-dc100d8cc49f@github.com>

On Fri, 4 Feb 2022 19:31:30 GMT, Virag Purnam <duke at openjdk.java.net> wrote:

> Issue: Dials and Charts in JMX Console was not rendering with the change. 
> 
> <img width="1302" alt="image-2022-01-18-21-36-49-712" src="https://user-images.githubusercontent.com/97600378/152590022-262d4ce1-fe1a-4b52-bb43-d1b61b96d4d0.png">
>  
> Root cause: Control redraw() method was conditionally called. This method was called for windows and Linux OS. For mac OS, this redraw() method was not called to solve "console dials causing high CPU load on Mac". But because of this rendering was not happening for dials and charts. 
> I do not see any high CPU load (May be issue with older versions of OS). Could you please review the changes and let me know if you see any performance issue with this fix (mainly on macOS) ? 
> 
> Fix: Control redraw() method has been called for macOS as well.
> 
> <img width="928" alt="Fix_7532" src="https://user-images.githubusercontent.com/97600378/152590703-0c385f22-be14-4ad6-b592-927c37fa2385.png">

application/org.openjdk.jmc.greychart.ui/src/main/java/org/openjdk/jmc/greychart/ui/views/ChartComposite.java line 189:

> 187: 			m_chart.setXAxis(m_chart.getXAxis());
> 188: 			redraw();
> 189: 			/*

It seems we can remove the comment and commented code here - explicit calls to update should not be needed.

-------------

PR: https://git.openjdk.java.net/jmc/pull/375

From duke at openjdk.java.net  Wed Feb  9 11:09:17 2022
From: duke at openjdk.java.net (Virag Purnam)
Date: Wed, 9 Feb 2022 11:09:17 GMT
Subject: Integrated: 6792: Outline shows as not available when starting up with
 open recording
In-Reply-To: <PV1ESX8NKTujz66CpKcCl83OB-s-xjx2gMu_C8EmBn0=.06ac72fd-b717-4155-b50a-aee5f9b509f2@github.com>
References: <PV1ESX8NKTujz66CpKcCl83OB-s-xjx2gMu_C8EmBn0=.06ac72fd-b717-4155-b50a-aee5f9b509f2@github.com>
Message-ID: <DQpUehUYSxQKFfmYmVnr6q9-2MsaN7jXOxh9yWnWxDY=.f83d7164-4c11-4108-926c-015b290b057f@github.com>

On Tue, 1 Feb 2022 09:54:52 GMT, Virag Purnam <duke at openjdk.java.net> wrote:

> Problem: On Re-launch of JMC, previously opened JFR gets loaded and shown in JFR editor. But the outline appears blank. Workaround is to click on the JFR Editor. Please refer the attached files.
> 
> ![OutlineIsBlank](https://user-images.githubusercontent.com/97600378/151947215-0a445f64-f4f8-43bd-9936-11ddf9ad4f66.jpg)
> 
> Fix: On Re-launch of JMC, setting the focus on active JFR editor. This solves the problem and outline gets displayed properly.
> 
> ![OutlineGetsDisplayed](https://user-images.githubusercontent.com/97600378/151947205-25d9d5dd-5256-4f3f-ba97-327b7ea6b406.jpg)

This pull request has now been integrated.

Changeset: 5fd290a6
Author:    vpurnam <vpurnam at VPURNAM-7420.in.oracle.com>
Committer: Suchita Chaturvedi <schaturvedi at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/5fd290a6235bc6c86d1c56439c6b052a10eb3a7a
Stats:     2 lines in 1 file changed: 1 ins; 0 del; 1 mod

6792: Outline shows as not available when starting up with open recording

Reviewed-by: hirt, aptmac

-------------

PR: https://git.openjdk.java.net/jmc/pull/373

From duke at openjdk.java.net  Wed Feb  9 11:38:45 2022
From: duke at openjdk.java.net (Virag Purnam)
Date: Wed, 9 Feb 2022 11:38:45 GMT
Subject: RFR: 7532: Delay in realtime rendering of graphs in JMX Console
 [v2]
In-Reply-To: <0S-tNA5qzHwhlFn4kuHbPhQ7k7yOGJIoO61OhZZEwIs=.68c21194-778b-4f7a-a66e-cb41e874ba7a@github.com>
References: <0S-tNA5qzHwhlFn4kuHbPhQ7k7yOGJIoO61OhZZEwIs=.68c21194-778b-4f7a-a66e-cb41e874ba7a@github.com>
Message-ID: <MEOsIfNWTwfzmtT8FW_zaT6UL9QWrchgRtKjKEkZw8g=.e2970997-d65e-4b9f-b3e4-ecfed82405da@github.com>

> Issue: Dials and Charts in JMX Console was not rendering with the change. 
> 
> <img width="1302" alt="image-2022-01-18-21-36-49-712" src="https://user-images.githubusercontent.com/97600378/152590022-262d4ce1-fe1a-4b52-bb43-d1b61b96d4d0.png">
>  
> Root cause: Control redraw() method was conditionally called. This method was called for windows and Linux OS. For mac OS, this redraw() method was not called to solve "console dials causing high CPU load on Mac". But because of this rendering was not happening for dials and charts. 
> I do not see any high CPU load (May be issue with older versions of OS). Could you please review the changes and let me know if you see any performance issue with this fix (mainly on macOS) ? 
> 
> Fix: Control redraw() method has been called for macOS as well.
> 
> <img width="928" alt="Fix_7532" src="https://user-images.githubusercontent.com/97600378/152590703-0c385f22-be14-4ad6-b592-927c37fa2385.png">

Virag Purnam has updated the pull request incrementally with one additional commit since the last revision:

  7532: Delay in realtime rendering of graphs in JMX Console

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/375/files
  - new: https://git.openjdk.java.net/jmc/pull/375/files/d9e79a4b..ea388506

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=375&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=375&range=00-01

  Stats: 12 lines in 2 files changed: 0 ins; 12 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/375.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/375/head:pull/375

PR: https://git.openjdk.java.net/jmc/pull/375

From duke at openjdk.java.net  Wed Feb  9 11:41:15 2022
From: duke at openjdk.java.net (Virag Purnam)
Date: Wed, 9 Feb 2022 11:41:15 GMT
Subject: RFR: 7532: Delay in realtime rendering of graphs in JMX Console
 [v2]
In-Reply-To: <cFY81Q9CrdKv8pOIKZITpUMWyIFyq_AvSjxJjhIzW3c=.6aee9598-39f4-47b2-b5d7-dc100d8cc49f@github.com>
References: <0S-tNA5qzHwhlFn4kuHbPhQ7k7yOGJIoO61OhZZEwIs=.68c21194-778b-4f7a-a66e-cb41e874ba7a@github.com>
 <cFY81Q9CrdKv8pOIKZITpUMWyIFyq_AvSjxJjhIzW3c=.6aee9598-39f4-47b2-b5d7-dc100d8cc49f@github.com>
Message-ID: <JlNptWQE_EexNRN77g_WysBIuNAgoPSbQSLsrgxm5XI=.01b3da80-8341-410e-aa0b-7bceb76ab2e9@github.com>

On Mon, 7 Feb 2022 13:15:06 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> It seems we can remove the comment and commented code here - explicit calls to update should not be needed.

I have removed the comment and commented code.

-------------

PR: https://git.openjdk.java.net/jmc/pull/375

From hirt at openjdk.java.net  Wed Feb  9 14:52:15 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 9 Feb 2022 14:52:15 GMT
Subject: RFR: 7532: Delay in realtime rendering of graphs in JMX Console
 [v2]
In-Reply-To: <MEOsIfNWTwfzmtT8FW_zaT6UL9QWrchgRtKjKEkZw8g=.e2970997-d65e-4b9f-b3e4-ecfed82405da@github.com>
References: <0S-tNA5qzHwhlFn4kuHbPhQ7k7yOGJIoO61OhZZEwIs=.68c21194-778b-4f7a-a66e-cb41e874ba7a@github.com>
 <MEOsIfNWTwfzmtT8FW_zaT6UL9QWrchgRtKjKEkZw8g=.e2970997-d65e-4b9f-b3e4-ecfed82405da@github.com>
Message-ID: <GPht8dmcHxTAWjZvlZpnd_ejVUfrAgCqma7GoM0txG0=.17c46f21-8b30-4651-a9ef-00c505556329@github.com>

On Wed, 9 Feb 2022 11:38:45 GMT, Virag Purnam <duke at openjdk.java.net> wrote:

>> Issue: Dials and Charts in JMX Console was not rendering with the change. 
>> 
>> <img width="1302" alt="image-2022-01-18-21-36-49-712" src="https://user-images.githubusercontent.com/97600378/152590022-262d4ce1-fe1a-4b52-bb43-d1b61b96d4d0.png">
>>  
>> Root cause: Control redraw() method was conditionally called. This method was called for windows and Linux OS. For mac OS, this redraw() method was not called to solve "console dials causing high CPU load on Mac". But because of this rendering was not happening for dials and charts. 
>> I do not see any high CPU load (May be issue with older versions of OS). Could you please review the changes and let me know if you see any performance issue with this fix (mainly on macOS) ? 
>> 
>> Fix: Control redraw() method has been called for macOS as well.
>> 
>> <img width="928" alt="Fix_7532" src="https://user-images.githubusercontent.com/97600378/152590703-0c385f22-be14-4ad6-b592-927c37fa2385.png">
>
> Virag Purnam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   7532: Delay in realtime rendering of graphs in JMX Console

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/375

From duke at openjdk.java.net  Wed Feb  9 17:00:16 2022
From: duke at openjdk.java.net (Virag Purnam)
Date: Wed, 9 Feb 2022 17:00:16 GMT
Subject: Integrated: 7532: Delay in realtime rendering of graphs in JMX Console
In-Reply-To: <0S-tNA5qzHwhlFn4kuHbPhQ7k7yOGJIoO61OhZZEwIs=.68c21194-778b-4f7a-a66e-cb41e874ba7a@github.com>
References: <0S-tNA5qzHwhlFn4kuHbPhQ7k7yOGJIoO61OhZZEwIs=.68c21194-778b-4f7a-a66e-cb41e874ba7a@github.com>
Message-ID: <BRlnimVStTOXVGVDjNK2N4IOr9ymZPBkMNdiHlklUyU=.7193186f-4881-4174-b47d-9e758f801353@github.com>

On Fri, 4 Feb 2022 19:31:30 GMT, Virag Purnam <duke at openjdk.java.net> wrote:

> Issue: Dials and Charts in JMX Console was not rendering with the change. 
> 
> <img width="1302" alt="image-2022-01-18-21-36-49-712" src="https://user-images.githubusercontent.com/97600378/152590022-262d4ce1-fe1a-4b52-bb43-d1b61b96d4d0.png">
>  
> Root cause: Control redraw() method was conditionally called. This method was called for windows and Linux OS. For mac OS, this redraw() method was not called to solve "console dials causing high CPU load on Mac". But because of this rendering was not happening for dials and charts. 
> I do not see any high CPU load (May be issue with older versions of OS). Could you please review the changes and let me know if you see any performance issue with this fix (mainly on macOS) ? 
> 
> Fix: Control redraw() method has been called for macOS as well.
> 
> <img width="928" alt="Fix_7532" src="https://user-images.githubusercontent.com/97600378/152590703-0c385f22-be14-4ad6-b592-927c37fa2385.png">

This pull request has now been integrated.

Changeset: e3549e9b
Author:    vpurnam <vpurnam at VPURNAM-7420.in.oracle.com>
Committer: Suchita Chaturvedi <schaturvedi at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/e3549e9bd809e0a06d8e751c4026fd22e70b5939
Stats:     40 lines in 2 files changed: 0 ins; 36 del; 4 mod

7532: Delay in realtime rendering of graphs  in JMX Console

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/375

From duke at openjdk.java.net  Mon Feb 14 19:32:37 2022
From: duke at openjdk.java.net (Virag Purnam)
Date: Mon, 14 Feb 2022 19:32:37 GMT
Subject: RFR: 7486: Unable to install Eclipse IDE Plugin
Message-ID: <zAmHq9oXAsWr3WVWLmj7tmdiTEo8KGDDMTxK3Ba4elc=.a6a8e9cc-ca75-4cfc-9f1a-5731dbf0437e@github.com>

**Issue:** Unable to install JMC supported Eclipse IDE Plugin. Some of the dependent plugins are missing. 

**Fix:** Added those dependent plugins in "ide feature" and also deleted one unused plugin from "flight recorder feature".

**Plugins added:**
"org.objectweb.asm",       
"org.objectweb.asm.commons",        
"org.objectweb.asm.tree",      
"org.objectweb.asm.util", 
"org.eclipse.jetty.webapp",        
"org.eclipse.jetty.security",         
"org.eclipse.jetty.server",        
"org.eclipse.jetty.alpn.client",        
"org.eclipse.jetty.servlet",              
"org.eclipse.jetty.http",       
"org.eclipse.jetty.io",       
"org.eclipse.jetty.util",        
"org.eclipse.jetty.xml",       
"org.eclipse.jetty.websocket.core.client",       
"org.eclipse.jetty.websocket.core.common",       
"org.eclipse.jetty.websocket.core.server",      
"org.eclipse.jetty.websocket.common",        
"org.eclipse.jetty.client"

**Plugin removed:**
"org.eclipse.jetty.websocket.javax.server"

-------------

Commit messages:
 - 7486: Unable to install Eclipse IDE Plugin

Changes: https://git.openjdk.java.net/jmc/pull/377/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=377&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7486
  Stats: 136 lines in 2 files changed: 128 ins; 7 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/377.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/377/head:pull/377

PR: https://git.openjdk.java.net/jmc/pull/377

From hirt at openjdk.java.net  Mon Feb 14 20:28:14 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 14 Feb 2022 20:28:14 GMT
Subject: RFR: 7486: Unable to install Eclipse IDE Plugin
In-Reply-To: <zAmHq9oXAsWr3WVWLmj7tmdiTEo8KGDDMTxK3Ba4elc=.a6a8e9cc-ca75-4cfc-9f1a-5731dbf0437e@github.com>
References: <zAmHq9oXAsWr3WVWLmj7tmdiTEo8KGDDMTxK3Ba4elc=.a6a8e9cc-ca75-4cfc-9f1a-5731dbf0437e@github.com>
Message-ID: <WcdVUOrLqfOEpZDRL3FrfzbBJQPdf9X6QaPETutbawY=.7b667e2a-7a69-4b93-8164-5a2d43279c5f@github.com>

On Mon, 14 Feb 2022 19:26:39 GMT, Virag Purnam <duke at openjdk.java.net> wrote:

> **Issue:** Unable to install JMC supported Eclipse IDE Plugin. Some of the dependent plugins are missing. 
> 
> **Fix:** Added those dependent plugins in "ide feature" and also deleted one unused plugin from "flight recorder feature".
> 
> **Plugins added:**
> "org.objectweb.asm",       
> "org.objectweb.asm.commons",        
> "org.objectweb.asm.tree",      
> "org.objectweb.asm.util", 
> "org.eclipse.jetty.webapp",        
> "org.eclipse.jetty.security",         
> "org.eclipse.jetty.server",        
> "org.eclipse.jetty.alpn.client",        
> "org.eclipse.jetty.servlet",              
> "org.eclipse.jetty.http",       
> "org.eclipse.jetty.io",       
> "org.eclipse.jetty.util",        
> "org.eclipse.jetty.xml",       
> "org.eclipse.jetty.websocket.core.client",       
> "org.eclipse.jetty.websocket.core.common",       
> "org.eclipse.jetty.websocket.core.server",      
> "org.eclipse.jetty.websocket.common",        
> "org.eclipse.jetty.client"
> 
> **Plugin removed:**
> "org.eclipse.jetty.websocket.javax.server"

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/377

From duke at openjdk.java.net  Tue Feb 15 06:24:27 2022
From: duke at openjdk.java.net (Virag Purnam)
Date: Tue, 15 Feb 2022 06:24:27 GMT
Subject: Integrated: 7486: Unable to install Eclipse IDE Plugin
In-Reply-To: <zAmHq9oXAsWr3WVWLmj7tmdiTEo8KGDDMTxK3Ba4elc=.a6a8e9cc-ca75-4cfc-9f1a-5731dbf0437e@github.com>
References: <zAmHq9oXAsWr3WVWLmj7tmdiTEo8KGDDMTxK3Ba4elc=.a6a8e9cc-ca75-4cfc-9f1a-5731dbf0437e@github.com>
Message-ID: <6rjFdrfirL5xr3JYU9wRFEYh7xjuOSz6sq3VVajgx50=.611de3d9-6114-4bf3-82ab-7d427712740b@github.com>

On Mon, 14 Feb 2022 19:26:39 GMT, Virag Purnam <duke at openjdk.java.net> wrote:

> **Issue:** Unable to install JMC supported Eclipse IDE Plugin. Some of the dependent plugins are missing. 
> 
> **Fix:** Added those dependent plugins in "ide feature" and also deleted one unused plugin from "flight recorder feature".
> 
> **Plugins added:**
> "org.objectweb.asm",       
> "org.objectweb.asm.commons",        
> "org.objectweb.asm.tree",      
> "org.objectweb.asm.util", 
> "org.eclipse.jetty.webapp",        
> "org.eclipse.jetty.security",         
> "org.eclipse.jetty.server",        
> "org.eclipse.jetty.alpn.client",        
> "org.eclipse.jetty.servlet",              
> "org.eclipse.jetty.http",       
> "org.eclipse.jetty.io",       
> "org.eclipse.jetty.util",        
> "org.eclipse.jetty.xml",       
> "org.eclipse.jetty.websocket.core.client",       
> "org.eclipse.jetty.websocket.core.common",       
> "org.eclipse.jetty.websocket.core.server",      
> "org.eclipse.jetty.websocket.common",        
> "org.eclipse.jetty.client"
> 
> **Plugin removed:**
> "org.eclipse.jetty.websocket.javax.server"

This pull request has now been integrated.

Changeset: 1844ca4c
Author:    vpurnam <vpurnam at VPURNAM-7420.in.oracle.com>
Committer: Suchita Chaturvedi <schaturvedi at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/1844ca4ccc5a0f4b47dda1b01da427a00e13910d
Stats:     136 lines in 2 files changed: 128 ins; 7 del; 1 mod

7486: Unable to install Eclipse IDE Plugin

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/377

From duke at openjdk.java.net  Tue Feb 15 08:02:16 2022
From: duke at openjdk.java.net (mohno007)
Date: Tue, 15 Feb 2022 08:02:16 GMT
Subject: Integrated: 7420: Update Japanese translation for rules
In-Reply-To: <_3eRPXBrbMr6uVo3lMVwefLwCSLj9Y_hnR21yY0T_vI=.a76a0f72-cb79-4fa9-921b-63d12432b8f4@github.com>
References: <_3eRPXBrbMr6uVo3lMVwefLwCSLj9Y_hnR21yY0T_vI=.a76a0f72-cb79-4fa9-921b-63d12432b8f4@github.com>
Message-ID: <6AopRQENIm7xlYwt7MwbuJ4GPi-4OuVvYp-ELhos7iE=.51f770ad-ae4d-497c-ab9c-ae13ebe6bb3a@github.com>

On Mon, 20 Sep 2021 04:55:25 GMT, mohno007 <duke at openjdk.java.net> wrote:

> This PR updates/improves Japanese translation of rules and its descriptions.
> 
> ## Update
> 
> * Update texts based on new commits to `messages.properties` made after the last update date of the `messages_ja.properties`.
> 	* Support a new placeholder format introduced in `Rule 2.0`.
> 	* Use Markdown style link.
> 	* Add translations for newly added texts.
> * Update texts for translation correctness and understandability.
> 	* Fix some wordings for understandability. Especially usage of Japanese particle.
> 	* Add [Japanese counter word (???)](https://en.wikipedia.org/wiki/Japanese_counter_word) for numeric value.
> 
> You can see decoded version of `messages_ja` using this script:
> 
> 
> native2ascii -reverse core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages_ja.properties

This pull request has now been integrated.

Changeset: 00029999
Author:    Motohiro Ohno <m-ohno at atware.co.jp>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/00029999ea3687905fc0f82e68157f9ec74ed735
Stats:     290 lines in 1 file changed: 89 ins; 4 del; 197 mod

7420: Update Japanese translation for rules

Reviewed-by: hirt, aptmac

-------------

PR: https://git.openjdk.java.net/jmc/pull/308

From duke at openjdk.java.net  Fri Feb 18 10:24:12 2022
From: duke at openjdk.java.net (Gunnar Morling)
Date: Fri, 18 Feb 2022 10:24:12 GMT
Subject: RFR: JMC-9999 Allowing char attribute to be parsed
Message-ID: <TEqc7tglR8X-y56bbr4NSu5dlelEdeFBTI6B3rKWs0s=.43032549-ae29-48c6-ae21-a37baf1f6f7c@github.com>

Hey @thegreystone, I noticed that JFR events with `char` attributes cannot be loaded into JMC:


org.openjdk.jmc.flightrecorder.internal.InvalidJfrFileException: Unknown integer type: char
	at org.openjdk.jmc.flightrecorder.internal.parser.v1.ValueReaders$PrimitiveReader.readLong(ValueReaders.java:424)
	at org.openjdk.jmc.flightrecorder.internal.parser.v1.ValueReaders$QuantityReader.read(ValueReaders.java:192)
	at org.openjdk.jmc.flightrecorder.internal.parser.v1.TypeManager$EventTypeEntry.readEvent(TypeManager.java:319)
	at org.openjdk.jmc.flightrecorder.internal.parser.v1.TypeManager.readEvent(TypeManager.java:420)
	at org.openjdk.jmc.flightrecorder.internal.parser.v1.ChunkLoaderV1.call(ChunkLoaderV1.java:92)
	at org.openjdk.jmc.flightrecorder.internal.parser.v1.ChunkLoaderV1.call(ChunkLoaderV1.java:47)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:833)


The code in `ValueReaders::isNumeric` considers `char` to be numeric, causing this to be treated as `long` during parsing later on. With this fix, I can successfully load and examine a recording with such an attribute type using the `RecordingPrinter` (I haven't tried with the JMC UI, as I haven't set up the toolchain required for building it).

If you agree on the fix per se, could you

* log a JMC issue to which I can attribute this fix
* advice me on how/where to test this change (I didn't find any tests in the `flightrecorder` module)

Thanks!

-------------

Commit messages:
 - JMC-9999 Allowing char attribute to be parsed

Changes: https://git.openjdk.java.net/jmc/pull/378/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=378&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-9999
  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/378.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/378/head:pull/378

PR: https://git.openjdk.java.net/jmc/pull/378

From hirt at openjdk.java.net  Sat Feb 19 13:24:09 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sat, 19 Feb 2022 13:24:09 GMT
Subject: RFR: 7561: Update to the release splash screen for JMC 8.2
Message-ID: <aGHzWzack_p_XL7pT_oWeUfbRwnNdPGarRbf87p8cIY=.9bd6d996-eb09-4732-9dc3-01e613cb50a9@github.com>

Just updating the splash in the jmc8 branch for the 8.2 release.

-------------

Commit messages:
 - 7561: Update to the release splash screen for JMC 8.2

Changes: https://git.openjdk.java.net/jmc/pull/380/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=380&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7561
  Stats: 0 lines in 1 file changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/380.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/380/head:pull/380

PR: https://git.openjdk.java.net/jmc/pull/380

From hirt at openjdk.java.net  Sat Feb 19 13:31:11 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sat, 19 Feb 2022 13:31:11 GMT
Subject: RFR: 7562: Make Skara realize master is now 8.3
Message-ID: <isM3I-UbU6TRVtOOSGVAwEa34lv4NjWW_0uF-OoknKc=.1cfa0689-4afb-4993-84f9-34a38e006c19@github.com>

Update for the skara tooling.

-------------

Commit messages:
 - 7562: Make Skara realize master is now 8.3

Changes: https://git.openjdk.java.net/jmc/pull/381/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=381&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7562
  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jmc/pull/381.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/381/head:pull/381

PR: https://git.openjdk.java.net/jmc/pull/381

From hirt at openjdk.java.net  Sat Feb 19 13:42:22 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sat, 19 Feb 2022 13:42:22 GMT
Subject: RFR: 7564: Early access splash for 8.3
Message-ID: <JHI9gF0DAysTj1SRB6qrLTv9evGbW4fVt4cn10esAMM=.73bc262c-87b2-4a87-b620-b7914a57f782@github.com>

Updating the splash in master.

-------------

Commit messages:
 - 7564: Early access splash for 8.3

Changes: https://git.openjdk.java.net/jmc/pull/382/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=382&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7564
  Stats: 0 lines in 1 file changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/382.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/382/head:pull/382

PR: https://git.openjdk.java.net/jmc/pull/382

From hdafgard at openjdk.java.net  Sat Feb 19 15:33:51 2022
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Sat, 19 Feb 2022 15:33:51 GMT
Subject: RFR: 7561: Update to the release splash screen for JMC 8.2
In-Reply-To: <aGHzWzack_p_XL7pT_oWeUfbRwnNdPGarRbf87p8cIY=.9bd6d996-eb09-4732-9dc3-01e613cb50a9@github.com>
References: <aGHzWzack_p_XL7pT_oWeUfbRwnNdPGarRbf87p8cIY=.9bd6d996-eb09-4732-9dc3-01e613cb50a9@github.com>
Message-ID: <K7SsPFiSLcPKJ7ecZeW51kpB4zJDFth5sDrDROpcvxY=.b2b4ad09-35e8-479b-8e6a-2cfa94c0f1a9@github.com>

On Sat, 19 Feb 2022 13:18:50 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Just updating the splash in the jmc8 branch for the 8.2 release.

Marked as reviewed by hdafgard (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/380

From hdafgard at openjdk.java.net  Sat Feb 19 15:33:59 2022
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Sat, 19 Feb 2022 15:33:59 GMT
Subject: RFR: 7562: Make Skara realize master is now 8.3
In-Reply-To: <isM3I-UbU6TRVtOOSGVAwEa34lv4NjWW_0uF-OoknKc=.1cfa0689-4afb-4993-84f9-34a38e006c19@github.com>
References: <isM3I-UbU6TRVtOOSGVAwEa34lv4NjWW_0uF-OoknKc=.1cfa0689-4afb-4993-84f9-34a38e006c19@github.com>
Message-ID: <YBfyAEPCzv4JzbDjb1c8bCNQsNem5cYrIYhBjz6urKk=.ec32896f-961c-4012-be0e-7e915e08f598@github.com>

On Sat, 19 Feb 2022 13:26:34 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Update for the skara tooling.

Marked as reviewed by hdafgard (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/381

From hdafgard at openjdk.java.net  Sat Feb 19 15:34:55 2022
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Sat, 19 Feb 2022 15:34:55 GMT
Subject: RFR: 7564: Early access splash for 8.3
In-Reply-To: <JHI9gF0DAysTj1SRB6qrLTv9evGbW4fVt4cn10esAMM=.73bc262c-87b2-4a87-b620-b7914a57f782@github.com>
References: <JHI9gF0DAysTj1SRB6qrLTv9evGbW4fVt4cn10esAMM=.73bc262c-87b2-4a87-b620-b7914a57f782@github.com>
Message-ID: <zN3OkIa8WLuKtcxFtIMq-uu3_0HDeQ4lPMcM5CN0Jfo=.a65a4583-2752-4e3a-8756-defc3ebdd443@github.com>

On Sat, 19 Feb 2022 13:37:26 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Updating the splash in master.

Marked as reviewed by hdafgard (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/382

From hirt at openjdk.java.net  Sat Feb 19 16:15:55 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sat, 19 Feb 2022 16:15:55 GMT
Subject: Integrated: 7564: Early access splash for 8.3
In-Reply-To: <JHI9gF0DAysTj1SRB6qrLTv9evGbW4fVt4cn10esAMM=.73bc262c-87b2-4a87-b620-b7914a57f782@github.com>
References: <JHI9gF0DAysTj1SRB6qrLTv9evGbW4fVt4cn10esAMM=.73bc262c-87b2-4a87-b620-b7914a57f782@github.com>
Message-ID: <Awn88lcDgDfCpQtHEGtARIXSzFpG2Mk_8DQupBYCtLY=.d11d6f79-6f28-455e-8fab-a92adc9a01af@github.com>

On Sat, 19 Feb 2022 13:37:26 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Updating the splash in master.

This pull request has now been integrated.

Changeset: f5c2c44b
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/f5c2c44bfbfc976963d0d8ed07eaeff8aaefd4ae
Stats:     0 lines in 1 file changed: 0 ins; 0 del; 0 mod

7564: Early access splash for 8.3

Reviewed-by: hdafgard

-------------

PR: https://git.openjdk.java.net/jmc/pull/382

From hirt at openjdk.java.net  Sat Feb 19 16:16:35 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sat, 19 Feb 2022 16:16:35 GMT
Subject: RFR: 7565: Update master to 8.3
Message-ID: <gHgI0rPWFV-RnUxbqcZckoCw5fphZhA08plA6fPCIcU=.4a96aefb-4e38-4523-9a6b-9660020fe373@github.com>

...

-------------

Commit messages:
 - 7565: Update master to 8.3

Changes: https://git.openjdk.java.net/jmc/pull/383/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=383&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7565
  Stats: 221 lines in 146 files changed: 0 ins; 0 del; 221 mod
  Patch: https://git.openjdk.java.net/jmc/pull/383.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/383/head:pull/383

PR: https://git.openjdk.java.net/jmc/pull/383

From hirt at openjdk.java.net  Sat Feb 19 16:16:48 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sat, 19 Feb 2022 16:16:48 GMT
Subject: Integrated: 7562: Make Skara realize master is now 8.3
In-Reply-To: <isM3I-UbU6TRVtOOSGVAwEa34lv4NjWW_0uF-OoknKc=.1cfa0689-4afb-4993-84f9-34a38e006c19@github.com>
References: <isM3I-UbU6TRVtOOSGVAwEa34lv4NjWW_0uF-OoknKc=.1cfa0689-4afb-4993-84f9-34a38e006c19@github.com>
Message-ID: <R2Okhx8pH6zeRw77k4QVA6p6AV2YSjqSR-gUHLifqNQ=.4414feeb-3461-498f-b622-4a9c6e00b638@github.com>

On Sat, 19 Feb 2022 13:26:34 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Update for the skara tooling.

This pull request has now been integrated.

Changeset: b344a14c
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/b344a14cf3d323af89cc8a08fcb7e43d3e69deeb
Stats:     3 lines in 1 file changed: 0 ins; 0 del; 3 mod

7562: Make Skara realize master is now 8.3

Reviewed-by: hdafgard

-------------

PR: https://git.openjdk.java.net/jmc/pull/381

From hirt at openjdk.java.net  Sat Feb 19 16:17:55 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sat, 19 Feb 2022 16:17:55 GMT
Subject: Integrated: 7561: Update to the release splash screen for JMC 8.2
In-Reply-To: <aGHzWzack_p_XL7pT_oWeUfbRwnNdPGarRbf87p8cIY=.9bd6d996-eb09-4732-9dc3-01e613cb50a9@github.com>
References: <aGHzWzack_p_XL7pT_oWeUfbRwnNdPGarRbf87p8cIY=.9bd6d996-eb09-4732-9dc3-01e613cb50a9@github.com>
Message-ID: <h-iDus3U09OwIbIsk573jwgKdMO_3fWBysOnYZyCTBE=.2537ed87-2f44-4fa0-bb55-4a5165d30bc4@github.com>

On Sat, 19 Feb 2022 13:18:50 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Just updating the splash in the jmc8 branch for the 8.2 release.

This pull request has now been integrated.

Changeset: 559f902d
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/559f902d0c739cec0e0199bd40876ea0c8c06773
Stats:     0 lines in 1 file changed: 0 ins; 0 del; 0 mod

7561: Update to the release splash screen for JMC 8.2

Reviewed-by: hdafgard

-------------

PR: https://git.openjdk.java.net/jmc/pull/380

From duke at openjdk.java.net  Sat Feb 19 21:13:28 2022
From: duke at openjdk.java.net (duke)
Date: Sat, 19 Feb 2022 21:13:28 GMT
Subject: git: openjdk/jmc: Added tag 8.2.0-rc for changeset 559f902d
Message-ID: <9fcd0366-fc62-4e1f-8ecd-494bac7a9987@openjdk.java.net>

Tagged by: Marcus Hirt <marcus at hirt.se>
Date:      2022-02-19 22:12:28 +0000

Release candidate for JMC 8.2.0
Changeset: 559f902d
Author:    Marcus Hirt <hirt at openjdk.org>
Date:      2022-02-19 16:13:22 +0000
URL:       https://git.openjdk.java.net/jmc/commit/559f902d0c739cec0e0199bd40876ea0c8c06773


From hdafgard at openjdk.java.net  Sat Feb 19 22:47:53 2022
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Sat, 19 Feb 2022 22:47:53 GMT
Subject: RFR: 7565: Update master to 8.3
In-Reply-To: <gHgI0rPWFV-RnUxbqcZckoCw5fphZhA08plA6fPCIcU=.4a96aefb-4e38-4523-9a6b-9660020fe373@github.com>
References: <gHgI0rPWFV-RnUxbqcZckoCw5fphZhA08plA6fPCIcU=.4a96aefb-4e38-4523-9a6b-9660020fe373@github.com>
Message-ID: <LkJ2U3nR7MtCKkkLVccT4qgtPASlA4xXgqPYUUAJO6Y=.3258fb6f-e3b7-4c25-8ae7-9a40ae9dcbd1@github.com>

On Sat, 19 Feb 2022 16:11:22 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> ...

Marked as reviewed by hdafgard (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/383

From hirt at openjdk.java.net  Sun Feb 20 21:49:52 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sun, 20 Feb 2022 21:49:52 GMT
Subject: Integrated: 7565: Update master to 8.3
In-Reply-To: <gHgI0rPWFV-RnUxbqcZckoCw5fphZhA08plA6fPCIcU=.4a96aefb-4e38-4523-9a6b-9660020fe373@github.com>
References: <gHgI0rPWFV-RnUxbqcZckoCw5fphZhA08plA6fPCIcU=.4a96aefb-4e38-4523-9a6b-9660020fe373@github.com>
Message-ID: <Oy8JTvuvw8AIM6SNOLJ8Vo2mXjNseiW9DHH6LCgPaYc=.c6ca913b-da79-4542-8cb4-06d7377012c3@github.com>

On Sat, 19 Feb 2022 16:11:22 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> ...

This pull request has now been integrated.

Changeset: cadc4ef9
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/cadc4ef987f4cc54377527230db4c95330bb7e47
Stats:     221 lines in 146 files changed: 0 ins; 0 del; 221 mod

7565: Update master to 8.3

Reviewed-by: hdafgard

-------------

PR: https://git.openjdk.java.net/jmc/pull/383

From duke at openjdk.java.net  Fri Feb 25 15:37:37 2022
From: duke at openjdk.java.net (Gunnar Morling)
Date: Fri, 25 Feb 2022 15:37:37 GMT
Subject: RFR: JMC-9999 Allowing char attribute to be parsed [v2]
In-Reply-To: <TEqc7tglR8X-y56bbr4NSu5dlelEdeFBTI6B3rKWs0s=.43032549-ae29-48c6-ae21-a37baf1f6f7c@github.com>
References: <TEqc7tglR8X-y56bbr4NSu5dlelEdeFBTI6B3rKWs0s=.43032549-ae29-48c6-ae21-a37baf1f6f7c@github.com>
Message-ID: <WEAYRsI4XEsQg91YDeUqFPiMkrF221LuXhF32OggyRk=.33432769-8abf-497b-9a0a-07caef14cc9d@github.com>

> Hey @thegreystone, I noticed that JFR events with `char` attributes cannot be loaded into JMC:
> 
> 
> org.openjdk.jmc.flightrecorder.internal.InvalidJfrFileException: Unknown integer type: char
> 	at org.openjdk.jmc.flightrecorder.internal.parser.v1.ValueReaders$PrimitiveReader.readLong(ValueReaders.java:424)
> 	at org.openjdk.jmc.flightrecorder.internal.parser.v1.ValueReaders$QuantityReader.read(ValueReaders.java:192)
> 	at org.openjdk.jmc.flightrecorder.internal.parser.v1.TypeManager$EventTypeEntry.readEvent(TypeManager.java:319)
> 	at org.openjdk.jmc.flightrecorder.internal.parser.v1.TypeManager.readEvent(TypeManager.java:420)
> 	at org.openjdk.jmc.flightrecorder.internal.parser.v1.ChunkLoaderV1.call(ChunkLoaderV1.java:92)
> 	at org.openjdk.jmc.flightrecorder.internal.parser.v1.ChunkLoaderV1.call(ChunkLoaderV1.java:47)
> 	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> 	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
> 	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
> 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
> 	at java.base/java.lang.Thread.run(Thread.java:833)
> 
> 
> The code in `ValueReaders::isNumeric` considers `char` to be numeric, causing this to be treated as `long` during parsing later on. With this fix, I can successfully load and examine a recording with such an attribute type using the `RecordingPrinter` (I haven't tried with the JMC UI, as I haven't set up the toolchain required for building it).
> 
> If you agree on the fix per se, could you
> 
> * log a JMC issue to which I can attribute this fix
> * advice me on how/where to test this change (I didn't find any tests in the `flightrecorder` module)
> 
> Thanks!

Gunnar Morling has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision:

 - JMC-9999 Improving misleading variable name
 - JMC-9999 Allowing char attribute to be parsed

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/378/files
  - new: https://git.openjdk.java.net/jmc/pull/378/files/51864877..4eb310bc

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=378&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=378&range=00-01

  Stats: 107 lines in 3 files changed: 104 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jmc/pull/378.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/378/head:pull/378

PR: https://git.openjdk.java.net/jmc/pull/378

From duke at openjdk.java.net  Fri Feb 25 15:45:40 2022
From: duke at openjdk.java.net (Gunnar Morling)
Date: Fri, 25 Feb 2022 15:45:40 GMT
Subject: RFR: JMC-9999 Allowing char attribute to be parsed [v3]
In-Reply-To: <TEqc7tglR8X-y56bbr4NSu5dlelEdeFBTI6B3rKWs0s=.43032549-ae29-48c6-ae21-a37baf1f6f7c@github.com>
References: <TEqc7tglR8X-y56bbr4NSu5dlelEdeFBTI6B3rKWs0s=.43032549-ae29-48c6-ae21-a37baf1f6f7c@github.com>
Message-ID: <BF7XMJgCVxOXu6GdvT5C-kfNudNZj3ZGhzwxG-LS8DE=.d2cbb25d-4704-403a-bd11-5194b8c3270c@github.com>

> Hey @thegreystone, I noticed that JFR events with `char` attributes cannot be loaded into JMC:
> 
> 
> org.openjdk.jmc.flightrecorder.internal.InvalidJfrFileException: Unknown integer type: char
> 	at org.openjdk.jmc.flightrecorder.internal.parser.v1.ValueReaders$PrimitiveReader.readLong(ValueReaders.java:424)
> 	at org.openjdk.jmc.flightrecorder.internal.parser.v1.ValueReaders$QuantityReader.read(ValueReaders.java:192)
> 	at org.openjdk.jmc.flightrecorder.internal.parser.v1.TypeManager$EventTypeEntry.readEvent(TypeManager.java:319)
> 	at org.openjdk.jmc.flightrecorder.internal.parser.v1.TypeManager.readEvent(TypeManager.java:420)
> 	at org.openjdk.jmc.flightrecorder.internal.parser.v1.ChunkLoaderV1.call(ChunkLoaderV1.java:92)
> 	at org.openjdk.jmc.flightrecorder.internal.parser.v1.ChunkLoaderV1.call(ChunkLoaderV1.java:47)
> 	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> 	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
> 	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
> 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
> 	at java.base/java.lang.Thread.run(Thread.java:833)
> 
> 
> The code in `ValueReaders::isNumeric` considers `char` to be numeric, causing this to be treated as `long` during parsing later on. With this fix, I can successfully load and examine a recording with such an attribute type using the `RecordingPrinter` (I haven't tried with the JMC UI, as I haven't set up the toolchain required for building it).
> 
> If you agree on the fix per se, could you
> 
> * log a JMC issue to which I can attribute this fix
> * advice me on how/where to test this change (I didn't find any tests in the `flightrecorder` module)
> 
> Thanks!

Gunnar Morling has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision:

 - JMC-9999 Improving misleading variable name
 - JMC-9999 Allowing char attribute to be parsed

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/378/files
  - new: https://git.openjdk.java.net/jmc/pull/378/files/4eb310bc..e36125c5

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=378&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=378&range=01-02

  Stats: 6 lines in 1 file changed: 1 ins; 0 del; 5 mod
  Patch: https://git.openjdk.java.net/jmc/pull/378.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/378/head:pull/378

PR: https://git.openjdk.java.net/jmc/pull/378