RFR: 6757: Selector for attribute in the flame graph [v2]

[Marcus Hirt]

On Mon, 29 Aug 2022 20:59:07 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

>> Add support for aggregating flamegraph by custom attribute.
>> 
>> Available attributes are chosen by their content type (number or memory).
>> 
>> <img width="1435" alt="Screenshot 2022-04-22 at 08 35 
>> 47" src="https://user-images.githubusercontent.com/4610701/164617514-34d56474-768a-4f96-8d92-5ba617aca45a.png">
>> 
>> <img width="1437" alt="Screenshot 2022-04-22 at 08 36 06" src="https://user-images.githubusercontent.com/4610701/164617547-c0da25a8-d5f2-4739-bbd9-d41a3dd98d02.png">
>> 
>> Added support on StacktraceView:
>> 
>> <img width="1098" alt="Screenshot 2022-05-10 at 22 20 13" src="https://user-images.githubusercontent.com/4610701/167715364-04ca6580-4389-4c21-b6da-5d7d0fcae63b.png">
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Filter items containing selected attribute
>   
>   Add separator and Samples as first in attribute selection
>   Fix copyright year

Changes requested by hirt (Lead).

Do we want to not even show attributes that only exist in event types that do not have stacktraces? Or perhaps at least sort those attributes under its own subgroup or after a delimiter? Either way, I think it's fine to take this PR once the last copyright fix is in. We can take any changes to what attributes are shown as a separate improvement.

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/AttributeSelection.java line 2:

> 1: /*
> 2:  * Copyright (c) 2022, Datadog, Inc. All rights reserved.

Copyrights must have a dual Oracle/Datadog copyright header per OCA. See other copyrighted files.

core/org.openjdk.jmc.flightrecorder.serializers/src/main/java/org/openjdk/jmc/flightrecorder/serializers/json/FlameGraphJsonSerializer.java line 2:

> 1: /*
> 2:  * Copyright (c) 2020, 2022, Oracle and/or its affiliates. All rights reserved.

See this file for an example of copyright header with Oracle + Datadog copyright.

-------------

PR: https://git.openjdk.org/jmc/pull/365