From asotona at openjdk.java.net  Mon Jan 25 10:17:04 2021
From: asotona at openjdk.java.net (Adam Sotona)
Date: Mon, 25 Jan 2021 10:17:04 GMT
Subject: RFR: Adding troubleshooting section to README.md
Message-ID: <iCdcMvx3m9VW2YbtbbmkpMjr4mwpjXCAJcFcjs6dMbw=.1bdbe7d1-afc0-46c7-9abe-f8a3dedb8b92@github.com>

Hi,
based on an external contributor recent experience with javac benchmarking javac using jmh-jdk-microbenchmarks I've created a troubleshooting section of the README.md

Thanks,
Adam

-------------

Commit messages:
 - Added troubleshooting section to README.md

Changes: https://git.openjdk.java.net/jmh-jdk-microbenchmarks/pull/5/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmh-jdk-microbenchmarks&pr=5&range=00
  Stats: 41 lines in 1 file changed: 41 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmh-jdk-microbenchmarks/pull/5.diff
  Fetch: git fetch https://git.openjdk.java.net/jmh-jdk-microbenchmarks pull/5/head:pull/5

PR: https://git.openjdk.java.net/jmh-jdk-microbenchmarks/pull/5

From mcimadamore at openjdk.java.net  Mon Jan 25 10:35:51 2021
From: mcimadamore at openjdk.java.net (Maurizio Cimadamore)
Date: Mon, 25 Jan 2021 10:35:51 GMT
Subject: RFR: Adding troubleshooting section to README.md
In-Reply-To: <iCdcMvx3m9VW2YbtbbmkpMjr4mwpjXCAJcFcjs6dMbw=.1bdbe7d1-afc0-46c7-9abe-f8a3dedb8b92@github.com>
References: <iCdcMvx3m9VW2YbtbbmkpMjr4mwpjXCAJcFcjs6dMbw=.1bdbe7d1-afc0-46c7-9abe-f8a3dedb8b92@github.com>
Message-ID: <WKazVDAp498xrspZkfN4N7FNsGVDTGtNhBARx31zHpg=.83d9e189-5e33-49a6-808d-7b9f0fe2a06d@github.com>

On Mon, 25 Jan 2021 10:13:25 GMT, Adam Sotona <asotona at openjdk.org> wrote:

> Hi,
> based on an external contributor recent experience with javac benchmarking javac using jmh-jdk-microbenchmarks I've created a troubleshooting section of the README.md
> 
> Thanks,
> Adam

Looks a good troubleshooting guide. I've left some comments

README.md line 72:

> 70: 
> 71: micros-javac benchmarks consist of two sets of benchmarks: 
> 72:  * `SingleJavacBenchmark` (which is parametrized) measures each single javac compilation stage in an isolated run. This benchmark is designed for exact automated performance regression testing and it takes several ours to execute completely. 

Suggestion:

 * `SingleJavacBenchmark` (which is parametrized) measures each single javac compilation stage in an isolated run. This benchmark is designed for exact automated performance regression testing and it takes several hours to execute completely.

README.md line 60:

> 58: It is caused by recently enabled Jigsaw enforcement and micros-javac benchmarks requirement to access several jdk.compiler module private packages. 
> 59: 
> 60: Solution is to export required packages by adding following options to the command line:

assuming this issue comes from reflective access, what about adding a single option to permit illegal access?

-------------

PR: https://git.openjdk.java.net/jmh-jdk-microbenchmarks/pull/5

From asotona at openjdk.java.net  Mon Jan 25 11:01:53 2021
From: asotona at openjdk.java.net (Adam Sotona)
Date: Mon, 25 Jan 2021 11:01:53 GMT
Subject: RFR: Adding troubleshooting section to README.md
In-Reply-To: <WKazVDAp498xrspZkfN4N7FNsGVDTGtNhBARx31zHpg=.83d9e189-5e33-49a6-808d-7b9f0fe2a06d@github.com>
References: <iCdcMvx3m9VW2YbtbbmkpMjr4mwpjXCAJcFcjs6dMbw=.1bdbe7d1-afc0-46c7-9abe-f8a3dedb8b92@github.com>
 <WKazVDAp498xrspZkfN4N7FNsGVDTGtNhBARx31zHpg=.83d9e189-5e33-49a6-808d-7b9f0fe2a06d@github.com>
Message-ID: <XNyDoQib-1zqhD7BPkGPY9PHSQdoH83aaN1itEXCUnI=.45e35d15-6565-447b-b1d1-ae67c0a4c075@github.com>

On Mon, 25 Jan 2021 10:33:01 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Hi,
>> based on an external contributor recent experience with javac benchmarking javac using jmh-jdk-microbenchmarks I've created a troubleshooting section of the README.md
>> 
>> Thanks,
>> Adam
>
> README.md line 60:
> 
>> 58: It is caused by recently enabled Jigsaw enforcement and micros-javac benchmarks requirement to access several jdk.compiler module private packages. 
>> 59: 
>> 60: Solution is to export required packages by adding following options to the command line:
> 
> assuming this issue comes from reflective access, what about adding a single option to permit illegal access?

I thought it was also removed however it is only  deprecated, so to generally permit illegal access is definitely better solution. Thanks!

-------------

PR: https://git.openjdk.java.net/jmh-jdk-microbenchmarks/pull/5

From asotona at openjdk.java.net  Mon Jan 25 11:12:03 2021
From: asotona at openjdk.java.net (Adam Sotona)
Date: Mon, 25 Jan 2021 11:12:03 GMT
Subject: RFR: Adding troubleshooting section to README.md [v2]
In-Reply-To: <iCdcMvx3m9VW2YbtbbmkpMjr4mwpjXCAJcFcjs6dMbw=.1bdbe7d1-afc0-46c7-9abe-f8a3dedb8b92@github.com>
References: <iCdcMvx3m9VW2YbtbbmkpMjr4mwpjXCAJcFcjs6dMbw=.1bdbe7d1-afc0-46c7-9abe-f8a3dedb8b92@github.com>
Message-ID: <ueKb4mRuahigVyYhKGucESadarQsKQndqYzad2lF_eU=.8bc65c6f-254b-4f28-879c-920438a8bfa9@github.com>

> Hi,
> based on an external contributor recent experience with javac benchmarking javac using jmh-jdk-microbenchmarks I've created a troubleshooting section of the README.md
> 
> Thanks,
> Adam

Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:

  Fixed troubleshooting section in README.md

-------------

Changes:
  - all: https://git.openjdk.java.net/jmh-jdk-microbenchmarks/pull/5/files
  - new: https://git.openjdk.java.net/jmh-jdk-microbenchmarks/pull/5/files/c63a764c..f2e85bb1

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmh-jdk-microbenchmarks&pr=5&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmh-jdk-microbenchmarks&pr=5&range=00-01

  Stats: 8 lines in 1 file changed: 0 ins; 5 del; 3 mod
  Patch: https://git.openjdk.java.net/jmh-jdk-microbenchmarks/pull/5.diff
  Fetch: git fetch https://git.openjdk.java.net/jmh-jdk-microbenchmarks pull/5/head:pull/5

PR: https://git.openjdk.java.net/jmh-jdk-microbenchmarks/pull/5

From asotona at openjdk.java.net  Mon Jan 25 11:12:04 2021
From: asotona at openjdk.java.net (Adam Sotona)
Date: Mon, 25 Jan 2021 11:12:04 GMT
Subject: RFR: Adding troubleshooting section to README.md [v2]
In-Reply-To: <WKazVDAp498xrspZkfN4N7FNsGVDTGtNhBARx31zHpg=.83d9e189-5e33-49a6-808d-7b9f0fe2a06d@github.com>
References: <iCdcMvx3m9VW2YbtbbmkpMjr4mwpjXCAJcFcjs6dMbw=.1bdbe7d1-afc0-46c7-9abe-f8a3dedb8b92@github.com>
 <WKazVDAp498xrspZkfN4N7FNsGVDTGtNhBARx31zHpg=.83d9e189-5e33-49a6-808d-7b9f0fe2a06d@github.com>
Message-ID: <4bKXbwf-6z1EAaYi9tyYpKD4HLKrFGkfft9pjItApKU=.03032d46-084e-452d-b266-9f984dc2cf61@github.com>

On Mon, 25 Jan 2021 10:32:22 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed troubleshooting section in README.md
>
> README.md line 72:
> 
>> 70: 
>> 71: micros-javac benchmarks consist of two sets of benchmarks: 
>> 72:  * `SingleJavacBenchmark` (which is parametrized) measures each single javac compilation stage in an isolated run. This benchmark is designed for exact automated performance regression testing and it takes several ours to execute completely. 
> 
> Suggestion:
> 
>  * `SingleJavacBenchmark` (which is parametrized) measures each single javac compilation stage in an isolated run. This benchmark is designed for exact automated performance regression testing and it takes several hours to execute completely.

fixed, thanks!

-------------

PR: https://git.openjdk.java.net/jmh-jdk-microbenchmarks/pull/5

From asotona at openjdk.java.net  Mon Jan 25 11:12:05 2021
From: asotona at openjdk.java.net (Adam Sotona)
Date: Mon, 25 Jan 2021 11:12:05 GMT
Subject: RFR: Adding troubleshooting section to README.md [v2]
In-Reply-To: <XNyDoQib-1zqhD7BPkGPY9PHSQdoH83aaN1itEXCUnI=.45e35d15-6565-447b-b1d1-ae67c0a4c075@github.com>
References: <iCdcMvx3m9VW2YbtbbmkpMjr4mwpjXCAJcFcjs6dMbw=.1bdbe7d1-afc0-46c7-9abe-f8a3dedb8b92@github.com>
 <WKazVDAp498xrspZkfN4N7FNsGVDTGtNhBARx31zHpg=.83d9e189-5e33-49a6-808d-7b9f0fe2a06d@github.com>
 <XNyDoQib-1zqhD7BPkGPY9PHSQdoH83aaN1itEXCUnI=.45e35d15-6565-447b-b1d1-ae67c0a4c075@github.com>
Message-ID: <JtuMchzY9jiyGH48Te-iAQYqP6ykpvvWdIHJanTd888=.d14d9972-ad67-446a-8385-015683d97ef1@github.com>

On Mon, 25 Jan 2021 10:58:52 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> README.md line 60:
>> 
>>> 58: It is caused by recently enabled Jigsaw enforcement and micros-javac benchmarks requirement to access several jdk.compiler module private packages. 
>>> 59: 
>>> 60: Solution is to export required packages by adding following options to the command line:
>> 
>> assuming this issue comes from reflective access, what about adding a single option to permit illegal access?
>
> I thought it was also removed however it is only  deprecated, so to generally permit illegal access is definitely better solution. Thanks!

fixed

-------------

PR: https://git.openjdk.java.net/jmh-jdk-microbenchmarks/pull/5

From ecaspole at openjdk.java.net  Mon Jan 25 15:18:53 2021
From: ecaspole at openjdk.java.net (Eric Caspole)
Date: Mon, 25 Jan 2021 15:18:53 GMT
Subject: RFR: Adding troubleshooting section to README.md [v2]
In-Reply-To: <ueKb4mRuahigVyYhKGucESadarQsKQndqYzad2lF_eU=.8bc65c6f-254b-4f28-879c-920438a8bfa9@github.com>
References: <iCdcMvx3m9VW2YbtbbmkpMjr4mwpjXCAJcFcjs6dMbw=.1bdbe7d1-afc0-46c7-9abe-f8a3dedb8b92@github.com>
 <ueKb4mRuahigVyYhKGucESadarQsKQndqYzad2lF_eU=.8bc65c6f-254b-4f28-879c-920438a8bfa9@github.com>
Message-ID: <YafNYcskWtA5HxhYaCIN1MPsOK7OxQNpgYd4OreAxeE=.e7c783a6-55f5-49f3-b2b1-94567d611728@github.com>

On Mon, 25 Jan 2021 11:12:03 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> Hi,
>> based on an external contributor recent experience with javac benchmarking javac using jmh-jdk-microbenchmarks I've created a troubleshooting section of the README.md
>> 
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed troubleshooting section in README.md

Looks good.

-------------

Marked as reviewed by ecaspole (Committer).

PR: https://git.openjdk.java.net/jmh-jdk-microbenchmarks/pull/5

From ecaspole at openjdk.java.net  Mon Jan 25 15:32:53 2021
From: ecaspole at openjdk.java.net (Eric Caspole)
Date: Mon, 25 Jan 2021 15:32:53 GMT
Subject: Withdrawn: Adding troubleshooting section to README.md
In-Reply-To: <iCdcMvx3m9VW2YbtbbmkpMjr4mwpjXCAJcFcjs6dMbw=.1bdbe7d1-afc0-46c7-9abe-f8a3dedb8b92@github.com>
References: <iCdcMvx3m9VW2YbtbbmkpMjr4mwpjXCAJcFcjs6dMbw=.1bdbe7d1-afc0-46c7-9abe-f8a3dedb8b92@github.com>
Message-ID: <ThYB8UNKQ_VjhTOr31f9QuliJfPQUXCTVG-tlY6M2Ys=.52c15c3a-a920-4ca5-81ba-65df160dd437@github.com>

On Mon, 25 Jan 2021 10:13:25 GMT, Adam Sotona <asotona at openjdk.org> wrote:

> Hi,
> based on an external contributor recent experience with javac benchmarking javac using jmh-jdk-microbenchmarks I've created a troubleshooting section of the README.md
> 
> Thanks,
> Adam

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.java.net/jmh-jdk-microbenchmarks/pull/5

From duke at openjdk.java.net  Mon Jan 25 16:20:18 2021
From: duke at openjdk.java.net (duke)
Date: Mon, 25 Jan 2021 16:20:18 GMT
Subject: git: openjdk/jmh-jdk-microbenchmarks: Adding troubleshooting section
 to README.md (#5)
Message-ID: <113d09b9-25b7-45a0-bde5-593229512633@openjdk.java.net>

Changeset: 90132242
Author:    Adam Sotona <asotona at users.noreply.github.com>
Committer: GitHub <noreply at github.com>
Date:      2021-01-25 16:30:28 +0000
URL:       https://git.openjdk.java.net/jmh-jdk-microbenchmarks/commit/90132242

Adding troubleshooting section to README.md (#5)

* Added troubleshooting section to README.md

* Fixed troubleshooting section in README.md

! README.md


From github.com+827112+lovepoem at openjdk.java.net  Tue Jan 26 01:21:00 2021
From: github.com+827112+lovepoem at openjdk.java.net (Xin Wang)
Date: Tue, 26 Jan 2021 01:21:00 GMT
Subject: RFR: update .gitignore
Message-ID: <glRssPuG-n8-M-s9uswV5a20vYjjkpl1hknPUbp8D7w=.9cbdaaef-19f8-4e7e-bde1-179d9bfc5508@github.com>

update .gitignore

-------------

Commit messages:
 - update .gitignore

Changes: https://git.openjdk.java.net/jmh-jdk-microbenchmarks/pull/4/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmh-jdk-microbenchmarks&pr=4&range=00
  Stats: 27 lines in 1 file changed: 22 ins; 0 del; 5 mod
  Patch: https://git.openjdk.java.net/jmh-jdk-microbenchmarks/pull/4.diff
  Fetch: git fetch https://git.openjdk.java.net/jmh-jdk-microbenchmarks pull/4/head:pull/4

PR: https://git.openjdk.java.net/jmh-jdk-microbenchmarks/pull/4

From ecaspole at openjdk.java.net  Tue Jan 26 01:21:00 2021
From: ecaspole at openjdk.java.net (Eric Caspole)
Date: Tue, 26 Jan 2021 01:21:00 GMT
Subject: RFR: update .gitignore
In-Reply-To: <glRssPuG-n8-M-s9uswV5a20vYjjkpl1hknPUbp8D7w=.9cbdaaef-19f8-4e7e-bde1-179d9bfc5508@github.com>
References: <glRssPuG-n8-M-s9uswV5a20vYjjkpl1hknPUbp8D7w=.9cbdaaef-19f8-4e7e-bde1-179d9bfc5508@github.com>
Message-ID: <aLW9NdPjQX0R4UPhxgrTTYCUjEx4bts1FD8NNhM8UjU=.94736948-0218-4996-a941-1fa82de66ef0@github.com>

On Thu, 21 Jan 2021 03:49:10 GMT, Xin Wang <github.com+827112+lovepoem at openjdk.org> wrote:

> update .gitignore

OK

-------------

Marked as reviewed by ecaspole (Committer).

PR: https://git.openjdk.java.net/jmh-jdk-microbenchmarks/pull/4