From dongbohe at openjdk.java.net  Wed May 26 03:23:34 2021
From: dongbohe at openjdk.java.net (Dongbo He)
Date: Wed, 26 May 2021 03:23:34 GMT
Subject: RFR: Remove unnecessary init in AESGCMBench:setup
Message-ID: <kHSFbUdPo1r8c4xYNLPoTWdjkCTu7dyVi4y6rEvFyhE=.a233052b-42d4-4d8c-8c62-9ad84974240e@github.com>

decryptCipher will be reinitialized in decrypt, which will loses all previously-acquired state. Therefore, it's not necessary to initialize in setup.

-------------

Commit messages:
 - Remove unnecessary init in AESGCMBench:setup

Changes: https://git.openjdk.java.net/jmh-jdk-microbenchmarks/pull/8/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmh-jdk-microbenchmarks&pr=8&range=00
  Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod
  Patch: https://git.openjdk.java.net/jmh-jdk-microbenchmarks/pull/8.diff
  Fetch: git fetch https://git.openjdk.java.net/jmh-jdk-microbenchmarks pull/8/head:pull/8

PR: https://git.openjdk.java.net/jmh-jdk-microbenchmarks/pull/8

From redestad at openjdk.java.net  Wed May 26 10:59:24 2021
From: redestad at openjdk.java.net (Claes Redestad)
Date: Wed, 26 May 2021 10:59:24 GMT
Subject: RFR: Remove unnecessary init in AESGCMBench:setup
In-Reply-To: <kHSFbUdPo1r8c4xYNLPoTWdjkCTu7dyVi4y6rEvFyhE=.a233052b-42d4-4d8c-8c62-9ad84974240e@github.com>
References: <kHSFbUdPo1r8c4xYNLPoTWdjkCTu7dyVi4y6rEvFyhE=.a233052b-42d4-4d8c-8c62-9ad84974240e@github.com>
Message-ID: <IDKUAEp3vxmD1K5nOd50TLRESKYkgiDnibjGq5Hy4eo=.b437b857-0186-4dd9-ba52-6da79d220223@github.com>

On Wed, 26 May 2021 03:18:54 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

> decryptCipher will be reinitialized in decrypt, which will loses all previously-acquired state. Therefore, it's not necessary to initialize in setup.

Looks ok (I don't have a reviewer bit for this project), but please sync the changes with the microbenchmark in the JDK proper.

-------------

PR: https://git.openjdk.java.net/jmh-jdk-microbenchmarks/pull/8

From dongbohe at openjdk.java.net  Thu May 27 12:13:17 2021
From: dongbohe at openjdk.java.net (Dongbo He)
Date: Thu, 27 May 2021 12:13:17 GMT
Subject: RFR: Remove unnecessary init in AESGCMBench:setup
In-Reply-To: <IDKUAEp3vxmD1K5nOd50TLRESKYkgiDnibjGq5Hy4eo=.b437b857-0186-4dd9-ba52-6da79d220223@github.com>
References: <kHSFbUdPo1r8c4xYNLPoTWdjkCTu7dyVi4y6rEvFyhE=.a233052b-42d4-4d8c-8c62-9ad84974240e@github.com>
 <IDKUAEp3vxmD1K5nOd50TLRESKYkgiDnibjGq5Hy4eo=.b437b857-0186-4dd9-ba52-6da79d220223@github.com>
Message-ID: <m22x-jRCt1nQiCa-kfBbYzBJyZsO_t-RVgNWg38XHz4=.cc117960-0cff-4830-855d-034248d6717f@github.com>

On Wed, 26 May 2021 10:56:17 GMT, Claes Redestad <redestad at openjdk.org> wrote:

> Looks ok (I don't have a reviewer bit for this project), but please sync the changes with the microbenchmark in the JDK proper.

Thanks, the changes is now integrated into JDK. See: https://github.com/openjdk/jdk/commit/85f616522b2dc8e7b4c31d760c3171ac74a5490f

-------------

PR: https://git.openjdk.java.net/jmh-jdk-microbenchmarks/pull/8