From duke at openjdk.java.net Thu Jun 9 16:56:57 2022 From: duke at openjdk.java.net (Steafan Chou) Date: Thu, 9 Jun 2022 16:56:57 GMT Subject: RFR: some code clean. Message-ID: Hi friends,I am studying the JOL source,i cleaned some code,thanks. ------------- Commit messages: - some code clean. Changes: https://git.openjdk.org/jol/pull/26/files Webrev: https://webrevs.openjdk.java.net/?repo=jol&pr=26&range=00 Stats: 257 lines in 21 files changed: 151 ins; 0 del; 106 mod Patch: https://git.openjdk.org/jol/pull/26.diff Fetch: git fetch https://git.openjdk.org/jol pull/26/head:pull/26 PR: https://git.openjdk.org/jol/pull/26 From duke at openjdk.java.net Thu Jun 9 16:56:58 2022 From: duke at openjdk.java.net (Steafan Chou) Date: Thu, 9 Jun 2022 16:56:58 GMT Subject: RFR: some code clean. In-Reply-To: References: Message-ID: On Tue, 24 May 2022 02:42:18 GMT, Steafan Chou wrote: > Hi friends,I am studying the JOL source,i cleaned some code,thanks. @shipilev Hi friends,i submitted a PR,please review and merge,thanks. It's been a week, can anyone handle this, thanks Hi,my OCA was processed,what do the PR next?thanks. ![image](https://user-images.githubusercontent.com/23360739/172318454-70320150-7a25-46b3-a04b-aa2c2d803070.png) > > But I have received an email from you 6 days ago, the email has clearly stated that my OCA has been processed, but why does the robot still have such a label? > > Well, I did not send you any emails; @robilad probably did, and that is the question for him why the new OCA status is not yet recorded for bots. ------------- PR: https://git.openjdk.org/jol/pull/26 From robilad at openjdk.java.net Thu Jun 9 16:56:58 2022 From: robilad at openjdk.java.net (Dalibor Topic) Date: Thu, 9 Jun 2022 16:56:58 GMT Subject: RFR: some code clean. In-Reply-To: References: Message-ID: <_CFBnX8aDLuabUsXHEoSUuI8VMI_xtNPVF_j3Uwdz74=.a460525f-c432-4e35-b907-4dd48d1abe05@github.com> On Tue, 24 May 2022 02:42:18 GMT, Steafan Chou wrote: > Hi friends,I am studying the JOL source,i cleaned some code,thanks. Hi, please send me an e-Mail to Dalibor.topic at oracle.vom so that I can check whether your OCA has been processed and mark your account as verified accordingly. Yeah, the processing confirmation mails for OpenJDK typically come from me. In this case, one additional step is necessary to associate the GitHub id with the OCA. Once I have the e-mail confirmation associating this particular Github id with their OCA from the user, I'll mark the account as verified. ------------- PR: https://git.openjdk.org/jol/pull/26 From duke at openjdk.java.net Thu Jun 9 16:57:00 2022 From: duke at openjdk.java.net (Steafan Chou) Date: Thu, 9 Jun 2022 16:57:00 GMT Subject: RFR: some code clean. In-Reply-To: References: Message-ID: On Mon, 30 May 2022 00:26:16 GMT, Steafan Chou wrote: > can anyone handle this, thanks It's been two weeks and my OCA was processed,can anyone handle this yet? Making a person wait for a long time is a manifestation of disrespect to people. ------------- PR: https://git.openjdk.org/jol/pull/26 From shade at openjdk.java.net Thu Jun 9 16:57:01 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 9 Jun 2022 16:57:01 GMT Subject: RFR: some code clean. In-Reply-To: References: Message-ID: On Tue, 7 Jun 2022 03:03:30 GMT, Steafan Chou wrote: > > can anyone handle this, thanks > > It's been two weeks and my OCA was processed,can anyone handle this yet? It is not processed yet: bots still have `oca`, `oca-verify` tags on the PR. > Making a person wait for a long time is a manifestation of disrespect to people. Let's see. Does this PR fixes a bug? Does not look like it. Does it improve performance considerably? Does not look like it. Does it improve readability by a lot? Does not look like it. Cleanups like these are by definition low-priority in most OSS projects, and they are processed when maintainers have time and goodwill to do so. Talking about disrespect does not contribute to goodwill, and therefore shrinks the chance a maintainer would spend time with the contribution. I understand it can be frustrating on a personal level, but I think having patience is paramount in OSS work. So, just wait for OCA to complete processing, and then we shall look at the code changes. ------------- PR: https://git.openjdk.org/jol/pull/26 From duke at openjdk.java.net Thu Jun 9 16:57:01 2022 From: duke at openjdk.java.net (Steafan Chou) Date: Thu, 9 Jun 2022 16:57:01 GMT Subject: RFR: some code clean. In-Reply-To: References: Message-ID: On Tue, 7 Jun 2022 06:16:17 GMT, Aleksey Shipilev wrote: > > > can anyone handle this, thanks > > > > > > It's been two weeks and my OCA was processed,can anyone handle this yet? > > It is not processed yet: bots still have `oca`, `oca-verify` tags on the PR. > > > Making a person wait for a long time is a manifestation of disrespect to people. > > Let's see. Does this PR fixes a bug? Does not look like it. Does it improve performance considerably? Does not look like it. Does it improve readability by a lot? Does not look like it. Cleanups like these are by definition low-priority in most OSS projects, and they are processed when maintainers have time and goodwill to do so. Talking about disrespect does not contribute to goodwill, and therefore shrinks the chance a maintainer would spend time with the contribution. I understand it can be frustrating on a personal level, but I think having patience is paramount in OSS work. > > So, just wait for OCA to complete processing, and then we shall look at the code changes. But I have received an email from you 6 days ago, the email has clearly stated that my OCA has been processed, but why does the robot still have such a label? ------------- PR: https://git.openjdk.org/jol/pull/26 From shade at openjdk.java.net Thu Jun 9 16:57:02 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 9 Jun 2022 16:57:02 GMT Subject: RFR: some code clean. In-Reply-To: References: Message-ID: On Tue, 7 Jun 2022 06:24:53 GMT, Steafan Chou wrote: > But I have received an email from you 6 days ago, the email has clearly stated that my OCA has been processed, but why does the robot still have such a label? Well, I did not send you any emails; @robilad probably did, and that is the question for him why the new OCA status is not yet recorded for bots. ------------- PR: https://git.openjdk.org/jol/pull/26 From duke at openjdk.java.net Tue Jun 14 01:36:59 2022 From: duke at openjdk.java.net (Steafan Chou) Date: Tue, 14 Jun 2022 01:36:59 GMT Subject: RFR: CODETOOLS-7903210: JOL: Minor code cleanups [v2] In-Reply-To: References: Message-ID: <-8qEeTt8Uy4TVLK2BfoA-uQSOyH3YEW8cemH86EdCwo=.3af41e28-1bdc-4f1d-93d1-d23ed360b35a@github.com> > Hi friends,I am studying the JOL source,i cleaned some code,thanks. Steafan Chou has updated the pull request incrementally with one additional commit since the last revision: revert GraphInstanceBench 49 line. ------------- Changes: - all: https://git.openjdk.org/jol/pull/26/files - new: https://git.openjdk.org/jol/pull/26/files/9d118630..f2e38258 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jol&pr=26&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jol&pr=26&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jol/pull/26.diff Fetch: git fetch https://git.openjdk.org/jol pull/26/head:pull/26 PR: https://git.openjdk.org/jol/pull/26 From duke at openjdk.java.net Tue Jun 14 01:37:01 2022 From: duke at openjdk.java.net (Steafan Chou) Date: Tue, 14 Jun 2022 01:37:01 GMT Subject: RFR: CODETOOLS-7903210: JOL: Minor code cleanups [v2] In-Reply-To: References: Message-ID: On Mon, 13 Jun 2022 16:35:47 GMT, Aleksey Shipilev wrote: >> Steafan Chou has updated the pull request incrementally with one additional commit since the last revision: >> >> revert GraphInstanceBench 49 line. > > jol-benchmarks/src/main/java/org/openjdk/jol/GraphInstanceBench.java line 49: > >> 47: arr = new Integer[size]; >> 48: for (int c = 0; c < size; c++) { >> 49: arr[c] = c; > > This boxing was intentional, please revert this hunk. I am revert this hunk,but I wonder why this is done on purpose. ------------- PR: https://git.openjdk.org/jol/pull/26 From duke at openjdk.java.net Tue Jun 14 02:06:22 2022 From: duke at openjdk.java.net (Steafan Chou) Date: Tue, 14 Jun 2022 02:06:22 GMT Subject: RFR: CODETOOLS-7903210: JOL: Minor code cleanups [v2] In-Reply-To: <-8qEeTt8Uy4TVLK2BfoA-uQSOyH3YEW8cemH86EdCwo=.3af41e28-1bdc-4f1d-93d1-d23ed360b35a@github.com> References: <-8qEeTt8Uy4TVLK2BfoA-uQSOyH3YEW8cemH86EdCwo=.3af41e28-1bdc-4f1d-93d1-d23ed360b35a@github.com> Message-ID: On Tue, 14 Jun 2022 01:36:59 GMT, Steafan Chou wrote: >> Hi friends,I am studying the JOL source,i cleaned some code,thanks. > > Steafan Chou has updated the pull request incrementally with one additional commit since the last revision: > > revert GraphInstanceBench 49 line. This workflow has been configured and executed, please check, thanks a lot. ------------- PR: https://git.openjdk.org/jol/pull/26 From shade at openjdk.java.net Tue Jun 14 14:44:19 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 14 Jun 2022 14:44:19 GMT Subject: RFR: CODETOOLS-7903210: JOL: Minor code cleanups [v2] In-Reply-To: <-8qEeTt8Uy4TVLK2BfoA-uQSOyH3YEW8cemH86EdCwo=.3af41e28-1bdc-4f1d-93d1-d23ed360b35a@github.com> References: <-8qEeTt8Uy4TVLK2BfoA-uQSOyH3YEW8cemH86EdCwo=.3af41e28-1bdc-4f1d-93d1-d23ed360b35a@github.com> Message-ID: On Tue, 14 Jun 2022 01:36:59 GMT, Steafan Chou wrote: >> Hi friends,I am studying the JOL source,i cleaned some code,thanks. > > Steafan Chou has updated the pull request incrementally with one additional commit since the last revision: > > revert GraphInstanceBench 49 line. Marked as reviewed by shade (Committer). ------------- PR: https://git.openjdk.org/jol/pull/26 From shade at openjdk.java.net Tue Jun 14 14:44:21 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 14 Jun 2022 14:44:21 GMT Subject: RFR: CODETOOLS-7903210: JOL: Minor code cleanups [v2] In-Reply-To: References: Message-ID: <6_wYzsEd3QIuMRWt4Bbf4t7tggPFPxheP5h6g6M3sHs=.9a4527c1-4ac0-4c19-9555-4a6600c03cde@github.com> On Tue, 14 Jun 2022 01:33:02 GMT, Steafan Chou wrote: >> jol-benchmarks/src/main/java/org/openjdk/jol/GraphInstanceBench.java line 49: >> >>> 47: arr = new Integer[size]; >>> 48: for (int c = 0; c < size; c++) { >>> 49: arr[c] = c; >> >> This boxing was intentional, please revert this hunk. > > I am revert this hunk,but I wonder why this is done on purpose. Because we want allocations to be cobbled together, not referenced from the integer cache. ------------- PR: https://git.openjdk.org/jol/pull/26 From duke at openjdk.java.net Wed Jun 15 07:02:02 2022 From: duke at openjdk.java.net (Steafan Chou) Date: Wed, 15 Jun 2022 07:02:02 GMT Subject: Integrated: CODETOOLS-7903210: JOL: Minor code cleanups In-Reply-To: References: Message-ID: On Tue, 24 May 2022 02:42:18 GMT, Steafan Chou wrote: > Hi friends,I am studying the JOL source,i cleaned some code,thanks. This pull request has now been integrated. Changeset: 5ec187a6 Author: Steafan <244007461 at qq.com> Committer: Aleksey Shipilev URL: https://git.openjdk.org/jol/commit/5ec187a6d38443604221a63abec39c545d4d1674 Stats: 256 lines in 20 files changed: 151 ins; 0 del; 105 mod 7903210: JOL: Minor code cleanups Reviewed-by: shade ------------- PR: https://git.openjdk.org/jol/pull/26 From duke at openjdk.org Mon Jun 20 02:15:39 2022 From: duke at openjdk.org (Steafan Chou) Date: Mon, 20 Jun 2022 02:15:39 GMT Subject: RFR: Complete some todos in VMOptions Message-ID: Complete some todos in VMOptions ------------- Commit messages: - Merge branch 'SteafanMrZhouJOLBranch' of https://urldefense.com/v3/__https://github.com/SteafanMrZhou/jol__;!!ACWV5N9M2RV99hQ!N07BEZ5rgTOsYZABoQrUDmT6ODiTARTHFcdT-NULUtdcJmxkJEKfCK9pJWdUC6_bBF1rVR-xu0mfCEid$ into SteafanMrZhouJOLBranch - revert GraphInstanceBench 49 line. - some code clean. - complete some todos in VMOptions. Changes: https://git.openjdk.org/jol/pull/27/files Webrev: https://webrevs.openjdk.org/?repo=jol&pr=27&range=00 Stats: 260 lines in 21 files changed: 151 ins; 0 del; 109 mod Patch: https://git.openjdk.org/jol/pull/27.diff Fetch: git fetch https://git.openjdk.org/jol pull/27/head:pull/27 PR: https://git.openjdk.org/jol/pull/27 From shade at openjdk.org Mon Jun 20 07:36:17 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 20 Jun 2022 07:36:17 GMT Subject: RFR: Complete some todos in VMOptions In-Reply-To: References: Message-ID: On Mon, 20 Jun 2022 02:09:29 GMT, Steafan Chou wrote: > Complete some todos in VMOptions This PR contains unrelated cleanup changes, please revert them. I think your branch is basically behind the upstream master. Please use "feature branches", avoid committing to maser of your fork, as it makes PRs harder to make out. ------------- Changes requested by shade (Committer). PR: https://git.openjdk.org/jol/pull/27 From duke at openjdk.org Mon Jun 20 08:23:16 2022 From: duke at openjdk.org (Steafan Chou) Date: Mon, 20 Jun 2022 08:23:16 GMT Subject: Withdrawn: Complete some todos in VMOptions In-Reply-To: References: Message-ID: On Mon, 20 Jun 2022 02:09:29 GMT, Steafan Chou wrote: > Complete some todos in VMOptions This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jol/pull/27 From duke at openjdk.org Mon Jun 20 08:26:45 2022 From: duke at openjdk.org (Steafan Chou) Date: Mon, 20 Jun 2022 08:26:45 GMT Subject: RFR: Complete some todos in VMOptions Message-ID: I'm sorry about the last commit, I forgot to update my branch. I have updated the branch synchronously, please check the PR,thanks a lot. ------------- Commit messages: - Complete some todos in VMOptions Changes: https://git.openjdk.org/jol/pull/28/files Webrev: https://webrevs.openjdk.org/?repo=jol&pr=28&range=00 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jol/pull/28.diff Fetch: git fetch https://git.openjdk.org/jol pull/28/head:pull/28 PR: https://git.openjdk.org/jol/pull/28 From duke at openjdk.org Mon Jun 20 08:45:06 2022 From: duke at openjdk.org (Steafan Chou) Date: Mon, 20 Jun 2022 08:45:06 GMT Subject: RFR: Complete some todos in VMOptions [v2] In-Reply-To: References: Message-ID: > I'm sorry about the last commit, I forgot to update my branch. > I have updated the branch synchronously, please check the PR,thanks a lot. Steafan Chou has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not available. ------------- Changes: - all: https://git.openjdk.org/jol/pull/28/files - new: https://git.openjdk.org/jol/pull/28/files/414bffe1..5ec187a6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jol&pr=28&range=01 - incr: https://webrevs.openjdk.org/?repo=jol&pr=28&range=00-01 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jol/pull/28.diff Fetch: git fetch https://git.openjdk.org/jol pull/28/head:pull/28 PR: https://git.openjdk.org/jol/pull/28 From duke at openjdk.org Mon Jun 20 08:45:07 2022 From: duke at openjdk.org (Steafan Chou) Date: Mon, 20 Jun 2022 08:45:07 GMT Subject: Withdrawn: Complete some todos in VMOptions In-Reply-To: References: Message-ID: On Mon, 20 Jun 2022 08:20:16 GMT, Steafan Chou wrote: > I'm sorry about the last commit, I forgot to update my branch. > I have updated the branch synchronously, please check the PR,thanks a lot. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jol/pull/28 From duke at openjdk.org Mon Jun 20 08:49:39 2022 From: duke at openjdk.org (Steafan Chou) Date: Mon, 20 Jun 2022 08:49:39 GMT Subject: RFR: Complete some todos in VMOptions Message-ID: I'm sorry about the last commit, I forgot to update my branch. I have updated the branch synchronously, please check the PR,thanks a lot. ------------- Commit messages: - Complete some todos in VMOptions Changes: https://git.openjdk.org/jol/pull/29/files Webrev: https://webrevs.openjdk.org/?repo=jol&pr=29&range=00 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jol/pull/29.diff Fetch: git fetch https://git.openjdk.org/jol pull/29/head:pull/29 PR: https://git.openjdk.org/jol/pull/29 From shade at openjdk.org Mon Jun 20 09:19:10 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 20 Jun 2022 09:19:10 GMT Subject: RFR: 7903214: JOL: Complete some TODOs in VMOptions In-Reply-To: References: Message-ID: On Mon, 20 Jun 2022 08:43:15 GMT, Steafan Chou wrote: > I'm sorry about the last commit, I forgot to update my branch. > I have updated the branch synchronously, please check the PR,thanks a lot. Can you also please go to https://urldefense.com/v3/__https://github.com/SteafanMrZhou/jol/actions/__;!!ACWV5N9M2RV99hQ!OmmC4m-i5sbpJ_HkTSjeM_sGguGRKDm-PF_DB0LycJvk78N7J_fXfF3_vNO1u91gb7e25JRtOGJSYq8_tw$ -- and check that workflows are enabled? The PRs need to be tested, and workflows are supposed to run automatically. ------------- PR: https://git.openjdk.org/jol/pull/29 From duke at openjdk.org Mon Jun 20 09:45:14 2022 From: duke at openjdk.org (Steafan Chou) Date: Mon, 20 Jun 2022 09:45:14 GMT Subject: RFR: 7903214: JOL: Complete some TODOs in VMOptions In-Reply-To: References: Message-ID: On Mon, 20 Jun 2022 09:15:17 GMT, Aleksey Shipilev wrote: > Can you also please go to https://urldefense.com/v3/__https://github.com/SteafanMrZhou/jol/actions/__;!!ACWV5N9M2RV99hQ!P70r0asuKtCGdObQmAdcGhG0rLQr0cET9P67prOfVy_5S6dFaR2RwXvShfC_Razwovj9RIiCsdRQmVDj$ -- and check that workflows are enabled? The PRs need to be tested, and workflows are supposed to run automatically. The tested has completed,thanks. ------------- PR: https://git.openjdk.org/jol/pull/29 From shade at openjdk.org Wed Jun 22 09:19:15 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 22 Jun 2022 09:19:15 GMT Subject: RFR: 7903214: JOL: Complete some TODOs in VMOptions In-Reply-To: References: Message-ID: On Mon, 20 Jun 2022 08:43:15 GMT, Steafan Chou wrote: > I'm sorry about the last commit, I forgot to update my branch. > I have updated the branch synchronously, please check the PR,thanks a lot. Ah, now I remember why these are not printed. On 32-bit VMs, where the options are not available, it would print unnecessary noise: # WARNING: Unable to get compressed oops. java.lang.IllegalArgumentException: VM option "UseCompressedOops" does not exist # WARNING: Unable to get compressed class pointersjava.lang.IllegalArgumentException: VM option "UseCompressedClassPointers" does not exist # WARNING: Unable to get compressed oops. java.lang.IllegalArgumentException: VM option "UseCompressedOops" does not exist # WARNING: the compressed oops is unavailable # Running 32-bit HotSpot VM. # Objects are 8 bytes aligned. # ref, bool, byte, char, shrt, int, flt, lng, dbl # Field sizes: 4, 1, 1, 2, 2, 4, 4, 8, 8 # Array element sizes: 4, 1, 1, 2, 2, 4, 4, 8, 8 # Array base offsets: 12, 12, 12, 12, 12, 12, 12, 16, 16 ... These warnings cannot be reasonably fixed by users, so there is no point in printing them. I suggest we just drop the `// TODO:` lines in this patch, and move on. ------------- Changes requested by shade (Committer). PR: https://git.openjdk.org/jol/pull/29 From duke at openjdk.org Wed Jun 22 09:29:03 2022 From: duke at openjdk.org (Steafan Chou) Date: Wed, 22 Jun 2022 09:29:03 GMT Subject: RFR: 7903214: JOL: Complete some TODOs in VMOptions [v2] In-Reply-To: References: Message-ID: <8y7j5KG3yMQgZY4OBjzMeidT5NdFUDwr2uWkdsHWxFE=.dfa6f83b-0125-47d8-9656-581f0120d0a7@github.com> > I'm sorry about the last commit, I forgot to update my branch. > I have updated the branch synchronously, please check the PR,thanks a lot. Steafan Chou has updated the pull request incrementally with one additional commit since the last revision: Remove some todos in VMOptions ------------- Changes: - all: https://git.openjdk.org/jol/pull/29/files - new: https://git.openjdk.org/jol/pull/29/files/414bffe1..38be272f Webrevs: - full: https://webrevs.openjdk.org/?repo=jol&pr=29&range=01 - incr: https://webrevs.openjdk.org/?repo=jol&pr=29&range=00-01 Stats: 4 lines in 1 file changed: 0 ins; 4 del; 0 mod Patch: https://git.openjdk.org/jol/pull/29.diff Fetch: git fetch https://git.openjdk.org/jol pull/29/head:pull/29 PR: https://git.openjdk.org/jol/pull/29 From duke at openjdk.org Wed Jun 22 09:29:06 2022 From: duke at openjdk.org (Steafan Chou) Date: Wed, 22 Jun 2022 09:29:06 GMT Subject: RFR: 7903214: JOL: Complete some TODOs in VMOptions In-Reply-To: References: Message-ID: On Mon, 20 Jun 2022 08:43:15 GMT, Steafan Chou wrote: > I'm sorry about the last commit, I forgot to update my branch. > I have updated the branch synchronously, please check the PR,thanks a lot. Alright,I changed for a later.just wait a minute. ------------- PR: https://git.openjdk.org/jol/pull/29 From shade at openjdk.org Wed Jun 22 09:33:15 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 22 Jun 2022 09:33:15 GMT Subject: RFR: 7903214: JOL: Complete some TODOs in VMOptions [v2] In-Reply-To: <8y7j5KG3yMQgZY4OBjzMeidT5NdFUDwr2uWkdsHWxFE=.dfa6f83b-0125-47d8-9656-581f0120d0a7@github.com> References: <8y7j5KG3yMQgZY4OBjzMeidT5NdFUDwr2uWkdsHWxFE=.dfa6f83b-0125-47d8-9656-581f0120d0a7@github.com> Message-ID: On Wed, 22 Jun 2022 09:29:03 GMT, Steafan Chou wrote: >> I'm sorry about the last commit, I forgot to update my branch. >> I have updated the branch synchronously, please check the PR,thanks a lot. > > Steafan Chou has updated the pull request incrementally with one additional commit since the last revision: > > Remove some todos in VMOptions Marked as reviewed by shade (Committer). ------------- PR: https://git.openjdk.org/jol/pull/29 From duke at openjdk.org Wed Jun 22 09:44:14 2022 From: duke at openjdk.org (Steafan Chou) Date: Wed, 22 Jun 2022 09:44:14 GMT Subject: RFR: 7903214: JOL: Complete some TODOs in VMOptions [v2] In-Reply-To: <8y7j5KG3yMQgZY4OBjzMeidT5NdFUDwr2uWkdsHWxFE=.dfa6f83b-0125-47d8-9656-581f0120d0a7@github.com> References: <8y7j5KG3yMQgZY4OBjzMeidT5NdFUDwr2uWkdsHWxFE=.dfa6f83b-0125-47d8-9656-581f0120d0a7@github.com> Message-ID: On Wed, 22 Jun 2022 09:29:03 GMT, Steafan Chou wrote: >> I'm sorry about the last commit, I forgot to update my branch. >> I have updated the branch synchronously, please check the PR,thanks a lot. > > Steafan Chou has updated the pull request incrementally with one additional commit since the last revision: > > Remove some todos in VMOptions Why can't PRs be merged, but integrated? How to become a Committer of this project?Thanks a lot. ------------- PR: https://git.openjdk.org/jol/pull/29 From shade at openjdk.org Wed Jun 22 09:44:15 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 22 Jun 2022 09:44:15 GMT Subject: RFR: 7903214: JOL: Complete some TODOs in VMOptions [v2] In-Reply-To: <8y7j5KG3yMQgZY4OBjzMeidT5NdFUDwr2uWkdsHWxFE=.dfa6f83b-0125-47d8-9656-581f0120d0a7@github.com> References: <8y7j5KG3yMQgZY4OBjzMeidT5NdFUDwr2uWkdsHWxFE=.dfa6f83b-0125-47d8-9656-581f0120d0a7@github.com> Message-ID: On Wed, 22 Jun 2022 09:29:03 GMT, Steafan Chou wrote: >> I'm sorry about the last commit, I forgot to update my branch. >> I have updated the branch synchronously, please check the PR,thanks a lot. > > Steafan Chou has updated the pull request incrementally with one additional commit since the last revision: > > Remove some todos in VMOptions Bots are handling all integrations to perform checks, do proper metadata updates, etc. This is how OpenJDK infra works. ------------- PR: https://git.openjdk.org/jol/pull/29 From duke at openjdk.org Wed Jun 22 09:49:19 2022 From: duke at openjdk.org (Steafan Chou) Date: Wed, 22 Jun 2022 09:49:19 GMT Subject: Integrated: 7903214: JOL: Complete some TODOs in VMOptions In-Reply-To: References: Message-ID: On Mon, 20 Jun 2022 08:43:15 GMT, Steafan Chou wrote: > I'm sorry about the last commit, I forgot to update my branch. > I have updated the branch synchronously, please check the PR,thanks a lot. This pull request has now been integrated. Changeset: 9fd21c96 Author: Steafan <244007461 at qq.com> Committer: Aleksey Shipilev URL: https://git.openjdk.org/jol/commit/9fd21c96a8f845b4e206635c038dcc07655b598b Stats: 4 lines in 1 file changed: 0 ins; 4 del; 0 mod 7903214: JOL: Complete some TODOs in VMOptions Reviewed-by: shade ------------- PR: https://git.openjdk.org/jol/pull/29 From shade at openjdk.org Wed Jun 22 10:02:13 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 22 Jun 2022 10:02:13 GMT Subject: RFR: 7903214: JOL: Complete some TODOs in VMOptions [v2] In-Reply-To: References: <8y7j5KG3yMQgZY4OBjzMeidT5NdFUDwr2uWkdsHWxFE=.dfa6f83b-0125-47d8-9656-581f0120d0a7@github.com> Message-ID: On Wed, 22 Jun 2022 09:40:20 GMT, Steafan Chou wrote: > How to become a Committer of this project? The same way as for the rest of OpenJDK and other OSS projects: accrue a track record of good contributions, reviews, involvement. ------------- PR: https://git.openjdk.org/jol/pull/29