From dmitry.bessonov at oracle.com Tue Sep 4 14:24:22 2018 From: dmitry.bessonov at oracle.com (dmitry.bessonov at oracle.com) Date: Tue, 04 Sep 2018 14:24:22 +0000 Subject: hg: code-tools/jtharness: 7902301: Remove reduntant 'new' expression in array creation Message-ID: <201809041424.w84EOMKX018181@aojmv0008.oracle.com> Changeset: 2213cfe265b5 Author: dbessono Date: 2018-09-04 16:09 +0200 URL: http://hg.openjdk.java.net/code-tools/jtharness/rev/2213cfe265b5 7902301: Remove reduntant 'new' expression in array creation Tool-assisted cleanup ! src/com/sun/interview/WizPrint.java ! src/com/sun/interview/YesNoQuestion.java ! src/com/sun/javatest/InterviewParameters.java ! src/com/sun/javatest/InterviewPropagator.java ! src/com/sun/javatest/TestResultCache.java ! src/com/sun/javatest/TestResultTable.java ! src/com/sun/javatest/agent/AgentApplet.java ! src/com/sun/javatest/agent/AgentFrame.java ! src/com/sun/javatest/exec/BasicSession.java ! src/com/sun/javatest/exec/FileSystemTableModel.java ! src/com/sun/javatest/exec/InterviewEditor.java ! src/com/sun/javatest/exec/template/TemplateSessionControl.java ! src/com/sun/javatest/mrep/OptionsPane.java ! src/com/sun/javatest/tool/WorkDirChooser.java From dmitry.bessonov at oracle.com Wed Sep 5 00:08:22 2018 From: dmitry.bessonov at oracle.com (dmitry.bessonov at oracle.com) Date: Wed, 05 Sep 2018 00:08:22 +0000 Subject: hg: code-tools/jtharness: 7902302: Remove reduntant 'throws' clause Message-ID: <201809050008.w8508MNw010672@aojmv0008.oracle.com> Changeset: 1575a3b9f49d Author: dbessono Date: 2018-09-05 01:00 +0100 URL: http://hg.openjdk.java.net/code-tools/jtharness/rev/1575a3b9f49d 7902302: Remove reduntant 'throws' clause Tool-assisted cleanup ! src/com/sun/interview/FloatQuestion.java ! src/com/sun/interview/HelpSetFactory.java ! src/com/sun/interview/InetAddressQuestion.java ! src/com/sun/interview/IntQuestion.java ! src/com/sun/interview/wizard/Exporter.java ! src/com/sun/interview/wizard/Wizard.java ! src/com/sun/javatest/AllTestsFilter.java ! src/com/sun/javatest/ExcludeList.java ! src/com/sun/javatest/Harness.java ! src/com/sun/javatest/KnownFailuresList.java ! src/com/sun/javatest/LastRunFilter.java ! src/com/sun/javatest/TestResultTable.java ! src/com/sun/javatest/TestSuite.java ! src/com/sun/javatest/WorkDirectory.java ! src/com/sun/javatest/agent/Agent.java ! src/com/sun/javatest/agent/AgentClassLoader2.java ! src/com/sun/javatest/agent/AgentMain.java ! src/com/sun/javatest/agent/AgentManager.java ! src/com/sun/javatest/agent/SerialPortConnection.java ! src/com/sun/javatest/audit/AuditCommandManager.java ! src/com/sun/javatest/audit/SummaryPane.java ! src/com/sun/javatest/batch/BatchManager.java ! src/com/sun/javatest/exec/ContextManager.java ! src/com/sun/javatest/exec/ExecModel.java ! src/com/sun/javatest/exec/ExecTool.java ! src/com/sun/javatest/exec/ExecToolManager.java ! src/com/sun/javatest/exec/TestTreePanel.java ! src/com/sun/javatest/exec/WorkDirChooseTool.java ! src/com/sun/javatest/finder/BinaryTestFinder.java ! src/com/sun/javatest/finder/HTMLTestFinder.java ! src/com/sun/javatest/junit/JUnitBareMultiTest.java ! src/com/sun/javatest/junit/JUnitTestRunner.java ! src/com/sun/javatest/lib/MultiTest.java ! src/com/sun/javatest/mrep/XMLReportReader.java ! src/com/sun/javatest/report/CustomReport.java ! src/com/sun/javatest/report/ReportManager.java ! src/com/sun/javatest/report/XMLReportMaker.java ! src/com/sun/javatest/services/LogWriter.java ! src/com/sun/javatest/services/ServiceManager.java ! src/com/sun/javatest/services/XMLServiceReader.java ! src/com/sun/javatest/servlets/ExcludeBrowser.java ! src/com/sun/javatest/servlets/ResultBrowser.java ! src/com/sun/javatest/tool/DesktopManager.java ! src/com/sun/javatest/tool/EnvironmentManager.java ! src/com/sun/javatest/tool/HttpManager.java ! src/com/sun/javatest/tool/Main.java ! src/com/sun/javatest/tool/VerboseCommand.java ! src/com/sun/javatest/util/PathClassLoader.java ! src/com/sun/jct/utils/glossarygen/Main.java ! src/com/sun/jct/utils/indexgen/Main.java ! src/com/sun/jct/utils/mapmerge/Main.java From dmitry.bessonov at oracle.com Wed Sep 5 00:35:08 2018 From: dmitry.bessonov at oracle.com (dmitry.bessonov at oracle.com) Date: Wed, 05 Sep 2018 00:35:08 +0000 Subject: hg: code-tools/jtharness: 7902303: Delete unused imports Message-ID: <201809050035.w850Z92k017139@aojmv0008.oracle.com> Changeset: 5626ea3de1c4 Author: dbessono Date: 2018-09-05 01:27 +0100 URL: http://hg.openjdk.java.net/code-tools/jtharness/rev/5626ea3de1c4 7902303: Delete unused imports Tool-assisted cleanup ! src/com/sun/interview/Help.java ! src/com/sun/interview/HelpSetFactory.java ! src/com/sun/interview/Interview.java ! src/com/sun/interview/InterviewSet.java ! src/com/sun/interview/wizard/selectiontree/SelectionTree.java ! src/com/sun/interview/wizard/selectiontree/SelectionTreeNode.java ! src/com/sun/javatest/FileParameters.java ! src/com/sun/javatest/InterviewPropagator.java ! src/com/sun/javatest/ResourceLoader.java ! src/com/sun/javatest/TestEnvContext.java ! src/com/sun/javatest/TestEnvironment.java ! src/com/sun/javatest/TestFinder.java ! src/com/sun/javatest/TestResultCache.java ! src/com/sun/javatest/TestResultTable.java ! src/com/sun/javatest/agent/Map.java ! src/com/sun/javatest/audit/OptionsDialog.java ! src/com/sun/javatest/batch/RunTestsCommand.java ! src/com/sun/javatest/exec/ExecModel.java ! src/com/sun/javatest/exec/ExecTool.java ! src/com/sun/javatest/exec/InterviewEditor.java ! src/com/sun/javatest/exec/MultiFormatPane.java ! src/com/sun/javatest/exec/NewReportDialog.java ! src/com/sun/javatest/exec/PrefsPane.java ! src/com/sun/javatest/exec/TP_PropertySubpanel.java ! src/com/sun/javatest/exec/TestTreeModel.java ! src/com/sun/javatest/exec/ToolBarPanel.java ! src/com/sun/javatest/exec/WorkDirChooseTool.java ! src/com/sun/javatest/finder/ExpandTestFinder.java ! src/com/sun/javatest/httpd/ProviderRegistry.java ! src/com/sun/javatest/httpd/RequestHandler.java ! src/com/sun/javatest/interview/TestsInterview.java ! src/com/sun/javatest/junit/JUnitBareMultiTest.java ! src/com/sun/javatest/junit/JUnitTestFinder.java ! src/com/sun/javatest/junit/JUnitTestSuite.java ! src/com/sun/javatest/lib/JavaCompileCommand.java ! src/com/sun/javatest/lib/KeywordScript.java ! src/com/sun/javatest/lib/ProcessCommand.java ! src/com/sun/javatest/logging/ErrorDialogHandler.java ! src/com/sun/javatest/moreInfo/ShowFile.java ! src/com/sun/javatest/mrep/OptionsPane.java ! src/com/sun/javatest/report/CustomReportFormat.java ! src/com/sun/javatest/report/KflPlainText.java ! src/com/sun/javatest/report/PlainTextReport.java ! src/com/sun/javatest/report/ResultSection.java ! src/com/sun/javatest/report/StatisticsSection.java ! src/com/sun/javatest/report/XMLReport.java ! src/com/sun/javatest/services/LogWriter.java ! src/com/sun/javatest/services/TestPath.java ! src/com/sun/javatest/servlets/ExcludeBrowser.java ! src/com/sun/javatest/servlets/ResultBrowser.java ! src/com/sun/javatest/tool/CustomPropagationController.java ! src/com/sun/javatest/tool/DeskView.java ! src/com/sun/javatest/tool/Desktop.java ! src/com/sun/javatest/tool/EditableList.java ! src/com/sun/javatest/tool/FocusMonitor.java ! src/com/sun/javatest/tool/HelpManager.java ! src/com/sun/javatest/tool/HelpMenu.java ! src/com/sun/javatest/tool/ManagerLoader.java ! src/com/sun/javatest/tool/Preferences.java ! src/com/sun/javatest/tool/PreferencesPane.java ! src/com/sun/javatest/tool/VerboseCommand.java ! src/com/sun/javatest/tool/selectiontree/SelectionTree.java ! src/com/sun/javatest/tool/selectiontree/SelectionTreeNode.java ! src/com/sun/javatest/util/BackupPolicy.java ! src/com/sun/javatest/util/DirectoryClassLoader.java ! src/com/sun/javatest/util/HelpTree.java ! src/com/sun/javatest/util/MainAppletContext.java ! src/com/sun/jct/utils/glossarygen/Main.java ! src/com/sun/jct/utils/mapmerge/Main.java From dmitry.bessonov at oracle.com Wed Sep 5 12:51:07 2018 From: dmitry.bessonov at oracle.com (dmitry.bessonov at oracle.com) Date: Wed, 05 Sep 2018 12:51:07 +0000 Subject: hg: code-tools/jtharness: 7902304: Fix 'throws' clause with subclassing exceptions Message-ID: <201809051251.w85Cp7cA018391@aojmv0008.oracle.com> Changeset: 1aca482dba53 Author: dbessono Date: 2018-09-05 13:43 +0100 URL: http://hg.openjdk.java.net/code-tools/jtharness/rev/1aca482dba53 7902304: Fix 'throws' clause with subclassing exceptions ! src/com/sun/javatest/WorkDirectory.java From dmitry.bessonov at oracle.com Wed Sep 5 13:47:10 2018 From: dmitry.bessonov at oracle.com (dmitry.bessonov at oracle.com) Date: Wed, 05 Sep 2018 13:47:10 +0000 Subject: hg: code-tools/jtharness: 7902305: Restoring some of the legacy 'throws' clause to soften client migration Message-ID: <201809051347.w85DlAWd005242@aojmv0008.oracle.com> Changeset: cc572fa65b25 Author: dbessono Date: 2018-09-05 14:39 +0100 URL: http://hg.openjdk.java.net/code-tools/jtharness/rev/cc572fa65b25 7902305: Restoring some of the legacy 'throws' clause to soften client migration ! src/com/sun/interview/InetAddressQuestion.java ! src/com/sun/javatest/TestSuite.java From dmitry.bessonov at oracle.com Wed Sep 5 14:08:30 2018 From: dmitry.bessonov at oracle.com (dmitry.bessonov at oracle.com) Date: Wed, 05 Sep 2018 14:08:30 +0000 Subject: hg: code-tools/jtharness: 7902306: Replacing StringBuffer with StringBuilder Message-ID: <201809051408.w85E8V7x011942@aojmv0008.oracle.com> Changeset: 450a8546d4cf Author: dbessono Date: 2018-09-05 15:00 +0100 URL: http://hg.openjdk.java.net/code-tools/jtharness/rev/450a8546d4cf 7902306: Replacing StringBuffer with StringBuilder Tool-assisted cleanup ! src/com/sun/interview/ChoiceArrayQuestion.java ! src/com/sun/interview/FileListQuestion.java ! src/com/sun/interview/Interview.java ! src/com/sun/interview/Properties2.java ! src/com/sun/interview/PropertiesQuestion.java ! src/com/sun/interview/StringListQuestion.java ! src/com/sun/interview/TreeQuestion.java ! src/com/sun/interview/WizPrint.java ! src/com/sun/interview/wizard/InetAddressQuestionRenderer.java ! src/com/sun/interview/wizard/ListQuestionRenderer.java ! src/com/sun/interview/wizard/PathPanel.java ! src/com/sun/interview/wizard/Wizard.java ! src/com/sun/javatest/EditLinks.java ! src/com/sun/javatest/ExcludeList.java ! src/com/sun/javatest/HarnessHttpHandler.java ! src/com/sun/javatest/InterviewPropagator.java ! src/com/sun/javatest/LastRunInfo.java ! src/com/sun/javatest/Script.java ! src/com/sun/javatest/Status.java ! src/com/sun/javatest/TRT_HttpHandler.java ! src/com/sun/javatest/TestEnvironment.java ! src/com/sun/javatest/TestResult.java ! src/com/sun/javatest/agent/ActiveAgentPool.java ! src/com/sun/javatest/agent/AgentMain.java ! src/com/sun/javatest/agent/SocketConnection.java ! src/com/sun/javatest/exec/BP_TestListSubpanel.java ! src/com/sun/javatest/exec/CE_EnvironmentPane.java ! src/com/sun/javatest/exec/CE_TestsPane.java ! src/com/sun/javatest/exec/ChecklistBrowser.java ! src/com/sun/javatest/exec/ExcludeListBrowser.java ! src/com/sun/javatest/exec/FileType.java ! src/com/sun/javatest/exec/QuickStartWizard.java ! src/com/sun/javatest/exec/TT_BasicNode.java ! src/com/sun/javatest/exec/TT_TestNode.java ! src/com/sun/javatest/exec/TestSuiteErrorsDialog.java ! src/com/sun/javatest/exec/TestTreePanel.java ! src/com/sun/javatest/finder/HTMLTestFinder.java ! src/com/sun/javatest/httpd/PageGenerator.java ! src/com/sun/javatest/httpd/RequestHandler.java ! src/com/sun/javatest/httpd/httpURL.java ! src/com/sun/javatest/interview/KeywordsInterview.java ! src/com/sun/javatest/interview/SimpleInterviewParameters.java ! src/com/sun/javatest/logging/ErrorDialogHandler.java ! src/com/sun/javatest/logging/JTFormatter.java ! src/com/sun/javatest/logging/LogModel.java ! src/com/sun/javatest/moreInfo/ShowFile.java ! src/com/sun/javatest/report/ConfigSection.java ! src/com/sun/javatest/report/HTMLSection.java ! src/com/sun/javatest/report/ReportSettings.java ! src/com/sun/javatest/report/XMLReportMaker.java ! src/com/sun/javatest/servlets/ExcludeBrowser.java ! src/com/sun/javatest/servlets/ResultBrowser.java ! src/com/sun/javatest/tool/Command.java ! src/com/sun/javatest/tool/ConfigManager.java ! src/com/sun/javatest/tool/FocusMonitor.java ! src/com/sun/javatest/tool/StringFitter.java ! src/com/sun/javatest/tool/UIFactory.java ! src/com/sun/javatest/util/Debug.java ! src/com/sun/javatest/util/I18NResourceBundle.java ! src/com/sun/javatest/util/PropertyUtils.java ! src/com/sun/javatest/util/StringArray.java ! src/com/sun/jct/utils/glossarygen/Main.java ! src/com/sun/jct/utils/indexgen/Main.java ! src/com/sun/jct/utils/mapmerge/Main.java From dmitry.bessonov at oracle.com Wed Sep 5 14:30:33 2018 From: dmitry.bessonov at oracle.com (dmitry.bessonov at oracle.com) Date: Wed, 05 Sep 2018 14:30:33 +0000 Subject: hg: code-tools/jtharness: 7902307: Simplify String::equals("") Message-ID: <201809051430.w85EUYkd018364@aojmv0008.oracle.com> Changeset: 608c91232258 Author: dbessono Date: 2018-09-05 15:19 +0100 URL: http://hg.openjdk.java.net/code-tools/jtharness/rev/608c91232258 7902307: Simplify String::equals("") Tool-assisted cleanup ! src/com/sun/interview/wizard/Wizard.java ! src/com/sun/javatest/TestFinder.java ! src/com/sun/javatest/TestSuite.java ! src/com/sun/javatest/exec/BP_TestListSubpanel.java ! src/com/sun/javatest/exec/LogViewer.java ! src/com/sun/javatest/exec/NewReportDialog.java ! src/com/sun/javatest/exec/RunTestsHandler.java ! src/com/sun/javatest/exec/WorkDirChooseTool.java ! src/com/sun/javatest/finder/ExpandTestFinder.java ! src/com/sun/javatest/logging/FilteredLogModel.java ! src/com/sun/javatest/mrep/FilesPane.java ! src/com/sun/javatest/mrep/ReportDirChooser.java ! src/com/sun/javatest/mrep/XMLReportWriter.java ! src/com/sun/javatest/report/ReportDirChooser.java ! src/com/sun/javatest/report/StatisticsSection.java ! src/com/sun/javatest/report/XMLReportMaker.java ! src/com/sun/javatest/servlets/ResultBrowser.java ! src/com/sun/javatest/tool/SelectedWorkDirApprover.java ! src/com/sun/javatest/tool/TestSuiteChooser.java ! src/com/sun/javatest/tool/ToolDialog.java ! src/com/sun/javatest/tool/WorkDirChooser.java ! src/com/sun/javatest/util/BackupUtil.java From dmitry.bessonov at oracle.com Wed Sep 5 14:47:44 2018 From: dmitry.bessonov at oracle.com (dmitry.bessonov at oracle.com) Date: Wed, 05 Sep 2018 14:47:44 +0000 Subject: hg: code-tools/jtharness: 7902308: Replace concatenation with an empty string with String.valueOf Message-ID: <201809051447.w85EliTX023100@aojmv0008.oracle.com> Changeset: 364cb5a1098d Author: dbessono Date: 2018-09-05 15:37 +0100 URL: http://hg.openjdk.java.net/code-tools/jtharness/rev/364cb5a1098d 7902308: Replace concatenation with an empty string with String.valueOf ! src/com/sun/javatest/exec/ExcludeListBrowser.java ! src/com/sun/javatest/exec/LogViewerTools.java ! src/com/sun/javatest/finder/HTMLTestFinder.java ! src/com/sun/javatest/logging/LogModel.java ! src/com/sun/javatest/mrep/OptionsDialog.java From jonathan.gibbons at oracle.com Wed Sep 5 15:15:55 2018 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 5 Sep 2018 08:15:55 -0700 Subject: hg: code-tools/jtharness: 7902304: Fix 'throws' clause with subclassing exceptions In-Reply-To: <201809051251.w85Cp7cA018391@aojmv0008.oracle.com> References: <201809051251.w85Cp7cA018391@aojmv0008.oracle.com> Message-ID: <62e4a4dd-667c-dd60-c238-9f6c3e260ac9@oracle.com> This one I disagree with. I would recommend reverting it. Yes, FileNotFoundException is a subtype of IOException, but it is reasonable to handle it differently, as shown in the lines you have deleted: - } // try - catch (FileNotFoundException e) { - throw new BadDirectoryFault(i18n, "wd.noTestSuiteFile", canonDir); } catch (IOException e) { throw new BadDirectoryFault(i18n, "wd.badTestSuiteFile", canonDir, e); } catch (TestSuite.Fault e) { Notice the error message is different. -- Jon On 9/5/18 5:51 AM, dmitry.bessonov at oracle.com wrote: > Changeset: 1aca482dba53 > Author: dbessono > Date: 2018-09-05 13:43 +0100 > URL: http://hg.openjdk.java.net/code-tools/jtharness/rev/1aca482dba53 > > 7902304: Fix 'throws' clause with subclassing exceptions > > ! src/com/sun/javatest/WorkDirectory.java > From dmitry.bessonov at oracle.com Wed Sep 5 16:49:17 2018 From: dmitry.bessonov at oracle.com (dmitry.bessonov at oracle.com) Date: Wed, 5 Sep 2018 17:49:17 +0100 Subject: hg: code-tools/jtharness: 7902304: Fix 'throws' clause with subclassing exceptions In-Reply-To: <62e4a4dd-667c-dd60-c238-9f6c3e260ac9@oracle.com> References: <201809051251.w85Cp7cA018391@aojmv0008.oracle.com> <62e4a4dd-667c-dd60-c238-9f6c3e260ac9@oracle.com> Message-ID: As I can see that the only case when FileNotFoundException could be thrown is creating a FileInputStream from "workdir/jtData" file and the following happens: " - if the file does not exist, is a directory rather than a regular file, or for some other reason cannot be opened for reading" but later in the lines which were removed the original exception is dropped and instead an unclear and very generic message is provided: wd.noTestSuiteFile=Cannot determine the test suite for the work directory {0}. While after the changes below: 1. exception instance is passed to the BadDirectoryFault wrapper 2. the message is "wd.badTestSuiteFile=Problem reading test suite data for work directory {0}.\n{1}" which generally looks like an improvement. I can revert to the legacy state... at least providing FileNotFoundException instance to the wrapper to reduce the confusion. dmitry On 05/09/2018 16:15, Jonathan Gibbons wrote: > This one I disagree with. I would recommend reverting it. > > Yes, FileNotFoundException is a subtype of IOException, but it > is reasonable to handle it differently, as shown in the lines you > have deleted: > > - } // try > - catch (FileNotFoundException e) { > - throw new BadDirectoryFault(i18n, "wd.noTestSuiteFile", canonDir); > } catch (IOException e) { > throw new BadDirectoryFault(i18n, "wd.badTestSuiteFile", canonDir, e); > } catch (TestSuite.Fault e) { > > > Notice the error message is different. > > -- Jon > > On 9/5/18 5:51 AM, dmitry.bessonov at oracle.com wrote: >> Changeset: 1aca482dba53 >> Author: dbessono >> Date: 2018-09-05 13:43 +0100 >> URL:http://hg.openjdk.java.net/code-tools/jtharness/rev/1aca482dba53 >> >> 7902304: Fix 'throws' clause with subclassing exceptions >> >> ! src/com/sun/javatest/WorkDirectory.java >> > From jonathan.gibbons at oracle.com Wed Sep 5 16:55:41 2018 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 5 Sep 2018 09:55:41 -0700 Subject: hg: code-tools/jtharness: 7902304: Fix 'throws' clause with subclassing exceptions In-Reply-To: References: <201809051251.w85Cp7cA018391@aojmv0008.oracle.com> <62e4a4dd-667c-dd60-c238-9f6c3e260ac9@oracle.com> Message-ID: OK, sounds like you've thought it through, and it is more than just a false positive found by the IDE. My primary general concern is to try and give better, more meaningful messages to to the user, and generally "file not found" is more informative than "Some IO problem happened."? That's all. It may not apply here, but I also note that (as a general rule) it is good not to directly pass exceptions up too may levels, since you may lose context when doing so ... what may be meaningful low down may be less so at higher levels. -- Jon On 9/5/18 9:49 AM, dmitry.bessonov at oracle.com wrote: > As I can see that the only case when FileNotFoundException could be > thrown is creating a FileInputStream from "workdir/jtData" file and > the following happens: > " - if the file does not exist, is a directory rather than a regular > file, or for some other reason cannot be opened for reading" > but later in the lines which were removed the original exception is > dropped and instead an unclear and very generic message is provided: > > wd.noTestSuiteFile=Cannot determine the test suite for the work > directory {0}. > > While after the changes below: > 1. exception instance is passed to the BadDirectoryFault wrapper > 2. the message is > "wd.badTestSuiteFile=Problem reading test suite data for work > directory {0}.\n{1}" > > which generally looks like an improvement. > > I can revert to the legacy state... at least providing > FileNotFoundException instance to the wrapper to reduce the confusion. > > > dmitry > > > On 05/09/2018 16:15, Jonathan Gibbons wrote: >> This one I disagree with. I would recommend reverting it. >> >> Yes, FileNotFoundException is a subtype of IOException, but it >> is reasonable to handle it differently, as shown in the lines you >> have deleted: >> >> - } // try >> - catch (FileNotFoundException e) { >> - throw new BadDirectoryFault(i18n, "wd.noTestSuiteFile", canonDir); >> } catch (IOException e) { >> throw new BadDirectoryFault(i18n, "wd.badTestSuiteFile", canonDir, e); >> } catch (TestSuite.Fault e) { >> >> >> Notice the error message is different. >> >> -- Jon >> >> On 9/5/18 5:51 AM, dmitry.bessonov at oracle.com wrote: >>> Changeset: 1aca482dba53 >>> Author:??? dbessono >>> Date:????? 2018-09-05 13:43 +0100 >>> URL:http://hg.openjdk.java.net/code-tools/jtharness/rev/1aca482dba53 >>> >>> 7902304: Fix 'throws' clause with subclassing exceptions >>> >>> ! src/com/sun/javatest/WorkDirectory.java >>> >> From dmitry.bessonov at oracle.com Wed Sep 5 18:28:35 2018 From: dmitry.bessonov at oracle.com (dmitry.bessonov at oracle.com) Date: Wed, 05 Sep 2018 18:28:35 +0000 Subject: hg: code-tools/jtharness: 7902310: Update 'throws' clause with subclassing exceptions and improve exception handling Message-ID: <201809051828.w85ISZlA000490@aojmv0008.oracle.com> Changeset: a17e47097405 Author: dbessono Date: 2018-09-05 19:20 +0100 URL: http://hg.openjdk.java.net/code-tools/jtharness/rev/a17e47097405 7902310: Update 'throws' clause with subclassing exceptions and improve exception handling ! src/com/sun/javatest/WorkDirectory.java From dmitry.bessonov at oracle.com Thu Sep 6 14:56:55 2018 From: dmitry.bessonov at oracle.com (dmitry.bessonov at oracle.com) Date: Thu, 06 Sep 2018 14:56:55 +0000 Subject: hg: code-tools/jtharness: 7902175: String values are compared using '==', not 'equals()' Message-ID: <201809061456.w86EutQa002983@aojmv0008.oracle.com> Changeset: e481ff68ee0e Author: dbessono Date: 2018-09-06 15:43 +0100 URL: http://hg.openjdk.java.net/code-tools/jtharness/rev/e481ff68ee0e 7902175: String values are compared using '==', not 'equals()' ! src/com/sun/interview/Question.java ! src/com/sun/interview/wizard/ChoiceQuestionRenderer.java ! src/com/sun/javatest/EditLinks.java ! src/com/sun/javatest/TRT_TreeNode.java ! src/com/sun/javatest/TestResult.java ! src/com/sun/javatest/TestResultTable.java ! src/com/sun/javatest/agent/Map.java ! src/com/sun/javatest/exec/BasicCustomTestFilter.java ! src/com/sun/javatest/exec/InterviewEditor.java ! src/com/sun/javatest/exec/TP_OutputSubpanel.java ! src/com/sun/javatest/exec/template/TemplateSession.java ! src/com/sun/javatest/finder/HTMLTestFinder.java ! src/com/sun/javatest/interview/ExcludeListInterview.java ! src/com/sun/javatest/interview/KeywordsInterview.java ! src/com/sun/javatest/interview/KnownFailuresListInterview.java ! src/com/sun/javatest/interview/PriorStatusInterview.java ! src/com/sun/javatest/interview/TestsInterview.java ! src/com/sun/jct/utils/glossarygen/Main.java ! src/com/sun/jct/utils/indexgen/Main.java ! src/com/sun/jct/utils/mapmerge/Main.java From dmitry.bessonov at oracle.com Thu Sep 6 17:00:32 2018 From: dmitry.bessonov at oracle.com (dmitry.bessonov at oracle.com) Date: Thu, 06 Sep 2018 17:00:32 +0000 Subject: hg: code-tools/jtharness: 7902311: Unchecked exception declared in 'throws' clause Message-ID: <201809061700.w86H0W2o009751@aojmv0008.oracle.com> Changeset: 2e0d3ac88393 Author: dbessono Date: 2018-09-06 17:28 +0100 URL: http://hg.openjdk.java.net/code-tools/jtharness/rev/2e0d3ac88393 7902311: Unchecked exception declared in 'throws' clause ! src/com/sun/interview/Interview.java ! src/com/sun/interview/wizard/I18NResourceBundle.java ! src/com/sun/interview/wizard/QuestionPanel.java ! src/com/sun/javatest/Harness.java ! src/com/sun/javatest/Status.java ! src/com/sun/javatest/TestDescription.java ! src/com/sun/javatest/TestFinder.java ! src/com/sun/javatest/TestResultCache.java ! src/com/sun/javatest/agent/Agent.java ! src/com/sun/javatest/exec/NavigationPane.java ! src/com/sun/javatest/exec/WorkDirChooseTool.java ! src/com/sun/javatest/httpd/ProviderRegistry.java ! src/com/sun/javatest/report/Report.java ! src/com/sun/javatest/tool/ToolDialog.java ! src/com/sun/javatest/tool/UIFactory.java ! src/com/sun/javatest/util/BackupPolicy.java ! src/com/sun/javatest/util/I18NResourceBundle.java From dmitry.bessonov at oracle.com Fri Sep 7 10:07:35 2018 From: dmitry.bessonov at oracle.com (dmitry.bessonov at oracle.com) Date: Fri, 07 Sep 2018 10:07:35 +0000 Subject: hg: code-tools/jtharness: 7902313: 'String::indexOf()' is replaceable with a simpler 'String::contains()' Message-ID: <201809071007.w87A7aZW016866@aojmv0008.oracle.com> Changeset: 4c0c53e4ada5 Author: dbessono Date: 2018-09-07 09:57 +0100 URL: http://hg.openjdk.java.net/code-tools/jtharness/rev/4c0c53e4ada5 7902313: 'String::indexOf()' is replaceable with a simpler 'String::contains()' ! src/com/sun/interview/StringListQuestion.java ! src/com/sun/javatest/ExcludeList.java ! src/com/sun/javatest/FileParameters.java ! src/com/sun/javatest/TRT_Iterator.java ! src/com/sun/javatest/TestEnvironment.java ! src/com/sun/javatest/TestFinderQueue.java ! src/com/sun/javatest/exec/MultiFormatPane.java ! src/com/sun/javatest/interview/EnvironmentInterview.java ! src/com/sun/javatest/junit/JUnitBareMultiTest.java ! src/com/sun/javatest/logging/FilteredLogModel.java ! src/com/sun/javatest/mrep/FilesPane.java ! src/com/sun/javatest/tool/CommandParser.java From dmitry.bessonov at oracle.com Fri Sep 7 12:11:53 2018 From: dmitry.bessonov at oracle.com (dmitry.bessonov at oracle.com) Date: Fri, 07 Sep 2018 12:11:53 +0000 Subject: hg: code-tools/jtharness: 7902314: Remove empty unused methods Message-ID: <201809071211.w87CBr6B022320@aojmv0008.oracle.com> Changeset: 02536721de06 Author: dbessono Date: 2018-09-07 13:01 +0100 URL: http://hg.openjdk.java.net/code-tools/jtharness/rev/02536721de06 7902314: Remove empty unused methods ! src/com/sun/interview/wizard/PathPanel.java ! src/com/sun/interview/wizard/QuestionPanel.java ! src/com/sun/javatest/audit/SummaryPane.java ! src/com/sun/javatest/exec/EmptyTestTreeModel.java ! src/com/sun/javatest/exec/EnvironmentBrowser.java ! src/com/sun/javatest/exec/TestTreePanel.java From dmitry.bessonov at oracle.com Sun Sep 9 10:37:15 2018 From: dmitry.bessonov at oracle.com (dmitry.bessonov at oracle.com) Date: Sun, 09 Sep 2018 10:37:15 +0000 Subject: hg: code-tools/jtharness: 7902315: Remove reduntant local variables Message-ID: <201809091037.w89AbFOW019860@aojmv0008.oracle.com> Changeset: c2593698e1d5 Author: dbessono Date: 2018-09-08 23:29 +0100 URL: http://hg.openjdk.java.net/code-tools/jtharness/rev/c2593698e1d5 7902315: Remove reduntant local variables ! src/com/sun/interview/Interview.java ! src/com/sun/interview/JavaHelpFactory.java ! src/com/sun/interview/WizEdit.java ! src/com/sun/interview/wizard/InfoPanel.java ! src/com/sun/interview/wizard/ListQuestionRenderer.java ! src/com/sun/javatest/Harness.java ! src/com/sun/javatest/ResourceLoader.java ! src/com/sun/javatest/TRT_TreeNode.java ! src/com/sun/javatest/TestResultTable.java ! src/com/sun/javatest/agent/AgentApplet.java ! src/com/sun/javatest/agent/AgentManager.java ! src/com/sun/javatest/agent/AgentPanel.java ! src/com/sun/javatest/agent/Deck.java ! src/com/sun/javatest/agent/SerialPortConnectionFactory.java ! src/com/sun/javatest/exec/BasicCustomTestFilter.java ! src/com/sun/javatest/exec/ET_FilterHandler.java ! src/com/sun/javatest/exec/JavaTestToolBar.java ! src/com/sun/javatest/exec/NavigationPane.java ! src/com/sun/javatest/exec/NewReportDialog.java ! src/com/sun/javatest/exec/RenderingUtilities.java ! src/com/sun/javatest/exec/ReportBrowser.java ! src/com/sun/javatest/exec/TT_NodeCache.java ! src/com/sun/javatest/junit/JUnitAnnotationMultiTest.java ! src/com/sun/javatest/lib/APIScript.java ! src/com/sun/javatest/logging/ObservedFile.java ! src/com/sun/javatest/moreInfo/ShowFileBeanInfo.java ! src/com/sun/javatest/mrep/BrowserPane.java ! src/com/sun/javatest/mrep/ReportTool.java ! src/com/sun/javatest/mrep/XMLReportWriter.java ! src/com/sun/javatest/report/TestResultsByFileComparator.java ! src/com/sun/javatest/services/AntService.java ! src/com/sun/javatest/services/ProcessExecutor.java ! src/com/sun/javatest/tool/ConfigManager.java ! src/com/sun/javatest/tool/FocusMonitor.java ! src/com/sun/javatest/tool/HelpLinkBeanInfo.java ! src/com/sun/javatest/tool/HelpMenu.java ! src/com/sun/javatest/tool/IconFactory.java ! src/com/sun/javatest/tool/IconLabelBeanInfo.java ! src/com/sun/javatest/tool/MDIDeskView.java ! src/com/sun/javatest/tool/ManagerLoader.java ! src/com/sun/javatest/tool/SDIDeskView.java ! src/com/sun/javatest/tool/UIFactory.java ! src/com/sun/javatest/util/Debug.java From dmitry.bessonov at oracle.com Thu Sep 13 17:19:29 2018 From: dmitry.bessonov at oracle.com (dmitry.bessonov at oracle.com) Date: Thu, 13 Sep 2018 17:19:29 +0000 Subject: hg: code-tools/jtharness: 7902318: com.sun.javatest.agent.Map class deserves a better name Message-ID: <201809131719.w8DHJTSt013797@aojmv0008.oracle.com> Changeset: 88da62e220e0 Author: dbessono Date: 2018-09-13 15:52 +0100 URL: http://hg.openjdk.java.net/code-tools/jtharness/rev/88da62e220e0 7902318: com.sun.javatest.agent.Map class deserves a better name ! src/com/sun/javatest/agent/Agent.java ! src/com/sun/javatest/agent/AgentApplet.java ! src/com/sun/javatest/agent/AgentFrame.java ! src/com/sun/javatest/agent/AgentMain.java ! src/com/sun/javatest/agent/AgentPanel.java + src/com/sun/javatest/agent/ConfigValuesMap.java - src/com/sun/javatest/agent/Map.java From dmitry.bessonov at oracle.com Fri Sep 14 13:45:40 2018 From: dmitry.bessonov at oracle.com (dmitry.bessonov at oracle.com) Date: Fri, 14 Sep 2018 13:45:40 +0000 Subject: hg: code-tools/jtharness: 7902320: Declaring variables with a weaker type Message-ID: <201809141345.w8EDje2k012210@aojmv0008.oracle.com> Changeset: 7fceceace84b Author: dbessono Date: 2018-09-14 14:21 +0100 URL: http://hg.openjdk.java.net/code-tools/jtharness/rev/7fceceace84b 7902320: Declaring variables with a weaker type ! src/com/sun/interview/FileListQuestion.java ! src/com/sun/interview/Interview.java ! src/com/sun/interview/wizard/selectiontree/SelectionTree.java ! src/com/sun/javatest/Harness.java ! src/com/sun/javatest/InterviewPropagator.java ! src/com/sun/javatest/TRT_Iterator.java ! src/com/sun/javatest/TRT_TreeNode.java ! src/com/sun/javatest/TestResultTable.java ! src/com/sun/javatest/agent/AgentMonitorBatchCommandManager.java ! src/com/sun/javatest/batch/ObserverCommand.java ! src/com/sun/javatest/exec/BP_BranchSubpanel.java ! src/com/sun/javatest/exec/BasicSessionControl.java ! src/com/sun/javatest/exec/ET_FilterHandler.java ! src/com/sun/javatest/exec/EmptyTestTreeModel.java ! src/com/sun/javatest/exec/LogViewer.java ! src/com/sun/javatest/exec/NewReportDialog.java ! src/com/sun/javatest/exec/ReportHandler.java ! src/com/sun/javatest/exec/RunTestsHandler.java ! src/com/sun/javatest/exec/TT_NodeCache.java ! src/com/sun/javatest/exec/TestTreeModel.java ! src/com/sun/javatest/exec/TestTreePanel.java ! src/com/sun/javatest/exec/ToolBarPanel.java ! src/com/sun/javatest/interview/TestsInterview.java ! src/com/sun/javatest/junit/JUnitBareMultiTest.java ! src/com/sun/javatest/junit/JUnitSuperTestFinder.java ! src/com/sun/javatest/logging/FilteredLogModel.java ! src/com/sun/javatest/logging/LogModel.java ! src/com/sun/javatest/logging/ObservedFile.java ! src/com/sun/javatest/report/CustomReportFormat.java ! src/com/sun/javatest/services/ServiceManager.java ! src/com/sun/javatest/tool/ConfigManager.java ! src/com/sun/javatest/tool/HelpMenu.java ! src/com/sun/javatest/tool/LogManager.java From dmitry.bessonov at oracle.com Tue Sep 25 15:07:47 2018 From: dmitry.bessonov at oracle.com (dmitry.bessonov at oracle.com) Date: Tue, 25 Sep 2018 15:07:47 +0000 Subject: hg: code-tools/jtharness: 7902325: Imports cleanup - java.lang.*, same package, unused Message-ID: <201809251507.w8PF7lba021439@aojmv0008.oracle.com> Changeset: 4e81a6dee721 Author: dbessono Date: 2018-09-25 16:02 +0100 URL: http://hg.openjdk.java.net/code-tools/jtharness/rev/4e81a6dee721 7902325: Imports cleanup - java.lang.*, same package, unused ! src/com/sun/interview/wizard/QuestionPanel.java ! src/com/sun/javatest/JavaTestSecurityManager.java ! src/com/sun/javatest/batch/ObserverCommand.java ! src/com/sun/javatest/exec/WorkDirChooseTool.java ! src/com/sun/javatest/interview/SimpleInterviewParameters.java ! src/com/sun/javatest/lib/MultiTest.java ! src/com/sun/javatest/tool/EnvironmentManager.java ! src/com/sun/javatest/tool/WDC_FileView.java From dmitry.bessonov at oracle.com Wed Sep 26 01:17:28 2018 From: dmitry.bessonov at oracle.com (dmitry.bessonov at oracle.com) Date: Wed, 26 Sep 2018 01:17:28 +0000 Subject: hg: code-tools/jtharness: 7902327: Restore support for COF feature Message-ID: <201809260117.w8Q1HSaJ009922@aojmv0008.oracle.com> Changeset: 52f2983b7255 Author: dbessono Date: 2018-09-26 02:09 +0100 URL: http://hg.openjdk.java.net/code-tools/jtharness/rev/52f2983b7255 7902327: Restore support for COF feature ! build/com.sun.javatest.report.ReportFormat ! src/com/sun/javatest/TestResult.java + src/com/sun/javatest/cof/COF1_0.xsd + src/com/sun/javatest/cof/COF2_0_2.xsd + src/com/sun/javatest/cof/COFApplication.java + src/com/sun/javatest/cof/COFApplications.java + src/com/sun/javatest/cof/COFData.java + src/com/sun/javatest/cof/COFEnvironment.java + src/com/sun/javatest/cof/COFEnvironments.java + src/com/sun/javatest/cof/COFItem.java + src/com/sun/javatest/cof/COFOS.java + src/com/sun/javatest/cof/COFReportAnnotation.java + src/com/sun/javatest/cof/COFReportAnnotations.java + src/com/sun/javatest/cof/COFSWEntities.java + src/com/sun/javatest/cof/COFSWEntity.java + src/com/sun/javatest/cof/COFStatus.java + src/com/sun/javatest/cof/COFTest.java + src/com/sun/javatest/cof/COFTestAttribute.java + src/com/sun/javatest/cof/COFTestAttributes.java + src/com/sun/javatest/cof/COFTestCase.java + src/com/sun/javatest/cof/COFTestCases.java + src/com/sun/javatest/cof/COFTestSuite.java + src/com/sun/javatest/cof/COFTestSuites.java + src/com/sun/javatest/cof/CustomFilter.java + src/com/sun/javatest/cof/CustomFilterAdapter.java + src/com/sun/javatest/cof/ID.java + src/com/sun/javatest/cof/MTL.java + src/com/sun/javatest/cof/Main.java + src/com/sun/javatest/cof/Report.java + src/com/sun/javatest/cof/i18n.properties + src/com/sun/javatest/report/COFReport.java