From dbessono at openjdk.java.net Thu Apr 2 14:18:47 2020 From: dbessono at openjdk.java.net (Dmitry Bessonov) Date: Thu, 2 Apr 2020 14:18:47 GMT Subject: git: openjdk/jtharness: (configuration) corrected .jcheck/conf Message-ID: Changeset: 47d3e26a Author: Dmitry Bessonov Date: 2020-04-02 15:18:21 +0000 URL: https://git.openjdk.java.net/jtharness/commit/47d3e26a (configuration) corrected .jcheck/conf ! .jcheck/conf From dmitry.bessonov at oracle.com Thu Apr 2 16:21:37 2020 From: dmitry.bessonov at oracle.com (Dmitry Bessonov) Date: Thu, 2 Apr 2020 17:21:37 +0100 Subject: (done) Re: Transition to Git and GitHub on April 2 In-Reply-To: <8309E809-EF7F-4F82-A7AF-37176838F1D6@oracle.com> References: <426AA490-7F7F-46B4-BDBD-05C573905BD5@oracle.com> <8309E809-EF7F-4F82-A7AF-37176838F1D6@oracle.com> Message-ID: <2CF9737F-CDDF-4ED0-BC3E-556582162488@oracle.com> JTHarness has successfully transitioned to GitHub: https://github.com/openjdk/jtharness dmitry > On 27 Mar 2020, at 17:56, Dmitry Bessonov wrote: > > > >> On 27 Mar 2020, at 17:48, Dmitry Bessonov wrote: >> >> Hi, >> >> As announced on code-tools-dev at openjdk.java.net [0], we are interested in moving JTHarness to Git, GitHub and Skara. We suggest that JTHarness transition to https://github.com/openjdk/jtharnesson on April 2. > > Correct URL - https://github.com/openjdk/jtharness > >> >> For more information about what a transition entails, please see the original announcement. >> >> kind regards, >> dmitry >> >> [0]: https://mail.openjdk.java.net/pipermail/code-tools-dev/2020-March/000576.html > From dbessono at openjdk.java.net Fri Apr 3 22:16:01 2020 From: dbessono at openjdk.java.net (Dmitry Bessonov) Date: Fri, 3 Apr 2020 22:16:01 GMT Subject: git: openjdk/jtharness: (regression tests/cleanup) removed unnecessary overriding method Message-ID: <23a52c9e-eec2-4049-bb4d-d2e89090d9d4@openjdk.org> Changeset: 65b504f4 Author: Dmitry Bessonov Date: 2020-04-03 23:14:52 +0000 URL: https://git.openjdk.java.net/jtharness/commit/65b504f4 (regression tests/cleanup) removed unnecessary overriding method ! unit-tests/com/sun/javatest/functional/basic2/AllTestsRun.java From dbessono at openjdk.java.net Fri Apr 3 23:10:02 2020 From: dbessono at openjdk.java.net (Dmitry Bessonov) Date: Fri, 3 Apr 2020 23:10:02 GMT Subject: git: openjdk/jtharness: 3 new changesets Message-ID: <8db14dee-c473-449e-a7b1-2758d854fd16@openjdk.org> Changeset: cd8cd0ad Author: Dmitry Bessonov Date: 2020-04-03 23:19:30 +0000 URL: https://git.openjdk.java.net/jtharness/commit/cd8cd0ad (regression tests/cleanup) TestEnvTest: now using enhanced 'for' loop ! unit-tests/com/sun/javatest/TestEnvTest.java Changeset: e47d8a82 Author: Dmitry Bessonov Date: 2020-04-03 23:27:27 +0000 URL: https://git.openjdk.java.net/jtharness/commit/e47d8a82 (regression tests/cleanup) DynamicArrayTest: removed unnecessary boxing ! unit-tests/com/sun/javatest/util/DynamicArrayTest.java Changeset: 966099f7 Author: Dmitry Bessonov Date: 2020-04-03 23:55:21 +0000 URL: https://git.openjdk.java.net/jtharness/commit/966099f7 (regression tests/cleanup) TableWithFinderTest: using <> ! unit-tests/com/sun/javatest/TableWithFinderTest.java From dbessono at openjdk.java.net Tue Apr 7 11:43:09 2020 From: dbessono at openjdk.java.net (Dmitry Bessonov) Date: Tue, 7 Apr 2020 11:43:09 GMT Subject: git: openjdk/jtharness: 9 new changesets Message-ID: <705f3021-ee49-4e94-a9fa-6a8bf86d58a3@openjdk.org> Changeset: 567c643d Author: Dmitry Bessonov Date: 2020-04-05 00:52:25 +0000 URL: https://git.openjdk.java.net/jtharness/commit/567c643d (regression tests/cleanup) static members should be accessed via class references ! unit-tests/com/sun/javatest/SelectionTest.java ! unit-tests/com/sun/javatest/TestResultTableTest.java Changeset: c8f81ea4 Author: Dmitry Bessonov Date: 2020-04-05 00:57:04 +0000 URL: https://git.openjdk.java.net/jtharness/commit/c8f81ea4 (regression tests/cleanup) DynamicArrayTest ignored catch params renamed to 'ignored' ! unit-tests/com/sun/javatest/util/DynamicArrayTest.java Changeset: 94736439 Author: Dmitry Bessonov Date: 2020-04-05 00:58:26 +0000 URL: https://git.openjdk.java.net/jtharness/commit/94736439 (regression tests/cleanup) catch blocks collapsed in few places ! unit-tests/com/sun/javatest/ExcludeTest.java ! unit-tests/com/sun/javatest/TableWithFinderTest.java ! unit-tests/com/sun/javatest/TestResultTableTest.java Changeset: ef0336b0 Author: Dmitry Bessonov Date: 2020-04-05 01:21:11 +0000 URL: https://git.openjdk.java.net/jtharness/commit/ef0336b0 (regression tests/cleanup) catch blocks collapsed in few places ! unit-tests/com/sun/javatest/agent/RemoteTest.java ! unit-tests/com/sun/javatest/finder/BinaryTestFinderTest.java Changeset: 21932d0f Author: Dmitry Bessonov Date: 2020-04-05 01:31:39 +0000 URL: https://git.openjdk.java.net/jtharness/commit/21932d0f 7902651: Make calls to JavaTestSecurityManager::setAllowExit via class reference ! src/com/sun/javatest/agent/AgentMain.java ! src/com/sun/javatest/tool/Main.java ! src/com/sun/javatest/util/ExitCount.java Changeset: 9a8eedf2 Author: Dmitry Bessonov Date: 2020-04-05 01:44:00 +0000 URL: https://git.openjdk.java.net/jtharness/commit/9a8eedf2 (cleanup/refactoring) few private final fields holding constant values are made 'static' ! src/com/sun/javatest/agent/ActiveAgentPool.java ! src/com/sun/javatest/exec/BP_SummarySubpanel.java ! src/com/sun/javatest/exec/LogViewer.java ! src/com/sun/javatest/report/COFReport.java ! src/com/sun/javatest/util/FileInfoCache.java Changeset: e6a9cc3f Author: Dmitry Bessonov Date: 2020-04-06 23:38:46 +0000 URL: https://git.openjdk.java.net/jtharness/commit/e6a9cc3f (cleanup/refactoring) InetAddressQuestion::setValue - removed unnecessary 'throws Interview.Fault' ! src/com/sun/interview/InetAddressQuestion.java Changeset: 4e7e5870 Author: Dmitry Bessonov Date: 2020-04-07 12:31:34 +0000 URL: https://git.openjdk.java.net/jtharness/commit/4e7e5870 (preview/tck.test) added a portion of test library core classes + src/com/sun/tck/lib/tgf/NodeIterator.java + src/com/sun/tck/lib/tgf/ReflectionUtils.java + src/com/sun/tck/lib/tgf/SomethingIsWrong.java + src/com/sun/tck/lib/tgf/TGFUtils.java + src/com/sun/tck/lib/tgf/Transform.java + src/com/sun/tck/lib/tgf/Values.java + src/com/sun/tck/lib/tgf/ValuesIterator.java Changeset: ad8f7416 Author: Dmitry Bessonov Date: 2020-04-07 12:38:38 +0000 URL: https://git.openjdk.java.net/jtharness/commit/ad8f7416 (cleanup/javadoc) com.sun.javatest.agent - fixed few javadoc problems ! src/com/sun/javatest/agent/AgentMain.java ! src/com/sun/javatest/agent/AgentMonitorTool.java ! src/com/sun/javatest/agent/AgentWriter.java From dbessono at openjdk.java.net Thu Apr 9 21:10:48 2020 From: dbessono at openjdk.java.net (Dmitry Bessonov) Date: Thu, 9 Apr 2020 21:10:48 GMT Subject: git: openjdk/jtharness: InetAddressQuestion::setValue - returned 'throws Interview.Fault' for client-code compatibility reasons Message-ID: Changeset: e583a717 Author: Dmitry Bessonov Date: 2020-04-09 21:19:57 +0000 URL: https://git.openjdk.java.net/jtharness/commit/e583a717 InetAddressQuestion::setValue - returned 'throws Interview.Fault' for client-code compatibility reasons ! src/com/sun/interview/InetAddressQuestion.java From dbessono at openjdk.java.net Tue Apr 21 11:50:10 2020 From: dbessono at openjdk.java.net (Dmitry Bessonov) Date: Tue, 21 Apr 2020 11:50:10 GMT Subject: RFR: 7902638: TestResult may count lines incorrectly Message-ID: <18rNxE6KDRwTOE9jeoSrJ1OVe-z3ue9KkNXl8C6iXAA=.634ab896-1d87-4083-8e3f-14c4865ce028@github.com> This is the fix for https://bugs.openjdk.java.net/browse/CODETOOLS-7902638 Changed behavior to handle not only "\n" as line ending but "\r" and "\r\n" as well. Updated regression tests that were matching the current behavior and so started to fail. ------------- Commit messages: - 7902638: TestResult may count lines incorrectly Changes: https://git.openjdk.java.net/jtharness/pull/1/files Webrev: https://webrevs.openjdk.java.net/jtharness/1/webrev.00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7902638 Stats: 104 lines in 2 files changed: 85 ins; 0 del; 19 mod Patch: https://git.openjdk.java.net/jtharness/pull/1.diff Fetch: git fetch https://git.openjdk.java.net/jtharness pull/1/head:pull/1 PR: https://git.openjdk.java.net/jtharness/pull/1 From dbessono at openjdk.java.net Tue Apr 21 11:50:10 2020 From: dbessono at openjdk.java.net (Dmitry Bessonov) Date: Tue, 21 Apr 2020 11:50:10 GMT Subject: RFR: 7902638: TestResult may count lines incorrectly In-Reply-To: <18rNxE6KDRwTOE9jeoSrJ1OVe-z3ue9KkNXl8C6iXAA=.634ab896-1d87-4083-8e3f-14c4865ce028@github.com> References: <18rNxE6KDRwTOE9jeoSrJ1OVe-z3ue9KkNXl8C6iXAA=.634ab896-1d87-4083-8e3f-14c4865ce028@github.com> Message-ID: On Tue, 7 Apr 2020 13:21:44 GMT, Dmitry Bessonov wrote: > This is the fix for https://bugs.openjdk.java.net/browse/CODETOOLS-7902638 > Changed behavior to handle not only "\n" as line ending but "\r" and "\r\n" as well. > Updated regression tests that were matching the current behavior and so started to fail. This is the fix for https://bugs.openjdk.java.net/browse/CODETOOLS-7902638 Changed behavior to handle not only "\n" as line ending but "\r" and "\r\n" as well. Updated regression tests that were matching the current behavior and so started to fail. ------------- PR: https://git.openjdk.java.net/jtharness/pull/1 From jjg at openjdk.java.net Fri Apr 24 15:04:38 2020 From: jjg at openjdk.java.net (Jonathan Gibbons) Date: Fri, 24 Apr 2020 15:04:38 GMT Subject: RFR: 7902638: TestResult may count lines incorrectly In-Reply-To: <18rNxE6KDRwTOE9jeoSrJ1OVe-z3ue9KkNXl8C6iXAA=.634ab896-1d87-4083-8e3f-14c4865ce028@github.com> References: <18rNxE6KDRwTOE9jeoSrJ1OVe-z3ue9KkNXl8C6iXAA=.634ab896-1d87-4083-8e3f-14c4865ce028@github.com> Message-ID: On Tue, 7 Apr 2020 13:21:44 GMT, Dmitry Bessonov wrote: > This is the fix for https://bugs.openjdk.java.net/browse/CODETOOLS-7902638 > Changed behavior to handle not only "\n" as line ending but "\r" and "\r\n" as well. > Updated regression tests that were matching the current behavior and so started to fail. Looks good to me. ------------- Marked as reviewed by jjg (Lead). PR: https://git.openjdk.java.net/jtharness/pull/1 From duke at openjdk.java.net Fri Apr 24 19:35:01 2020 From: duke at openjdk.java.net (duke) Date: Fri, 24 Apr 2020 19:35:01 GMT Subject: git: openjdk/jtharness: 7902638: TestResult may count lines incorrectly Message-ID: Changeset: 35de1377 Author: Dmitry Bessonov Committer: Dmitry Bessonov <52243731+dbessono at users.noreply.github.com> Date: 2020-04-07 14:20:39 +0000 URL: https://git.openjdk.java.net/jtharness/commit/35de1377 7902638: TestResult may count lines incorrectly ! src/com/sun/javatest/TestResult.java ! unit-tests/com/sun/javatest/TestResult_TextScanResult.java From dbessono at openjdk.java.net Fri Apr 24 19:36:24 2020 From: dbessono at openjdk.java.net (Dmitry Bessonov) Date: Fri, 24 Apr 2020 19:36:24 GMT Subject: [Closed] RFR: 7902638: TestResult may count lines incorrectly In-Reply-To: <18rNxE6KDRwTOE9jeoSrJ1OVe-z3ue9KkNXl8C6iXAA=.634ab896-1d87-4083-8e3f-14c4865ce028@github.com> References: <18rNxE6KDRwTOE9jeoSrJ1OVe-z3ue9KkNXl8C6iXAA=.634ab896-1d87-4083-8e3f-14c4865ce028@github.com> Message-ID: On Tue, 7 Apr 2020 13:21:44 GMT, Dmitry Bessonov wrote: > This is the fix for https://bugs.openjdk.java.net/browse/CODETOOLS-7902638 > Changed behavior to handle not only "\n" as line ending but "\r" and "\r\n" as well. > Updated regression tests that were matching the current behavior and so started to fail. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jtharness/pull/1 From jjg at openjdk.java.net Fri Apr 24 19:52:41 2020 From: jjg at openjdk.java.net (Jonathan Gibbons) Date: Fri, 24 Apr 2020 19:52:41 GMT Subject: RFR: 7902638: TestResult may count lines incorrectly In-Reply-To: References: <18rNxE6KDRwTOE9jeoSrJ1OVe-z3ue9KkNXl8C6iXAA=.634ab896-1d87-4083-8e3f-14c4865ce028@github.com> Message-ID: On Fri, 24 Apr 2020 15:02:35 GMT, Jonathan Gibbons wrote: >> This is the fix for https://bugs.openjdk.java.net/browse/CODETOOLS-7902638 >> Changed behavior to handle not only "\n" as line ending but "\r" and "\r\n" as well. >> Updated regression tests that were matching the current behavior and so started to fail. > > Looks good to me. Still looks good to me ------------- PR: https://git.openjdk.java.net/jtharness/pull/1 From dbessono at openjdk.java.net Mon Apr 27 19:11:05 2020 From: dbessono at openjdk.java.net (Dmitry Bessonov) Date: Mon, 27 Apr 2020 19:11:05 GMT Subject: git: openjdk/jtharness: 8 new changesets Message-ID: Changeset: dd036b50 Author: Dmitry Bessonov Date: 2020-04-16 00:04:06 +0000 URL: https://git.openjdk.java.net/jtharness/commit/dd036b50 (cleanup/refactoring) com.sun.javatest: anonymous type use changed to a shorter method call with lambda ! src/com/sun/javatest/Harness.java ! src/com/sun/javatest/TestResultCache.java Changeset: fcfa8ae9 Author: Dmitry Bessonov Date: 2020-04-21 22:43:42 +0000 URL: https://git.openjdk.java.net/jtharness/commit/fcfa8ae9 (regression tests) added KeySortTest + unit-tests/com/sun/javatest/finder/KeySortTest.java Changeset: bcea201f Author: Dmitry Bessonov Date: 2020-04-22 21:35:20 +0000 URL: https://git.openjdk.java.net/jtharness/commit/bcea201f (regression tests) improving TestUtil: added helper method to get abs path for test testsuite ! unit-tests-support/com/sun/javatest/TestUtil.java Changeset: 4d6dc22d Author: Dmitry Bessonov Date: 2020-04-22 21:42:53 +0000 URL: https://git.openjdk.java.net/jtharness/commit/4d6dc22d 7902653: Tool managers for Desktop if provided via sys prop should be instantiated with correct constructor ! src/com/sun/javatest/tool/Desktop.java Changeset: a0bc0c07 Author: Dmitry Bessonov Date: 2020-04-24 21:06:21 +0000 URL: https://git.openjdk.java.net/jtharness/commit/a0bc0c07 Merge branch 'master' of https://github.com/openjdk/jtharness Changeset: e5d93ef9 Author: Dmitry Bessonov Date: 2020-04-26 21:32:08 +0000 URL: https://git.openjdk.java.net/jtharness/commit/e5d93ef9 (preview/tck.test) added more test library core classes + src/com/oracle/tck/lib/autd2/NonTestCase.java + src/com/oracle/tck/lib/autd2/processors/tc/AfterTestCaseActions.java + src/com/oracle/tck/lib/autd2/processors/tc/BeforeTestCaseActions.java + src/com/oracle/tck/lib/autd2/processors/tc/DefaultExecutionResult.java + src/com/oracle/tck/lib/autd2/processors/tc/DefaultNoArgTestCaseMethodSetting.java + src/com/oracle/tck/lib/autd2/processors/tc/DefaultThreadRunning.java + src/com/oracle/tck/lib/autd2/processors/tc/ExceptionsExpected.java + src/com/oracle/tck/lib/autd2/processors/tc/TGFTestCaseMethodSetting.java + src/com/oracle/tck/lib/autd2/processors/tg/AfterTestGroupActions.java + src/com/oracle/tck/lib/autd2/processors/tg/BeforeTestGroupActions.java + src/com/oracle/tck/lib/autd2/processors/tg/NonPublicTestCasesReporter.java + src/com/oracle/tck/lib/autd2/processors/tg/PublicNonTestCaseMethodsReporter.java + src/com/oracle/tck/lib/autd2/processors/tg/RunningTestCases.java + src/com/oracle/tck/lib/autd2/processors/tg/TGFWrongAnnotationsChecking.java + src/com/oracle/tck/lib/autd2/processors/tg/TestCaseExcluding.java + src/com/oracle/tck/lib/autd2/processors/tg/TestCaseSelecting.java + src/com/sun/tck/lib/AfterTestGroup.java + src/com/sun/tck/lib/BeforeTestGroup.java + src/com/sun/tck/lib/ExecuteIf.java + src/com/sun/tck/lib/ExecuteIfNot.java + src/com/sun/tck/lib/ExpectedExceptions.java + src/com/sun/tck/lib/tgf/AbstractValue.java + src/com/sun/tck/lib/tgf/After.java + src/com/sun/tck/lib/tgf/Before.java + src/com/sun/tck/lib/tgf/CachedIterator.java + src/com/sun/tck/lib/tgf/DataFactory.java + src/com/sun/tck/lib/tgf/EmptyIterator.java + src/com/sun/tck/lib/tgf/IntersectIterator.java + src/com/sun/tck/lib/tgf/LeafIterator.java + src/com/sun/tck/lib/tgf/MultiplyIterator.java + src/com/sun/tck/lib/tgf/PseudoMultiplyIterator.java + src/com/sun/tck/lib/tgf/ReducingIterator.java + src/com/sun/tck/lib/tgf/TestData.java + src/com/sun/tck/lib/tgf/TestDataCollector.java + src/com/sun/tck/lib/tgf/TransformingIterator.java + src/com/sun/tck/lib/tgf/UniteIterator.java + src/com/sun/tck/lib/tgf/ValuesImpl.java + src/com/sun/tck/lib/tgf/data/Booleans.java + src/com/sun/tck/lib/tgf/data/Bytes.java + src/com/sun/tck/lib/tgf/data/Chars.java + src/com/sun/tck/lib/tgf/data/Classes.java + src/com/sun/tck/lib/tgf/data/Doubles.java + src/com/sun/tck/lib/tgf/data/Floats.java + src/com/sun/tck/lib/tgf/data/Ints.java + src/com/sun/tck/lib/tgf/data/Longs.java + src/com/sun/tck/lib/tgf/data/Operation.java + src/com/sun/tck/lib/tgf/data/Shorts.java + src/com/sun/tck/lib/tgf/data/Strings.java + src/com/sun/tck/lib/tgf/data/package-info.java Changeset: 3972dae3 Author: Dmitry Bessonov Date: 2020-04-26 21:33:46 +0000 URL: https://git.openjdk.java.net/jtharness/commit/3972dae3 (regression tests) refactoring TestSuiteRunningTestBase for better reuse ! unit-tests-support/com/sun/javatest/functional/TestSuiteRunningTestBase.java Changeset: e2ba3049 Author: Dmitry Bessonov Date: 2020-04-26 22:54:48 +0000 URL: https://git.openjdk.java.net/jtharness/commit/e2ba3049 (regression tests) added MainToolTest + unit-tests/com/sun/javatest/tool/MainToolTest.java From dbessono at openjdk.java.net Mon Apr 27 19:15:46 2020 From: dbessono at openjdk.java.net (Dmitry Bessonov) Date: Mon, 27 Apr 2020 19:15:46 GMT Subject: git: openjdk/jtharness: 2 new changesets Message-ID: <917358b1-2f7b-47ad-b70b-95275a28724b@openjdk.org> Changeset: d55193ba Author: Dmitry Bessonov Date: 2020-04-27 20:13:42 +0000 URL: https://git.openjdk.java.net/jtharness/commit/d55193ba (build) corrected source package names to be included in compilation ! build/build.xml Changeset: 37e4a637 Author: Dmitry Bessonov Date: 2020-04-27 20:14:33 +0000 URL: https://git.openjdk.java.net/jtharness/commit/37e4a637 (build) added copyright checks for regression tests and test support class sources ! build/build.xml From dbessono at openjdk.java.net Tue Apr 28 20:45:26 2020 From: dbessono at openjdk.java.net (Dmitry Bessonov) Date: Tue, 28 Apr 2020 20:45:26 GMT Subject: git: openjdk/jtharness: (typo fixed) ExecTool: prviateFactory -> privateFactory Message-ID: <970a8d4a-939b-446c-8533-b5740865aa69@openjdk.org> Changeset: de8dfff6 Author: Dmitry Bessonov Date: 2020-04-28 21:43:13 +0000 URL: https://git.openjdk.java.net/jtharness/commit/de8dfff6 (typo fixed) ExecTool: prviateFactory -> privateFactory ! src/com/sun/javatest/exec/ExecTool.java From dbessono at openjdk.java.net Wed Apr 29 16:00:29 2020 From: dbessono at openjdk.java.net (Dmitry Bessonov) Date: Wed, 29 Apr 2020 16:00:29 GMT Subject: git: openjdk/jtharness: 7 new changesets Message-ID: <59cf9ef2-4d0f-4ec9-8622-2a04ea3b52ba@openjdk.org> Changeset: 5bbecc8c Author: Dmitry Bessonov Date: 2020-04-29 15:21:27 +0000 URL: https://git.openjdk.java.net/jtharness/commit/5bbecc8c (typo fixed) CompositeFilter: convienience -> convenience ! src/com/sun/javatest/CompositeFilter.java Changeset: e9ba518e Author: Dmitry Bessonov Date: 2020-04-29 16:11:16 +0000 URL: https://git.openjdk.java.net/jtharness/commit/e9ba518e (typo fixed) Harness, Keywords classes: fixed typos in the comments ! src/com/sun/javatest/Harness.java ! src/com/sun/javatest/Keywords.java Changeset: f2dc7b81 Author: Dmitry Bessonov Date: 2020-04-29 16:12:19 +0000 URL: https://git.openjdk.java.net/jtharness/commit/f2dc7b81 (preview/tck.test) added support for testcases returning Status + src/com/oracle/tck/lib/autd2/processors/tc/TestCaseResultCanBeStatus.java Changeset: 449a8ddd Author: Dmitry Bessonov Date: 2020-04-29 16:17:52 +0000 URL: https://git.openjdk.java.net/jtharness/commit/449a8ddd (typo fixed) Script: fixed few typos ! src/com/sun/javatest/Script.java Changeset: 2995003d Author: Dmitry Bessonov Date: 2020-04-29 16:22:42 +0000 URL: https://git.openjdk.java.net/jtharness/commit/2995003d (regression tests) enhanced TU class with more helper methods ! unit-tests-support/com/sun/tck/TU.java Changeset: c038a8c7 Author: Dmitry Bessonov Date: 2020-04-29 16:24:21 +0000 URL: https://git.openjdk.java.net/jtharness/commit/c038a8c7 (preview/tck.test) few more regression tests added + unit-tests/com/oracle/tck/lib/autd2/unittests/Examples.java + unit-tests/com/oracle/tck/lib/autd2/unittests/FailingSimpleTestCases.java + unit-tests/com/oracle/tck/lib/autd2/unittests/PassingSimpleTestCases.java Changeset: 368c807f Author: Dmitry Bessonov Date: 2020-04-29 16:59:08 +0000 URL: https://git.openjdk.java.net/jtharness/commit/368c807f (typo fixed) DefaultTestRunner2: class description ! src/com/sun/javatest/DefaultTestRunner2.java From dbessono at openjdk.java.net Wed Apr 29 17:02:29 2020 From: dbessono at openjdk.java.net (Dmitry Bessonov) Date: Wed, 29 Apr 2020 17:02:29 GMT Subject: RFR: 7902649: Allow a testsuite to define several TestFilters specific for this suite Message-ID: Currently TestSuite class has a method to override that returns only one test filter: TestFilter createTestFilter(TestEnvironment) There are situations when test suite has several test filters that it is forced however to hide behind an umbrella filter. It is more natural and convenient to let test suite return a collection of atomized filters that would be iterated on the JTHarness side and listed in the test run stats separately and informatively. ------------- Commit messages: - 7902649: Allow a testsuite to define several TestFilters specific for this suite Changes: https://git.openjdk.java.net/jtharness/pull/2/files Webrev: https://webrevs.openjdk.java.net/jtharness/2/webrev.00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7902649 Stats: 93 lines in 6 files changed: 50 ins; 11 del; 32 mod Patch: https://git.openjdk.java.net/jtharness/pull/2.diff Fetch: git fetch https://git.openjdk.java.net/jtharness pull/2/head:pull/2 PR: https://git.openjdk.java.net/jtharness/pull/2 From dbessono at openjdk.java.net Wed Apr 29 17:09:38 2020 From: dbessono at openjdk.java.net (Dmitry Bessonov) Date: Wed, 29 Apr 2020 17:09:38 GMT Subject: RFR: 7902649: Allow a testsuite to define several TestFilters specific for this suite In-Reply-To: References: Message-ID: <14rTCImSuxgKf16_HCO43EF7_a3XeHdNCK-pXFf0PZE=.b5a40c66-0e36-41f2-861d-421aa3895d79@github.com> On Wed, 29 Apr 2020 16:56:54 GMT, Dmitry Bessonov wrote: > Currently TestSuite class has a method to override that returns only one test filter: > > TestFilter createTestFilter(TestEnvironment) > > There are situations when test suite has several test filters that it is forced however to hide behind an umbrella > filter. It is more natural and convenient to let test suite return a collection of atomized filters that would be > iterated on the JTHarness side and listed in the test run stats separately and informatively. Most complex changes are in ET_FilterHandler.java ------------- PR: https://git.openjdk.java.net/jtharness/pull/2 From dbessono at openjdk.java.net Wed Apr 29 17:33:37 2020 From: dbessono at openjdk.java.net (Dmitry Bessonov) Date: Wed, 29 Apr 2020 17:33:37 GMT Subject: [Rev 01] RFR: 7902649: Allow a testsuite to define several TestFilters specific for this suite In-Reply-To: References: Message-ID: <0TVS1wpxSF0vWpHXKKYfSeT5zTwMtRkyqGUuC3ZA_wM=.f3d822cc-c1bc-43af-b401-4d023af16f48@github.com> > Currently TestSuite class has a method to override that returns only one test filter: > > TestFilter createTestFilter(TestEnvironment) > > There are situations when test suite has several test filters that it is forced however to hide behind an umbrella > filter. It is more natural and convenient to let test suite return a collection of atomized filters that would be > iterated on the JTHarness side and listed in the test run stats separately and informatively. Dmitry Bessonov has updated the pull request incrementally with one additional commit since the last revision: (javadoc) fixed {@code} links in TestSuite::createTestFilter ------------- Changes: - all: https://git.openjdk.java.net/jtharness/pull/2/files - new: https://git.openjdk.java.net/jtharness/pull/2/files/2cbc74aa..3a389bc6 Webrevs: - full: https://webrevs.openjdk.java.net/jtharness/2/webrev.01 - incr: https://webrevs.openjdk.java.net/jtharness/2/webrev.00-01 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jtharness/pull/2.diff Fetch: git fetch https://git.openjdk.java.net/jtharness pull/2/head:pull/2 PR: https://git.openjdk.java.net/jtharness/pull/2 From dbessono at openjdk.java.net Wed Apr 29 19:27:13 2020 From: dbessono at openjdk.java.net (Dmitry Bessonov) Date: Wed, 29 Apr 2020 19:27:13 GMT Subject: RFR: 7902649: Allow a testsuite to define several TestFilters specific for this suite In-Reply-To: <14rTCImSuxgKf16_HCO43EF7_a3XeHdNCK-pXFf0PZE=.b5a40c66-0e36-41f2-861d-421aa3895d79@github.com> References: <14rTCImSuxgKf16_HCO43EF7_a3XeHdNCK-pXFf0PZE=.b5a40c66-0e36-41f2-861d-421aa3895d79@github.com> Message-ID: On Wed, 29 Apr 2020 17:07:28 GMT, Dmitry Bessonov wrote: >> Currently TestSuite class has a method to override that returns only one test filter: >> >> TestFilter createTestFilter(TestEnvironment) >> >> There are situations when test suite has several test filters that it is forced however to hide behind an umbrella >> filter. It is more natural and convenient to let test suite return a collection of atomized filters that would be >> iterated on the JTHarness side and listed in the test run stats separately and informatively. > > Most complex changes are in ET_FilterHandler.java After some conversations it is considered that a safer, less disturbing, more balanced, and actually simpler-to-implement approach might be - just to allow TestSuite to return a composite test filter that would be decomposed on the JTH side into several first class test filters. ------------- PR: https://git.openjdk.java.net/jtharness/pull/2 From dbessono at openjdk.java.net Wed Apr 29 20:39:03 2020 From: dbessono at openjdk.java.net (Dmitry Bessonov) Date: Wed, 29 Apr 2020 20:39:03 GMT Subject: git: openjdk/jtharness: (typo fixed) TestFilter.Observer: methodcalled -> "method called" Message-ID: Changeset: 2f70e34c Author: Dmitry Bessonov Date: 2020-04-29 21:37:53 +0000 URL: https://git.openjdk.java.net/jtharness/commit/2f70e34c (typo fixed) TestFilter.Observer: methodcalled -> "method called" ! src/com/sun/javatest/TestFilter.java