From dbessono at openjdk.java.net Wed Feb 2 22:25:21 2022 From: dbessono at openjdk.java.net (Dmitry Bessonov) Date: Wed, 2 Feb 2022 22:25:21 GMT Subject: RFR: 7902698: Collision of zero timestamp as a special value with use in filesystems [v2] In-Reply-To: <8qzt2ZPEQTWGjppg_mc1nNzPEwnwu0F-5tazmMqhRSA=.9c043d44-ea16-4a32-97ae-f3c2716ae2f8@github.com> References: <8qzt2ZPEQTWGjppg_mc1nNzPEwnwu0F-5tazmMqhRSA=.9c043d44-ea16-4a32-97ae-f3c2716ae2f8@github.com> Message-ID: On Tue, 25 Jan 2022 22:40:07 GMT, Liam Miller-Cushon wrote: >> This fixes a bug when the timestamp of a test file is set to zero, since jtharness currently uses zero as a special value. See discussion in [CODETOOLS-7902698](https://bugs.openjdk.java.net/browse/CODETOOLS-7902698). > > Liam Miller-Cushon has updated the pull request incrementally with one additional commit since the last revision: > > Use OptionalLong instead of -1L seeing a failure of com.sun.javatest.SelectionTest regression test... inlined comments on the possible changes src/com/sun/javatest/TRT_TreeNode.java line 794: > 792: File thisDir = new File(TestResultTable.getRootRelativePath(this)); > 793: long lmd = table.getLastModifiedTime(thisDir); > 794: if (lastScanDate.isEmpty() || lmd <= lastScanDate.getAsLong()) { Seen a failure of com.sun.javatest.SelectionTest when checking the latest patch... It seems that here a more correct replacement could be if (lastScanDate.isPresent() && lmd <= lastScanDate.getAsLong()) { return; } src/com/sun/javatest/TRT_TreeNode.java line 907: > 905: // may be less than if the custom finder starts to return a > 906: // bogus value - like zero or 1 for whatever reason > 907: if (lastScanDate.isEmpty() || thisScanDate <= lastScanDate.getAsLong()) { Likely the same thing here, the mentioned `SelectionTest` passes with if (lastScanDate.isPresent() && thisScanDate <= lastScanDate.getAsLong() ) { return false; } ------------- Changes requested by dbessono (Committer). PR: https://git.openjdk.java.net/jtharness/pull/22 From cushon at openjdk.java.net Wed Feb 2 22:47:48 2022 From: cushon at openjdk.java.net (Liam Miller-Cushon) Date: Wed, 2 Feb 2022 22:47:48 GMT Subject: RFR: 7902698: Collision of zero timestamp as a special value with use in filesystems [v3] In-Reply-To: References: Message-ID: <2ue6GQCLqzjAlWh07MAPt2MmFzDKMLMThkr7IOM13RY=.e2d8699a-f82f-4e7c-818b-25460fb73d9f@github.com> > This fixes a bug when the timestamp of a test file is set to zero, since jtharness currently uses zero as a special value. See discussion in [CODETOOLS-7902698](https://bugs.openjdk.java.net/browse/CODETOOLS-7902698). Liam Miller-Cushon has updated the pull request incrementally with one additional commit since the last revision: Fix com.sun.javatest.SelectionTest failure ------------- Changes: - all: https://git.openjdk.java.net/jtharness/pull/22/files - new: https://git.openjdk.java.net/jtharness/pull/22/files/c988435a..d6fef84d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jtharness&pr=22&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jtharness&pr=22&range=01-02 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jtharness/pull/22.diff Fetch: git fetch https://git.openjdk.java.net/jtharness pull/22/head:pull/22 PR: https://git.openjdk.java.net/jtharness/pull/22 From cushon at openjdk.java.net Wed Feb 2 22:47:52 2022 From: cushon at openjdk.java.net (Liam Miller-Cushon) Date: Wed, 2 Feb 2022 22:47:52 GMT Subject: RFR: 7902698: Collision of zero timestamp as a special value with use in filesystems [v2] In-Reply-To: References: <8qzt2ZPEQTWGjppg_mc1nNzPEwnwu0F-5tazmMqhRSA=.9c043d44-ea16-4a32-97ae-f3c2716ae2f8@github.com> Message-ID: On Wed, 2 Feb 2022 22:18:25 GMT, Dmitry Bessonov wrote: >> Liam Miller-Cushon has updated the pull request incrementally with one additional commit since the last revision: >> >> Use OptionalLong instead of -1L > > src/com/sun/javatest/TRT_TreeNode.java line 794: > >> 792: File thisDir = new File(TestResultTable.getRootRelativePath(this)); >> 793: long lmd = table.getLastModifiedTime(thisDir); >> 794: if (lastScanDate.isEmpty() || lmd <= lastScanDate.getAsLong()) { > > Seen a failure of com.sun.javatest.SelectionTest when checking the latest patch... It seems that here a more correct replacement could be > > > if (lastScanDate.isPresent() && lmd <= lastScanDate.getAsLong()) { > return; > } Thanks for the catch, I have implemented the suggested fix and verified the test is now passing > src/com/sun/javatest/TRT_TreeNode.java line 907: > >> 905: // may be less than if the custom finder starts to return a >> 906: // bogus value - like zero or 1 for whatever reason >> 907: if (lastScanDate.isEmpty() || thisScanDate <= lastScanDate.getAsLong()) { > > Likely the same thing here, the mentioned `SelectionTest` passes with > > if (lastScanDate.isPresent() && thisScanDate <= lastScanDate.getAsLong() ) { > return false; > } Done ------------- PR: https://git.openjdk.java.net/jtharness/pull/22 From dbessono at openjdk.java.net Thu Feb 3 14:54:18 2022 From: dbessono at openjdk.java.net (Dmitry Bessonov) Date: Thu, 3 Feb 2022 14:54:18 GMT Subject: RFR: 7902698: Collision of zero timestamp as a special value with use in filesystems [v2] In-Reply-To: References: <8qzt2ZPEQTWGjppg_mc1nNzPEwnwu0F-5tazmMqhRSA=.9c043d44-ea16-4a32-97ae-f3c2716ae2f8@github.com> Message-ID: On Wed, 2 Feb 2022 22:42:24 GMT, Liam Miller-Cushon wrote: >> src/com/sun/javatest/TRT_TreeNode.java line 794: >> >>> 792: File thisDir = new File(TestResultTable.getRootRelativePath(this)); >>> 793: long lmd = table.getLastModifiedTime(thisDir); >>> 794: if (lastScanDate.isEmpty() || lmd <= lastScanDate.getAsLong()) { >> >> Seen a failure of com.sun.javatest.SelectionTest when checking the latest patch... It seems that here a more correct replacement could be >> >> >> if (lastScanDate.isPresent() && lmd <= lastScanDate.getAsLong()) { >> return; >> } > > Thanks for the catch, I have implemented the suggested fix and verified the test is now passing thank you ------------- PR: https://git.openjdk.java.net/jtharness/pull/22 From dbessono at openjdk.java.net Thu Feb 3 14:54:18 2022 From: dbessono at openjdk.java.net (Dmitry Bessonov) Date: Thu, 3 Feb 2022 14:54:18 GMT Subject: RFR: 7902698: Collision of zero timestamp as a special value with use in filesystems [v3] In-Reply-To: <2ue6GQCLqzjAlWh07MAPt2MmFzDKMLMThkr7IOM13RY=.e2d8699a-f82f-4e7c-818b-25460fb73d9f@github.com> References: <2ue6GQCLqzjAlWh07MAPt2MmFzDKMLMThkr7IOM13RY=.e2d8699a-f82f-4e7c-818b-25460fb73d9f@github.com> Message-ID: On Wed, 2 Feb 2022 22:47:48 GMT, Liam Miller-Cushon wrote: >> This fixes a bug when the timestamp of a test file is set to zero, since jtharness currently uses zero as a special value. See discussion in [CODETOOLS-7902698](https://bugs.openjdk.java.net/browse/CODETOOLS-7902698). > > Liam Miller-Cushon has updated the pull request incrementally with one additional commit since the last revision: > > Fix com.sun.javatest.SelectionTest failure Marked as reviewed by dbessono (Committer). Marked as reviewed by dbessono (Committer). ------------- PR: https://git.openjdk.java.net/jtharness/pull/22 From cushon at openjdk.java.net Thu Feb 3 19:50:18 2022 From: cushon at openjdk.java.net (Liam Miller-Cushon) Date: Thu, 3 Feb 2022 19:50:18 GMT Subject: Integrated: 7902698: Collision of zero timestamp as a special value with use in filesystems In-Reply-To: References: Message-ID: On Thu, 20 Jan 2022 03:27:00 GMT, Liam Miller-Cushon wrote: > This fixes a bug when the timestamp of a test file is set to zero, since jtharness currently uses zero as a special value. See discussion in [CODETOOLS-7902698](https://bugs.openjdk.java.net/browse/CODETOOLS-7902698). This pull request has now been integrated. Changeset: 6e1a709f Author: Liam Miller-Cushon Committer: Dmitry Bessonov URL: https://git.openjdk.java.net/jtharness/commit/6e1a709f7a5b5050c5ac5dfb75bf0600876dd563 Stats: 33 lines in 3 files changed: 5 ins; 0 del; 28 mod 7902698: Collision of zero timestamp as a special value with use in filesystems Reviewed-by: dbessono ------------- PR: https://git.openjdk.java.net/jtharness/pull/22 From duke at openjdk.java.net Tue Feb 15 22:13:32 2022 From: duke at openjdk.java.net (gollayadav) Date: Tue, 15 Feb 2022 22:13:32 GMT Subject: RFR: 7903103: Sanity Tests - Adding JavaTest GUI new automated test scripts. Message-ID: Adding below automated JavaTest GUI Sanity Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine. 1.Test_Config_Edit3.java 2.Test_Config_EditA1java 3.Test_Config_EditA2.java 4. Test_Config_EditB1.java 5. Test_Config_EditB2.java 6. Test_Config_EditC1.java 7. Test_Config_Load1.java 8. Test_Config_New1.java 9. Test_Config_New2.java 10. Test_Config_Save1.java 11. Test_Create_Work_Dir1.java 12. Test_Open_Test_Suite1.java 13. Test_Open_Work_Dir1.java 14. Test_Open_Work_Dir2.java 15. Test_QSM_NewA1.java 16. Test_QSM_NewB1.java 17. Test_QSM_SaveA1.java 18. Test_QSM_SaveB1.java 19. Test_QSM_Test1.java 20. Test_Report_Create1.java 21. Test_Report_Open1.java ------------- Commit messages: - 7903103: Sanity Tests - Adding JavaTest GUI legacy automated test scripts Changes: https://git.openjdk.java.net/jtharness/pull/23/files Webrev: https://webrevs.openjdk.java.net/?repo=jtharness&pr=23&range=00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903103 Stats: 3080 lines in 21 files changed: 3080 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jtharness/pull/23.diff Fetch: git fetch https://git.openjdk.java.net/jtharness pull/23/head:pull/23 PR: https://git.openjdk.java.net/jtharness/pull/23 From duke at openjdk.java.net Sun Feb 27 21:10:23 2022 From: duke at openjdk.java.net (gollayadav) Date: Sun, 27 Feb 2022 21:10:23 GMT Subject: RFR: 7903103: Sanity Tests - Adding JavaTest GUI new automated test scripts. [v2] In-Reply-To: References: Message-ID: > Adding below automated JavaTest GUI Sanity Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine. > > 1. Test_Create_Work_Dir1.java > 2. Test_Open_Test_Suite1.java > 3. Test_Open_Work_Dir1.java > 4. Test_Open_Work_Dir2.java > 5. Test_Config_New2.java gollayadav has updated the pull request incrementally with one additional commit since the last revision: 7903103: Sanity Tests - Modified/Updated JavaTest GUI automated test scripts ------------- Changes: - all: https://git.openjdk.java.net/jtharness/pull/23/files - new: https://git.openjdk.java.net/jtharness/pull/23/files/90cfa5fc..73efef04 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jtharness&pr=23&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jtharness&pr=23&range=00-01 Stats: 2952 lines in 23 files changed: 75 ins; 2777 del; 100 mod Patch: https://git.openjdk.java.net/jtharness/pull/23.diff Fetch: git fetch https://git.openjdk.java.net/jtharness pull/23/head:pull/23 PR: https://git.openjdk.java.net/jtharness/pull/23 From duke at openjdk.java.net Sun Feb 27 21:15:21 2022 From: duke at openjdk.java.net (gollayadav) Date: Sun, 27 Feb 2022 21:15:21 GMT Subject: RFR: 7903103: Sanity Tests - Adding JavaTest GUI new automated test scripts. [v3] In-Reply-To: References: Message-ID: > Adding below automated JavaTest GUI Sanity Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine. > > 1. Test_Create_Work_Dir1.java > 2. Test_Open_Test_Suite1.java > 3. Test_Open_Work_Dir1.java > 4. Test_Open_Work_Dir2.java > 5. Test_Config_New2.java gollayadav has updated the pull request incrementally with one additional commit since the last revision: 7903103: Sanity Tests - Corrected the whitespace errors ------------- Changes: - all: https://git.openjdk.java.net/jtharness/pull/23/files - new: https://git.openjdk.java.net/jtharness/pull/23/files/73efef04..eb6cba06 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jtharness&pr=23&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jtharness&pr=23&range=01-02 Stats: 43 lines in 2 files changed: 14 ins; 18 del; 11 mod Patch: https://git.openjdk.java.net/jtharness/pull/23.diff Fetch: git fetch https://git.openjdk.java.net/jtharness pull/23/head:pull/23 PR: https://git.openjdk.java.net/jtharness/pull/23 From duke at openjdk.java.net Sun Feb 27 21:24:28 2022 From: duke at openjdk.java.net (gollayadav) Date: Sun, 27 Feb 2022 21:24:28 GMT Subject: RFR: 7903103: Sanity Tests - Adding JavaTest GUI new automated test scripts. [v4] In-Reply-To: References: Message-ID: > Adding below automated JavaTest GUI Sanity Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine. > > 1. Test_Create_Work_Dir1.java > 2. Test_Open_Test_Suite1.java > 3. Test_Open_Work_Dir1.java > 4. Test_Open_Work_Dir2.java > 5. Test_Config_New2.java gollayadav has updated the pull request incrementally with one additional commit since the last revision: 7903103: Sanity Tests - jcheck is failed so corrected the tab space errors ------------- Changes: - all: https://git.openjdk.java.net/jtharness/pull/23/files - new: https://git.openjdk.java.net/jtharness/pull/23/files/eb6cba06..4954eab5 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jtharness&pr=23&range=03 - incr: https://webrevs.openjdk.java.net/?repo=jtharness&pr=23&range=02-03 Stats: 91 lines in 4 files changed: 0 ins; 0 del; 91 mod Patch: https://git.openjdk.java.net/jtharness/pull/23.diff Fetch: git fetch https://git.openjdk.java.net/jtharness pull/23/head:pull/23 PR: https://git.openjdk.java.net/jtharness/pull/23 From duke at openjdk.java.net Mon Feb 28 07:04:30 2022 From: duke at openjdk.java.net (gollayadav) Date: Mon, 28 Feb 2022 07:04:30 GMT Subject: RFR: 7903103: Sanity Tests - Adding JavaTest GUI new automated test scripts. [v5] In-Reply-To: References: Message-ID: > Adding below automated JavaTest GUI Sanity Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine. > > 1. Test_Create_Work_Dir1.java > 2. Test_Open_Test_Suite1.java > 3. Test_Open_Work_Dir1.java > 4. Test_Open_Work_Dir2.java > 5. Test_Config_New2.java gollayadav has updated the pull request incrementally with one additional commit since the last revision: 7903103: Sanity Tests - Modified the test script Test_Open_Work_Dir1.java ------------- Changes: - all: https://git.openjdk.java.net/jtharness/pull/23/files - new: https://git.openjdk.java.net/jtharness/pull/23/files/4954eab5..16f169a0 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jtharness&pr=23&range=04 - incr: https://webrevs.openjdk.java.net/?repo=jtharness&pr=23&range=03-04 Stats: 15 lines in 1 file changed: 0 ins; 8 del; 7 mod Patch: https://git.openjdk.java.net/jtharness/pull/23.diff Fetch: git fetch https://git.openjdk.java.net/jtharness pull/23/head:pull/23 PR: https://git.openjdk.java.net/jtharness/pull/23 From duke at openjdk.java.net Mon Feb 28 13:55:39 2022 From: duke at openjdk.java.net (gollayadav) Date: Mon, 28 Feb 2022 13:55:39 GMT Subject: RFR: 7903103: Sanity Tests - Adding JavaTest GUI new automated test scripts. [v6] In-Reply-To: References: Message-ID: > Adding below automated JavaTest GUI Sanity Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine. > > 1. Test_Create_Work_Dir1.java > 2. Test_Open_Test_Suite1.java > 3. Test_Open_Work_Dir1.java > 4. Test_Open_Work_Dir2.java > 5. Test_Config_New2.java gollayadav has updated the pull request incrementally with one additional commit since the last revision: 7903103: Sanity Tests - Updated the format of the test scripts ------------- Changes: - all: https://git.openjdk.java.net/jtharness/pull/23/files - new: https://git.openjdk.java.net/jtharness/pull/23/files/16f169a0..308964e4 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jtharness&pr=23&range=05 - incr: https://webrevs.openjdk.java.net/?repo=jtharness&pr=23&range=04-05 Stats: 7 lines in 3 files changed: 3 ins; 4 del; 0 mod Patch: https://git.openjdk.java.net/jtharness/pull/23.diff Fetch: git fetch https://git.openjdk.java.net/jtharness pull/23/head:pull/23 PR: https://git.openjdk.java.net/jtharness/pull/23 From dbessono at openjdk.java.net Mon Feb 28 15:33:02 2022 From: dbessono at openjdk.java.net (Dmitry Bessonov) Date: Mon, 28 Feb 2022 15:33:02 GMT Subject: RFR: 7903103: Sanity Tests - Adding JavaTest GUI new automated test scripts. [v6] In-Reply-To: References: Message-ID: On Mon, 28 Feb 2022 13:55:39 GMT, gollayadav wrote: >> Adding below automated JavaTest GUI Sanity Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine. >> >> 1. Test_Create_Work_Dir1.java >> 2. Test_Open_Test_Suite1.java >> 3. Test_Open_Work_Dir1.java >> 4. Test_Open_Work_Dir2.java >> 5. Test_Config_New2.java > > gollayadav has updated the pull request incrementally with one additional commit since the last revision: > > 7903103: Sanity Tests - Updated the format of the test scripts Marked as reviewed by dbessono (Committer). gui-tests/src/gui/src/jthtest/Sanity_Tests/Test_Config_Edit3.java line 79: > 77: JTextFieldOperator test = new JTextFieldOperator(config, n); > 78: test.clearText(); > 79: Path p = Paths.get(System.getenv("JAVA_HOME")); A more normative way would be to use `System.getProperty("java.home")` (please see the API specification). Should better be updated here and in all the other places. ------------- PR: https://git.openjdk.java.net/jtharness/pull/23