From duke at openjdk.java.net  Sun May  1 12:05:42 2022
From: duke at openjdk.java.net (gollayadav)
Date: Sun, 1 May 2022 12:05:42 GMT
Subject: Integrated: 7903170: Sanity Tests - Adding JavaTest GUI newly
 automated test scripts
In-Reply-To: <-K1tk9hqmNl1kiN6U9K2u4u7at7m01SWcSkZjM9WTmg=.4e9dfe2f-5db6-4cc1-8b62-3b2c57ce1aaf@github.com>
References: <-K1tk9hqmNl1kiN6U9K2u4u7at7m01SWcSkZjM9WTmg=.4e9dfe2f-5db6-4cc1-8b62-3b2c57ce1aaf@github.com>
Message-ID: <_z6hyCQSG1Cz0PifALXR37q3DnfFG9dDDWzXnT35rQo=.0fa5cbd9-f695-4eb5-81e9-170d89f8d97f@github.com>

On Mon, 25 Apr 2022 21:39:54 GMT, gollayadav <duke at openjdk.java.net> wrote:

> Adding below automated JavaTest GUI Sanity Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine.
> 
> 1. Test_QSM_Exclude1.java
> 2. Test_QSM_New1.java
> 3. Test_QSM_Save1.java
> 4. Test_QSM_Test1.java
> 5. Test_Report_Create1.java

This pull request has now been integrated.

Changeset: 036dae14
Author:    golla.yadav at oracle.com <gryadav at saturn.s3.javaplatfo1phx.oraclevcn.com>
Committer: Dmitry Bessonov <dbessono at openjdk.org>
URL:       https://git.openjdk.java.net/jtharness/commit/036dae1491f596b2f6b4a71e8ca4a751b548a1f3
Stats:     775 lines in 6 files changed: 770 ins; 4 del; 1 mod

7903170: Sanity Tests - Adding JavaTest GUI newly automated test scripts

Reviewed-by: dbessono

-------------

PR: https://git.openjdk.java.net/jtharness/pull/28

From duke at openjdk.java.net  Tue May  3 21:27:41 2022
From: duke at openjdk.java.net (gollayadav)
Date: Tue, 3 May 2022 21:27:41 GMT
Subject: RFR: 7903177: Feature Tests - Adding five JavaTest GUI legacy
 automated test scripts
Message-ID: <cFY8Cf41gMOfU5GA46JEtpnLxb_aLbPgLWw1jE0Dh6k=.1c0d339a-9e75-44e2-9211-97cee3783ed8@github.com>

Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine.

1.Config_Load5.java
2.Config_Load6.java
3.Config_LoadEdit1.java
4.Config_LoadEdit2.java
5.Config_LoadEdit3.java

-------------

Commit messages:
 - 7903177: Feature Tests - Adding five JavaTest GUI legacy automated feature test scripts

Changes: https://git.openjdk.java.net/jtharness/pull/29/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jtharness&pr=29&range=00
  Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903177
  Stats: 381 lines in 6 files changed: 379 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jtharness/pull/29.diff
  Fetch: git fetch https://git.openjdk.java.net/jtharness pull/29/head:pull/29

PR: https://git.openjdk.java.net/jtharness/pull/29

From dbessono at openjdk.java.net  Thu May 19 15:52:58 2022
From: dbessono at openjdk.java.net (Dmitry Bessonov)
Date: Thu, 19 May 2022 15:52:58 GMT
Subject: RFR: 7903177: Feature Tests - Adding five JavaTest GUI legacy
 automated test scripts
In-Reply-To: <cFY8Cf41gMOfU5GA46JEtpnLxb_aLbPgLWw1jE0Dh6k=.1c0d339a-9e75-44e2-9211-97cee3783ed8@github.com>
References: <cFY8Cf41gMOfU5GA46JEtpnLxb_aLbPgLWw1jE0Dh6k=.1c0d339a-9e75-44e2-9211-97cee3783ed8@github.com>
Message-ID: <bGkG-901GTgz8M2E3k-AAqLPw2hSoEZE26iXAynL2uY=.9d072429-aea8-46ae-b5dd-f3c9592aa039@github.com>

On Tue, 3 May 2022 21:19:16 GMT, gollayadav <duke at openjdk.java.net> wrote:

> Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine.
> 
> 1.Config_Load5.java
> 2.Config_Load6.java
> 3.Config_LoadEdit1.java
> 4.Config_LoadEdit2.java
> 5.Config_LoadEdit3.java

gui-tests/src/gui/src/jthtest/Config_LoadEdit/Config_LoadEdit.java line 35:

> 33:  *
> 34:  * @author linfar
> 35:  */

This looks not correct. Instead it would be better to have a short description of what the test is doing.

gui-tests/src/gui/src/jthtest/Config_LoadEdit/Config_LoadEdit1.java line 51:

> 49:      * @throws InvocationTargetException
> 50:      *
> 51:      * @throws NoSuchMethodException

Please remove this

gui-tests/src/gui/src/jthtest/Config_LoadEdit/Config_LoadEdit2.java line 48:

> 46:      * @throws InvocationTargetException
> 47:      *
> 48:      * @throws NoSuchMethodException

looks not correct, could be removed

gui-tests/src/gui/src/jthtest/Config_LoadEdit/Config_LoadEdit3.java line 50:

> 48:      * @throws InvocationTargetException
> 49:      *
> 50:      * @throws NoSuchMethodException

looks not correct

-------------

PR: https://git.openjdk.java.net/jtharness/pull/29

From duke at openjdk.java.net  Thu May 19 18:23:56 2022
From: duke at openjdk.java.net (gollayadav)
Date: Thu, 19 May 2022 18:23:56 GMT
Subject: RFR: 7903177: Feature Tests - Adding five JavaTest GUI legacy
 automated test scripts [v2]
In-Reply-To: <cFY8Cf41gMOfU5GA46JEtpnLxb_aLbPgLWw1jE0Dh6k=.1c0d339a-9e75-44e2-9211-97cee3783ed8@github.com>
References: <cFY8Cf41gMOfU5GA46JEtpnLxb_aLbPgLWw1jE0Dh6k=.1c0d339a-9e75-44e2-9211-97cee3783ed8@github.com>
Message-ID: <3qm0HBab-U1ZE9qks0x965p27bhGpVfYL7go1Ozqsfk=.a31d2be5-3d8e-4124-a694-60fc9ea1e98b@github.com>

> Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine.
> 
> 1.Config_Load5.java
> 2.Config_Load6.java
> 3.Config_LoadEdit1.java
> 4.Config_LoadEdit2.java
> 5.Config_LoadEdit3.java

gollayadav has updated the pull request incrementally with four additional commits since the last revision:

 - Update Config_LoadEdit3.java
   
   Updated/Modified the Config_LoadEdit3.java as per review comments
 - Update Config_LoadEdit2.java
   
   Updated/Modified the Config_LoadEdit2.java as per review comments
 - Update Config_LoadEdit1.java
   
   Updated/Modified the Config_LoadEdit1.java as per the review comments
 - Updated the script as per the review.

-------------

Changes:
  - all: https://git.openjdk.java.net/jtharness/pull/29/files
  - new: https://git.openjdk.java.net/jtharness/pull/29/files/746ce60d..643abae1

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtharness&pr=29&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jtharness&pr=29&range=00-01

  Stats: 21 lines in 4 files changed: 0 ins; 19 del; 2 mod
  Patch: https://git.openjdk.java.net/jtharness/pull/29.diff
  Fetch: git fetch https://git.openjdk.java.net/jtharness pull/29/head:pull/29

PR: https://git.openjdk.java.net/jtharness/pull/29

From duke at openjdk.java.net  Thu May 19 18:27:06 2022
From: duke at openjdk.java.net (gollayadav)
Date: Thu, 19 May 2022 18:27:06 GMT
Subject: RFR: 7903177: Feature Tests - Adding five JavaTest GUI legacy
 automated test scripts
In-Reply-To: <cFY8Cf41gMOfU5GA46JEtpnLxb_aLbPgLWw1jE0Dh6k=.1c0d339a-9e75-44e2-9211-97cee3783ed8@github.com>
References: <cFY8Cf41gMOfU5GA46JEtpnLxb_aLbPgLWw1jE0Dh6k=.1c0d339a-9e75-44e2-9211-97cee3783ed8@github.com>
Message-ID: <Pinwdm1HgqqXdbc39z4Uo1O6lOT6XKZ6r9NP2Fy0gdA=.afd03f19-86ff-42c3-849b-1ca760d860e7@github.com>

On Tue, 3 May 2022 21:19:16 GMT, gollayadav <duke at openjdk.java.net> wrote:

> Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine.
> 
> 1.Config_Load5.java
> 2.Config_Load6.java
> 3.Config_LoadEdit1.java
> 4.Config_LoadEdit2.java
> 5.Config_LoadEdit3.java

Thank You for your time in reviewing. I have updated/modified the scripts as per the review comments. Could you please check.

-------------

PR: https://git.openjdk.java.net/jtharness/pull/29

From dbessono at openjdk.java.net  Thu May 19 21:27:04 2022
From: dbessono at openjdk.java.net (Dmitry Bessonov)
Date: Thu, 19 May 2022 21:27:04 GMT
Subject: RFR: 7903177: Feature Tests - Adding five JavaTest GUI legacy
 automated test scripts [v2]
In-Reply-To: <3qm0HBab-U1ZE9qks0x965p27bhGpVfYL7go1Ozqsfk=.a31d2be5-3d8e-4124-a694-60fc9ea1e98b@github.com>
References: <cFY8Cf41gMOfU5GA46JEtpnLxb_aLbPgLWw1jE0Dh6k=.1c0d339a-9e75-44e2-9211-97cee3783ed8@github.com>
 <3qm0HBab-U1ZE9qks0x965p27bhGpVfYL7go1Ozqsfk=.a31d2be5-3d8e-4124-a694-60fc9ea1e98b@github.com>
Message-ID: <w8Z1hWlXgsfOUi8SLjlMyovQrYtkR5APcr3nwVNKV1A=.1a1e05e6-777f-42a6-bee8-e6c92e51f6b9@github.com>

On Thu, 19 May 2022 18:23:56 GMT, gollayadav <duke at openjdk.java.net> wrote:

>> Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine.
>> 
>> 1.Config_Load5.java
>> 2.Config_Load6.java
>> 3.Config_LoadEdit1.java
>> 4.Config_LoadEdit2.java
>> 5.Config_LoadEdit3.java
>
> gollayadav has updated the pull request incrementally with four additional commits since the last revision:
> 
>  - Update Config_LoadEdit3.java
>    
>    Updated/Modified the Config_LoadEdit3.java as per review comments
>  - Update Config_LoadEdit2.java
>    
>    Updated/Modified the Config_LoadEdit2.java as per review comments
>  - Update Config_LoadEdit1.java
>    
>    Updated/Modified the Config_LoadEdit1.java as per the review comments
>  - Updated the script as per the review.

Marked as reviewed by dbessono (Committer).

gui-tests/src/gui/src/jthtest/Config_LoadEdit/Config_LoadEdit.java line 37:

> 35: public class Config_LoadEdit extends ConfigTools {
> 36: 
> 37: }

During the first iteration missed that this test is empty. It it really needed at all?

-------------

PR: https://git.openjdk.java.net/jtharness/pull/29

From dbessono at openjdk.java.net  Fri May 20 11:23:07 2022
From: dbessono at openjdk.java.net (Dmitry Bessonov)
Date: Fri, 20 May 2022 11:23:07 GMT
Subject: RFR: 7903177: Feature Tests - Adding five JavaTest GUI legacy
 automated test scripts [v2]
In-Reply-To: <3qm0HBab-U1ZE9qks0x965p27bhGpVfYL7go1Ozqsfk=.a31d2be5-3d8e-4124-a694-60fc9ea1e98b@github.com>
References: <cFY8Cf41gMOfU5GA46JEtpnLxb_aLbPgLWw1jE0Dh6k=.1c0d339a-9e75-44e2-9211-97cee3783ed8@github.com>
 <3qm0HBab-U1ZE9qks0x965p27bhGpVfYL7go1Ozqsfk=.a31d2be5-3d8e-4124-a694-60fc9ea1e98b@github.com>
Message-ID: <xxuJ1mqQta2BO2bwzMEhyIWYfSqO6vFmdEpvyRwLn34=.e817b4c9-4740-4ff0-80be-796ae7863a28@github.com>

On Thu, 19 May 2022 18:23:56 GMT, gollayadav <duke at openjdk.java.net> wrote:

>> Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine.
>> 
>> 1.Config_Load5.java
>> 2.Config_Load6.java
>> 3.Config_LoadEdit1.java
>> 4.Config_LoadEdit2.java
>> 5.Config_LoadEdit3.java
>
> gollayadav has updated the pull request incrementally with four additional commits since the last revision:
> 
>  - Update Config_LoadEdit3.java
>    
>    Updated/Modified the Config_LoadEdit3.java as per review comments
>  - Update Config_LoadEdit2.java
>    
>    Updated/Modified the Config_LoadEdit2.java as per review comments
>  - Update Config_LoadEdit1.java
>    
>    Updated/Modified the Config_LoadEdit1.java as per the review comments
>  - Updated the script as per the review.

What is the purpose of this test?


/**
 *This tests verifies the load button under configuration editor
 */
public class Config_LoadEdit extends ConfigTools {

}

-------------

Changes requested by dbessono (Committer).

PR: https://git.openjdk.java.net/jtharness/pull/29

From duke at openjdk.java.net  Fri May 20 12:12:38 2022
From: duke at openjdk.java.net (gollayadav)
Date: Fri, 20 May 2022 12:12:38 GMT
Subject: RFR: 7903177: Feature Tests - Adding five JavaTest GUI legacy
 automated test scripts [v3]
In-Reply-To: <cFY8Cf41gMOfU5GA46JEtpnLxb_aLbPgLWw1jE0Dh6k=.1c0d339a-9e75-44e2-9211-97cee3783ed8@github.com>
References: <cFY8Cf41gMOfU5GA46JEtpnLxb_aLbPgLWw1jE0Dh6k=.1c0d339a-9e75-44e2-9211-97cee3783ed8@github.com>
Message-ID: <0K3Ta0A_21bRbr8CxESICs00q8uRUeg0Z-oXHHi3VB4=.d35639f4-9b5f-46a0-abe1-d29d5c9c298c@github.com>

> Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine.
> 
> 1.Config_Load5.java
> 2.Config_Load6.java
> 3.Config_LoadEdit1.java
> 4.Config_LoadEdit2.java
> 5.Config_LoadEdit3.java

gollayadav has updated the pull request incrementally with one additional commit since the last revision:

  Delete Config_LoadEdit.java
  
  Verified that Config_LoadEdit.java is not required and removed this empty test script.

-------------

Changes:
  - all: https://git.openjdk.java.net/jtharness/pull/29/files
  - new: https://git.openjdk.java.net/jtharness/pull/29/files/643abae1..0634d251

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtharness&pr=29&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jtharness&pr=29&range=01-02

  Stats: 37 lines in 1 file changed: 0 ins; 37 del; 0 mod
  Patch: https://git.openjdk.java.net/jtharness/pull/29.diff
  Fetch: git fetch https://git.openjdk.java.net/jtharness pull/29/head:pull/29

PR: https://git.openjdk.java.net/jtharness/pull/29

From duke at openjdk.java.net  Fri May 20 12:12:39 2022
From: duke at openjdk.java.net (gollayadav)
Date: Fri, 20 May 2022 12:12:39 GMT
Subject: RFR: 7903177: Feature Tests - Adding five JavaTest GUI legacy
 automated test scripts [v2]
In-Reply-To: <w8Z1hWlXgsfOUi8SLjlMyovQrYtkR5APcr3nwVNKV1A=.1a1e05e6-777f-42a6-bee8-e6c92e51f6b9@github.com>
References: <cFY8Cf41gMOfU5GA46JEtpnLxb_aLbPgLWw1jE0Dh6k=.1c0d339a-9e75-44e2-9211-97cee3783ed8@github.com>
 <3qm0HBab-U1ZE9qks0x965p27bhGpVfYL7go1Ozqsfk=.a31d2be5-3d8e-4124-a694-60fc9ea1e98b@github.com>
 <w8Z1hWlXgsfOUi8SLjlMyovQrYtkR5APcr3nwVNKV1A=.1a1e05e6-777f-42a6-bee8-e6c92e51f6b9@github.com>
Message-ID: <htS49r65ThYFigU6hnNAfYGQRJjPGflNAsNaxXAwPMY=.6b217d30-2aab-4f4f-ad4d-210aae47fb87@github.com>

On Thu, 19 May 2022 21:23:24 GMT, Dmitry Bessonov <dbessono at openjdk.org> wrote:

>> gollayadav has updated the pull request incrementally with four additional commits since the last revision:
>> 
>>  - Update Config_LoadEdit3.java
>>    
>>    Updated/Modified the Config_LoadEdit3.java as per review comments
>>  - Update Config_LoadEdit2.java
>>    
>>    Updated/Modified the Config_LoadEdit2.java as per review comments
>>  - Update Config_LoadEdit1.java
>>    
>>    Updated/Modified the Config_LoadEdit1.java as per the review comments
>>  - Updated the script as per the review.
>
> gui-tests/src/gui/src/jthtest/Config_LoadEdit/Config_LoadEdit.java line 37:
> 
>> 35: public class Config_LoadEdit extends ConfigTools {
>> 36: 
>> 37: }
> 
> During the first iteration missed that this test is empty. It it really needed at all?

This empty test script is not required and removing it.

-------------

PR: https://git.openjdk.java.net/jtharness/pull/29

From dbessono at openjdk.java.net  Fri May 20 12:44:01 2022
From: dbessono at openjdk.java.net (Dmitry Bessonov)
Date: Fri, 20 May 2022 12:44:01 GMT
Subject: RFR: 7903177: Feature Tests - Adding five JavaTest GUI legacy
 automated test scripts [v3]
In-Reply-To: <0K3Ta0A_21bRbr8CxESICs00q8uRUeg0Z-oXHHi3VB4=.d35639f4-9b5f-46a0-abe1-d29d5c9c298c@github.com>
References: <cFY8Cf41gMOfU5GA46JEtpnLxb_aLbPgLWw1jE0Dh6k=.1c0d339a-9e75-44e2-9211-97cee3783ed8@github.com>
 <0K3Ta0A_21bRbr8CxESICs00q8uRUeg0Z-oXHHi3VB4=.d35639f4-9b5f-46a0-abe1-d29d5c9c298c@github.com>
Message-ID: <MNg9UNBA7X6ROlxwF-y8oyDUv0j1RqNqRPSaB0Pk0aM=.c5c3444c-208a-412d-a24c-0e7515236505@github.com>

On Fri, 20 May 2022 12:12:38 GMT, gollayadav <duke at openjdk.java.net> wrote:

>> Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine.
>> 
>> 1.Config_Load5.java
>> 2.Config_Load6.java
>> 3.Config_LoadEdit1.java
>> 4.Config_LoadEdit2.java
>> 5.Config_LoadEdit3.java
>
> gollayadav has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Delete Config_LoadEdit.java
>   
>   Verified that Config_LoadEdit.java is not required and removed this empty test script.

Thank you for the updates, looking good

-------------

Marked as reviewed by dbessono (Committer).

PR: https://git.openjdk.java.net/jtharness/pull/29

From duke at openjdk.java.net  Fri May 20 12:50:07 2022
From: duke at openjdk.java.net (gollayadav)
Date: Fri, 20 May 2022 12:50:07 GMT
Subject: Integrated: 7903177: Feature Tests - Adding five JavaTest GUI legacy
 automated test scripts
In-Reply-To: <cFY8Cf41gMOfU5GA46JEtpnLxb_aLbPgLWw1jE0Dh6k=.1c0d339a-9e75-44e2-9211-97cee3783ed8@github.com>
References: <cFY8Cf41gMOfU5GA46JEtpnLxb_aLbPgLWw1jE0Dh6k=.1c0d339a-9e75-44e2-9211-97cee3783ed8@github.com>
Message-ID: <EJ2swODIfEEAMoFyMTBaDT5NZWpkL0Rk1SW8dhk9520=.c585391f-1572-4659-a319-e30def5e35f6@github.com>

On Tue, 3 May 2022 21:19:16 GMT, gollayadav <duke at openjdk.java.net> wrote:

> Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine.
> 
> 1.Config_Load5.java
> 2.Config_Load6.java
> 3.Config_LoadEdit1.java
> 4.Config_LoadEdit2.java
> 5.Config_LoadEdit3.java

This pull request has now been integrated.

Changeset: 4c0a9adc
Author:    gollayadav <83762358+gollayadav at users.noreply.github.com>
Committer: Dmitry Bessonov <dbessono at openjdk.org>
URL:       https://git.openjdk.java.net/jtharness/commit/4c0a9adcd8e2abcaea3c6a51acf996cf01374bd1
Stats:     357 lines in 5 files changed: 357 ins; 0 del; 0 mod

7903177: Feature Tests - Adding five JavaTest GUI legacy automated test scripts

Reviewed-by: dbessono

-------------

PR: https://git.openjdk.java.net/jtharness/pull/29