From jonathan.gibbons at oracle.com Tue Dec 9 00:17:57 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Mon, 08 Dec 2014 16:17:57 -0800 Subject: moving jtreg forward Message-ID: <54863FB5.6090800@oracle.com> Sean, Rob, We're looking at advancing jtreg so that it will require JDK 8 (or better) to run jtreg itself, although it will still be able to test as far back as we want to go -- meaning JDK 5 or so. For refer4ence, jtreg currently only requires JDK 5 or better. One consequence is that we would not be able to use -samevm mode for anything less than JDK 8, but -agentvm should provide a satisfactory replacement. Do you see any problems from the Sustaining side of the organization if we require JDK 8 or better to be used to run jtreg? -- Jon From jonathan.gibbons at oracle.com Tue Dec 9 00:38:10 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Mon, 08 Dec 2014 16:38:10 -0800 Subject: moving jtreg forward In-Reply-To: <54864391.4000604@oracle.com> References: <54863FB5.6090800@oracle.com> <54864391.4000604@oracle.com> Message-ID: <54864472.3000206@oracle.com> It hasn't happened yet. But there is interesting in doing a bunch of improvements to jtreg innards, especially timeout handling, which would benefit from being able to use JDK 8 API. -- Jon On 12/08/2014 04:34 PM, Rob McKenna wrote: > We may sometimes test on the platforms that we use to build. In some > cases it may not be possible to run 8 on those hosts, I don't have an > objection to simply using an older version of jtreg in those instances > however. > > Out of curiosity, what prompted the move to 8? > > -Rob > > On 09/12/14 00:17, Jonathan Gibbons wrote: >> Sean, Rob, >> >> We're looking at advancing jtreg so that it will require JDK 8 (or >> better) to run jtreg itself, although it will still be able to test >> as far back as we want to go -- meaning JDK 5 or so. For refer4ence, >> jtreg currently only requires JDK 5 or better. >> >> One consequence is that we would not be able to use -samevm mode for >> anything less than JDK 8, but -agentvm should provide a satisfactory >> replacement. >> >> Do you see any problems from the Sustaining side of the organization >> if we require JDK 8 or better to be used to run jtreg? >> >> -- Jon > From rob.mckenna at oracle.com Tue Dec 9 00:34:25 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 09 Dec 2014 00:34:25 +0000 Subject: moving jtreg forward In-Reply-To: <54863FB5.6090800@oracle.com> References: <54863FB5.6090800@oracle.com> Message-ID: <54864391.4000604@oracle.com> We may sometimes test on the platforms that we use to build. In some cases it may not be possible to run 8 on those hosts, I don't have an objection to simply using an older version of jtreg in those instances however. Out of curiosity, what prompted the move to 8? -Rob On 09/12/14 00:17, Jonathan Gibbons wrote: > Sean, Rob, > > We're looking at advancing jtreg so that it will require JDK 8 (or > better) to run jtreg itself, although it will still be able to test as > far back as we want to go -- meaning JDK 5 or so. For refer4ence, > jtreg currently only requires JDK 5 or better. > > One consequence is that we would not be able to use -samevm mode for > anything less than JDK 8, but -agentvm should provide a satisfactory > replacement. > > Do you see any problems from the Sustaining side of the organization > if we require JDK 8 or better to be used to run jtreg? > > -- Jon From jonathan.gibbons at oracle.com Tue Dec 9 02:25:55 2014 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 09 Dec 2014 02:25:55 +0000 Subject: hg: code-tools/jtreg: 2 new changesets Message-ID: <201412090225.sB92Pt4c025024@aojmv0008> Changeset: 92624726080e Author: sla Date: 2014-12-05 20:37 +0100 URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/92624726080e Fix for running tests in headless mode Contributed-by: staffan.larsen at oracle.com ! make/tests/EnvTest.gmk ! make/tests/RerunTest.gmk Changeset: 6bfb8aba6e3b Author: jjg Date: 2014-12-08 18:25 -0800 URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/6bfb8aba6e3b Unset XMODIFIERS for test ! make/tests/RerunTest.gmk From sean.coffey at oracle.com Tue Dec 9 09:18:01 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Tue, 09 Dec 2014 09:18:01 +0000 Subject: moving jtreg forward In-Reply-To: <54864472.3000206@oracle.com> References: <54863FB5.6090800@oracle.com> <54864391.4000604@oracle.com> <54864472.3000206@oracle.com> Message-ID: <5486BE49.4010906@oracle.com> No problems here either. I would say that the Quality group is impacted most by such a change. Best to check that they're in agreement with such changes. regards, Sean. On 09/12/2014 00:38, Jonathan Gibbons wrote: > It hasn't happened yet. > > But there is interesting in doing a bunch of improvements to jtreg > innards, especially timeout handling, which would benefit from being > able to use JDK 8 API. > > -- Jon > > On 12/08/2014 04:34 PM, Rob McKenna wrote: >> We may sometimes test on the platforms that we use to build. In some >> cases it may not be possible to run 8 on those hosts, I don't have an >> objection to simply using an older version of jtreg in those >> instances however. >> >> Out of curiosity, what prompted the move to 8? >> >> -Rob >> >> On 09/12/14 00:17, Jonathan Gibbons wrote: >>> Sean, Rob, >>> >>> We're looking at advancing jtreg so that it will require JDK 8 (or >>> better) to run jtreg itself, although it will still be able to test >>> as far back as we want to go -- meaning JDK 5 or so. For refer4ence, >>> jtreg currently only requires JDK 5 or better. >>> >>> One consequence is that we would not be able to use -samevm mode for >>> anything less than JDK 8, but -agentvm should provide a satisfactory >>> replacement. >>> >>> Do you see any problems from the Sustaining side of the organization >>> if we require JDK 8 or better to be used to run jtreg? >>> >>> -- Jon >> > From jonathan.gibbons at oracle.com Fri Dec 12 22:29:52 2014 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 12 Dec 2014 22:29:52 +0000 Subject: hg: code-tools/jtreg: 4 new changesets Message-ID: <201412122229.sBCMTrCN010242@aojmv0008> Changeset: 9a460da0b07d Author: sla Date: 2014-12-12 14:08 -0800 URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/9a460da0b07d Make rerun output stable so RerunTest does not sometimes fail ! make/tests/RerunTest.gmk ! src/share/classes/com/sun/javatest/regtest/RegressionScript.java ! src/share/test/javatest/regtest/data/rerun/std/AppletTest.agentvm.out ! src/share/test/javatest/regtest/data/rerun/std/AppletTest.othervm.out ! src/share/test/javatest/regtest/data/rerun/std/AppletTest.samevm.out ! src/share/test/javatest/regtest/data/rerun/std/BuildTest.agentvm.out ! src/share/test/javatest/regtest/data/rerun/std/BuildTest.othervm.out ! src/share/test/javatest/regtest/data/rerun/std/BuildTest.samevm.out ! src/share/test/javatest/regtest/data/rerun/std/CompileTest.agentvm.out ! src/share/test/javatest/regtest/data/rerun/std/CompileTest.othervm.out ! src/share/test/javatest/regtest/data/rerun/std/CompileTest.samevm.out ! src/share/test/javatest/regtest/data/rerun/std/JUnitTest.agentvm.out ! src/share/test/javatest/regtest/data/rerun/std/JUnitTest.othervm.out ! src/share/test/javatest/regtest/data/rerun/std/JUnitTest.samevm.out ! src/share/test/javatest/regtest/data/rerun/std/MainTest.agentvm.out ! src/share/test/javatest/regtest/data/rerun/std/MainTest.othervm.out ! src/share/test/javatest/regtest/data/rerun/std/MainTest.samevm.out ! src/share/test/javatest/regtest/data/rerun/std/TestNGTest.agentvm.out ! src/share/test/javatest/regtest/data/rerun/std/TestNGTest.othervm.out ! src/share/test/javatest/regtest/data/rerun/std/TestNGTest.samevm.out ! src/share/test/javatest/regtest/data/rerun/testng/TestNGTest.agentvm.out ! src/share/test/javatest/regtest/data/rerun/testng/TestNGTest.othervm.out ! src/share/test/javatest/regtest/data/rerun/testng/TestNGTest.samevm.out Changeset: 2a60b350811a Author: sla Date: 2014-12-12 14:10 -0800 URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/2a60b350811a Add support for handling timeouts from tests. ! make/Defs.gmk ! make/tests/CleanupTest.gmk + make/tests/TimeoutHandlerTest.gmk ! src/share/classes/com/sun/javatest/regtest/ActionRecorder.java ! src/share/classes/com/sun/javatest/regtest/Agent.java ! src/share/classes/com/sun/javatest/regtest/Alarm.java ! src/share/classes/com/sun/javatest/regtest/AppletAction.java ! src/share/classes/com/sun/javatest/regtest/CompileAction.java + src/share/classes/com/sun/javatest/regtest/DefaultTimeoutHandler.java ! src/share/classes/com/sun/javatest/regtest/Main.java ! src/share/classes/com/sun/javatest/regtest/MainAction.java + src/share/classes/com/sun/javatest/regtest/ProcessCommand.java ! src/share/classes/com/sun/javatest/regtest/ShellAction.java + src/share/classes/com/sun/javatest/regtest/StreamCopier.java + src/share/classes/com/sun/javatest/regtest/TimeoutHandler.java + src/share/classes/com/sun/javatest/regtest/TimeoutHandlerProvider.java ! src/share/classes/com/sun/javatest/regtest/i18n.properties + src/share/test/javatest/regtest/data/timeouthandlers/MyHandler.java + src/share/test/javatest/regtest/data/timeouthandlers/TEST.ROOT + src/share/test/javatest/regtest/data/timeouthandlers/TestJavaHang.java Changeset: 773cd4beb300 Author: sla Date: 2014-12-12 14:13 -0800 URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/773cd4beb300 Refactor to use Map for env variables ! src/share/classes/com/sun/javatest/regtest/ActionRecorder.java ! src/share/classes/com/sun/javatest/regtest/Agent.java ! src/share/classes/com/sun/javatest/regtest/AppletAction.java ! src/share/classes/com/sun/javatest/regtest/CompileAction.java ! src/share/classes/com/sun/javatest/regtest/Main.java ! src/share/classes/com/sun/javatest/regtest/MainAction.java ! src/share/classes/com/sun/javatest/regtest/ProcessCommand.java ! src/share/classes/com/sun/javatest/regtest/RegressionParameters.java ! src/share/classes/com/sun/javatest/regtest/RegressionScript.java ! src/share/classes/com/sun/javatest/regtest/ShellAction.java Changeset: 4ecfc66af16b Author: jjg Date: 2014-12-12 14:23 -0800 URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/4ecfc66af16b Downgrade use of JDK19HOME to JDK18HOME in test ! make/tests/TimeoutHandlerTest.gmk From jonathan.gibbons at oracle.com Sat Dec 13 02:10:57 2014 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Sat, 13 Dec 2014 02:10:57 +0000 Subject: hg: code-tools/jtreg: 7901129: Remove support for JDK 1.1 Message-ID: <201412130210.sBD2AvZS020095@aojmv0008> Changeset: d37ce1ca5ded Author: jjg Date: 2014-12-12 18:10 -0800 URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/d37ce1ca5ded 7901129: Remove support for JDK 1.1 ! make/tests/CompileTests.gmk ! src/share/classes/com/sun/javatest/regtest/AppletAction.java ! src/share/classes/com/sun/javatest/regtest/CompileAction.java ! src/share/classes/com/sun/javatest/regtest/JDK.java ! src/share/classes/com/sun/javatest/regtest/Main.java ! src/share/classes/com/sun/javatest/regtest/MainAction.java ! src/share/classes/com/sun/javatest/regtest/RegressionContext.java ! src/share/classes/com/sun/javatest/regtest/RegressionScript.java ! src/share/classes/com/sun/javatest/regtest/i18n.properties From weijun.wang at oracle.com Wed Dec 31 15:11:29 2014 From: weijun.wang at oracle.com (Weijun Wang) Date: Wed, 31 Dec 2014 23:11:29 +0800 Subject: jtreg creates wrong FilePermission line on cygwin Message-ID: <54A41221.4020908@oracle.com> For every test with a policy file, jtreg creates a new one with some extra entries. On Windows, one of them is grant { permission java.io.FilePermission "C:\tmp\W\classes${/}-", "read"; }; (Here, I provide -w:C:/tmp/W on the jtreg command line.) The syntax of the file name is incorrect, it should be either "C:/tmp/..." or "C:\\tmp\\...". In fact, if I add -Djava.security.debug=policy to jtreg, I will see policy: granting ("java.io.FilePermission" "C: mpWclasses\-" "read") This seems to be harmless now, but in our experiment of implementing FilePermission with NIO Path, the path will be rejected because it contains the illegal char \t. I have a patch here. diff --git a/src/share/classes/com/sun/javatest/regtest/Action.java b/src/share/classes/com/sun/javatest/regtest/Action.java --- a/src/share/classes/com/sun/javatest/regtest/Action.java +++ b/src/share/classes/com/sun/javatest/regtest/Action.java @@ -182,7 +182,7 @@ fw.write("// The following grant entries were added by JavaTest. Do not edit." + LINESEP); fw.write("grant {" + LINESEP); fw.write(" permission java.io.FilePermission \"" - + script.absTestClsTopDir().getPath().replace('\\' + FILESEP, "{/}") + + script.absTestClsTopDir().getPath().replace(FILESEP, "${/}") + "${/}-\"" + ", \"read\";" + LINESEP); fw.write("};" + LINESEP); for (File f: script.getJavaTestClassPath().split()) { I have no idea why the old code substitutes \\ to {/}. I've changed it to \ to ${/}. Thanks Max