From sadhak001 at gmail.com Fri Jun 2 16:04:46 2017 From: sadhak001 at gmail.com (Mani Sarkar) Date: Fri, 02 Jun 2017 16:04:46 +0000 Subject: Jtreg build is failing Message-ID: Hi all, Recently jtreg stopped building on our build farm, checking the logs we got (this version uses jdk9 as one of the jdks during the build process): -compile-jtreg.usage: [mkdir] Created dir: /scratch/jenkins/workspace/jtreg/build/jtreg [java] Executing '/opt/java/sdk/Oracle/x86_64/jdk1.8.0_102/jre/bin/java' with arguments: [java] '-Dprogram=jtreg' [java] '-classpath' [java] '/scratch/jenkins/workspace/jtreg/build/classes:/scratch/jenkins/workspace/jtreg/jtharness/lib/javatest.jar:/scratch/jenkins/workspace/jtreg/junit/junit.jar:/scratch/jenkins/workspace/jtreg/jh2.0/javahelp/lib/jh.jar' [java] 'com.sun.javatest.regtest.Main' [java] '-help' [java] 'all' [java] [java] The ' characters around the executable and arguments are [java] not part of the command. [java] Output redirected to /scratch/jenkins/workspace/jtreg/build/jtreg/usage.txt BUILD FAILED /scratch/jenkins/workspace/jtreg/make/build.xml:192: Java returned: 6 at org.apache.tools.ant.taskdefs.Java.execute(Java.java:111) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292) at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) at org.apache.tools.ant.Task.perform(Task.java:348) at org.apache.tools.ant.Target.execute(Target.java:435) at org.apache.tools.ant.Target.performTasks(Target.java:456) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1393) at org.apache.tools.ant.Project.executeTarget(Project.java:1364) at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) at org.apache.tools.ant.Project.executeTargets(Project.java:1248) at org.apache.tools.ant.Main.runBuild(Main.java:851) at org.apache.tools.ant.Main.startAnt(Main.java:235) at org.apache.tools.ant.launch.Launcher.run(Launcher.java:280) at org.apache.tools.ant.launch.Launcher.main(Launcher.java:109) Checking the usage.txt created in we see: Error: Unexpected exception occurred! java.lang.NullPointerException java.lang.NullPointerException at sun.reflect.UnsafeFieldAccessorImpl.ensureObj(UnsafeFieldAccessorImpl.java:57) at sun.reflect.UnsafeObjectFieldAccessorImpl.set(UnsafeObjectFieldAccessorImpl.java:75) at java.lang.reflect.Field.set(Field.java:764) at com.sun.javatest.regtest.tool.Help.showCommandLineHelp(Help.java:332) at com.sun.javatest.regtest.tool.Help.show(Help.java:168) at com.sun.javatest.regtest.tool.Tool.run(Tool.java:960) at com.sun.javatest.regtest.tool.Tool.run(Tool.java:953) at com.sun.javatest.regtest.tool.Tool.main(Tool.java:133) at com.sun.javatest.regtest.Main.main(Main.java:58) Logs can be found at https://adopt-openjdk.ci.cloudbees.com/job/jtreg/843/consoleFull Any ideas whats leading to it? Cheers, Mani -- @theNeomatrix369 * | **Blog ** | *LJC Associate & LJC Advocate (@adoptopenjdk & @adoptajsr programs) *Meet-a-Project - *MutabilityDetector * | **Bitbucket * * | **Github * * | **LinkedIn * *Come to Devoxx UK 2017:* http://www.devoxx.co.uk/ *Don't chase success, rather aim for "Excellence", and success will come chasing after you!* From jonathan.gibbons at oracle.com Fri Jun 2 17:20:38 2017 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Fri, 02 Jun 2017 10:20:38 -0700 Subject: Jtreg build is failing In-Reply-To: References: Message-ID: <59319E66.9040205@oracle.com> Mani, Thanks for the report. I'll investigate. -- Jon On 06/02/2017 09:04 AM, Mani Sarkar wrote: > Hi all, > > Recently jtreg stopped building on our build farm, checking the logs we got > (this version uses jdk9 as one of the jdks during the build process): > > -compile-jtreg.usage: > [mkdir] Created dir: /scratch/jenkins/workspace/jtreg/build/jtreg > [java] Executing > '/opt/java/sdk/Oracle/x86_64/jdk1.8.0_102/jre/bin/java' with > arguments: > [java] '-Dprogram=jtreg' > [java] '-classpath' > [java] '/scratch/jenkins/workspace/jtreg/build/classes:/scratch/jenkins/workspace/jtreg/jtharness/lib/javatest.jar:/scratch/jenkins/workspace/jtreg/junit/junit.jar:/scratch/jenkins/workspace/jtreg/jh2.0/javahelp/lib/jh.jar' > [java] 'com.sun.javatest.regtest.Main' > [java] '-help' > [java] 'all' > [java] > [java] The ' characters around the executable and arguments are > [java] not part of the command. > [java] Output redirected to > /scratch/jenkins/workspace/jtreg/build/jtreg/usage.txt > > BUILD FAILED > /scratch/jenkins/workspace/jtreg/make/build.xml:192: Java returned: 6 > at org.apache.tools.ant.taskdefs.Java.execute(Java.java:111) > at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292) > at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.Task.perform(Task.java:348) > at org.apache.tools.ant.Target.execute(Target.java:435) > at org.apache.tools.ant.Target.performTasks(Target.java:456) > at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1393) > at org.apache.tools.ant.Project.executeTarget(Project.java:1364) > at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) > at org.apache.tools.ant.Project.executeTargets(Project.java:1248) > at org.apache.tools.ant.Main.runBuild(Main.java:851) > at org.apache.tools.ant.Main.startAnt(Main.java:235) > at org.apache.tools.ant.launch.Launcher.run(Launcher.java:280) > at org.apache.tools.ant.launch.Launcher.main(Launcher.java:109) > > > Checking the usage.txt created in we see: > > > Error: Unexpected exception occurred! java.lang.NullPointerException > java.lang.NullPointerException > at sun.reflect.UnsafeFieldAccessorImpl.ensureObj(UnsafeFieldAccessorImpl.java:57) > at sun.reflect.UnsafeObjectFieldAccessorImpl.set(UnsafeObjectFieldAccessorImpl.java:75) > at java.lang.reflect.Field.set(Field.java:764) > at com.sun.javatest.regtest.tool.Help.showCommandLineHelp(Help.java:332) > at com.sun.javatest.regtest.tool.Help.show(Help.java:168) > at com.sun.javatest.regtest.tool.Tool.run(Tool.java:960) > at com.sun.javatest.regtest.tool.Tool.run(Tool.java:953) > at com.sun.javatest.regtest.tool.Tool.main(Tool.java:133) > at com.sun.javatest.regtest.Main.main(Main.java:58) > > Logs can be found at > https://adopt-openjdk.ci.cloudbees.com/job/jtreg/843/consoleFull > > > Any ideas whats leading to it? > > > Cheers, > > Mani > > From jonathan.gibbons at oracle.com Wed Jun 7 20:45:44 2017 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 07 Jun 2017 20:45:44 +0000 Subject: hg: code-tools/jtreg: Fix typo in module config reporting Message-ID: <201706072045.v57KjjTc016451@aojmv0008.oracle.com> Changeset: 2d5267167c24 Author: jjg Date: 2017-06-07 13:43 -0700 URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/2d5267167c24 Fix typo in module config reporting ! src/share/classes/com/sun/javatest/regtest/exec/ModuleConfig.java From sadhak001 at gmail.com Fri Jun 9 15:01:05 2017 From: sadhak001 at gmail.com (Mani Sarkar) Date: Fri, 09 Jun 2017 15:01:05 +0000 Subject: Jtreg build is failing In-Reply-To: References: Message-ID: Hi Jon, Any suggestions on how to resolve the below, apologies if I have missed out any communication with regards to the below. Thanks. Cheers, Mani On Fri, 2 Jun 2017 at 17:04 Mani Sarkar wrote: > Hi all, > > Recently jtreg stopped building on our build farm, checking the logs we > got (this version uses jdk9 as one of the jdks during the build process): > > -compile-jtreg.usage: > [mkdir] Created dir: /scratch/jenkins/workspace/jtreg/build/jtreg > [java] Executing '/opt/java/sdk/Oracle/x86_64/jdk1.8.0_102/jre/bin/java' with arguments: > [java] '-Dprogram=jtreg' > [java] '-classpath' > [java] '/scratch/jenkins/workspace/jtreg/build/classes:/scratch/jenkins/workspace/jtreg/jtharness/lib/javatest.jar:/scratch/jenkins/workspace/jtreg/junit/junit.jar:/scratch/jenkins/workspace/jtreg/jh2.0/javahelp/lib/jh.jar' > [java] 'com.sun.javatest.regtest.Main' > [java] '-help' > [java] 'all' > [java] > [java] The ' characters around the executable and arguments are > [java] not part of the command. > [java] Output redirected to /scratch/jenkins/workspace/jtreg/build/jtreg/usage.txt > > BUILD FAILED > /scratch/jenkins/workspace/jtreg/make/build.xml:192: Java returned: 6 > at org.apache.tools.ant.taskdefs.Java.execute(Java.java:111) > at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292) > at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.Task.perform(Task.java:348) > at org.apache.tools.ant.Target.execute(Target.java:435) > at org.apache.tools.ant.Target.performTasks(Target.java:456) > at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1393) > at org.apache.tools.ant.Project.executeTarget(Project.java:1364) > at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) > at org.apache.tools.ant.Project.executeTargets(Project.java:1248) > at org.apache.tools.ant.Main.runBuild(Main.java:851) > at org.apache.tools.ant.Main.startAnt(Main.java:235) > at org.apache.tools.ant.launch.Launcher.run(Launcher.java:280) > at org.apache.tools.ant.launch.Launcher.main(Launcher.java:109) > > > Checking the usage.txt created in we see: > > > Error: Unexpected exception occurred! java.lang.NullPointerException > java.lang.NullPointerException > at sun.reflect.UnsafeFieldAccessorImpl.ensureObj(UnsafeFieldAccessorImpl.java:57) > at sun.reflect.UnsafeObjectFieldAccessorImpl.set(UnsafeObjectFieldAccessorImpl.java:75) > at java.lang.reflect.Field.set(Field.java:764) > at com.sun.javatest.regtest.tool.Help.showCommandLineHelp(Help.java:332) > at com.sun.javatest.regtest.tool.Help.show(Help.java:168) > at com.sun.javatest.regtest.tool.Tool.run(Tool.java:960) > at com.sun.javatest.regtest.tool.Tool.run(Tool.java:953) > at com.sun.javatest.regtest.tool.Tool.main(Tool.java:133) > at com.sun.javatest.regtest.Main.main(Main.java:58) > > Logs can be found at https://adopt-openjdk.ci.cloudbees.com/job/jtreg/843/consoleFull > > > Any ideas whats leading to it? > > > Cheers, > > Mani > > > -- > @theNeomatrix369 * | **Blog > ** | *LJC Associate & LJC Advocate > (@adoptopenjdk & @adoptajsr programs) > *Meet-a-Project - *MutabilityDetector > * | **Bitbucket > * * | **Github > * * | **LinkedIn > * > *Come to Devoxx UK 2017:* http://www.devoxx.co.uk/ > > *Don't chase success, rather aim for "Excellence", and success will come > chasing after you!* > -- @theNeomatrix369 * | **Blog ** | *LJC Associate & LJC Advocate (@adoptopenjdk & @adoptajsr programs) *Meet-a-Project - *MutabilityDetector * | **Bitbucket * * | **Github * * | **LinkedIn * *Come to Devoxx UK 2018:* http://www.devoxx.co.uk/ *Don't chase success, rather aim for "Excellence", and success will come chasing after you!* From jonathan.gibbons at oracle.com Fri Jun 9 19:23:02 2017 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Fri, 9 Jun 2017 12:23:02 -0700 Subject: Jtreg build is failing In-Reply-To: References: Message-ID: <2eabe5f4-cf0d-5eb0-2b32-1246e52a9cf5@oracle.com> From a brief examination of the stacktrace, it looks like you have now-incompatible versions of jtharness and jtreg. I will make the jtreg code more robust. -- Jon On 6/9/17 8:01 AM, Mani Sarkar wrote: > Hi Jon, > > Any suggestions on how to resolve the below, apologies if I have missed out > any communication with regards to the below. > > Thanks. > > Cheers, > Mani > > On Fri, 2 Jun 2017 at 17:04 Mani Sarkar wrote: > >> Hi all, >> >> Recently jtreg stopped building on our build farm, checking the logs we >> got (this version uses jdk9 as one of the jdks during the build process): >> >> -compile-jtreg.usage: >> [mkdir] Created dir: /scratch/jenkins/workspace/jtreg/build/jtreg >> [java] Executing '/opt/java/sdk/Oracle/x86_64/jdk1.8.0_102/jre/bin/java' with arguments: >> [java] '-Dprogram=jtreg' >> [java] '-classpath' >> [java] '/scratch/jenkins/workspace/jtreg/build/classes:/scratch/jenkins/workspace/jtreg/jtharness/lib/javatest.jar:/scratch/jenkins/workspace/jtreg/junit/junit.jar:/scratch/jenkins/workspace/jtreg/jh2.0/javahelp/lib/jh.jar' >> [java] 'com.sun.javatest.regtest.Main' >> [java] '-help' >> [java] 'all' >> [java] >> [java] The ' characters around the executable and arguments are >> [java] not part of the command. >> [java] Output redirected to /scratch/jenkins/workspace/jtreg/build/jtreg/usage.txt >> >> BUILD FAILED >> /scratch/jenkins/workspace/jtreg/make/build.xml:192: Java returned: 6 >> at org.apache.tools.ant.taskdefs.Java.execute(Java.java:111) >> at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292) >> at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) >> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >> at java.lang.reflect.Method.invoke(Method.java:498) >> at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) >> at org.apache.tools.ant.Task.perform(Task.java:348) >> at org.apache.tools.ant.Target.execute(Target.java:435) >> at org.apache.tools.ant.Target.performTasks(Target.java:456) >> at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1393) >> at org.apache.tools.ant.Project.executeTarget(Project.java:1364) >> at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) >> at org.apache.tools.ant.Project.executeTargets(Project.java:1248) >> at org.apache.tools.ant.Main.runBuild(Main.java:851) >> at org.apache.tools.ant.Main.startAnt(Main.java:235) >> at org.apache.tools.ant.launch.Launcher.run(Launcher.java:280) >> at org.apache.tools.ant.launch.Launcher.main(Launcher.java:109) >> >> >> Checking the usage.txt created in we see: >> >> >> Error: Unexpected exception occurred! java.lang.NullPointerException >> java.lang.NullPointerException >> at sun.reflect.UnsafeFieldAccessorImpl.ensureObj(UnsafeFieldAccessorImpl.java:57) >> at sun.reflect.UnsafeObjectFieldAccessorImpl.set(UnsafeObjectFieldAccessorImpl.java:75) >> at java.lang.reflect.Field.set(Field.java:764) >> at com.sun.javatest.regtest.tool.Help.showCommandLineHelp(Help.java:332) >> at com.sun.javatest.regtest.tool.Help.show(Help.java:168) >> at com.sun.javatest.regtest.tool.Tool.run(Tool.java:960) >> at com.sun.javatest.regtest.tool.Tool.run(Tool.java:953) >> at com.sun.javatest.regtest.tool.Tool.main(Tool.java:133) >> at com.sun.javatest.regtest.Main.main(Main.java:58) >> >> Logs can be found at https://adopt-openjdk.ci.cloudbees.com/job/jtreg/843/consoleFull >> >> >> Any ideas whats leading to it? >> >> >> Cheers, >> >> Mani >> >> >> -- >> @theNeomatrix369 * | **Blog >> ** | *LJC Associate & LJC Advocate >> (@adoptopenjdk & @adoptajsr programs) >> *Meet-a-Project - *MutabilityDetector >> * | **Bitbucket >> * * | **Github >> * * | **LinkedIn >> * >> *Come to Devoxx UK 2017:* http://www.devoxx.co.uk/ >> >> *Don't chase success, rather aim for "Excellence", and success will come >> chasing after you!* >> From jonathan.gibbons at oracle.com Mon Jun 12 21:38:03 2017 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 12 Jun 2017 21:38:03 +0000 Subject: hg: code-tools/jtreg: 2 new changesets Message-ID: <201706122138.v5CLc3OC013637@aojmv0008.oracle.com> Changeset: f08b9f04a2a5 Author: jjg Date: 2017-06-12 14:15 -0700 URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/f08b9f04a2a5 Update tests in line with latest Jigsaw updates ! test/modlibs/TEST.ROOT - test/moduleExports/ExportsPrivate.java - test/moduleExports/ModuleExportsTest.gmk - test/moduleExports/TEST.ROOT + test/moduleOpens/ModuleOpen.java + test/moduleOpens/ModuleOpensTest.gmk + test/moduleOpens/TEST.ROOT Changeset: 33d0a6d64b82 Author: jjg Date: 2017-06-12 14:35 -0700 URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/33d0a6d64b82 fix unnecessary use of #id0 qualifier ! src/share/classes/com/sun/javatest/regtest/config/RegressionTestFinder.java From stuart.monteith at linaro.org Wed Jun 21 15:15:07 2017 From: stuart.monteith at linaro.org (Stuart Monteith) Date: Wed, 21 Jun 2017 16:15:07 +0100 Subject: Jtreg build is failing In-Reply-To: <2eabe5f4-cf0d-5eb0-2b32-1246e52a9cf5@oracle.com> References: <2eabe5f4-cf0d-5eb0-2b32-1246e52a9cf5@oracle.com> Message-ID: Hi, I just noticed I have hit this problem. HelpTree in jtharness-5.0.jar has this: private java.util.Comparator nodeComparator; Whereas in jtharness-4.6.jar it has: private static java.util.Comparator nodeComparator; i.e. the nodeComparator field is no longer a static field. This happened since adopt-openjdk started building with this: https://adopt-openjdk.ci.cloudbees.com/job/jtharness/lastSuccessfulBuild/artifact/jtharness-5.0.tar.gz BR, Stuart On 9 June 2017 at 20:23, Jonathan Gibbons wrote: > From a brief examination of the stacktrace, it looks like you have > now-incompatible versions of jtharness and jtreg. > > I will make the jtreg code more robust. > > -- Jon > > > > On 6/9/17 8:01 AM, Mani Sarkar wrote: >> >> Hi Jon, >> >> Any suggestions on how to resolve the below, apologies if I have missed >> out >> any communication with regards to the below. >> >> Thanks. >> >> Cheers, >> Mani >> >> On Fri, 2 Jun 2017 at 17:04 Mani Sarkar wrote: >> >>> Hi all, >>> >>> Recently jtreg stopped building on our build farm, checking the logs we >>> got (this version uses jdk9 as one of the jdks during the build process): >>> >>> -compile-jtreg.usage: >>> [mkdir] Created dir: /scratch/jenkins/workspace/jtreg/build/jtreg >>> [java] Executing >>> '/opt/java/sdk/Oracle/x86_64/jdk1.8.0_102/jre/bin/java' with arguments: >>> [java] '-Dprogram=jtreg' >>> [java] '-classpath' >>> [java] >>> '/scratch/jenkins/workspace/jtreg/build/classes:/scratch/jenkins/workspace/jtreg/jtharness/lib/javatest.jar:/scratch/jenkins/workspace/jtreg/junit/junit.jar:/scratch/jenkins/workspace/jtreg/jh2.0/javahelp/lib/jh.jar' >>> [java] 'com.sun.javatest.regtest.Main' >>> [java] '-help' >>> [java] 'all' >>> [java] >>> [java] The ' characters around the executable and arguments are >>> [java] not part of the command. >>> [java] Output redirected to >>> /scratch/jenkins/workspace/jtreg/build/jtreg/usage.txt >>> >>> BUILD FAILED >>> /scratch/jenkins/workspace/jtreg/make/build.xml:192: Java returned: 6 >>> at org.apache.tools.ant.taskdefs.Java.execute(Java.java:111) >>> at >>> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292) >>> at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) >>> at >>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >>> at java.lang.reflect.Method.invoke(Method.java:498) >>> at >>> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) >>> at org.apache.tools.ant.Task.perform(Task.java:348) >>> at org.apache.tools.ant.Target.execute(Target.java:435) >>> at org.apache.tools.ant.Target.performTasks(Target.java:456) >>> at >>> org.apache.tools.ant.Project.executeSortedTargets(Project.java:1393) >>> at org.apache.tools.ant.Project.executeTarget(Project.java:1364) >>> at >>> org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) >>> at org.apache.tools.ant.Project.executeTargets(Project.java:1248) >>> at org.apache.tools.ant.Main.runBuild(Main.java:851) >>> at org.apache.tools.ant.Main.startAnt(Main.java:235) >>> at org.apache.tools.ant.launch.Launcher.run(Launcher.java:280) >>> at org.apache.tools.ant.launch.Launcher.main(Launcher.java:109) >>> >>> >>> Checking the usage.txt created in we see: >>> >>> >>> Error: Unexpected exception occurred! java.lang.NullPointerException >>> java.lang.NullPointerException >>> at >>> sun.reflect.UnsafeFieldAccessorImpl.ensureObj(UnsafeFieldAccessorImpl.java:57) >>> at >>> sun.reflect.UnsafeObjectFieldAccessorImpl.set(UnsafeObjectFieldAccessorImpl.java:75) >>> at java.lang.reflect.Field.set(Field.java:764) >>> at >>> com.sun.javatest.regtest.tool.Help.showCommandLineHelp(Help.java:332) >>> at com.sun.javatest.regtest.tool.Help.show(Help.java:168) >>> at com.sun.javatest.regtest.tool.Tool.run(Tool.java:960) >>> at com.sun.javatest.regtest.tool.Tool.run(Tool.java:953) >>> at com.sun.javatest.regtest.tool.Tool.main(Tool.java:133) >>> at com.sun.javatest.regtest.Main.main(Main.java:58) >>> >>> Logs can be found at >>> https://adopt-openjdk.ci.cloudbees.com/job/jtreg/843/consoleFull >>> >>> >>> Any ideas whats leading to it? >>> >>> >>> Cheers, >>> >>> Mani >>> >>> >>> -- >>> @theNeomatrix369 * | **Blog >>> ** | *LJC Associate & LJC Advocate >>> (@adoptopenjdk & @adoptajsr programs) >>> *Meet-a-Project - *MutabilityDetector >>> * | **Bitbucket >>> * * | **Github >>> * * | **LinkedIn >>> * >>> *Come to Devoxx UK 2017:* http://www.devoxx.co.uk/ >>> >>> *Don't chase success, rather aim for "Excellence", and success will come >>> chasing after you!* >>> > From jonathan.gibbons at oracle.com Wed Jun 21 15:30:15 2017 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 21 Jun 2017 08:30:15 -0700 Subject: Jtreg build is failing In-Reply-To: References: <2eabe5f4-cf0d-5eb0-2b32-1246e52a9cf5@oracle.com> Message-ID: <3297199d-49c9-c281-7b3a-23dd6b81e2ec@oracle.com> Yes, jtreg has not yet been updated to be compatible with JTHarness 5.0. -- Jon On 6/21/17 8:15 AM, Stuart Monteith wrote: > Hi, > I just noticed I have hit this problem. > > HelpTree in jtharness-5.0.jar has this: > private java.util.Comparator nodeComparator; > Whereas in jtharness-4.6.jar it has: > private static java.util.Comparator nodeComparator; > > i.e. the nodeComparator field is no longer a static field. > > This happened since adopt-openjdk started building with this: > https://adopt-openjdk.ci.cloudbees.com/job/jtharness/lastSuccessfulBuild/artifact/jtharness-5.0.tar.gz > > BR, > Stuart > > > On 9 June 2017 at 20:23, Jonathan Gibbons wrote: >> From a brief examination of the stacktrace, it looks like you have >> now-incompatible versions of jtharness and jtreg. >> >> I will make the jtreg code more robust. >> >> -- Jon >> >> >> >> On 6/9/17 8:01 AM, Mani Sarkar wrote: >>> Hi Jon, >>> >>> Any suggestions on how to resolve the below, apologies if I have missed >>> out >>> any communication with regards to the below. >>> >>> Thanks. >>> >>> Cheers, >>> Mani >>> >>> On Fri, 2 Jun 2017 at 17:04 Mani Sarkar wrote: >>> >>>> Hi all, >>>> >>>> Recently jtreg stopped building on our build farm, checking the logs we >>>> got (this version uses jdk9 as one of the jdks during the build process): >>>> >>>> -compile-jtreg.usage: >>>> [mkdir] Created dir: /scratch/jenkins/workspace/jtreg/build/jtreg >>>> [java] Executing >>>> '/opt/java/sdk/Oracle/x86_64/jdk1.8.0_102/jre/bin/java' with arguments: >>>> [java] '-Dprogram=jtreg' >>>> [java] '-classpath' >>>> [java] >>>> '/scratch/jenkins/workspace/jtreg/build/classes:/scratch/jenkins/workspace/jtreg/jtharness/lib/javatest.jar:/scratch/jenkins/workspace/jtreg/junit/junit.jar:/scratch/jenkins/workspace/jtreg/jh2.0/javahelp/lib/jh.jar' >>>> [java] 'com.sun.javatest.regtest.Main' >>>> [java] '-help' >>>> [java] 'all' >>>> [java] >>>> [java] The ' characters around the executable and arguments are >>>> [java] not part of the command. >>>> [java] Output redirected to >>>> /scratch/jenkins/workspace/jtreg/build/jtreg/usage.txt >>>> >>>> BUILD FAILED >>>> /scratch/jenkins/workspace/jtreg/make/build.xml:192: Java returned: 6 >>>> at org.apache.tools.ant.taskdefs.Java.execute(Java.java:111) >>>> at >>>> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292) >>>> at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) >>>> at >>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >>>> at java.lang.reflect.Method.invoke(Method.java:498) >>>> at >>>> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) >>>> at org.apache.tools.ant.Task.perform(Task.java:348) >>>> at org.apache.tools.ant.Target.execute(Target.java:435) >>>> at org.apache.tools.ant.Target.performTasks(Target.java:456) >>>> at >>>> org.apache.tools.ant.Project.executeSortedTargets(Project.java:1393) >>>> at org.apache.tools.ant.Project.executeTarget(Project.java:1364) >>>> at >>>> org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) >>>> at org.apache.tools.ant.Project.executeTargets(Project.java:1248) >>>> at org.apache.tools.ant.Main.runBuild(Main.java:851) >>>> at org.apache.tools.ant.Main.startAnt(Main.java:235) >>>> at org.apache.tools.ant.launch.Launcher.run(Launcher.java:280) >>>> at org.apache.tools.ant.launch.Launcher.main(Launcher.java:109) >>>> >>>> >>>> Checking the usage.txt created in we see: >>>> >>>> >>>> Error: Unexpected exception occurred! java.lang.NullPointerException >>>> java.lang.NullPointerException >>>> at >>>> sun.reflect.UnsafeFieldAccessorImpl.ensureObj(UnsafeFieldAccessorImpl.java:57) >>>> at >>>> sun.reflect.UnsafeObjectFieldAccessorImpl.set(UnsafeObjectFieldAccessorImpl.java:75) >>>> at java.lang.reflect.Field.set(Field.java:764) >>>> at >>>> com.sun.javatest.regtest.tool.Help.showCommandLineHelp(Help.java:332) >>>> at com.sun.javatest.regtest.tool.Help.show(Help.java:168) >>>> at com.sun.javatest.regtest.tool.Tool.run(Tool.java:960) >>>> at com.sun.javatest.regtest.tool.Tool.run(Tool.java:953) >>>> at com.sun.javatest.regtest.tool.Tool.main(Tool.java:133) >>>> at com.sun.javatest.regtest.Main.main(Main.java:58) >>>> >>>> Logs can be found at >>>> https://adopt-openjdk.ci.cloudbees.com/job/jtreg/843/consoleFull >>>> >>>> >>>> Any ideas whats leading to it? >>>> >>>> >>>> Cheers, >>>> >>>> Mani >>>> >>>> >>>> -- >>>> @theNeomatrix369 * | **Blog >>>> ** | *LJC Associate & LJC Advocate >>>> (@adoptopenjdk & @adoptajsr programs) >>>> *Meet-a-Project - *MutabilityDetector >>>> * | **Bitbucket >>>> * * | **Github >>>> * * | **LinkedIn >>>> * >>>> *Come to Devoxx UK 2017:* http://www.devoxx.co.uk/ >>>> >>>> *Don't chase success, rather aim for "Excellence", and success will come >>>> chasing after you!* >>>> From stuart.monteith at linaro.org Wed Jun 21 15:48:26 2017 From: stuart.monteith at linaro.org (Stuart Monteith) Date: Wed, 21 Jun 2017 16:48:26 +0100 Subject: Jtreg build is failing In-Reply-To: <3297199d-49c9-c281-7b3a-23dd6b81e2ec@oracle.com> References: <2eabe5f4-cf0d-5eb0-2b32-1246e52a9cf5@oracle.com> <3297199d-49c9-c281-7b3a-23dd6b81e2ec@oracle.com> Message-ID: The immediate problem is solved with the patch below (with no regards to backwards compatibility). I'm note getting clean test runs though. I see: TRT.finished(), attempting cache compress...TRT.finished(), requesting cache flush...Test results: passed: 89; failed: 47; error: 87 Report written to /home/stumon01/jtreg-local/jtreg/build/Basic.othervm/report/html/report.html Results written to /home/stumon01/jtreg-local/jtreg/build/Basic.othervm/work Error: Some tests failed or other problems occurred. ok...batch execution checking selection according to previous state state: 0 (passed) expected number of tests: 92 found: 89 wrong number of tests found java.lang.Error: wrong number of tests found at Basic.failed(Basic.java:346) at Basic.checkPreviousStateSelection(Basic.java:272) at Basic.(Basic.java:115) at Basic.main(Basic.java:50) ../test/basic/Basic.gmk:78: recipe for target '../build/Basic.othervm.ok' failed make: *** [../build/Basic.othervm.ok] Error 1 make: Leaving directory '/home/stumon01/jtreg-local/jtreg/make' I've not compared this against running with jtharness-4.6.jar. I don't suppose you're looking additional issues? BR, Stuart # HG changeset patch # User smonteith # Date 1498059859 -3600 # Wed Jun 21 16:44:19 2017 +0100 # Node ID 75cda45229ca989faf3e8ba83f45ccb951b1bb8f # Parent 33d0a6d64b82f5ca23b7b1eaadf74317b2204ecf Fix HelpTree field access diff -r 33d0a6d64b82 -r 75cda45229ca src/share/classes/com/sun/javatest/regtest/tool/Help.java --- a/src/share/classes/com/sun/javatest/regtest/tool/Help.java Mon Jun 12 14:35:46 2017 -0700 +++ b/src/share/classes/com/sun/javatest/regtest/tool/Help.java Wed Jun 21 16:44:19 2017 +0100 @@ -329,7 +329,7 @@ try{ Field f = HelpTree.class.getDeclaredField("nodeComparator"); f.setAccessible(true); - f.set(null, new NodeComparator()); + f.set(commandHelpTree, new NodeComparator()); } catch (IllegalAccessException | IllegalArgumentException | NoSuchFieldException | SecurityException ignore) { } On 21 June 2017 at 16:30, Jonathan Gibbons wrote: > Yes, jtreg has not yet been updated to be compatible with JTHarness 5.0. > > -- Jon > > > > On 6/21/17 8:15 AM, Stuart Monteith wrote: >> >> Hi, >> I just noticed I have hit this problem. >> >> HelpTree in jtharness-5.0.jar has this: >> private java.util.Comparator nodeComparator; >> Whereas in jtharness-4.6.jar it has: >> private static java.util.Comparator nodeComparator; >> >> i.e. the nodeComparator field is no longer a static field. >> >> This happened since adopt-openjdk started building with this: >> >> https://adopt-openjdk.ci.cloudbees.com/job/jtharness/lastSuccessfulBuild/artifact/jtharness-5.0.tar.gz >> >> BR, >> Stuart >> >> >> On 9 June 2017 at 20:23, Jonathan Gibbons >> wrote: >>> >>> From a brief examination of the stacktrace, it looks like you have >>> now-incompatible versions of jtharness and jtreg. >>> >>> I will make the jtreg code more robust. >>> >>> -- Jon >>> >>> >>> >>> On 6/9/17 8:01 AM, Mani Sarkar wrote: >>>> >>>> Hi Jon, >>>> >>>> Any suggestions on how to resolve the below, apologies if I have missed >>>> out >>>> any communication with regards to the below. >>>> >>>> Thanks. >>>> >>>> Cheers, >>>> Mani >>>> >>>> On Fri, 2 Jun 2017 at 17:04 Mani Sarkar wrote: >>>> >>>>> Hi all, >>>>> >>>>> Recently jtreg stopped building on our build farm, checking the logs we >>>>> got (this version uses jdk9 as one of the jdks during the build >>>>> process): >>>>> >>>>> -compile-jtreg.usage: >>>>> [mkdir] Created dir: /scratch/jenkins/workspace/jtreg/build/jtreg >>>>> [java] Executing >>>>> '/opt/java/sdk/Oracle/x86_64/jdk1.8.0_102/jre/bin/java' with arguments: >>>>> [java] '-Dprogram=jtreg' >>>>> [java] '-classpath' >>>>> [java] >>>>> >>>>> '/scratch/jenkins/workspace/jtreg/build/classes:/scratch/jenkins/workspace/jtreg/jtharness/lib/javatest.jar:/scratch/jenkins/workspace/jtreg/junit/junit.jar:/scratch/jenkins/workspace/jtreg/jh2.0/javahelp/lib/jh.jar' >>>>> [java] 'com.sun.javatest.regtest.Main' >>>>> [java] '-help' >>>>> [java] 'all' >>>>> [java] >>>>> [java] The ' characters around the executable and arguments are >>>>> [java] not part of the command. >>>>> [java] Output redirected to >>>>> /scratch/jenkins/workspace/jtreg/build/jtreg/usage.txt >>>>> >>>>> BUILD FAILED >>>>> /scratch/jenkins/workspace/jtreg/make/build.xml:192: Java returned: 6 >>>>> at org.apache.tools.ant.taskdefs.Java.execute(Java.java:111) >>>>> at >>>>> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292) >>>>> at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) >>>>> at >>>>> >>>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >>>>> at java.lang.reflect.Method.invoke(Method.java:498) >>>>> at >>>>> >>>>> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) >>>>> at org.apache.tools.ant.Task.perform(Task.java:348) >>>>> at org.apache.tools.ant.Target.execute(Target.java:435) >>>>> at org.apache.tools.ant.Target.performTasks(Target.java:456) >>>>> at >>>>> org.apache.tools.ant.Project.executeSortedTargets(Project.java:1393) >>>>> at >>>>> org.apache.tools.ant.Project.executeTarget(Project.java:1364) >>>>> at >>>>> >>>>> org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) >>>>> at >>>>> org.apache.tools.ant.Project.executeTargets(Project.java:1248) >>>>> at org.apache.tools.ant.Main.runBuild(Main.java:851) >>>>> at org.apache.tools.ant.Main.startAnt(Main.java:235) >>>>> at org.apache.tools.ant.launch.Launcher.run(Launcher.java:280) >>>>> at >>>>> org.apache.tools.ant.launch.Launcher.main(Launcher.java:109) >>>>> >>>>> >>>>> Checking the usage.txt created in we see: >>>>> >>>>> >>>>> Error: Unexpected exception occurred! java.lang.NullPointerException >>>>> java.lang.NullPointerException >>>>> at >>>>> >>>>> sun.reflect.UnsafeFieldAccessorImpl.ensureObj(UnsafeFieldAccessorImpl.java:57) >>>>> at >>>>> >>>>> sun.reflect.UnsafeObjectFieldAccessorImpl.set(UnsafeObjectFieldAccessorImpl.java:75) >>>>> at java.lang.reflect.Field.set(Field.java:764) >>>>> at >>>>> com.sun.javatest.regtest.tool.Help.showCommandLineHelp(Help.java:332) >>>>> at com.sun.javatest.regtest.tool.Help.show(Help.java:168) >>>>> at com.sun.javatest.regtest.tool.Tool.run(Tool.java:960) >>>>> at com.sun.javatest.regtest.tool.Tool.run(Tool.java:953) >>>>> at com.sun.javatest.regtest.tool.Tool.main(Tool.java:133) >>>>> at com.sun.javatest.regtest.Main.main(Main.java:58) >>>>> >>>>> Logs can be found at >>>>> https://adopt-openjdk.ci.cloudbees.com/job/jtreg/843/consoleFull >>>>> >>>>> >>>>> Any ideas whats leading to it? >>>>> >>>>> >>>>> Cheers, >>>>> >>>>> Mani >>>>> >>>>> >>>>> -- >>>>> @theNeomatrix369 * | **Blog >>>>> ** | *LJC Associate & LJC >>>>> Advocate >>>>> (@adoptopenjdk & @adoptajsr programs) >>>>> *Meet-a-Project - *MutabilityDetector >>>>> * | **Bitbucket >>>>> * * | **Github >>>>> * * | **LinkedIn >>>>> * >>>>> *Come to Devoxx UK 2017:* http://www.devoxx.co.uk/ >>>>> >>>>> *Don't chase success, rather aim for "Excellence", and success will >>>>> come >>>>> chasing after you!* >>>>> > From stuart.monteith at linaro.org Wed Jun 21 16:11:15 2017 From: stuart.monteith at linaro.org (Stuart Monteith) Date: Wed, 21 Jun 2017 17:11:15 +0100 Subject: Jtreg build is failing In-Reply-To: References: <2eabe5f4-cf0d-5eb0-2b32-1246e52a9cf5@oracle.com> <3297199d-49c9-c281-7b3a-23dd6b81e2ec@oracle.com> Message-ID: Ok, I'm not seeing any better test results with the old jtharness.jar version. Also, "f.set(commandHelpTree, new NodeComparator()) " should be backwards compatible with the static field in the old version of jtharness, as "commandHelpTree" will just be ignored. BR, Stuart On 21 June 2017 at 16:48, Stuart Monteith wrote: > The immediate problem is solved with the patch below (with no regards > to backwards compatibility). > > I'm note getting clean test runs though. I see: > > TRT.finished(), attempting cache compress...TRT.finished(), requesting > cache flush...Test results: passed: 89; failed: 47; error: 87 > Report written to > /home/stumon01/jtreg-local/jtreg/build/Basic.othervm/report/html/report.html > Results written to /home/stumon01/jtreg-local/jtreg/build/Basic.othervm/work > Error: Some tests failed or other problems occurred. > ok...batch execution > checking selection according to previous state > state: 0 (passed) > expected number of tests: 92 > found: 89 > wrong number of tests found > java.lang.Error: wrong number of tests found > at Basic.failed(Basic.java:346) > at Basic.checkPreviousStateSelection(Basic.java:272) > at Basic.(Basic.java:115) > at Basic.main(Basic.java:50) > ../test/basic/Basic.gmk:78: recipe for target '../build/Basic.othervm.ok' failed > make: *** [../build/Basic.othervm.ok] Error 1 > make: Leaving directory '/home/stumon01/jtreg-local/jtreg/make' > > > I've not compared this against running with jtharness-4.6.jar. > > I don't suppose you're looking additional issues? > > BR, > Stuart > > > # HG changeset patch > # User smonteith > # Date 1498059859 -3600 > # Wed Jun 21 16:44:19 2017 +0100 > # Node ID 75cda45229ca989faf3e8ba83f45ccb951b1bb8f > # Parent 33d0a6d64b82f5ca23b7b1eaadf74317b2204ecf > Fix HelpTree field access > > diff -r 33d0a6d64b82 -r 75cda45229ca > src/share/classes/com/sun/javatest/regtest/tool/Help.java > --- a/src/share/classes/com/sun/javatest/regtest/tool/Help.java Mon > Jun 12 14:35:46 2017 -0700 > +++ b/src/share/classes/com/sun/javatest/regtest/tool/Help.java Wed > Jun 21 16:44:19 2017 +0100 > @@ -329,7 +329,7 @@ > try{ > Field f = HelpTree.class.getDeclaredField("nodeComparator"); > f.setAccessible(true); > - f.set(null, new NodeComparator()); > + f.set(commandHelpTree, new NodeComparator()); > } catch (IllegalAccessException | IllegalArgumentException | > NoSuchFieldException | SecurityException ignore) { > } > > On 21 June 2017 at 16:30, Jonathan Gibbons wrote: >> Yes, jtreg has not yet been updated to be compatible with JTHarness 5.0. >> >> -- Jon >> >> >> >> On 6/21/17 8:15 AM, Stuart Monteith wrote: >>> >>> Hi, >>> I just noticed I have hit this problem. >>> >>> HelpTree in jtharness-5.0.jar has this: >>> private java.util.Comparator nodeComparator; >>> Whereas in jtharness-4.6.jar it has: >>> private static java.util.Comparator nodeComparator; >>> >>> i.e. the nodeComparator field is no longer a static field. >>> >>> This happened since adopt-openjdk started building with this: >>> >>> https://adopt-openjdk.ci.cloudbees.com/job/jtharness/lastSuccessfulBuild/artifact/jtharness-5.0.tar.gz >>> >>> BR, >>> Stuart >>> >>> >>> On 9 June 2017 at 20:23, Jonathan Gibbons >>> wrote: >>>> >>>> From a brief examination of the stacktrace, it looks like you have >>>> now-incompatible versions of jtharness and jtreg. >>>> >>>> I will make the jtreg code more robust. >>>> >>>> -- Jon >>>> >>>> >>>> >>>> On 6/9/17 8:01 AM, Mani Sarkar wrote: >>>>> >>>>> Hi Jon, >>>>> >>>>> Any suggestions on how to resolve the below, apologies if I have missed >>>>> out >>>>> any communication with regards to the below. >>>>> >>>>> Thanks. >>>>> >>>>> Cheers, >>>>> Mani >>>>> >>>>> On Fri, 2 Jun 2017 at 17:04 Mani Sarkar wrote: >>>>> >>>>>> Hi all, >>>>>> >>>>>> Recently jtreg stopped building on our build farm, checking the logs we >>>>>> got (this version uses jdk9 as one of the jdks during the build >>>>>> process): >>>>>> >>>>>> -compile-jtreg.usage: >>>>>> [mkdir] Created dir: /scratch/jenkins/workspace/jtreg/build/jtreg >>>>>> [java] Executing >>>>>> '/opt/java/sdk/Oracle/x86_64/jdk1.8.0_102/jre/bin/java' with arguments: >>>>>> [java] '-Dprogram=jtreg' >>>>>> [java] '-classpath' >>>>>> [java] >>>>>> >>>>>> '/scratch/jenkins/workspace/jtreg/build/classes:/scratch/jenkins/workspace/jtreg/jtharness/lib/javatest.jar:/scratch/jenkins/workspace/jtreg/junit/junit.jar:/scratch/jenkins/workspace/jtreg/jh2.0/javahelp/lib/jh.jar' >>>>>> [java] 'com.sun.javatest.regtest.Main' >>>>>> [java] '-help' >>>>>> [java] 'all' >>>>>> [java] >>>>>> [java] The ' characters around the executable and arguments are >>>>>> [java] not part of the command. >>>>>> [java] Output redirected to >>>>>> /scratch/jenkins/workspace/jtreg/build/jtreg/usage.txt >>>>>> >>>>>> BUILD FAILED >>>>>> /scratch/jenkins/workspace/jtreg/make/build.xml:192: Java returned: 6 >>>>>> at org.apache.tools.ant.taskdefs.Java.execute(Java.java:111) >>>>>> at >>>>>> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292) >>>>>> at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) >>>>>> at >>>>>> >>>>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >>>>>> at java.lang.reflect.Method.invoke(Method.java:498) >>>>>> at >>>>>> >>>>>> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) >>>>>> at org.apache.tools.ant.Task.perform(Task.java:348) >>>>>> at org.apache.tools.ant.Target.execute(Target.java:435) >>>>>> at org.apache.tools.ant.Target.performTasks(Target.java:456) >>>>>> at >>>>>> org.apache.tools.ant.Project.executeSortedTargets(Project.java:1393) >>>>>> at >>>>>> org.apache.tools.ant.Project.executeTarget(Project.java:1364) >>>>>> at >>>>>> >>>>>> org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) >>>>>> at >>>>>> org.apache.tools.ant.Project.executeTargets(Project.java:1248) >>>>>> at org.apache.tools.ant.Main.runBuild(Main.java:851) >>>>>> at org.apache.tools.ant.Main.startAnt(Main.java:235) >>>>>> at org.apache.tools.ant.launch.Launcher.run(Launcher.java:280) >>>>>> at >>>>>> org.apache.tools.ant.launch.Launcher.main(Launcher.java:109) >>>>>> >>>>>> >>>>>> Checking the usage.txt created in we see: >>>>>> >>>>>> >>>>>> Error: Unexpected exception occurred! java.lang.NullPointerException >>>>>> java.lang.NullPointerException >>>>>> at >>>>>> >>>>>> sun.reflect.UnsafeFieldAccessorImpl.ensureObj(UnsafeFieldAccessorImpl.java:57) >>>>>> at >>>>>> >>>>>> sun.reflect.UnsafeObjectFieldAccessorImpl.set(UnsafeObjectFieldAccessorImpl.java:75) >>>>>> at java.lang.reflect.Field.set(Field.java:764) >>>>>> at >>>>>> com.sun.javatest.regtest.tool.Help.showCommandLineHelp(Help.java:332) >>>>>> at com.sun.javatest.regtest.tool.Help.show(Help.java:168) >>>>>> at com.sun.javatest.regtest.tool.Tool.run(Tool.java:960) >>>>>> at com.sun.javatest.regtest.tool.Tool.run(Tool.java:953) >>>>>> at com.sun.javatest.regtest.tool.Tool.main(Tool.java:133) >>>>>> at com.sun.javatest.regtest.Main.main(Main.java:58) >>>>>> >>>>>> Logs can be found at >>>>>> https://adopt-openjdk.ci.cloudbees.com/job/jtreg/843/consoleFull >>>>>> >>>>>> >>>>>> Any ideas whats leading to it? >>>>>> >>>>>> >>>>>> Cheers, >>>>>> >>>>>> Mani >>>>>> >>>>>> >>>>>> -- >>>>>> @theNeomatrix369 * | **Blog >>>>>> ** | *LJC Associate & LJC >>>>>> Advocate >>>>>> (@adoptopenjdk & @adoptajsr programs) >>>>>> *Meet-a-Project - *MutabilityDetector >>>>>> * | **Bitbucket >>>>>> * * | **Github >>>>>> * * | **LinkedIn >>>>>> * >>>>>> *Come to Devoxx UK 2017:* http://www.devoxx.co.uk/ >>>>>> >>>>>> *Don't chase success, rather aim for "Excellence", and success will >>>>>> come >>>>>> chasing after you!* >>>>>> >> From jonathan.gibbons at oracle.com Wed Jun 21 16:29:51 2017 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 21 Jun 2017 09:29:51 -0700 Subject: Jtreg build is failing In-Reply-To: References: <2eabe5f4-cf0d-5eb0-2b32-1246e52a9cf5@oracle.com> <3297199d-49c9-c281-7b3a-23dd6b81e2ec@oracle.com> Message-ID: <594A9EFF.5030007@oracle.com> Stuart, Your fix for the HelpTree problem looks like the fix I would anticipate. I'll try it out locally and run the tests. You don't give enough info for me to diagnose why the tests are not running for you. Are you using the recommended version of other libraries, and not necessarily the latest version? (i.e. the version we recommend for use with jtreg) Some other folk are looking at making the overall jtreg build easier to configure. That work is ongoing. -- Jon On 06/21/2017 09:11 AM, Stuart Monteith wrote: > Ok, I'm not seeing any better test results with the old jtharness.jar version. > > Also, "f.set(commandHelpTree, new NodeComparator()) " should be > backwards compatible with the static field in the old version of > jtharness, as "commandHelpTree" will just be ignored. > > BR, > Stuart > > On 21 June 2017 at 16:48, Stuart Monteith wrote: >> The immediate problem is solved with the patch below (with no regards >> to backwards compatibility). >> >> I'm note getting clean test runs though. I see: >> >> TRT.finished(), attempting cache compress...TRT.finished(), requesting >> cache flush...Test results: passed: 89; failed: 47; error: 87 >> Report written to >> /home/stumon01/jtreg-local/jtreg/build/Basic.othervm/report/html/report.html >> Results written to /home/stumon01/jtreg-local/jtreg/build/Basic.othervm/work >> Error: Some tests failed or other problems occurred. >> ok...batch execution >> checking selection according to previous state >> state: 0 (passed) >> expected number of tests: 92 >> found: 89 >> wrong number of tests found >> java.lang.Error: wrong number of tests found >> at Basic.failed(Basic.java:346) >> at Basic.checkPreviousStateSelection(Basic.java:272) >> at Basic.(Basic.java:115) >> at Basic.main(Basic.java:50) >> ../test/basic/Basic.gmk:78: recipe for target '../build/Basic.othervm.ok' failed >> make: *** [../build/Basic.othervm.ok] Error 1 >> make: Leaving directory '/home/stumon01/jtreg-local/jtreg/make' >> >> >> I've not compared this against running with jtharness-4.6.jar. >> >> I don't suppose you're looking additional issues? >> >> BR, >> Stuart >> >> >> # HG changeset patch >> # User smonteith >> # Date 1498059859 -3600 >> # Wed Jun 21 16:44:19 2017 +0100 >> # Node ID 75cda45229ca989faf3e8ba83f45ccb951b1bb8f >> # Parent 33d0a6d64b82f5ca23b7b1eaadf74317b2204ecf >> Fix HelpTree field access >> >> diff -r 33d0a6d64b82 -r 75cda45229ca >> src/share/classes/com/sun/javatest/regtest/tool/Help.java >> --- a/src/share/classes/com/sun/javatest/regtest/tool/Help.java Mon >> Jun 12 14:35:46 2017 -0700 >> +++ b/src/share/classes/com/sun/javatest/regtest/tool/Help.java Wed >> Jun 21 16:44:19 2017 +0100 >> @@ -329,7 +329,7 @@ >> try{ >> Field f = HelpTree.class.getDeclaredField("nodeComparator"); >> f.setAccessible(true); >> - f.set(null, new NodeComparator()); >> + f.set(commandHelpTree, new NodeComparator()); >> } catch (IllegalAccessException | IllegalArgumentException | >> NoSuchFieldException | SecurityException ignore) { >> } >> >> On 21 June 2017 at 16:30, Jonathan Gibbons wrote: >>> Yes, jtreg has not yet been updated to be compatible with JTHarness 5.0. >>> >>> -- Jon >>> >>> >>> >>> On 6/21/17 8:15 AM, Stuart Monteith wrote: >>>> Hi, >>>> I just noticed I have hit this problem. >>>> >>>> HelpTree in jtharness-5.0.jar has this: >>>> private java.util.Comparator nodeComparator; >>>> Whereas in jtharness-4.6.jar it has: >>>> private static java.util.Comparator nodeComparator; >>>> >>>> i.e. the nodeComparator field is no longer a static field. >>>> >>>> This happened since adopt-openjdk started building with this: >>>> >>>> https://adopt-openjdk.ci.cloudbees.com/job/jtharness/lastSuccessfulBuild/artifact/jtharness-5.0.tar.gz >>>> >>>> BR, >>>> Stuart >>>> >>>> >>>> On 9 June 2017 at 20:23, Jonathan Gibbons >>>> wrote: >>>>> From a brief examination of the stacktrace, it looks like you have >>>>> now-incompatible versions of jtharness and jtreg. >>>>> >>>>> I will make the jtreg code more robust. >>>>> >>>>> -- Jon >>>>> >>>>> >>>>> >>>>> On 6/9/17 8:01 AM, Mani Sarkar wrote: >>>>>> Hi Jon, >>>>>> >>>>>> Any suggestions on how to resolve the below, apologies if I have missed >>>>>> out >>>>>> any communication with regards to the below. >>>>>> >>>>>> Thanks. >>>>>> >>>>>> Cheers, >>>>>> Mani >>>>>> >>>>>> On Fri, 2 Jun 2017 at 17:04 Mani Sarkar wrote: >>>>>> >>>>>>> Hi all, >>>>>>> >>>>>>> Recently jtreg stopped building on our build farm, checking the logs we >>>>>>> got (this version uses jdk9 as one of the jdks during the build >>>>>>> process): >>>>>>> >>>>>>> -compile-jtreg.usage: >>>>>>> [mkdir] Created dir: /scratch/jenkins/workspace/jtreg/build/jtreg >>>>>>> [java] Executing >>>>>>> '/opt/java/sdk/Oracle/x86_64/jdk1.8.0_102/jre/bin/java' with arguments: >>>>>>> [java] '-Dprogram=jtreg' >>>>>>> [java] '-classpath' >>>>>>> [java] >>>>>>> >>>>>>> '/scratch/jenkins/workspace/jtreg/build/classes:/scratch/jenkins/workspace/jtreg/jtharness/lib/javatest.jar:/scratch/jenkins/workspace/jtreg/junit/junit.jar:/scratch/jenkins/workspace/jtreg/jh2.0/javahelp/lib/jh.jar' >>>>>>> [java] 'com.sun.javatest.regtest.Main' >>>>>>> [java] '-help' >>>>>>> [java] 'all' >>>>>>> [java] >>>>>>> [java] The ' characters around the executable and arguments are >>>>>>> [java] not part of the command. >>>>>>> [java] Output redirected to >>>>>>> /scratch/jenkins/workspace/jtreg/build/jtreg/usage.txt >>>>>>> >>>>>>> BUILD FAILED >>>>>>> /scratch/jenkins/workspace/jtreg/make/build.xml:192: Java returned: 6 >>>>>>> at org.apache.tools.ant.taskdefs.Java.execute(Java.java:111) >>>>>>> at >>>>>>> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292) >>>>>>> at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) >>>>>>> at >>>>>>> >>>>>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >>>>>>> at java.lang.reflect.Method.invoke(Method.java:498) >>>>>>> at >>>>>>> >>>>>>> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) >>>>>>> at org.apache.tools.ant.Task.perform(Task.java:348) >>>>>>> at org.apache.tools.ant.Target.execute(Target.java:435) >>>>>>> at org.apache.tools.ant.Target.performTasks(Target.java:456) >>>>>>> at >>>>>>> org.apache.tools.ant.Project.executeSortedTargets(Project.java:1393) >>>>>>> at >>>>>>> org.apache.tools.ant.Project.executeTarget(Project.java:1364) >>>>>>> at >>>>>>> >>>>>>> org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) >>>>>>> at >>>>>>> org.apache.tools.ant.Project.executeTargets(Project.java:1248) >>>>>>> at org.apache.tools.ant.Main.runBuild(Main.java:851) >>>>>>> at org.apache.tools.ant.Main.startAnt(Main.java:235) >>>>>>> at org.apache.tools.ant.launch.Launcher.run(Launcher.java:280) >>>>>>> at >>>>>>> org.apache.tools.ant.launch.Launcher.main(Launcher.java:109) >>>>>>> >>>>>>> >>>>>>> Checking the usage.txt created in we see: >>>>>>> >>>>>>> >>>>>>> Error: Unexpected exception occurred! java.lang.NullPointerException >>>>>>> java.lang.NullPointerException >>>>>>> at >>>>>>> >>>>>>> sun.reflect.UnsafeFieldAccessorImpl.ensureObj(UnsafeFieldAccessorImpl.java:57) >>>>>>> at >>>>>>> >>>>>>> sun.reflect.UnsafeObjectFieldAccessorImpl.set(UnsafeObjectFieldAccessorImpl.java:75) >>>>>>> at java.lang.reflect.Field.set(Field.java:764) >>>>>>> at >>>>>>> com.sun.javatest.regtest.tool.Help.showCommandLineHelp(Help.java:332) >>>>>>> at com.sun.javatest.regtest.tool.Help.show(Help.java:168) >>>>>>> at com.sun.javatest.regtest.tool.Tool.run(Tool.java:960) >>>>>>> at com.sun.javatest.regtest.tool.Tool.run(Tool.java:953) >>>>>>> at com.sun.javatest.regtest.tool.Tool.main(Tool.java:133) >>>>>>> at com.sun.javatest.regtest.Main.main(Main.java:58) >>>>>>> >>>>>>> Logs can be found at >>>>>>> https://adopt-openjdk.ci.cloudbees.com/job/jtreg/843/consoleFull >>>>>>> >>>>>>> >>>>>>> Any ideas whats leading to it? >>>>>>> >>>>>>> >>>>>>> Cheers, >>>>>>> >>>>>>> Mani >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> @theNeomatrix369 * | **Blog >>>>>>> ** | *LJC Associate & LJC >>>>>>> Advocate >>>>>>> (@adoptopenjdk & @adoptajsr programs) >>>>>>> *Meet-a-Project - *MutabilityDetector >>>>>>> * | **Bitbucket >>>>>>> * * | **Github >>>>>>> * * | **LinkedIn >>>>>>> * >>>>>>> *Come to Devoxx UK 2017:* http://www.devoxx.co.uk/ >>>>>>> >>>>>>> *Don't chase success, rather aim for "Excellence", and success will >>>>>>> come >>>>>>> chasing after you!* >>>>>>> From stuart.monteith at linaro.org Wed Jun 21 17:00:02 2017 From: stuart.monteith at linaro.org (Stuart Monteith) Date: Wed, 21 Jun 2017 18:00:02 +0100 Subject: Jtreg build is failing In-Reply-To: <594A9EFF.5030007@oracle.com> References: <2eabe5f4-cf0d-5eb0-2b32-1246e52a9cf5@oracle.com> <3297199d-49c9-c281-7b3a-23dd6b81e2ec@oracle.com> <594A9EFF.5030007@oracle.com> Message-ID: The versions are (the ones I'm using, then the recommended versions from the README, then from the website): asmtools-6.0 - ? - 6.0 or better jtharness-5.0 - 4.1.3 - jtharness 4.6 or better junit-4.8.2 - junit 4 - JUnit 4.1.0 testng-6.9.5 - ? - 6.9.5 jcommander-1.48 - ? - ? javahelp-2.0.05 - 2.0_01 - e.g. javahelp2.0_05.zip There are some disparities. I've not investigated much to see why they are failing. I've put the build files here: http://people.linaro.org/~stuart.monteith/jtreg-build/Basic.othervm/report/ you can look around from here: http://people.linaro.org/~stuart.monteith/jtreg-build/ Thanks, Stuart On 21 June 2017 at 17:29, Jonathan Gibbons wrote: > Stuart, > > Your fix for the HelpTree problem looks like the fix I would anticipate. > I'll try it out locally and run the tests. > > You don't give enough info for me to diagnose why the tests are not > running for you. Are you using the recommended version of other libraries, > and not necessarily the latest version? (i.e. the version we recommend for > use with jtreg) > > Some other folk are looking at making the overall jtreg build easier to > configure. > That work is ongoing. > > -- Jon > > > On 06/21/2017 09:11 AM, Stuart Monteith wrote: >> >> Ok, I'm not seeing any better test results with the old jtharness.jar >> version. >> >> Also, "f.set(commandHelpTree, new NodeComparator()) " should be >> backwards compatible with the static field in the old version of >> jtharness, as "commandHelpTree" will just be ignored. >> >> BR, >> Stuart >> >> On 21 June 2017 at 16:48, Stuart Monteith >> wrote: >>> >>> The immediate problem is solved with the patch below (with no regards >>> to backwards compatibility). >>> >>> I'm note getting clean test runs though. I see: >>> >>> TRT.finished(), attempting cache compress...TRT.finished(), requesting >>> cache flush...Test results: passed: 89; failed: 47; error: 87 >>> Report written to >>> >>> /home/stumon01/jtreg-local/jtreg/build/Basic.othervm/report/html/report.html >>> Results written to >>> /home/stumon01/jtreg-local/jtreg/build/Basic.othervm/work >>> Error: Some tests failed or other problems occurred. >>> ok...batch execution >>> checking selection according to previous state >>> state: 0 (passed) >>> expected number of tests: 92 >>> found: 89 >>> wrong number of tests found >>> java.lang.Error: wrong number of tests found >>> at Basic.failed(Basic.java:346) >>> at Basic.checkPreviousStateSelection(Basic.java:272) >>> at Basic.(Basic.java:115) >>> at Basic.main(Basic.java:50) >>> ../test/basic/Basic.gmk:78: recipe for target '../build/Basic.othervm.ok' >>> failed >>> make: *** [../build/Basic.othervm.ok] Error 1 >>> make: Leaving directory '/home/stumon01/jtreg-local/jtreg/make' >>> >>> >>> I've not compared this against running with jtharness-4.6.jar. >>> >>> I don't suppose you're looking additional issues? >>> >>> BR, >>> Stuart >>> >>> >>> # HG changeset patch >>> # User smonteith >>> # Date 1498059859 -3600 >>> # Wed Jun 21 16:44:19 2017 +0100 >>> # Node ID 75cda45229ca989faf3e8ba83f45ccb951b1bb8f >>> # Parent 33d0a6d64b82f5ca23b7b1eaadf74317b2204ecf >>> Fix HelpTree field access >>> >>> diff -r 33d0a6d64b82 -r 75cda45229ca >>> src/share/classes/com/sun/javatest/regtest/tool/Help.java >>> --- a/src/share/classes/com/sun/javatest/regtest/tool/Help.java Mon >>> Jun 12 14:35:46 2017 -0700 >>> +++ b/src/share/classes/com/sun/javatest/regtest/tool/Help.java Wed >>> Jun 21 16:44:19 2017 +0100 >>> @@ -329,7 +329,7 @@ >>> try{ >>> Field f = >>> HelpTree.class.getDeclaredField("nodeComparator"); >>> f.setAccessible(true); >>> - f.set(null, new NodeComparator()); >>> + f.set(commandHelpTree, new NodeComparator()); >>> } catch (IllegalAccessException | IllegalArgumentException | >>> NoSuchFieldException | SecurityException ignore) { >>> } >>> >>> On 21 June 2017 at 16:30, Jonathan Gibbons >>> wrote: >>>> >>>> Yes, jtreg has not yet been updated to be compatible with JTHarness 5.0. >>>> >>>> -- Jon >>>> >>>> >>>> >>>> On 6/21/17 8:15 AM, Stuart Monteith wrote: >>>>> >>>>> Hi, >>>>> I just noticed I have hit this problem. >>>>> >>>>> HelpTree in jtharness-5.0.jar has this: >>>>> private java.util.Comparator nodeComparator; >>>>> Whereas in jtharness-4.6.jar it has: >>>>> private static java.util.Comparator nodeComparator; >>>>> >>>>> i.e. the nodeComparator field is no longer a static field. >>>>> >>>>> This happened since adopt-openjdk started building with this: >>>>> >>>>> >>>>> https://adopt-openjdk.ci.cloudbees.com/job/jtharness/lastSuccessfulBuild/artifact/jtharness-5.0.tar.gz >>>>> >>>>> BR, >>>>> Stuart >>>>> >>>>> >>>>> On 9 June 2017 at 20:23, Jonathan Gibbons >>>>> wrote: >>>>>> >>>>>> From a brief examination of the stacktrace, it looks like you have >>>>>> now-incompatible versions of jtharness and jtreg. >>>>>> >>>>>> I will make the jtreg code more robust. >>>>>> >>>>>> -- Jon >>>>>> >>>>>> >>>>>> >>>>>> On 6/9/17 8:01 AM, Mani Sarkar wrote: >>>>>>> >>>>>>> Hi Jon, >>>>>>> >>>>>>> Any suggestions on how to resolve the below, apologies if I have >>>>>>> missed >>>>>>> out >>>>>>> any communication with regards to the below. >>>>>>> >>>>>>> Thanks. >>>>>>> >>>>>>> Cheers, >>>>>>> Mani >>>>>>> >>>>>>> On Fri, 2 Jun 2017 at 17:04 Mani Sarkar wrote: >>>>>>> >>>>>>>> Hi all, >>>>>>>> >>>>>>>> Recently jtreg stopped building on our build farm, checking the logs >>>>>>>> we >>>>>>>> got (this version uses jdk9 as one of the jdks during the build >>>>>>>> process): >>>>>>>> >>>>>>>> -compile-jtreg.usage: >>>>>>>> [mkdir] Created dir: >>>>>>>> /scratch/jenkins/workspace/jtreg/build/jtreg >>>>>>>> [java] Executing >>>>>>>> '/opt/java/sdk/Oracle/x86_64/jdk1.8.0_102/jre/bin/java' with >>>>>>>> arguments: >>>>>>>> [java] '-Dprogram=jtreg' >>>>>>>> [java] '-classpath' >>>>>>>> [java] >>>>>>>> >>>>>>>> >>>>>>>> '/scratch/jenkins/workspace/jtreg/build/classes:/scratch/jenkins/workspace/jtreg/jtharness/lib/javatest.jar:/scratch/jenkins/workspace/jtreg/junit/junit.jar:/scratch/jenkins/workspace/jtreg/jh2.0/javahelp/lib/jh.jar' >>>>>>>> [java] 'com.sun.javatest.regtest.Main' >>>>>>>> [java] '-help' >>>>>>>> [java] 'all' >>>>>>>> [java] >>>>>>>> [java] The ' characters around the executable and arguments >>>>>>>> are >>>>>>>> [java] not part of the command. >>>>>>>> [java] Output redirected to >>>>>>>> /scratch/jenkins/workspace/jtreg/build/jtreg/usage.txt >>>>>>>> >>>>>>>> BUILD FAILED >>>>>>>> /scratch/jenkins/workspace/jtreg/make/build.xml:192: Java returned: >>>>>>>> 6 >>>>>>>> at >>>>>>>> org.apache.tools.ant.taskdefs.Java.execute(Java.java:111) >>>>>>>> at >>>>>>>> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292) >>>>>>>> at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown >>>>>>>> Source) >>>>>>>> at >>>>>>>> >>>>>>>> >>>>>>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >>>>>>>> at java.lang.reflect.Method.invoke(Method.java:498) >>>>>>>> at >>>>>>>> >>>>>>>> >>>>>>>> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) >>>>>>>> at org.apache.tools.ant.Task.perform(Task.java:348) >>>>>>>> at org.apache.tools.ant.Target.execute(Target.java:435) >>>>>>>> at >>>>>>>> org.apache.tools.ant.Target.performTasks(Target.java:456) >>>>>>>> at >>>>>>>> org.apache.tools.ant.Project.executeSortedTargets(Project.java:1393) >>>>>>>> at >>>>>>>> org.apache.tools.ant.Project.executeTarget(Project.java:1364) >>>>>>>> at >>>>>>>> >>>>>>>> >>>>>>>> org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) >>>>>>>> at >>>>>>>> org.apache.tools.ant.Project.executeTargets(Project.java:1248) >>>>>>>> at org.apache.tools.ant.Main.runBuild(Main.java:851) >>>>>>>> at org.apache.tools.ant.Main.startAnt(Main.java:235) >>>>>>>> at >>>>>>>> org.apache.tools.ant.launch.Launcher.run(Launcher.java:280) >>>>>>>> at >>>>>>>> org.apache.tools.ant.launch.Launcher.main(Launcher.java:109) >>>>>>>> >>>>>>>> >>>>>>>> Checking the usage.txt created in we see: >>>>>>>> >>>>>>>> >>>>>>>> Error: Unexpected exception occurred! java.lang.NullPointerException >>>>>>>> java.lang.NullPointerException >>>>>>>> at >>>>>>>> >>>>>>>> >>>>>>>> sun.reflect.UnsafeFieldAccessorImpl.ensureObj(UnsafeFieldAccessorImpl.java:57) >>>>>>>> at >>>>>>>> >>>>>>>> >>>>>>>> sun.reflect.UnsafeObjectFieldAccessorImpl.set(UnsafeObjectFieldAccessorImpl.java:75) >>>>>>>> at java.lang.reflect.Field.set(Field.java:764) >>>>>>>> at >>>>>>>> >>>>>>>> com.sun.javatest.regtest.tool.Help.showCommandLineHelp(Help.java:332) >>>>>>>> at com.sun.javatest.regtest.tool.Help.show(Help.java:168) >>>>>>>> at com.sun.javatest.regtest.tool.Tool.run(Tool.java:960) >>>>>>>> at com.sun.javatest.regtest.tool.Tool.run(Tool.java:953) >>>>>>>> at com.sun.javatest.regtest.tool.Tool.main(Tool.java:133) >>>>>>>> at com.sun.javatest.regtest.Main.main(Main.java:58) >>>>>>>> >>>>>>>> Logs can be found at >>>>>>>> https://adopt-openjdk.ci.cloudbees.com/job/jtreg/843/consoleFull >>>>>>>> >>>>>>>> >>>>>>>> Any ideas whats leading to it? >>>>>>>> >>>>>>>> >>>>>>>> Cheers, >>>>>>>> >>>>>>>> Mani >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> @theNeomatrix369 * | **Blog >>>>>>>> ** | *LJC Associate & LJC >>>>>>>> Advocate >>>>>>>> (@adoptopenjdk & @adoptajsr programs) >>>>>>>> *Meet-a-Project - *MutabilityDetector >>>>>>>> * | **Bitbucket >>>>>>>> * * | **Github >>>>>>>> * * | **LinkedIn >>>>>>>> * >>>>>>>> *Come to Devoxx UK 2017:* http://www.devoxx.co.uk/ >>>>>>>> >>>>>>>> *Don't chase success, rather aim for "Excellence", and success will >>>>>>>> come >>>>>>>> chasing after you!* >>>>>>>> > From jonathan.gibbons at oracle.com Wed Jun 21 17:03:05 2017 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 21 Jun 2017 17:03:05 +0000 Subject: hg: code-tools/jtreg: 7901994: jtreg needs to be updated for JT Harness 5.0 Message-ID: <201706211703.v5LH35eg027078@aojmv0008.oracle.com> Changeset: a9c1bf811261 Author: jjg Date: 2017-06-21 10:00 -0700 URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/a9c1bf811261 7901994: jtreg needs to be updated for JT Harness 5.0 Contributed-by: stuart.monteith at linaro.org ! src/share/classes/com/sun/javatest/regtest/tool/Help.java From jonathan.gibbons at oracle.com Wed Jun 21 17:25:39 2017 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 21 Jun 2017 10:25:39 -0700 Subject: Jtreg build is failing In-Reply-To: References: <2eabe5f4-cf0d-5eb0-2b32-1246e52a9cf5@oracle.com> <3297199d-49c9-c281-7b3a-23dd6b81e2ec@oracle.com> <594A9EFF.5030007@oracle.com> Message-ID: <594AAC13.1070808@oracle.com> Stuart, I've not dug all the way down to the root cause of your issue, but I can confirm that the primary significant different between your test results in the Basic.othervm tests and the test results I have locally (which pass) is related to the JCommander library. The following lines at the end of Basic.othervm/report/text/summary.txt seem to be the appropriate ones to look at: testng/group/p/q/ExtraComment.java Failed. Execution failed: `main' threw exception: java.lang.NoClassDefFoundError: com/beust/jcommander/ParameterException testng/group/p/q/ExtraComment.java#1 Error. Multiple test descriptions not allowed testng/group/p/q/Fail.java Failed. Execution failed: `main' threw exception: java.lang.NoClassDefFoundError: com/beust/jcommander/ParameterException testng/group/p/q/Pass.java Failed. Execution failed: `main' threw exception: java.lang.NoClassDefFoundError: com/beust/jcommander/ParameterException testng/singles/Fail.java Failed. Execution failed: `main' threw exception: java.lang.NoClassDefFoundError: com/beust/jcommander/ParameterException testng/singles/Pass.java Failed. Execution failed: `main' threw exception: java.lang.NoClassDefFoundError: com/beust/jcommander/ParameterException You can ignore the second line ... that is intentional ... the Basic* tests have many intentional errors, as part of testing jtreg's ability to correctly detect errors. But the messages about not finding ParameterException are significant. -- Jon On 06/21/2017 10:00 AM, Stuart Monteith wrote: > The versions are (the ones I'm using, then the recommended versions > from the README, then from the website): > asmtools-6.0 - ? - 6.0 or better > jtharness-5.0 - 4.1.3 - jtharness 4.6 or better > junit-4.8.2 - junit 4 - JUnit 4.1.0 > testng-6.9.5 - ? - 6.9.5 > jcommander-1.48 - ? - ? > javahelp-2.0.05 - 2.0_01 - e.g. javahelp2.0_05.zip > > There are some disparities. I've not investigated much to see why they > are failing. > > I've put the build files here: > > http://people.linaro.org/~stuart.monteith/jtreg-build/Basic.othervm/report/ > you can look around from here: > http://people.linaro.org/~stuart.monteith/jtreg-build/ > > Thanks, > Stuart > > On 21 June 2017 at 17:29, Jonathan Gibbons wrote: >> Stuart, >> >> Your fix for the HelpTree problem looks like the fix I would anticipate. >> I'll try it out locally and run the tests. >> >> You don't give enough info for me to diagnose why the tests are not >> running for you. Are you using the recommended version of other libraries, >> and not necessarily the latest version? (i.e. the version we recommend for >> use with jtreg) >> >> Some other folk are looking at making the overall jtreg build easier to >> configure. >> That work is ongoing. >> >> -- Jon >> >> >> On 06/21/2017 09:11 AM, Stuart Monteith wrote: >>> Ok, I'm not seeing any better test results with the old jtharness.jar >>> version. >>> >>> Also, "f.set(commandHelpTree, new NodeComparator()) " should be >>> backwards compatible with the static field in the old version of >>> jtharness, as "commandHelpTree" will just be ignored. >>> >>> BR, >>> Stuart >>> >>> On 21 June 2017 at 16:48, Stuart Monteith >>> wrote: >>>> The immediate problem is solved with the patch below (with no regards >>>> to backwards compatibility). >>>> >>>> I'm note getting clean test runs though. I see: >>>> >>>> TRT.finished(), attempting cache compress...TRT.finished(), requesting >>>> cache flush...Test results: passed: 89; failed: 47; error: 87 >>>> Report written to >>>> >>>> /home/stumon01/jtreg-local/jtreg/build/Basic.othervm/report/html/report.html >>>> Results written to >>>> /home/stumon01/jtreg-local/jtreg/build/Basic.othervm/work >>>> Error: Some tests failed or other problems occurred. >>>> ok...batch execution >>>> checking selection according to previous state >>>> state: 0 (passed) >>>> expected number of tests: 92 >>>> found: 89 >>>> wrong number of tests found >>>> java.lang.Error: wrong number of tests found >>>> at Basic.failed(Basic.java:346) >>>> at Basic.checkPreviousStateSelection(Basic.java:272) >>>> at Basic.(Basic.java:115) >>>> at Basic.main(Basic.java:50) >>>> ../test/basic/Basic.gmk:78: recipe for target '../build/Basic.othervm.ok' >>>> failed >>>> make: *** [../build/Basic.othervm.ok] Error 1 >>>> make: Leaving directory '/home/stumon01/jtreg-local/jtreg/make' >>>> >>>> >>>> I've not compared this against running with jtharness-4.6.jar. >>>> >>>> I don't suppose you're looking additional issues? >>>> >>>> BR, >>>> Stuart >>>> >>>> >>>> # HG changeset patch >>>> # User smonteith >>>> # Date 1498059859 -3600 >>>> # Wed Jun 21 16:44:19 2017 +0100 >>>> # Node ID 75cda45229ca989faf3e8ba83f45ccb951b1bb8f >>>> # Parent 33d0a6d64b82f5ca23b7b1eaadf74317b2204ecf >>>> Fix HelpTree field access >>>> >>>> diff -r 33d0a6d64b82 -r 75cda45229ca >>>> src/share/classes/com/sun/javatest/regtest/tool/Help.java >>>> --- a/src/share/classes/com/sun/javatest/regtest/tool/Help.java Mon >>>> Jun 12 14:35:46 2017 -0700 >>>> +++ b/src/share/classes/com/sun/javatest/regtest/tool/Help.java Wed >>>> Jun 21 16:44:19 2017 +0100 >>>> @@ -329,7 +329,7 @@ >>>> try{ >>>> Field f = >>>> HelpTree.class.getDeclaredField("nodeComparator"); >>>> f.setAccessible(true); >>>> - f.set(null, new NodeComparator()); >>>> + f.set(commandHelpTree, new NodeComparator()); >>>> } catch (IllegalAccessException | IllegalArgumentException | >>>> NoSuchFieldException | SecurityException ignore) { >>>> } >>>> >>>> On 21 June 2017 at 16:30, Jonathan Gibbons >>>> wrote: >>>>> Yes, jtreg has not yet been updated to be compatible with JTHarness 5.0. >>>>> >>>>> -- Jon >>>>> >>>>> >>>>> >>>>> On 6/21/17 8:15 AM, Stuart Monteith wrote: >>>>>> Hi, >>>>>> I just noticed I have hit this problem. >>>>>> >>>>>> HelpTree in jtharness-5.0.jar has this: >>>>>> private java.util.Comparator nodeComparator; >>>>>> Whereas in jtharness-4.6.jar it has: >>>>>> private static java.util.Comparator nodeComparator; >>>>>> >>>>>> i.e. the nodeComparator field is no longer a static field. >>>>>> >>>>>> This happened since adopt-openjdk started building with this: >>>>>> >>>>>> >>>>>> https://adopt-openjdk.ci.cloudbees.com/job/jtharness/lastSuccessfulBuild/artifact/jtharness-5.0.tar.gz >>>>>> >>>>>> BR, >>>>>> Stuart >>>>>> >>>>>> >>>>>> On 9 June 2017 at 20:23, Jonathan Gibbons >>>>>> wrote: >>>>>>> From a brief examination of the stacktrace, it looks like you have >>>>>>> now-incompatible versions of jtharness and jtreg. >>>>>>> >>>>>>> I will make the jtreg code more robust. >>>>>>> >>>>>>> -- Jon >>>>>>> >>>>>>> >>>>>>> >>>>>>> On 6/9/17 8:01 AM, Mani Sarkar wrote: >>>>>>>> Hi Jon, >>>>>>>> >>>>>>>> Any suggestions on how to resolve the below, apologies if I have >>>>>>>> missed >>>>>>>> out >>>>>>>> any communication with regards to the below. >>>>>>>> >>>>>>>> Thanks. >>>>>>>> >>>>>>>> Cheers, >>>>>>>> Mani >>>>>>>> >>>>>>>> On Fri, 2 Jun 2017 at 17:04 Mani Sarkar wrote: >>>>>>>> >>>>>>>>> Hi all, >>>>>>>>> >>>>>>>>> Recently jtreg stopped building on our build farm, checking the logs >>>>>>>>> we >>>>>>>>> got (this version uses jdk9 as one of the jdks during the build >>>>>>>>> process): >>>>>>>>> >>>>>>>>> -compile-jtreg.usage: >>>>>>>>> [mkdir] Created dir: >>>>>>>>> /scratch/jenkins/workspace/jtreg/build/jtreg >>>>>>>>> [java] Executing >>>>>>>>> '/opt/java/sdk/Oracle/x86_64/jdk1.8.0_102/jre/bin/java' with >>>>>>>>> arguments: >>>>>>>>> [java] '-Dprogram=jtreg' >>>>>>>>> [java] '-classpath' >>>>>>>>> [java] >>>>>>>>> >>>>>>>>> >>>>>>>>> '/scratch/jenkins/workspace/jtreg/build/classes:/scratch/jenkins/workspace/jtreg/jtharness/lib/javatest.jar:/scratch/jenkins/workspace/jtreg/junit/junit.jar:/scratch/jenkins/workspace/jtreg/jh2.0/javahelp/lib/jh.jar' >>>>>>>>> [java] 'com.sun.javatest.regtest.Main' >>>>>>>>> [java] '-help' >>>>>>>>> [java] 'all' >>>>>>>>> [java] >>>>>>>>> [java] The ' characters around the executable and arguments >>>>>>>>> are >>>>>>>>> [java] not part of the command. >>>>>>>>> [java] Output redirected to >>>>>>>>> /scratch/jenkins/workspace/jtreg/build/jtreg/usage.txt >>>>>>>>> >>>>>>>>> BUILD FAILED >>>>>>>>> /scratch/jenkins/workspace/jtreg/make/build.xml:192: Java returned: >>>>>>>>> 6 >>>>>>>>> at >>>>>>>>> org.apache.tools.ant.taskdefs.Java.execute(Java.java:111) >>>>>>>>> at >>>>>>>>> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292) >>>>>>>>> at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown >>>>>>>>> Source) >>>>>>>>> at >>>>>>>>> >>>>>>>>> >>>>>>>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >>>>>>>>> at java.lang.reflect.Method.invoke(Method.java:498) >>>>>>>>> at >>>>>>>>> >>>>>>>>> >>>>>>>>> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) >>>>>>>>> at org.apache.tools.ant.Task.perform(Task.java:348) >>>>>>>>> at org.apache.tools.ant.Target.execute(Target.java:435) >>>>>>>>> at >>>>>>>>> org.apache.tools.ant.Target.performTasks(Target.java:456) >>>>>>>>> at >>>>>>>>> org.apache.tools.ant.Project.executeSortedTargets(Project.java:1393) >>>>>>>>> at >>>>>>>>> org.apache.tools.ant.Project.executeTarget(Project.java:1364) >>>>>>>>> at >>>>>>>>> >>>>>>>>> >>>>>>>>> org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) >>>>>>>>> at >>>>>>>>> org.apache.tools.ant.Project.executeTargets(Project.java:1248) >>>>>>>>> at org.apache.tools.ant.Main.runBuild(Main.java:851) >>>>>>>>> at org.apache.tools.ant.Main.startAnt(Main.java:235) >>>>>>>>> at >>>>>>>>> org.apache.tools.ant.launch.Launcher.run(Launcher.java:280) >>>>>>>>> at >>>>>>>>> org.apache.tools.ant.launch.Launcher.main(Launcher.java:109) >>>>>>>>> >>>>>>>>> >>>>>>>>> Checking the usage.txt created in we see: >>>>>>>>> >>>>>>>>> >>>>>>>>> Error: Unexpected exception occurred! java.lang.NullPointerException >>>>>>>>> java.lang.NullPointerException >>>>>>>>> at >>>>>>>>> >>>>>>>>> >>>>>>>>> sun.reflect.UnsafeFieldAccessorImpl.ensureObj(UnsafeFieldAccessorImpl.java:57) >>>>>>>>> at >>>>>>>>> >>>>>>>>> >>>>>>>>> sun.reflect.UnsafeObjectFieldAccessorImpl.set(UnsafeObjectFieldAccessorImpl.java:75) >>>>>>>>> at java.lang.reflect.Field.set(Field.java:764) >>>>>>>>> at >>>>>>>>> >>>>>>>>> com.sun.javatest.regtest.tool.Help.showCommandLineHelp(Help.java:332) >>>>>>>>> at com.sun.javatest.regtest.tool.Help.show(Help.java:168) >>>>>>>>> at com.sun.javatest.regtest.tool.Tool.run(Tool.java:960) >>>>>>>>> at com.sun.javatest.regtest.tool.Tool.run(Tool.java:953) >>>>>>>>> at com.sun.javatest.regtest.tool.Tool.main(Tool.java:133) >>>>>>>>> at com.sun.javatest.regtest.Main.main(Main.java:58) >>>>>>>>> >>>>>>>>> Logs can be found at >>>>>>>>> https://adopt-openjdk.ci.cloudbees.com/job/jtreg/843/consoleFull >>>>>>>>> >>>>>>>>> >>>>>>>>> Any ideas whats leading to it? >>>>>>>>> >>>>>>>>> >>>>>>>>> Cheers, >>>>>>>>> >>>>>>>>> Mani >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> @theNeomatrix369 * | **Blog >>>>>>>>> ** | *LJC Associate & LJC >>>>>>>>> Advocate >>>>>>>>> (@adoptopenjdk & @adoptajsr programs) >>>>>>>>> *Meet-a-Project - *MutabilityDetector >>>>>>>>> * | **Bitbucket >>>>>>>>> * * | **Github >>>>>>>>> * * | **LinkedIn >>>>>>>>> * >>>>>>>>> *Come to Devoxx UK 2017:* http://www.devoxx.co.uk/ >>>>>>>>> >>>>>>>>> *Don't chase success, rather aim for "Excellence", and success will >>>>>>>>> come >>>>>>>>> chasing after you!* >>>>>>>>> From jonathan.gibbons at oracle.com Wed Jun 21 21:36:36 2017 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 21 Jun 2017 21:36:36 +0000 Subject: hg: code-tools/jtreg: 7901995: Allow BUILDDIR to be specified Message-ID: <201706212136.v5LLaa5Z028016@aojmv0008.oracle.com> Changeset: ccd2976912a9 Author: jjg Date: 2017-06-21 14:34 -0700 URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/ccd2976912a9 7901995: Allow BUILDDIR to be specified Portions contributed by: erik.helin at oracle.com ! make/Defs.gmk ! make/Makefile ! make/jtreg.gmk ! test/6533043/T6533043.gmk ! test/6533074/T6533074.gmk ! test/6533136/T6533136.gmk ! test/7113596/T7113596.gmk ! test/autovm/AutoVMTests.gmk ! test/basic/Basic.gmk ! test/compilejdk/CompileTests.gmk ! test/env/EnvTest.gmk ! test/rerun/RerunTest.gmk ! test/rerun/std/AppletTest.agentvm.out ! test/rerun/std/AppletTest.othervm.out ! test/rerun/std/BuildTest.agentvm.out ! test/rerun/std/BuildTest.othervm.out ! test/rerun/std/CleanTest.agentvm.out ! test/rerun/std/CleanTest.othervm.out ! test/rerun/std/CompileTest.agentvm.out ! test/rerun/std/CompileTest.othervm.out ! test/rerun/std/JUnitTest.agentvm.out ! test/rerun/std/JUnitTest.othervm.out ! test/rerun/std/MainTest.agentvm.out ! test/rerun/std/MainTest.othervm.out ! test/rerun/std/ShellTest.agentvm.out ! test/rerun/std/ShellTest.othervm.out ! test/rerun/std/TestNGTest.agentvm.out ! test/rerun/std/TestNGTest.othervm.out ! test/rerun/testng/TestNGTest.agentvm.out ! test/rerun/testng/TestNGTest.othervm.out ! test/rerun2/RerunTest2.gmk ! test/vmopts/TestVMOpts.gmk From stuart.monteith at linaro.org Thu Jun 22 13:46:49 2017 From: stuart.monteith at linaro.org (Stuart Monteith) Date: Thu, 22 Jun 2017 14:46:49 +0100 Subject: Jtreg build is failing In-Reply-To: <594AAC13.1070808@oracle.com> References: <2eabe5f4-cf0d-5eb0-2b32-1246e52a9cf5@oracle.com> <3297199d-49c9-c281-7b3a-23dd6b81e2ec@oracle.com> <594A9EFF.5030007@oracle.com> <594AAC13.1070808@oracle.com> Message-ID: Thanks Jonathan, I had misplaced jcommander between the build and the test. There are some issues setting up the environment, so far I have to do the following: export LANG=en_US.UTF-8 unset TZ export J2SEHOME=$JDK17HOME export JDK18HOME=$JDK17HOME export JDK16HOME=$JDK18HOME But I think we're mostly good now. BR, Stuart On 21 June 2017 at 18:25, Jonathan Gibbons wrote: > Stuart, > > I've not dug all the way down to the root cause of your issue, but I can > confirm that the primary significant different between your test results in > the Basic.othervm tests and the test results I have locally (which pass) is > related to the JCommander library. > > The following lines at the end of Basic.othervm/report/text/summary.txt seem > to be the appropriate ones to look at: > > testng/group/p/q/ExtraComment.java Failed. Execution failed: `main' threw > exception: java.lang.NoClassDefFoundError: > com/beust/jcommander/ParameterException > testng/group/p/q/ExtraComment.java#1 Error. Multiple test descriptions not > allowed > testng/group/p/q/Fail.java Failed. Execution failed: `main' threw > exception: java.lang.NoClassDefFoundError: > com/beust/jcommander/ParameterException > testng/group/p/q/Pass.java Failed. Execution failed: `main' threw > exception: java.lang.NoClassDefFoundError: > com/beust/jcommander/ParameterException > testng/singles/Fail.java Failed. Execution failed: `main' threw > exception: java.lang.NoClassDefFoundError: > com/beust/jcommander/ParameterException > testng/singles/Pass.java Failed. Execution failed: `main' threw > exception: java.lang.NoClassDefFoundError: > com/beust/jcommander/ParameterException > > You can ignore the second line ... that is intentional ... the Basic* tests > have many intentional errors, as part of testing jtreg's ability to > correctly detect errors. But the messages about not finding > ParameterException are significant. > > -- Jon > > > > On 06/21/2017 10:00 AM, Stuart Monteith wrote: >> >> The versions are (the ones I'm using, then the recommended versions >> from the README, then from the website): >> asmtools-6.0 - ? - 6.0 or better >> jtharness-5.0 - 4.1.3 - jtharness 4.6 or better >> junit-4.8.2 - junit 4 - JUnit 4.1.0 >> testng-6.9.5 - ? - 6.9.5 >> jcommander-1.48 - ? - ? >> javahelp-2.0.05 - 2.0_01 - e.g. javahelp2.0_05.zip >> >> There are some disparities. I've not investigated much to see why they >> are failing. >> >> I've put the build files here: >> >> >> http://people.linaro.org/~stuart.monteith/jtreg-build/Basic.othervm/report/ >> you can look around from here: >> http://people.linaro.org/~stuart.monteith/jtreg-build/ >> >> Thanks, >> Stuart >> >> On 21 June 2017 at 17:29, Jonathan Gibbons >> wrote: >>> >>> Stuart, >>> >>> Your fix for the HelpTree problem looks like the fix I would anticipate. >>> I'll try it out locally and run the tests. >>> >>> You don't give enough info for me to diagnose why the tests are not >>> running for you. Are you using the recommended version of other >>> libraries, >>> and not necessarily the latest version? (i.e. the version we recommend >>> for >>> use with jtreg) >>> >>> Some other folk are looking at making the overall jtreg build easier to >>> configure. >>> That work is ongoing. >>> >>> -- Jon >>> >>> >>> On 06/21/2017 09:11 AM, Stuart Monteith wrote: >>>> >>>> Ok, I'm not seeing any better test results with the old jtharness.jar >>>> version. >>>> >>>> Also, "f.set(commandHelpTree, new NodeComparator()) " should be >>>> backwards compatible with the static field in the old version of >>>> jtharness, as "commandHelpTree" will just be ignored. >>>> >>>> BR, >>>> Stuart >>>> >>>> On 21 June 2017 at 16:48, Stuart Monteith >>>> wrote: >>>>> >>>>> The immediate problem is solved with the patch below (with no regards >>>>> to backwards compatibility). >>>>> >>>>> I'm note getting clean test runs though. I see: >>>>> >>>>> TRT.finished(), attempting cache compress...TRT.finished(), requesting >>>>> cache flush...Test results: passed: 89; failed: 47; error: 87 >>>>> Report written to >>>>> >>>>> >>>>> /home/stumon01/jtreg-local/jtreg/build/Basic.othervm/report/html/report.html >>>>> Results written to >>>>> /home/stumon01/jtreg-local/jtreg/build/Basic.othervm/work >>>>> Error: Some tests failed or other problems occurred. >>>>> ok...batch execution >>>>> checking selection according to previous state >>>>> state: 0 (passed) >>>>> expected number of tests: 92 >>>>> found: 89 >>>>> wrong number of tests found >>>>> java.lang.Error: wrong number of tests found >>>>> at Basic.failed(Basic.java:346) >>>>> at Basic.checkPreviousStateSelection(Basic.java:272) >>>>> at Basic.(Basic.java:115) >>>>> at Basic.main(Basic.java:50) >>>>> ../test/basic/Basic.gmk:78: recipe for target >>>>> '../build/Basic.othervm.ok' >>>>> failed >>>>> make: *** [../build/Basic.othervm.ok] Error 1 >>>>> make: Leaving directory '/home/stumon01/jtreg-local/jtreg/make' >>>>> >>>>> >>>>> I've not compared this against running with jtharness-4.6.jar. >>>>> >>>>> I don't suppose you're looking additional issues? >>>>> >>>>> BR, >>>>> Stuart >>>>> >>>>> >>>>> # HG changeset patch >>>>> # User smonteith >>>>> # Date 1498059859 -3600 >>>>> # Wed Jun 21 16:44:19 2017 +0100 >>>>> # Node ID 75cda45229ca989faf3e8ba83f45ccb951b1bb8f >>>>> # Parent 33d0a6d64b82f5ca23b7b1eaadf74317b2204ecf >>>>> Fix HelpTree field access >>>>> >>>>> diff -r 33d0a6d64b82 -r 75cda45229ca >>>>> src/share/classes/com/sun/javatest/regtest/tool/Help.java >>>>> --- a/src/share/classes/com/sun/javatest/regtest/tool/Help.java Mon >>>>> Jun 12 14:35:46 2017 -0700 >>>>> +++ b/src/share/classes/com/sun/javatest/regtest/tool/Help.java Wed >>>>> Jun 21 16:44:19 2017 +0100 >>>>> @@ -329,7 +329,7 @@ >>>>> try{ >>>>> Field f = >>>>> HelpTree.class.getDeclaredField("nodeComparator"); >>>>> f.setAccessible(true); >>>>> - f.set(null, new NodeComparator()); >>>>> + f.set(commandHelpTree, new NodeComparator()); >>>>> } catch (IllegalAccessException | IllegalArgumentException | >>>>> NoSuchFieldException | SecurityException ignore) { >>>>> } >>>>> >>>>> On 21 June 2017 at 16:30, Jonathan Gibbons >>>>> >>>>> wrote: >>>>>> >>>>>> Yes, jtreg has not yet been updated to be compatible with JTHarness >>>>>> 5.0. >>>>>> >>>>>> -- Jon >>>>>> >>>>>> >>>>>> >>>>>> On 6/21/17 8:15 AM, Stuart Monteith wrote: >>>>>>> >>>>>>> Hi, >>>>>>> I just noticed I have hit this problem. >>>>>>> >>>>>>> HelpTree in jtharness-5.0.jar has this: >>>>>>> private java.util.Comparator nodeComparator; >>>>>>> Whereas in jtharness-4.6.jar it has: >>>>>>> private static java.util.Comparator nodeComparator; >>>>>>> >>>>>>> i.e. the nodeComparator field is no longer a static field. >>>>>>> >>>>>>> This happened since adopt-openjdk started building with this: >>>>>>> >>>>>>> >>>>>>> >>>>>>> https://adopt-openjdk.ci.cloudbees.com/job/jtharness/lastSuccessfulBuild/artifact/jtharness-5.0.tar.gz >>>>>>> >>>>>>> BR, >>>>>>> Stuart >>>>>>> >>>>>>> >>>>>>> On 9 June 2017 at 20:23, Jonathan Gibbons >>>>>>> >>>>>>> wrote: >>>>>>>> >>>>>>>> From a brief examination of the stacktrace, it looks like you >>>>>>>> have >>>>>>>> now-incompatible versions of jtharness and jtreg. >>>>>>>> >>>>>>>> I will make the jtreg code more robust. >>>>>>>> >>>>>>>> -- Jon >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On 6/9/17 8:01 AM, Mani Sarkar wrote: >>>>>>>>> >>>>>>>>> Hi Jon, >>>>>>>>> >>>>>>>>> Any suggestions on how to resolve the below, apologies if I have >>>>>>>>> missed >>>>>>>>> out >>>>>>>>> any communication with regards to the below. >>>>>>>>> >>>>>>>>> Thanks. >>>>>>>>> >>>>>>>>> Cheers, >>>>>>>>> Mani >>>>>>>>> >>>>>>>>> On Fri, 2 Jun 2017 at 17:04 Mani Sarkar >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Hi all, >>>>>>>>>> >>>>>>>>>> Recently jtreg stopped building on our build farm, checking the >>>>>>>>>> logs >>>>>>>>>> we >>>>>>>>>> got (this version uses jdk9 as one of the jdks during the build >>>>>>>>>> process): >>>>>>>>>> >>>>>>>>>> -compile-jtreg.usage: >>>>>>>>>> [mkdir] Created dir: >>>>>>>>>> /scratch/jenkins/workspace/jtreg/build/jtreg >>>>>>>>>> [java] Executing >>>>>>>>>> '/opt/java/sdk/Oracle/x86_64/jdk1.8.0_102/jre/bin/java' with >>>>>>>>>> arguments: >>>>>>>>>> [java] '-Dprogram=jtreg' >>>>>>>>>> [java] '-classpath' >>>>>>>>>> [java] >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> '/scratch/jenkins/workspace/jtreg/build/classes:/scratch/jenkins/workspace/jtreg/jtharness/lib/javatest.jar:/scratch/jenkins/workspace/jtreg/junit/junit.jar:/scratch/jenkins/workspace/jtreg/jh2.0/javahelp/lib/jh.jar' >>>>>>>>>> [java] 'com.sun.javatest.regtest.Main' >>>>>>>>>> [java] '-help' >>>>>>>>>> [java] 'all' >>>>>>>>>> [java] >>>>>>>>>> [java] The ' characters around the executable and >>>>>>>>>> arguments >>>>>>>>>> are >>>>>>>>>> [java] not part of the command. >>>>>>>>>> [java] Output redirected to >>>>>>>>>> /scratch/jenkins/workspace/jtreg/build/jtreg/usage.txt >>>>>>>>>> >>>>>>>>>> BUILD FAILED >>>>>>>>>> /scratch/jenkins/workspace/jtreg/make/build.xml:192: Java >>>>>>>>>> returned: >>>>>>>>>> 6 >>>>>>>>>> at >>>>>>>>>> org.apache.tools.ant.taskdefs.Java.execute(Java.java:111) >>>>>>>>>> at >>>>>>>>>> >>>>>>>>>> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292) >>>>>>>>>> at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown >>>>>>>>>> Source) >>>>>>>>>> at >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >>>>>>>>>> at java.lang.reflect.Method.invoke(Method.java:498) >>>>>>>>>> at >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) >>>>>>>>>> at org.apache.tools.ant.Task.perform(Task.java:348) >>>>>>>>>> at org.apache.tools.ant.Target.execute(Target.java:435) >>>>>>>>>> at >>>>>>>>>> org.apache.tools.ant.Target.performTasks(Target.java:456) >>>>>>>>>> at >>>>>>>>>> >>>>>>>>>> org.apache.tools.ant.Project.executeSortedTargets(Project.java:1393) >>>>>>>>>> at >>>>>>>>>> org.apache.tools.ant.Project.executeTarget(Project.java:1364) >>>>>>>>>> at >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) >>>>>>>>>> at >>>>>>>>>> org.apache.tools.ant.Project.executeTargets(Project.java:1248) >>>>>>>>>> at org.apache.tools.ant.Main.runBuild(Main.java:851) >>>>>>>>>> at org.apache.tools.ant.Main.startAnt(Main.java:235) >>>>>>>>>> at >>>>>>>>>> org.apache.tools.ant.launch.Launcher.run(Launcher.java:280) >>>>>>>>>> at >>>>>>>>>> org.apache.tools.ant.launch.Launcher.main(Launcher.java:109) >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Checking the usage.txt created in we see: >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Error: Unexpected exception occurred! >>>>>>>>>> java.lang.NullPointerException >>>>>>>>>> java.lang.NullPointerException >>>>>>>>>> at >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> sun.reflect.UnsafeFieldAccessorImpl.ensureObj(UnsafeFieldAccessorImpl.java:57) >>>>>>>>>> at >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> sun.reflect.UnsafeObjectFieldAccessorImpl.set(UnsafeObjectFieldAccessorImpl.java:75) >>>>>>>>>> at java.lang.reflect.Field.set(Field.java:764) >>>>>>>>>> at >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> com.sun.javatest.regtest.tool.Help.showCommandLineHelp(Help.java:332) >>>>>>>>>> at >>>>>>>>>> com.sun.javatest.regtest.tool.Help.show(Help.java:168) >>>>>>>>>> at >>>>>>>>>> com.sun.javatest.regtest.tool.Tool.run(Tool.java:960) >>>>>>>>>> at >>>>>>>>>> com.sun.javatest.regtest.tool.Tool.run(Tool.java:953) >>>>>>>>>> at >>>>>>>>>> com.sun.javatest.regtest.tool.Tool.main(Tool.java:133) >>>>>>>>>> at com.sun.javatest.regtest.Main.main(Main.java:58) >>>>>>>>>> >>>>>>>>>> Logs can be found at >>>>>>>>>> https://adopt-openjdk.ci.cloudbees.com/job/jtreg/843/consoleFull >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Any ideas whats leading to it? >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Cheers, >>>>>>>>>> >>>>>>>>>> Mani >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> @theNeomatrix369 * | **Blog >>>>>>>>>> ** | *LJC Associate & LJC >>>>>>>>>> Advocate >>>>>>>>>> (@adoptopenjdk & @adoptajsr programs) >>>>>>>>>> *Meet-a-Project - *MutabilityDetector >>>>>>>>>> * | **Bitbucket >>>>>>>>>> * * | **Github >>>>>>>>>> * * | **LinkedIn >>>>>>>>>> * >>>>>>>>>> *Come to Devoxx UK 2017:* http://www.devoxx.co.uk/ >>>>>>>>>> >>>>>>>>>> *Don't chase success, rather aim for "Excellence", and success >>>>>>>>>> will >>>>>>>>>> come >>>>>>>>>> chasing after you!* >>>>>>>>>> > From jonathan.gibbons at oracle.com Thu Jun 22 14:35:38 2017 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 22 Jun 2017 07:35:38 -0700 Subject: Jtreg build is failing In-Reply-To: References: <2eabe5f4-cf0d-5eb0-2b32-1246e52a9cf5@oracle.com> <3297199d-49c9-c281-7b3a-23dd6b81e2ec@oracle.com> <594A9EFF.5030007@oracle.com> <594AAC13.1070808@oracle.com> Message-ID: <48f2df99-a77d-954a-283a-0c2c5c6e2538@oracle.com> Thanks for the followup. Do you know why you had to unset TZ? You should not need the settings for older JDKs unless you are running the tests, and there are some tests that may require the JDKs to be distinct, so you may get test failures if you set the locations for older JDKs to unexpected values. -- Jon On 6/22/17 6:46 AM, Stuart Monteith wrote: > Thanks Jonathan, > I had misplaced jcommander between the build and the test. > > There are some issues setting up the environment, so far I have to do > the following: > > export LANG=en_US.UTF-8 > unset TZ > export J2SEHOME=$JDK17HOME > export JDK18HOME=$JDK17HOME > export JDK16HOME=$JDK18HOME > > But I think we're mostly good now. > > BR, > Stuart > > On 21 June 2017 at 18:25, Jonathan Gibbons wrote: >> Stuart, >> >> I've not dug all the way down to the root cause of your issue, but I can >> confirm that the primary significant different between your test results in >> the Basic.othervm tests and the test results I have locally (which pass) is >> related to the JCommander library. >> >> The following lines at the end of Basic.othervm/report/text/summary.txt seem >> to be the appropriate ones to look at: >> >> testng/group/p/q/ExtraComment.java Failed. Execution failed: `main' threw >> exception: java.lang.NoClassDefFoundError: >> com/beust/jcommander/ParameterException >> testng/group/p/q/ExtraComment.java#1 Error. Multiple test descriptions not >> allowed >> testng/group/p/q/Fail.java Failed. Execution failed: `main' threw >> exception: java.lang.NoClassDefFoundError: >> com/beust/jcommander/ParameterException >> testng/group/p/q/Pass.java Failed. Execution failed: `main' threw >> exception: java.lang.NoClassDefFoundError: >> com/beust/jcommander/ParameterException >> testng/singles/Fail.java Failed. Execution failed: `main' threw >> exception: java.lang.NoClassDefFoundError: >> com/beust/jcommander/ParameterException >> testng/singles/Pass.java Failed. Execution failed: `main' threw >> exception: java.lang.NoClassDefFoundError: >> com/beust/jcommander/ParameterException >> >> You can ignore the second line ... that is intentional ... the Basic* tests >> have many intentional errors, as part of testing jtreg's ability to >> correctly detect errors. But the messages about not finding >> ParameterException are significant. >> >> -- Jon >> >> >> >> On 06/21/2017 10:00 AM, Stuart Monteith wrote: >>> The versions are (the ones I'm using, then the recommended versions >>> from the README, then from the website): >>> asmtools-6.0 - ? - 6.0 or better >>> jtharness-5.0 - 4.1.3 - jtharness 4.6 or better >>> junit-4.8.2 - junit 4 - JUnit 4.1.0 >>> testng-6.9.5 - ? - 6.9.5 >>> jcommander-1.48 - ? - ? >>> javahelp-2.0.05 - 2.0_01 - e.g. javahelp2.0_05.zip >>> >>> There are some disparities. I've not investigated much to see why they >>> are failing. >>> >>> I've put the build files here: >>> >>> >>> http://people.linaro.org/~stuart.monteith/jtreg-build/Basic.othervm/report/ >>> you can look around from here: >>> http://people.linaro.org/~stuart.monteith/jtreg-build/ >>> >>> Thanks, >>> Stuart >>> >>> On 21 June 2017 at 17:29, Jonathan Gibbons >>> wrote: >>>> Stuart, >>>> >>>> Your fix for the HelpTree problem looks like the fix I would anticipate. >>>> I'll try it out locally and run the tests. >>>> >>>> You don't give enough info for me to diagnose why the tests are not >>>> running for you. Are you using the recommended version of other >>>> libraries, >>>> and not necessarily the latest version? (i.e. the version we recommend >>>> for >>>> use with jtreg) >>>> >>>> Some other folk are looking at making the overall jtreg build easier to >>>> configure. >>>> That work is ongoing. >>>> >>>> -- Jon >>>> >>>> >>>> On 06/21/2017 09:11 AM, Stuart Monteith wrote: >>>>> Ok, I'm not seeing any better test results with the old jtharness.jar >>>>> version. >>>>> >>>>> Also, "f.set(commandHelpTree, new NodeComparator()) " should be >>>>> backwards compatible with the static field in the old version of >>>>> jtharness, as "commandHelpTree" will just be ignored. >>>>> >>>>> BR, >>>>> Stuart >>>>> >>>>> On 21 June 2017 at 16:48, Stuart Monteith >>>>> wrote: >>>>>> The immediate problem is solved with the patch below (with no regards >>>>>> to backwards compatibility). >>>>>> >>>>>> I'm note getting clean test runs though. I see: >>>>>> >>>>>> TRT.finished(), attempting cache compress...TRT.finished(), requesting >>>>>> cache flush...Test results: passed: 89; failed: 47; error: 87 >>>>>> Report written to >>>>>> >>>>>> >>>>>> /home/stumon01/jtreg-local/jtreg/build/Basic.othervm/report/html/report.html >>>>>> Results written to >>>>>> /home/stumon01/jtreg-local/jtreg/build/Basic.othervm/work >>>>>> Error: Some tests failed or other problems occurred. >>>>>> ok...batch execution >>>>>> checking selection according to previous state >>>>>> state: 0 (passed) >>>>>> expected number of tests: 92 >>>>>> found: 89 >>>>>> wrong number of tests found >>>>>> java.lang.Error: wrong number of tests found >>>>>> at Basic.failed(Basic.java:346) >>>>>> at Basic.checkPreviousStateSelection(Basic.java:272) >>>>>> at Basic.(Basic.java:115) >>>>>> at Basic.main(Basic.java:50) >>>>>> ../test/basic/Basic.gmk:78: recipe for target >>>>>> '../build/Basic.othervm.ok' >>>>>> failed >>>>>> make: *** [../build/Basic.othervm.ok] Error 1 >>>>>> make: Leaving directory '/home/stumon01/jtreg-local/jtreg/make' >>>>>> >>>>>> >>>>>> I've not compared this against running with jtharness-4.6.jar. >>>>>> >>>>>> I don't suppose you're looking additional issues? >>>>>> >>>>>> BR, >>>>>> Stuart >>>>>> >>>>>> >>>>>> # HG changeset patch >>>>>> # User smonteith >>>>>> # Date 1498059859 -3600 >>>>>> # Wed Jun 21 16:44:19 2017 +0100 >>>>>> # Node ID 75cda45229ca989faf3e8ba83f45ccb951b1bb8f >>>>>> # Parent 33d0a6d64b82f5ca23b7b1eaadf74317b2204ecf >>>>>> Fix HelpTree field access >>>>>> >>>>>> diff -r 33d0a6d64b82 -r 75cda45229ca >>>>>> src/share/classes/com/sun/javatest/regtest/tool/Help.java >>>>>> --- a/src/share/classes/com/sun/javatest/regtest/tool/Help.java Mon >>>>>> Jun 12 14:35:46 2017 -0700 >>>>>> +++ b/src/share/classes/com/sun/javatest/regtest/tool/Help.java Wed >>>>>> Jun 21 16:44:19 2017 +0100 >>>>>> @@ -329,7 +329,7 @@ >>>>>> try{ >>>>>> Field f = >>>>>> HelpTree.class.getDeclaredField("nodeComparator"); >>>>>> f.setAccessible(true); >>>>>> - f.set(null, new NodeComparator()); >>>>>> + f.set(commandHelpTree, new NodeComparator()); >>>>>> } catch (IllegalAccessException | IllegalArgumentException | >>>>>> NoSuchFieldException | SecurityException ignore) { >>>>>> } >>>>>> >>>>>> On 21 June 2017 at 16:30, Jonathan Gibbons >>>>>> >>>>>> wrote: >>>>>>> Yes, jtreg has not yet been updated to be compatible with JTHarness >>>>>>> 5.0. >>>>>>> >>>>>>> -- Jon >>>>>>> >>>>>>> >>>>>>> >>>>>>> On 6/21/17 8:15 AM, Stuart Monteith wrote: >>>>>>>> Hi, >>>>>>>> I just noticed I have hit this problem. >>>>>>>> >>>>>>>> HelpTree in jtharness-5.0.jar has this: >>>>>>>> private java.util.Comparator nodeComparator; >>>>>>>> Whereas in jtharness-4.6.jar it has: >>>>>>>> private static java.util.Comparator nodeComparator; >>>>>>>> >>>>>>>> i.e. the nodeComparator field is no longer a static field. >>>>>>>> >>>>>>>> This happened since adopt-openjdk started building with this: >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> https://adopt-openjdk.ci.cloudbees.com/job/jtharness/lastSuccessfulBuild/artifact/jtharness-5.0.tar.gz >>>>>>>> >>>>>>>> BR, >>>>>>>> Stuart >>>>>>>> >>>>>>>> >>>>>>>> On 9 June 2017 at 20:23, Jonathan Gibbons >>>>>>>> >>>>>>>> wrote: >>>>>>>>> From a brief examination of the stacktrace, it looks like you >>>>>>>>> have >>>>>>>>> now-incompatible versions of jtharness and jtreg. >>>>>>>>> >>>>>>>>> I will make the jtreg code more robust. >>>>>>>>> >>>>>>>>> -- Jon >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On 6/9/17 8:01 AM, Mani Sarkar wrote: >>>>>>>>>> Hi Jon, >>>>>>>>>> >>>>>>>>>> Any suggestions on how to resolve the below, apologies if I have >>>>>>>>>> missed >>>>>>>>>> out >>>>>>>>>> any communication with regards to the below. >>>>>>>>>> >>>>>>>>>> Thanks. >>>>>>>>>> >>>>>>>>>> Cheers, >>>>>>>>>> Mani >>>>>>>>>> >>>>>>>>>> On Fri, 2 Jun 2017 at 17:04 Mani Sarkar >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> Hi all, >>>>>>>>>>> >>>>>>>>>>> Recently jtreg stopped building on our build farm, checking the >>>>>>>>>>> logs >>>>>>>>>>> we >>>>>>>>>>> got (this version uses jdk9 as one of the jdks during the build >>>>>>>>>>> process): >>>>>>>>>>> >>>>>>>>>>> -compile-jtreg.usage: >>>>>>>>>>> [mkdir] Created dir: >>>>>>>>>>> /scratch/jenkins/workspace/jtreg/build/jtreg >>>>>>>>>>> [java] Executing >>>>>>>>>>> '/opt/java/sdk/Oracle/x86_64/jdk1.8.0_102/jre/bin/java' with >>>>>>>>>>> arguments: >>>>>>>>>>> [java] '-Dprogram=jtreg' >>>>>>>>>>> [java] '-classpath' >>>>>>>>>>> [java] >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> '/scratch/jenkins/workspace/jtreg/build/classes:/scratch/jenkins/workspace/jtreg/jtharness/lib/javatest.jar:/scratch/jenkins/workspace/jtreg/junit/junit.jar:/scratch/jenkins/workspace/jtreg/jh2.0/javahelp/lib/jh.jar' >>>>>>>>>>> [java] 'com.sun.javatest.regtest.Main' >>>>>>>>>>> [java] '-help' >>>>>>>>>>> [java] 'all' >>>>>>>>>>> [java] >>>>>>>>>>> [java] The ' characters around the executable and >>>>>>>>>>> arguments >>>>>>>>>>> are >>>>>>>>>>> [java] not part of the command. >>>>>>>>>>> [java] Output redirected to >>>>>>>>>>> /scratch/jenkins/workspace/jtreg/build/jtreg/usage.txt >>>>>>>>>>> >>>>>>>>>>> BUILD FAILED >>>>>>>>>>> /scratch/jenkins/workspace/jtreg/make/build.xml:192: Java >>>>>>>>>>> returned: >>>>>>>>>>> 6 >>>>>>>>>>> at >>>>>>>>>>> org.apache.tools.ant.taskdefs.Java.execute(Java.java:111) >>>>>>>>>>> at >>>>>>>>>>> >>>>>>>>>>> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292) >>>>>>>>>>> at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown >>>>>>>>>>> Source) >>>>>>>>>>> at >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >>>>>>>>>>> at java.lang.reflect.Method.invoke(Method.java:498) >>>>>>>>>>> at >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) >>>>>>>>>>> at org.apache.tools.ant.Task.perform(Task.java:348) >>>>>>>>>>> at org.apache.tools.ant.Target.execute(Target.java:435) >>>>>>>>>>> at >>>>>>>>>>> org.apache.tools.ant.Target.performTasks(Target.java:456) >>>>>>>>>>> at >>>>>>>>>>> >>>>>>>>>>> org.apache.tools.ant.Project.executeSortedTargets(Project.java:1393) >>>>>>>>>>> at >>>>>>>>>>> org.apache.tools.ant.Project.executeTarget(Project.java:1364) >>>>>>>>>>> at >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) >>>>>>>>>>> at >>>>>>>>>>> org.apache.tools.ant.Project.executeTargets(Project.java:1248) >>>>>>>>>>> at org.apache.tools.ant.Main.runBuild(Main.java:851) >>>>>>>>>>> at org.apache.tools.ant.Main.startAnt(Main.java:235) >>>>>>>>>>> at >>>>>>>>>>> org.apache.tools.ant.launch.Launcher.run(Launcher.java:280) >>>>>>>>>>> at >>>>>>>>>>> org.apache.tools.ant.launch.Launcher.main(Launcher.java:109) >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Checking the usage.txt created in we see: >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Error: Unexpected exception occurred! >>>>>>>>>>> java.lang.NullPointerException >>>>>>>>>>> java.lang.NullPointerException >>>>>>>>>>> at >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> sun.reflect.UnsafeFieldAccessorImpl.ensureObj(UnsafeFieldAccessorImpl.java:57) >>>>>>>>>>> at >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> sun.reflect.UnsafeObjectFieldAccessorImpl.set(UnsafeObjectFieldAccessorImpl.java:75) >>>>>>>>>>> at java.lang.reflect.Field.set(Field.java:764) >>>>>>>>>>> at >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> com.sun.javatest.regtest.tool.Help.showCommandLineHelp(Help.java:332) >>>>>>>>>>> at >>>>>>>>>>> com.sun.javatest.regtest.tool.Help.show(Help.java:168) >>>>>>>>>>> at >>>>>>>>>>> com.sun.javatest.regtest.tool.Tool.run(Tool.java:960) >>>>>>>>>>> at >>>>>>>>>>> com.sun.javatest.regtest.tool.Tool.run(Tool.java:953) >>>>>>>>>>> at >>>>>>>>>>> com.sun.javatest.regtest.tool.Tool.main(Tool.java:133) >>>>>>>>>>> at com.sun.javatest.regtest.Main.main(Main.java:58) >>>>>>>>>>> >>>>>>>>>>> Logs can be found at >>>>>>>>>>> https://adopt-openjdk.ci.cloudbees.com/job/jtreg/843/consoleFull >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Any ideas whats leading to it? >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Cheers, >>>>>>>>>>> >>>>>>>>>>> Mani >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> @theNeomatrix369 * | **Blog >>>>>>>>>>> ** | *LJC Associate & LJC >>>>>>>>>>> Advocate >>>>>>>>>>> (@adoptopenjdk & @adoptajsr programs) >>>>>>>>>>> *Meet-a-Project - *MutabilityDetector >>>>>>>>>>> * | **Bitbucket >>>>>>>>>>> * * | **Github >>>>>>>>>>> * * | **LinkedIn >>>>>>>>>>> * >>>>>>>>>>> *Come to Devoxx UK 2017:* http://www.devoxx.co.uk/ >>>>>>>>>>> >>>>>>>>>>> *Don't chase success, rather aim for "Excellence", and success >>>>>>>>>>> will >>>>>>>>>>> come >>>>>>>>>>> chasing after you!* >>>>>>>>>>> From jonathan.gibbons at oracle.com Fri Jun 23 20:54:58 2017 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 23 Jun 2017 20:54:58 +0000 Subject: hg: code-tools/jtreg: 7901997: remove transition support for --patch-module Message-ID: <201706232054.v5NKsw8A026800@aojmv0008.oracle.com> Changeset: e3cf307d8912 Author: jjg Date: 2017-06-23 13:51 -0700 URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/e3cf307d8912 7901997: remove transition support for --patch-module ! src/share/classes/com/sun/javatest/regtest/config/RegressionTestSuite.java ! src/share/classes/com/sun/javatest/regtest/config/TestProperties.java ! src/share/classes/com/sun/javatest/regtest/exec/CompileAction.java ! src/share/classes/com/sun/javatest/regtest/exec/RegressionScript.java ! src/share/doc/javatest/regtest/tag-spec.html From stuart.monteith at linaro.org Mon Jun 26 15:45:29 2017 From: stuart.monteith at linaro.org (Stuart Monteith) Date: Mon, 26 Jun 2017 16:45:29 +0100 Subject: Jtreg build is failing In-Reply-To: <48f2df99-a77d-954a-283a-0c2c5c6e2538@oracle.com> References: <2eabe5f4-cf0d-5eb0-2b32-1246e52a9cf5@oracle.com> <3297199d-49c9-c281-7b3a-23dd6b81e2ec@oracle.com> <594A9EFF.5030007@oracle.com> <594AAC13.1070808@oracle.com> <48f2df99-a77d-954a-283a-0c2c5c6e2538@oracle.com> Message-ID: Hi Jonathan, The testcases were failing as they were trying to match the TZ against the expected value and failing. The tests don't seem to be clever enough to exclude tests if their version particular JDK environment variable is unset. It puts us in an awkward position, as not every platform has a port for the tested versions - on AArch64 there hasn't been JDK6 release. BR, Stuart On 22 June 2017 at 15:35, Jonathan Gibbons wrote: > Thanks for the followup. > > Do you know why you had to unset TZ? > > You should not need the settings for older JDKs unless you are running the > tests, and there are some tests that may require the JDKs to be distinct, so > you may get test failures if you set the locations for older JDKs to > unexpected values. > > -- Jon > > > > On 6/22/17 6:46 AM, Stuart Monteith wrote: >> >> Thanks Jonathan, >> I had misplaced jcommander between the build and the test. >> >> There are some issues setting up the environment, so far I have to do >> the following: >> >> export LANG=en_US.UTF-8 >> unset TZ >> export J2SEHOME=$JDK17HOME >> export JDK18HOME=$JDK17HOME >> export JDK16HOME=$JDK18HOME >> >> But I think we're mostly good now. >> >> BR, >> Stuart >> >> On 21 June 2017 at 18:25, Jonathan Gibbons >> wrote: >>> >>> Stuart, >>> >>> I've not dug all the way down to the root cause of your issue, but I can >>> confirm that the primary significant different between your test results >>> in >>> the Basic.othervm tests and the test results I have locally (which pass) >>> is >>> related to the JCommander library. >>> >>> The following lines at the end of Basic.othervm/report/text/summary.txt >>> seem >>> to be the appropriate ones to look at: >>> >>> testng/group/p/q/ExtraComment.java Failed. Execution failed: `main' >>> threw >>> exception: java.lang.NoClassDefFoundError: >>> com/beust/jcommander/ParameterException >>> testng/group/p/q/ExtraComment.java#1 Error. Multiple test descriptions >>> not >>> allowed >>> testng/group/p/q/Fail.java Failed. Execution failed: `main' >>> threw >>> exception: java.lang.NoClassDefFoundError: >>> com/beust/jcommander/ParameterException >>> testng/group/p/q/Pass.java Failed. Execution failed: `main' >>> threw >>> exception: java.lang.NoClassDefFoundError: >>> com/beust/jcommander/ParameterException >>> testng/singles/Fail.java Failed. Execution failed: `main' >>> threw >>> exception: java.lang.NoClassDefFoundError: >>> com/beust/jcommander/ParameterException >>> testng/singles/Pass.java Failed. Execution failed: `main' >>> threw >>> exception: java.lang.NoClassDefFoundError: >>> com/beust/jcommander/ParameterException >>> >>> You can ignore the second line ... that is intentional ... the Basic* >>> tests >>> have many intentional errors, as part of testing jtreg's ability to >>> correctly detect errors. But the messages about not finding >>> ParameterException are significant. >>> >>> -- Jon >>> >>> >>> >>> On 06/21/2017 10:00 AM, Stuart Monteith wrote: >>>> >>>> The versions are (the ones I'm using, then the recommended versions >>>> from the README, then from the website): >>>> asmtools-6.0 - ? - 6.0 or better >>>> jtharness-5.0 - 4.1.3 - jtharness 4.6 or better >>>> junit-4.8.2 - junit 4 - JUnit 4.1.0 >>>> testng-6.9.5 - ? - 6.9.5 >>>> jcommander-1.48 - ? - ? >>>> javahelp-2.0.05 - 2.0_01 - e.g. javahelp2.0_05.zip >>>> >>>> There are some disparities. I've not investigated much to see why they >>>> are failing. >>>> >>>> I've put the build files here: >>>> >>>> >>>> >>>> http://people.linaro.org/~stuart.monteith/jtreg-build/Basic.othervm/report/ >>>> you can look around from here: >>>> http://people.linaro.org/~stuart.monteith/jtreg-build/ >>>> >>>> Thanks, >>>> Stuart >>>> >>>> On 21 June 2017 at 17:29, Jonathan Gibbons >>>> wrote: >>>>> >>>>> Stuart, >>>>> >>>>> Your fix for the HelpTree problem looks like the fix I would >>>>> anticipate. >>>>> I'll try it out locally and run the tests. >>>>> >>>>> You don't give enough info for me to diagnose why the tests are not >>>>> running for you. Are you using the recommended version of other >>>>> libraries, >>>>> and not necessarily the latest version? (i.e. the version we recommend >>>>> for >>>>> use with jtreg) >>>>> >>>>> Some other folk are looking at making the overall jtreg build easier to >>>>> configure. >>>>> That work is ongoing. >>>>> >>>>> -- Jon >>>>> >>>>> >>>>> On 06/21/2017 09:11 AM, Stuart Monteith wrote: >>>>>> >>>>>> Ok, I'm not seeing any better test results with the old jtharness.jar >>>>>> version. >>>>>> >>>>>> Also, "f.set(commandHelpTree, new NodeComparator()) " should be >>>>>> backwards compatible with the static field in the old version of >>>>>> jtharness, as "commandHelpTree" will just be ignored. >>>>>> >>>>>> BR, >>>>>> Stuart >>>>>> >>>>>> On 21 June 2017 at 16:48, Stuart Monteith >>>>>> wrote: >>>>>>> >>>>>>> The immediate problem is solved with the patch below (with no regards >>>>>>> to backwards compatibility). >>>>>>> >>>>>>> I'm note getting clean test runs though. I see: >>>>>>> >>>>>>> TRT.finished(), attempting cache compress...TRT.finished(), >>>>>>> requesting >>>>>>> cache flush...Test results: passed: 89; failed: 47; error: 87 >>>>>>> Report written to >>>>>>> >>>>>>> >>>>>>> >>>>>>> /home/stumon01/jtreg-local/jtreg/build/Basic.othervm/report/html/report.html >>>>>>> Results written to >>>>>>> /home/stumon01/jtreg-local/jtreg/build/Basic.othervm/work >>>>>>> Error: Some tests failed or other problems occurred. >>>>>>> ok...batch execution >>>>>>> checking selection according to previous state >>>>>>> state: 0 (passed) >>>>>>> expected number of tests: 92 >>>>>>> found: 89 >>>>>>> wrong number of tests found >>>>>>> java.lang.Error: wrong number of tests found >>>>>>> at Basic.failed(Basic.java:346) >>>>>>> at Basic.checkPreviousStateSelection(Basic.java:272) >>>>>>> at Basic.(Basic.java:115) >>>>>>> at Basic.main(Basic.java:50) >>>>>>> ../test/basic/Basic.gmk:78: recipe for target >>>>>>> '../build/Basic.othervm.ok' >>>>>>> failed >>>>>>> make: *** [../build/Basic.othervm.ok] Error 1 >>>>>>> make: Leaving directory '/home/stumon01/jtreg-local/jtreg/make' >>>>>>> >>>>>>> >>>>>>> I've not compared this against running with jtharness-4.6.jar. >>>>>>> >>>>>>> I don't suppose you're looking additional issues? >>>>>>> >>>>>>> BR, >>>>>>> Stuart >>>>>>> >>>>>>> >>>>>>> # HG changeset patch >>>>>>> # User smonteith >>>>>>> # Date 1498059859 -3600 >>>>>>> # Wed Jun 21 16:44:19 2017 +0100 >>>>>>> # Node ID 75cda45229ca989faf3e8ba83f45ccb951b1bb8f >>>>>>> # Parent 33d0a6d64b82f5ca23b7b1eaadf74317b2204ecf >>>>>>> Fix HelpTree field access >>>>>>> >>>>>>> diff -r 33d0a6d64b82 -r 75cda45229ca >>>>>>> src/share/classes/com/sun/javatest/regtest/tool/Help.java >>>>>>> --- a/src/share/classes/com/sun/javatest/regtest/tool/Help.java Mon >>>>>>> Jun 12 14:35:46 2017 -0700 >>>>>>> +++ b/src/share/classes/com/sun/javatest/regtest/tool/Help.java Wed >>>>>>> Jun 21 16:44:19 2017 +0100 >>>>>>> @@ -329,7 +329,7 @@ >>>>>>> try{ >>>>>>> Field f = >>>>>>> HelpTree.class.getDeclaredField("nodeComparator"); >>>>>>> f.setAccessible(true); >>>>>>> - f.set(null, new NodeComparator()); >>>>>>> + f.set(commandHelpTree, new NodeComparator()); >>>>>>> } catch (IllegalAccessException | >>>>>>> IllegalArgumentException | >>>>>>> NoSuchFieldException | SecurityException ignore) { >>>>>>> } >>>>>>> >>>>>>> On 21 June 2017 at 16:30, Jonathan Gibbons >>>>>>> >>>>>>> wrote: >>>>>>>> >>>>>>>> Yes, jtreg has not yet been updated to be compatible with JTHarness >>>>>>>> 5.0. >>>>>>>> >>>>>>>> -- Jon >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On 6/21/17 8:15 AM, Stuart Monteith wrote: >>>>>>>>> >>>>>>>>> Hi, >>>>>>>>> I just noticed I have hit this problem. >>>>>>>>> >>>>>>>>> HelpTree in jtharness-5.0.jar has this: >>>>>>>>> private java.util.Comparator nodeComparator; >>>>>>>>> Whereas in jtharness-4.6.jar it has: >>>>>>>>> private static java.util.Comparator nodeComparator; >>>>>>>>> >>>>>>>>> i.e. the nodeComparator field is no longer a static field. >>>>>>>>> >>>>>>>>> This happened since adopt-openjdk started building with this: >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> https://adopt-openjdk.ci.cloudbees.com/job/jtharness/lastSuccessfulBuild/artifact/jtharness-5.0.tar.gz >>>>>>>>> >>>>>>>>> BR, >>>>>>>>> Stuart >>>>>>>>> >>>>>>>>> >>>>>>>>> On 9 June 2017 at 20:23, Jonathan Gibbons >>>>>>>>> >>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>> From a brief examination of the stacktrace, it looks like you >>>>>>>>>> have >>>>>>>>>> now-incompatible versions of jtharness and jtreg. >>>>>>>>>> >>>>>>>>>> I will make the jtreg code more robust. >>>>>>>>>> >>>>>>>>>> -- Jon >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On 6/9/17 8:01 AM, Mani Sarkar wrote: >>>>>>>>>>> >>>>>>>>>>> Hi Jon, >>>>>>>>>>> >>>>>>>>>>> Any suggestions on how to resolve the below, apologies if I have >>>>>>>>>>> missed >>>>>>>>>>> out >>>>>>>>>>> any communication with regards to the below. >>>>>>>>>>> >>>>>>>>>>> Thanks. >>>>>>>>>>> >>>>>>>>>>> Cheers, >>>>>>>>>>> Mani >>>>>>>>>>> >>>>>>>>>>> On Fri, 2 Jun 2017 at 17:04 Mani Sarkar >>>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi all, >>>>>>>>>>>> >>>>>>>>>>>> Recently jtreg stopped building on our build farm, checking the >>>>>>>>>>>> logs >>>>>>>>>>>> we >>>>>>>>>>>> got (this version uses jdk9 as one of the jdks during the build >>>>>>>>>>>> process): >>>>>>>>>>>> >>>>>>>>>>>> -compile-jtreg.usage: >>>>>>>>>>>> [mkdir] Created dir: >>>>>>>>>>>> /scratch/jenkins/workspace/jtreg/build/jtreg >>>>>>>>>>>> [java] Executing >>>>>>>>>>>> '/opt/java/sdk/Oracle/x86_64/jdk1.8.0_102/jre/bin/java' with >>>>>>>>>>>> arguments: >>>>>>>>>>>> [java] '-Dprogram=jtreg' >>>>>>>>>>>> [java] '-classpath' >>>>>>>>>>>> [java] >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> '/scratch/jenkins/workspace/jtreg/build/classes:/scratch/jenkins/workspace/jtreg/jtharness/lib/javatest.jar:/scratch/jenkins/workspace/jtreg/junit/junit.jar:/scratch/jenkins/workspace/jtreg/jh2.0/javahelp/lib/jh.jar' >>>>>>>>>>>> [java] 'com.sun.javatest.regtest.Main' >>>>>>>>>>>> [java] '-help' >>>>>>>>>>>> [java] 'all' >>>>>>>>>>>> [java] >>>>>>>>>>>> [java] The ' characters around the executable and >>>>>>>>>>>> arguments >>>>>>>>>>>> are >>>>>>>>>>>> [java] not part of the command. >>>>>>>>>>>> [java] Output redirected to >>>>>>>>>>>> /scratch/jenkins/workspace/jtreg/build/jtreg/usage.txt >>>>>>>>>>>> >>>>>>>>>>>> BUILD FAILED >>>>>>>>>>>> /scratch/jenkins/workspace/jtreg/make/build.xml:192: Java >>>>>>>>>>>> returned: >>>>>>>>>>>> 6 >>>>>>>>>>>> at >>>>>>>>>>>> org.apache.tools.ant.taskdefs.Java.execute(Java.java:111) >>>>>>>>>>>> at >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292) >>>>>>>>>>>> at >>>>>>>>>>>> sun.reflect.GeneratedMethodAccessor4.invoke(Unknown >>>>>>>>>>>> Source) >>>>>>>>>>>> at >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >>>>>>>>>>>> at java.lang.reflect.Method.invoke(Method.java:498) >>>>>>>>>>>> at >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) >>>>>>>>>>>> at org.apache.tools.ant.Task.perform(Task.java:348) >>>>>>>>>>>> at >>>>>>>>>>>> org.apache.tools.ant.Target.execute(Target.java:435) >>>>>>>>>>>> at >>>>>>>>>>>> org.apache.tools.ant.Target.performTasks(Target.java:456) >>>>>>>>>>>> at >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> org.apache.tools.ant.Project.executeSortedTargets(Project.java:1393) >>>>>>>>>>>> at >>>>>>>>>>>> org.apache.tools.ant.Project.executeTarget(Project.java:1364) >>>>>>>>>>>> at >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) >>>>>>>>>>>> at >>>>>>>>>>>> org.apache.tools.ant.Project.executeTargets(Project.java:1248) >>>>>>>>>>>> at org.apache.tools.ant.Main.runBuild(Main.java:851) >>>>>>>>>>>> at org.apache.tools.ant.Main.startAnt(Main.java:235) >>>>>>>>>>>> at >>>>>>>>>>>> org.apache.tools.ant.launch.Launcher.run(Launcher.java:280) >>>>>>>>>>>> at >>>>>>>>>>>> org.apache.tools.ant.launch.Launcher.main(Launcher.java:109) >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Checking the usage.txt created in we see: >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Error: Unexpected exception occurred! >>>>>>>>>>>> java.lang.NullPointerException >>>>>>>>>>>> java.lang.NullPointerException >>>>>>>>>>>> at >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> sun.reflect.UnsafeFieldAccessorImpl.ensureObj(UnsafeFieldAccessorImpl.java:57) >>>>>>>>>>>> at >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> sun.reflect.UnsafeObjectFieldAccessorImpl.set(UnsafeObjectFieldAccessorImpl.java:75) >>>>>>>>>>>> at java.lang.reflect.Field.set(Field.java:764) >>>>>>>>>>>> at >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> com.sun.javatest.regtest.tool.Help.showCommandLineHelp(Help.java:332) >>>>>>>>>>>> at >>>>>>>>>>>> com.sun.javatest.regtest.tool.Help.show(Help.java:168) >>>>>>>>>>>> at >>>>>>>>>>>> com.sun.javatest.regtest.tool.Tool.run(Tool.java:960) >>>>>>>>>>>> at >>>>>>>>>>>> com.sun.javatest.regtest.tool.Tool.run(Tool.java:953) >>>>>>>>>>>> at >>>>>>>>>>>> com.sun.javatest.regtest.tool.Tool.main(Tool.java:133) >>>>>>>>>>>> at com.sun.javatest.regtest.Main.main(Main.java:58) >>>>>>>>>>>> >>>>>>>>>>>> Logs can be found at >>>>>>>>>>>> https://adopt-openjdk.ci.cloudbees.com/job/jtreg/843/consoleFull >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Any ideas whats leading to it? >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Cheers, >>>>>>>>>>>> >>>>>>>>>>>> Mani >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> @theNeomatrix369 * | >>>>>>>>>>>> **Blog >>>>>>>>>>>> ** | *LJC Associate & LJC >>>>>>>>>>>> Advocate >>>>>>>>>>>> (@adoptopenjdk & @adoptajsr programs) >>>>>>>>>>>> *Meet-a-Project - *MutabilityDetector >>>>>>>>>>>> * | **Bitbucket >>>>>>>>>>>> * * | **Github >>>>>>>>>>>> * * | **LinkedIn >>>>>>>>>>>> * >>>>>>>>>>>> *Come to Devoxx UK 2017:* http://www.devoxx.co.uk/ >>>>>>>>>>>> >>>>>>>>>>>> *Don't chase success, rather aim for "Excellence", and success >>>>>>>>>>>> will >>>>>>>>>>>> come >>>>>>>>>>>> chasing after you!* >>>>>>>>>>>> > From jonathan.gibbons at oracle.com Mon Jun 26 15:51:03 2017 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Mon, 26 Jun 2017 08:51:03 -0700 Subject: Jtreg build is failing In-Reply-To: References: <2eabe5f4-cf0d-5eb0-2b32-1246e52a9cf5@oracle.com> <3297199d-49c9-c281-7b3a-23dd6b81e2ec@oracle.com> <594A9EFF.5030007@oracle.com> <594AAC13.1070808@oracle.com> <48f2df99-a77d-954a-283a-0c2c5c6e2538@oracle.com> Message-ID: Stuart, We've started putting ifdefs in place for these tests. I'll look at the TZ issue as well. Previously, not many people outside Oracle were running the tests, which is why this hasn't been a focus before. Chickens and eggs, I guess. -- Jon On 6/26/17 8:45 AM, Stuart Monteith wrote: > Hi Jonathan, > The testcases were failing as they were trying to match the TZ > against the expected value and failing. The tests don't seem to be > clever enough to exclude tests if their version particular JDK > environment variable is unset. It puts us in an awkward position, as > not every platform has a port for the tested versions - on AArch64 > there hasn't been JDK6 release. > > > BR, > Stuart > > On 22 June 2017 at 15:35, Jonathan Gibbons wrote: >> Thanks for the followup. >> >> Do you know why you had to unset TZ? >> >> You should not need the settings for older JDKs unless you are running the >> tests, and there are some tests that may require the JDKs to be distinct, so >> you may get test failures if you set the locations for older JDKs to >> unexpected values. >> >> -- Jon >> >> >> >> On 6/22/17 6:46 AM, Stuart Monteith wrote: >>> Thanks Jonathan, >>> I had misplaced jcommander between the build and the test. >>> >>> There are some issues setting up the environment, so far I have to do >>> the following: >>> >>> export LANG=en_US.UTF-8 >>> unset TZ >>> export J2SEHOME=$JDK17HOME >>> export JDK18HOME=$JDK17HOME >>> export JDK16HOME=$JDK18HOME >>> >>> But I think we're mostly good now. >>> >>> BR, >>> Stuart >>> >>> On 21 June 2017 at 18:25, Jonathan Gibbons >>> wrote: >>>> Stuart, >>>> >>>> I've not dug all the way down to the root cause of your issue, but I can >>>> confirm that the primary significant different between your test results >>>> in >>>> the Basic.othervm tests and the test results I have locally (which pass) >>>> is >>>> related to the JCommander library. >>>> >>>> The following lines at the end of Basic.othervm/report/text/summary.txt >>>> seem >>>> to be the appropriate ones to look at: >>>> >>>> testng/group/p/q/ExtraComment.java Failed. Execution failed: `main' >>>> threw >>>> exception: java.lang.NoClassDefFoundError: >>>> com/beust/jcommander/ParameterException >>>> testng/group/p/q/ExtraComment.java#1 Error. Multiple test descriptions >>>> not >>>> allowed >>>> testng/group/p/q/Fail.java Failed. Execution failed: `main' >>>> threw >>>> exception: java.lang.NoClassDefFoundError: >>>> com/beust/jcommander/ParameterException >>>> testng/group/p/q/Pass.java Failed. Execution failed: `main' >>>> threw >>>> exception: java.lang.NoClassDefFoundError: >>>> com/beust/jcommander/ParameterException >>>> testng/singles/Fail.java Failed. Execution failed: `main' >>>> threw >>>> exception: java.lang.NoClassDefFoundError: >>>> com/beust/jcommander/ParameterException >>>> testng/singles/Pass.java Failed. Execution failed: `main' >>>> threw >>>> exception: java.lang.NoClassDefFoundError: >>>> com/beust/jcommander/ParameterException >>>> >>>> You can ignore the second line ... that is intentional ... the Basic* >>>> tests >>>> have many intentional errors, as part of testing jtreg's ability to >>>> correctly detect errors. But the messages about not finding >>>> ParameterException are significant. >>>> >>>> -- Jon >>>> >>>> >>>> >>>> On 06/21/2017 10:00 AM, Stuart Monteith wrote: >>>>> The versions are (the ones I'm using, then the recommended versions >>>>> from the README, then from the website): >>>>> asmtools-6.0 - ? - 6.0 or better >>>>> jtharness-5.0 - 4.1.3 - jtharness 4.6 or better >>>>> junit-4.8.2 - junit 4 - JUnit 4.1.0 >>>>> testng-6.9.5 - ? - 6.9.5 >>>>> jcommander-1.48 - ? - ? >>>>> javahelp-2.0.05 - 2.0_01 - e.g. javahelp2.0_05.zip >>>>> >>>>> There are some disparities. I've not investigated much to see why they >>>>> are failing. >>>>> >>>>> I've put the build files here: >>>>> >>>>> >>>>> >>>>> http://people.linaro.org/~stuart.monteith/jtreg-build/Basic.othervm/report/ >>>>> you can look around from here: >>>>> http://people.linaro.org/~stuart.monteith/jtreg-build/ >>>>> >>>>> Thanks, >>>>> Stuart >>>>> >>>>> On 21 June 2017 at 17:29, Jonathan Gibbons >>>>> wrote: >>>>>> Stuart, >>>>>> >>>>>> Your fix for the HelpTree problem looks like the fix I would >>>>>> anticipate. >>>>>> I'll try it out locally and run the tests. >>>>>> >>>>>> You don't give enough info for me to diagnose why the tests are not >>>>>> running for you. Are you using the recommended version of other >>>>>> libraries, >>>>>> and not necessarily the latest version? (i.e. the version we recommend >>>>>> for >>>>>> use with jtreg) >>>>>> >>>>>> Some other folk are looking at making the overall jtreg build easier to >>>>>> configure. >>>>>> That work is ongoing. >>>>>> >>>>>> -- Jon >>>>>> >>>>>> >>>>>> On 06/21/2017 09:11 AM, Stuart Monteith wrote: >>>>>>> Ok, I'm not seeing any better test results with the old jtharness.jar >>>>>>> version. >>>>>>> >>>>>>> Also, "f.set(commandHelpTree, new NodeComparator()) " should be >>>>>>> backwards compatible with the static field in the old version of >>>>>>> jtharness, as "commandHelpTree" will just be ignored. >>>>>>> >>>>>>> BR, >>>>>>> Stuart >>>>>>> >>>>>>> On 21 June 2017 at 16:48, Stuart Monteith >>>>>>> wrote: >>>>>>>> The immediate problem is solved with the patch below (with no regards >>>>>>>> to backwards compatibility). >>>>>>>> >>>>>>>> I'm note getting clean test runs though. I see: >>>>>>>> >>>>>>>> TRT.finished(), attempting cache compress...TRT.finished(), >>>>>>>> requesting >>>>>>>> cache flush...Test results: passed: 89; failed: 47; error: 87 >>>>>>>> Report written to >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> /home/stumon01/jtreg-local/jtreg/build/Basic.othervm/report/html/report.html >>>>>>>> Results written to >>>>>>>> /home/stumon01/jtreg-local/jtreg/build/Basic.othervm/work >>>>>>>> Error: Some tests failed or other problems occurred. >>>>>>>> ok...batch execution >>>>>>>> checking selection according to previous state >>>>>>>> state: 0 (passed) >>>>>>>> expected number of tests: 92 >>>>>>>> found: 89 >>>>>>>> wrong number of tests found >>>>>>>> java.lang.Error: wrong number of tests found >>>>>>>> at Basic.failed(Basic.java:346) >>>>>>>> at Basic.checkPreviousStateSelection(Basic.java:272) >>>>>>>> at Basic.(Basic.java:115) >>>>>>>> at Basic.main(Basic.java:50) >>>>>>>> ../test/basic/Basic.gmk:78: recipe for target >>>>>>>> '../build/Basic.othervm.ok' >>>>>>>> failed >>>>>>>> make: *** [../build/Basic.othervm.ok] Error 1 >>>>>>>> make: Leaving directory '/home/stumon01/jtreg-local/jtreg/make' >>>>>>>> >>>>>>>> >>>>>>>> I've not compared this against running with jtharness-4.6.jar. >>>>>>>> >>>>>>>> I don't suppose you're looking additional issues? >>>>>>>> >>>>>>>> BR, >>>>>>>> Stuart >>>>>>>> >>>>>>>> >>>>>>>> # HG changeset patch >>>>>>>> # User smonteith >>>>>>>> # Date 1498059859 -3600 >>>>>>>> # Wed Jun 21 16:44:19 2017 +0100 >>>>>>>> # Node ID 75cda45229ca989faf3e8ba83f45ccb951b1bb8f >>>>>>>> # Parent 33d0a6d64b82f5ca23b7b1eaadf74317b2204ecf >>>>>>>> Fix HelpTree field access >>>>>>>> >>>>>>>> diff -r 33d0a6d64b82 -r 75cda45229ca >>>>>>>> src/share/classes/com/sun/javatest/regtest/tool/Help.java >>>>>>>> --- a/src/share/classes/com/sun/javatest/regtest/tool/Help.java Mon >>>>>>>> Jun 12 14:35:46 2017 -0700 >>>>>>>> +++ b/src/share/classes/com/sun/javatest/regtest/tool/Help.java Wed >>>>>>>> Jun 21 16:44:19 2017 +0100 >>>>>>>> @@ -329,7 +329,7 @@ >>>>>>>> try{ >>>>>>>> Field f = >>>>>>>> HelpTree.class.getDeclaredField("nodeComparator"); >>>>>>>> f.setAccessible(true); >>>>>>>> - f.set(null, new NodeComparator()); >>>>>>>> + f.set(commandHelpTree, new NodeComparator()); >>>>>>>> } catch (IllegalAccessException | >>>>>>>> IllegalArgumentException | >>>>>>>> NoSuchFieldException | SecurityException ignore) { >>>>>>>> } >>>>>>>> >>>>>>>> On 21 June 2017 at 16:30, Jonathan Gibbons >>>>>>>> >>>>>>>> wrote: >>>>>>>>> Yes, jtreg has not yet been updated to be compatible with JTHarness >>>>>>>>> 5.0. >>>>>>>>> >>>>>>>>> -- Jon >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On 6/21/17 8:15 AM, Stuart Monteith wrote: >>>>>>>>>> Hi, >>>>>>>>>> I just noticed I have hit this problem. >>>>>>>>>> >>>>>>>>>> HelpTree in jtharness-5.0.jar has this: >>>>>>>>>> private java.util.Comparator nodeComparator; >>>>>>>>>> Whereas in jtharness-4.6.jar it has: >>>>>>>>>> private static java.util.Comparator nodeComparator; >>>>>>>>>> >>>>>>>>>> i.e. the nodeComparator field is no longer a static field. >>>>>>>>>> >>>>>>>>>> This happened since adopt-openjdk started building with this: >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> https://adopt-openjdk.ci.cloudbees.com/job/jtharness/lastSuccessfulBuild/artifact/jtharness-5.0.tar.gz >>>>>>>>>> >>>>>>>>>> BR, >>>>>>>>>> Stuart >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On 9 June 2017 at 20:23, Jonathan Gibbons >>>>>>>>>> >>>>>>>>>> wrote: >>>>>>>>>>> From a brief examination of the stacktrace, it looks like you >>>>>>>>>>> have >>>>>>>>>>> now-incompatible versions of jtharness and jtreg. >>>>>>>>>>> >>>>>>>>>>> I will make the jtreg code more robust. >>>>>>>>>>> >>>>>>>>>>> -- Jon >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On 6/9/17 8:01 AM, Mani Sarkar wrote: >>>>>>>>>>>> Hi Jon, >>>>>>>>>>>> >>>>>>>>>>>> Any suggestions on how to resolve the below, apologies if I have >>>>>>>>>>>> missed >>>>>>>>>>>> out >>>>>>>>>>>> any communication with regards to the below. >>>>>>>>>>>> >>>>>>>>>>>> Thanks. >>>>>>>>>>>> >>>>>>>>>>>> Cheers, >>>>>>>>>>>> Mani >>>>>>>>>>>> >>>>>>>>>>>> On Fri, 2 Jun 2017 at 17:04 Mani Sarkar >>>>>>>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Hi all, >>>>>>>>>>>>> >>>>>>>>>>>>> Recently jtreg stopped building on our build farm, checking the >>>>>>>>>>>>> logs >>>>>>>>>>>>> we >>>>>>>>>>>>> got (this version uses jdk9 as one of the jdks during the build >>>>>>>>>>>>> process): >>>>>>>>>>>>> >>>>>>>>>>>>> -compile-jtreg.usage: >>>>>>>>>>>>> [mkdir] Created dir: >>>>>>>>>>>>> /scratch/jenkins/workspace/jtreg/build/jtreg >>>>>>>>>>>>> [java] Executing >>>>>>>>>>>>> '/opt/java/sdk/Oracle/x86_64/jdk1.8.0_102/jre/bin/java' with >>>>>>>>>>>>> arguments: >>>>>>>>>>>>> [java] '-Dprogram=jtreg' >>>>>>>>>>>>> [java] '-classpath' >>>>>>>>>>>>> [java] >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> '/scratch/jenkins/workspace/jtreg/build/classes:/scratch/jenkins/workspace/jtreg/jtharness/lib/javatest.jar:/scratch/jenkins/workspace/jtreg/junit/junit.jar:/scratch/jenkins/workspace/jtreg/jh2.0/javahelp/lib/jh.jar' >>>>>>>>>>>>> [java] 'com.sun.javatest.regtest.Main' >>>>>>>>>>>>> [java] '-help' >>>>>>>>>>>>> [java] 'all' >>>>>>>>>>>>> [java] >>>>>>>>>>>>> [java] The ' characters around the executable and >>>>>>>>>>>>> arguments >>>>>>>>>>>>> are >>>>>>>>>>>>> [java] not part of the command. >>>>>>>>>>>>> [java] Output redirected to >>>>>>>>>>>>> /scratch/jenkins/workspace/jtreg/build/jtreg/usage.txt >>>>>>>>>>>>> >>>>>>>>>>>>> BUILD FAILED >>>>>>>>>>>>> /scratch/jenkins/workspace/jtreg/make/build.xml:192: Java >>>>>>>>>>>>> returned: >>>>>>>>>>>>> 6 >>>>>>>>>>>>> at >>>>>>>>>>>>> org.apache.tools.ant.taskdefs.Java.execute(Java.java:111) >>>>>>>>>>>>> at >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292) >>>>>>>>>>>>> at >>>>>>>>>>>>> sun.reflect.GeneratedMethodAccessor4.invoke(Unknown >>>>>>>>>>>>> Source) >>>>>>>>>>>>> at >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >>>>>>>>>>>>> at java.lang.reflect.Method.invoke(Method.java:498) >>>>>>>>>>>>> at >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) >>>>>>>>>>>>> at org.apache.tools.ant.Task.perform(Task.java:348) >>>>>>>>>>>>> at >>>>>>>>>>>>> org.apache.tools.ant.Target.execute(Target.java:435) >>>>>>>>>>>>> at >>>>>>>>>>>>> org.apache.tools.ant.Target.performTasks(Target.java:456) >>>>>>>>>>>>> at >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> org.apache.tools.ant.Project.executeSortedTargets(Project.java:1393) >>>>>>>>>>>>> at >>>>>>>>>>>>> org.apache.tools.ant.Project.executeTarget(Project.java:1364) >>>>>>>>>>>>> at >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) >>>>>>>>>>>>> at >>>>>>>>>>>>> org.apache.tools.ant.Project.executeTargets(Project.java:1248) >>>>>>>>>>>>> at org.apache.tools.ant.Main.runBuild(Main.java:851) >>>>>>>>>>>>> at org.apache.tools.ant.Main.startAnt(Main.java:235) >>>>>>>>>>>>> at >>>>>>>>>>>>> org.apache.tools.ant.launch.Launcher.run(Launcher.java:280) >>>>>>>>>>>>> at >>>>>>>>>>>>> org.apache.tools.ant.launch.Launcher.main(Launcher.java:109) >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Checking the usage.txt created in we see: >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Error: Unexpected exception occurred! >>>>>>>>>>>>> java.lang.NullPointerException >>>>>>>>>>>>> java.lang.NullPointerException >>>>>>>>>>>>> at >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> sun.reflect.UnsafeFieldAccessorImpl.ensureObj(UnsafeFieldAccessorImpl.java:57) >>>>>>>>>>>>> at >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> sun.reflect.UnsafeObjectFieldAccessorImpl.set(UnsafeObjectFieldAccessorImpl.java:75) >>>>>>>>>>>>> at java.lang.reflect.Field.set(Field.java:764) >>>>>>>>>>>>> at >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> com.sun.javatest.regtest.tool.Help.showCommandLineHelp(Help.java:332) >>>>>>>>>>>>> at >>>>>>>>>>>>> com.sun.javatest.regtest.tool.Help.show(Help.java:168) >>>>>>>>>>>>> at >>>>>>>>>>>>> com.sun.javatest.regtest.tool.Tool.run(Tool.java:960) >>>>>>>>>>>>> at >>>>>>>>>>>>> com.sun.javatest.regtest.tool.Tool.run(Tool.java:953) >>>>>>>>>>>>> at >>>>>>>>>>>>> com.sun.javatest.regtest.tool.Tool.main(Tool.java:133) >>>>>>>>>>>>> at com.sun.javatest.regtest.Main.main(Main.java:58) >>>>>>>>>>>>> >>>>>>>>>>>>> Logs can be found at >>>>>>>>>>>>> https://adopt-openjdk.ci.cloudbees.com/job/jtreg/843/consoleFull >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Any ideas whats leading to it? >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Cheers, >>>>>>>>>>>>> >>>>>>>>>>>>> Mani >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> -- >>>>>>>>>>>>> @theNeomatrix369 * | >>>>>>>>>>>>> **Blog >>>>>>>>>>>>> ** | *LJC Associate & LJC >>>>>>>>>>>>> Advocate >>>>>>>>>>>>> (@adoptopenjdk & @adoptajsr programs) >>>>>>>>>>>>> *Meet-a-Project - *MutabilityDetector >>>>>>>>>>>>> * | **Bitbucket >>>>>>>>>>>>> * * | **Github >>>>>>>>>>>>> * * | **LinkedIn >>>>>>>>>>>>> * >>>>>>>>>>>>> *Come to Devoxx UK 2017:* http://www.devoxx.co.uk/ >>>>>>>>>>>>> >>>>>>>>>>>>> *Don't chase success, rather aim for "Excellence", and success >>>>>>>>>>>>> will >>>>>>>>>>>>> come >>>>>>>>>>>>> chasing after you!* >>>>>>>>>>>>> From jonathan.gibbons at oracle.com Fri Jun 30 18:58:26 2017 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 30 Jun 2017 18:58:26 +0000 Subject: hg: code-tools/jtreg: 7902003: Use unique test.classes directory for each test Message-ID: <201706301858.v5UIwQDL014657@aojmv0008.oracle.com> Changeset: cce0ac75e878 Author: jjg Date: 2017-06-30 11:55 -0700 URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/cce0ac75e878 7902003: Use unique test.classes directory for each test ! src/share/classes/com/sun/javatest/regtest/config/Locations.java ! test/6517916/T6517916.gmk + test/classDirs/ClassDirsTest.gmk + test/classDirs/ClassDirsTest.java + test/classIsolation/ClassIsolationTest.gmk + test/classIsolation/default/TEST.ROOT + test/classIsolation/default/Test1.java + test/classIsolation/default/Test2.java + test/classIsolation/default/Test3.java + test/classIsolation/disable/TEST.ROOT + test/classIsolation/disable/Test1.java + test/classIsolation/disable/Test2.java + test/classIsolation/disable/Test3.java ! test/env/applet/AppletTest.java ! test/env/applet/AppletTest1.html ! test/env/applet/AppletTest2.html ! test/env/applet/AppletTest3.html ! test/env/applet/AppletTest4.html ! test/env/compile/CompileTest.java ! test/env/main/MainTest.java ! test/env/shell/ShellTest.java ! test/env/shell/ShellTest.sh ! test/modlibs/expect-classes.txt ! test/moduleOpens/ModuleOpen.java ! test/moduleOpens/ModuleOpensTest.gmk ! test/rerun/std/AppletTest.agentvm.out ! test/rerun/std/AppletTest.othervm.out ! test/rerun/std/BuildTest.agentvm.out ! test/rerun/std/BuildTest.othervm.out ! test/rerun/std/CleanTest.agentvm.out ! test/rerun/std/CleanTest.othervm.out ! test/rerun/std/CompileTest.agentvm.out ! test/rerun/std/CompileTest.othervm.out ! test/rerun/std/JUnitTest.agentvm.out ! test/rerun/std/JUnitTest.othervm.out ! test/rerun/std/MainTest.agentvm.out ! test/rerun/std/MainTest.othervm.out ! test/rerun/std/ShellTest.agentvm.out ! test/rerun/std/ShellTest.othervm.out ! test/rerun/std/TestNGTest.agentvm.out ! test/rerun/std/TestNGTest.othervm.out